[EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u

[Severin Gehwolf]

Hi,

On Fri, 2023-09-15 at 19:31 +0000, Terry Chow (Simba Technologies Inc) wrote:
> Hi Severin,
> 
> I just saw that the 21u backport merged. Thanks again for the help. I also now want to do a backport for 17u.
> 
> The "Fix request" comment for 17u:
> 
> The backport does not cleanly apply to 17u. The following changes were made in these files to resolve conflicts and issues:
>    1. make/modules/jdk.net/Lib.gmk --I updated this script to support building extnet for Windows.
>    2. jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java --I added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions.
> The reason for the backport to 17u is to have keepalive parity with the other OS platforms. Similarly to the 21u backport,  the risk is low as the backported code introduces a new code path that only takes effect when keepalive extended socket options are set on a Windows platform. I manually tested the patch and Tier 1 tests were ran and they're passing. No new tests were added as there are existing tests in 17u that cover this scenario. URL to intended backport PR: Backport f3ade388dac0b882e671462caa762138f44817fb · tkyc/jdk17u-dev at 7c75b9d (github.com).

Please create a backport PR for jdk17u-dev and use the new Skara
tooling for the approval process. It should handle the "Fix Request"
comment for you with the "/approval" command[1].

Thanks,
Severin

[1] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval