[jdk17u-dev] RFR: 8313322: RISC-V: implement MD5 intrinsic [v2]

Fei Yang fyang at openjdk.org
Wed Sep 20 03:18:51 UTC 2023


On Thu, 14 Sep 2023 12:29:30 GMT, Ilya Gavrilin <igavrilin at openjdk.org> wrote:

>> Please review this backport of md5 intrinsics to jdk17u-dev.
>> 
>> Backport is not clean because:
>> 
>> - There was no iterator for `class AbstractRegSet`, as an example `RegSetIterator` from aarch64 used: https://github.com/openjdk/jdk17u-dev/blob/0ddf1ebe3df119be2029b12feee93d0128e7cae0/src/hotspot/cpu/aarch64/register_aarch64.hpp#L379-L421
>> - Method `uint AbstractRegSet::size()` was missing
>> - Also for `size()` method we need `population_count()` function, so included `population_count.hpp` in `register_riscv.hpp`
>> - MD5 generation requires huge `codeBuffer`, with old codeBuffer sizes got error during intrinsic generation, so extended them:
>> 
>>   code_size1: 19000 -> 20000
>>   code_size2: 28000  -> 30000
>
> Ilya Gavrilin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add missing include to register_riscv.hpp

PS: I just realized that this fix is not there in jdk21u. I think this should be backported to jdk21u first. Then we can consider jdk17u-dev backport.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1739#issuecomment-1726820471


More information about the jdk-updates-dev mailing list