[jdk17u-dev] RFR: 8307732: build-test-lib is broken [v2]

Aleksey Shipilev shade at openjdk.org
Wed Sep 27 14:15:24 UTC 2023


On Wed, 27 Sep 2023 14:05:45 GMT, Vishal Chand <duke at openjdk.org> wrote:

>> - This PR backports JDK-8274345, JDK-8303922, JDK-8307732 to jdk17u-dev. The build-test-lib target is broken on jdk17 and is needed to build wb.jar and test-lib.jar.
>> - `make build-test-lib` works as expected after the change.
>
> Vishal Chand has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains three new commits since the last revision:
> 
>  - 8307732: build-test-lib is broken
>    
>    Reviewed-by: erikj, djelinski
>  - 8303922: build-test-lib target is broken
>    
>    Reviewed-by: erikj, jwaters
>  - 8274345: make build-test-lib is broken
>    
>    Reviewed-by: erikj

Aha! So we missed the hunk in [test/lib/jdk/test/lib/hexdump/ASN1Formatter.java](https://github.com/openjdk/jdk17u-dev/pull/1801/files#diff-e1e2d7227c36a4b597376f217cb9e41e351ef6bed60831735460eaf3d5b56e1c), which new PR now has. Very nice!

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1801#issuecomment-1737483623


More information about the jdk-updates-dev mailing list