[jdk11u-dev] RFR: 8310923: Refactor Currency tests to use JUnit [v2]

Lutz Schmidt lucy at openjdk.org
Tue Apr 2 11:03:07 UTC 2024


On Thu, 28 Mar 2024 08:10:53 GMT, Andrew Lu <andrewlu at openjdk.org> wrote:

>> I backport this for parity with 11.0.24-oracle.
>> All Locale constructors change to new Locale("", country) due to JDK-8283698 has not been backported.
>> 
>> test/jdk/java/util/Currency/ValidateISO4217.java
>> due to the https://github.com/openjdk/jdk11u-dev/pull/2532
>> the missing part was backported to this file here
>> 
>> test/jdk/java/util/Currency/CurrencyTest.java
>> due to the private static method was not allowed here such as 'private static Stream<String> validCurrencies()',
>> remove static and add '@TestInstance(TestInstance.Lifecycle.PER_CLASS)'
>
> Andrew Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix

LGTM.

Marked as reviewed by lucy (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2632#pullrequestreview-1973402684
PR Review: https://git.openjdk.org/jdk11u-dev/pull/2632#pullrequestreview-1973403177


More information about the jdk-updates-dev mailing list