[jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address [v2]
Jaikiran Pai
jpai at openjdk.org
Sat Apr 6 08:17:15 UTC 2024
On Mon, 11 Mar 2024 09:40:26 GMT, Varada M <varadam at openjdk.org> wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit [43956686](https://github.com/openjdk/jdk17u-dev/commit/43956686c924658ee2d7866e46ee9f10d9595c35) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository.
>>
>> The commit being backported was authored by Jaikiran Pai on 16 Feb 2024 and was reviewed by Paul Hohensee.
>>
>> Thanks!
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>
> Backport 43956686c924658ee2d7866e46ee9f10d9595c35
The source changes look OK to me and matches the changes that were done in mainline. The test looks OK too. But do note that I haven't run it against JDK 11u to ascertain that the test work as expected. As long as the test fails without the source changes and passes with the source changes, I think this is fine.
I am not involved in JDK update project, so before integrating, please also have this approved by someone who is involved in JDK updates project.
-------------
Marked as reviewed by jpai (no project role).
PR Review: https://git.openjdk.org/jdk11u-dev/pull/2531#pullrequestreview-1984462661
More information about the jdk-updates-dev
mailing list