[jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address [v2]

[Varada M]

On Wed, 10 Apr 2024 06:55:23 GMT, Varada M <varadam at openjdk.org> wrote:

>> The source changes look OK to me and matches the changes that were done in mainline. The test looks OK too. But do note that I haven't run it against JDK 11u to ascertain that the test work as expected. As long as the test fails without the source changes and passes with the source changes, I think this is fine.
>> 
>> I am not involved in JDK update project, so before integrating, please also have this approved by someone who is involved in JDK updates project.
>
> Thank you @jaikiran for reviewing the changes.

> Hi @varada1110 please explain how you addressed the issues that came up in the 17u backport. Also explain how you tested to show the same issues don't surface in 11. Please rerun the GHA tests.
> 
> Also, we updated jtreg in the meantime. Your changes to the test are probably unnecessary now. Please check and undo them if possible.

Hi @GoeLin , initially with the lower jtreg version, org.junit.jupiter.api was not supported and I changed the test to use the supported junit annotations. With the updated jtreg version 7.3, test is passing with the same change made in jdk17u-dev.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2531#issuecomment-2063419294