[jdk17u-dev] RFR: 8289182: NMT: MemTracker::baseline should return void

[Goetz Lindenmaier]

On Thu, 18 Apr 2024 07:43:47 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This backport does not introduce any new feature or bug fixing, but it removes dead code. Before the backport, MemTracker::baseline() always returned true. Now, it returns void and all the conditionals that depended on that result are simplified.
>
> Hi Goetz,
> 
> This is the same logic behind Maria's attempt to port NMT changes to 11, which you blocked. We did not explicitly talk about 17. If you, as maintainer, feel 17 should be feature stable and we should not downport NMT changes, then that is fine with us. In that case, we would abort the attempt to downport any missing NMT changes.

Hi @tstuefe, I think there can be good reasons to backport NMT changes as they can improve analysing issues in 17. But there should always be a reason for each backport.  There should be something 17 profits from. I would assume you have a follow-up that is easier to backport if this one is in?

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2415#issuecomment-2063597418