[jdk17u-dev] RFR: 8319048: Monitor deflation unlink phase prolongs time to safepoint [v2]

Goetz Lindenmaier goetz at openjdk.org
Fri Apr 19 08:05:01 UTC 2024


On Thu, 18 Apr 2024 18:50:30 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Unclean backport to eliminate another safepoint hiccup caused by monitor deflation. The uncleanliness comes mostly from `NULL` vs `nullptr` differences in affected hunks. I chose to accept the new version that uses `nullptr` consistently, even though some `NULL`-s might have been left alone.
>> 
>> I was concerned that we might still have problems with interleaving with end-of-VM monitor deflation. This was one of the minor reasons to do [JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896), but I see that we only do that in `VMThread` when exiting, so we are not actually at risk here.
>> 
>> Additional testing:
>>   - [x] Linux x86_64 server fastdebug, `all` tests pass
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8319048-monitor-deflation-unlink
>  - Backport efc392259c64986bbbe880259e95b09058b9076a

Hi @shipilev, should we backport JDK-8325437 as folllow up?  Or won't this affect 17?

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2309#issuecomment-2066032541


More information about the jdk-updates-dev mailing list