[jdk17u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols [v2]

Lutz Schmidt lucy at openjdk.org
Tue Apr 23 10:11:33 UTC 2024


On Mon, 22 Apr 2024 13:23:49 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This PR contains a backport of [6c0bebccb0092d9726eb89a054e023e92edf7ca6](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6). 
>> 
>> Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```. 
>> 
>> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). 
>> 
>> I've worked around that by removing the dependency to that utility function and checking the operating system with ```System.getProperty("os.name")```. 
>> 
>> Testing: 
>> - [x] Added test case passes 
>> 
>> Thanks!
>
> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into my-backport-8159927
>  - Backport 6c0bebccb0092d9726eb89a054e023e92edf7ca6

LGTM.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2305#pullrequestreview-2016822407


More information about the jdk-updates-dev mailing list