[jdk21u-dev] RFR: 8320061: [nmt] Multiple issues with peak accounting [v3]

Tue Apr 23 11:48:32 UTC 2024

On Tue, 23 Apr 2024 11:35:48 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> María Arias de Reyna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge master
>>  - Backport dc256fbc6490f8163adb286dbb7380c10e5e1e06
>>  - Backport 8647f001bbb804503e8491d10f77aa0f34d66bf2
>
> Superficially, this looks good. @tstuefe should ack as well.
> 
> Have you ran `runtime/NMT` tests with this PR?

> Tests are being run on the github jobs right now. Once they are done I will do the approval command. Thanks @shipilev !

It would be safer to run `runtime/NMT` locally, without relying on GHA to include all of them. Since this PR is modifies the tests, it is expected that you verify all of them still work reliably :)

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/481#issuecomment-2072082562