[jdk17u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v2]

[Goetz Lindenmaier]

On Tue, 23 Apr 2024 14:10:06 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). 
>> 
>> Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```.
>> 
>> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485).
>> 
>> I've worked around that by removing the dependency to that utility function and checking the operating system with System.getProperty("os.name").
>> 
>> Testing: 
>> - [x] Modified test case passes 
>> 
>> Thanks!
>
> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into my-backport-8326591
>  - 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
>    
>    Backport-of: 656cba7af376d6460202591230ac95d2366de9f3
>  - 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
>    
>    Backport-of: 1c7b09bc23ac37f83b9043de35b71bea7e814da5
>  - 8315609: Open source few more swing text/html tests
>    
>    Backport-of: a04c6c1ac663a1eab7d45913940cb6ac0af2c11c
>  - 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
>    
>    Backport-of: 31e26814db5d5ad5018fb6ed2e8160e8a01938ab
>  - 8305874: Open source AWT Key, Text Event related tests
>    
>    Backport-of: d6cf4aa1551df591c7bc75cb8c5e90d57630ca2a
>  - 8187759: Background not refreshed when painting over a transparent JFrame
>    
>    Backport-of: 04d43c435d3ede519df169053dd9d724aa2312eb
>  - 8306634: Open source AWT Event related tests
>    
>    Backport-of: 9ed456fac87f598af7d71f9c0887234a09e10eed
>  - 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
>    
>    Backport-of: bfbc41c1f177c7a2b8e91351ac41eaffaab2d8fc
>  - 8316242: Opensource SwingGraphics manual test
>    
>    Backport-of: a57b9dab6c02c313f3975f47d502dae270c67508
>  - ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/e6d7a7ee...d207bf79

Hi Sonia, 
the usual way would be to use test/lib/jdk/test/lib/Platform.java instead of System.getProperty("os.name").

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2321#issuecomment-2076704334