[jdk17u-ri] RFR: 8297878: KEM: Implementation [v4]

[Andrew John Hughes]

On Thu, 18 Apr 2024 18:09:35 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> This is the KEM API backport to Java SE 17 MR 1.
>> 
>> The `src` files are identical to those in the current `jdk` repo except for the change made to `KEM.java` at https://github.com/openjdk/jdk/commit/59c2aff1edffb66762bbbe5e310913f87953be5b#diff-7bee547996d0de5692181a509bdf509276c7eb9351722580fd6aee7975745e67.
>> 
>> _Update: There are javadoc changes to all the `src` files in following commits._
>> 
>> The `RSA_KEM` code is modified because `DerOutputStream` lacks several methods in JDK 17.
>> 
>> `Proc` is updated like in JDK 21 to support for some internal interop testing. The test files for `Proc` are also backported.
>> 
>> This change does not contain the DHKEM implementation in the original JDK 21 change.
>> 
>> This change also covers JDK-8322971 which fixed a follow-on P3 bug of the initial KEM work.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update tags of inner types

It would be easier to review if [JDK-8322971](https://bugs.openjdk.org/browse/JDK-8322971) and [JDK-8305846](https://bugs.openjdk.org/browse/JDK-8305846): "Support compilation in Proc test utility" were backported separately.  Also, 8322971 seems to be missing from 21u as well.

The changes look correct as far as I can tell. I'm not sure why different copyright years are being used from the original patch, particularly for `Provider.java` where this is the only difference from 8297878.

The other differences (21->17, removal of the implementation, SSL & ECC changes) make sense. I presume the test differences with `getKemImpl` are due to the implementation removal making `KEM.getInstance` unusable?

So Skara correctly recognises this as a backport, the title should be "Backport 6b90b0519e89429300838fa598b2ea9ffda984a2"

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-ri/pull/1#pullrequestreview-2023792700