[jdk11u-dev] RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path

[Goetz Lindenmaier]

On Thu, 25 Apr 2024 15:16:24 GMT, Amos Shi <ashi at openjdk.org> wrote:

>> The backported change does not add the zc argumenht to the call in lin 1436.
>> Can you please explain why you add it?  Originally it was added for larger change JDK-8243254
>
> Hi @GoeLin , 
> - Because in the Line `1436` of the same file, it needs the 3rd parameter `zc` . 
>   - Without this parameter, there will be a compile error. 
> 
> 
> 1436    BasicFileAttributes.class), zc);
> 
> 
> - In the latest `jdk` code, the 3d parameter `zc` has been there already
>   - Well in `jdk11u-dev`, the parameter was not there yet
> 
> - Considering this is an internal `private` class (line `1385`)
>   - So we can add this parameter more safely with current Jira ticket.
> 
> 
> 1385    private static class Key {

Yes, but it is you who added the paramteter zc in line 1436, not the patch you backported. 
The backported patch only `adds builtInFS.getPath()` and changes the line breaks.
So why did you add zc in line 1436? I think you should not add it there, and then you don't need the other additional changes either.

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2647#discussion_r1580511546