[jdk11u-dev] RFR: 5029431: (bf) Add absolute bulk put and get methods

Amos Shi ashi at openjdk.org
Sat Apr 27 19:11:10 UTC 2024


On Sat, 27 Apr 2024 05:48:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Backport of [JDK-5029431](https://bugs.openjdk.org/browse/JDK-5029431)
>> - This PR contains two commits
>> - commit 1: is a clean result of git apply
>> - commit 2: is a manual merge of `Basic.java`, the only change is adding`5029431` to `@bug` section 
>>   - Content of `test/jdk/java/nio/Buffer/Basic.java.rej` as bellow
>>   - It shows the only differences in the `.rej` file bellow is adding `5029431`
>> 
>> 
>> @@ -24,9 +24,9 @@
>>  /* @test
>>   * @summary Unit test for buffers
>>   * @bug 4413135 4414911 4416536 4416562 4418782 4471053 4472779 4490253 4523725
>> - *      4526177 4463011 4660660 4661219 4663521 4782970 4804304 4938424 6231529
>> - *      6221101 6234263 6535542 6591971 6593946 6795561 7190219 7199551 8065556
>> - *      8149469
>> + *      4526177 4463011 4660660 4661219 4663521 4782970 4804304 4938424 5029431
>> + *      6231529 6221101 6234263 6535542 6591971 6593946 6795561 7190219 7199551
>> + *      8065556 8149469
>>   * @modules java.base/java.nio:open
>>   *          java.base/jdk.internal.misc
>>   * @author Mark Reinhold
>> ``` 
>> 
>> 
>> Testing
>> - Local: Test passed on `MaOS 14.4.1`
>>   - `test/jdk/java/nio/Buffer/`: Test results: passed: 11
>> - Pipeline: All checks have passed
>> - Testing Machine:
>
> Adding standard APIs to Java 11 would require a Maintenance Release of JSR 384. Did you mean to backport a change that adds new APIs?

Hi @AlanBateman, Cc. @GoeLin, here is the full story: 

- when we are trying to back port [JDK-8326643](https://bugs.openjdk.org/browse/JDK-8326643) to `jdk11u-dev`, compile errors are occurred:


----------System.err:(130/10006)----------
github.com/dev-8326643-11/test/jdk/javax/net/ssl/TLSv13/EngineOutOfSeqCCS.java:56: error: SSLEngineTemplate() has private access in SSLEngineTemplate
        super();
        ^
github.com/dev-8326643-11/test/jdk/javax/net/ssl/TLSv13/EngineOutOfSeqCCS.java:68: error: cannot find symbol
                sslParams.setNamedGroups(new String[] {"secp384r1"});
                         ^
  symbol:   method setNamedGroups(String[])
  location: variable sslParams of type SSLParameters
...
...
39 errors
result: Failed. Compilation failed: Compilation failed


- It turns out we need to back port [JDK-5029431](https://bugs.openjdk.org/browse/JDK-5029431) and [JDK-5071718](https://bugs.openjdk.org/browse/JDK-5071718) to fix this compile error for `JDK-8326643`

While current `JDK-5029431` PR adding standard API.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2685#issuecomment-2081154444


More information about the jdk-updates-dev mailing list