[jdk11u-dev] RFR: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
Thomas Stuefe
stuefe at openjdk.org
Mon Apr 29 07:38:06 UTC 2024
On Fri, 26 Apr 2024 20:31:01 GMT, Amos Shi <ashi at openjdk.org> wrote:
> Backport of [JDK-8329013](https://bugs.openjdk.org/browse/JDK-8329013)
> - This PR contains two commits
> - commit 1:
> - is the original git apply
> - and the `src/java.base/share/classes/jdk/internal/misc/ThreadTracker.java` file needed by this PR
> - The `ThreadTracker.java` class was added by https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84 , which is pretty big for `Virtual Threads` ([JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161)) and we have no intention to back port this change to Java 11 right now
> - So here we simply copy the current code of `ThreadTracker.java` to `jdk11u-dev`
> - commit 2:
> - Manual merge of `src/java.base/share/classes/jdk/internal/event/EventHelper.java` based on the `EventHelper.java.rej` file. The change to this file can be `considered as clean`.
> - Fix java 11 compile error for `ThreadTracker.java`
>
> Testing
> - Local: Test passed
> - `RecursiveEventHelper.java`: Test results: passed: 1
> - Pipeline: All checks have passed
> - Testing Machine: SAP nightlies passed on `2024-04-28`
> - Automated jtreg test: jtreg_jdk_tier2
> - `jdk/security/logging/RecursiveEventHelper.java`: SUCCESSFUL GitHub 📊⏲ - [2,152 msec]
I don't have time to review this, but kudos for clearly delineating and explaining the delta between this patch and its original. Wish every backporter would do this.
-------------
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2687#issuecomment-2082064338
More information about the jdk-updates-dev
mailing list