[jdk17u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v3]
Sonia Zaldana Calles
szaldana at openjdk.org
Mon Apr 29 15:46:24 UTC 2024
> Hi all,
>
> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439).
>
> Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```.
>
> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485).
>
> I've worked around that by removing the dependency to that utility function and checking the operating system with System.getProperty("os.name").
>
> Testing:
> - [x] Modified test case passes
>
> Thanks!
Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge master
- Merge branch 'openjdk:master' into my-backport-8326591
- Backport 43c6f0b5880899b797fab2f851bd35be1c342439
- Backport 6c0bebccb0092d9726eb89a054e023e92edf7ca6
-------------
Changes:
- all: https://git.openjdk.org/jdk17u-dev/pull/2321/files
- new: https://git.openjdk.org/jdk17u-dev/pull/2321/files/d207bf79..d6349c50
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2321&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2321&range=01-02
Stats: 1186 lines in 38 files changed: 1018 ins; 46 del; 122 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/2321.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2321/head:pull/2321
PR: https://git.openjdk.org/jdk17u-dev/pull/2321
More information about the jdk-updates-dev
mailing list