[jdk11u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v3]

Sonia Zaldana Calles szaldana at openjdk.org
Mon Apr 29 15:55:43 UTC 2024


> Hi all, 
> 
> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). 
> 
> Patch is not clean. Test won't build in 11 because it can't find ```import jdk.internal.util.OperatingSystem```.
> 
> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485).
> 
> I've worked around that by removing the dependency to that utility function and checking the operating system with System.getProperty("os.name").
> 
> Testing: 
> - [x] Modified test case passes 
> 
> Thanks!

Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge master
 - Backport 43c6f0b5880899b797fab2f851bd35be1c342439
 - Backport 6c0bebccb0092d9726eb89a054e023e92edf7ca6

-------------

Changes:
  - all: https://git.openjdk.org/jdk11u-dev/pull/2679/files
  - new: https://git.openjdk.org/jdk11u-dev/pull/2679/files/857623ce..a517e2ee

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2679&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2679&range=01-02

  Stats: 19884 lines in 386 files changed: 13289 ins; 3613 del; 2982 mod
  Patch: https://git.openjdk.org/jdk11u-dev/pull/2679.diff
  Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2679/head:pull/2679

PR: https://git.openjdk.org/jdk11u-dev/pull/2679


More information about the jdk-updates-dev mailing list