From andrewlu at openjdk.org Thu Aug 1 02:20:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:20:32 GMT Subject: [jdk21u-dev] Integrated: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout In-Reply-To: References: Message-ID: <4Ke3vfnT5SOMn0xigYPvbAxmZkEJ1nBEqAz26EwIZIw=.3cb91120-740e-4bd5-a5b4-b57723736dd3@github.com> On Tue, 30 Jul 2024 09:06:29 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: e478a235 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/e478a23583e9d9374f15542d53b167d0b41b2fbe Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout Backport-of: 4e8cbf884ab1eee9c3110712ab62edc706e948ba ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/877 From andrewlu at openjdk.org Thu Aug 1 02:21:38 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:21:38 GMT Subject: [jdk21u-dev] Integrated: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 09:13:51 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 43cb9133 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/43cb91335b1aeb8839f72700136c04dfc30f4de3 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java Backport-of: ed068469f3852aa69a27fe0f267d1828a0e59aec ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/878 From andrewlu at openjdk.org Thu Aug 1 02:21:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:21:39 GMT Subject: [jdk21u-dev] Integrated: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test In-Reply-To: <_nxV8MbwkczurZVSUydxRIq34y2TUsvhRN5Oy5rlUkw=.9a6fb6d4-37cf-4365-8f69-e06bd7777126@github.com> References: <_nxV8MbwkczurZVSUydxRIq34y2TUsvhRN5Oy5rlUkw=.9a6fb6d4-37cf-4365-8f69-e06bd7777126@github.com> Message-ID: On Tue, 30 Jul 2024 09:28:10 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 72395842 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/72395842fc82d5946b45ac1866f5ed78d3837ee4 Stats: 1184 lines in 4 files changed: 408 ins; 322 del; 454 mod 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test Backport-of: 4da28b40f04acc355d86d44cb8d9fa0c5c7829bd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/879 From andrewlu at openjdk.org Thu Aug 1 02:22:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:22:32 GMT Subject: [jdk17u-dev] Integrated: 8317358: G1: Make TestMaxNewSize use createTestJvm In-Reply-To: References: Message-ID: On Tue, 16 Jul 2024 06:30:52 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 15c5caa2 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/15c5caa2f72a5c7581649b0fd8a71c3502a2972f Stats: 33 lines in 1 file changed: 3 ins; 23 del; 7 mod 8317358: G1: Make TestMaxNewSize use createTestJvm Backport-of: 1a098356dd3a157b12c2b5c527e61c8a628bdb2d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2715 From andrewlu at openjdk.org Thu Aug 1 02:22:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:22:40 GMT Subject: [jdk11u-dev] Integrated: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 08:20:17 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: ee57792b Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/ee57792bbae576eeaff1c95873ade2d529d514ce Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java Backport-of: 2659bc449c8f09a1b9a5e336bd437e8427979fb8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2886 From andrewlu at openjdk.org Thu Aug 1 02:22:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:22:43 GMT Subject: [jdk11u-dev] Integrated: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 08:55:01 GMT, Andrew Lu wrote: > I backport this with 17 backport, includes follow-up [JDK-8301189](https://bugs.openjdk.org/browse/JDK-8301189) This pull request has now been integrated. Changeset: d668844b Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/d668844b6622b61cca05fd303c461295f9ca6e10 Stats: 314 lines in 3 files changed: 236 ins; 78 del; 0 mod 8298873: Update IllegalRecordVersion.java for changes to TLS implementation 8301189: validate-source fails after JDK-8298873 Backport-of: 28adafcb524a043eca0fc6e7f9a1bb2a5490d723 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2887 From andrewlu at openjdk.org Thu Aug 1 02:23:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:23:40 GMT Subject: [jdk11u-dev] Integrated: 8255913: Decrease number of iterations in TestMaxCachedBufferSize In-Reply-To: <45Wwe2FkdZOojADMfTPn709Q_50mFflCiYzQ6BnOZ84=.cc5fae6d-6640-467a-a4be-97872b7bb20f@github.com> References: <45Wwe2FkdZOojADMfTPn709Q_50mFflCiYzQ6BnOZ84=.cc5fae6d-6640-467a-a4be-97872b7bb20f@github.com> Message-ID: <2gzajPIGgzKpaIKZSdgVh_-5J8DZNALk1dq-Xr6zurA=.ffcdf1d4-3d3a-4a38-ac25-0eceafdb0d37@github.com> On Tue, 30 Jul 2024 08:14:40 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: 7547abf0 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/7547abf0d3005b9d82b49fc1e6455eb30183d3bb Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8255913: Decrease number of iterations in TestMaxCachedBufferSize Backport-of: d6f094040085fb16306fd1e0eea7d8d7969cdb4d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2885 From andrewlu at openjdk.org Thu Aug 1 02:27:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:27:22 GMT Subject: [jdk11u-dev] RFR: 8317358: G1: Make TestMaxNewSize use createTestJvm [v3] In-Reply-To: References: Message-ID: <72jLyb4EHYsqzlur7wsBCkBsSteNp_BtDteBsAcMn30=.71a8cfe8-6531-47ad-af4c-44b5e1d21f5b@github.com> > I backport this for parity with 11.0.25-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into backport_8317358 - Merge branch 'openjdk:master' into backport_8317358 - Backport 1a098356dd3a157b12c2b5c527e61c8a628bdb2d ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2858/files - new: https://git.openjdk.org/jdk11u-dev/pull/2858/files/a3b693f7..13034269 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2858&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2858&range=01-02 Stats: 388 lines in 12 files changed: 284 ins; 86 del; 18 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2858.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2858/head:pull/2858 PR: https://git.openjdk.org/jdk11u-dev/pull/2858 From andrewlu at openjdk.org Thu Aug 1 02:27:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:27:39 GMT Subject: [jdk17u-dev] Integrated: 8280988: [XWayland] Click on title to request focus test failures In-Reply-To: References: Message-ID: On Tue, 23 Jul 2024 06:56:03 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 68193818 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/68193818b51e190425a34e26d6368b3cb8e3c296 Stats: 259 lines in 5 files changed: 134 ins; 43 del; 82 mod 8280988: [XWayland] Click on title to request focus test failures Backport-of: f6cdcc6f65f2a436906541bb8266e69ded17e2e3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2739 From andrewlu at openjdk.org Thu Aug 1 02:32:04 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:32:04 GMT Subject: [jdk21u-dev] RFR: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport ae9f318fc35eeab497e546ebab9faed6ec774ec5 Changes: https://git.openjdk.org/jdk21u-dev/pull/886/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=886&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336301 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/886.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/886/head:pull/886 PR: https://git.openjdk.org/jdk21u-dev/pull/886 From andrewlu at openjdk.org Thu Aug 1 02:35:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:35:00 GMT Subject: [jdk17u-dev] RFR: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Message-ID: <9IlX43O19NAjLGudgijyGkEZrOixUJz6OiL5Kq12jVM=.70e51266-1ea8-40d9-840f-e6ab5d6b5819@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport ae9f318fc35eeab497e546ebab9faed6ec774ec5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2757/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2757&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336301 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2757.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2757/head:pull/2757 PR: https://git.openjdk.org/jdk17u-dev/pull/2757 From andrewlu at openjdk.org Thu Aug 1 02:35:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:35:05 GMT Subject: [jdk21u-dev] RFR: 8332113: Update nsk.share.Log to be always verbose Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 Changes: https://git.openjdk.org/jdk21u-dev/pull/887/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=887&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332113 Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/887.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/887/head:pull/887 PR: https://git.openjdk.org/jdk21u-dev/pull/887 From andrewlu at openjdk.org Thu Aug 1 02:35:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:35:10 GMT Subject: [jdk17u-dev] RFR: 8332113: Update nsk.share.Log to be always verbose Message-ID: <11W4Z6t9412jJtfIRtu0bCECEjtUhE73IcNV0MxOSfA=.ddc98f08-2951-49b8-a2b6-b7dc58febf55@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2759/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2759&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332113 Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2759.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2759/head:pull/2759 PR: https://git.openjdk.org/jdk17u-dev/pull/2759 From andrewlu at openjdk.org Thu Aug 1 02:35:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:35:15 GMT Subject: [jdk11u-dev] RFR: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport ae9f318fc35eeab497e546ebab9faed6ec774ec5 Changes: https://git.openjdk.org/jdk11u-dev/pull/2889/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2889&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336301 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2889.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2889/head:pull/2889 PR: https://git.openjdk.org/jdk11u-dev/pull/2889 From andrewlu at openjdk.org Thu Aug 1 02:35:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:35:20 GMT Subject: [jdk17u-dev] RFR: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3 Message-ID: <49y4DmD9HEoVF34jz0lk9-PW5Zlg-YNgfLjP8XEFZ4Y=.50574b3d-b4ea-44ec-8b4d-0cad885bccf3@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport d02cb742f79e88c6438ca58a6357fe432fb286cb Changes: https://git.openjdk.org/jdk17u-dev/pull/2758/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2758&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333270 Stats: 16 lines in 2 files changed: 0 ins; 2 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2758.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2758/head:pull/2758 PR: https://git.openjdk.org/jdk17u-dev/pull/2758 From andrewlu at openjdk.org Thu Aug 1 02:37:46 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:37:46 GMT Subject: [jdk11u-dev] RFR: 8332113: Update nsk.share.Log to be always verbose Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport 8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 Changes: https://git.openjdk.org/jdk11u-dev/pull/2890/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2890&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332113 Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2890.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2890/head:pull/2890 PR: https://git.openjdk.org/jdk11u-dev/pull/2890 From andrewlu at openjdk.org Thu Aug 1 02:38:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:38:03 GMT Subject: [jdk17u-dev] RFR: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure Message-ID: <2IjUByY77LOvyoffbfrgP0p39DPf0DBsyReA4lWpSrY=.d0442ad5-c8b8-492a-a699-14ccd9091f67@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 01125fa21b733199d4fe670ecf38b82cd917e242 Changes: https://git.openjdk.org/jdk17u-dev/pull/2760/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2760&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331605 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2760.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2760/head:pull/2760 PR: https://git.openjdk.org/jdk17u-dev/pull/2760 From andrewlu at openjdk.org Thu Aug 1 02:38:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:38:07 GMT Subject: [jdk11u-dev] RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport ab183e437c18b445e9c022a4d74de818d4ccecbe Changes: https://git.openjdk.org/jdk11u-dev/pull/2891/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2891&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328642 Stats: 284 lines in 2 files changed: 46 ins; 211 del; 27 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2891.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2891/head:pull/2891 PR: https://git.openjdk.org/jdk11u-dev/pull/2891 From andrewlu at openjdk.org Thu Aug 1 02:38:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 02:38:15 GMT Subject: [jdk17u-dev] RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport ab183e437c18b445e9c022a4d74de818d4ccecbe Changes: https://git.openjdk.org/jdk17u-dev/pull/2761/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2761&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328642 Stats: 286 lines in 2 files changed: 48 ins; 211 del; 27 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2761.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2761/head:pull/2761 PR: https://git.openjdk.org/jdk17u-dev/pull/2761 From andrewlu at openjdk.org Thu Aug 1 05:56:02 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 05:56:02 GMT Subject: [jdk11u-dev] RFR: 8328300: Convert PrintDialogsTest.java from Applet to main program Message-ID: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport dea94f4445b9389339cf7ca0eef688ca56c17814 Changes: https://git.openjdk.org/jdk11u-dev/pull/2892/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2892&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328300 Stats: 127 lines in 2 files changed: 65 ins; 52 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2892.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2892/head:pull/2892 PR: https://git.openjdk.org/jdk11u-dev/pull/2892 From andrewlu at openjdk.org Thu Aug 1 06:28:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 06:28:48 GMT Subject: [jdk11u-dev] RFR: 8328300: Convert PrintDialogsTest.java from Applet to main program [v2] In-Reply-To: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> References: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> Message-ID: > I backport this for parity with 11.0.25-oracle. > text block modified as not supported. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: Backport dea94f4445b9389339cf7ca0eef688ca56c17814 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2892/files - new: https://git.openjdk.org/jdk11u-dev/pull/2892/files/ebc67d3c..29b371ec Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2892&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2892&range=00-01 Stats: 26 lines in 1 file changed: 0 ins; 1 del; 25 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2892.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2892/head:pull/2892 PR: https://git.openjdk.org/jdk11u-dev/pull/2892 From qxing at openjdk.org Thu Aug 1 06:38:32 2024 From: qxing at openjdk.org (Qizheng Xing) Date: Thu, 1 Aug 2024 06:38:32 GMT Subject: [jdk17u-dev] RFR: 8335536: Fix assertion failure in IdealGraphPrinter when append is true In-Reply-To: References: Message-ID: On Thu, 4 Jul 2024 03:06:59 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [6db4c6a7](https://github.com/openjdk/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein. > > The original patch does not apply cleanly to 17u due to some merge conflicts about creating `xmlStream` with placement `new` expressions. > > Thanks! Hi all, This backport fixes some assertion failures in `IdealGraphPrinter` when debugging on ideal graph, which is low risk. Could someone please review this PR? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2657#issuecomment-2262164056 From sshivang at openjdk.org Thu Aug 1 07:02:02 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Thu, 1 Aug 2024 07:02:02 GMT Subject: [jdk23u] RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect Message-ID: Straight Backport https://mach5.us.oracle.com/mdash/jobs/sshivang-adhoc-20240801-0529-14709657 ------------- Commit messages: - Backport 330e520c1d42d3a9f3e187873dcd8ed7fd561aaf Changes: https://git.openjdk.org/jdk23u/pull/50/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=50&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8028127 Stats: 96 lines in 1 file changed: 60 ins; 5 del; 31 mod Patch: https://git.openjdk.org/jdk23u/pull/50.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/50/head:pull/50 PR: https://git.openjdk.org/jdk23u/pull/50 From mbaesken at openjdk.org Thu Aug 1 07:26:42 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 07:26:42 GMT Subject: [jdk21u-dev] Integrated: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray' In-Reply-To: References: Message-ID: On Mon, 29 Jul 2024 10:29:31 GMT, Matthias Baesken wrote: > 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray' This pull request has now been integrated. Changeset: c3b424e4 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/c3b424e4129c7d163e7feb2ce7a4b0b8f9ca397b Stats: 34 lines in 2 files changed: 9 ins; 15 del; 10 mod 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray' Backport-of: 46b817b7499e74ba8812d38bcce93147ebf93b25 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/873 From mbaesken at openjdk.org Thu Aug 1 08:06:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 08:06:03 GMT Subject: [jdk21u-dev] RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags Message-ID: <1CEkh8DtaBaOq1-m-PVFARxmQlmJp4sn_FcJUnCgbvM=.e826934a-b97d-49ee-bd75-cab6e530de10@github.com> 8335967: "text-decoration: none" does not work with "A" HTML tags ------------- Commit messages: - Backport 374fca0fcbc049f937fa49bb4825edcbbf961f2b Changes: https://git.openjdk.org/jdk21u-dev/pull/888/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=888&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335967 Stats: 132 lines in 2 files changed: 132 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/888.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/888/head:pull/888 PR: https://git.openjdk.org/jdk21u-dev/pull/888 From mbaesken at openjdk.org Thu Aug 1 08:29:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 08:29:34 GMT Subject: [jdk21u-dev] Integrated: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero In-Reply-To: References: Message-ID: On Fri, 26 Jul 2024 12:12:31 GMT, Matthias Baesken wrote: > 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero This pull request has now been integrated. Changeset: a757e62a Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/a757e62a114dd19f3650d3fa0ef5a9c8ff8ee90c Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero Backport-of: 57b6481449612529615484a313d8b85ccf23e287 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/870 From andrewlu at openjdk.org Thu Aug 1 08:45:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 08:45:42 GMT Subject: [jdk17u-dev] RFR: 8317635: Improve GetClassFields test to verify correctness of field order Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 599560a832386d9c61aca24450d6efa65156f663 Changes: https://git.openjdk.org/jdk17u-dev/pull/2762/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2762&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317635 Stats: 176 lines in 3 files changed: 62 ins; 52 del; 62 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2762.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2762/head:pull/2762 PR: https://git.openjdk.org/jdk17u-dev/pull/2762 From andrewlu at openjdk.org Thu Aug 1 08:47:53 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 08:47:53 GMT Subject: [jdk11u-dev] RFR: 8317343: GC: Make TestHeapFreeRatio use createTestJvm Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport c64bd3d6715304accd9a1e3266edd9d3d2353273 Changes: https://git.openjdk.org/jdk11u-dev/pull/2893/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2893&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317343 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2893.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2893/head:pull/2893 PR: https://git.openjdk.org/jdk11u-dev/pull/2893 From andrewlu at openjdk.org Thu Aug 1 08:48:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 08:48:10 GMT Subject: [jdk17u-dev] RFR: 8317343: GC: Make TestHeapFreeRatio use createTestJvm Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport c64bd3d6715304accd9a1e3266edd9d3d2353273 Changes: https://git.openjdk.org/jdk17u-dev/pull/2763/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2763&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317343 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2763.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2763/head:pull/2763 PR: https://git.openjdk.org/jdk17u-dev/pull/2763 From mbaesken at openjdk.org Thu Aug 1 08:49:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 08:49:38 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v6] In-Reply-To: References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Wed, 24 Jul 2024 11:43:11 GMT, SendaoYan wrote: >> Hi, >> >> The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. >> >> And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) >> >> >> Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! > > Signed-off-by: sendaoYan Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2186#pullrequestreview-2212049654 From shade at openjdk.org Thu Aug 1 08:49:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Aug 2024 08:49:39 GMT Subject: [jdk21u-dev] Integrated: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 11:56:49 GMT, Aleksey Shipilev wrote: > Fixes Shenandoah deadlock. There is one minor contextual difference that make the backport unclean: the existence of `ICStubVerifier` that was removed in JDK 23 with [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630). > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 server fastdebug, `all` with `-XX:+UseShenandoahGC` This pull request has now been integrated. Changeset: c2daaa63 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/c2daaa63aba87c801db76478802a87a3bbb326db Stats: 72 lines in 4 files changed: 25 ins; 33 del; 14 mod 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration Backport-of: 2aeb12ec03944c777d617d0be48982fd225b16e7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/880 From andrewlu at openjdk.org Thu Aug 1 08:50:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 08:50:12 GMT Subject: [jdk21u-dev] RFR: 8317112: Add screenshot for Frame/DefaultSizeTest.java Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport a36eaf03afd148581a9d9754f85a652cac84d655 Changes: https://git.openjdk.org/jdk21u-dev/pull/889/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=889&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317112 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/889.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/889/head:pull/889 PR: https://git.openjdk.org/jdk21u-dev/pull/889 From andrewlu at openjdk.org Thu Aug 1 08:50:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 08:50:16 GMT Subject: [jdk17u-dev] RFR: 8317112: Add screenshot for Frame/DefaultSizeTest.java Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport a36eaf03afd148581a9d9754f85a652cac84d655 Changes: https://git.openjdk.org/jdk17u-dev/pull/2764/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2764&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317112 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2764.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2764/head:pull/2764 PR: https://git.openjdk.org/jdk17u-dev/pull/2764 From andrewlu at openjdk.org Thu Aug 1 08:50:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 08:50:20 GMT Subject: [jdk11u-dev] RFR: 8317112: Add screenshot for Frame/DefaultSizeTest.java Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport a36eaf03afd148581a9d9754f85a652cac84d655 Changes: https://git.openjdk.org/jdk11u-dev/pull/2894/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2894&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317112 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2894.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2894/head:pull/2894 PR: https://git.openjdk.org/jdk11u-dev/pull/2894 From clanger at openjdk.org Thu Aug 1 08:56:06 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 1 Aug 2024 08:56:06 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v6] In-Reply-To: References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Wed, 24 Jul 2024 11:43:11 GMT, SendaoYan wrote: >> Hi, >> >> The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. >> >> And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) >> >> >> Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! > > Signed-off-by: sendaoYan We can reproduce the failure, so the exclusion seems ok. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-2262438295 From andrewlu at openjdk.org Thu Aug 1 08:59:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 1 Aug 2024 08:59:41 GMT Subject: [jdk21u-dev] RFR: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3 Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport af7c6af0cc1eb6c42199c05933c7feb032bd6353 Changes: https://git.openjdk.org/jdk21u-dev/pull/890/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=890&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324808 Stats: 1638 lines in 6 files changed: 296 ins; 1069 del; 273 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/890.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/890/head:pull/890 PR: https://git.openjdk.org/jdk21u-dev/pull/890 From shade at openjdk.org Thu Aug 1 09:03:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Aug 2024 09:03:05 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v4] In-Reply-To: References: Message-ID: > The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. > > Additional testing: > - [ ] Linux x86_64 server fastdebug, `all` > - [ ] Linux AArch64 server fastdebug, `all` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Backport 28216aa971ea65938117107542152abd532a5384 - Backport 53c4714aab2e072ba18631875dcaa3b2d5d22243 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/338/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=338&range=03 Stats: 11 lines in 2 files changed: 8 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/338.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/338/head:pull/338 PR: https://git.openjdk.org/jdk21u-dev/pull/338 From syan at openjdk.org Thu Aug 1 09:10:38 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 1 Aug 2024 09:10:38 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v6] In-Reply-To: References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Wed, 24 Jul 2024 11:43:11 GMT, SendaoYan wrote: >> Hi, >> >> The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. >> >> And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) >> >> >> Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! > > Signed-off-by: sendaoYan Thanks all for the review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-2262503781 From syan at openjdk.org Thu Aug 1 09:12:40 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 1 Aug 2024 09:12:40 GMT Subject: [jdk17u-dev] Integrated: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message In-Reply-To: <6eDplsrN0OHJ91jlzi89sq0Nw7Qipnn5kWYHcRSE20Y=.c22f11a1-f434-4dd0-933f-a9ea230dc52b@github.com> References: <6eDplsrN0OHJ91jlzi89sq0Nw7Qipnn5kWYHcRSE20Y=.c22f11a1-f434-4dd0-933f-a9ea230dc52b@github.com> Message-ID: On Tue, 16 Jul 2024 15:15:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [c798316b](https://github.com/openjdk/jdk/commit/c798316bc4cb33fd902f926030d8a0b6870d661a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 28 Jun 2024 and was reviewed by Daniel Fuchs. > > Thanks! This pull request has now been integrated. Changeset: 772c9786 Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/772c9786bd0954b93dfac4f89d92f3fc362bb444 Stats: 11 lines in 1 file changed: 8 ins; 0 del; 3 mod 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message Backport-of: c798316bc4cb33fd902f926030d8a0b6870d661a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2720 From syan at openjdk.org Thu Aug 1 09:34:36 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 1 Aug 2024 09:34:36 GMT Subject: [jdk17u-dev] RFR: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message In-Reply-To: <6eDplsrN0OHJ91jlzi89sq0Nw7Qipnn5kWYHcRSE20Y=.c22f11a1-f434-4dd0-933f-a9ea230dc52b@github.com> References: <6eDplsrN0OHJ91jlzi89sq0Nw7Qipnn5kWYHcRSE20Y=.c22f11a1-f434-4dd0-933f-a9ea230dc52b@github.com> Message-ID: On Tue, 16 Jul 2024 15:15:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [c798316b](https://github.com/openjdk/jdk/commit/c798316bc4cb33fd902f926030d8a0b6870d661a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 28 Jun 2024 and was reviewed by Daniel Fuchs. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2720#issuecomment-2262588263 From duke at openjdk.org Thu Aug 1 09:45:39 2024 From: duke at openjdk.org (duke) Date: Thu, 1 Aug 2024 09:45:39 GMT Subject: [jdk11u-dev] RFR: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java In-Reply-To: References: Message-ID: On Thu, 27 Jun 2024 11:15:11 GMT, Alexander Pepin wrote: > Fix the compilation issue in MimeFormatsTest.java on jdk11 for obvious reason: formatted() is in java.lang.String since jdk15 @sashapepin Your change (at version a5c55f79919198ecabf9b58bb20905ae32ac9193) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2823#issuecomment-2262608896 From duke at openjdk.org Thu Aug 1 09:49:35 2024 From: duke at openjdk.org (Alexander Pepin) Date: Thu, 1 Aug 2024 09:49:35 GMT Subject: [jdk11u-dev] Integrated: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java In-Reply-To: References: Message-ID: On Thu, 27 Jun 2024 11:15:11 GMT, Alexander Pepin wrote: > Fix the compilation issue in MimeFormatsTest.java on jdk11 for obvious reason: formatted() is in java.lang.String since jdk15 This pull request has now been integrated. Changeset: 8ef84821 Author: Alexander Pepin <89089666+sashapepin at users.noreply.github.com> Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk11u-dev/commit/8ef848219bc270b968ca5e9ecdd371973f2debb3 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java Reviewed-by: yan ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2823 From lmao at openjdk.org Thu Aug 1 10:19:34 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 1 Aug 2024 10:19:34 GMT Subject: [jdk21u-dev] RFR: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 08:39:33 GMT, Christoph Langer wrote: > @mmyxym please bring to jdk23u first. Thanks! @RealCLanger It's in 23u now. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/857#issuecomment-2262676866 From mbaesken at openjdk.org Thu Aug 1 11:20:02 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 11:20:02 GMT Subject: [jdk21u-dev] RFR: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510 Message-ID: <89S3h2n4DCy1XhoKX1zmvZ-yRqAkJArt_bjJu5vNygg=.f2546176-7f90-427b-92ad-52dc877dbe87@github.com> 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510 ------------- Commit messages: - Backport 2c1b311f81319cee1af574526a91424c2577b78c Changes: https://git.openjdk.org/jdk21u-dev/pull/891/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=891&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331854 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/891.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/891/head:pull/891 PR: https://git.openjdk.org/jdk21u-dev/pull/891 From duke at openjdk.org Thu Aug 1 12:14:02 2024 From: duke at openjdk.org (Vanitha B P) Date: Thu, 1 Aug 2024 12:14:02 GMT Subject: [jdk23u] RFR: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive Message-ID: It is a clean backport. ------------- Commit messages: - Backport 2c9fd9016f4675448a62380ff2b86533020e690f Changes: https://git.openjdk.org/jdk23u/pull/51/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=51&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336315 Stats: 20 lines in 2 files changed: 5 ins; 1 del; 14 mod Patch: https://git.openjdk.org/jdk23u/pull/51.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/51/head:pull/51 PR: https://git.openjdk.org/jdk23u/pull/51 From mbaesken at openjdk.org Thu Aug 1 13:23:54 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 13:23:54 GMT Subject: [jdk17u-dev] RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags Message-ID: 8335967: "text-decoration: none" does not work with "A" HTML tags ------------- Commit messages: - Backport 374fca0fcbc049f937fa49bb4825edcbbf961f2b Changes: https://git.openjdk.org/jdk17u-dev/pull/2765/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2765&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335967 Stats: 132 lines in 2 files changed: 132 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2765.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2765/head:pull/2765 PR: https://git.openjdk.org/jdk17u-dev/pull/2765 From robm at openjdk.org Thu Aug 1 14:15:39 2024 From: robm at openjdk.org (Rob McKenna) Date: Thu, 1 Aug 2024 14:15:39 GMT Subject: [jdk23u] RFR: 8334166: Enable binary check Message-ID: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> Enable binary check on jdk23u ------------- Commit messages: - Backport a4582a8957d604b50249e1f59679393966456a14 Changes: https://git.openjdk.org/jdk23u/pull/52/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=52&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334166 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/52.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/52/head:pull/52 PR: https://git.openjdk.org/jdk23u/pull/52 From shade at openjdk.org Thu Aug 1 14:24:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Aug 2024 14:24:36 GMT Subject: [jdk23u] RFR: 8334166: Enable binary check In-Reply-To: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> References: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> Message-ID: On Thu, 1 Aug 2024 14:10:29 GMT, Rob McKenna wrote: > Enable binary check on jdk23u I am a bit confused here. Do we really want this for 23u? I understand this for mainline: it gates addition of new changesets that have binaries in them. But for update releases repos, that might effectively block a backport that pick up a changeset done _before_ a related check was introduced in mainline? ------------- PR Review: https://git.openjdk.org/jdk23u/pull/52#pullrequestreview-2212997927 From clanger at openjdk.org Thu Aug 1 14:25:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 1 Aug 2024 14:25:04 GMT Subject: [jdk17u-dev] RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java Message-ID: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> Backport of 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java The wrong location is 17 is not "risv64" as it was in JDK 19 but here it is "riscv" which should be "riscv64" to make jdk.hotspot.agent compile correctly. ------------- Commit messages: - JDK-8283728 Changes: https://git.openjdk.org/jdk17u-dev/pull/2766/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2766&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283728 Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2766.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2766/head:pull/2766 PR: https://git.openjdk.org/jdk17u-dev/pull/2766 From clanger at openjdk.org Thu Aug 1 14:31:48 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 1 Aug 2024 14:31:48 GMT Subject: [jdk17u-dev] RFR: 8337669: [17u] Backport of JDK-8284047 missed to delete a file Message-ID: The backport of JDK-8284047 to jdk17u should have deleted the file test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketBruceForceClose.java but it didn't. Let's do it now. ------------- Commit messages: - JDK-8337669 Changes: https://git.openjdk.org/jdk17u-dev/pull/2767/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2767&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337669 Stats: 102 lines in 1 file changed: 0 ins; 102 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2767.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2767/head:pull/2767 PR: https://git.openjdk.org/jdk17u-dev/pull/2767 From shade at openjdk.org Thu Aug 1 14:32:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Aug 2024 14:32:33 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v2] In-Reply-To: References: <2wBmyrfLiij-rq9PtiE2OEaua9bx6ORiq_nSGod3Vqk=.7f56115f-8aa5-447e-93ba-0c23b947a476@github.com> Message-ID: On Tue, 4 Jun 2024 09:03:39 GMT, Severin Gehwolf wrote: >>> Lets wait on getting this one backported until the compatibility impact wrt. setting the context class loader of a thread in the common pool is addressed. >> >> Checking, @jerboaa, are you good with this going into jdk21u-dev? > > @shipilev Yes, though, a bit uneasy. It fixes the unloading issue. We'll have a close look once EA builds are available. Worst case we'll have to back it out during stabilization closer to the 21.0.5 release. Re-based, re-tested, ready to integrate. Checking with @jerboaa -- go or no-go? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/338#issuecomment-2263224537 From mbaesken at openjdk.org Thu Aug 1 14:37:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 14:37:32 GMT Subject: [jdk17u-dev] RFR: 8337669: [17u] Backport of JDK-8284047 missed to delete a file In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 14:26:16 GMT, Christoph Langer wrote: > The backport of JDK-8284047 to jdk17u should have deleted the file test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketBruceForceClose.java but it didn't. Let's do it now. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2767#pullrequestreview-2213032319 From mbaesken at openjdk.org Thu Aug 1 14:39:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 14:39:33 GMT Subject: [jdk17u-dev] RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java In-Reply-To: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> References: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> Message-ID: <_rX8mIRNslnUQXIza0tLLa0mL7Zgcw8ovJrYMmSBaME=.c2db0bb5-5ba3-4acc-80ad-7ad887328e88@github.com> On Thu, 1 Aug 2024 14:19:49 GMT, Christoph Langer wrote: > Backport of 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java > > The wrong location is 17 is not "risv64" as it was in JDK 19 but here it is "riscv" which should be "riscv64" to make jdk.hotspot.agent compile correctly. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2766#pullrequestreview-2213037919 From shade at openjdk.org Thu Aug 1 14:42:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Aug 2024 14:42:39 GMT Subject: [jdk17u-dev] RFR: 8337669: [17u] Backport of JDK-8284047 missed to delete a file In-Reply-To: References: Message-ID: <01JuCzw8PgeKZaQU_4hLo4ksitj_ZTVEjyRtuTxw35I=.d6d01945-4764-4009-ae29-661700a0bac6@github.com> On Thu, 1 Aug 2024 14:26:16 GMT, Christoph Langer wrote: > The backport of JDK-8284047 to jdk17u should have deleted the file test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketBruceForceClose.java but it didn't. Let's do it now. Honestly, I don't find it very surprising that a file with that typo in its name dies really hard. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2767#pullrequestreview-2213048204 From shade at openjdk.org Thu Aug 1 14:43:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Aug 2024 14:43:31 GMT Subject: [jdk23u] RFR: 8334166: Enable binary check In-Reply-To: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> References: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> Message-ID: On Thu, 1 Aug 2024 14:10:29 GMT, Rob McKenna wrote: > Enable binary check on jdk23u Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/52#pullrequestreview-2213050432 From kcr at openjdk.org Thu Aug 1 14:43:31 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 1 Aug 2024 14:43:31 GMT Subject: [jdk23u] RFR: 8334166: Enable binary check In-Reply-To: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> References: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> Message-ID: On Thu, 1 Aug 2024 14:10:29 GMT, Rob McKenna wrote: > Enable binary check on jdk23u This is merely an informational warning for the benefit of reviewers. It is not blocking, so yes, I do think we want this for jdk23u (and everywhere else we can backport it to). ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/52#issuecomment-2263247163 From shade at openjdk.org Thu Aug 1 14:43:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Aug 2024 14:43:31 GMT Subject: [jdk23u] RFR: 8334166: Enable binary check In-Reply-To: References: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> Message-ID: On Thu, 1 Aug 2024 14:39:53 GMT, Kevin Rushforth wrote: > This is merely an informational warning for the benefit of reviewers. It is not blocking, so yes, I do think we want this for jdk23u (and everywhere else we can backport it to). Oh, it's a warning. Okay then, thanks! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/52#issuecomment-2263249345 From iris at openjdk.org Thu Aug 1 14:48:36 2024 From: iris at openjdk.org (Iris Clark) Date: Thu, 1 Aug 2024 14:48:36 GMT Subject: [jdk23u] RFR: 8334166: Enable binary check In-Reply-To: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> References: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> Message-ID: On Thu, 1 Aug 2024 14:10:29 GMT, Rob McKenna wrote: > Enable binary check on jdk23u Thanks for enabling this review-time warning! ------------- Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/52#pullrequestreview-2213063634 From mbaesken at openjdk.org Thu Aug 1 15:36:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 1 Aug 2024 15:36:03 GMT Subject: [jdk21u-dev] RFR: 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer Message-ID: Backport of 8331731, relocInfo.cpp assert had to be added manually ------------- Commit messages: - Backport 664c993c41753843293388a6ff1481a94a5b4c22 Changes: https://git.openjdk.org/jdk21u-dev/pull/892/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=892&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331731 Stats: 8 lines in 2 files changed: 1 ins; 4 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/892.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/892/head:pull/892 PR: https://git.openjdk.org/jdk21u-dev/pull/892 From robm at openjdk.org Thu Aug 1 16:20:42 2024 From: robm at openjdk.org (Rob McKenna) Date: Thu, 1 Aug 2024 16:20:42 GMT Subject: [jdk23u] Integrated: 8334166: Enable binary check In-Reply-To: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> References: <0HzGQ1vjeewcDWl3sBmdbGLPacmjFsfExMCxsLQ7xmU=.07fe5776-189e-425c-9100-52d3797487e7@github.com> Message-ID: On Thu, 1 Aug 2024 14:10:29 GMT, Rob McKenna wrote: > Enable binary check on jdk23u This pull request has now been integrated. Changeset: 659b469e Author: Rob McKenna URL: https://git.openjdk.org/jdk23u/commit/659b469e206da758a1b17849a68712f0eb71064f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8334166: Enable binary check Reviewed-by: shade, iris Backport-of: a4582a8957d604b50249e1f59679393966456a14 ------------- PR: https://git.openjdk.org/jdk23u/pull/52 From phh at openjdk.org Thu Aug 1 16:24:33 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 1 Aug 2024 16:24:33 GMT Subject: [jdk17u-dev] RFR: 8335536: Fix assertion failure in IdealGraphPrinter when append is true In-Reply-To: References: Message-ID: On Thu, 4 Jul 2024 03:06:59 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [6db4c6a7](https://github.com/openjdk/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein. > > The original patch does not apply cleanly to 17u due to some merge conflicts about creating `xmlStream` with placement `new` expressions. > > Thanks! Please configure pre-submit testing on this repo. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2657#issuecomment-2263467303 From dzhang at openjdk.org Thu Aug 1 16:51:45 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 1 Aug 2024 16:51:45 GMT Subject: [jdk11u-dev] RFR: Allow building with Clang 13 [v10] In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 17:41:55 GMT, VVD wrote: >> Reilly Brogan has updated the pull request incrementally with one additional commit since the last revision: >> >> Rework markOops into markWord > > OpenJDK 11 build and work fine with LLVM 18 on FreeBSD 14.1 amd64. @VVD @RealCLanger Thanks for your information! Do you have plans to create a new PR to jdk11u-dev? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1284#issuecomment-2263516251 From ashi at openjdk.org Thu Aug 1 17:16:13 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 1 Aug 2024 17:16:13 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality Message-ID: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) - This PR has two commits - `commit 1`: the git apply result, which is `clean` - `commit 2`: manually merge the following two `.rej` files - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` @@ -668,15 +670,21 @@ static void assertReductionArraysEquals(double[] r, double rc, double[] a, FReductionOp f, FReductionAllOp fa) { + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); + } + + static void assertReductionArraysEquals(double[] r, double rc, double[] a, + FReductionOp f, FReductionAllOp fa, + double relativeError) { int i = 0; try { - Assert.assertEquals(rc, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(r[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); } } catch (AssertionError e) { - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); } } @@ -690,15 +698,22 @@ static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); + } + + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, + FReductionMaskedOp f, FReductionAllMaskedOp fa, + double relativeError) { int i = 0; try { - Assert.assertEquals(rc, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask), Math.abs(rc * relativeError)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(r[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask), Math.abs(r[i] * +relativeError)); } } catch (AssertionError e) { - Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), Math.abs(rc * relativeError), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), Math.abs(r[i] * relativeError), "at index #" + i); } } Content of `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` @@ -668,15 +670,21 @@ static void assertReductionArraysEquals(float[] r, float rc, float[] a, FReductionOp f, FReductionAllOp fa) { + assertReductionArraysEquals(r, rc, a, f, fa, (float)0.0); + } + + static void assertReductionArraysEquals(float[] r, float rc, float[] a, + FReductionOp f, FReductionAllOp fa, + float relativeError) { int i = 0; try { - Assert.assertEquals(rc, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(r[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); } } catch (AssertionError e) { - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); } } @@ -690,15 +698,22 @@ static void assertReductionArraysEqualsMasked(float[] r, float rc, float[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (float)0.0); + } + + static void assertReductionArraysEqualsMasked(float[] r, float rc, float[] a, boolean[] mask, + FReductionMaskedOp f, FReductionAllMaskedOp fa, + float relativeError) { int i = 0; try { - Assert.assertEquals(rc, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask), Math.abs(rc * relativeError)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(r[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask), Math.abs(r[i] * +relativeError)); } } catch (AssertionError e) { - Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), Math.abs(rc * relativeError), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), Math.abs(r[i] * relativeError), "at index #" + i); } } Testing - Local: Test passed on `MacOS 14.5` with `Apple M1 Max` - `Double128VectorTests.java`: Test results: passed: 1 - `Double256VectorTests.java`: Test results: passed: 1 - `Double512VectorTests.java`: Test results: passed: 1 - `Double64VectorTests.java`: Test results: passed: 1 - `DoubleMaxVectorTests.java`: Test results: passed: 1 - `Float128VectorTests.java`: Test results: passed: 1 - `Float256VectorTests.java`: Test results: passed: 1 - `Float512VectorTests.java`: Test results: passed: 1 - `Float64VectorTests.java`: Test results: passed: 1 - `FloatMaxVectorTests.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport e6f23a90d4a53339a3c9c2b76fc5d317940e4472 Manual Merge - Backport e6f23a90d4a53339a3c9c2b76fc5d317940e4472 Changes: https://git.openjdk.org/jdk17u-dev/pull/2768/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315024 Stats: 358 lines in 12 files changed: 238 ins; 0 del; 120 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2768.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2768/head:pull/2768 PR: https://git.openjdk.org/jdk17u-dev/pull/2768 From phh at openjdk.org Thu Aug 1 17:35:36 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 1 Aug 2024 17:35:36 GMT Subject: [jdk17u-dev] RFR: 8335536: Fix assertion failure in IdealGraphPrinter when append is true In-Reply-To: References: Message-ID: <7MZ0TqIbu1EC8lXZVDK5UCeV9KKnHd95GNHLV8DSjrE=.824e85dc-5b79-4f81-89a6-1d1c0fde32e8@github.com> On Thu, 4 Jul 2024 03:06:59 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [6db4c6a7](https://github.com/openjdk/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein. > > The original patch does not apply cleanly to 17u due to some merge conflicts about creating `xmlStream` with placement `new` expressions. > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2657#pullrequestreview-2213446108 From ashi at openjdk.org Thu Aug 1 21:03:48 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 1 Aug 2024 21:03:48 GMT Subject: [jdk17u-dev] RFR: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError Message-ID: Backport of [JDK-8313901](https://bugs.openjdk.org/browse/JDK-8313901) Testing - Local: Test passed on `MacOS 14.5` on Apple M1 Max - `CodeCacheFullCountTest.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport d1de3d082ef9b83aaa68664e653ab09feb8bad87 Changes: https://git.openjdk.org/jdk17u-dev/pull/2769/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2769&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313901 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2769.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2769/head:pull/2769 PR: https://git.openjdk.org/jdk17u-dev/pull/2769 From ashi at openjdk.org Thu Aug 1 22:38:02 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 1 Aug 2024 22:38:02 GMT Subject: [jdk17u-dev] RFR: 8320608: Many jtreg printing tests are missing the @printer keyword Message-ID: Backport of [JDK-8320608](https://bugs.openjdk.org/browse/JDK-8320608) - This PR contains two commits - `commit 1`: changes made by `git apply`, which is `clean` - `commit 2`: manual merge the `test/jdk/TEST.ROOT.rej` Contents of `test/jdk/TEST.ROOT.rej` @@ -9,17 +9,41 @@ # should be taken to handle test failures of intermittent or # randomness tests. # -# A "headful" test requires a graphical environment to meaningfully -# run. Tests that are not headful are "headless". -# A test flagged with key sound needs audio devices on the system, this -# may be accompanied by the headful keyword since audio device access +# A test flagged with cgroups uses cgroups. +# +# Notes on "client" keywords : headful sound printer multimon +# =========================================================== +# +# These keywords are there to help with test selection so that +# tests that need a particular resource can be selected to run on a system +# with that resource. Conversely "!somekeyword" can be used to exclude tests +# on a system without such a resource. +# Caution: If you are always excluding tests using any of these keywords then you +# are likely missing many important tests. +# +# "headful". A "headful" test requires a graphical environment to meaningfully run. +# This does not have to mean a physical host, since a VM can be configured as headful. +# Tests that are not headful are "headless". +# Note: all manual tests are assumed to be headful and do not need the keyword. +# +# "printer". Not all tests of printing APIs require a printer, but many do. +# So a "printer" test requires a printer to be installed to do anything meaningful. +# Tests may not fail if there is none, instead just silently return. +# But they also may legitimately throw an Exception depending on the test. +# Also printer tests are not necessarily headful, but some are, and some are automated. +# +# "sound". Similarly, not all sound tests require audio devices, but many do. +# A test flagged with key "sound" needs audio devices on the system. +# Also they are not necessarily "headful", since they don't require a display etc. +# But sometimes they may be accompanied by the headful keyword, since sound # is often linked to access to desktop resources and headful systems are # also more likely to have audio devices (ie meaning both input and output) -# A test flagged with key "printer" requires a printer to succeed, else -# throws a PrinterException or the like. -# A test flagged with cgroups uses cgroups. +# +# "multimon" should be used in conjunction with headful and is used to identify +# tests which require two displays connected. -keys=2d dnd headful sound i18n intermittent printer randomness jfr cgroups +keys=headful sound printer multimon \ + i18n intermittent randomness jfr cgroups # Tests that must run in othervm mode othervm.dirs=java/awt java/beans javax/accessibility javax/imageio javax/sound javax/swing javax/print \ Testing - Local: Test passed on `MacOS 14.5` with Apple M1 Max chip - `test/jdk/java/awt/PrintJob/**`: Test results: passed: 7 - `test/jdk/java/awt/print/**`: Test results: passed: 38 - `test/jdk/javax/print/**`: Test results: passed: 23 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 76fea807071eee80a1e00aae7bc4784a6d35bf4b Manual merge - Backport 76fea807071eee80a1e00aae7bc4784a6d35bf4b Changes: https://git.openjdk.org/jdk17u-dev/pull/2770/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2770&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320608 Stats: 247 lines in 139 files changed: 140 ins; 23 del; 84 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2770.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2770/head:pull/2770 PR: https://git.openjdk.org/jdk17u-dev/pull/2770 From ashi at openjdk.org Thu Aug 1 23:40:49 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 1 Aug 2024 23:40:49 GMT Subject: [jdk17u-dev] RFR: 8306583: Add JVM crash check in CDSTestUtils.executeAndLog Message-ID: Backport of [JDK-8306583](https://bugs.openjdk.org/browse/JDK-8306583) Testing - Local: Test passed - `TestCDSVMCrash.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 27764e60357b018b4f403d63cb54f95604b0cb8c Manual merge - Backport 27764e60357b018b4f403d63cb54f95604b0cb8c Changes: https://git.openjdk.org/jdk17u-dev/pull/2771/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2771&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306583 Stats: 75 lines in 2 files changed: 74 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2771.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2771/head:pull/2771 PR: https://git.openjdk.org/jdk17u-dev/pull/2771 From ashi at openjdk.org Fri Aug 2 00:23:01 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 2 Aug 2024 00:23:01 GMT Subject: [jdk17u-dev] RFR: 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused Message-ID: Backport of [JDK-8304962](https://bugs.openjdk.org/browse/JDK-8304962) Testing - Local: Test passed - `B5045306.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport cddaf686e16424e9543be50a48b1c02337e79cf1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2772/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2772&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304962 Stats: 9 lines in 1 file changed: 1 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2772.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2772/head:pull/2772 PR: https://git.openjdk.org/jdk17u-dev/pull/2772 From ashi at openjdk.org Fri Aug 2 00:55:57 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 2 Aug 2024 00:55:57 GMT Subject: [jdk17u-dev] RFR: 8279641: Create manual JTReg tests for Swing accessibility Message-ID: Backport of [JDK-8279641](https://bugs.openjdk.org/browse/JDK-8279641) Testing - Local: Not applicable - `test/jdk/javax/accessibility/manual` - Test results: no tests selected - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 5523ddebd572f38c3f960950d114ffead33266ae Changes: https://git.openjdk.org/jdk17u-dev/pull/2773/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2773&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279641 Stats: 1410 lines in 35 files changed: 1410 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2773.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2773/head:pull/2773 PR: https://git.openjdk.org/jdk17u-dev/pull/2773 From qxing at openjdk.org Fri Aug 2 01:41:34 2024 From: qxing at openjdk.org (Qizheng Xing) Date: Fri, 2 Aug 2024 01:41:34 GMT Subject: [jdk17u-dev] RFR: 8335536: Fix assertion failure in IdealGraphPrinter when append is true In-Reply-To: References: Message-ID: <53qnAc7uyd4VzngttkV3OP5LiRQ9z30kqytvyqiR_S4=.99b4b6a1-09a8-4902-ad03-9c8dcd975e1e@github.com> On Thu, 1 Aug 2024 16:21:59 GMT, Paul Hohensee wrote: >> Hi all, >> >> This pull request contains a backport of commit [6db4c6a7](https://github.com/openjdk/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein. >> >> The original patch does not apply cleanly to 17u due to some merge conflicts about creating `xmlStream` with placement `new` expressions. >> >> Thanks! > > Please configure pre-submit testing on this repo. @phohensee Thanks for the review! I have enabled testing in my repository. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2657#issuecomment-2264328061 From andrewlu at openjdk.org Fri Aug 2 02:05:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 02:05:43 GMT Subject: [jdk11u-dev] Withdrawn: 8317112: Add screenshot for Frame/DefaultSizeTest.java In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 08:43:42 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2894 From ashi at openjdk.org Fri Aug 2 03:14:03 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 2 Aug 2024 03:14:03 GMT Subject: [jdk17u-dev] RFR: 8295087: Manual Test to Automated Test Conversion Message-ID: Backport of [JDK-8295087](https://bugs.openjdk.org/browse/JDK-8295087) - This PR contains two commit - `Commit 1` is generated by git apply from original commit - `Commit 2` is adding the missing test case `InconsistentEntries.java`, which was originally added by [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779) Testing - Local: Test passed on `MacOS 14.5` on Apple M1 Max - `ExtDirs.java`: Test results: passed: 2 - `ExtDirsChange.java`: Test results: passed: 1 - `ExtDirsDefaultPolicy.java`: Test results: passed: 4 - `InconsistentEntries.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport a3693ccc617d06137a61050b34646e8a90ed3d7e Add test InconsistentEntries - Backport a3693ccc617d06137a61050b34646e8a90ed3d7e Changes: https://git.openjdk.org/jdk17u-dev/pull/2774/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2774&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295087 Stats: 221 lines in 13 files changed: 144 ins; 26 del; 51 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2774.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2774/head:pull/2774 PR: https://git.openjdk.org/jdk17u-dev/pull/2774 From mbaesken at openjdk.org Fri Aug 2 06:49:42 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 06:49:42 GMT Subject: [jdk17u-dev] RFR: 8335967: "text-decoration: none" does not work with "A" HTML tags In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 13:17:40 GMT, Matthias Baesken wrote: > 8335967: "text-decoration: none" does not work with "A" HTML tags jdk/test/lib/TestMutuallyExclusivePlatformPredicates failures in GHA, seems to be unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2765#issuecomment-2264681233 From coffeys at openjdk.org Fri Aug 2 06:51:32 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Fri, 2 Aug 2024 06:51:32 GMT Subject: [jdk23u] RFR: 8330702: Update failure handler to don't generate Error message if cores actions are empty In-Reply-To: References: Message-ID: On Mon, 24 Jun 2024 12:54:54 GMT, Mimoun Ghordou wrote: > Tested Tier 1 Marked as reviewed by coffeys (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/5#pullrequestreview-2214788293 From duke at openjdk.org Fri Aug 2 07:13:38 2024 From: duke at openjdk.org (Junhua Huang) Date: Fri, 2 Aug 2024 07:13:38 GMT Subject: [jdk17u-dev] RFR: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 21:59:40 GMT, Amos Shi wrote: > Backport of [JDK-8313674](https://bugs.openjdk.org/browse/JDK-8313674) > - `Unclean` backport > - Manually merged based original commit > > Testing > - Local: will do on a Linux `(os.family == "linux")` - current dev machine is MacOS cannot execute for now > - Pipeline: > - Testing Machine: Test succeeded on linux DISTRIB_ID=Ubuntu DISTRIB_RELEASE=22.04 DISTRIB_CODENAME=jammy DISTRIB_DESCRIPTION="Ubuntu 22.04.3 LTS" Test command: - `/root/projects/jtreg/bin/jtreg -dir:test/ -a -nativepath:/root/projects/jdk17u-dev/build/linux-x86_64-server-release/images/test/hotspot/jtreg/native -testjdk:/root/projects/jdk17u-dev/build/linux-x86_64-server-release/images/jdk -w:build/jtreg-test /root/projects/jdk17u-dev/test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java` Test result: Directory "build/jtreg-test" not found: creating Directory "JTreport" not found: creating Test results: passed: 1 Report written to /root/projects/jdk17u-dev/JTreport/html/report.html Results written to /root/projects/jdk17u-dev/build/jtreg-test ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2756#issuecomment-2264717265 From rschmelter at openjdk.org Fri Aug 2 07:14:41 2024 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Fri, 2 Aug 2024 07:14:41 GMT Subject: [jdk21u-dev] RFR: 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 15:31:11 GMT, Matthias Baesken wrote: > Backport of 8331731, relocInfo.cpp assert had to be added manually Looks good. ------------- Marked as reviewed by rschmelter (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/892#pullrequestreview-2214835516 From clanger at openjdk.org Fri Aug 2 07:21:31 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 2 Aug 2024 07:21:31 GMT Subject: [jdk21u-dev] RFR: 8332113: Update nsk.share.Log to be always verbose In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:28:59 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. @luchenlin can you please bring this to jdk23u as well? Seems to be a case where Oracle forgot to do this... Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/887#issuecomment-2264733965 From mbaesken at openjdk.org Fri Aug 2 07:43:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 07:43:32 GMT Subject: [jdk21u-dev] Integrated: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 14:17:17 GMT, Matthias Baesken wrote: > 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null This pull request has now been integrated. Changeset: 6bc382ff Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/6bc382ff3ef0a026f9d7cf71c72a53c3f1f446a4 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null Backport-of: 880c6b42ba74884690daa5c23f6605876f29aece ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/884 From mbaesken at openjdk.org Fri Aug 2 07:45:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 07:45:33 GMT Subject: [jdk21u-dev] Integrated: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]' In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 12:55:32 GMT, Matthias Baesken wrote: > Backport of 8332699; COPYRIGHT year This pull request has now been integrated. Changeset: 0fdb2066 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/0fdb206658ffe37dc53807d9bf05231e4e778604 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]' Backport-of: abbf45b57edf2f5bf9a3f2fa408f35a43ebe9bb9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/883 From duke at openjdk.org Fri Aug 2 07:58:38 2024 From: duke at openjdk.org (luwang1103) Date: Fri, 2 Aug 2024 07:58:38 GMT Subject: [jdk21u-dev] Integrated: 8324580: SIGFPE on THP initialization on kernels < 4.10 In-Reply-To: References: Message-ID: On Mon, 15 Jul 2024 09:09:04 GMT, luwang1103 wrote: > hi , > > This pull request contains a backport of commit [a231706a](https://git.openjdk.org/jdk/commit/a231706a06a86abb16d0040e8ca1b76a9741a0b2) from the [master](https://github.com/openjdk/jdk) repository. > > The commit being backported was authored by Zdenek Zambersky on 15 Feb 2024. > > Thanks? This pull request has now been integrated. Changeset: 9cb36b2f Author: luwang1103 <576420940 at qq.com> Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/9cb36b2f677f4fa7b4af88752b7a3e4ab473db15 Stats: 36 lines in 5 files changed: 34 ins; 1 del; 1 mod 8324580: SIGFPE on THP initialization on kernels < 4.10 Reviewed-by: stuefe Backport-of: a231706a06a86abb16d0040e8ca1b76a9741a0b2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/840 From duke at openjdk.org Fri Aug 2 08:13:36 2024 From: duke at openjdk.org (duke) Date: Fri, 2 Aug 2024 08:13:36 GMT Subject: [jdk21u-dev] RFR: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 05:42:00 GMT, Liang Mao wrote: > Clean backport of fixing soft-ref resetting in Parallel Full GC. @mmyxym Your change (at version 3a089b591dee683f4e3c855cc77601aef1be9e51) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/857#issuecomment-2264820965 From clanger at openjdk.org Fri Aug 2 08:20:37 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 2 Aug 2024 08:20:37 GMT Subject: [jdk17u-dev] RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:29:47 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. @luchenlin this needs to be brought to jdk21u-dev first. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2761#issuecomment-2264832825 From shade at openjdk.org Fri Aug 2 08:32:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Aug 2024 08:32:38 GMT Subject: [jdk17u-dev] Integrated: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 13:27:53 GMT, Aleksey Shipilev wrote: > Fixes Shenandoah deadlock. There are few minor differences that make the backport unclean: > - the absence of [JDK-8273559](https://bugs.openjdk.org/browse/JDK-8273559) that added another argument to GC in JDK 18 > - the existence of `ShenandoahNMethodPurgeTask` that was removed along with Sweeper with [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025) in JDK 20 > - the existence of `ICStubVerifier` that was removed in JDK 23 with [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 server fastdebug, `all` with `-XX:+UseShenandoahGC` This pull request has now been integrated. Changeset: 2ec87177 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/2ec87177d436f8f97dc3358d4ad1355e7c4b6a26 Stats: 79 lines in 4 files changed: 25 ins; 39 del; 15 mod 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration Reviewed-by: phh Backport-of: 2aeb12ec03944c777d617d0be48982fd225b16e7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2751 From syan at openjdk.org Fri Aug 2 08:33:40 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 2 Aug 2024 08:33:40 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v6] In-Reply-To: References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Wed, 24 Jul 2024 11:43:11 GMT, SendaoYan wrote: >> Hi, >> >> The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. >> >> And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) >> >> >> Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! > > Signed-off-by: sendaoYan Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-2264853162 From duke at openjdk.org Fri Aug 2 08:33:41 2024 From: duke at openjdk.org (duke) Date: Fri, 2 Aug 2024 08:33:41 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v6] In-Reply-To: References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Wed, 24 Jul 2024 11:43:11 GMT, SendaoYan wrote: >> Hi, >> >> The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. >> >> And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) >> >> >> Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! > > Signed-off-by: sendaoYan @sendaoYan Your change (at version 8d0d48963a61173b0eea9a0a890ed7d3984650d4) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-2264855955 From shade at openjdk.org Fri Aug 2 09:08:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Aug 2024 09:08:59 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport Message-ID: See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. ------------- Commit messages: - 8337684: [17/11u] Revert JDK-8163921 backport Changes: https://git.openjdk.org/jdk17u-dev/pull/2775/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2775&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337684 Stats: 11 lines in 2 files changed: 1 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2775.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2775/head:pull/2775 PR: https://git.openjdk.org/jdk17u-dev/pull/2775 From mbaesken at openjdk.org Fri Aug 2 09:12:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 09:12:37 GMT Subject: [jdk21u-dev] Integrated: 8335967: "text-decoration: none" does not work with "A" HTML tags In-Reply-To: <1CEkh8DtaBaOq1-m-PVFARxmQlmJp4sn_FcJUnCgbvM=.e826934a-b97d-49ee-bd75-cab6e530de10@github.com> References: <1CEkh8DtaBaOq1-m-PVFARxmQlmJp4sn_FcJUnCgbvM=.e826934a-b97d-49ee-bd75-cab6e530de10@github.com> Message-ID: On Thu, 1 Aug 2024 08:00:59 GMT, Matthias Baesken wrote: > 8335967: "text-decoration: none" does not work with "A" HTML tags This pull request has now been integrated. Changeset: 7c2666d9 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/7c2666d9e5d016199ead47f8edb3f94ef1d469d3 Stats: 132 lines in 2 files changed: 132 ins; 0 del; 0 mod 8335967: "text-decoration: none" does not work with "A" HTML tags Backport-of: 374fca0fcbc049f937fa49bb4825edcbbf961f2b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/888 From mbaesken at openjdk.org Fri Aug 2 09:12:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 09:12:37 GMT Subject: [jdk17u-dev] Integrated: 8292044: HttpClient doesn't handle 102 or 103 properly In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 12:16:41 GMT, Matthias Baesken wrote: > Backport of 8292044, src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java and src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java need imports manually added (diffs in the stride) and small test adjustments because of differences in jdk17 compared to higher jdk (imports and library/build statements) This pull request has now been integrated. Changeset: 10000286 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/10000286390ac9b0288cee25a4f3551d09475fdc Stats: 618 lines in 7 files changed: 609 ins; 0 del; 9 mod 8292044: HttpClient doesn't handle 102 or 103 properly Reviewed-by: phh Backport-of: 800e68d6906734242119e4ea033422f037a79857 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2753 From andrewlu at openjdk.org Fri Aug 2 09:26:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 09:26:40 GMT Subject: [jdk17u-dev] Integrated: 8317635: Improve GetClassFields test to verify correctness of field order In-Reply-To: References: Message-ID: <9Q7FPi3v0utjp08J2TqSMjCP3jPqs7zElUaIOWL9MdE=.9298690c-63b4-4217-944d-27a84467ad3f@github.com> On Thu, 1 Aug 2024 08:41:21 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 8bb51e5e Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/8bb51e5edb0e3a4a3e32076966b81eaf20903ed4 Stats: 176 lines in 3 files changed: 62 ins; 52 del; 62 mod 8317635: Improve GetClassFields test to verify correctness of field order Backport-of: 599560a832386d9c61aca24450d6efa65156f663 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2762 From andrewlu at openjdk.org Fri Aug 2 09:27:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 09:27:36 GMT Subject: [jdk21u-dev] Integrated: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3 In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 08:53:06 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 81d1c97f Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/81d1c97f8a37174915bdb944bb482d3fa28895ad Stats: 1638 lines in 6 files changed: 296 ins; 1069 del; 273 mod 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3 Backport-of: af7c6af0cc1eb6c42199c05933c7feb032bd6353 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/890 From andrewlu at openjdk.org Fri Aug 2 09:27:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 09:27:39 GMT Subject: [jdk21u-dev] Integrated: 8317112: Add screenshot for Frame/DefaultSizeTest.java In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 08:43:07 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: ce67ab0a Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/ce67ab0a9f62fd4ff834db4bbdf1d72589cba3cb Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8317112: Add screenshot for Frame/DefaultSizeTest.java Backport-of: a36eaf03afd148581a9d9754f85a652cac84d655 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/889 From andrewlu at openjdk.org Fri Aug 2 09:27:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 09:27:40 GMT Subject: [jdk17u-dev] Integrated: 8317343: GC: Make TestHeapFreeRatio use createTestJvm In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 08:41:37 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: a76c3af6 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/a76c3af69f59ff2d7881c29f9f478ecfadfe23d5 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8317343: GC: Make TestHeapFreeRatio use createTestJvm Backport-of: c64bd3d6715304accd9a1e3266edd9d3d2353273 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2763 From andrewlu at openjdk.org Fri Aug 2 09:27:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 09:27:40 GMT Subject: [jdk17u-dev] Integrated: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure In-Reply-To: <2IjUByY77LOvyoffbfrgP0p39DPf0DBsyReA4lWpSrY=.d0442ad5-c8b8-492a-a699-14ccd9091f67@github.com> References: <2IjUByY77LOvyoffbfrgP0p39DPf0DBsyReA4lWpSrY=.d0442ad5-c8b8-492a-a699-14ccd9091f67@github.com> Message-ID: On Thu, 1 Aug 2024 02:29:31 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 4d03e9dd Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/4d03e9ddc957bb08f405367f0d8b9a0748ef170e Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure Backport-of: 01125fa21b733199d4fe670ecf38b82cd917e242 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2760 From andrewlu at openjdk.org Fri Aug 2 09:29:34 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 09:29:34 GMT Subject: [jdk21u-dev] Integrated: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:27:33 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 3511d722 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/3511d722ca164bc077fc40b5375d62757c9e1d2e Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Backport-of: ae9f318fc35eeab497e546ebab9faed6ec774ec5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/886 From andrewlu at openjdk.org Fri Aug 2 09:29:35 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 2 Aug 2024 09:29:35 GMT Subject: [jdk17u-dev] Integrated: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3 In-Reply-To: <49y4DmD9HEoVF34jz0lk9-PW5Zlg-YNgfLjP8XEFZ4Y=.50574b3d-b4ea-44ec-8b4d-0cad885bccf3@github.com> References: <49y4DmD9HEoVF34jz0lk9-PW5Zlg-YNgfLjP8XEFZ4Y=.50574b3d-b4ea-44ec-8b4d-0cad885bccf3@github.com> Message-ID: On Thu, 1 Aug 2024 02:28:44 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 8f32625b Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/8f32625b1181e193d9b529111bfce9f5d4d626b9 Stats: 16 lines in 2 files changed: 0 ins; 2 del; 14 mod 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3 Backport-of: d02cb742f79e88c6438ca58a6357fe432fb286cb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2758 From mbaesken at openjdk.org Fri Aug 2 09:42:58 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 09:42:58 GMT Subject: [jdk11u-dev] RFR: 8229822: ThrowingPushPromises tests sometimes fail due to EOF Message-ID: 8229822: ThrowingPushPromises tests sometimes fail due to EOF ------------- Commit messages: - Backport 77c46ea9112b0c2632b4af1d899d59a132878da3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2895/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2895&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8229822 Stats: 170 lines in 10 files changed: 141 ins; 1 del; 28 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2895.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2895/head:pull/2895 PR: https://git.openjdk.org/jdk11u-dev/pull/2895 From mbaesken at openjdk.org Fri Aug 2 10:47:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 10:47:31 GMT Subject: [jdk21u-dev] Integrated: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510 In-Reply-To: <89S3h2n4DCy1XhoKX1zmvZ-yRqAkJArt_bjJu5vNygg=.f2546176-7f90-427b-92ad-52dc877dbe87@github.com> References: <89S3h2n4DCy1XhoKX1zmvZ-yRqAkJArt_bjJu5vNygg=.f2546176-7f90-427b-92ad-52dc877dbe87@github.com> Message-ID: On Thu, 1 Aug 2024 11:14:43 GMT, Matthias Baesken wrote: > 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510 This pull request has now been integrated. Changeset: 30294f4d Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/30294f4dc62e758ccc4fc769ef670470cc0afdc5 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510 Backport-of: 2c1b311f81319cee1af574526a91424c2577b78c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/891 From lmao at openjdk.org Fri Aug 2 11:19:32 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 2 Aug 2024 11:19:32 GMT Subject: [jdk21u-dev] Integrated: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 05:42:00 GMT, Liang Mao wrote: > Clean backport of fixing soft-ref resetting in Parallel Full GC. This pull request has now been integrated. Changeset: ee21571d Author: Liang Mao Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/ee21571d46ccd2e2a283055eb272274de5378b38 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs Backport-of: cff9e246cc2fbd3914f40bb71daa85dcf7731396 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/857 From syan at openjdk.org Fri Aug 2 11:19:35 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 2 Aug 2024 11:19:35 GMT Subject: [jdk17u-dev] Integrated: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 In-Reply-To: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Tue, 30 Jan 2024 16:25:52 GMT, SendaoYan wrote: > Hi, > > The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. > > And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) > > > Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. > > Thanks, > -sendao This pull request has now been integrated. Changeset: 9ca66081 Author: SendaoYan Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/9ca66081d5f92b63cb3d4116468f256c4d3f14b3 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 Reviewed-by: mbaesken ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2186 From mbaesken at openjdk.org Fri Aug 2 11:55:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 11:55:31 GMT Subject: [jdk21u-dev] RFR: 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer In-Reply-To: References: Message-ID: <1Z5R4ww4nnRn3OsDGOyo3CdlAQ0jRLFY0ZsL4AkzQZ4=.29434ba9-87e3-401e-ac40-364b9000db23@github.com> On Thu, 1 Aug 2024 15:31:11 GMT, Matthias Baesken wrote: > Backport of 8331731, relocInfo.cpp assert had to be added manually Thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/892#issuecomment-2265190585 From mbaesken at openjdk.org Fri Aug 2 11:55:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 11:55:31 GMT Subject: [jdk21u-dev] Integrated: 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 15:31:11 GMT, Matthias Baesken wrote: > Backport of 8331731, relocInfo.cpp assert had to be added manually This pull request has now been integrated. Changeset: b79e1852 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/b79e18521a024feb8693708680731f556edf1786 Stats: 8 lines in 2 files changed: 1 ins; 4 del; 3 mod 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer Reviewed-by: rschmelter Backport-of: 664c993c41753843293388a6ff1481a94a5b4c22 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/892 From syan at openjdk.org Fri Aug 2 12:04:42 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 2 Aug 2024 12:04:42 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v6] In-Reply-To: References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: <4jRyDxhsL-gSB5l2JUKO7GsRJuJIZbu8aRo2UyBufwQ=.99592db3-bf6b-4ce9-9ab9-4983d020f8a0@github.com> On Wed, 24 Jul 2024 11:43:11 GMT, SendaoYan wrote: >> Hi, >> >> The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. >> >> And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) >> >> >> Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - Merge branch 'openjdk:master' into jbs8324978 > - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! > > Signed-off-by: sendaoYan Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-2265206442 From mbaesken at openjdk.org Fri Aug 2 12:05:40 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Aug 2024 12:05:40 GMT Subject: [jdk17u-dev] Integrated: 8335967: "text-decoration: none" does not work with "A" HTML tags In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 13:17:40 GMT, Matthias Baesken wrote: > 8335967: "text-decoration: none" does not work with "A" HTML tags This pull request has now been integrated. Changeset: 7f8fdbd0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/7f8fdbd0940c30968f38a226e52e9ce8264a1e74 Stats: 132 lines in 2 files changed: 132 ins; 0 del; 0 mod 8335967: "text-decoration: none" does not work with "A" HTML tags Backport-of: 374fca0fcbc049f937fa49bb4825edcbbf961f2b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2765 From clanger at openjdk.org Fri Aug 2 12:45:50 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 2 Aug 2024 12:45:50 GMT Subject: [jdk17u-dev] RFR: 8337669: [17u] Backport of JDK-8284047 missed to delete a file [v2] In-Reply-To: References: Message-ID: > The backport of JDK-8284047 to jdk17u should have deleted the file test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketBruceForceClose.java but it didn't. Let's do it now. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into deletebruce - JDK-8337669 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2767/files - new: https://git.openjdk.org/jdk17u-dev/pull/2767/files/fe94b8ea..1d35aa5f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2767&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2767&range=00-01 Stats: 1027 lines in 21 files changed: 830 ins; 93 del; 104 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2767.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2767/head:pull/2767 PR: https://git.openjdk.org/jdk17u-dev/pull/2767 From clanger at openjdk.org Fri Aug 2 12:46:11 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 2 Aug 2024 12:46:11 GMT Subject: [jdk17u-dev] RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java [v2] In-Reply-To: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> References: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> Message-ID: > Backport of 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java > > The wrong location is 17 is not "risv64" as it was in JDK 19 but here it is "riscv" which should be "riscv64" to make jdk.hotspot.agent compile correctly. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into riscstuff - JDK-8283728 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2766/files - new: https://git.openjdk.org/jdk17u-dev/pull/2766/files/9a36f3ff..384864a1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2766&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2766&range=00-01 Stats: 1027 lines in 21 files changed: 830 ins; 93 del; 104 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2766.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2766/head:pull/2766 PR: https://git.openjdk.org/jdk17u-dev/pull/2766 From shade at openjdk.org Fri Aug 2 13:15:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Aug 2024 13:15:51 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: > See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. > > This is a `git revert` of https://github.com/openjdk/jdk17u-dev/commit/b37df147b011b23b6c7474d726710e1478af7607. Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8337684-revert-http-accept - 8337684: [17/11u] Revert JDK-8163921 backport ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2775/files - new: https://git.openjdk.org/jdk17u-dev/pull/2775/files/5109bef4..f4d5ba99 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2775&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2775&range=00-01 Stats: 948 lines in 17 files changed: 805 ins; 54 del; 89 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2775.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2775/head:pull/2775 PR: https://git.openjdk.org/jdk17u-dev/pull/2775 From ogillespie at openjdk.org Fri Aug 2 13:26:44 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Fri, 2 Aug 2024 13:26:44 GMT Subject: [jdk17u-dev] RFR: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared Message-ID: Hi all, This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn. It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue. Thanks! ------------- Commit messages: - Backport 408cec516bb5fd82fb6dcddeee934ac0c5ecffaf Changes: https://git.openjdk.org/jdk17u-dev/pull/2776/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2776&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306929 Stats: 150 lines in 6 files changed: 127 ins; 3 del; 20 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2776.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2776/head:pull/2776 PR: https://git.openjdk.org/jdk17u-dev/pull/2776 From shade at openjdk.org Fri Aug 2 14:41:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Aug 2024 14:41:32 GMT Subject: [jdk17u-dev] RFR: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:20:38 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn. > > It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue. > > Thanks! This looks fine. I don't see any follow-up bugs for this change, but please run `all` tests to see if there is any trouble. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2776#pullrequestreview-2215749869 From ogillespie at openjdk.org Fri Aug 2 15:58:32 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Fri, 2 Aug 2024 15:58:32 GMT Subject: [jdk17u-dev] RFR: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:20:38 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn. > > It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue. > > Thanks! Hmm, the new test is failing on Windows. [1.056s][trace][redefine,class,iklass,add] adding previous version ref for java.lang.Error, EMCP_cnt=0 [1.056s][trace][redefine,class,iklass,add] scratch class not added; no methods are running [1.271s][info ][jfr,startup ] Started recording 1. No limit specified, using maxsize=250MB as default. [1.271s][info ][jfr,startup ] [1.271s][info ][jfr,startup ] Use jcmd 2540 JFR.dump name=1 filename=FILEPATH to copy recording data to file. [1.371s][trace][redefine,class,iklass,purge] Class unloading: should_clean_previous_versions = false is happening for `-Xshare:off` instead of the expected scratch class added; one of its methods is on_stack. Class unloading: should_clean_previous_versions = true Will try to investigate. @kstefanj if you happen to know why this might happen please let me know. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2776#issuecomment-2265696431 From duke at openjdk.org Fri Aug 2 17:02:38 2024 From: duke at openjdk.org (duke) Date: Fri, 2 Aug 2024 17:02:38 GMT Subject: [jdk21u-dev] RFR: 8321509: False positive in get_trampoline fast path causes crash In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 22:42:35 GMT, Dan Lutker wrote: > We have a customer experiencing this crash in 21.0.3 with the same stack as the duplicate issue (JDK-8334136). > > Ran tier1-4 on Linux aarch64 as well as a `jcstress -m quick`. @lutkerd Your change (at version a80bb359bec8ec8f8fa0628f03e2afa616491b10) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/864#issuecomment-2265802195 From dlutker at openjdk.org Fri Aug 2 17:08:39 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Fri, 2 Aug 2024 17:08:39 GMT Subject: [jdk21u-dev] Integrated: 8321509: False positive in get_trampoline fast path causes crash In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 22:42:35 GMT, Dan Lutker wrote: > We have a customer experiencing this crash in 21.0.3 with the same stack as the duplicate issue (JDK-8334136). > > Ran tier1-4 on Linux aarch64 as well as a `jcstress -m quick`. This pull request has now been integrated. Changeset: 49891655 Author: Dan Lutker Committer: Ben Taylor URL: https://git.openjdk.org/jdk21u-dev/commit/498916555cbc90e597bbe48e242c80f3fd1a2a4c Stats: 72 lines in 6 files changed: 34 ins; 14 del; 24 mod 8321509: False positive in get_trampoline fast path causes crash Backport-of: 73e3e0edeb20c6f701b213423476f92fb05dd262 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/864 From btaylor at openjdk.org Fri Aug 2 21:40:52 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 2 Aug 2024 21:40:52 GMT Subject: [jdk17u-dev] RFR: 8290966: G1: Record number of PLAB filled and number of direct allocations Message-ID: Clean, low risk backport of a change to improve logging around full PLABs and direct allocations. Passes the included test, as well as `make test TEST=gc/g1` locally on linux x64. ------------- Commit messages: - Backport 30205bb289e9b25d60474b24b891e15923071b5a Changes: https://git.openjdk.org/jdk17u-dev/pull/2777/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2777&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290966 Stats: 73 lines in 9 files changed: 51 ins; 0 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2777.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2777/head:pull/2777 PR: https://git.openjdk.org/jdk17u-dev/pull/2777 From ashi at openjdk.org Fri Aug 2 23:24:59 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 2 Aug 2024 23:24:59 GMT Subject: [jdk17u-dev] RFR: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" Message-ID: Backport of [JDK-8298596](https://bugs.openjdk.org/browse/JDK-8298596) - The change on file `test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java` is `clean` - The change on file `test/hotspot/jtreg/ProblemList-zgc.txt` has been **ignored**, because the line does not exist in `jdk17u-dev` Testing - Local: Test passed on `MacOS 14.5` on Apple M1 Max - `OneeFinalizerTest.java`: Test results: passed: 1 - `PhantomReferenceEvilTest.java`: Test results: passed: 1 - `PhantomReferenceTest.java`: Test results: passed: 1 - `ReferencesGC.java`: Test results: passed: 1 - `soft001.java`: Test results: passed: 1 - `weak001.java`: Test results: passed: 1 - `WeakReferenceGC.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport c3242ee452c25b5038283c68e65541122a10df0d Changes: https://git.openjdk.org/jdk17u-dev/pull/2778/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2778&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298596 Stats: 15 lines in 1 file changed: 12 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2778.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2778/head:pull/2778 PR: https://git.openjdk.org/jdk17u-dev/pull/2778 From ashi at openjdk.org Sat Aug 3 00:10:09 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 3 Aug 2024 00:10:09 GMT Subject: [jdk17u-dev] RFR: 8302800: Augment NaN handling tests of FDLIBM methods Message-ID: Backport of [JDK-8302800](https://bugs.openjdk.org/browse/JDK-8302800) - This PR contains two PR - `commit 1` is made by the `git apply` which is `clean` - `commit 2` adds the missing file `test/jdk/java/lang/Math/InverseTrigTests.java` currently does not exist in `jdk17u-dev`, it was originally added by [JDK-8302026](https://bugs.openjdk.org/browse/JDK-8302026) via [commit](https://github.com/openjdk/jdk/commit/3ba156082b73c4a8e9d890a57a42fb68df2bf98f) Testing - Local: Test passed on `MacOS 14.5` on Apple M1 Max - `CubeRootTests.java`: Test results: passed: 1 - `Expm1Tests.java`: Test results: passed: 1 - `HyperbolicTests.java`: Test results: passed: 1 - `Log10Tests.java`: Test results: passed: 1 - `Log1pTests.java`: Test results: passed: 1 - `Tests.java`: Not applicable: not a test - `InverseTrigTests.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport dfce4e1943f2f95b74b5a9cdde9d738dcffd0b43 Add file InverseTrigTests.java - Backport dfce4e1943f2f95b74b5a9cdde9d738dcffd0b43 Changes: https://git.openjdk.org/jdk17u-dev/pull/2779/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2779&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302800 Stats: 363 lines in 7 files changed: 269 ins; 77 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2779.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2779/head:pull/2779 PR: https://git.openjdk.org/jdk17u-dev/pull/2779 From ashi at openjdk.org Sat Aug 3 02:04:13 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 3 Aug 2024 02:04:13 GMT Subject: [jdk17u-dev] RFR: 8313256: Exclude failing multicast tests on AIX Message-ID: Backport of [JDK-8313256](https://bugs.openjdk.org/browse/JDK-8313256) - This PR contains two commit - `commit 1` is generated by git apply command, which is `clean` - `commit 2` is the manual merge of the `test/jdk/ProblemList.txt.rej` file Contents of `test/jdk/ProblemList.txt.rej` @@ -586,13 +587,16 @@ # jdk_net -java/net/MulticastSocket/NoLoopbackPackets.java 7122846 macosx-all -java/net/MulticastSocket/SetLoopbackMode.java 7122846 macosx-all +java/net/MulticastSocket/NoLoopbackPackets.java 7122846,8308807 macosx-all,aix-ppc64 +java/net/MulticastSocket/SetLoopbackMode.java 7122846,8308807 macosx-all,aix-ppc64 -java/net/MulticastSocket/Test.java 7145658 macosx-all +java/net/MulticastSocket/Test.java 7145658,8308807 macosx-all,aix-ppc64 java/net/ServerSocket/AcceptInheritHandle.java 8211854 aix-ppc64 +java/net/MulticastSocket/B6427403.java 8308807 aix-ppc64 +java/net/MulticastSocket/SetOutgoingIf.java 8308807 aix-ppc64 + ############################################################################ # jdk_nio Testing - Local: Not applicable. we don't have AIX system in local dev machine unfortunately. - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 98a915a54ce62da7cebc1f0ab07dab276291a1d1 Manual merge ProblemList.txt - Backport 98a915a54ce62da7cebc1f0ab07dab276291a1d1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2780/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2780&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313256 Stats: 12 lines in 1 file changed: 6 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2780.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2780/head:pull/2780 PR: https://git.openjdk.org/jdk17u-dev/pull/2780 From clanger at openjdk.org Sat Aug 3 04:10:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 3 Aug 2024 04:10:04 GMT Subject: [jdk17u-dev] RFR: 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused Message-ID: <4VImzeHwIc-Zt7cb28XJur0LNX9s5PA-YdiRI1sCVb8=.8548cd20-91f0-4c50-899e-297e31cb9dab@github.com> Hi all, This pull request contains a backport of [JDK-8304962](https://bugs.openjdk.org/browse/JDK-8304962), commit [cddaf686](https://github.com/openjdk/jdk21u-dev/commit/cddaf686e16424e9543be50a48b1c02337e79cf1) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. The commit being backported was authored by Daniel Jeli?ski on 28 Mar 2023 and was reviewed by Jaikiran Pai. Thanks! ------------- Commit messages: - Backport cddaf686e16424e9543be50a48b1c02337e79cf1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2781/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2781&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304962 Stats: 9 lines in 1 file changed: 1 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2781.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2781/head:pull/2781 PR: https://git.openjdk.org/jdk17u-dev/pull/2781 From clanger at openjdk.org Sat Aug 3 04:28:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 3 Aug 2024 04:28:04 GMT Subject: [jdk17u-dev] RFR: 7026262: HttpServer: improve handling of finished HTTP exchanges Message-ID: Hi all, This pull request contains a backport of [JDK-7026262](https://bugs.openjdk.org/browse/JDK-7026262), commit [a5ffa079](https://github.com/openjdk/jdk21u-dev/commit/a5ffa079a0d6107be652bc026f5c91b7dcd791f8) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. The commit being backported was authored by Daniel Jeli?ski on 27 Mar 2023 and was reviewed by Daniel Fuchs and Michael McMahon. Thanks! ------------- Commit messages: - Backport a5ffa079a0d6107be652bc026f5c91b7dcd791f8 Changes: https://git.openjdk.org/jdk17u-dev/pull/2782/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2782&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7026262 Stats: 325 lines in 9 files changed: 288 ins; 19 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2782.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2782/head:pull/2782 PR: https://git.openjdk.org/jdk17u-dev/pull/2782 From clanger at openjdk.org Sat Aug 3 04:30:05 2024 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 3 Aug 2024 04:30:05 GMT Subject: [jdk17u-dev] RFR: 8304963: HttpServer closes connection after processing HEAD after JDK-7026262 Message-ID: Hi all, This pull request contains a backport of [JDK-8304963](https://bugs.openjdk.org/browse/JDK-8304963), commit [3c4cd50e](https://github.com/openjdk/jdk/commit/3c4cd50e3cef5905d6c5dacddd6759e118bc50ca) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Daniel Jeli?ski on 28 Mar 2023 and was reviewed by Daniel Fuchs. Thanks! ------------- Commit messages: - Backport 3c4cd50e3cef5905d6c5dacddd6759e118bc50ca Changes: https://git.openjdk.org/jdk17u-dev/pull/2783/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2783&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304963 Stats: 129 lines in 2 files changed: 129 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2783.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2783/head:pull/2783 PR: https://git.openjdk.org/jdk17u-dev/pull/2783 From andrew at openjdk.org Sat Aug 3 16:31:12 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 3 Aug 2024 16:31:12 GMT Subject: [jdk21u-dev] RFR: 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed Message-ID: Hi all, This pull request contains a clean backport of commit [9fd855ed](https://github.com/openjdk/jdk/commit/9fd855ed477bb0849ce5c774854844deec0f4c6b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Weijun Wang on 11 Jan 2024 and was reviewed by Sean Mullan and Valerie Peng. Tests in `test/jdk/javax/crypto/KEM` and `test/jdk/com/sun/crypto/provider/DHKEM` all passed on the patched build. The change jumped 21u and [is already in 17u](https://git.openjdk.org/jdk17u/commit/e49367bba1733eaad374c152e04e2af322956466), thanks to the 17.0.0.1 RI, so we should get it fixed here too. Thanks! ------------- Commit messages: - Backport 9fd855ed477bb0849ce5c774854844deec0f4c6b Changes: https://git.openjdk.org/jdk21u-dev/pull/893/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=893&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322971 Stats: 119 lines in 4 files changed: 74 ins; 29 del; 16 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/893.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/893/head:pull/893 PR: https://git.openjdk.org/jdk21u-dev/pull/893 From andrewlu at openjdk.org Mon Aug 5 02:14:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 5 Aug 2024 02:14:40 GMT Subject: [jdk17u-dev] Integrated: 8317112: Add screenshot for Frame/DefaultSizeTest.java In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 08:43:25 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 66fa7568 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/66fa75681fbc83d6a744ae2a22f7c149dc66da5d Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8317112: Add screenshot for Frame/DefaultSizeTest.java Backport-of: a36eaf03afd148581a9d9754f85a652cac84d655 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2764 From andrewlu at openjdk.org Mon Aug 5 02:16:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 5 Aug 2024 02:16:41 GMT Subject: [jdk11u-dev] Integrated: 8317343: GC: Make TestHeapFreeRatio use createTestJvm In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 08:42:47 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: 1daafddf Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/1daafddfd02f1e01a46bf1228877f6f261ce4c24 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8317343: GC: Make TestHeapFreeRatio use createTestJvm Backport-of: c64bd3d6715304accd9a1e3266edd9d3d2353273 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2893 From andrewlu at openjdk.org Mon Aug 5 02:18:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 5 Aug 2024 02:18:39 GMT Subject: [jdk17u-dev] Integrated: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion In-Reply-To: <9IlX43O19NAjLGudgijyGkEZrOixUJz6OiL5Kq12jVM=.70e51266-1ea8-40d9-840f-e6ab5d6b5819@github.com> References: <9IlX43O19NAjLGudgijyGkEZrOixUJz6OiL5Kq12jVM=.70e51266-1ea8-40d9-840f-e6ab5d6b5819@github.com> Message-ID: On Thu, 1 Aug 2024 02:27:41 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 37726c5f Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/37726c5f283248d5f7a827cd45be58168fc2a7e2 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Backport-of: ae9f318fc35eeab497e546ebab9faed6ec774ec5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2757 From duke at openjdk.org Mon Aug 5 06:28:08 2024 From: duke at openjdk.org (Vanitha B P) Date: Mon, 5 Aug 2024 06:28:08 GMT Subject: [jdk23u] RFR: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive [v2] In-Reply-To: References: Message-ID: > It is a clean backport. Vanitha B P has updated the pull request incrementally with one additional commit since the last revision: Vanitha B P ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/51/files - new: https://git.openjdk.org/jdk23u/pull/51/files/067e9097..8e520751 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=51&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=51&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/51.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/51/head:pull/51 PR: https://git.openjdk.org/jdk23u/pull/51 From mbaesken at openjdk.org Mon Aug 5 07:08:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 5 Aug 2024 07:08:08 GMT Subject: [jdk21u-dev] RFR: 8333622: ubsan: relocInfo_x86.cpp:101:56: runtime error: pointer index expression with base (-1) overflowed Message-ID: <6n26VZ_aD97qadiZLMzH6uRwKgKyzWuuEWHnb2RI8pM=.be28374d-95c3-45a9-84a6-f6bb50c1dd24@github.com> 8333622: ubsan: relocInfo_x86.cpp:101:56: runtime error: pointer index expression with base (-1) overflowed ------------- Commit messages: - Backport 33fd6ae98638d2a4b33d18cc4acee4f0daaa9b35 Changes: https://git.openjdk.org/jdk21u-dev/pull/894/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=894&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333622 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/894.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/894/head:pull/894 PR: https://git.openjdk.org/jdk21u-dev/pull/894 From duke at openjdk.org Mon Aug 5 08:23:36 2024 From: duke at openjdk.org (duke) Date: Mon, 5 Aug 2024 08:23:36 GMT Subject: [jdk23u] RFR: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive [v2] In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 06:28:08 GMT, Vanitha B P wrote: >> It is a clean backport. > > Vanitha B P has updated the pull request incrementally with one additional commit since the last revision: > > Vanitha B P @Vanitha-bp Your change (at version 8e520751e12a9f8dc7612ee5d11bc26ab7d1d19a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/51#issuecomment-2268460837 From duke at openjdk.org Mon Aug 5 08:53:31 2024 From: duke at openjdk.org (Vanitha B P) Date: Mon, 5 Aug 2024 08:53:31 GMT Subject: [jdk23u] RFR: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive [v2] In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 06:28:08 GMT, Vanitha B P wrote: >> It is a clean backport. > > Vanitha B P has updated the pull request incrementally with one additional commit since the last revision: > > Vanitha B P @coffeys Can you please sponsor? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/51#issuecomment-2268521288 From shade at openjdk.org Mon Aug 5 09:01:45 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 09:01:45 GMT Subject: [jdk17u-dev] RFR: 8290966: G1: Record number of PLAB filled and number of direct allocations In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 21:36:02 GMT, Ben Taylor wrote: > Clean, low risk backport of a change to improve logging around full PLABs and direct allocations. > > Passes the included test, as well as `make test TEST=gc/g1` locally on linux x64. Looks fine. I noticed Atomics can be improved a little bit: https://bugs.openjdk.org/browse/JDK-8337815 ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2777#pullrequestreview-2218430348 From clanger at openjdk.org Mon Aug 5 10:01:39 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 5 Aug 2024 10:01:39 GMT Subject: [jdk17u-dev] RFR: 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused In-Reply-To: <4VImzeHwIc-Zt7cb28XJur0LNX9s5PA-YdiRI1sCVb8=.8548cd20-91f0-4c50-899e-297e31cb9dab@github.com> References: <4VImzeHwIc-Zt7cb28XJur0LNX9s5PA-YdiRI1sCVb8=.8548cd20-91f0-4c50-899e-297e31cb9dab@github.com> Message-ID: On Sat, 3 Aug 2024 04:05:46 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8304962](https://bugs.openjdk.org/browse/JDK-8304962), commit [cddaf686](https://github.com/openjdk/jdk21u-dev/commit/cddaf686e16424e9543be50a48b1c02337e79cf1) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by Daniel Jeli?ski on 28 Mar 2023 and was reviewed by Jaikiran Pai. > > Thanks! Closing in favor of #2772 (Sorry @amosshi, didn't see that you were already doing this) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2781#issuecomment-2268679539 From clanger at openjdk.org Mon Aug 5 10:01:40 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 5 Aug 2024 10:01:40 GMT Subject: [jdk17u-dev] Withdrawn: 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused In-Reply-To: <4VImzeHwIc-Zt7cb28XJur0LNX9s5PA-YdiRI1sCVb8=.8548cd20-91f0-4c50-899e-297e31cb9dab@github.com> References: <4VImzeHwIc-Zt7cb28XJur0LNX9s5PA-YdiRI1sCVb8=.8548cd20-91f0-4c50-899e-297e31cb9dab@github.com> Message-ID: On Sat, 3 Aug 2024 04:05:46 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8304962](https://bugs.openjdk.org/browse/JDK-8304962), commit [cddaf686](https://github.com/openjdk/jdk21u-dev/commit/cddaf686e16424e9543be50a48b1c02337e79cf1) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by Daniel Jeli?ski on 28 Mar 2023 and was reviewed by Jaikiran Pai. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2781 From ogillespie at openjdk.org Mon Aug 5 10:21:19 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 5 Aug 2024 10:21:19 GMT Subject: [jdk17u-dev] RFR: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn. > > It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue. > > Thanks! Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: Backport 29233e0a001adde71a3fa5d56292ccfba8409ea5 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2776/files - new: https://git.openjdk.org/jdk17u-dev/pull/2776/files/350f7696..9409b2f3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2776&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2776&range=00-01 Stats: 10 lines in 1 file changed: 1 ins; 3 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2776.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2776/head:pull/2776 PR: https://git.openjdk.org/jdk17u-dev/pull/2776 From shade at openjdk.org Mon Aug 5 10:21:19 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 10:21:19 GMT Subject: [jdk17u-dev] RFR: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared [v2] In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 10:17:37 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn. >> >> It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue. >> >> Thanks! > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Backport 29233e0a001adde71a3fa5d56292ccfba8409ea5 Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2776#pullrequestreview-2218615908 From duke at openjdk.org Mon Aug 5 13:34:32 2024 From: duke at openjdk.org (duke) Date: Mon, 5 Aug 2024 13:34:32 GMT Subject: [jdk23u] RFR: 8330702: Update failure handler to don't generate Error message if cores actions are empty In-Reply-To: References: Message-ID: On Mon, 24 Jun 2024 12:54:54 GMT, Mimoun Ghordou wrote: > Tested Tier 1 @ghmaimon Your change (at version 6fe6a5aeab9351a0221d73c3c5963433dd9ebfb0) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/5#issuecomment-2269089419 From duke at openjdk.org Mon Aug 5 13:52:38 2024 From: duke at openjdk.org (duke) Date: Mon, 5 Aug 2024 13:52:38 GMT Subject: [jdk23u] RFR: 8328723: IP Address error when client enables HTTPS endpoint check on server socket In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 07:36:30 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport and test runs are green @pkumaraswamy Your change (at version 7f2931eb440a5505b8bef05b3f30e935693d356b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/48#issuecomment-2269129473 From duke at openjdk.org Mon Aug 5 13:54:38 2024 From: duke at openjdk.org (Mimoun Ghordou) Date: Mon, 5 Aug 2024 13:54:38 GMT Subject: [jdk23u] Integrated: 8330702: Update failure handler to don't generate Error message if cores actions are empty In-Reply-To: References: Message-ID: <0BXUIHCUVFY6L8ACHQTUIS2UZcYHzqIBWr-wiVjOUPs=.a4086368-b588-4236-8299-8c2294d8aaa5@github.com> On Mon, 24 Jun 2024 12:54:54 GMT, Mimoun Ghordou wrote: > Tested Tier 1 This pull request has now been integrated. Changeset: 1e1e5978 Author: Leonid Mesnik Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/1e1e597899bfd92f4f0e551bcbedb97765a064ee Stats: 9 lines in 2 files changed: 5 ins; 0 del; 4 mod 8330702: Update failure handler to don't generate Error message if cores actions are empty Reviewed-by: lmesnik, coffeys Backport-of: 548e95a689d63e97ddbdfe7dd7df3a2e3377046c ------------- PR: https://git.openjdk.org/jdk23u/pull/5 From duke at openjdk.org Mon Aug 5 13:59:35 2024 From: duke at openjdk.org (duke) Date: Mon, 5 Aug 2024 13:59:35 GMT Subject: [jdk17u-dev] Withdrawn: 8272317: jstatd has dependency on Security Manager which needs to be removed In-Reply-To: <8AiQeYQHemWRcrECE1z53PC-lvp0dQZpXV_yB-Ve-aQ=.51d9b676-89ce-4e40-a5eb-e38759fad744@github.com> References: <8AiQeYQHemWRcrECE1z53PC-lvp0dQZpXV_yB-Ve-aQ=.51d9b676-89ce-4e40-a5eb-e38759fad744@github.com> Message-ID: On Thu, 6 Jun 2024 09:40:13 GMT, Aleksey Shipilev wrote: > Semi-clean backport to resolve the jstatd dependency on SM. Current `jstatd` tests are also failing because some recently backported tests do not expect SM deprecation messages, see [JDK-8333698](https://bugs.openjdk.org/browse/JDK-8333698). > > This also reverts 17u-specific test amendment, [JDK-8272317](https://bugs.openjdk.org/browse/JDK-8272317). > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `sun/tools/jstatd/` now pass This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2542 From phh at openjdk.org Mon Aug 5 14:05:32 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 5 Aug 2024 14:05:32 GMT Subject: [jdk23u] RFR: 8328723: IP Address error when client enables HTTPS endpoint check on server socket In-Reply-To: References: Message-ID: <1fr394U6ywl6NVw5k93MQRwZG5ctoM-F7_zGrBcoOaE=.8d211f5a-c657-4288-8d87-164b607c28bb@github.com> On Wed, 31 Jul 2024 07:36:30 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport and test runs are green Please configure pre-submit testing on this repo. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/48#issuecomment-2269156219 From pkumaraswamy at openjdk.org Mon Aug 5 14:05:32 2024 From: pkumaraswamy at openjdk.org (Prajwal Kumaraswamy) Date: Mon, 5 Aug 2024 14:05:32 GMT Subject: [jdk23u] Integrated: 8328723: IP Address error when client enables HTTPS endpoint check on server socket In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 07:36:30 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport and test runs are green This pull request has now been integrated. Changeset: c3d15683 Author: Prajwal Kumaraswamy Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/c3d1568363e0d34e9730a1cf5e90c01a2dec807f Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod 8328723: IP Address error when client enables HTTPS endpoint check on server socket Backport-of: 1b9270ac8a76b482103dd3f6b12606a22214e554 ------------- PR: https://git.openjdk.org/jdk23u/pull/48 From shade at openjdk.org Mon Aug 5 17:56:04 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 17:56:04 GMT Subject: [jdk23u] RFR: 8337283: configure.log is truncated when build dir is on different filesystem Message-ID: Keeps `configure.log` nice and complete. I have been running with this patch for more than a week in 23u builds, and there were no problems. ------------- Commit messages: - Backport 7e925d727f716e5c366b0d85b9c0de24efe43103 Changes: https://git.openjdk.org/jdk23u/pull/53/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=53&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337283 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/53.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/53/head:pull/53 PR: https://git.openjdk.org/jdk23u/pull/53 From shade at openjdk.org Mon Aug 5 17:57:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 17:57:59 GMT Subject: [jdk23u] RFR: 8336342: Fix known X11 library locations in sysroot Message-ID: <6nu_K76RSzQE2La8dE2CI79DBRSpTcF-fHDWPljH3_M=.6ec7ab61-b53b-4e22-abe7-0e5bc2687497@github.com> Allows cleaner cross-builds without supplying `--x-libraries` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 23u builds, and there were no problems. ------------- Commit messages: - Backport ee365d75cca6f33e5781fe514e557caba2b67c32 Changes: https://git.openjdk.org/jdk23u/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=54&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336342 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/54.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/54/head:pull/54 PR: https://git.openjdk.org/jdk23u/pull/54 From shade at openjdk.org Mon Aug 5 17:58:03 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 17:58:03 GMT Subject: [jdk23u] RFR: 8336343: Add more known sysroot library locations for ALSA Message-ID: Allows cleaner cross-builds without supplying `--with-alsa` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 23u builds, and there were no problems. ------------- Commit messages: - Backport 9e6e0a8f341389215f0db6b2260f2b16351f02be Changes: https://git.openjdk.org/jdk23u/pull/55/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=55&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336343 Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/55.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/55/head:pull/55 PR: https://git.openjdk.org/jdk23u/pull/55 From shade at openjdk.org Mon Aug 5 18:01:15 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 18:01:15 GMT Subject: [jdk21u-dev] RFR: 8337283: configure.log is truncated when build dir is on different filesystem Message-ID: Keeps `configure.log` nice and complete. I have been running with this patch for more than a week in 21u-dev builds, and there were no problems. ------------- Commit messages: - Backport 7e925d727f716e5c366b0d85b9c0de24efe43103 Changes: https://git.openjdk.org/jdk21u-dev/pull/895/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=895&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337283 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/895.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/895/head:pull/895 PR: https://git.openjdk.org/jdk21u-dev/pull/895 From shade at openjdk.org Mon Aug 5 18:07:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 18:07:51 GMT Subject: [jdk17u-dev] RFR: 8337283: configure.log is truncated when build dir is on different filesystem Message-ID: Keeps `configure.log` nice and complete. I have been running with this patch for more than a week in 17u-dev builds, and there were no problems. ------------- Commit messages: - Backport 7e925d727f716e5c366b0d85b9c0de24efe43103 Changes: https://git.openjdk.org/jdk17u-dev/pull/2784/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2784&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337283 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2784.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2784/head:pull/2784 PR: https://git.openjdk.org/jdk17u-dev/pull/2784 From shade at openjdk.org Mon Aug 5 18:14:47 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 18:14:47 GMT Subject: [jdk17u-dev] RFR: 8336342: Fix known X11 library locations in sysroot Message-ID: Allows cleaner cross-builds without supplying `--x-libraries` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 17u-dev builds, and there were no problems. ------------- Commit messages: - Backport ee365d75cca6f33e5781fe514e557caba2b67c32 Changes: https://git.openjdk.org/jdk17u-dev/pull/2785/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2785&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336342 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2785.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2785/head:pull/2785 PR: https://git.openjdk.org/jdk17u-dev/pull/2785 From shade at openjdk.org Mon Aug 5 18:15:45 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 18:15:45 GMT Subject: [jdk21u-dev] RFR: 8336342: Fix known X11 library locations in sysroot Message-ID: Allows cleaner cross-builds without supplying `--x-libraries` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 21u-dev builds, and there were no problems. ------------- Commit messages: - Backport ee365d75cca6f33e5781fe514e557caba2b67c32 Changes: https://git.openjdk.org/jdk21u-dev/pull/896/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=896&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336342 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/896.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/896/head:pull/896 PR: https://git.openjdk.org/jdk21u-dev/pull/896 From shade at openjdk.org Mon Aug 5 18:17:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 18:17:51 GMT Subject: [jdk21u-dev] RFR: 8336343: Add more known sysroot library locations for ALSA Message-ID: Allows cleaner cross-builds without supplying `--with-alsa` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 21u-dev builds, and there were no problems. ------------- Commit messages: - Backport 9e6e0a8f341389215f0db6b2260f2b16351f02be Changes: https://git.openjdk.org/jdk21u-dev/pull/897/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=897&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336343 Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/897.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/897/head:pull/897 PR: https://git.openjdk.org/jdk21u-dev/pull/897 From shade at openjdk.org Mon Aug 5 18:21:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 5 Aug 2024 18:21:44 GMT Subject: [jdk17u-dev] RFR: 8336343: Add more known sysroot library locations for ALSA Message-ID: Allows cleaner cross-builds without supplying `--with-alsa` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 17u-dev builds, and there were no problems. ------------- Commit messages: - Backport 9e6e0a8f341389215f0db6b2260f2b16351f02be Changes: https://git.openjdk.org/jdk17u-dev/pull/2786/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2786&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336343 Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2786.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2786/head:pull/2786 PR: https://git.openjdk.org/jdk17u-dev/pull/2786 From duke at openjdk.org Tue Aug 6 01:31:43 2024 From: duke at openjdk.org (duke) Date: Tue, 6 Aug 2024 01:31:43 GMT Subject: [jdk17u-dev] RFR: 8335536: Fix assertion failure in IdealGraphPrinter when append is true In-Reply-To: References: Message-ID: On Thu, 4 Jul 2024 03:06:59 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [6db4c6a7](https://github.com/openjdk/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein. > > The original patch does not apply cleanly to 17u due to some merge conflicts about creating `xmlStream` with placement `new` expressions. > > Thanks! @MaxXSoft Your change (at version 6a4a350d412ef0ffb62f2c99b83619279016b9e4) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2657#issuecomment-2270192171 From andrewlu at openjdk.org Tue Aug 6 02:16:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 6 Aug 2024 02:16:40 GMT Subject: [jdk11u-dev] Integrated: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:28:31 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: c5d2cc13 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/c5d2cc138fed05c8dfcd13f6d786dd5c8dae4560 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Backport-of: ae9f318fc35eeab497e546ebab9faed6ec774ec5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2889 From andrewlu at openjdk.org Tue Aug 6 02:16:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 6 Aug 2024 02:16:42 GMT Subject: [jdk11u-dev] Integrated: 8317358: G1: Make TestMaxNewSize use createTestJvm In-Reply-To: References: Message-ID: On Tue, 16 Jul 2024 06:31:02 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: 7d346936 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/7d3469361210546c24715f8c7b7df95e8f876c7b Stats: 33 lines in 1 file changed: 3 ins; 23 del; 7 mod 8317358: G1: Make TestMaxNewSize use createTestJvm Backport-of: 1a098356dd3a157b12c2b5c527e61c8a628bdb2d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2858 From mbaesken at openjdk.org Tue Aug 6 07:08:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 6 Aug 2024 07:08:34 GMT Subject: [jdk11u-dev] Integrated: 8229822: ThrowingPushPromises tests sometimes fail due to EOF In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 09:36:46 GMT, Matthias Baesken wrote: > 8229822: ThrowingPushPromises tests sometimes fail due to EOF This pull request has now been integrated. Changeset: 3acdebea Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/3acdebea8539c12a7a6c6503976e8f74859d2264 Stats: 170 lines in 10 files changed: 141 ins; 1 del; 28 mod 8229822: ThrowingPushPromises tests sometimes fail due to EOF SocketTube is fixed to cater for errors caused by pausing/resuming events on an asynchronously closed connection, from within the selector's manager thread. Http2Connection and Stream are fixed to prevent sending a DataFrame on a stream after Reset has been sent. Backport-of: 77c46ea9112b0c2632b4af1d899d59a132878da3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2895 From mbaesken at openjdk.org Tue Aug 6 07:12:43 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 6 Aug 2024 07:12:43 GMT Subject: [jdk21u-dev] Integrated: 8333622: ubsan: relocInfo_x86.cpp:101:56: runtime error: pointer index expression with base (-1) overflowed In-Reply-To: <6n26VZ_aD97qadiZLMzH6uRwKgKyzWuuEWHnb2RI8pM=.be28374d-95c3-45a9-84a6-f6bb50c1dd24@github.com> References: <6n26VZ_aD97qadiZLMzH6uRwKgKyzWuuEWHnb2RI8pM=.be28374d-95c3-45a9-84a6-f6bb50c1dd24@github.com> Message-ID: On Mon, 5 Aug 2024 06:37:48 GMT, Matthias Baesken wrote: > 8333622: ubsan: relocInfo_x86.cpp:101:56: runtime error: pointer index expression with base (-1) overflowed This pull request has now been integrated. Changeset: dac39de0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/dac39de0ff69fa3d073256062a052ba369d18e7d Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8333622: ubsan: relocInfo_x86.cpp:101:56: runtime error: pointer index expression with base (-1) overflowed Backport-of: 33fd6ae98638d2a4b33d18cc4acee4f0daaa9b35 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/894 From duke at openjdk.org Tue Aug 6 08:56:40 2024 From: duke at openjdk.org (duke) Date: Tue, 6 Aug 2024 08:56:40 GMT Subject: [jdk17u-dev] RFR: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared [v2] In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 10:21:19 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn. >> >> It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue. >> >> Edit: This now also backports 8307448/https://github.com/openjdk/jdk/commit/29233e0a001adde71a3fa5d56292ccfba8409ea5 to fix the flaky test. 8307448 applied cleanly. >> >> Testing - looks good, just 3 unrelated tests failing on my machine. >> >> >> JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all >> >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:all 6131 6131 0 0 >>>> jtreg:test/jdk:all 9140 9137 3 0 << >> jtreg:test/langtools:all 4251 4251 0 0 >> jtreg:test/jaxp:all 467 467 0 0 >> jtreg:test/lib-test:all 30 30 0 0 >> >> build/AbsPathsInImage.java Failed. Execution failed: `main' threw exception: java.lang.Exception: Test failed >> java/nio/channels/FileChannel/directio/DirectIOTest.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: DirectIO is not working properly with read. File still exists in cache! >> jdk/internal/platform/docker/TestDockerMemoryMetrics.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Expected to get exit value of [0] >> >> >> Thanks! > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Backport 29233e0a001adde71a3fa5d56292ccfba8409ea5 @olivergillespie Your change (at version 9409b2f3111624ac1aec76658d1a065f0212a140) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2776#issuecomment-2270741887 From ogillespie at openjdk.org Tue Aug 6 09:01:37 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 6 Aug 2024 09:01:37 GMT Subject: [jdk17u-dev] Integrated: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:20:38 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn. > > It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue. > > Edit: This now also backports 8307448/https://github.com/openjdk/jdk/commit/29233e0a001adde71a3fa5d56292ccfba8409ea5 to fix the flaky test. 8307448 applied cleanly. > > Testing - looks good, just 3 unrelated tests failing on my machine. > > > JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all > > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:all 6131 6131 0 0 >>> jtreg:test/jdk:all 9140 9137 3 0 << > jtreg:test/langtools:all 4251 4251 0 0 > jtreg:test/jaxp:all 467 467 0 0 > jtreg:test/lib-test:all 30 30 0 0 > > build/AbsPathsInImage.java Failed. Execution failed: `main' threw exception: java.lang.Exception: Test failed > java/nio/channels/FileChannel/directio/DirectIOTest.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: DirectIO is not working properly with read. File still exists in cache! > jdk/internal/platform/docker/TestDockerMemoryMetrics.java Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Expected to get exit value of [0] > > > Thanks! This pull request has now been integrated. Changeset: 1f14f860 Author: Oli Gillespie Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/1f14f86087d4da6bad981f53f309e8d9da31f5d0 Stats: 148 lines in 6 files changed: 125 ins; 3 del; 20 mod 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared 8307448: Test RedefineSharedClassJFR fail due to wrong assumption Reviewed-by: shade Backport-of: 408cec516bb5fd82fb6dcddeee934ac0c5ecffaf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2776 From clanger at openjdk.org Tue Aug 6 09:07:07 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 6 Aug 2024 09:07:07 GMT Subject: [jdk23u] RFR: 8337819: Update GHA JDKs to 22.0.2 Message-ID: Hi all, This pull request contains a backport of [JDK-8337819](https://bugs.openjdk.org/browse/JDK-8337819), commit [08f697f4](https://github.com/openjdk/jdk/commit/08f697f4fcbcdd912c3aa5f331fbf8212906465f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christoph Langer on 5 Aug 2024 and was reviewed by Matthias Baesken, Magnus Ihse Bursie and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 08f697f4fcbcdd912c3aa5f331fbf8212906465f Changes: https://git.openjdk.org/jdk23u/pull/56/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=56&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337819 Stats: 14 lines in 1 file changed: 4 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk23u/pull/56.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/56/head:pull/56 PR: https://git.openjdk.org/jdk23u/pull/56 From duke at openjdk.org Tue Aug 6 10:32:37 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Tue, 6 Aug 2024 10:32:37 GMT Subject: [jdk21u-dev] RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread In-Reply-To: References: Message-ID: On Fri, 19 Jul 2024 09:02:41 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8335743. > It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. > I created the pull request https://github.com/openjdk/jdk21u-dev/pull/854 which backports JDK-8336284. > > Testing: > hotspot/jtreg/serviceability/sa and jdk/sun/tools/jhsdb Would anyone review this PR? This backport is clean. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/853#issuecomment-2270943291 From mbaesken at openjdk.org Tue Aug 6 11:51:53 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 6 Aug 2024 11:51:53 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly In-Reply-To: References: Message-ID: On Tue, 6 Aug 2024 11:45:58 GMT, Matthias Baesken wrote: > Backport of 8292044 from 17 HttpClientImpl.java exception block needs manual addition, diffs in the stride @@ -582,6 +583,8 @@ final class HttpClientImpl extends HttpClient implements Trackable { // any other SSLException is wrapped in a plain // SSLException throw new SSLException(msg, throwable); + } else if (throwable instanceof ProtocolException) { + throw new ProtocolException(msg); } else if (throwable instanceof IOException) { throw new IOException(msg, throwable); } else { Stream.java checkRequestCancelled() not in, avoid this change part test Response1xxTest.java has to be adjusted to build ; and testSecureHTTP2Unexpected101 gets an IOException not a ProtocolException (seems there are some diffs/other changes 11 compared to 17/21) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2896#issuecomment-2271100689 From mbaesken at openjdk.org Tue Aug 6 11:51:53 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 6 Aug 2024 11:51:53 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly Message-ID: Backport of 8292044 from 17 ------------- Commit messages: - Backport 10000286390ac9b0288cee25a4f3551d09475fdc Changes: https://git.openjdk.org/jdk11u-dev/pull/2896/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2896&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292044 Stats: 618 lines in 7 files changed: 610 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2896.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2896/head:pull/2896 PR: https://git.openjdk.org/jdk11u-dev/pull/2896 From phh at openjdk.org Tue Aug 6 12:44:42 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 6 Aug 2024 12:44:42 GMT Subject: [jdk17u-dev] RFR: 8335536: Fix assertion failure in IdealGraphPrinter when append is true In-Reply-To: References: Message-ID: <7dTd7dvzzrFi_C4RLSyCPtMVmnkuvm9d21SBqhGEfCM=.8260d97b-fbef-40ed-85e9-3684bbe52fc0@github.com> On Thu, 4 Jul 2024 03:06:59 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [6db4c6a7](https://github.com/openjdk/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein. > > The original patch does not apply cleanly to 17u due to some merge conflicts about creating `xmlStream` with placement `new` expressions. > > Thanks! Presubmit testing for macos seems to be hung. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2657#issuecomment-2271197349 From qxing at openjdk.org Tue Aug 6 12:44:42 2024 From: qxing at openjdk.org (Qizheng Xing) Date: Tue, 6 Aug 2024 12:44:42 GMT Subject: [jdk17u-dev] Integrated: 8335536: Fix assertion failure in IdealGraphPrinter when append is true In-Reply-To: References: Message-ID: <9zYd1F8tLSMBxgEFZZDK_f6g7ssy7dd4pc7c-O0bcAE=.46befe12-072d-47bc-9120-e8a5cf169ebc@github.com> On Thu, 4 Jul 2024 03:06:59 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [6db4c6a7](https://github.com/openjdk/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 3 Jul 2024 and was reviewed by Tobias Hartmann, Christian Hagedorn and Tobias Holenstein. > > The original patch does not apply cleanly to 17u due to some merge conflicts about creating `xmlStream` with placement `new` expressions. > > Thanks! This pull request has now been integrated. Changeset: ae7be19a Author: Qizheng Xing Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/ae7be19a7f14aec3af69d2db1509bf7f6d793f35 Stats: 22 lines in 2 files changed: 11 ins; 0 del; 11 mod 8335536: Fix assertion failure in IdealGraphPrinter when append is true Reviewed-by: phh Backport-of: 6db4c6a772df856fc3099c32a5b2c102a30d360c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2657 From phh at openjdk.org Tue Aug 6 14:28:42 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 6 Aug 2024 14:28:42 GMT Subject: [jdk21u-dev] RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread In-Reply-To: References: Message-ID: On Fri, 19 Jul 2024 09:02:41 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8335743. > It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. > I created the pull request https://github.com/openjdk/jdk21u-dev/pull/854 which backports JDK-8336284. > > Testing: > hotspot/jtreg/serviceability/sa and jdk/sun/tools/jhsdb You need to change the PR title to "Backport in order for the bot to recognize it as a backport. If the bot recognizes it as clean, you can go ahead and ask for maintainer approval. The maintainer will probably want you to also backport to 23u. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/853#issuecomment-2271431242 From duke at openjdk.org Tue Aug 6 14:56:03 2024 From: duke at openjdk.org (Mimoun Ghordou) Date: Tue, 6 Aug 2024 14:56:03 GMT Subject: [jdk23u] RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java Message-ID: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Clean Backport Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine ------------- Commit messages: - 8335397: Improve reliability of TestRecursiveMonitorChurn.java Changes: https://git.openjdk.org/jdk23u/pull/57/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=57&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335397 Stats: 77 lines in 5 files changed: 28 ins; 31 del; 18 mod Patch: https://git.openjdk.org/jdk23u/pull/57.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/57/head:pull/57 PR: https://git.openjdk.org/jdk23u/pull/57 From duke at openjdk.org Wed Aug 7 06:08:37 2024 From: duke at openjdk.org (duke) Date: Wed, 7 Aug 2024 06:08:37 GMT Subject: [jdk23u] RFR: 8333754: Add a Test against ECDSA and ECDH NIST Test vector In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 11:09:22 GMT, Ramesh Bhagavatam Gangadhar wrote: > 8333754: Add a Test against ECDSA and ECDH NIST Test vector @rgangadhar Your change (at version 0d66833913e410320be87a37f81ec76f024fef10) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/46#issuecomment-2272686528 From rgangadhar at openjdk.org Wed Aug 7 06:43:40 2024 From: rgangadhar at openjdk.org (Ramesh Bhagavatam Gangadhar) Date: Wed, 7 Aug 2024 06:43:40 GMT Subject: [jdk23u] Integrated: 8333754: Add a Test against ECDSA and ECDH NIST Test vector In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 11:09:22 GMT, Ramesh Bhagavatam Gangadhar wrote: > 8333754: Add a Test against ECDSA and ECDH NIST Test vector This pull request has now been integrated. Changeset: 474db8db Author: Ramesh Bhagavatam Gangadhar Committer: Sibabrata Sahoo URL: https://git.openjdk.org/jdk23u/commit/474db8db3c8d4124f657ffcc4d70e94f0d119705 Stats: 9501 lines in 4 files changed: 9501 ins; 0 del; 0 mod 8333754: Add a Test against ECDSA and ECDH NIST Test vector Backport-of: fad6644eabbad6b6d3472206d9db946408aca612 ------------- PR: https://git.openjdk.org/jdk23u/pull/46 From goetz at openjdk.org Wed Aug 7 07:36:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 7 Aug 2024 07:36:43 GMT Subject: [jdk17u-dev] RFR: 8337669: [17u] Backport of JDK-8284047 missed to delete a file [v2] In-Reply-To: References: Message-ID: <7mSVzpY37Ram9uGtfdi548PhxX07rLg4t79cTL1kbGA=.1fd6ffd6-1602-40e5-95e2-ce1bfdfedf72@github.com> On Fri, 2 Aug 2024 12:45:50 GMT, Christoph Langer wrote: >> The backport of JDK-8284047 to jdk17u should have deleted the file test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketBruceForceClose.java but it didn't. Let's do it now. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into deletebruce > - JDK-8337669 Oh, thanks for fixing this! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2767#issuecomment-2272815065 From mbaesken at openjdk.org Wed Aug 7 08:13:02 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 7 Aug 2024 08:13:02 GMT Subject: [jdk23u] RFR: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' Message-ID: <36n2OXGeR4EJm08BgTKVOZ_qT53CQK9scW0XWsEHYfo=.1b747961-8a32-4373-b7c9-88c5d5671311@github.com> 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' ------------- Commit messages: - Backport 0199fee431e0dccdd570b38595ea29c760dbed44 Changes: https://git.openjdk.org/jdk23u/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=58&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333639 Stats: 10 lines in 1 file changed: 2 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk23u/pull/58.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/58/head:pull/58 PR: https://git.openjdk.org/jdk23u/pull/58 From mbaesken at openjdk.org Wed Aug 7 08:15:52 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 7 Aug 2024 08:15:52 GMT Subject: [jdk21u-dev] RFR: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' Message-ID: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' ------------- Commit messages: - Backport 0199fee431e0dccdd570b38595ea29c760dbed44 Changes: https://git.openjdk.org/jdk21u-dev/pull/898/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=898&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333639 Stats: 10 lines in 1 file changed: 2 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/898.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/898/head:pull/898 PR: https://git.openjdk.org/jdk21u-dev/pull/898 From mbaesken at openjdk.org Wed Aug 7 08:20:49 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 7 Aug 2024 08:20:49 GMT Subject: [jdk21u-dev] RFR: 8335237: ubsan: vtableStubs.hpp is_vtable_stub exclude from ubsan checks Message-ID: Backport of 8335237, diff in stride at headers ------------- Commit messages: - Backport 486aa11e74d0772ba84c2adc3c62fc1fcbf52604 Changes: https://git.openjdk.org/jdk21u-dev/pull/899/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=899&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335237 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/899.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/899/head:pull/899 PR: https://git.openjdk.org/jdk21u-dev/pull/899 From mdoerr at openjdk.org Wed Aug 7 09:39:42 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 7 Aug 2024 09:39:42 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly In-Reply-To: References: Message-ID: On Tue, 6 Aug 2024 11:45:58 GMT, Matthias Baesken wrote: > Backport of 8292044 from 17 Ok, [JDK-8245462](https://bugs.openjdk.org/browse/JDK-8245462) is not in 11u. I have only one change request. test/jdk/java/net/httpclient/Response1xxTest.java line 447: > 445: // we expect the request to fail because the server sent an unexpected 101 > 446: // to check - we get here an IOException not a ProtocalException (compared to 17 or 21) > 447: //Assert.assertThrows(ProtocolException.class, Typo: `ProtocalException`. I think a better comment would be: Backport note: Later JDK versions throw a ProtocolException. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2896#pullrequestreview-2223726563 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2896#discussion_r1706700111 From afarley at openjdk.org Wed Aug 7 09:46:07 2024 From: afarley at openjdk.org (Adam Farley) Date: Wed, 7 Aug 2024 09:46:07 GMT Subject: [jdk11u-dev] RFR: 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk Message-ID: Hi all, This pull request contains a backport of commit [461fb320](https://github.com/openjdk/jdk17u-dev/commit/461fb320bc67de9e8f378b8a845f67764cd003ed) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. The commit being backported was authored by Adam Farley on 23 May 2022 and was reviewed by Andrew John Hughes. Thanks! ------------- Commit messages: - Backport 461fb320bc67de9e8f378b8a845f67764cd003ed Changes: https://git.openjdk.org/jdk11u-dev/pull/2897/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2897&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286601 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2897.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2897/head:pull/2897 PR: https://git.openjdk.org/jdk11u-dev/pull/2897 From afarley at openjdk.org Wed Aug 7 09:46:07 2024 From: afarley at openjdk.org (Adam Farley) Date: Wed, 7 Aug 2024 09:46:07 GMT Subject: [jdk11u-dev] RFR: 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 09:36:22 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [461fb320](https://github.com/openjdk/jdk17u-dev/commit/461fb320bc67de9e8f378b8a845f67764cd003ed) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Adam Farley on 23 May 2022 and was reviewed by Andrew John Hughes. > > Thanks! Associated with: https://bugs.openjdk.org/browse/JDK-8286601 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2897#issuecomment-2273046727 From duke at openjdk.org Wed Aug 7 09:47:06 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Wed, 7 Aug 2024 09:47:06 GMT Subject: [jdk23u] RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread Message-ID: Hi all, This pull request is the backport of JDK-8335743. It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. I will create the pull request for JDK-8336284 ------------- Commit messages: - 8335743: jhsdb jstack cannot print some information on the waiting thread Changes: https://git.openjdk.org/jdk23u/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=59&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335743 Stats: 25 lines in 4 files changed: 18 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk23u/pull/59.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/59/head:pull/59 PR: https://git.openjdk.org/jdk23u/pull/59 From duke at openjdk.org Wed Aug 7 10:43:09 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Wed, 7 Aug 2024 10:43:09 GMT Subject: [jdk23u] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 Message-ID: Hi all, This pull request is the backport of JDK-8336284 . It is clean. This change resolves a test failure introduced by JDK-8335743. JDK-8335743 will be backported in https://github.com/openjdk/jdk23u/pull/59. I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. ------------- Depends on: https://git.openjdk.org/jdk23u/pull/59 Commit messages: - 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 Changes: https://git.openjdk.org/jdk23u/pull/60/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=60&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336284 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/60.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/60/head:pull/60 PR: https://git.openjdk.org/jdk23u/pull/60 From duke at openjdk.org Wed Aug 7 10:45:37 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Wed, 7 Aug 2024 10:45:37 GMT Subject: [jdk21u-dev] RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread In-Reply-To: References: Message-ID: On Fri, 19 Jul 2024 09:02:41 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8335743. > It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. > I created the pull request https://github.com/openjdk/jdk21u-dev/pull/854 which backports JDK-8336284. > > Testing: > hotspot/jtreg/serviceability/sa and jdk/sun/tools/jhsdb Thank you for pointing that out. I changed the PR title. And I created the backport [PR](https://github.com/openjdk/jdk23u/pull/59 ) to jdk23u. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/853#issuecomment-2273170404 From mbaesken at openjdk.org Wed Aug 7 11:15:48 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 7 Aug 2024 11:15:48 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly [v2] In-Reply-To: References: Message-ID: > Backport of 8292044 from 17 Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: change comment in test about other exception class ProtocolException in jdk17 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2896/files - new: https://git.openjdk.org/jdk11u-dev/pull/2896/files/f55652e6..75c13614 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2896&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2896&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2896.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2896/head:pull/2896 PR: https://git.openjdk.org/jdk11u-dev/pull/2896 From mbaesken at openjdk.org Wed Aug 7 11:15:48 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 7 Aug 2024 11:15:48 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly [v2] In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 09:36:16 GMT, Martin Doerr wrote: >> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: >> >> change comment in test about other exception class ProtocolException in jdk17 > > test/jdk/java/net/httpclient/Response1xxTest.java line 447: > >> 445: // we expect the request to fail because the server sent an unexpected 101 >> 446: // to check - we get here an IOException not a ProtocalException (compared to 17 or 21) >> 447: //Assert.assertThrows(ProtocolException.class, > > Typo: `ProtocalException`. I think a better comment would be: > Backport note: Later JDK versions throw a ProtocolException. Hi Martin, I changed the comment . ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2896#discussion_r1706821512 From mdoerr at openjdk.org Wed Aug 7 13:13:39 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 7 Aug 2024 13:13:39 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly [v2] In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 11:15:48 GMT, Matthias Baesken wrote: >> Backport of 8292044 from 17 > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > change comment in test about other exception class ProtocolException in jdk17 The backport LGTM. It would still be good to know more details about the IOException. Do you have a stack trace with more Exception details or .jtr output? ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2896#pullrequestreview-2224958476 From clanger at openjdk.org Wed Aug 7 14:12:45 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Aug 2024 14:12:45 GMT Subject: [jdk17u-dev] Integrated: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java In-Reply-To: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> References: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> Message-ID: On Thu, 1 Aug 2024 14:19:49 GMT, Christoph Langer wrote: > Backport of 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java > > The wrong location is 17 is not "risv64" as it was in JDK 19 but here it is "riscv" which should be "riscv64" to make jdk.hotspot.agent compile correctly. This pull request has now been integrated. Changeset: 7230bafb Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/7230bafbb2124b7169de7819cfcbf4981cd38404 Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java Reviewed-by: mbaesken Backport-of: f4eaa16c0fe0659376325cec1c912a13ef0f1be8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2766 From clanger at openjdk.org Wed Aug 7 14:15:35 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Aug 2024 14:15:35 GMT Subject: [jdk17u-dev] Integrated: 8337669: [17u] Backport of JDK-8284047 missed to delete a file In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 14:26:16 GMT, Christoph Langer wrote: > The backport of JDK-8284047 to jdk17u should have deleted the file test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketBruceForceClose.java but it didn't. Let's do it now. This pull request has now been integrated. Changeset: 396e209f Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/396e209feb58c81d4271010c5c4c3fd605a1f653 Stats: 102 lines in 1 file changed: 0 ins; 102 del; 0 mod 8337669: [17u] Backport of JDK-8284047 missed to delete a file Reviewed-by: mbaesken, shade ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2767 From clanger at openjdk.org Wed Aug 7 14:19:40 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Aug 2024 14:19:40 GMT Subject: [jdk17u-dev] Integrated: 7026262: HttpServer: improve handling of finished HTTP exchanges In-Reply-To: References: Message-ID: On Sat, 3 Aug 2024 04:23:06 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-7026262](https://bugs.openjdk.org/browse/JDK-7026262), commit [a5ffa079](https://github.com/openjdk/jdk21u-dev/commit/a5ffa079a0d6107be652bc026f5c91b7dcd791f8) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by Daniel Jeli?ski on 27 Mar 2023 and was reviewed by Daniel Fuchs and Michael McMahon. > > Thanks! This pull request has now been integrated. Changeset: 966cafcd Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/966cafcd14e425061a79e0027dc5ac02c968f270 Stats: 325 lines in 9 files changed: 288 ins; 19 del; 18 mod 7026262: HttpServer: improve handling of finished HTTP exchanges Backport-of: a5ffa079a0d6107be652bc026f5c91b7dcd791f8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2782 From clanger at openjdk.org Wed Aug 7 14:21:39 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Aug 2024 14:21:39 GMT Subject: [jdk17u-dev] Integrated: 8304963: HttpServer closes connection after processing HEAD after JDK-7026262 In-Reply-To: References: Message-ID: <-qxMbrm2I8ltZvbwuxPGsWjigY8Stx6eMi0-CXtPfX0=.0d867a92-634e-41fb-a3d8-a930e88ea6d6@github.com> On Sat, 3 Aug 2024 04:23:54 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8304963](https://bugs.openjdk.org/browse/JDK-8304963), commit [3c4cd50e](https://github.com/openjdk/jdk/commit/3c4cd50e3cef5905d6c5dacddd6759e118bc50ca) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Daniel Jeli?ski on 28 Mar 2023 and was reviewed by Daniel Fuchs. > > Thanks! This pull request has now been integrated. Changeset: 7a53368b Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/7a53368b2b27585270184316c9b30a6fb27e33e6 Stats: 12 lines in 2 files changed: 3 ins; 5 del; 4 mod 8304963: HttpServer closes connection after processing HEAD after JDK-7026262 Backport-of: 3c4cd50e3cef5905d6c5dacddd6759e118bc50ca ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2783 From clanger at openjdk.org Wed Aug 7 15:08:42 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Aug 2024 15:08:42 GMT Subject: [jdk11u-dev] Integrated: 8330523: Reduce runtime and improve efficiency of KeepAliveTest In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 20:59:49 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8330523](https://bugs.openjdk.org/browse/JDK-8330523), commit [98038b3d](https://github.com/openjdk/jdk17u-dev/commit/98038b3dfd8984c28a37646de6b1cdaa4c7ae6a3) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Christoph Langer on 16 May 2024 and was reviewed by Matthias Baesken. > > Thanks! This pull request has now been integrated. Changeset: 648e8f01 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/648e8f01896b46aa338b1607de70dc1f17706008 Stats: 1242 lines in 1 file changed: 87 ins; 1023 del; 132 mod 8330523: Reduce runtime and improve efficiency of KeepAliveTest Backport-of: 98038b3dfd8984c28a37646de6b1cdaa4c7ae6a3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2888 From fyang at openjdk.org Wed Aug 7 15:10:39 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 7 Aug 2024 15:10:39 GMT Subject: [jdk17u-dev] RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java [v2] In-Reply-To: References: <8uTP7oKAH_PbsJ9ehzZyLxqOqBIJh2-zAMhHfKBxii8=.c856ec00-c568-4f23-9862-8af785b15be7@github.com> Message-ID: <54WVbniTNHDZ4Hirqx7DSiJ-oip_YpbkDw5kfauw5Xo=.f209d3c8-c9cf-4031-84bf-e88d8d2f36d3@github.com> On Fri, 2 Aug 2024 12:46:11 GMT, Christoph Langer wrote: >> Backport of 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java >> >> The wrong location is 17 is not "risv64" as it was in JDK 19 but here it is "riscv" which should be "riscv64" to make jdk.hotspot.agent compile correctly. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into riscstuff > - JDK-8283728 Hi, Thanks for finding and fixing this typo. Looks good. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2766#issuecomment-2273701216 From duke at openjdk.org Wed Aug 7 16:40:32 2024 From: duke at openjdk.org (duke) Date: Wed, 7 Aug 2024 16:40:32 GMT Subject: [jdk23u] RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java In-Reply-To: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> References: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Message-ID: On Tue, 6 Aug 2024 14:50:35 GMT, Mimoun Ghordou wrote: > Clean Backport > > Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine @ghmaimon Your change (at version a509fe081e7023f5d55de0599b465e745f67db6f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/57#issuecomment-2273878298 From btaylor at openjdk.org Wed Aug 7 18:16:40 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 7 Aug 2024 18:16:40 GMT Subject: [jdk17u-dev] Integrated: 8290966: G1: Record number of PLAB filled and number of direct allocations In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 21:36:02 GMT, Ben Taylor wrote: > Clean, low risk backport of a change to improve logging around full PLABs and direct allocations. > > Passes the included test, as well as `make test TEST=gc/g1` locally on linux x64. This pull request has now been integrated. Changeset: f07c2664 Author: Ben Taylor URL: https://git.openjdk.org/jdk17u-dev/commit/f07c266489dd13a9c80a8fd4ad4edb51111a1d86 Stats: 73 lines in 9 files changed: 51 ins; 0 del; 22 mod 8290966: G1: Record number of PLAB filled and number of direct allocations Reviewed-by: shade Backport-of: 30205bb289e9b25d60474b24b891e15923071b5a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2777 From clanger at openjdk.org Thu Aug 8 06:18:39 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 8 Aug 2024 06:18:39 GMT Subject: [jdk23u] Integrated: 8337819: Update GHA JDKs to 22.0.2 In-Reply-To: References: Message-ID: On Tue, 6 Aug 2024 09:00:54 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8337819](https://bugs.openjdk.org/browse/JDK-8337819), commit [08f697f4](https://github.com/openjdk/jdk/commit/08f697f4fcbcdd912c3aa5f331fbf8212906465f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christoph Langer on 5 Aug 2024 and was reviewed by Matthias Baesken, Magnus Ihse Bursie and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 0a86e830 Author: Christoph Langer URL: https://git.openjdk.org/jdk23u/commit/0a86e830af7853d7764af20eff442073fb01ccb2 Stats: 14 lines in 1 file changed: 4 ins; 4 del; 6 mod 8337819: Update GHA JDKs to 22.0.2 Backport-of: 08f697f4fcbcdd912c3aa5f331fbf8212906465f ------------- PR: https://git.openjdk.org/jdk23u/pull/56 From ashi at openjdk.org Thu Aug 8 06:48:33 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 8 Aug 2024 06:48:33 GMT Subject: [jdk17u-dev] Integrated: 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused In-Reply-To: References: Message-ID: <3vz7ci57641yIBXgTQmKhSwHVMvmwLUGmBmGCEXrwZg=.39e1c0b0-f35a-4f15-a3b9-5d6499aa0bb7@github.com> On Fri, 2 Aug 2024 00:18:31 GMT, Amos Shi wrote: > Backport of [JDK-8304962](https://bugs.openjdk.org/browse/JDK-8304962) > > Testing > - Local: Test passed > - `B5045306.java`: Test results: passed: 1 > - Pipeline > - linux-x64,x86, windows-aarch64,x64 macos-aarch64,x64 - passed > - The failed test case is not related to current PR and has been fixed in master branch > - Testing Machine: SAP nightlies passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier2 > - Started at 2024-08-06 21:10:46+01:00 > - `sun/net/www/http/KeepAliveCache/B5045306.java`: SUCCESSFUL GitHub ? - [21:36:33.819 -> 13,634 msec] This pull request has now been integrated. Changeset: cf21d29b Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/cf21d29b28ff06240c7fb53284b537fbbce05f89 Stats: 9 lines in 1 file changed: 1 ins; 2 del; 6 mod 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused Backport-of: cddaf686e16424e9543be50a48b1c02337e79cf1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2772 From mbaesken at openjdk.org Thu Aug 8 07:10:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 07:10:39 GMT Subject: [jdk21u-dev] Integrated: 8335237: ubsan: vtableStubs.hpp is_vtable_stub exclude from ubsan checks In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 08:14:14 GMT, Matthias Baesken wrote: > Backport of 8335237, diff in stride at headers but still recognized clean This pull request has now been integrated. Changeset: d5782215 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/d5782215b5ca3befd58d8029e67fd447b26bfa79 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8335237: ubsan: vtableStubs.hpp is_vtable_stub exclude from ubsan checks Backport-of: 486aa11e74d0772ba84c2adc3c62fc1fcbf52604 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/899 From mbaesken at openjdk.org Thu Aug 8 07:15:46 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 07:15:46 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly [v2] In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 13:10:54 GMT, Martin Doerr wrote: > Do you have a stack trace with more Exception details This is the stack trace when I keep the ProtocolException and omit the check for IOException java.lang.AssertionError: Expected ProtocolException to be thrown, but IOException was thrown at org.testng.Assert.expectThrows(Assert.java:1724) at org.testng.Assert.assertThrows(Assert.java:1695) at Response1xxTest.testSecureHTTP2Unexpected101(Response1xxTest.java:448) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599) at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174) at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46) at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822) at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128) at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) at org.testng.TestRunner.privateRun(TestRunner.java:764) at org.testng.TestRunner.run(TestRunner.java:585) at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) at org.testng.SuiteRunner.run(SuiteRunner.java:286) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) at org.testng.TestNG.runSuites(TestNG.java:1069) at org.testng.TestNG.run(TestNG.java:1037) at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:102) at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:58) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.io.IOException: No subject alternative names present at java.net.http/jdk.internal.net.http.HttpClientImpl.send(HttpClientImpl.java:568) at java.net.http/jdk.internal.net.http.HttpClientFacade.send(HttpClientFacade.java:119) at Response1xxTest.lambda$testSecureHTTP2Unexpected101$2(Response1xxTest.java:449) at org.testng.Assert.expectThrows(Assert.java:1714) ... 35 more Caused by: javax.net.ssl.SSLHandshakeException: No subject alternative names present at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:360) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:303) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:298) at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(CertificateMessage.java:1357) at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.onConsumeCertificate(CertificateMessage.java:1232) at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.consume(CertificateMessage.java:1175) at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392) at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:443) at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:1076) at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:1063) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask.run(SSLEngineImpl.java:1010) at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate.lambda$executeTasks$3(SSLFlowDelegate.java:1073) at java.net.http/jdk.internal.net.http.HttpClientImpl$DelegatingExecutor.execute(HttpClientImpl.java:154) at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate.executeTasks(SSLFlowDelegate.java:1068) at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate.doHandshake(SSLFlowDelegate.java:1034) at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate$Reader.processData(SSLFlowDelegate.java:442) at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate$Reader$ReaderDownstreamPusher.run(SSLFlowDelegate.java:264) at java.net.http/jdk.internal.net.http.common.SequentialScheduler$SynchronizedRestartableTask.run(SequentialScheduler.java:175) at java.net.http/jdk.internal.net.http.common.SequentialScheduler$CompleteRestartableTask.run(SequentialScheduler.java:147) at java.net.http/jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run(SequentialScheduler.java:198) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ... 1 more Caused by: java.security.cert.CertificateException: No subject alternative names present at java.base/sun.security.util.HostnameChecker.matchIP(HostnameChecker.java:142) at java.base/sun.security.util.HostnameChecker.match(HostnameChecker.java:101) at java.base/sun.security.ssl.X509TrustManagerImpl.checkIdentity(X509TrustManagerImpl.java:461) at java.base/sun.security.ssl.X509TrustManagerImpl.checkIdentity(X509TrustManagerImpl.java:435) at java.base/sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:283) at java.base/sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:141) at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(CertificateMessage.java:1335) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2896#issuecomment-2275110955 From ashi at openjdk.org Thu Aug 8 08:17:34 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 8 Aug 2024 08:17:34 GMT Subject: [jdk17u-dev] Integrated: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen" In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 21:09:35 GMT, Amos Shi wrote: > Backport of [JDK-8314614](https://bugs.openjdk.org/browse/JDK-8314614) > > Testing > - Local: Test passed on `MacOS 14.5` > - `AnalyzeSnippetTest.java`: Test results: passed: 1 > - `CustomInputToolBuilder.java`: Test results: passed: 1 > - `FailOverDirectExecutionControlTest.java`: Test results: passed: 1 > - `FailOverExecutionControlDyingLaunchTest.java`: Test results: passed: 1 > - `FailOverExecutionControlHangingLaunchTest.java`: Test results: passed: 1 > - `FailOverExecutionControlHangingListenTest.java`: Test results: passed: 1 > - `FailOverExecutionControlTest.java`: Test results: passed: 1 > - `IdGeneratorTest.java`: Test results: passed: 1 > - `StartOptionTest.java`: Test results: passed: 1 > - `ToolReloadTest.java`: Test results: passed: 1 > - Pipeline: > - Linux and Windows: Passed > - MacOS: Not executed > - Testing Machine: SAP nightlies passed on `2024-08-06` > - Automated jtreg test: jtreg_langtools > - Started at 2024-08-06 20:52:37+01:00 > - jdk/jshell/AnalyzeSnippetTest.java: SUCCESSFUL GitHub ? - [20:55:14.694 -> 34,287 msec] > - jdk/jshell/CustomInputToolBuilder.java: SUCCESSFUL GitHub ? - [20:55:50.275 -> 21,143 msec] > - jdk/jshell/FailOverDirectExecutionControlTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - jdk/jshell/FailOverExecutionControlDyingLaunchTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - jdk/jshell/FailOverExecutionControlHangingLaunchTest.java: SUCCESSFUL GitHub ? - [20:56:17.158 -> 13,958 msec] > - jdk/jshell/FailOverExecutionControlHangingListenTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - jdk/jshell/FailOverExecutionControlTest.java: SUCCESSFUL GitHub ? - [20:56:18.245 -> 6,288 msec] > - jdk/jshell/IdGeneratorTest.java: SUCCESSFUL GitHub ? - [20:56:35.852 -> 4,579 msec] > - jdk/jshell/StartOptionTest.java: SUCCESSFUL GitHub ? - [20:57:10.159 -> 8,664 msec] > - jdk/jshell/ToolReloadTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!intermittent))) & !manual & !ignore] GitHub ? - [0 msec] This pull request has now been integrated. Changeset: 13f6ab3e Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/13f6ab3e195419ff8a3987f9b98035f1581292cd Stats: 106 lines in 15 files changed: 66 ins; 18 del; 22 mod 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen" 8312140: jdk/jshell tests failed with JDI socket timeouts Backport-of: 14193a049ebcbd3639962729c631293b8d3a9114 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2755 From andrewlu at openjdk.org Thu Aug 8 08:54:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 8 Aug 2024 08:54:06 GMT Subject: [jdk21u-dev] RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport ab183e437c18b445e9c022a4d74de818d4ccecbe Changes: https://git.openjdk.org/jdk21u-dev/pull/900/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=900&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328642 Stats: 286 lines in 2 files changed: 48 ins; 211 del; 27 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/900.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/900/head:pull/900 PR: https://git.openjdk.org/jdk21u-dev/pull/900 From ashi at openjdk.org Thu Aug 8 10:00:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 8 Aug 2024 10:00:39 GMT Subject: [jdk11u-dev] Withdrawn: 8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration In-Reply-To: References: Message-ID: On Fri, 14 Jun 2024 01:28:20 GMT, Amos Shi wrote: > This is backprot for parity with `11.0.24-oracle` > > ---- > > Backport of [JDK-8253700](https://bugs.openjdk.org/browse/JDK-8253700) > - This is an **unclean** backport, contains two commits > - Commit 1. is generated by `git patch` command, is a clean apply of the original commit > - Commit 2. contains > - a, Manual merge of the following `.rej` files > - b. Manually fixed the `TestThrows.java` on Java 11 compile error, and fixed the test case to match the `javadoc` 11 output > > `.rej` files > - `src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java.rej` > - This file has been manually merged into the `commit 2` > > > @@ -51,6 +51,7 @@ > import static jdk.javadoc.internal.doclets.formats.html.LinkInfoImpl.Kind.MEMBER; > import static jdk.javadoc.internal.doclets.formats.html.LinkInfoImpl.Kind.MEMBER_TYPE_PARAMS; > import static jdk.javadoc.internal.doclets.formats.html.LinkInfoImpl.Kind.RECEIVER_TYPE; > +import static jdk.javadoc.internal.doclets.formats.html.LinkInfoImpl.Kind.THROWS_TYPE; > > /** > * Print method and constructor info. > @@ -254,19 +255,16 @@ > */ > protected Content getExceptions(ExecutableElement member) { > List exceptions = utils.asInstantiatedMethodType(typeElement, member).getThrownTypes(); > - Content htmltree = new ContentBuilder(); > - if (!exceptions.isEmpty()) { > - Content link = writer.getLink(new LinkInfoImpl(configuration, MEMBER, exceptions.get(0))); > - htmltree.add(link); > - for (int i = 1; i < exceptions.size(); i++) { > - htmltree.add(","); > - htmltree.add(DocletConstants.NL); > - Content exceptionLink = writer.getLink(new LinkInfoImpl(configuration, MEMBER, > - exceptions.get(i))); > - htmltree.add(exceptionLink); > + Content htmlTree = new ContentBuilder(); > + for (TypeMirror t : exceptions) { > + if (!htmlTree.isEmpty()) { > + htmlTree.add(","); > + htmlTree.add(DocletConstants.NL); > } > + Content link = writer.getLink(new LinkInfoImpl(configuration, THROWS_TYPE, t)); > + htmlTree.add(link); > } > - return htmltree; > + return htmlTree; > } > > protected TypeElement implementsMethodInIntfac(ExecutableElement method, > > > - `src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/LinkInfoImpl.java.rej` > - This file has been manually m... This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2772 From mbaesken at openjdk.org Thu Aug 8 12:14:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 12:14:32 GMT Subject: [jdk17u-dev] RFR: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices In-Reply-To: References: Message-ID: <941nWMPCazycCv1OBzVemh5jgr7j6n1E7aRAVlwledU=.bca4bf86-cd08-4f2a-b1c2-1379dbc9f5d9@github.com> On Wed, 31 Jul 2024 21:59:40 GMT, Amos Shi wrote: > Backport of [JDK-8313674](https://bugs.openjdk.org/browse/JDK-8313674) > - Manually merged based original commit. Although `Unclean`, all code is in line with current latest code base. > > Testing > - Local: `(os.family == "linux")` > - `BlockDeviceSize.java`: Test results: passed: 1, on [WSL](https://ubuntu.com/desktop/wsl) based `Ubuntu Linux 22.04` > - see comments bellow by @Harry-Junhua-Huang > - Pipeline > - `Linux`, Windows - `Passed` > - MacOS - skipped > - Testing Machine: SAP nightlies skipped on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00 > - java/nio/channels/FileChannel/BlockDeviceSize.java: `SKIPPED` [Filter: Composite Filter - Filtered out by a composite filter.] GitHub ? - [0 msec] Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2756#pullrequestreview-2227681821 From zzambers at openjdk.org Thu Aug 8 12:19:04 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 8 Aug 2024 12:19:04 GMT Subject: [jdk23u] RFR: 8336928: GHA: Bundle artifacts removal broken Message-ID: Fix to GHA code removing bundle artifacts. ------------- Commit messages: - Backport 98562166e4a4c8921709014423c6cbc993aa0d97 Changes: https://git.openjdk.org/jdk23u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336928 Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod Patch: https://git.openjdk.org/jdk23u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/61/head:pull/61 PR: https://git.openjdk.org/jdk23u/pull/61 From duke at openjdk.org Thu Aug 8 12:28:36 2024 From: duke at openjdk.org (duke) Date: Thu, 8 Aug 2024 12:28:36 GMT Subject: [jdk23u] RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 06:56:35 GMT, Shivangi Gupta wrote: > Straight Backport @openjdk[bot] Your change (at version b8e980e975055875bde99004c858460895c7ddea) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/50#issuecomment-2275694043 From sshivang at openjdk.org Thu Aug 8 12:28:36 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Thu, 8 Aug 2024 12:28:36 GMT Subject: [jdk23u] RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 06:56:35 GMT, Shivangi Gupta wrote: > Straight Backport @coffeys Please sponsor this change ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/50#issuecomment-2275696297 From mbaesken at openjdk.org Thu Aug 8 12:38:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 12:38:32 GMT Subject: [jdk17u-dev] RFR: 8320608: Many jtreg printing tests are missing the @printer keyword In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 22:33:02 GMT, Amos Shi wrote: > Backport of [JDK-8320608](https://bugs.openjdk.org/browse/JDK-8320608) > - This PR contains two commits > - `commit 1`: changes made by `git apply`, which is `clean` > - `commit 2`: manual merge the `test/jdk/TEST.ROOT.rej` > > Contents of `test/jdk/TEST.ROOT.rej` > > > @@ -9,17 +9,41 @@ > # should be taken to handle test failures of intermittent or > # randomness tests. > # > -# A "headful" test requires a graphical environment to meaningfully > -# run. Tests that are not headful are "headless". > -# A test flagged with key sound needs audio devices on the system, this > -# may be accompanied by the headful keyword since audio device access > +# A test flagged with cgroups uses cgroups. > +# > +# Notes on "client" keywords : headful sound printer multimon > +# =========================================================== > +# > +# These keywords are there to help with test selection so that > +# tests that need a particular resource can be selected to run on a system > +# with that resource. Conversely "!somekeyword" can be used to exclude tests > +# on a system without such a resource. > +# Caution: If you are always excluding tests using any of these keywords then you > +# are likely missing many important tests. > +# > +# "headful". A "headful" test requires a graphical environment to meaningfully run. > +# This does not have to mean a physical host, since a VM can be configured as headful. > +# Tests that are not headful are "headless". > +# Note: all manual tests are assumed to be headful and do not need the keyword. > +# > +# "printer". Not all tests of printing APIs require a printer, but many do. > +# So a "printer" test requires a printer to be installed to do anything meaningful. > +# Tests may not fail if there is none, instead just silently return. > +# But they also may legitimately throw an Exception depending on the test. > +# Also printer tests are not necessarily headful, but some are, and some are automated. > +# > +# "sound". Similarly, not all sound tests require audio devices, but many do. > +# A test flagged with key "sound" needs audio devices on the system. > +# Also they are not necessarily "headful", since they don't require a display etc. > +# But sometimes they may be accompanied by the headful keyword, since sound > # is often linked to access to desktop resources and headful systems are > # also more likely to have audio devices (ie meaning both input and output) > -# A test flagged with key "printer" requires a printer to succeed, else > -# throws a PrinterException or the like. > -# A test flagged with cg... Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2770#pullrequestreview-2227737871 From zzambers at openjdk.org Thu Aug 8 12:48:02 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 8 Aug 2024 12:48:02 GMT Subject: [jdk21u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken Message-ID: <6vHBrvqmxMn-3QbGz00HdQVT8VXWEYJvcFhjEgNR5Fw=.03c7bb18-9e9b-4c6c-9a5b-00b5071d51f8@github.com> Fix of GHA code which removes bundle artifacts. Testing in GHA: bundles-* artifacts got correctly removed ------------- Commit messages: - Backport 98562166e4a4c8921709014423c6cbc993aa0d97 Changes: https://git.openjdk.org/jdk21u-dev/pull/901/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=901&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336928 Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/901.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/901/head:pull/901 PR: https://git.openjdk.org/jdk21u-dev/pull/901 From mbaesken at openjdk.org Thu Aug 8 12:57:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 12:57:33 GMT Subject: [jdk17u-dev] RFR: 8295087: Manual Test to Automated Test Conversion In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 03:09:05 GMT, Amos Shi wrote: > Backport of [JDK-8295087](https://bugs.openjdk.org/browse/JDK-8295087) > - This PR contains two commit > - `Commit 1` is generated by git apply from original commit > - `Commit 2` is adding the missing test case `InconsistentEntries.java`, which was originally added by [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779) > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `ExtDirs.java`: Test results: passed: 2 > - `ExtDirsChange.java`: Test results: passed: 1 > - `ExtDirsDefaultPolicy.java`: Test results: passed: 4 > - `InconsistentEntries.java`: Test results: passed: 1 > - Pipeline: > - Linux, Windows - Passed > - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00 > - java/lang/ClassLoader/ExtDirs.java: SUCCESSFUL GitHub ? - [20:37:45.782 -> 568 msec] > - Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00 > - sun/security/provider/PolicyParser/ExtDirsChange.java: SUCCESSFUL GitHub ? - [21:41:01.101 -> 364 msec] > - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id0: SUCCESSFUL GitHub ? - [21:41:01.165 -> 39 msec] > - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id1: SUCCESSFUL GitHub ? - [21:41:01.204 -> 309 msec] > - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id2: SUCCESSFUL GitHub ? - [21:41:01.465 -> 309 msec] > - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id3: SUCCESSFUL GitHub ? - [21:41:01.513 -> 362 msec] > - javax/crypto/CryptoPermissions/InconsistentEntries.java: SUCCESSFUL GitHub ? - [21:30:11.979 -> 4,379 msec] You add [test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java](https://github.com/openjdk/jdk17u-dev/pull/2774/files#diff-6921fd8e4c83f33bbb681d27e21f3e6d167036940bd09e42567a4039993c5e5f) with the test, But the JBS issue https://bugs.openjdk.org/browse/JDK-8286779 associated with this test is in jdk20 and it seems it was not backported to 17. So is it really a good idea to backport the test ? Looks a bit inconsistent to me . ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2774#issuecomment-2275754315 From zzambers at openjdk.org Thu Aug 8 12:58:00 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 8 Aug 2024 12:58:00 GMT Subject: [jdk17u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken Message-ID: Fix of GHA code which removes bundle artifacts. Testing in GHA: bundles-* artifacts got correctly removed ------------- Commit messages: - Backport 98562166e4a4c8921709014423c6cbc993aa0d97 Changes: https://git.openjdk.org/jdk17u-dev/pull/2787/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2787&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336928 Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2787.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2787/head:pull/2787 PR: https://git.openjdk.org/jdk17u-dev/pull/2787 From mbaesken at openjdk.org Thu Aug 8 13:00:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 13:00:39 GMT Subject: [jdk17u-dev] RFR: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 23:18:18 GMT, Amos Shi wrote: > Backport of [JDK-8298596](https://bugs.openjdk.org/browse/JDK-8298596) > - The change on file `test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java` is `clean` > - The change on file `test/hotspot/jtreg/ProblemList-zgc.txt` has been **ignored**, because the line does not exist in `jdk17u-dev` > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `OneeFinalizerTest.java`: Test results: passed: 1 > - `PhantomReferenceEvilTest.java`: Test results: passed: 1 > - `PhantomReferenceTest.java`: Test results: passed: 1 > - `ReferencesGC.java`: Test results: passed: 1 > - `soft001.java`: Test results: passed: 1 > - `weak001.java`: Test results: passed: 1 > - `WeakReferenceGC.java`: Test results: passed: 1 > - Pipeline: > - Linux, Windows - Passed > - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_notstresshotspot_tier4, Started at 2024-08-06 23:51:31+01:00 > - vmTestbase/gc/gctests/OneeFinalizerTest/OneeFinalizerTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/PhantomReference/PhantomReferenceEvilTest/PhantomReferenceEvilTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/PhantomReference/PhantomReferenceTest/PhantomReferenceTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/SoftReference/soft001/soft001.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/WeakReference/weak001/weak001.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/WeakRe... Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2778#pullrequestreview-2227793043 From mbaesken at openjdk.org Thu Aug 8 13:06:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 13:06:34 GMT Subject: [jdk17u-dev] RFR: 8302800: Augment NaN handling tests of FDLIBM methods In-Reply-To: References: Message-ID: On Sat, 3 Aug 2024 00:04:48 GMT, Amos Shi wrote: > Backport of [JDK-8302800](https://bugs.openjdk.org/browse/JDK-8302800) > - This PR contains two PR > - `commit 1` is made by the `git apply` which is `clean` > - `commit 2` adds the missing file `test/jdk/java/lang/Math/InverseTrigTests.java` currently does not exist in `jdk17u-dev`, it was originally added by [JDK-8302026](https://bugs.openjdk.org/browse/JDK-8302026) via [commit](https://github.com/openjdk/jdk/commit/3ba156082b73c4a8e9d890a57a42fb68df2bf98f) > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `CubeRootTests.java`: Test results: passed: 1 > - `Expm1Tests.java`: Test results: passed: 1 > - `HyperbolicTests.java`: Test results: passed: 1 > - `Log10Tests.java`: Test results: passed: 1 > - `Log1pTests.java`: Test results: passed: 1 > - `Tests.java`: Not applicable: not a test > - `InverseTrigTests.java`: Test results: passed: 1 > - Pipeline: > - Linux, Windows - Passed > - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00 > - java/lang/Math/CubeRootTests.java: SUCCESSFUL GitHub ? - [20:41:53.428 -> 166 msec] > - java/lang/Math/Expm1Tests.java: SUCCESSFUL GitHub ? - [20:41:54.175 -> 253 msec] > - java/lang/Math/HyperbolicTests.java: SUCCESSFUL GitHub ? - [20:41:54.428 -> 307 msec] > - java/lang/Math/Log10Tests.java: SUCCESSFUL GitHub ? - [20:41:55.238 -> 196 msec] > - java/lang/Math/Log1pTests.java: SUCCESSFUL GitHub ? - [20:41:55.434 -> 202 msec] > - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [20:41:55.038 -> 199 msec] JDK-8302026 which contains the 'missing' InverseTrigTests.java test was never backported to 17 so please check again that the test is really stable. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2779#issuecomment-2275773946 From zzambers at openjdk.org Thu Aug 8 13:07:44 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 8 Aug 2024 13:07:44 GMT Subject: [jdk11u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken Message-ID: Fix of GHA code which removes bundle artifacts. Testing in GHA: bundles-* artifacts got correctly removed ------------- Commit messages: - Backport 98562166e4a4c8921709014423c6cbc993aa0d97 Changes: https://git.openjdk.org/jdk11u-dev/pull/2898/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2898&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336928 Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2898.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2898/head:pull/2898 PR: https://git.openjdk.org/jdk11u-dev/pull/2898 From mbaesken at openjdk.org Thu Aug 8 13:08:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 8 Aug 2024 13:08:33 GMT Subject: [jdk17u-dev] RFR: 8313256: Exclude failing multicast tests on AIX In-Reply-To: References: Message-ID: On Sat, 3 Aug 2024 01:59:45 GMT, Amos Shi wrote: > Backport of [JDK-8313256](https://bugs.openjdk.org/browse/JDK-8313256) > - This PR contains two commit > - `commit 1` is generated by git apply command, which is `clean` > - `commit 2` is the manual merge of the `test/jdk/ProblemList.txt.rej` file > > Contents of `test/jdk/ProblemList.txt.rej` > > > @@ -586,13 +587,16 @@ > > # jdk_net > > -java/net/MulticastSocket/NoLoopbackPackets.java 7122846 macosx-all > -java/net/MulticastSocket/SetLoopbackMode.java 7122846 macosx-all > +java/net/MulticastSocket/NoLoopbackPackets.java 7122846,8308807 macosx-all,aix-ppc64 > +java/net/MulticastSocket/SetLoopbackMode.java 7122846,8308807 macosx-all,aix-ppc64 > > -java/net/MulticastSocket/Test.java 7145658 macosx-all > +java/net/MulticastSocket/Test.java 7145658,8308807 macosx-all,aix-ppc64 > > java/net/ServerSocket/AcceptInheritHandle.java 8211854 aix-ppc64 > > +java/net/MulticastSocket/B6427403.java 8308807 aix-ppc64 > +java/net/MulticastSocket/SetOutgoingIf.java 8308807 aix-ppc64 > + > ############################################################################ > > # jdk_nio > > > Testing > - Local: Not applicable (`aix-ppc64`) > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier3, Started at 2024-08-06 22:04:38+01:00 > - sun/management/jdp/JdpDefaultsTest.java: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - sun/management/jdp/JdpJmxRemoteDynamicPortTest.java: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - sun/management/jdp/JdpSpecificAddressTest.java: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - sun/management/jdp/JdpOffTest.java: SUCCESSFUL GitHub ? - [22:20:33.777 -> 12,159 msec] > - Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00 > - java/net/MulticastSocket/NoLoopbackPackets.java: SKIPPED[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - java/net/MulticastSocket/SetLoopbackMode.java: SKIPPED[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - java/net/MulticastSocket/Test.java: SKIPPED[Filter: jtregExcludeLis... Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2780#pullrequestreview-2227816032 From dchuyko at openjdk.org Thu Aug 8 14:15:13 2024 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 8 Aug 2024 14:15:13 GMT Subject: [jdk21u-dev] RFR: 8320192: SHAKE256 does not work correctly if n >= 137 Message-ID: This is a clean backport of KAT fix for SHAKE256. The test provided in the bug description currently fails on JDK 21. ------------- Commit messages: - Backport fcb4df26f18c7a10e4511f4be948c887f14ee093 Changes: https://git.openjdk.org/jdk21u-dev/pull/902/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=902&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320192 Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/902.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/902/head:pull/902 PR: https://git.openjdk.org/jdk21u-dev/pull/902 From shade at openjdk.org Thu Aug 8 16:31:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 8 Aug 2024 16:31:09 GMT Subject: [jdk21u-dev] RFR: 8331572: Allow using OopMapCache outside of STW GC phases [v3] In-Reply-To: <49YutDmQvYgxmebaYPJSIGEVyHUVPP4Ok9ZdiohkYB8=.8b1a8a83-6d66-4700-a319-d9d77de734fe@github.com> References: <49YutDmQvYgxmebaYPJSIGEVyHUVPP4Ok9ZdiohkYB8=.8b1a8a83-6d66-4700-a319-d9d77de734fe@github.com> Message-ID: > Unclean backport to improve GC and general stack walk performance when walking interpreted frames. > > This is one of few backports that gets `OopMapCache` behavior similar to mainline. This makes [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely. > > The point of uncleanliness comes from the way we hook up the cleanup notifications to Service Thread. In later JDKs, [JDK-8329488](https://bugs.openjdk.org/browse/JDK-8329488) made Service Thread wake up regularly to do various cleanups. In JDK 21, we still need to hook up the clean up to the "usual" place in safepoint epilog. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8331572-oopmap-cache-all - Backport 05ff3185edd25b381a97f6879f496e97b62dddc2 - Merge branch 'master' into JDK-8331572-oopmap-cache-all - Backport d999b81e7110751be402012e1ed41b3256f5895e ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/610/files - new: https://git.openjdk.org/jdk21u-dev/pull/610/files/9000a426..fc7b61cb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=610&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=610&range=01-02 Stats: 31780 lines in 390 files changed: 15974 ins; 13586 del; 2220 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/610.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/610/head:pull/610 PR: https://git.openjdk.org/jdk21u-dev/pull/610 From andrew at openjdk.org Thu Aug 8 17:28:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 8 Aug 2024 17:28:41 GMT Subject: [jdk21u-dev] Integrated: 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed In-Reply-To: References: Message-ID: On Sat, 3 Aug 2024 16:25:50 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a clean backport of commit [9fd855ed](https://github.com/openjdk/jdk/commit/9fd855ed477bb0849ce5c774854844deec0f4c6b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Weijun Wang on 11 Jan 2024 and was reviewed by Sean Mullan and Valerie Peng. > > Tests in `test/jdk/javax/crypto/KEM` and `test/jdk/com/sun/crypto/provider/DHKEM` all passed on the patched build. > > The change jumped 21u and [is already in 17u](https://git.openjdk.org/jdk17u/commit/e49367bba1733eaad374c152e04e2af322956466), thanks to the 17.0.0.1 RI, so we should get it fixed here too. > > Thanks! This pull request has now been integrated. Changeset: fd4ce63c Author: Andrew John Hughes URL: https://git.openjdk.org/jdk21u-dev/commit/fd4ce63ce5735db55da7535be0c33cd65aa7671d Stats: 119 lines in 4 files changed: 74 ins; 29 del; 16 mod 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed Backport-of: 9fd855ed477bb0849ce5c774854844deec0f4c6b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/893 From duke at openjdk.org Thu Aug 8 19:40:36 2024 From: duke at openjdk.org (duke) Date: Thu, 8 Aug 2024 19:40:36 GMT Subject: [jdk23u] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: <0HMVRZqED-86x7oZY2mtI6VPWonAqa8Xa94JU5urGsE=.ff8a308f-7841-400e-9c57-4025c4f02f5b@github.com> On Thu, 8 Aug 2024 12:14:20 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed @zzambers Your change (at version b784515a95a73a3ba5c23a1977be3baeabfcb1ad) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/61#issuecomment-2276526020 From duke at openjdk.org Thu Aug 8 20:21:30 2024 From: duke at openjdk.org (cklim0815is) Date: Thu, 8 Aug 2024 20:21:30 GMT Subject: [jdk23u] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 12:14:20 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed Marked as reviewed by cklim0815is at github.com (no known OpenJDK username). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/61#pullrequestreview-2228782332 From duke at openjdk.org Thu Aug 8 20:24:38 2024 From: duke at openjdk.org (cklim0815is) Date: Thu, 8 Aug 2024 20:24:38 GMT Subject: [jdk23u] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 12:14:20 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed Marked as reviewed by cklim0815is at github.com (no known OpenJDK username). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/61#pullrequestreview-2228787921 From ashi at openjdk.org Thu Aug 8 20:29:05 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 8 Aug 2024 20:29:05 GMT Subject: [jdk21u-dev] RFR: 8310683: Refactor StandardCharset/standard.java to use JUnit Message-ID: <5UXUpT-ZhL3qxUpfriq7hiuP0uBjxzzkzUdGBOsv_yA=.1fb7d360-9afe-4151-accb-e637c47f3e31@github.com> Backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) - This PR contains three commits - `commit 1` is the `clean` backport of `Standard.java` file from [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047), which is the dependency of current PR [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) - `commit 2` is the `clean` backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) original commit - `commit 3` is fixing the compile error of the test case, to remove the charsets added by [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047) in Java 22 /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:140: error: cannot find symbol Arguments.of(StandardCharsets.UTF_32BE, "UTF-32BE"), ^ symbol: variable UTF_32BE location: class StandardCharsets /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:141: error: cannot find symbol Arguments.of(StandardCharsets.UTF_32LE, "UTF-32LE"), ^ symbol: variable UTF_32LE location: class StandardCharsets /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:142: error: cannot find symbol Arguments.of(StandardCharsets.UTF_32, "UTF-32") ^ symbol: variable UTF_32 location: class StandardCharsets Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `Standard.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport d82ade354570a930d8282684a8ffd368c613defc Remove new fields by JDK-8310047 - Backport d82ade354570a930d8282684a8ffd368c613defc - Backport 00c7f914c665a77842d32eb8f760dcbbbda66554 Changes: https://git.openjdk.org/jdk21u-dev/pull/903/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=903&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310683 Stats: 128 lines in 1 file changed: 49 ins; 28 del; 51 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/903.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/903/head:pull/903 PR: https://git.openjdk.org/jdk21u-dev/pull/903 From ashi at openjdk.org Thu Aug 8 21:07:52 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 8 Aug 2024 21:07:52 GMT Subject: [jdk17u-dev] RFR: 8314837: 5 compiled/codecache tests ignore VM flags Message-ID: Backport of [JDK-8314837](https://bugs.openjdk.org/browse/JDK-8314837) - This PR is generated by git patch, so it is `considered as Clean` - There is one line rejected for class `test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java.rej`, content as bellow - This diff can be ignored, becuase the current version is in line with current latest jdk code base with [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097) `test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java.rej` Contents @@ -54,7 +55,7 @@ } public static void runTest() throws Throwable { - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( + ProcessBuilder pb = ProcessTools.createTestJvm( "-XX:ReservedCodeCacheSize=2496k", "-XX:-UseCodeCacheFlushing", "-XX:-MethodFlushing", "CodeCacheFullCountTest", "WasteCodeCache"); OutputAnalyzer oa = ProcessTools.executeProcess(pb); // Ignore adapter creation failures Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `CheckCodeCacheInfo.java`: Test results: passed: 1 - `CodeCacheFullCountTest.java`: Test results: passed: 1 - `TestSegmentedCodeCacheOption.java`: Test results: passed: 1 - `TestCodeHeapSizeOptions.java`: Test results: passed: 1 - `TestPrintCodeCacheOption.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 2a11bc41baec20cf670393ff29689043ed2d2114 Changes: https://git.openjdk.org/jdk17u-dev/pull/2788/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2788&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314837 Stats: 10 lines in 5 files changed: 4 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2788.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2788/head:pull/2788 PR: https://git.openjdk.org/jdk17u-dev/pull/2788 From ashi at openjdk.org Thu Aug 8 21:36:50 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 8 Aug 2024 21:36:50 GMT Subject: [jdk17u-dev] RFR: 8314837: 5 compiled/codecache tests ignore VM flags [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8314837](https://bugs.openjdk.org/browse/JDK-8314837) > - This PR has two commits > - `commit 1` generated by git patch, so it is `considered as Clean` > - `commit 2` is the manual merge of `test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java.rej`, content as bellow > > > @@ -54,7 +55,7 @@ > } > > public static void runTest() throws Throwable { > - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( > + ProcessBuilder pb = ProcessTools.createTestJvm( > "-XX:ReservedCodeCacheSize=2496k", "-XX:-UseCodeCacheFlushing", "-XX:-MethodFlushing", "CodeCacheFullCountTest", "WasteCodeCache"); > OutputAnalyzer oa = ProcessTools.executeProcess(pb); > // Ignore adapter creation failures > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `CheckCodeCacheInfo.java`: Test results: passed: 1 > - `CodeCacheFullCountTest.java`: Test results: passed: 1 > - `TestSegmentedCodeCacheOption.java`: Test results: passed: 1 > - `TestCodeHeapSizeOptions.java`: Test results: passed: 1 > - `TestPrintCodeCacheOption.java`: Test results: passed: 1 > - Pipeline: > - Testing Machine: Amos Shi has updated the pull request incrementally with one additional commit since the last revision: Backport 2a11bc41baec20cf670393ff29689043ed2d2114 Manual merge ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2788/files - new: https://git.openjdk.org/jdk17u-dev/pull/2788/files/5fa47190..68268c47 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2788&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2788&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2788.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2788/head:pull/2788 PR: https://git.openjdk.org/jdk17u-dev/pull/2788 From ashi at openjdk.org Thu Aug 8 21:54:57 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 8 Aug 2024 21:54:57 GMT Subject: [jdk21u-dev] RFR: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic" Message-ID: <9gNSVk2yba0kDH1wd8UOTGVxkszrhIqXOFlfwrKq9T0=.f4c938d0-327d-4e69-9fc5-9662d5b819ed@github.com> Backport of [JDK-8317738](https://bugs.openjdk.org/browse/JDK-8317738) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `CodeCacheFullCountTest.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 0fd807118c9b2cb8381b5c0f5d22d4e3451e8f10 Changes: https://git.openjdk.org/jdk21u-dev/pull/904/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=904&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317738 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/904.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/904/head:pull/904 PR: https://git.openjdk.org/jdk21u-dev/pull/904 From ashi at openjdk.org Fri Aug 9 00:46:00 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 9 Aug 2024 00:46:00 GMT Subject: [jdk21u-dev] RFR: 8325022: Incorrect error message on client authentication Message-ID: Backport of [JDK-8325022](https://bugs.openjdk.org/browse/JDK-8325022) Testing - Local: - Build passed on `MacOS 14.6.1` on Apple M1 Max - No applicable test case - Pipeline: - Testing Machine: ------------- Commit messages: - Backport fe78c0f1911c9fdc1d30e23847d102748dfa2063 Changes: https://git.openjdk.org/jdk21u-dev/pull/905/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=905&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325022 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/905.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/905/head:pull/905 PR: https://git.openjdk.org/jdk21u-dev/pull/905 From ashi at openjdk.org Fri Aug 9 00:49:50 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 9 Aug 2024 00:49:50 GMT Subject: [jdk17u-dev] RFR: 8325022: Incorrect error message on client authentication Message-ID: Backport of [JDK-8325022](https://bugs.openjdk.org/browse/JDK-8325022) Testing - Local: - Build passed on `MacOS 14.6.1` on Apple M1 Max - No applicable test case - Pipeline: - Testing Machine: ------------- Commit messages: - Backport fe78c0f1911c9fdc1d30e23847d102748dfa2063 Changes: https://git.openjdk.org/jdk17u-dev/pull/2789/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2789&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325022 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2789.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2789/head:pull/2789 PR: https://git.openjdk.org/jdk17u-dev/pull/2789 From ashi at openjdk.org Fri Aug 9 01:00:48 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 9 Aug 2024 01:00:48 GMT Subject: [jdk11u-dev] RFR: 8325022: Incorrect error message on client authentication Message-ID: Backport of [JDK-8325022](https://bugs.openjdk.org/browse/JDK-8325022) Testing - Local: - Build passed on `MacOS 14.6.1` on Apple M1 Max - No applicable test case - Pipeline: - Testing Machine: ------------- Commit messages: - Backport fe78c0f1911c9fdc1d30e23847d102748dfa2063 Changes: https://git.openjdk.org/jdk11u-dev/pull/2899/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2899&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325022 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2899.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2899/head:pull/2899 PR: https://git.openjdk.org/jdk11u-dev/pull/2899 From clanger at openjdk.org Fri Aug 9 05:17:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 9 Aug 2024 05:17:04 GMT Subject: [jdk17u-dev] RFR: 8330814: Cleanups for KeepAliveCache tests Message-ID: Backporting the cleanups for KeepAliveCache tests. Now with all prerequisites in place, it applies nearly clean. Only in test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java there was a little modification due to the different HttpServer API in 17 which lacks the constructor with all the options that is used in higher releases. ------------- Commit messages: - Backport a1a56cf88b1d4022441a51aac53f9f7cf47096fb Changes: https://git.openjdk.org/jdk17u-dev/pull/2790/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2790&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330814 Stats: 289 lines in 5 files changed: 113 ins; 69 del; 107 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2790.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2790/head:pull/2790 PR: https://git.openjdk.org/jdk17u-dev/pull/2790 From mbaesken at openjdk.org Fri Aug 9 06:10:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 06:10:31 GMT Subject: [jdk17u-dev] RFR: 8330814: Cleanups for KeepAliveCache tests In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 05:12:38 GMT, Christoph Langer wrote: > Backporting the cleanups for KeepAliveCache tests. Now with all prerequisites in place, it applies nearly clean. Only in test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java there was a little modification due to the different HttpServer API in 17 which lacks the constructor with all the options that is used in higher releases. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2790#pullrequestreview-2229380543 From mbaesken at openjdk.org Fri Aug 9 07:20:10 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 07:20:10 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check Message-ID: Backport of 8334166; previous warning setting missing so not clean ------------- Commit messages: - Backport a4582a8957d604b50249e1f59679393966456a14 Changes: https://git.openjdk.org/jdk21u-dev/pull/906/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=906&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334166 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/906.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/906/head:pull/906 PR: https://git.openjdk.org/jdk21u-dev/pull/906 From jwtang at openjdk.org Fri Aug 9 07:27:06 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Fri, 9 Aug 2024 07:27:06 GMT Subject: [jdk21u-dev] RFR: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed Message-ID: I will backport [JDK-8337331](https://bugs.openjdk.org/browse/JDK-8337331) after this to fix the deadlock / jvm crash problem. ------------- Commit messages: - Backport c4ff58b9bcfd08eae0623a648a837e08f25b3f9b Changes: https://git.openjdk.org/jdk21u-dev/pull/907/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=907&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330146 Stats: 9 lines in 1 file changed: 2 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/907.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/907/head:pull/907 PR: https://git.openjdk.org/jdk21u-dev/pull/907 From andrewlu at openjdk.org Fri Aug 9 08:19:50 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:19:50 GMT Subject: [jdk11u-dev] RFR: 7156347: javax/swing/JList/6462008/bug6462008.java fails Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport a5b7bc50d450e083a09c16c73f9097650142fe35 Changes: https://git.openjdk.org/jdk11u-dev/pull/2900/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2900&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7156347 Stats: 3 lines in 2 files changed: 2 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2900.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2900/head:pull/2900 PR: https://git.openjdk.org/jdk11u-dev/pull/2900 From andrewlu at openjdk.org Fri Aug 9 08:26:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:26:11 GMT Subject: [jdk11u-dev] RFR: 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" Message-ID: <3zMVQwjZ5QOADXFfewgtXJKPegW4Ch5CSRYsO5ODrqE=.5bb699ff-8ba1-40ad-a959-90e2789bbdb4@github.com> I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport cd07b3cab00e6656e73a29f82210e2dedf26df8c Changes: https://git.openjdk.org/jdk11u-dev/pull/2901/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2901&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8257534 Stats: 12 lines in 1 file changed: 5 ins; 5 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2901.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2901/head:pull/2901 PR: https://git.openjdk.org/jdk11u-dev/pull/2901 From mbaesken at openjdk.org Fri Aug 9 08:29:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 08:29:32 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality In-Reply-To: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: On Thu, 1 Aug 2024 17:10:40 GMT, Amos Shi wrote: > Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) > - This PR has two commits > - `commit 1`: the git apply result, which is `clean` > - `commit 2`: manually merge the following two `.rej` files > - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` > > Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > > > @@ -668,15 +670,21 @@ > > static void assertReductionArraysEquals(double[] r, double rc, double[] a, > FReductionOp f, FReductionAllOp fa) { > + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEquals(double[] r, double rc, double[] a, > + FReductionOp f, FReductionAllOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a)); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); > for (; i < a.length; i += SPECIES.length()) { > - Assert.assertEquals(r[i], f.apply(a, i)); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); > } > } catch (AssertionError e) { > - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); > - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > } > } > > @@ -690,15 +698,22 @@ > > static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > FReductionMaskedOp f, FReductionAllMaskedOp fa) { > + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > + FReductionMaskedOp f, FReductionAllMaskedOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a, mask)); > + Assert.assertEquals(rc, fa.apply(a, mask), Math.abs(rc * relativeError)); > ... In the original commit I see in [test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java](https://github.com/openjdk/jdk/commit/e6f23a90d4a53339a3c9c2b76fc5d317940e4472#diff-a1baf5cd2c3bc9046a703b75c78cdb1948a2ca10d84ac1428dee4b471f87546f) https://github.com/openjdk/jdk/commit/e6f23a90d4a53339a3c9c2b76fc5d317940e4472 private static final double RELATIVE_ROUNDING_ERROR = (double)0.000001; Is it intentional that it is not in the backport ? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#issuecomment-2277429960 From andrewlu at openjdk.org Fri Aug 9 08:31:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:31:05 GMT Subject: [jdk11u-dev] RFR: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error Message-ID: <2mEwwS-rJQpsqHfuiVPbZk2RcnNLs31-xidGqac7sRA=.fb2c4379-940f-41cc-8cc0-c60de9464efd@github.com> I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport 8785737ba5f398888816ddd0f50adeea6a75bb0f Changes: https://git.openjdk.org/jdk11u-dev/pull/2902/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2902&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269616 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2902.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2902/head:pull/2902 PR: https://git.openjdk.org/jdk11u-dev/pull/2902 From andrewlu at openjdk.org Fri Aug 9 08:46:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:46:09 GMT Subject: [jdk11u-dev] RFR: 8278312: Update SimpleSSLContext keystore to use SANs for localhost IP addresses Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport bc31ccc95be9523cc6c64932f6d39f81c2e82bdd Changes: https://git.openjdk.org/jdk11u-dev/pull/2903/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2903&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278312 Stats: 222 lines in 3 files changed: 218 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2903.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2903/head:pull/2903 PR: https://git.openjdk.org/jdk11u-dev/pull/2903 From andrewlu at openjdk.org Fri Aug 9 08:56:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:56:00 GMT Subject: [jdk11u-dev] RFR: 8316973: GC: Make TestDisableDefaultGC use createTestJvm Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c Changes: https://git.openjdk.org/jdk11u-dev/pull/2904/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2904&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316973 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2904.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2904/head:pull/2904 PR: https://git.openjdk.org/jdk11u-dev/pull/2904 From andrewlu at openjdk.org Fri Aug 9 08:56:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:56:05 GMT Subject: [jdk17u-dev] RFR: 8316973: GC: Make TestDisableDefaultGC use createTestJvm Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c Changes: https://git.openjdk.org/jdk17u-dev/pull/2791/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2791&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316973 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2791.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2791/head:pull/2791 PR: https://git.openjdk.org/jdk17u-dev/pull/2791 From andrewlu at openjdk.org Fri Aug 9 08:58:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:58:00 GMT Subject: [jdk11u-dev] RFR: 8316285: Opensource JButton manual tests Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport 9f5d2b947f7d70babba663e16882e480b8a973f2 Changes: https://git.openjdk.org/jdk11u-dev/pull/2905/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2905&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316285 Stats: 292 lines in 3 files changed: 292 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2905.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2905/head:pull/2905 PR: https://git.openjdk.org/jdk11u-dev/pull/2905 From andrewlu at openjdk.org Fri Aug 9 08:58:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:58:19 GMT Subject: [jdk17u-dev] RFR: 8316285: Opensource JButton manual tests Message-ID: <2po_rc_6p2T6RIrC0ywa3JZofj4E-3FbdYovsKPQYpA=.5133ad95-fa89-4a59-a564-e516b2bb197c@github.com> I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 9f5d2b947f7d70babba663e16882e480b8a973f2 Changes: https://git.openjdk.org/jdk17u-dev/pull/2792/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2792&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316285 Stats: 292 lines in 3 files changed: 292 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2792.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2792/head:pull/2792 PR: https://git.openjdk.org/jdk17u-dev/pull/2792 From andrewlu at openjdk.org Fri Aug 9 08:58:56 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:58:56 GMT Subject: [jdk21u-dev] RFR: 8315965: Open source various AWT applet tests Message-ID: <-QOEOOxuTYtZgPtkexBGSSBIOgoXEUdzk9JPh_SQuA8=.30bf9b5c-fcce-40e5-b45b-c6b55d81e3de@github.com> I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 3b397c8552d7fd1b1084fbbc06384f3f34481ba4 Changes: https://git.openjdk.org/jdk21u-dev/pull/908/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=908&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315965 Stats: 546 lines in 4 files changed: 546 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/908.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/908/head:pull/908 PR: https://git.openjdk.org/jdk21u-dev/pull/908 From andrewlu at openjdk.org Fri Aug 9 08:59:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:59:17 GMT Subject: [jdk11u-dev] RFR: 8315965: Open source various AWT applet tests Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport 3b397c8552d7fd1b1084fbbc06384f3f34481ba4 Changes: https://git.openjdk.org/jdk11u-dev/pull/2906/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2906&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315965 Stats: 546 lines in 4 files changed: 546 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2906.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2906/head:pull/2906 PR: https://git.openjdk.org/jdk11u-dev/pull/2906 From andrewlu at openjdk.org Fri Aug 9 08:59:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 9 Aug 2024 08:59:20 GMT Subject: [jdk17u-dev] RFR: 8315965: Open source various AWT applet tests Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 3b397c8552d7fd1b1084fbbc06384f3f34481ba4 Changes: https://git.openjdk.org/jdk17u-dev/pull/2793/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2793&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315965 Stats: 546 lines in 4 files changed: 546 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2793.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2793/head:pull/2793 PR: https://git.openjdk.org/jdk17u-dev/pull/2793 From asteiner at openjdk.org Fri Aug 9 12:10:58 2024 From: asteiner at openjdk.org (Andreas Steiner) Date: Fri, 9 Aug 2024 12:10:58 GMT Subject: [jdk17u-dev] RFR: 8318089: Class space not marked as such with NMT when CDS is off Message-ID: 8318089: Class space not marked as such with NMT when CDS is off ------------- Commit messages: - Backport c0e154c876e586660b36af6441cd178bc8ebab89 Changes: https://git.openjdk.org/jdk17u-dev/pull/2794/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2794&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318089 Stats: 9 lines in 1 file changed: 3 ins; 6 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2794.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2794/head:pull/2794 PR: https://git.openjdk.org/jdk17u-dev/pull/2794 From mbaesken at openjdk.org Fri Aug 9 13:31:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 13:31:38 GMT Subject: [jdk23u] Integrated: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' In-Reply-To: <36n2OXGeR4EJm08BgTKVOZ_qT53CQK9scW0XWsEHYfo=.1b747961-8a32-4373-b7c9-88c5d5671311@github.com> References: <36n2OXGeR4EJm08BgTKVOZ_qT53CQK9scW0XWsEHYfo=.1b747961-8a32-4373-b7c9-88c5d5671311@github.com> Message-ID: On Wed, 7 Aug 2024 08:06:51 GMT, Matthias Baesken wrote: > 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' This pull request has now been integrated. Changeset: 6534917b Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/6534917bf19b0c20fa0f71bd7e887332cb50155a Stats: 10 lines in 1 file changed: 2 ins; 4 del; 4 mod 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' Backport-of: 0199fee431e0dccdd570b38595ea29c760dbed44 ------------- PR: https://git.openjdk.org/jdk23u/pull/58 From mbaesken at openjdk.org Fri Aug 9 13:32:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 13:32:34 GMT Subject: [jdk23u] Integrated: 8334618: ubsan: support setting additional ubsan check options In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 14:28:09 GMT, Matthias Baesken wrote: > 8334618: ubsan: support setting additional ubsan check options This pull request has now been integrated. Changeset: e0083387 Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/e008338747a5d601d3bc63b01282f06a16bedd06 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8334618: ubsan: support setting additional ubsan check options Backport-of: efb905e57ab7a5299952419fa9961316541056c2 ------------- PR: https://git.openjdk.org/jdk23u/pull/49 From clanger at openjdk.org Fri Aug 9 13:37:33 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 9 Aug 2024 13:37:33 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check In-Reply-To: References: Message-ID: <22FrqKwymmWlm9QW0N3d0EOtZShUx-H7HdbeWaRqvqw=.0c8fb595-091c-402a-a9ee-9804b6565372@github.com> On Fri, 9 Aug 2024 07:14:43 GMT, Matthias Baesken wrote: > Backport of 8334166; previous warning setting missing so not clean Hi Matthias, I think you could inline a backport of https://bugs.openjdk.org/browse/JDK-8332008 in this PR. This is the conflict for this backport and I think it makes sense for update releases as well. Afterwards the change can be brought to 17 and 11 as well. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/906#issuecomment-2277960641 From mbaesken at openjdk.org Fri Aug 9 13:55:05 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 13:55:05 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check [v2] In-Reply-To: References: Message-ID: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> > Backport of 8334166; previous warning setting missing so not clean Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: add issuestitle from 8334166 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/906/files - new: https://git.openjdk.org/jdk21u-dev/pull/906/files/e5e7e159..28defbb9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=906&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=906&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/906.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/906/head:pull/906 PR: https://git.openjdk.org/jdk21u-dev/pull/906 From mbaesken at openjdk.org Fri Aug 9 13:59:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 13:59:38 GMT Subject: [jdk21u-dev] Integrated: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 08:11:06 GMT, Matthias Baesken wrote: > 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' This pull request has now been integrated. Changeset: 953846d9 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/953846d9403b4b34fb84380473a298d8386ea8ff Stats: 10 lines in 1 file changed: 2 ins; 4 del; 4 mod 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]' Backport-of: 0199fee431e0dccdd570b38595ea29c760dbed44 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/898 From mbaesken at openjdk.org Fri Aug 9 14:00:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 14:00:33 GMT Subject: [jdk21u-dev] Integrated: 8334618: ubsan: support setting additional ubsan check options In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 14:37:55 GMT, Matthias Baesken wrote: > 8334618: ubsan: support setting additional ubsan check options This pull request has now been integrated. Changeset: e4d27d0e Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/e4d27d0efcacc40417ee3e42cc8cffd107e84de4 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8334618: ubsan: support setting additional ubsan check options Backport-of: efb905e57ab7a5299952419fa9961316541056c2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/885 From mbaesken at openjdk.org Fri Aug 9 14:08:46 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 14:08:46 GMT Subject: [jdk11u-dev] RFR: 8292044: HttpClient doesn't handle 102 or 103 properly [v2] In-Reply-To: References: Message-ID: <95RIQeC1kRzole6oV0qCKxDCp28EJvhZqW6qYPTNC9g=.b356dea1-2396-4136-b29d-828e4d8f715f@github.com> On Wed, 7 Aug 2024 11:15:48 GMT, Matthias Baesken wrote: >> Backport of 8292044 from 17 > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > change comment in test about other exception class ProtocolException in jdk17 Hi Martin, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2896#issuecomment-2278028243 From mbaesken at openjdk.org Fri Aug 9 14:08:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 9 Aug 2024 14:08:47 GMT Subject: [jdk11u-dev] Integrated: 8292044: HttpClient doesn't handle 102 or 103 properly In-Reply-To: References: Message-ID: <-0In2X6EUuUtXJDJpolmM-TEgeJTrLNdFJqbbV2pLV4=.d36a816a-0bd4-4376-a5cd-170554a7d253@github.com> On Tue, 6 Aug 2024 11:45:58 GMT, Matthias Baesken wrote: > Backport of 8292044 from 17 This pull request has now been integrated. Changeset: 73dc9e89 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/73dc9e89994dcd3ebc389845cbcd5979781ca3b0 Stats: 617 lines in 7 files changed: 609 ins; 0 del; 8 mod 8292044: HttpClient doesn't handle 102 or 103 properly Reviewed-by: mdoerr Backport-of: 10000286390ac9b0288cee25a4f3551d09475fdc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2896 From stuefe at openjdk.org Fri Aug 9 15:53:46 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 9 Aug 2024 15:53:46 GMT Subject: [jdk17u-dev] RFR: 8318089: Class space not marked as such with NMT when CDS is off In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 12:06:26 GMT, Andreas Steiner wrote: > 8318089: Class space not marked as such with NMT when CDS is off LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2794#pullrequestreview-2230539287 From ashi at openjdk.org Fri Aug 9 19:55:44 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 9 Aug 2024 19:55:44 GMT Subject: [jdk17u-dev] Integrated: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 20:58:25 GMT, Amos Shi wrote: > Backport of [JDK-8313901](https://bugs.openjdk.org/browse/JDK-8313901) > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `CodeCacheFullCountTest.java`: Test results: passed: 1 > - Pipeline: > - linux-x86,x64 macos-aarch64,x64 windows-aarch64,x64 - `Passed` > - Other failed test case is not caused by current PR and has been fixed in master > - Testing Machine: SAP nightlies skipped on `2024-08-07` > - Automated jtreg test: jtreg_hotspot_tier1, Started at 2024-08-06 20:18:52+01:00 > - `compiler/codecache/CodeCacheFullCountTest.java`: SUCCESSFUL GitHub ? - [20:19:40.191 -> 6,078 msec] This pull request has now been integrated. Changeset: 67b57e0f Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/67b57e0f579dbc119a1e5ffa8b5128621fad64b9 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError Backport-of: d1de3d082ef9b83aaa68664e653ab09feb8bad87 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2769 From ashi at openjdk.org Fri Aug 9 19:58:35 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 9 Aug 2024 19:58:35 GMT Subject: [jdk17u-dev] Integrated: 8306583: Add JVM crash check in CDSTestUtils.executeAndLog In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 23:35:59 GMT, Amos Shi wrote: > Backport of [JDK-8306583](https://bugs.openjdk.org/browse/JDK-8306583) > > Testing > - Local: Test passed > - `TestCDSVMCrash.java`: Test results: passed: 1 > - Pipeline: > - linux-x64,x86 macos-aarch64,x64 windows-aarch64,x64 - Passed > - The failed test case (`RuntimeException: All Platform's methods with signature '():Z' should be tested.`) is not caused by current PR and has been fixed in master branch > - Testing Machine: SAP nightlies passed on `2024-08-07` > - Automated jtreg test: jtreg_hotspot_tier1, Started at 2024-08-06 20:18:52+01:00 > - runtime/cds/TestCDSVMCrash.java: SUCCESSFUL GitHub ? - [20:23:37.036 -> 689 msec] This pull request has now been integrated. Changeset: a2b45f2e Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/a2b45f2eaad69a5edfc33830ab4f69ed76d3da04 Stats: 75 lines in 2 files changed: 74 ins; 0 del; 1 mod 8306583: Add JVM crash check in CDSTestUtils.executeAndLog Backport-of: 27764e60357b018b4f403d63cb54f95604b0cb8c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2771 From ashi at openjdk.org Fri Aug 9 19:58:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 9 Aug 2024 19:58:39 GMT Subject: [jdk17u-dev] Integrated: 8279641: Create manual JTReg tests for Swing accessibility In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 00:49:40 GMT, Amos Shi wrote: > Backport of [JDK-8279641](https://bugs.openjdk.org/browse/JDK-8279641) > > Testing > - Local: Passed on MacOS `14.6.1` with `Apple M1 Max` > - Manual `test/jdk/javax/accessibility/manual/ButtonDemo.java` - Test results: passed: 1 > - Manual `test/jdk/javax/accessibility/manual/ComboBoxDemo.java` - Test results: passed: 1 > - Manual `test/jdk/javax/accessibility/manual/DemoSelection.java` - Test results: passed: 1 > - Manual `test/jdk/javax/accessibility/manual/OptionPaneDemo.java` - Test results: passed: 1 > - Manual `test/jdk/javax/accessibility/manual/TableDemo.java` - Test results: passed: 1 > - Manual `test/jdk/javax/accessibility/manual/TabsDemo.java` - Test results: passed: 1 > - Manual `test/jdk/javax/accessibility/manual/TreeDemo.java` - Test results: passed: 1 > - Pipeline: > - linux-x64,x86 macos-aarch64,x64 windows-aarch64,x64 - Passed > - The failed test case (`RuntimeException: All Platform's methods with signature '():Z' should be tested.`) is not caused > - Testing Machine: SAP nightlies `SKIPPED` on `2024-08-07` > - Automated jtreg test: jtreg_hotspot_tier1, Started at 2024-08-06 20:18:52+01:00 > - javax/accessibility/manual/ButtonDemo.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub ? - [0 msec] > - javax/accessibility/manual/ComboBoxDemo.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub ? - [0 msec] > - javax/accessibility/manual/DemoSelection.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub ? - [0 msec] > - javax/accessibility/manual/OptionPaneDemo.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub ? - [0 msec] > - javax/accessibility/manual/TableDemo.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub ? - [0 msec] > - javax/accessibility/manual/TabsDemo.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub ? - [0 msec] > - javax/accessibility/manual/TreeDemo.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&... This pull request has now been integrated. Changeset: ebcad8c1 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/ebcad8c176e5d3019a7784bfde258a91605c80fa Stats: 1410 lines in 35 files changed: 1410 ins; 0 del; 0 mod 8279641: Create manual JTReg tests for Swing accessibility Backport-of: 5523ddebd572f38c3f960950d114ffead33266ae ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2773 From duke at openjdk.org Fri Aug 9 20:07:52 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 9 Aug 2024 20:07:52 GMT Subject: [jdk21u-dev] RFR: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 Message-ID: This is a clean backport of https://github.com/openjdk/jdk/commit/64c3642c57719940855b220025b33758950b3980 originally authored by @vpa1977 and reviewed by @jonathan-gibbons Additional testing: - [x] New regression test fails without the fix, passes with it - [x] linux-x86_64-server-release: `make test TEST=test/langtools/jdk/javadoc` ------------- Commit messages: - Backport 64c3642c57719940855b220025b33758950b3980 Changes: https://git.openjdk.org/jdk21u-dev/pull/856/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=856&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8242564 Stats: 61 lines in 2 files changed: 56 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/856.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/856/head:pull/856 PR: https://git.openjdk.org/jdk21u-dev/pull/856 From duke at openjdk.org Fri Aug 9 20:07:59 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 9 Aug 2024 20:07:59 GMT Subject: [jdk21u-dev] RFR: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable Message-ID: This is a clean backport of https://github.com/openjdk/jdk/commit/36ac83904c9e81a01822b0e36ef677cae2808709 originally authored by @bplb and reviewed by @AlanBateman It also includes this follow-up fix: * [JDK-8317128](https://bugs.openjdk.org/browse/JDK-8317128): **java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException** * https://github.com/openjdk/jdk/pull/15991 Additional testing: - [x] New regression test fails without the fix, passes with it - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST="tier1 tier2 tier3"` ------------- Commit messages: - Clean JDK-8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException - Backport 36ac83904c9e81a01822b0e36ef677cae2808709 Changes: https://git.openjdk.org/jdk21u-dev/pull/863/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=863&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8073061 Stats: 319 lines in 6 files changed: 307 ins; 3 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/863/head:pull/863 PR: https://git.openjdk.org/jdk21u-dev/pull/863 From duke at openjdk.org Fri Aug 9 20:07:59 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 9 Aug 2024 20:07:59 GMT Subject: [jdk21u-dev] RFR: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 20:25:34 GMT, Todd V. Jonker wrote: > This is a clean backport of https://github.com/openjdk/jdk/commit/36ac83904c9e81a01822b0e36ef677cae2808709 originally authored by @bplb and reviewed by @AlanBateman > > It also includes this follow-up fix: > * [JDK-8317128](https://bugs.openjdk.org/browse/JDK-8317128): **java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException** > * https://github.com/openjdk/jdk/pull/15991 > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST="tier1 tier2 tier3"` Putting back into draft; I missed the follow-up fix https://bugs.openjdk.org/browse/JDK-8317128 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/863#issuecomment-2249029646 From duke at openjdk.org Fri Aug 9 20:08:04 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 9 Aug 2024 20:08:04 GMT Subject: [jdk21u-dev] RFR: 8319817: Charset constructor should make defensive copy of aliases Message-ID: Clean backport. Additional testing: - [x] New regression test fails without the fix, passes with it - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` * These tests fail repeatedly, but also fail on `master`: * `build/AbsPathsInImage.java` * `java/nio/channels/FileChannel/directio/DirectIOTest.java` ------------- Commit messages: - Backport d6d7bdc7748c10963c3e58c0287b2472646bf36f Changes: https://git.openjdk.org/jdk21u-dev/pull/841/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=841&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319817 Stats: 76 lines in 2 files changed: 74 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/841.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/841/head:pull/841 PR: https://git.openjdk.org/jdk21u-dev/pull/841 From duke at openjdk.org Fri Aug 9 20:10:15 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 9 Aug 2024 20:10:15 GMT Subject: [jdk17u-dev] RFR: 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer Message-ID: Backports a fix for a potential data-loss defect from JDK19 to JDK17. This change is not clean, but the conflict is minimal and localized to `StreamDecoder.java`. Viewing this diff alongside the original fix [here](https://github.com/openjdk/jdk/commit/6520843f86f638fe4d1e5b3358fab5799daca654?diff=unified&w=0#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eR184-R227) and expanding context upward a bit should be illuminating. The conflict is due to structural/indentation difference when the lock acquisition at L158 was hoisted into a separate method. That happened [here](https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84?diff=unified&w=1#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eL154-L190) (wherein this file has an ugly diff obscuring relatively simple changes). Additional testing: - [x] New regression test fails without the fix, passes with it - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test` (tier1-3) ------------- Commit messages: - Backport 6520843f86f638fe4d1e5b3358fab5799daca654 Changes: https://git.openjdk.org/jdk17u-dev/pull/2726/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2726&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287003 Stats: 33 lines in 2 files changed: 24 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2726.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2726/head:pull/2726 PR: https://git.openjdk.org/jdk17u-dev/pull/2726 From duke at openjdk.org Fri Aug 9 20:10:23 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 9 Aug 2024 20:10:23 GMT Subject: [jdk17u-dev] RFR: 8319817: Charset constructor should make defensive copy of aliases Message-ID: <6cD_If-pKlvZDkDjOVIZciiV3ew1B8FY2SjVGDlwBzE=.c5966432-fe63-4b53-82d2-6452808331e6@github.com> Clean backport. Additional testing: - [x] New regression test fails without the fix, passes with it - [x] macosx-aarch64-server-release: `make test-tier1` - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` * These tests fail repeatedly, but also fail on `master`: * `build/AbsPathsInImage.java` * `jdk/internal/platform/docker/TestDockerMemoryMetrics.java` ------------- Commit messages: - Backport d6d7bdc7748c10963c3e58c0287b2472646bf36f Changes: https://git.openjdk.org/jdk17u-dev/pull/2713/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2713&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319817 Stats: 76 lines in 2 files changed: 74 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2713.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2713/head:pull/2713 PR: https://git.openjdk.org/jdk17u-dev/pull/2713 From duke at openjdk.org Fri Aug 9 22:52:37 2024 From: duke at openjdk.org (Daniel Hu) Date: Fri, 9 Aug 2024 22:52:37 GMT Subject: [jdk21u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved Message-ID: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> Backport of [JDK-8312049](https://bugs.openjdk.org/browse/JDK-8312049): improving ClassLoadUnloadTest. Original commit does not apply cleanly due to this [backport](https://bugs.openjdk.org/browse/JDK-8323123) that renames createJavaProcessBuilder to createLimitedTestJavaProcessBuilder. Additionally, the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Passes tier1 tests on Linux x86 and MacOS aarch64, and most importantly, the test itself. ------------- Commit messages: - Backport 4676b40f17dd18941f5883cb9b989ad639992a50 Changes: https://git.openjdk.org/jdk21u-dev/pull/909/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=909&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312049 Stats: 35 lines in 1 file changed: 2 ins; 7 del; 26 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/909.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/909/head:pull/909 PR: https://git.openjdk.org/jdk21u-dev/pull/909 From duke at openjdk.org Mon Aug 12 02:10:37 2024 From: duke at openjdk.org (duke) Date: Mon, 12 Aug 2024 02:10:37 GMT Subject: [jdk21u-dev] RFR: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 07:20:29 GMT, Jiawei Tang wrote: > I will backport [JDK-8337331](https://bugs.openjdk.org/browse/JDK-8337331) after this to fix the deadlock / jvm crash problem. @jia-wei-tang Your change (at version 126d8cb2dd4fdc903a02783adc15438e19a689b8) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/907#issuecomment-2283005007 From andrewlu at openjdk.org Mon Aug 12 02:23:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 12 Aug 2024 02:23:37 GMT Subject: [jdk21u-dev] Integrated: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 08:48:03 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 27abeb82 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/27abeb82ccfaf8a108e13a73b98920f5a2953a1f Stats: 286 lines in 2 files changed: 48 ins; 211 del; 27 mod 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Backport-of: ab183e437c18b445e9c022a4d74de818d4ccecbe ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/900 From shade at openjdk.org Mon Aug 12 08:22:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 08:22:37 GMT Subject: [jdk21u-dev] RFR: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 07:20:29 GMT, Jiawei Tang wrote: > I will backport [JDK-8337331](https://bugs.openjdk.org/browse/JDK-8337331) after this to fix the deadlock / jvm crash problem. All right. You need to pick up [JDK-8337331](https://bugs.openjdk.org/browse/JDK-8337331) immediately after this. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/907#issuecomment-2283362294 From jwtang at openjdk.org Mon Aug 12 08:22:38 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 12 Aug 2024 08:22:38 GMT Subject: [jdk21u-dev] Integrated: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 07:20:29 GMT, Jiawei Tang wrote: > I will backport [JDK-8337331](https://bugs.openjdk.org/browse/JDK-8337331) after this to fix the deadlock / jvm crash problem. This pull request has now been integrated. Changeset: 27b1e1a6 Author: Jiawei Tang Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/27b1e1a6c92df1d09572c2f494d860d574c3b5b4 Stats: 9 lines in 1 file changed: 2 ins; 2 del; 5 mod 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed Backport-of: c4ff58b9bcfd08eae0623a648a837e08f25b3f9b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/907 From mbaesken at openjdk.org Mon Aug 12 08:23:42 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 12 Aug 2024 08:23:42 GMT Subject: [jdk17u-dev] RFR: 8330814: Cleanups for KeepAliveCache tests In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 05:12:38 GMT, Christoph Langer wrote: > Backporting the cleanups for KeepAliveCache tests. Now with all prerequisites in place, it applies nearly clean. Only in test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java there was a little modification due to the different HttpServer API in 17 which lacks the constructor with all the options that is used in higher releases. sun/net/www/http/KeepAliveCache/B5045306.java fails now in our nightly tests; please check this before integrating. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2790#issuecomment-2283366726 From jwtang at openjdk.org Mon Aug 12 08:31:52 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 12 Aug 2024 08:31:52 GMT Subject: [jdk21u-dev] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option Message-ID: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option ------------- Commit messages: - Backport 55c509708e9b89a7609fd41b6e5a271f250bbacd Changes: https://git.openjdk.org/jdk21u-dev/pull/910/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=910&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337331 Stats: 83 lines in 2 files changed: 78 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/910.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/910/head:pull/910 PR: https://git.openjdk.org/jdk21u-dev/pull/910 From sgehwolf at openjdk.org Mon Aug 12 09:57:32 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 12 Aug 2024 09:57:32 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v2] In-Reply-To: References: <2wBmyrfLiij-rq9PtiE2OEaua9bx6ORiq_nSGod3Vqk=.7f56115f-8aa5-447e-93ba-0c23b947a476@github.com> Message-ID: On Tue, 4 Jun 2024 09:03:39 GMT, Severin Gehwolf wrote: >>> Lets wait on getting this one backported until the compatibility impact wrt. setting the context class loader of a thread in the common pool is addressed. >> >> Checking, @jerboaa, are you good with this going into jdk21u-dev? > > @shipilev Yes, though, a bit uneasy. It fixes the unloading issue. We'll have a close look once EA builds are available. Worst case we'll have to back it out during stabilization closer to the 21.0.5 release. > Re-based, re-tested, ready to integrate. Checking with @jerboaa -- go or no-go? @shipilev Please go ahead and integrate it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/338#issuecomment-2283546017 From shade at openjdk.org Mon Aug 12 10:08:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 10:08:33 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v4] In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 09:03:05 GMT, Aleksey Shipilev wrote: >> The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` >> - [x] Linux AArch64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Backport 28216aa971ea65938117107542152abd532a5384 > - Backport 53c4714aab2e072ba18631875dcaa3b2d5d22243 Aye. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/338#issuecomment-2283562983 From shade at openjdk.org Mon Aug 12 10:08:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 10:08:34 GMT Subject: [jdk21u-dev] Integrated: 8327501: Common ForkJoinPool prevents class unloading in some cases In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 10:07:27 GMT, Aleksey Shipilev wrote: > The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` > - [x] Linux AArch64 server fastdebug, `all` This pull request has now been integrated. Changeset: eb103b0e Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/eb103b0e1abeeee19779cafc763d3d159030fb48 Stats: 11 lines in 2 files changed: 8 ins; 2 del; 1 mod 8327501: Common ForkJoinPool prevents class unloading in some cases 8328366: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 Backport-of: 53c4714aab2e072ba18631875dcaa3b2d5d22243 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/338 From shade at openjdk.org Mon Aug 12 10:35:08 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 10:35:08 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable Message-ID: Clean backport to improve IR Framework for upcoming tests. Additional testing: - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes ------------- Commit messages: - Backport c01f53ac2dab1d4d2cd1e4d45a67f9373d4a9c7e Changes: https://git.openjdk.org/jdk23u/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337876 Stats: 103 lines in 5 files changed: 96 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk23u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/62/head:pull/62 PR: https://git.openjdk.org/jdk23u/pull/62 From zzambers at openjdk.org Mon Aug 12 10:41:38 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 12 Aug 2024 10:41:38 GMT Subject: [jdk23u] Integrated: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: <5P7-gPAOJAoBtu3hJpAYJstSq18adtuwx-r8Bhj4lPk=.059df206-8e92-4396-a938-4ff53d3dbc39@github.com> On Thu, 8 Aug 2024 12:14:20 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed This pull request has now been integrated. Changeset: 66fb62a0 Author: Zdenek Zambersky Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/66fb62a0f47c60eedae9fc1e5e180167ab8b3aee Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod 8336928: GHA: Bundle artifacts removal broken Backport-of: 98562166e4a4c8921709014423c6cbc993aa0d97 ------------- PR: https://git.openjdk.org/jdk23u/pull/61 From shade at openjdk.org Mon Aug 12 10:44:21 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 10:44:21 GMT Subject: [jdk21u-dev] RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields Message-ID: <3ZOtJXSLMAjBPdNyxhPA-v0Kg2_ptnGPB30oHh3Up2s=.800a9c60-03c0-491b-987e-0b2378fecb85@github.com> Improves IR Framework, allows backporting IR Tests without modifications. Applies nearly cleanly, except the hunk in `compiler/c2/irTests/TestTestRemovalPeephole.java`, since this file does not exist in JDK 21. Additional testing: - [x] Grep `@Arguments` yields no unfixed cases in test suite - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` - [ ] Linux AArch64 server release, `testlibrary_tests/ir_framework compiler/c2/irTests` - [ ] Linux AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` ------------- Commit messages: - Backport 8d9ad97c293b090fbcedbfdb046f1b5d97b02f87 Changes: https://git.openjdk.org/jdk21u-dev/pull/911/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=911&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324641 Stats: 1156 lines in 27 files changed: 899 ins; 52 del; 205 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/911.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/911/head:pull/911 PR: https://git.openjdk.org/jdk21u-dev/pull/911 From shade at openjdk.org Mon Aug 12 10:56:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 10:56:31 GMT Subject: [jdk21u-dev] RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields In-Reply-To: <3ZOtJXSLMAjBPdNyxhPA-v0Kg2_ptnGPB30oHh3Up2s=.800a9c60-03c0-491b-987e-0b2378fecb85@github.com> References: <3ZOtJXSLMAjBPdNyxhPA-v0Kg2_ptnGPB30oHh3Up2s=.800a9c60-03c0-491b-987e-0b2378fecb85@github.com> Message-ID: On Mon, 12 Aug 2024 10:36:15 GMT, Aleksey Shipilev wrote: > Improves IR Framework, allows backporting IR Tests without modifications. Applies nearly cleanly, except the hunk in `compiler/c2/irTests/TestTestRemovalPeephole.java`, since this file does not exist in JDK 21. > > Additional testing: > - [x] Grep `@Arguments` yields no unfixed cases in test suite > - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` > - [x] Linux AArch64 server release, `testlibrary_tests/ir_framework compiler/c2/irTests` > - [x] Linux AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` @chhagedorn, FYI, I am bringing this to JDK 21 to make IR tests cleaner. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/911#issuecomment-2283652844 From coffeys at openjdk.org Mon Aug 12 11:00:33 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Mon, 12 Aug 2024 11:00:33 GMT Subject: [jdk23u] RFR: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive [v2] In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 06:28:08 GMT, Vanitha B P wrote: >> It is a clean backport. > > Vanitha B P has updated the pull request incrementally with one additional commit since the last revision: > > Vanitha B P sorry - just seeing this now! ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/51#issuecomment-2283658243 From duke at openjdk.org Mon Aug 12 11:00:34 2024 From: duke at openjdk.org (Vanitha B P) Date: Mon, 12 Aug 2024 11:00:34 GMT Subject: [jdk23u] Integrated: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 12:08:14 GMT, Vanitha B P wrote: > It is a clean backport. This pull request has now been integrated. Changeset: 28207685 Author: Vanitha B P Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/28207685993f30559d34b659c9cd4cadff37378a Stats: 20 lines in 2 files changed: 5 ins; 1 del; 14 mod 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive Backport-of: 2c9fd9016f4675448a62380ff2b86533020e690f ------------- PR: https://git.openjdk.org/jdk23u/pull/51 From shade at openjdk.org Mon Aug 12 11:04:13 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 11:04:13 GMT Subject: [jdk17u-dev] RFR: 8272558: IR Test Framework README misses some flags Message-ID: This is a simple docs amendment. Without it, IR Framework backports are not clean and require tedious resolves. ------------- Commit messages: - Backport 5189047d09e976cfd17d4ab5ec12097c242f3435 Changes: https://git.openjdk.org/jdk17u-dev/pull/2795/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2795&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272558 Stats: 17 lines in 1 file changed: 2 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2795.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2795/head:pull/2795 PR: https://git.openjdk.org/jdk17u-dev/pull/2795 From shade at openjdk.org Mon Aug 12 11:14:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 11:14:31 GMT Subject: [jdk23u] RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java In-Reply-To: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> References: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Message-ID: On Tue, 6 Aug 2024 14:50:35 GMT, Mimoun Ghordou wrote: > Clean Backport > > Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine There is an issue with the test: [JDK-8336148](https://bugs.openjdk.org/browse/JDK-8336148) -- I don't think we can integrate until that is resolved. ------------- Changes requested by shade (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/57#pullrequestreview-2232687564 From aph at openjdk.org Mon Aug 12 12:02:05 2024 From: aph at openjdk.org (Andrew Haley) Date: Mon, 12 Aug 2024 12:02:05 GMT Subject: [jdk23u] RFR: 8337958: Out-of-bounds array access in secondary_super_cache Message-ID: Hi all, This pull request contains a backport of commit [03204600](https://github.com/openjdk/jdk/commit/03204600c596214895ef86581eba9722f76d39b3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrew Haley on 12 Aug 2024 and was reviewed by Vladimir Ivanov and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 03204600c596214895ef86581eba9722f76d39b3 Changes: https://git.openjdk.org/jdk23u/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=63&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337958 Stats: 13 lines in 3 files changed: 3 ins; 1 del; 9 mod Patch: https://git.openjdk.org/jdk23u/pull/63.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/63/head:pull/63 PR: https://git.openjdk.org/jdk23u/pull/63 From sgehwolf at openjdk.org Mon Aug 12 13:02:44 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 12 Aug 2024 13:02:44 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check [v2] In-Reply-To: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> References: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> Message-ID: On Fri, 9 Aug 2024 13:55:05 GMT, Matthias Baesken wrote: >> Backport of 8334166; previous warning setting missing so not clean > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > add issuestitle from 8334166 Looks fine. Thanks for doing this! ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/906#pullrequestreview-2232948500 From shade at openjdk.org Mon Aug 12 13:12:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 13:12:38 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check [v2] In-Reply-To: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> References: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> Message-ID: On Fri, 9 Aug 2024 13:55:05 GMT, Matthias Baesken wrote: >> Backport of 8334166; previous warning setting missing so not clean > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > add issuestitle from 8334166 This is fine, as long as they are warnings. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/906#pullrequestreview-2232973936 From mbaesken at openjdk.org Mon Aug 12 13:12:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 12 Aug 2024 13:12:38 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check [v2] In-Reply-To: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> References: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> Message-ID: <3xC_dOJyDKqS1oSW7ZOx2_-WRuBHqO5n67roO0q-MQA=.c18b0d3b-8fad-42c6-ab80-05351a04103b@github.com> On Fri, 9 Aug 2024 13:55:05 GMT, Matthias Baesken wrote: >> Backport of 8334166; previous warning setting missing so not clean > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > add issuestitle from 8334166 Thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/906#issuecomment-2283942814 From shade at openjdk.org Mon Aug 12 13:13:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 13:13:41 GMT Subject: [jdk21u-dev] RFR: 8331572: Allow using OopMapCache outside of STW GC phases [v3] In-Reply-To: <6IlwxqgiorZ4wqxRLi2J9TWcxzzjIDHSHLF4r7uoC_0=.122ec8e5-be62-4ab8-a854-30cc54d97e7f@github.com> References: <49YutDmQvYgxmebaYPJSIGEVyHUVPP4Ok9ZdiohkYB8=.8b1a8a83-6d66-4700-a319-d9d77de734fe@github.com> <6IlwxqgiorZ4wqxRLi2J9TWcxzzjIDHSHLF4r7uoC_0=.122ec8e5-be62-4ab8-a854-30cc54d97e7f@github.com> Message-ID: On Fri, 7 Jun 2024 21:27:24 GMT, Paul Hohensee wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: >> >> - Merge branch 'master' into JDK-8331572-oopmap-cache-all >> - Backport 05ff3185edd25b381a97f6879f496e97b62dddc2 >> - Merge branch 'master' into JDK-8331572-oopmap-cache-all >> - Backport d999b81e7110751be402012e1ed41b3256f5895e > > Marked as reviewed by phh (Reviewer). @phohensee or anyone else, please re-review? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/610#issuecomment-2283945801 From kcr at openjdk.org Mon Aug 12 13:20:31 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 12 Aug 2024 13:20:31 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check [v2] In-Reply-To: References: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> Message-ID: On Mon, 12 Aug 2024 13:10:23 GMT, Aleksey Shipilev wrote: > This is fine, as long as they are warnings. Both of them are. FWIW, I did the same thing for the JavaFX equivalent of these, and enabled both warnings in the same PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/906#issuecomment-2283966984 From coffeys at openjdk.org Mon Aug 12 13:28:37 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Mon, 12 Aug 2024 13:28:37 GMT Subject: [jdk23u] RFR: 8332113: Update nsk.share.Log to be always verbose In-Reply-To: References: Message-ID: On Wed, 26 Jun 2024 09:39:30 GMT, Mimoun Ghordou wrote: > Tested Tier 1 Marked as reviewed by coffeys (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/11#pullrequestreview-2233022858 From duke at openjdk.org Mon Aug 12 13:28:37 2024 From: duke at openjdk.org (duke) Date: Mon, 12 Aug 2024 13:28:37 GMT Subject: [jdk23u] RFR: 8332113: Update nsk.share.Log to be always verbose In-Reply-To: References: Message-ID: On Wed, 26 Jun 2024 09:39:30 GMT, Mimoun Ghordou wrote: > Tested Tier 1 @ghmaimon Your change (at version 912ba697f0ab0cf08bee1083066bf2b1756492b4) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/11#issuecomment-2283992466 From duke at openjdk.org Mon Aug 12 13:44:40 2024 From: duke at openjdk.org (Mimoun Ghordou) Date: Mon, 12 Aug 2024 13:44:40 GMT Subject: [jdk23u] Integrated: 8332113: Update nsk.share.Log to be always verbose In-Reply-To: References: Message-ID: <2I2tKv5pB3x8BUHKJJPFR6iiCh_m7Y7iB8F_f9FOPa0=.15f7afd3-3da3-4bf6-990f-c350d8886bda@github.com> On Wed, 26 Jun 2024 09:39:30 GMT, Mimoun Ghordou wrote: > Tested Tier 1 This pull request has now been integrated. Changeset: fd4f3305 Author: Leonid Mesnik Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/fd4f33057c8fb914992e9ae86b0d5695b62a2a77 Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod 8332113: Update nsk.share.Log to be always verbose Reviewed-by: lmesnik, coffeys Backport-of: 8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 ------------- PR: https://git.openjdk.org/jdk23u/pull/11 From phh at openjdk.org Mon Aug 12 14:21:48 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Aug 2024 14:21:48 GMT Subject: [jdk21u-dev] RFR: 8331572: Allow using OopMapCache outside of STW GC phases [v3] In-Reply-To: References: <49YutDmQvYgxmebaYPJSIGEVyHUVPP4Ok9ZdiohkYB8=.8b1a8a83-6d66-4700-a319-d9d77de734fe@github.com> Message-ID: On Thu, 8 Aug 2024 16:31:09 GMT, Aleksey Shipilev wrote: >> Unclean backport to improve GC and general stack walk performance when walking interpreted frames. >> >> This is one of few backports that gets `OopMapCache` behavior similar to mainline. This makes [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely. >> >> The point of uncleanliness comes from the way we hook up the cleanup notifications to Service Thread. In later JDKs, [JDK-8329488](https://bugs.openjdk.org/browse/JDK-8329488) made Service Thread wake up regularly to do various cleanups. In JDK 21, we still need to hook up the clean up to the "usual" place in safepoint epilog. >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8331572-oopmap-cache-all > - Backport 05ff3185edd25b381a97f6879f496e97b62dddc2 > - Merge branch 'master' into JDK-8331572-oopmap-cache-all > - Backport d999b81e7110751be402012e1ed41b3256f5895e Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/610#pullrequestreview-2233154798 From shade at openjdk.org Mon Aug 12 14:34:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 14:34:09 GMT Subject: [jdk23u] RFR: 8335007: Inline OopMapCache table Message-ID: Clean backport to improve OopMapCache. I actually want this change in 21u-dev, so I am backporting to 23u on its way there. The change is pretty simple, so there is only a little risk. Additional testing: - [ ] Linux x86_64 server fastdebug, `tier1` ------------- Commit messages: - Backport 50dd962b0d0fe36634d96dbbd9d94fbc34d9ff7f Changes: https://git.openjdk.org/jdk23u/pull/64/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=64&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335007 Stats: 17 lines in 2 files changed: 0 ins; 5 del; 12 mod Patch: https://git.openjdk.org/jdk23u/pull/64.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/64/head:pull/64 PR: https://git.openjdk.org/jdk23u/pull/64 From tim.bell at oracle.com Mon Aug 12 15:04:20 2024 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Mon, 12 Aug 2024 15:04:20 +0000 Subject: Need CCATS for OpenJDK 8 (ECCN 5D992.c) In-Reply-To: References: Message-ID: <1f18679e-9e7e-4024-818a-4e90b61c43f7@oracle.com> Hello OpenJDK can't provide export control certification information for third parties. Contact the vendor providing your JDK 8 runtime for this information. Best regards- Tim Bell OpenJDK.org infrastructure team On 8/12/24 13:34, Hemantkumar Prakashbhai Makhijani wrote: > Hello > Jdk8u, build-dev , jdk-updates-dev > > Can you guys help us here please ? > > > > > > Regards > Hemantkumar Makhijani > > > > ------------------------------------------------------------------------ > *From:* Hemantkumar Prakashbhai Makhijani > *Sent:* Monday, August 12, 2024 3:45 PM > *To:* mailman-owner at openjdk.org > *Cc:* Shankar Shailesh ; Rim Bains > *Subject:* RE: Need CCATS for OpenJDK 8 (ECCN 5D992.c) > > Gentle reminder ? > > Since *OpenJDK 8*is managed by you, > > Please provide Commodity Classification Automated Tracking System > (CCATS > ) > . > > This is because, we got to know that, for ENC product, it is mandatory > to get CCATS certificate from U.S. to meet export control guidelines. > > Regards > > *Hemant Makhijani* > > *From:*Hemantkumar Prakashbhai Makhijani > *Sent:* Thursday, August 8, 2024 7:21 PM > *To:* mailman-owner at openjdk.org > *Cc:* Shankar Shailesh ; Rim Bains > *Subject:* Need CCATS for OpenJDK 8 (ECCN 5D992.c) > > Hello > > We are interested to obtain a copy of the Commodity Classification > Automated Tracking System (CCATS > )certificate > so that we can understand how *ENC note reporting* should be handled > for your *below* product : > > OpenJDK 8 > . > > Note :- > > Referring this, we could understand that OpenJDK has ECCN as 5D992.c > and CCATS number as *G167674. *However, we don?t see actual CCATS > certificate anywhere. > > Regards > > *Hemantkumar Makhijani | SLB* > > SLB-Public > -------------- next part -------------- An HTML attachment was scrubbed... URL: From shade at openjdk.org Mon Aug 12 15:09:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 15:09:38 GMT Subject: [jdk23u] Integrated: 8336343: Add more known sysroot library locations for ALSA In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 17:53:06 GMT, Aleksey Shipilev wrote: > Allows cleaner cross-builds without supplying `--with-alsa` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 23u builds, and there were no problems. This pull request has now been integrated. Changeset: d6046d87 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/d6046d876c24607efccb58a46541a8f66495d291 Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod 8336343: Add more known sysroot library locations for ALSA Backport-of: 9e6e0a8f341389215f0db6b2260f2b16351f02be ------------- PR: https://git.openjdk.org/jdk23u/pull/55 From shade at openjdk.org Mon Aug 12 15:10:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 15:10:38 GMT Subject: [jdk23u] Integrated: 8337283: configure.log is truncated when build dir is on different filesystem In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 17:51:32 GMT, Aleksey Shipilev wrote: > Keeps `configure.log` nice and complete. I have been running with this patch for more than a week in 23u builds, and there were no problems. This pull request has now been integrated. Changeset: 677c18ef Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/677c18efeb072b9b7eecfb5bb0bdd6f3ba06e311 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod 8337283: configure.log is truncated when build dir is on different filesystem Backport-of: 7e925d727f716e5c366b0d85b9c0de24efe43103 ------------- PR: https://git.openjdk.org/jdk23u/pull/53 From shade at openjdk.org Mon Aug 12 15:10:42 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 12 Aug 2024 15:10:42 GMT Subject: [jdk23u] Integrated: 8336342: Fix known X11 library locations in sysroot In-Reply-To: <6nu_K76RSzQE2La8dE2CI79DBRSpTcF-fHDWPljH3_M=.6ec7ab61-b53b-4e22-abe7-0e5bc2687497@github.com> References: <6nu_K76RSzQE2La8dE2CI79DBRSpTcF-fHDWPljH3_M=.6ec7ab61-b53b-4e22-abe7-0e5bc2687497@github.com> Message-ID: On Mon, 5 Aug 2024 17:52:46 GMT, Aleksey Shipilev wrote: > Allows cleaner cross-builds without supplying `--x-libraries` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 23u builds, and there were no problems. This pull request has now been integrated. Changeset: de9f5ed9 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/de9f5ed9c60addecfc729d209fb82df56deed093 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8336342: Fix known X11 library locations in sysroot Backport-of: ee365d75cca6f33e5781fe514e557caba2b67c32 ------------- PR: https://git.openjdk.org/jdk23u/pull/54 From sshivang at openjdk.org Mon Aug 12 15:17:37 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 12 Aug 2024 15:17:37 GMT Subject: [jdk23u] Integrated: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 06:56:35 GMT, Shivangi Gupta wrote: > Straight Backport This pull request has now been integrated. Changeset: ed24b9e6 Author: Shivangi Gupta Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/ed24b9e62f91a566759fe1f6303ea7b31a7c877a Stats: 96 lines in 1 file changed: 60 ins; 5 del; 31 mod 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect Backport-of: 330e520c1d42d3a9f3e187873dcd8ed7fd561aaf ------------- PR: https://git.openjdk.org/jdk23u/pull/50 From vlivanov at openjdk.org Mon Aug 12 16:36:36 2024 From: vlivanov at openjdk.org (Vladimir Ivanov) Date: Mon, 12 Aug 2024 16:36:36 GMT Subject: [jdk23u] RFR: 8337958: Out-of-bounds array access in secondary_super_cache In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 11:57:17 GMT, Andrew Haley wrote: > Hi all, > > This pull request contains a backport of commit [03204600](https://github.com/openjdk/jdk/commit/03204600c596214895ef86581eba9722f76d39b3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew Haley on 12 Aug 2024 and was reviewed by Vladimir Ivanov and Aleksey Shipilev. > > Thanks! Marked as reviewed by vlivanov (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/63#pullrequestreview-2233542486 From aph at openjdk.org Mon Aug 12 17:02:31 2024 From: aph at openjdk.org (Andrew Haley) Date: Mon, 12 Aug 2024 17:02:31 GMT Subject: [jdk23u] RFR: 8337958: Out-of-bounds array access in secondary_super_cache In-Reply-To: References: Message-ID: <-N_uK9x1PE7lWY1wkVi6dvttRa-HA6a67ryAnP75-3k=.f82b2f99-70fd-4721-9eb3-ec32e0d9b661@github.com> On Mon, 12 Aug 2024 16:34:20 GMT, Vladimir Ivanov wrote: >> Hi all, >> >> This pull request contains a backport of commit [03204600](https://github.com/openjdk/jdk/commit/03204600c596214895ef86581eba9722f76d39b3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Andrew Haley on 12 Aug 2024 and was reviewed by Vladimir Ivanov and Aleksey Shipilev. >> >> Thanks! > > Marked as reviewed by vlivanov (Reviewer). Thanks @iwanowww . Do I need another reviewer? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/63#issuecomment-2284507189 From phh at openjdk.org Mon Aug 12 17:04:40 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Aug 2024 17:04:40 GMT Subject: [jdk21u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> References: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> Message-ID: On Fri, 9 Aug 2024 21:08:29 GMT, Daniel Hu wrote: > Backport of [JDK-8312049](https://bugs.openjdk.org/browse/JDK-8312049): improving ClassLoadUnloadTest. Original commit does not apply cleanly due to this [backport](https://bugs.openjdk.org/browse/JDK-8323123) that renames createJavaProcessBuilder to createLimitedTestJavaProcessBuilder. Additionally, the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. > > Passes tier1 tests on Linux x86 and MacOS aarch64, and most importantly, the test itself. Please tag the JBS issue after you get a review (or if the backport is clean), rather than before. :) ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/909#pullrequestreview-2233597994 From kvn at openjdk.org Mon Aug 12 17:13:31 2024 From: kvn at openjdk.org (Vladimir Kozlov) Date: Mon, 12 Aug 2024 17:13:31 GMT Subject: [jdk23u] RFR: 8337958: Out-of-bounds array access in secondary_super_cache In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 16:34:20 GMT, Vladimir Ivanov wrote: >> Hi all, >> >> This pull request contains a backport of commit [03204600](https://github.com/openjdk/jdk/commit/03204600c596214895ef86581eba9722f76d39b3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Andrew Haley on 12 Aug 2024 and was reviewed by Vladimir Ivanov and Aleksey Shipilev. >> >> Thanks! > > Marked as reviewed by vlivanov (Reviewer). > Thanks @iwanowww . Do I need another reviewer? No, for clean backport. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/63#issuecomment-2284527260 From serb at openjdk.org Mon Aug 12 17:23:44 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:23:44 GMT Subject: [jdk21u-dev] RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG In-Reply-To: <57cH2emDQ965zvl4hqSy67m4z4LY-7B0fhDouC5u6Jo=.6639c626-0a5b-44a9-bfaf-7e1bc5809f17@github.com> References: <57cH2emDQ965zvl4hqSy67m4z4LY-7B0fhDouC5u6Jo=.6639c626-0a5b-44a9-bfaf-7e1bc5809f17@github.com> Message-ID: On Mon, 1 Jul 2024 07:06:53 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [c7c6d47a](https://github.com/openjdk/jdk/commit/c7c6d47a07100f6c81af6cfad301ec1bda77adf7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Liam Miller-Cushon on 13 Jul 2023 and was reviewed by Phil Race and Sergey Bylokhov. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/806#issuecomment-2284545524 From kcr at openjdk.org Mon Aug 12 17:54:35 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 12 Aug 2024 17:54:35 GMT Subject: [jdk23u] RFR: 8337958: Out-of-bounds array access in secondary_super_cache In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 16:34:20 GMT, Vladimir Ivanov wrote: >> Hi all, >> >> This pull request contains a backport of commit [03204600](https://github.com/openjdk/jdk/commit/03204600c596214895ef86581eba9722f76d39b3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Andrew Haley on 12 Aug 2024 and was reviewed by Vladimir Ivanov and Aleksey Shipilev. >> >> Thanks! > > Marked as reviewed by vlivanov (Reviewer). > > Thanks @iwanowww . Do I need another reviewer? > > No, for clean backport. The review requirement has been met. Maintainer approval is pending. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/63#issuecomment-2284598801 From phh at openjdk.org Mon Aug 12 18:43:38 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Aug 2024 18:43:38 GMT Subject: [jdk21u-dev] RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG In-Reply-To: References: <57cH2emDQ965zvl4hqSy67m4z4LY-7B0fhDouC5u6Jo=.6639c626-0a5b-44a9-bfaf-7e1bc5809f17@github.com> Message-ID: On Mon, 12 Aug 2024 17:21:05 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [c7c6d47a](https://github.com/openjdk/jdk/commit/c7c6d47a07100f6c81af6cfad301ec1bda77adf7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Liam Miller-Cushon on 13 Jul 2023 and was reviewed by Phil Race and Sergey Bylokhov. >> >> Thanks! > > keep open @mrserb, this needs an approval request. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/806#issuecomment-2284678111 From phh at openjdk.org Mon Aug 12 18:51:32 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Aug 2024 18:51:32 GMT Subject: [jdk21u-dev] RFR: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields In-Reply-To: <3ZOtJXSLMAjBPdNyxhPA-v0Kg2_ptnGPB30oHh3Up2s=.800a9c60-03c0-491b-987e-0b2378fecb85@github.com> References: <3ZOtJXSLMAjBPdNyxhPA-v0Kg2_ptnGPB30oHh3Up2s=.800a9c60-03c0-491b-987e-0b2378fecb85@github.com> Message-ID: On Mon, 12 Aug 2024 10:36:15 GMT, Aleksey Shipilev wrote: > Improves IR Framework, allows backporting IR Tests without modifications. Applies nearly cleanly, except the hunk in `compiler/c2/irTests/TestTestRemovalPeephole.java`, since this file does not exist in JDK 21. > > Additional testing: > - [x] Grep `@Arguments` yields no unfixed cases in test suite > - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` > - [x] Linux AArch64 server release, `testlibrary_tests/ir_framework compiler/c2/irTests` > - [x] Linux AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/911#pullrequestreview-2233790070 From phh at openjdk.org Mon Aug 12 19:02:52 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Aug 2024 19:02:52 GMT Subject: [jdk17u-dev] RFR: 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer In-Reply-To: References: Message-ID: On Thu, 18 Jul 2024 22:50:53 GMT, Todd V. Jonker wrote: > Backports a fix for a potential data-loss defect from JDK19 to JDK17. > > This change is not clean, but the conflict is minimal and localized to `StreamDecoder.java`. > > Viewing this diff alongside the original fix [here](https://github.com/openjdk/jdk/commit/6520843f86f638fe4d1e5b3358fab5799daca654?diff=unified&w=0#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eR184-R227) and expanding context upward a bit should be illuminating. The conflict is due to structural/indentation difference when the lock acquisition at L158 was hoisted into a separate method. That happened [here](https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84?diff=unified&w=1#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eL154-L190) (wherein this file has an ugly diff obscuring relatively simple changes). > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test` (tier1-3) Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2726#pullrequestreview-2233808959 From btaylor at openjdk.org Mon Aug 12 20:01:09 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 12 Aug 2024 20:01:09 GMT Subject: [jdk21u-dev] RFR: 8321206: Make Locale related system properties `StaticProperty` Message-ID: Clean backport of change to make Locale system properties static. >From the original PR: >Currently, Locale-related system properties, such as user.language or user.country, are initialized when the Locale class is loaded. Making them static properties is safer than relying on the Locale class loading timing, which could potentially be changed depending on the implementation. This change also makes [JDK-8321940](https://bugs.openjdk.org/browse/JDK-8321940) clean, which will improve maintainability by reducing the number of manually curated `ADD_EXCL` entries in `cdsHeapVerifier.cpp`. ------------- Commit messages: - Backport 0c178beb69c4c5fc3e92621340748e42d017d458 Changes: https://git.openjdk.org/jdk21u-dev/pull/912/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=912&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321206 Stats: 69 lines in 3 files changed: 49 ins; 7 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/912.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/912/head:pull/912 PR: https://git.openjdk.org/jdk21u-dev/pull/912 From phh at openjdk.org Mon Aug 12 20:33:32 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Aug 2024 20:33:32 GMT Subject: [jdk21u-dev] RFR: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 20:25:34 GMT, Todd V. Jonker wrote: > This is a clean backport of https://github.com/openjdk/jdk/commit/36ac83904c9e81a01822b0e36ef677cae2808709 originally authored by @bplb and reviewed by @AlanBateman > > It also includes this follow-up fix: > * [JDK-8317128](https://bugs.openjdk.org/browse/JDK-8317128): **java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException** > * https://github.com/openjdk/jdk/pull/15991 > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST="tier1 tier2 tier3"` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/863#pullrequestreview-2233960309 From duke at openjdk.org Mon Aug 12 23:43:29 2024 From: duke at openjdk.org (Daniel Hu) Date: Mon, 12 Aug 2024 23:43:29 GMT Subject: [jdk21u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Message-ID: Backport of improvements to DataDescriptorSignatureMissing test. Unclean for 2 minor reasons: updated copyright year and this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. Passes tier1 tests and the test itself on Linux x64 ------------- Commit messages: - Backport 07eaea8c25bae6ed852685f082f8b50c5b20c1a9 Changes: https://git.openjdk.org/jdk21u-dev/pull/913/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=913&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303920 Stats: 158 lines in 1 file changed: 52 ins; 38 del; 68 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/913.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/913/head:pull/913 PR: https://git.openjdk.org/jdk21u-dev/pull/913 From syan at openjdk.org Tue Aug 13 02:27:53 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 13 Aug 2024 02:27:53 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: <_BF_cG2qlx-tS3Lv3BQS9kmAp4jPc7hBfHMA8zdGYG8=.92336038-98ba-4673-a4d6-a3a21dce6e6d@github.com> On Tue, 16 Jul 2024 02:02:06 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. > > Thanks! The GHA test runner report `java/util/zip/ZipFile/ZipSourceCache.java` fail on windows-x64, the issue has been recorded by https://bugs.openjdk.org/browse/JDK-8322078, it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2285222013 From syan at openjdk.org Tue Aug 13 03:17:14 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 13 Aug 2024 03:17:14 GMT Subject: [jdk21u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java Message-ID: Hi all, This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. This the prefixed backport of JDK-8323196. Thanks! ------------- Commit messages: - Backport f3bb3e21704dd47c6c5d5753ca5882520a538c06 Changes: https://git.openjdk.org/jdk21u-dev/pull/915/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=915&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331153 Stats: 21 lines in 1 file changed: 15 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/915.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/915/head:pull/915 PR: https://git.openjdk.org/jdk21u-dev/pull/915 From syan at openjdk.org Tue Aug 13 03:24:27 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 13 Aug 2024 03:24:27 GMT Subject: [jdk17u-dev] RFR: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false" Message-ID: Hi all, This pull request contains a backport of commit [48702345](https://github.com/openjdk/jdk/commit/4870234552d2c63c786641493794a87654b98b7b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Erik Gahlin on 25 May 2023 and was reviewed by Markus Gr?nlund. This the one of the several prefixed backports of JDK-8323196. Thanks! ------------- Commit messages: - Backport 4870234552d2c63c786641493794a87654b98b7b Changes: https://git.openjdk.org/jdk17u-dev/pull/2796/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2796&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304375 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2796.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2796/head:pull/2796 PR: https://git.openjdk.org/jdk17u-dev/pull/2796 From gcao at openjdk.org Tue Aug 13 05:20:33 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 13 Aug 2024 05:20:33 GMT Subject: [jdk23u] RFR: 8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed Message-ID: <_KjDGBxYYwhtnDw5VMvHyxublzq0DrRzBU9wWsXVNa8=.3348b55b-37ae-4537-87b5-bc6cf07f529b@github.com> Hi, The same issue also exists in the jdk23u. I would like to backport [8337971](https://bugs.openjdk.org/browse/JDK-8337971) to jdk23u. With this backport, we can skip these tests on the linux-riscv64 platform. ------------- Commit messages: - Backport 16df9c33e9bbc9329ae60ba14332c09aadaba3f0 Changes: https://git.openjdk.org/jdk23u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=65&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337971 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/65/head:pull/65 PR: https://git.openjdk.org/jdk23u/pull/65 From andrewlu at openjdk.org Tue Aug 13 05:53:53 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 13 Aug 2024 05:53:53 GMT Subject: [jdk17u-dev] RFR: 8316973: GC: Make TestDisableDefaultGC use createTestJvm [v2] In-Reply-To: References: Message-ID: <_2z7Lqoid6bt4EmqKNDO0qDEMXMIAey2ZIlZs6nwyvU=.ac2c31ca-943b-4d74-9c65-c9209ef1daaa@github.com> > I backport this for parity with 17.0.13-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport_8316973 - Backport 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2791/files - new: https://git.openjdk.org/jdk17u-dev/pull/2791/files/cb224ec7..4fbc3eb5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2791&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2791&range=00-01 Stats: 1491 lines in 38 files changed: 1488 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2791.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2791/head:pull/2791 PR: https://git.openjdk.org/jdk17u-dev/pull/2791 From andrewlu at openjdk.org Tue Aug 13 05:54:02 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 13 Aug 2024 05:54:02 GMT Subject: [jdk11u-dev] RFR: 8316973: GC: Make TestDisableDefaultGC use createTestJvm [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.25-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport_8316973 - Backport 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2904/files - new: https://git.openjdk.org/jdk11u-dev/pull/2904/files/f6f041db..b479655c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2904&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2904&range=00-01 Stats: 617 lines in 7 files changed: 609 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2904.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2904/head:pull/2904 PR: https://git.openjdk.org/jdk11u-dev/pull/2904 From shade at openjdk.org Tue Aug 13 08:19:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 08:19:54 GMT Subject: [jdk21u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 21:14:16 GMT, Daniel Hu wrote: > Backport of improvements to DataDescriptorSignatureMissing test. Unclean for 2 minor reasons: updated copyright year and this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. > > Passes tier1 tests and the test itself on Linux x64 Good, except for: test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 3: > 1: /* > 2: * Copyright 2012 Google, Inc. All Rights Reserved. > 3: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. Yeah, but the original hunk has `2023`. Leave it as-as, i.e. at `2023`: https://github.com/openjdk/jdk/commit/07eaea8c25bae6ed852685f082f8b50c5b20c1a9#diff-20b351f8e90d650865fb32bf9208e9a8a0f77ad2deefd38dbbf062b0cc88fb5cR3 ------------- Changes requested by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/913#pullrequestreview-2234849095 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/913#discussion_r1714870119 From shade at openjdk.org Tue Aug 13 11:02:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 11:02:09 GMT Subject: [jdk23u] RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException Message-ID: Clean backport to fix potential `CME` in `ReferencedKeyMap`. Additional testing: - [x] MacOS AArch64 server fastdebug, `jdk/internal/util java/lang/invoke` ------------- Commit messages: - Backport bfb75b96266f4c5840e2edea13f9aa2c801518cf Changes: https://git.openjdk.org/jdk23u/pull/66/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=66&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336926 Stats: 11 lines in 1 file changed: 7 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/66.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/66/head:pull/66 PR: https://git.openjdk.org/jdk23u/pull/66 From shade at openjdk.org Tue Aug 13 11:11:20 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 11:11:20 GMT Subject: [jdk21u-dev] RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException Message-ID: Clean backport to fix potential `CME` in `ReferencedKeyMap`. Additional testing: - [x] MacOS AArch64 server fastdebug, `jdk/internal/util java/lang/invoke` ------------- Commit messages: - Backport bfb75b96266f4c5840e2edea13f9aa2c801518cf Changes: https://git.openjdk.org/jdk21u-dev/pull/916/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=916&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336926 Stats: 11 lines in 1 file changed: 7 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/916.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/916/head:pull/916 PR: https://git.openjdk.org/jdk21u-dev/pull/916 From shade at openjdk.org Tue Aug 13 13:24:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 13:24:46 GMT Subject: [jdk21u-dev] RFR: 8330981: ZGC: Should not dedup strings in the finalizer graph Message-ID: Clean backport to fix a ZGC corner case. Additional testing: - [ ] Linux x86_64 server fastdebug, `all` with `-XX:+UseZGC` - [ ] Linux x86_64 server fastdebug, `all` with `-XX:+UseZGC -XX:+ZGenerational` ------------- Commit messages: - Backport 2f2dc2289bce47d8071a86215218f345cce71dba Changes: https://git.openjdk.org/jdk21u-dev/pull/917/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=917&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330981 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/917.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/917/head:pull/917 PR: https://git.openjdk.org/jdk21u-dev/pull/917 From sgehwolf at openjdk.org Tue Aug 13 15:15:50 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Aug 2024 15:15:50 GMT Subject: [jdk21u-dev] RFR: 6942632: Hotspot should be able to use more than 64 logical processors on Windows In-Reply-To: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> References: <2coHSZZXFN7EQtSqhEuq3uM01sX9UqpOpvAMZBuowEw=.045fbe79-cd99-4b58-a756-895fc8ab0bf7@github.com> Message-ID: On Tue, 30 Jul 2024 19:05:36 GMT, Saint Wesonga wrote: > Clean backport of support for >64 logical processors on Windows (https://github.com/openjdk/jdk/pull/17576) to jdk21. @swesonga Please add an appropriate fix request comment to the bug when it's being asked for approval. Currently there is none. It should mention the testing you've done and the estimated risk (with a reason) for bringing this patch to 21u. Meanwhile I'll remove the approval label. Also, I don't see the CSR for 21-pool as approved (it's still in provisional). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/881#issuecomment-2286500761 From sgehwolf at openjdk.org Tue Aug 13 15:38:57 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Aug 2024 15:38:57 GMT Subject: [jdk21u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> References: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> Message-ID: On Fri, 9 Aug 2024 21:08:29 GMT, Daniel Hu wrote: > Backport of [JDK-8312049](https://bugs.openjdk.org/browse/JDK-8312049): improving ClassLoadUnloadTest. Original commit does not apply cleanly due to this [backport](https://bugs.openjdk.org/browse/JDK-8323123) that renames createJavaProcessBuilder to createLimitedTestJavaProcessBuilder. Additionally, the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. > > Passes tier1 tests on Linux x86 and MacOS aarch64, and most importantly, the test itself. @cost0much Please enable GHA on your fork, thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/909#issuecomment-2286552403 From duke at openjdk.org Tue Aug 13 15:39:01 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 15:39:01 GMT Subject: [jdk11u-dev] RFR: 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 09:36:22 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [461fb320](https://github.com/openjdk/jdk17u-dev/commit/461fb320bc67de9e8f378b8a845f67764cd003ed) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Adam Farley on 23 May 2022 and was reviewed by Andrew John Hughes. > > Thanks! @adamfarley Your change (at version e0c8b795173c3961085278d4030fa8e0618404e1) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2897#issuecomment-2286550501 From duke at openjdk.org Tue Aug 13 15:52:56 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 15:52:56 GMT Subject: [jdk21u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: <6vHBrvqmxMn-3QbGz00HdQVT8VXWEYJvcFhjEgNR5Fw=.03c7bb18-9e9b-4c6c-9a5b-00b5071d51f8@github.com> References: <6vHBrvqmxMn-3QbGz00HdQVT8VXWEYJvcFhjEgNR5Fw=.03c7bb18-9e9b-4c6c-9a5b-00b5071d51f8@github.com> Message-ID: <3dO7uaM1tHN4X6RUPVIMsOZI1qB0ZWZ7JZ7NBkkikB4=.9c013a32-d135-4be3-9b88-6df89cd83ef0@github.com> On Thu, 8 Aug 2024 12:43:18 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed @zzambers Your change (at version d9a1087d80ecbb25855d2fc334194efd75a0c405) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/901#issuecomment-2286580978 From duke at openjdk.org Tue Aug 13 15:57:02 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 15:57:02 GMT Subject: [jdk17u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 12:53:15 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed @zzambers Your change (at version ab446c2e4aa9f47ba0371c07457ed5c7032cc9df) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2787#issuecomment-2286585551 From zzambers at openjdk.org Tue Aug 13 15:57:02 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 13 Aug 2024 15:57:02 GMT Subject: [jdk17u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 12:53:15 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed Note: [backport to jdk21u](https://github.com/openjdk/jdk21u-dev/pull/901#issuecomment-2286580978) needs to be sponsored before this one ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2787#issuecomment-2286589683 From shade at openjdk.org Tue Aug 13 15:58:03 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 15:58:03 GMT Subject: [jdk17u-dev] Integrated: 8337283: configure.log is truncated when build dir is on different filesystem In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 18:02:34 GMT, Aleksey Shipilev wrote: > Keeps `configure.log` nice and complete. I have been running with this patch for more than a week in 17u-dev builds, and there were no problems. This pull request has now been integrated. Changeset: 4aa7950d Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/4aa7950d07bb012ced20a5a0cf9c670c64233fa8 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod 8337283: configure.log is truncated when build dir is on different filesystem Backport-of: 7e925d727f716e5c366b0d85b9c0de24efe43103 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2784 From shade at openjdk.org Tue Aug 13 15:58:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 15:58:54 GMT Subject: [jdk21u-dev] Integrated: 8337283: configure.log is truncated when build dir is on different filesystem In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 17:56:01 GMT, Aleksey Shipilev wrote: > Keeps `configure.log` nice and complete. I have been running with this patch for more than a week in 21u-dev builds, and there were no problems. This pull request has now been integrated. Changeset: bafcddd9 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/bafcddd90d91e64e223ca3fe3c2cd2433bc0e1c7 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod 8337283: configure.log is truncated when build dir is on different filesystem Backport-of: 7e925d727f716e5c366b0d85b9c0de24efe43103 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/895 From zzambers at openjdk.org Tue Aug 13 16:00:55 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 13 Aug 2024 16:00:55 GMT Subject: [jdk21u-dev] Integrated: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: <6vHBrvqmxMn-3QbGz00HdQVT8VXWEYJvcFhjEgNR5Fw=.03c7bb18-9e9b-4c6c-9a5b-00b5071d51f8@github.com> References: <6vHBrvqmxMn-3QbGz00HdQVT8VXWEYJvcFhjEgNR5Fw=.03c7bb18-9e9b-4c6c-9a5b-00b5071d51f8@github.com> Message-ID: <3bHyNpu1chzL0JL9YACgfV-FzVy5KL3g_zDTKO04ErM=.9c76e280-f7a2-4308-ade2-0d4682e40d4e@github.com> On Thu, 8 Aug 2024 12:43:18 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed This pull request has now been integrated. Changeset: 123614b8 Author: Zdenek Zambersky Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/123614b860cb575941dc52c57d124e55166b93f8 Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod 8336928: GHA: Bundle artifacts removal broken Backport-of: 98562166e4a4c8921709014423c6cbc993aa0d97 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/901 From shade at openjdk.org Tue Aug 13 16:00:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 16:00:54 GMT Subject: [jdk21u-dev] Integrated: 8336342: Fix known X11 library locations in sysroot In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 18:10:05 GMT, Aleksey Shipilev wrote: > Allows cleaner cross-builds without supplying `--x-libraries` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 21u-dev builds, and there were no problems. This pull request has now been integrated. Changeset: 9ac591a3 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/9ac591a3f4ee90967139894d5b20262d4323f38b Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8336342: Fix known X11 library locations in sysroot Backport-of: ee365d75cca6f33e5781fe514e557caba2b67c32 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/896 From afarley at openjdk.org Tue Aug 13 16:01:04 2024 From: afarley at openjdk.org (Adam Farley) Date: Tue, 13 Aug 2024 16:01:04 GMT Subject: [jdk11u-dev] Integrated: 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk In-Reply-To: References: Message-ID: <1e-1ejDjSp0wkUUhGrM5VGrr80zuVrsrssYFRrioGfQ=.6e75fdfa-0b4e-47c4-a501-7aae355a01a5@github.com> On Wed, 7 Aug 2024 09:36:22 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [461fb320](https://github.com/openjdk/jdk17u-dev/commit/461fb320bc67de9e8f378b8a845f67764cd003ed) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Adam Farley on 23 May 2022 and was reviewed by Andrew John Hughes. > > Thanks! This pull request has now been integrated. Changeset: f7217d75 Author: Adam Farley Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/f7217d7595da114f197ed8d9c78fbba453f875bb Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk Backport-of: 461fb320bc67de9e8f378b8a845f67764cd003ed ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2897 From shade at openjdk.org Tue Aug 13 16:01:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 16:01:55 GMT Subject: [jdk21u-dev] Integrated: 8336343: Add more known sysroot library locations for ALSA In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 18:10:55 GMT, Aleksey Shipilev wrote: > Allows cleaner cross-builds without supplying `--with-alsa` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 21u-dev builds, and there were no problems. This pull request has now been integrated. Changeset: 75c82f63 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/75c82f63d00b7a635b7824fd97cf74da61d8cd6c Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod 8336343: Add more known sysroot library locations for ALSA Backport-of: 9e6e0a8f341389215f0db6b2260f2b16351f02be ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/897 From zzambers at openjdk.org Tue Aug 13 16:06:53 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 13 Aug 2024 16:06:53 GMT Subject: [jdk17u-dev] Integrated: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 12:53:15 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed This pull request has now been integrated. Changeset: 2e9152dc Author: Zdenek Zambersky Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/2e9152dc268ee946680f274c9e6006edfb8d0398 Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod 8336928: GHA: Bundle artifacts removal broken Backport-of: 98562166e4a4c8921709014423c6cbc993aa0d97 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2787 From duke at openjdk.org Tue Aug 13 16:06:12 2024 From: duke at openjdk.org (Daniel Hu) Date: Tue, 13 Aug 2024 16:06:12 GMT Subject: [jdk21u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 08:16:22 GMT, Aleksey Shipilev wrote: >> Daniel Hu has updated the pull request incrementally with one additional commit since the last revision: >> >> reverted copyright year to original > > test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 3: > >> 1: /* >> 2: * Copyright 2012 Google, Inc. All Rights Reserved. >> 3: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. > > Yeah, but the original hunk has `2023`. Leave it as-as, i.e. at `2023`: > https://github.com/openjdk/jdk/commit/07eaea8c25bae6ed852685f082f8b50c5b20c1a9#diff-20b351f8e90d650865fb32bf9208e9a8a0f77ad2deefd38dbbf062b0cc88fb5cR3 fixed! ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/913#discussion_r1715555815 From duke at openjdk.org Tue Aug 13 16:06:12 2024 From: duke at openjdk.org (Daniel Hu) Date: Tue, 13 Aug 2024 16:06:12 GMT Subject: [jdk21u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2] In-Reply-To: References: Message-ID: > Backport of improvements to DataDescriptorSignatureMissing test. Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. > > Passes tier1 tests and the test itself on Linux x64 Daniel Hu has updated the pull request incrementally with one additional commit since the last revision: reverted copyright year to original ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/913/files - new: https://git.openjdk.org/jdk21u-dev/pull/913/files/50688ba4..0d4c3d20 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=913&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=913&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/913.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/913/head:pull/913 PR: https://git.openjdk.org/jdk21u-dev/pull/913 From shade at openjdk.org Tue Aug 13 16:13:49 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 16:13:49 GMT Subject: [jdk21u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 16:06:12 GMT, Daniel Hu wrote: >> Backport of improvements to DataDescriptorSignatureMissing test. Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. >> >> Passes tier1 tests and the test itself on Linux x64 > > Daniel Hu has updated the pull request incrementally with one additional commit since the last revision: > > reverted copyright year to original Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/913#pullrequestreview-2235999619 From shade at openjdk.org Tue Aug 13 16:14:52 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 16:14:52 GMT Subject: [jdk21u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: References: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> Message-ID: On Tue, 13 Aug 2024 15:36:41 GMT, Severin Gehwolf wrote: > @cost0much Please enable GHA on your fork, thanks! +1. It would be good to make sure GHA are passing before we integrate. You can trigger the GHA workflow on your branch from https://github.com/cost0much/jdk21u-dev/actions, without pushing anything to PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/909#issuecomment-2286625538 From sgehwolf at openjdk.org Tue Aug 13 16:24:59 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Aug 2024 16:24:59 GMT Subject: [jdk21u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:05:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. > > This the prefixed backport of JDK-8323196. > > Thanks! @sendaoYan Please provide some rationale why this debugging in a test is needed. Do you actually see test failures? Why are you backporting this? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/915#issuecomment-2286643881 From xpeng at openjdk.org Tue Aug 13 17:22:27 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 13 Aug 2024 17:22:27 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM Message-ID: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Hi, This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17. Best, Xiaolong. Additional tests: - [x] hotspot_gc_shenandoah - [ ] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC ------------- Commit messages: - Replace nullptr with NULL - Backport 492e8bf563135d27b46fde198880e62d5f1940e8 Changes: https://git.openjdk.org/jdk17u-dev/pull/2797/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2797&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325587 Stats: 67 lines in 3 files changed: 48 ins; 1 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2797.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2797/head:pull/2797 PR: https://git.openjdk.org/jdk17u-dev/pull/2797 From cushon at openjdk.org Tue Aug 13 17:26:24 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 13 Aug 2024 17:26:24 GMT Subject: [jdk23u] RFR: 8337795: Type annotation attached to incorrect type during class reading Message-ID: This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377. ------------- Commit messages: - Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 Changes: https://git.openjdk.org/jdk23u/pull/67/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=67&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337795 Stats: 109 lines in 2 files changed: 25 ins; 44 del; 40 mod Patch: https://git.openjdk.org/jdk23u/pull/67.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/67/head:pull/67 PR: https://git.openjdk.org/jdk23u/pull/67 From phh at openjdk.org Tue Aug 13 17:31:48 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 13 Aug 2024 17:31:48 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Tue, 13 Aug 2024 16:54:05 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. > It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. > This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17. > > Best, > Xiaolong. > > > Additional tests: > - [x] hotspot_gc_shenandoah > - [ ] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC Outline the backport series you're proposing? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#issuecomment-2286761959 From xpeng at openjdk.org Tue Aug 13 17:36:58 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Tue, 13 Aug 2024 17:36:58 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Tue, 13 Aug 2024 17:28:08 GMT, Paul Hohensee wrote: > Outline the backport series you're proposing? Thanks Paul, I have provided the list of bugs I'm going to backport. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#issuecomment-2286774967 From cushon at openjdk.org Tue Aug 13 17:39:05 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 13 Aug 2024 17:39:05 GMT Subject: [jdk23u] RFR: 8337998: CompletionFailure in getEnclosingType attaching type annotations Message-ID: <9kCInkTP1JZYG7gKqoB7pkXmYjChxNti9BMrusphX4Q=.d1c53caa-cc75-4dde-b85b-95425a61f95c@github.com> This change fixes a javac crash when classes are missing from the classpath. The fix causes javac to instead report a non-crash error diagnostic. The change improves logic first added in JDK 22 as part of the fix for JDK-8225377. ------------- Commit messages: - Backport 9e282e5c966a9c065de8b901b7d30bb5c9ccf243 Changes: https://git.openjdk.org/jdk23u/pull/68/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=68&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337998 Stats: 116 lines in 4 files changed: 113 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/68.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/68/head:pull/68 PR: https://git.openjdk.org/jdk23u/pull/68 From shade at openjdk.org Tue Aug 13 18:07:57 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 18:07:57 GMT Subject: [jdk21u-dev] Integrated: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields In-Reply-To: <3ZOtJXSLMAjBPdNyxhPA-v0Kg2_ptnGPB30oHh3Up2s=.800a9c60-03c0-491b-987e-0b2378fecb85@github.com> References: <3ZOtJXSLMAjBPdNyxhPA-v0Kg2_ptnGPB30oHh3Up2s=.800a9c60-03c0-491b-987e-0b2378fecb85@github.com> Message-ID: On Mon, 12 Aug 2024 10:36:15 GMT, Aleksey Shipilev wrote: > Improves IR Framework, allows backporting IR Tests without modifications. Applies nearly cleanly, except the hunk in `compiler/c2/irTests/TestTestRemovalPeephole.java`, since this file does not exist in JDK 21. > > Additional testing: > - [x] Grep `@Arguments` yields no unfixed cases in test suite > - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` > - [x] Linux AArch64 server release, `testlibrary_tests/ir_framework compiler/c2/irTests` > - [x] Linux AArch64 server fastdebug, `testlibrary_tests/ir_framework compiler/c2/irTests` This pull request has now been integrated. Changeset: d4a6e72a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/d4a6e72a22cf8cee91dc9553454dd62fe0547b85 Stats: 1156 lines in 27 files changed: 899 ins; 52 del; 205 mod 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields Reviewed-by: phh Backport-of: 8d9ad97c293b090fbcedbfdb046f1b5d97b02f87 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/911 From shade at openjdk.org Tue Aug 13 18:18:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Aug 2024 18:18:22 GMT Subject: [jdk23u] RFR: 8337876: [IR Framework] Add support for IR tests with @Stable [v2] In-Reply-To: References: Message-ID: > Clean backport to improve IR Framework for upcoming tests. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `testlibrary_tests/ir_framework` passes Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Backport 0e7c1c1afeaba1c125b70cabe7b1b7a3193ee5c3 ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/62/files - new: https://git.openjdk.org/jdk23u/pull/62/files/4abef48d..7ef846f3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=62&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=62&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/62/head:pull/62 PR: https://git.openjdk.org/jdk23u/pull/62 From abakhtin at openjdk.org Tue Aug 13 20:06:04 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 13 Aug 2024 20:06:04 GMT Subject: [jdk17u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 Message-ID: The backport is almost clean. - manual update of the copyright year for Stream.java - manual merge of one-line change in the Http2TestServer.java file. Caused by difference in JDK-8295944 implementation for JDK17 and JDK21 All java/net/httpclient JTREG tests passed ------------- Commit messages: - Backport f4b140b4200fc0f49161395501d3dbcba7a79059 Changes: https://git.openjdk.org/jdk17u-dev/pull/2798/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2798&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296410 Stats: 431 lines in 5 files changed: 389 ins; 14 del; 28 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2798.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2798/head:pull/2798 PR: https://git.openjdk.org/jdk17u-dev/pull/2798 From duke at openjdk.org Tue Aug 13 20:20:19 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Tue, 13 Aug 2024 20:20:19 GMT Subject: [jdk21u-dev] RFR: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 [v2] In-Reply-To: References: Message-ID: > This is a clean backport of https://github.com/openjdk/jdk/commit/64c3642c57719940855b220025b33758950b3980 originally authored by @vpa1977 and reviewed by @jonathan-gibbons > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `make test TEST=test/langtools/jdk/javadoc` Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into jdoc-crash for testing - Backport 64c3642c57719940855b220025b33758950b3980 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/856/files - new: https://git.openjdk.org/jdk21u-dev/pull/856/files/fed8bbdb..f4b7f310 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=856&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=856&range=00-01 Stats: 5796 lines in 130 files changed: 2630 ins; 1925 del; 1241 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/856.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/856/head:pull/856 PR: https://git.openjdk.org/jdk21u-dev/pull/856 From duke at openjdk.org Tue Aug 13 20:24:21 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Tue, 13 Aug 2024 20:24:21 GMT Subject: [jdk21u-dev] RFR: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable [v2] In-Reply-To: References: Message-ID: > This is a clean backport of https://github.com/openjdk/jdk/commit/36ac83904c9e81a01822b0e36ef677cae2808709 originally authored by @bplb and reviewed by @AlanBateman > > It also includes this follow-up fix: > * [JDK-8317128](https://bugs.openjdk.org/browse/JDK-8317128): **java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException** > * https://github.com/openjdk/jdk/pull/15991 > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST="tier1 tier2 tier3"` Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into filedelete for testing - Clean JDK-8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException 6c6beba2569a2f9f3fd5d6988360ffd8680de821 - Backport 36ac83904c9e81a01822b0e36ef677cae2808709 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/863/files - new: https://git.openjdk.org/jdk21u-dev/pull/863/files/a650c6ef..a3bb19e5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=863&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=863&range=00-01 Stats: 5796 lines in 130 files changed: 2630 ins; 1925 del; 1241 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/863/head:pull/863 PR: https://git.openjdk.org/jdk21u-dev/pull/863 From duke at openjdk.org Tue Aug 13 20:24:36 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Tue, 13 Aug 2024 20:24:36 GMT Subject: [jdk21u-dev] RFR: 8319817: Charset constructor should make defensive copy of aliases [v2] In-Reply-To: References: Message-ID: > Clean backport. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` > * These tests fail repeatedly, but also fail on `master`: > * `build/AbsPathsInImage.java` > * `java/nio/channels/FileChannel/directio/DirectIOTest.java` Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into charset-ctor for testing - Backport d6d7bdc7748c10963c3e58c0287b2472646bf36f ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/841/files - new: https://git.openjdk.org/jdk21u-dev/pull/841/files/5a733371..92503f50 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=841&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=841&range=00-01 Stats: 6051 lines in 152 files changed: 2806 ins; 1929 del; 1316 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/841.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/841/head:pull/841 PR: https://git.openjdk.org/jdk21u-dev/pull/841 From duke at openjdk.org Tue Aug 13 20:36:09 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Tue, 13 Aug 2024 20:36:09 GMT Subject: [jdk17u-dev] RFR: 8319817: Charset constructor should make defensive copy of aliases [v2] In-Reply-To: <6cD_If-pKlvZDkDjOVIZciiV3ew1B8FY2SjVGDlwBzE=.c5966432-fe63-4b53-82d2-6452808331e6@github.com> References: <6cD_If-pKlvZDkDjOVIZciiV3ew1B8FY2SjVGDlwBzE=.c5966432-fe63-4b53-82d2-6452808331e6@github.com> Message-ID: > Clean backport. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] macosx-aarch64-server-release: `make test-tier1` > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` > * These tests fail repeatedly, but also fail on `master`: > * `build/AbsPathsInImage.java` > * `jdk/internal/platform/docker/TestDockerMemoryMetrics.java` Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into charset-ctor for testing - Backport d6d7bdc7748c10963c3e58c0287b2472646bf36f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2713/files - new: https://git.openjdk.org/jdk17u-dev/pull/2713/files/9afe9b6b..99dbada0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2713&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2713&range=00-01 Stats: 8853 lines in 216 files changed: 6995 ins; 1053 del; 805 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2713.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2713/head:pull/2713 PR: https://git.openjdk.org/jdk17u-dev/pull/2713 From duke at openjdk.org Tue Aug 13 20:38:03 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Tue, 13 Aug 2024 20:38:03 GMT Subject: [jdk17u-dev] RFR: 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer [v2] In-Reply-To: References: Message-ID: > Backports a fix for a potential data-loss defect from JDK19 to JDK17. > > This change is not clean, but the conflict is minimal and localized to `StreamDecoder.java`. > > Viewing this diff alongside the original fix [here](https://github.com/openjdk/jdk/commit/6520843f86f638fe4d1e5b3358fab5799daca654?diff=unified&w=0#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eR184-R227) and expanding context upward a bit should be illuminating. The conflict is due to structural/indentation difference when the lock acquisition at L158 was hoisted into a separate method. That happened [here](https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84?diff=unified&w=1#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eL154-L190) (wherein this file has an ugly diff obscuring relatively simple changes). > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test` (tier1-3) Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into inputstreamreader for testing - Backport 6520843f86f638fe4d1e5b3358fab5799daca654 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2726/files - new: https://git.openjdk.org/jdk17u-dev/pull/2726/files/b8bfb9cf..cbc13988 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2726&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2726&range=00-01 Stats: 7641 lines in 180 files changed: 5963 ins; 1006 del; 672 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2726.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2726/head:pull/2726 PR: https://git.openjdk.org/jdk17u-dev/pull/2726 From abakhtin at openjdk.org Tue Aug 13 22:29:08 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 13 Aug 2024 22:29:08 GMT Subject: [jdk17u-dev] RFR: 8307648: java/net/httpclient/ExpectContinueTest.java timed out Message-ID: <7b2Q9_wuaiyAuPzTbGcsHBJFBeZdM0fK1cq6zjJpjgQ=.04ca936f-2ef2-485b-bc00-ac48829ab2d6@github.com> The backport is not clean. JDK17 does not have JDK-8293786. As a result, the debug log is not merged into Stream::incoming_reset method. These changes could be skipped because they are not required for this functionality Also, ExpectContinueTest test was added in JDK21 as part of JDK-8286171. Not backported to JDK17. The changes for this test are skipped All java/net/httpclient JTREG tests passed ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/2798 Commit messages: - Backport 04b0e785f6b9b4629b77bb19f2b072434be4951c Changes: https://git.openjdk.org/jdk17u-dev/pull/2799/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2799&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307648 Stats: 24 lines in 2 files changed: 19 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2799.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2799/head:pull/2799 PR: https://git.openjdk.org/jdk17u-dev/pull/2799 From duke at openjdk.org Tue Aug 13 22:37:53 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 22:37:53 GMT Subject: [jdk21u-dev] RFR: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:20:19 GMT, Todd V. Jonker wrote: >> This is a clean backport of https://github.com/openjdk/jdk/commit/64c3642c57719940855b220025b33758950b3980 originally authored by @vpa1977 and reviewed by @jonathan-gibbons >> >> Additional testing: >> - [x] New regression test fails without the fix, passes with it >> - [x] linux-x86_64-server-release: `make test TEST=test/langtools/jdk/javadoc` > > Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into jdoc-crash for testing > - Backport 64c3642c57719940855b220025b33758950b3980 @openjdk[bot] Your change (at version f4b7f31091debc23fdfb8fd0b7679b3d42d9c1fa) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/856#issuecomment-2287279189 From duke at openjdk.org Tue Aug 13 22:38:49 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 22:38:49 GMT Subject: [jdk21u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> References: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> Message-ID: On Fri, 9 Aug 2024 21:08:29 GMT, Daniel Hu wrote: > Backport of [JDK-8312049](https://bugs.openjdk.org/browse/JDK-8312049): improving ClassLoadUnloadTest. Original commit does not apply cleanly due to this [backport](https://bugs.openjdk.org/browse/JDK-8323123) that renames createJavaProcessBuilder to createLimitedTestJavaProcessBuilder. Additionally, the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. > > Passes tier1 tests on Linux x86 and MacOS aarch64, and most importantly, the test itself. @openjdk[bot] Your change (at version a7dd41731f192d951f46d0cdf9d93d47c846b546) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/909#issuecomment-2287281561 From duke at openjdk.org Tue Aug 13 22:47:00 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 22:47:00 GMT Subject: [jdk21u-dev] RFR: 8319817: Charset constructor should make defensive copy of aliases [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:24:36 GMT, Todd V. Jonker wrote: >> Clean backport. >> >> Additional testing: >> - [x] New regression test fails without the fix, passes with it >> - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` >> * These tests fail repeatedly, but also fail on `master`: >> * `build/AbsPathsInImage.java` >> * `java/nio/channels/FileChannel/directio/DirectIOTest.java` > > Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into charset-ctor for testing > - Backport d6d7bdc7748c10963c3e58c0287b2472646bf36f @toddjonker Your change (at version 92503f500e2c3a4d09f91aa07fc9d9d0af45f337) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/841#issuecomment-2287296504 From duke at openjdk.org Tue Aug 13 22:48:50 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Tue, 13 Aug 2024 22:48:50 GMT Subject: [jdk21u-dev] Integrated: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 In-Reply-To: References: Message-ID: On Fri, 19 Jul 2024 22:48:04 GMT, Todd V. Jonker wrote: > This is a clean backport of https://github.com/openjdk/jdk/commit/64c3642c57719940855b220025b33758950b3980 originally authored by @vpa1977 and reviewed by @jonathan-gibbons > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `make test TEST=test/langtools/jdk/javadoc` This pull request has now been integrated. Changeset: 8150179c Author: Todd V. Jonker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/8150179c6592d3f33970a34dd11fc5d001530fb2 Stats: 61 lines in 2 files changed: 56 ins; 0 del; 5 mod 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 Backport-of: 64c3642c57719940855b220025b33758950b3980 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/856 From duke at openjdk.org Tue Aug 13 22:54:56 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 22:54:56 GMT Subject: [jdk21u-dev] RFR: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:24:21 GMT, Todd V. Jonker wrote: >> This is a clean backport of https://github.com/openjdk/jdk/commit/36ac83904c9e81a01822b0e36ef677cae2808709 originally authored by @bplb and reviewed by @AlanBateman >> >> It also includes this follow-up fix: >> * [JDK-8317128](https://bugs.openjdk.org/browse/JDK-8317128): **java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException** >> * https://github.com/openjdk/jdk/pull/15991 >> >> Additional testing: >> - [x] New regression test fails without the fix, passes with it >> - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST="tier1 tier2 tier3"` > > Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into filedelete for testing > - Clean JDK-8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException > > 6c6beba2569a2f9f3fd5d6988360ffd8680de821 > - Backport 36ac83904c9e81a01822b0e36ef677cae2808709 @toddjonker Your change (at version a3bb19e58bb6ba7ef755ec86db21e903b594915a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/863#issuecomment-2287316520 From duke at openjdk.org Wed Aug 14 00:12:49 2024 From: duke at openjdk.org (Daniel Hu) Date: Wed, 14 Aug 2024 00:12:49 GMT Subject: [jdk21u-dev] Integrated: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> References: <_na11MTJHfGGq51EGtz-9k326lYcvGt7cpkKDbylC2o=.0e6b4542-c5f7-47c8-a1b6-8e53762a8fde@github.com> Message-ID: On Fri, 9 Aug 2024 21:08:29 GMT, Daniel Hu wrote: > Backport of [JDK-8312049](https://bugs.openjdk.org/browse/JDK-8312049): improving ClassLoadUnloadTest. Original commit does not apply cleanly due to this [backport](https://bugs.openjdk.org/browse/JDK-8323123) that renames createJavaProcessBuilder to createLimitedTestJavaProcessBuilder. Additionally, the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. > > Passes tier1 tests on Linux x86 and MacOS aarch64, and most importantly, the test itself. This pull request has now been integrated. Changeset: 7e7b0f38 Author: Daniel Hu Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/7e7b0f38b64976d0d44fd823a45b2d1217cd4b36 Stats: 35 lines in 1 file changed: 2 ins; 7 del; 26 mod 8312049: runtime/logging/ClassLoadUnloadTest can be improved Reviewed-by: phh Backport-of: 4676b40f17dd18941f5883cb9b989ad639992a50 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/909 From syan at openjdk.org Wed Aug 14 01:31:54 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 01:31:54 GMT Subject: [jdk21u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 16:22:03 GMT, Severin Gehwolf wrote: > @sendaoYan Please provide some rationale why this debugging in a test is needed. Do you actually see test failures? Why are you backporting this? Hi, we have observed this test intermittent failure, which seems similar to [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). So we want to backport [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196), and this PR is the prefixed backport of [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/915#issuecomment-2287659616 From syan at openjdk.org Wed Aug 14 01:42:38 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 01:42:38 GMT Subject: [jdk23u] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Message-ID: Hi all, This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. Thanks! ------------- Commit messages: - Backport f132b347e13a57d9654f0ab11db0636999576036 Changes: https://git.openjdk.org/jdk23u/pull/69/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=69&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336854 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/69.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/69/head:pull/69 PR: https://git.openjdk.org/jdk23u/pull/69 From andrewlu at openjdk.org Wed Aug 14 01:58:04 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 01:58:04 GMT Subject: [jdk21u-dev] Integrated: 8315965: Open source various AWT applet tests In-Reply-To: <-QOEOOxuTYtZgPtkexBGSSBIOgoXEUdzk9JPh_SQuA8=.30bf9b5c-fcce-40e5-b45b-c6b55d81e3de@github.com> References: <-QOEOOxuTYtZgPtkexBGSSBIOgoXEUdzk9JPh_SQuA8=.30bf9b5c-fcce-40e5-b45b-c6b55d81e3de@github.com> Message-ID: On Fri, 9 Aug 2024 08:53:02 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 785ae1f0 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/785ae1f0d47403b2618c2e093fd77678d8e8dda3 Stats: 546 lines in 4 files changed: 546 ins; 0 del; 0 mod 8315965: Open source various AWT applet tests Backport-of: 3b397c8552d7fd1b1084fbbc06384f3f34481ba4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/908 From andrewlu at openjdk.org Wed Aug 14 01:58:54 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 01:58:54 GMT Subject: [jdk17u-dev] Integrated: 8332113: Update nsk.share.Log to be always verbose In-Reply-To: <11W4Z6t9412jJtfIRtu0bCECEjtUhE73IcNV0MxOSfA=.ddc98f08-2951-49b8-a2b6-b7dc58febf55@github.com> References: <11W4Z6t9412jJtfIRtu0bCECEjtUhE73IcNV0MxOSfA=.ddc98f08-2951-49b8-a2b6-b7dc58febf55@github.com> Message-ID: On Thu, 1 Aug 2024 02:29:08 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 0b789c17 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/0b789c177293f0dc1c0d710c3ce001e07765a717 Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod 8332113: Update nsk.share.Log to be always verbose Backport-of: 8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2759 From andrewlu at openjdk.org Wed Aug 14 01:59:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 01:59:01 GMT Subject: [jdk11u-dev] Integrated: 8315965: Open source various AWT applet tests In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 08:53:22 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: 3c43b2f6 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/3c43b2f623774c5e6b115632de017ffaa765981c Stats: 546 lines in 4 files changed: 546 ins; 0 del; 0 mod 8315965: Open source various AWT applet tests Backport-of: 3b397c8552d7fd1b1084fbbc06384f3f34481ba4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2906 From andrewlu at openjdk.org Wed Aug 14 01:59:49 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 01:59:49 GMT Subject: [jdk21u-dev] Integrated: 8332113: Update nsk.share.Log to be always verbose In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:28:59 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 6196ed1d Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/6196ed1d06cb32496cc39462745fd9634e68c0ff Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod 8332113: Update nsk.share.Log to be always verbose Backport-of: 8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/887 From andrewlu at openjdk.org Wed Aug 14 02:00:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 02:00:03 GMT Subject: [jdk17u-dev] Integrated: 8315965: Open source various AWT applet tests In-Reply-To: References: Message-ID: <11CmR5sfPCFxd8tmmbHfhDZwbIARcQ8ix0I2lBy_oww=.87d47cb9-3e38-4afe-ae2f-efd25c22b8df@github.com> On Fri, 9 Aug 2024 08:53:11 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 971b01ae Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/971b01ae8b59449db1467f0b08647e679ea21187 Stats: 546 lines in 4 files changed: 546 ins; 0 del; 0 mod 8315965: Open source various AWT applet tests Backport-of: 3b397c8552d7fd1b1084fbbc06384f3f34481ba4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2793 From andrewlu at openjdk.org Wed Aug 14 02:00:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 02:00:11 GMT Subject: [jdk11u-dev] Integrated: 8332113: Update nsk.share.Log to be always verbose In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:29:19 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: 3f2d6f03 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/3f2d6f0378ca44207cbdf3f86a1bfe6ac8982b03 Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod 8332113: Update nsk.share.Log to be always verbose Backport-of: 8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2890 From serb at openjdk.org Wed Aug 14 06:19:56 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 14 Aug 2024 06:19:56 GMT Subject: [jdk21u-dev] Integrated: 6355567: AdobeMarkerSegment causes failure to read valid JPEG In-Reply-To: <57cH2emDQ965zvl4hqSy67m4z4LY-7B0fhDouC5u6Jo=.6639c626-0a5b-44a9-bfaf-7e1bc5809f17@github.com> References: <57cH2emDQ965zvl4hqSy67m4z4LY-7B0fhDouC5u6Jo=.6639c626-0a5b-44a9-bfaf-7e1bc5809f17@github.com> Message-ID: On Mon, 1 Jul 2024 07:06:53 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [c7c6d47a](https://github.com/openjdk/jdk/commit/c7c6d47a07100f6c81af6cfad301ec1bda77adf7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Liam Miller-Cushon on 13 Jul 2023 and was reviewed by Phil Race and Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 5acb0228 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/5acb02287b474a3393d4a371d6da55dba3b2ad2b Stats: 69 lines in 3 files changed: 61 ins; 0 del; 8 mod 6355567: AdobeMarkerSegment causes failure to read valid JPEG Backport-of: c7c6d47a07100f6c81af6cfad301ec1bda77adf7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/806 From mbaesken at openjdk.org Wed Aug 14 07:06:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 07:06:56 GMT Subject: [jdk21u-dev] RFR: 8334166: Enable binary check [v2] In-Reply-To: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> References: <-oICmPqbwvN_rizC-5XoEkHZj-2RvNxaMKpOae8c2yg=.673ddcda-df62-49af-94fd-0beefc78526a@github.com> Message-ID: <5PjyuEcrOLaxXQmC3tHr17I-IYPNsJ97NElqNnoIaQU=.402d7d3a-0725-423b-ab79-fc31a290c7a9@github.com> On Fri, 9 Aug 2024 13:55:05 GMT, Matthias Baesken wrote: >> Backport of 8334166; previous warning setting missing so not clean > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > add issuestitle from 8334166 Thanks for the reviews ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/906#issuecomment-2288002047 From mbaesken at openjdk.org Wed Aug 14 07:06:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 07:06:57 GMT Subject: [jdk21u-dev] Integrated: 8334166: Enable binary check In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 07:14:43 GMT, Matthias Baesken wrote: > Backport of 8334166; previous warning setting missing so not clean This pull request has now been integrated. Changeset: 108c2e49 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/108c2e4986bfae9f6993ad03d926298b267cf523 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8334166: Enable binary check 8332008: Enable issuestitle check Reviewed-by: sgehwolf, shade Backport-of: a4582a8957d604b50249e1f59679393966456a14 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/906 From mbaesken at openjdk.org Wed Aug 14 07:21:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 07:21:23 GMT Subject: [jdk17u-dev] RFR: 8334166: Enable binary check Message-ID: 8334166: Enable binary check ------------- Commit messages: - Backport 108c2e4986bfae9f6993ad03d926298b267cf523 Changes: https://git.openjdk.org/jdk17u-dev/pull/2800/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2800&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334166 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2800.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2800/head:pull/2800 PR: https://git.openjdk.org/jdk17u-dev/pull/2800 From mbaesken at openjdk.org Wed Aug 14 08:17:16 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 08:17:16 GMT Subject: [jdk11u-dev] RFR: 8334166: Enable binary check Message-ID: 8334166: Enable binary check ------------- Commit messages: - Backport 108c2e4986bfae9f6993ad03d926298b267cf523 Changes: https://git.openjdk.org/jdk11u-dev/pull/2907/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2907&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334166 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2907.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2907/head:pull/2907 PR: https://git.openjdk.org/jdk11u-dev/pull/2907 From mbaesken at openjdk.org Wed Aug 14 08:29:54 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 08:29:54 GMT Subject: [jdk17u-dev] RFR: 8334166: Enable binary check In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 07:15:39 GMT, Matthias Baesken wrote: > 8334166: Enable binary check macOS: infrastructure issue "curl: (28) Operation too slow. Less than 100 bytes/sec transferred the last 5 seconds" ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2800#issuecomment-2288148632 From andrewlu at openjdk.org Wed Aug 14 09:12:53 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 09:12:53 GMT Subject: [jdk17u-dev] Integrated: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:29:47 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: c09ca4e9 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/c09ca4e9e23211c6ad42877a0bb7cf527b82bde4 Stats: 286 lines in 2 files changed: 48 ins; 211 del; 27 mod 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main Backport-of: ab183e437c18b445e9c022a4d74de818d4ccecbe ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2761 From sgehwolf at openjdk.org Wed Aug 14 09:12:57 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 14 Aug 2024 09:12:57 GMT Subject: [jdk21u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: <1dpZLRVTPfz8FPFg3nWikbneisusN5jdybq6gDwWBqc=.05971171-040a-4ec3-a0c6-64a88b841636@github.com> On Wed, 14 Aug 2024 01:29:05 GMT, SendaoYan wrote: > > @sendaoYan Please provide some rationale why this debugging in a test is needed. Do you actually see test failures? Why are you backporting this? > > Hi, we have observed this test intermittent failure, which seems similar to [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). So we want to backport [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196), and this PR is the prefixed backport of [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). OK. Next time, please mention this in the fix request comment from the get go. It's useful info when looking for approval. Now, please re-issue the `/approval` command with the updated comment and I'll approve. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/915#issuecomment-2288247591 From andrewlu at openjdk.org Wed Aug 14 09:13:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 09:13:05 GMT Subject: [jdk11u-dev] Integrated: 7156347: javax/swing/JList/6462008/bug6462008.java fails In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 08:14:58 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: 30f532b4 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/30f532b4b175c4ba50a71b38bd6a2b244cac12fc Stats: 3 lines in 2 files changed: 2 ins; 1 del; 0 mod 7156347: javax/swing/JList/6462008/bug6462008.java fails Backport-of: a5b7bc50d450e083a09c16c73f9097650142fe35 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2900 From andrewlu at openjdk.org Wed Aug 14 09:13:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 09:13:05 GMT Subject: [jdk17u-dev] Integrated: 8316285: Opensource JButton manual tests In-Reply-To: <2po_rc_6p2T6RIrC0ywa3JZofj4E-3FbdYovsKPQYpA=.5133ad95-fa89-4a59-a564-e516b2bb197c@github.com> References: <2po_rc_6p2T6RIrC0ywa3JZofj4E-3FbdYovsKPQYpA=.5133ad95-fa89-4a59-a564-e516b2bb197c@github.com> Message-ID: On Fri, 9 Aug 2024 08:51:40 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 7f78f216 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/7f78f216d9877184a6eeda1171d420afe7aab679 Stats: 292 lines in 3 files changed: 292 ins; 0 del; 0 mod 8316285: Opensource JButton manual tests Backport-of: 9f5d2b947f7d70babba663e16882e480b8a973f2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2792 From andrewlu at openjdk.org Wed Aug 14 09:13:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 09:13:09 GMT Subject: [jdk11u-dev] Integrated: 8316285: Opensource JButton manual tests In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 08:51:50 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: fa64c0e3 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/fa64c0e345e1fc0591b05a60eb04204fa1ca84d7 Stats: 292 lines in 3 files changed: 292 ins; 0 del; 0 mod 8316285: Opensource JButton manual tests Backport-of: 9f5d2b947f7d70babba663e16882e480b8a973f2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2905 From andrewlu at openjdk.org Wed Aug 14 09:13:59 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 09:13:59 GMT Subject: [jdk17u-dev] Integrated: 8316973: GC: Make TestDisableDefaultGC use createTestJvm In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 08:50:53 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 03300692 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/03300692ec6c5e73987e00f34c34ac3fbe7c396a Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod 8316973: GC: Make TestDisableDefaultGC use createTestJvm Backport-of: 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2791 From andrewlu at openjdk.org Wed Aug 14 09:17:52 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 09:17:52 GMT Subject: [jdk11u-dev] Integrated: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error In-Reply-To: <2mEwwS-rJQpsqHfuiVPbZk2RcnNLs31-xidGqac7sRA=.fb2c4379-940f-41cc-8cc0-c60de9464efd@github.com> References: <2mEwwS-rJQpsqHfuiVPbZk2RcnNLs31-xidGqac7sRA=.fb2c4379-940f-41cc-8cc0-c60de9464efd@github.com> Message-ID: On Fri, 9 Aug 2024 08:25:24 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. This pull request has now been integrated. Changeset: d8632eda Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/d8632eda29e8b6d4e0939e32dafdb07ab61cccec Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error Backport-of: 8785737ba5f398888816ddd0f50adeea6a75bb0f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2902 From mbaesken at openjdk.org Wed Aug 14 09:57:51 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 09:57:51 GMT Subject: [jdk11u-dev] RFR: 8316973: GC: Make TestDisableDefaultGC use createTestJvm [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 05:54:02 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.25-oracle. >> jdk11 use '-XX:-UseZGC', not '-XX:-UseShenandoahGC', so not clean. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport_8316973 > - Backport 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c Marked as reviewed by mbaesken (Reviewer). macOS GHAs currently broken/in bad shape ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2904#pullrequestreview-2237696791 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2904#issuecomment-2288334635 From mbaesken at openjdk.org Wed Aug 14 10:03:52 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 10:03:52 GMT Subject: [jdk11u-dev] RFR: 8328300: Convert PrintDialogsTest.java from Applet to main program [v2] In-Reply-To: References: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> Message-ID: On Thu, 1 Aug 2024 06:28:48 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.25-oracle. >> text block modified as not supported. > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > Backport dea94f4445b9389339cf7ca0eef688ca56c17814 Seems the test is marked manual , did you run it manually , does it work ? `@run main/manual PrintDialogsTest` ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2892#issuecomment-2288345062 From mbaesken at openjdk.org Wed Aug 14 10:11:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 10:11:50 GMT Subject: [jdk11u-dev] RFR: 8209362: sun/security/ssl/SSLSocketImpl/ReuseAddr.java failed due to "BindException: Address already in use (Bind failed)" In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 08:09:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java > "protected volatile int serverPort = 0;" > "protected void doServerSide() throws Exception" > already protected, no need to change, make it clean. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2884#pullrequestreview-2237726211 From mbaesken at openjdk.org Wed Aug 14 10:18:51 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 10:18:51 GMT Subject: [jdk11u-dev] RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:29:56 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > text block modified as not supported. Test seems to be manual, does it still work ? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2891#issuecomment-2288375352 From andrewlu at openjdk.org Wed Aug 14 10:39:21 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 10:39:21 GMT Subject: [jdk17u-dev] RFR: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test Message-ID: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test ------------- Commit messages: - Backport 3f19df685c342cef212305cca630331878a24e79 Changes: https://git.openjdk.org/jdk17u-dev/pull/2801/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2801&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315936 Stats: 45 lines in 1 file changed: 35 ins; 6 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2801.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2801/head:pull/2801 PR: https://git.openjdk.org/jdk17u-dev/pull/2801 From andrewlu at openjdk.org Wed Aug 14 10:40:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 10:40:01 GMT Subject: [jdk11u-dev] RFR: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test Message-ID: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test ------------- Commit messages: - Backport 3f19df685c342cef212305cca630331878a24e79 Changes: https://git.openjdk.org/jdk11u-dev/pull/2908/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2908&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315936 Stats: 45 lines in 1 file changed: 35 ins; 6 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2908.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2908/head:pull/2908 PR: https://git.openjdk.org/jdk11u-dev/pull/2908 From andrewlu at openjdk.org Wed Aug 14 10:40:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 10:40:19 GMT Subject: [jdk17u-dev] RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file Message-ID: 8303891: Speed up Zip64SizeTest using a small ZIP64 file ------------- Commit messages: - Backport 842b895f093e15ecd8aa0153d712f5f81cf1cf67 Changes: https://git.openjdk.org/jdk17u-dev/pull/2803/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2803&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303891 Stats: 147 lines in 1 file changed: 75 ins; 10 del; 62 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2803.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2803/head:pull/2803 PR: https://git.openjdk.org/jdk17u-dev/pull/2803 From andrewlu at openjdk.org Wed Aug 14 10:40:27 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 10:40:27 GMT Subject: [jdk17u-dev] RFR: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java Message-ID: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java ------------- Commit messages: - Backport 0f77d250b67ae0678756f986607eb239641dfb9e Changes: https://git.openjdk.org/jdk17u-dev/pull/2802/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2802&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315684 Stats: 62 lines in 1 file changed: 60 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2802.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2802/head:pull/2802 PR: https://git.openjdk.org/jdk17u-dev/pull/2802 From andrewlu at openjdk.org Wed Aug 14 10:47:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 10:47:03 GMT Subject: [jdk17u-dev] RFR: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram Message-ID: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram ------------- Commit messages: - Backport 49eb00da8dc66cff3ca430f06ab21357ee6180ef Changes: https://git.openjdk.org/jdk17u-dev/pull/2804/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2804&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299813 Stats: 32 lines in 1 file changed: 19 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2804.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2804/head:pull/2804 PR: https://git.openjdk.org/jdk17u-dev/pull/2804 From andrewlu at openjdk.org Wed Aug 14 10:53:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 14 Aug 2024 10:53:20 GMT Subject: [jdk21u-dev] RFR: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 49eb00da8dc66cff3ca430f06ab21357ee6180ef Changes: https://git.openjdk.org/jdk21u-dev/pull/919/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=919&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299813 Stats: 32 lines in 1 file changed: 19 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/919.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/919/head:pull/919 PR: https://git.openjdk.org/jdk21u-dev/pull/919 From mbaesken at openjdk.org Wed Aug 14 11:13:05 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 11:13:05 GMT Subject: [jdk23u] RFR: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows Message-ID: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows ------------- Commit messages: - Backport f92c60e1a9968620cbc92b52aa546b57c09da487 Changes: https://git.openjdk.org/jdk23u/pull/70/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=70&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337810 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/70/head:pull/70 PR: https://git.openjdk.org/jdk23u/pull/70 From mbaesken at openjdk.org Wed Aug 14 11:21:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 11:21:04 GMT Subject: [jdk23u] RFR: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' Message-ID: <83rlLFTwXhU1YzlYaACkVFsXP_f4Sky5GMLhdorekq0=.31c488d0-21c6-4803-bee6-b29cb35124f4@github.com> 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' ------------- Commit messages: - Backport 8162832832ac6e8c17f942e718e309a3489e0da6 Changes: https://git.openjdk.org/jdk23u/pull/71/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=71&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333354 Stats: 131 lines in 10 files changed: 50 ins; 64 del; 17 mod Patch: https://git.openjdk.org/jdk23u/pull/71.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/71/head:pull/71 PR: https://git.openjdk.org/jdk23u/pull/71 From duke at openjdk.org Wed Aug 14 11:30:54 2024 From: duke at openjdk.org (duke) Date: Wed, 14 Aug 2024 11:30:54 GMT Subject: [jdk11u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: <6Z7whtGawqMaLueiqgq6bvIoxcdCf8KAMuJ8-JQe0gk=.03213bab-daed-42f7-b789-de3701803eec@github.com> On Thu, 8 Aug 2024 13:02:21 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed @zzambers Your change (at version f5e15f171aadd70d9cda5dcc34ff0b86de2346f7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2898#issuecomment-2288497303 From mbaesken at openjdk.org Wed Aug 14 11:34:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 11:34:04 GMT Subject: [jdk23u] RFR: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Message-ID: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion ------------- Commit messages: - Backport 00aac4097abd3c5e6144734cfd44228bc31892fb Changes: https://git.openjdk.org/jdk23u/pull/72/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=72&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338058 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/72.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/72/head:pull/72 PR: https://git.openjdk.org/jdk23u/pull/72 From mbaesken at openjdk.org Wed Aug 14 11:39:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 11:39:21 GMT Subject: [jdk21u-dev] RFR: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Message-ID: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion ------------- Commit messages: - Backport 00aac4097abd3c5e6144734cfd44228bc31892fb Changes: https://git.openjdk.org/jdk21u-dev/pull/920/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=920&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338058 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/920.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/920/head:pull/920 PR: https://git.openjdk.org/jdk21u-dev/pull/920 From syan at openjdk.org Wed Aug 14 11:58:52 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 11:58:52 GMT Subject: [jdk17u-dev] RFR: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false" In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:15:50 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [48702345](https://github.com/openjdk/jdk/commit/4870234552d2c63c786641493794a87654b98b7b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 25 May 2023 and was reviewed by Markus Gr?nlund. > > This the one of the several prefixed backports of JDK-8323196. > > Thanks! Thanks for the approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2796#issuecomment-2288545024 From duke at openjdk.org Wed Aug 14 11:58:53 2024 From: duke at openjdk.org (duke) Date: Wed, 14 Aug 2024 11:58:53 GMT Subject: [jdk17u-dev] RFR: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false" In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:15:50 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [48702345](https://github.com/openjdk/jdk/commit/4870234552d2c63c786641493794a87654b98b7b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 25 May 2023 and was reviewed by Markus Gr?nlund. > > This the one of the several prefixed backports of JDK-8323196. > > Thanks! @sendaoYan Your change (at version accdff910e591b3a0e6a2bb1eafbf67997d848f1) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2796#issuecomment-2288546456 From mbaesken at openjdk.org Wed Aug 14 11:59:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 11:59:03 GMT Subject: [jdk17u-dev] RFR: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' Message-ID: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' ------------- Commit messages: - Backport 113a2c028dc3b9abb6229d5f0b812b54a9b61011 Changes: https://git.openjdk.org/jdk17u-dev/pull/2805/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2805&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332903 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2805.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2805/head:pull/2805 PR: https://git.openjdk.org/jdk17u-dev/pull/2805 From syan at openjdk.org Wed Aug 14 12:05:55 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 12:05:55 GMT Subject: [jdk17u-dev] RFR: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 00:42:40 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2c9f741d](https://github.com/openjdk/jdk21u-dev/commit/2c9f741d9ce27cd81e4ad9395a88af1b34a2ba77) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Matthias Baesken. > > Thanks! Thanks for the approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2752#issuecomment-2288555257 From syan at openjdk.org Wed Aug 14 12:05:58 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 12:05:58 GMT Subject: [jdk11u-dev] RFR: 8334332: TestIOException.java fails if run by root In-Reply-To: <5-zEZYJt00wVH02mwY3eiC1JNttfqb55dnyk8BRRxZg=.cef6f6ff-d62b-4287-bd09-416541b1a862@github.com> References: <5-zEZYJt00wVH02mwY3eiC1JNttfqb55dnyk8BRRxZg=.cef6f6ff-d62b-4287-bd09-416541b1a862@github.com> Message-ID: <04g30yPXPF5xIaOm6LCfd7nV5gAFzXyn1JmaxEmfivk=.51a0ab2c-b239-42f6-b49a-bae01b889c2f@github.com> On Tue, 18 Jun 2024 15:31:24 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo. > > The reason of backport is not clean is that, multiple PRs have been merged into the `jdk17u-dev` of this file, including `JDK-8215516`, `JDK-8164597`, etc., and these PRs cannot be directly backported to `jdk11u-dev`. > > This PR also change `test/langtools/TEST.ROOT`, it's partial backport of [JDK-8242652](https://bugs.openjdk.org/browse/JDK-8242652). [JDK-8242652](https://bugs.openjdk.org/browse/JDK-8242652) can't backport to jdk11u-dev, the jdk11u-dev repo dosen't have file `test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java`. > > Only change test testcase, the risk is quite very low. > > The change verified on below env: > > - [x] linux non-root user > - [x] linix root user > - [x] windows > > Thanks! Hi, can anyone take a look this backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2795#issuecomment-2288559154 From duke at openjdk.org Wed Aug 14 12:05:55 2024 From: duke at openjdk.org (duke) Date: Wed, 14 Aug 2024 12:05:55 GMT Subject: [jdk17u-dev] RFR: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 00:42:40 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2c9f741d](https://github.com/openjdk/jdk21u-dev/commit/2c9f741d9ce27cd81e4ad9395a88af1b34a2ba77) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Matthias Baesken. > > Thanks! @sendaoYan Your change (at version e39586611035f739fbf6cc3bf9cdc0ec35e57ae9) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2752#issuecomment-2288558608 From shade at openjdk.org Wed Aug 14 12:59:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 14 Aug 2024 12:59:53 GMT Subject: [jdk17u-dev] Integrated: 8272558: IR Test Framework README misses some flags In-Reply-To: References: Message-ID: <0sgRDdG_yYSX4wef18ZciqMc3PmMVMpGBIwNED21ZHI=.8033a233-c8b7-4b66-81f6-a3af822d9511@github.com> On Mon, 12 Aug 2024 10:58:35 GMT, Aleksey Shipilev wrote: > This is a simple docs amendment. Without it, IR Framework backports are not clean and require tedious resolves. This pull request has now been integrated. Changeset: 9990cfaf Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/9990cfaf80712f6afc9d8a61b253ac11fb6c9d4e Stats: 17 lines in 1 file changed: 2 ins; 0 del; 15 mod 8272558: IR Test Framework README misses some flags Backport-of: 5189047d09e976cfd17d4ab5ec12097c242f3435 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2795 From duke at openjdk.org Wed Aug 14 13:03:52 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Wed, 14 Aug 2024 13:03:52 GMT Subject: [jdk21u-dev] Integrated: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable In-Reply-To: References: Message-ID: On Mon, 22 Jul 2024 20:25:34 GMT, Todd V. Jonker wrote: > This is a clean backport of https://github.com/openjdk/jdk/commit/36ac83904c9e81a01822b0e36ef677cae2808709 originally authored by @bplb and reviewed by @AlanBateman > > It also includes this follow-up fix: > * [JDK-8317128](https://bugs.openjdk.org/browse/JDK-8317128): **java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException** > * https://github.com/openjdk/jdk/pull/15991 > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST="tier1 tier2 tier3"` This pull request has now been integrated. Changeset: 590715f4 Author: Todd V. Jonker Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/590715f4f62a6e4c9cdf4cf1061b4ee7a2f3808e Stats: 319 lines in 6 files changed: 307 ins; 3 del; 9 mod 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable 8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException Reviewed-by: phh Backport-of: 36ac83904c9e81a01822b0e36ef677cae2808709 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/863 From duke at openjdk.org Wed Aug 14 13:04:52 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Wed, 14 Aug 2024 13:04:52 GMT Subject: [jdk21u-dev] Integrated: 8319817: Charset constructor should make defensive copy of aliases In-Reply-To: References: Message-ID: On Mon, 15 Jul 2024 21:46:38 GMT, Todd V. Jonker wrote: > Clean backport. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` > * These tests fail repeatedly, but also fail on `master`: > * `build/AbsPathsInImage.java` > * `java/nio/channels/FileChannel/directio/DirectIOTest.java` This pull request has now been integrated. Changeset: edd64373 Author: Todd V. Jonker Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/edd6437324d5f0a2f8848f09c0936b6ebfbe82bf Stats: 76 lines in 2 files changed: 74 ins; 1 del; 1 mod 8319817: Charset constructor should make defensive copy of aliases Backport-of: d6d7bdc7748c10963c3e58c0287b2472646bf36f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/841 From mbaesken at openjdk.org Wed Aug 14 13:50:55 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Aug 2024 13:50:55 GMT Subject: [jdk23u] Integrated: 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows In-Reply-To: References: Message-ID: <865N_6kLQZZWzHXcPo8ZA-uDoZZD_OlqkSxgp2CZTNc=.7a54ac77-4a7e-493f-97c3-d9749afa3d3e@github.com> On Wed, 14 Aug 2024 11:06:24 GMT, Matthias Baesken wrote: > 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows This pull request has now been integrated. Changeset: afba2b34 Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/afba2b3467333cc1910114c2d194912763c5a5f4 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8337810: ProblemList BasicDirectoryModel/LoaderThreadCount.java on Windows Backport-of: f92c60e1a9968620cbc92b52aa546b57c09da487 ------------- PR: https://git.openjdk.org/jdk23u/pull/70 From cushon at openjdk.org Wed Aug 14 15:07:01 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 14 Aug 2024 15:07:01 GMT Subject: [jdk23u] RFR: 8337795: Type annotation attached to incorrect type during class reading [v2] In-Reply-To: References: Message-ID: > This change fixes a bug in javac's handling of type annotations in bytecode, which was logic first added in JDK 22 as part of the fix for JDK-8225377. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8337795 - Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/67/files - new: https://git.openjdk.org/jdk23u/pull/67/files/ca2e3434..c7b59e5b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=67&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=67&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/67.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/67/head:pull/67 PR: https://git.openjdk.org/jdk23u/pull/67 From cushon at openjdk.org Wed Aug 14 15:08:09 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 14 Aug 2024 15:08:09 GMT Subject: [jdk23u] RFR: 8337998: CompletionFailure in getEnclosingType attaching type annotations [v2] In-Reply-To: <9kCInkTP1JZYG7gKqoB7pkXmYjChxNti9BMrusphX4Q=.d1c53caa-cc75-4dde-b85b-95425a61f95c@github.com> References: <9kCInkTP1JZYG7gKqoB7pkXmYjChxNti9BMrusphX4Q=.d1c53caa-cc75-4dde-b85b-95425a61f95c@github.com> Message-ID: > This change fixes a javac crash when classes are missing from the classpath. The fix causes javac to instead report a non-crash error diagnostic. The change improves logic first added in JDK 22 as part of the fix for JDK-8225377. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8337998 - Backport 9e282e5c966a9c065de8b901b7d30bb5c9ccf243 ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/68/files - new: https://git.openjdk.org/jdk23u/pull/68/files/bc7e1b47..3d938a6d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=68&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=68&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/68.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/68/head:pull/68 PR: https://git.openjdk.org/jdk23u/pull/68 From syan at openjdk.org Wed Aug 14 15:42:51 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 15:42:51 GMT Subject: [jdk23u] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 01:35:10 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! The GHA test runner report macos-x64 `install dependencies` fail, seems like environmental issue, unreleated to this PR. Thanks for the approvel. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/69#issuecomment-2289138177 PR Comment: https://git.openjdk.org/jdk23u/pull/69#issuecomment-2289139392 From duke at openjdk.org Wed Aug 14 15:42:52 2024 From: duke at openjdk.org (duke) Date: Wed, 14 Aug 2024 15:42:52 GMT Subject: [jdk23u] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 01:35:10 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! @sendaoYan Your change (at version 7c4010982a99a087b6606abe309821527c46dafb) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/69#issuecomment-2289142092 From andrew at openjdk.org Wed Aug 14 15:44:52 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 14 Aug 2024 15:44:52 GMT Subject: [jdk11u-dev] RFR: 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings In-Reply-To: References: Message-ID: <0B_KliL_e8vJE4qrby-7hyDDG5uAVW7sQtKAVneF86M=.b166e6bf-fc84-4104-8d3c-c5f9cba02e5e@github.com> On Sat, 6 Jul 2024 15:00:54 GMT, Andrew John Hughes wrote: > The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from `gcc` builds by changing `WARNING_CFLAGS_JDK` and `WARNING_CFLAGS_JVM`, but not defining `WARNINGS_ENABLE_ALL`, `WARNINGS_ENABLE_ADDITIONAL_JVM` and `DISABLED_WARNINGS`. > > The other more minor issues are the silent inclusion of `-Wreorder` to clang builds (should be a backport of [JDK-8208672](https://bugs.openjdk.org/browse/JDK-8208672)) and `-xc99=%none` (reverting [JDK-8215296](https://bugs.openjdk.org/browse/JDK-8215296)), because new lines were used as is without comparing differences in what was being replaced. > > All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch. > > I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work) Keep this open. Still waiting on a review. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2838#issuecomment-2289145609 From syan at openjdk.org Wed Aug 14 15:46:50 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 15:46:50 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: <0_z00j-8tBFfSvP8Q641W5FBl-Ur-TYbih7D_UrWNOM=.36e6cd08-e73c-41f4-9278-1fbf779bcc48@github.com> On Tue, 16 Jul 2024 02:02:06 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. > > Thanks! Thanks for the approval. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2289145954 From duke at openjdk.org Wed Aug 14 15:46:50 2024 From: duke at openjdk.org (duke) Date: Wed, 14 Aug 2024 15:46:50 GMT Subject: [jdk23u] RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts In-Reply-To: References: Message-ID: On Tue, 16 Jul 2024 02:02:06 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [8feabc84](https://github.com/openjdk/jdk/commit/8feabc849ba2f617c8c6dbb2ec5074297beb6437) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 16 Jul 2024 and was reviewed by Jaikiran Pai. > > Thanks! @sendaoYan Your change (at version 8c2ca4bed96ac74f503ea0a1f2de616c621f1111) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/25#issuecomment-2289149088 From syan at openjdk.org Wed Aug 14 15:50:08 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 15:50:08 GMT Subject: [jdk21u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:05:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. > > This the prefixed backport of [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). > > Thanks! > /approve yes Thanks for the approval. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/915#issuecomment-2289152032 From duke at openjdk.org Wed Aug 14 15:50:08 2024 From: duke at openjdk.org (duke) Date: Wed, 14 Aug 2024 15:50:08 GMT Subject: [jdk21u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:05:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. > > This the prefixed backport of [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). > > Thanks! @sendaoYan Your change (at version 3edfdc0aa396b3665c35ac5c4c316fd961f45d43) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/915#issuecomment-2289154717 From duke at openjdk.org Wed Aug 14 16:07:54 2024 From: duke at openjdk.org (duke) Date: Wed, 14 Aug 2024 16:07:54 GMT Subject: [jdk21u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 16:06:12 GMT, Daniel Hu wrote: >> Backport of improvements to DataDescriptorSignatureMissing test. Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. >> >> Passes tier1 tests and the test itself on Linux x64 > > Daniel Hu has updated the pull request incrementally with one additional commit since the last revision: > > reverted copyright year to original @cost0much Your change (at version 0d4c3d205155bbc04be5b47229dcc60c4e12c52a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/913#issuecomment-2289204498 From duke at openjdk.org Wed Aug 14 16:13:50 2024 From: duke at openjdk.org (Daniel Hu) Date: Wed, 14 Aug 2024 16:13:50 GMT Subject: [jdk21u-dev] Integrated: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 21:14:16 GMT, Daniel Hu wrote: > Backport of improvements to DataDescriptorSignatureMissing test. Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. > > Passes tier1 tests and the test itself on Linux x64 This pull request has now been integrated. Changeset: 79349b8b Author: Daniel Hu Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/79349b8bb30e3a358a1fec2382d44aabcf15239b Stats: 158 lines in 1 file changed: 52 ins; 38 del; 68 mod 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Reviewed-by: shade Backport-of: 07eaea8c25bae6ed852685f082f8b50c5b20c1a9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/913 From syan at openjdk.org Wed Aug 14 16:16:14 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 14 Aug 2024 16:16:14 GMT Subject: [jdk21u-dev] RFR: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp Message-ID: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> Hi all, This pull request contains a backport of commit [bf13a4e2](https://github.com/openjdk/jdk/commit/bf13a4e2819fa5bcb3e4f2281121d4e0b5535403) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by sunyaqi on 26 Feb 2024 and was reviewed by Brian Burkhalter. Thanks! ------------- Commit messages: - Backport bf13a4e2819fa5bcb3e4f2281121d4e0b5535403 Changes: https://git.openjdk.org/jdk21u-dev/pull/921/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=921&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322881 Stats: 11 lines in 1 file changed: 1 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/921.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/921/head:pull/921 PR: https://git.openjdk.org/jdk21u-dev/pull/921 From duke at openjdk.org Wed Aug 14 16:19:02 2024 From: duke at openjdk.org (Daniel Hu) Date: Wed, 14 Aug 2024 16:19:02 GMT Subject: [jdk21u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Message-ID: Clean backport. Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes tier1 tests on linux x64 and the test itself. ------------- Commit messages: - Backport f6be922952642f40dcf0d27b7896c9a6acdd6378 Changes: https://git.openjdk.org/jdk21u-dev/pull/918/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=918&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316193 Stats: 12 lines in 1 file changed: 2 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/918.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/918/head:pull/918 PR: https://git.openjdk.org/jdk21u-dev/pull/918 From mdoerr at openjdk.org Wed Aug 14 20:55:59 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 14 Aug 2024 20:55:59 GMT Subject: [jdk11u-dev] RFR: 8336451: [11u] GHA macos-13 builder is unable to resolve local hostname In-Reply-To: References: Message-ID: On Tue, 16 Jul 2024 15:39:30 GMT, Antonio Vieiro wrote: > This fixes [JDK-8336451](https://bugs.openjdk.org/browse/JDK-8336451). > > This is a problem with the latest Github macos runners (see https://github.com/actions/runner-images/issues/8649) that makes it impossible for `getaddrinfo` to properly resolve the builder's hostname. The issue has been opened since late 2023. > > Not being able to resolve the local hostname makes `jdk/tier1` and `langtools/tier1` to fail on this platform, as the [socket transport ](https://github.com/openjdk/jdk11u-dev/blob/697d8566b1d4801cb7926fa35bbf471f8f4ba066/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c#L329) cannot establish a connection. > > There are still some other `sprintf`s in the codebase, but these do not affect the macos builds, and can be possibly backported later on, once the macos builds are again in place. > > The macos builds and tests are expected to succeed after this fix is in place. LGTM, but I'm not an expert in this area. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2861#pullrequestreview-2239169573 From mdoerr at openjdk.org Wed Aug 14 20:58:55 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 14 Aug 2024 20:58:55 GMT Subject: [jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype In-Reply-To: References: Message-ID: On Fri, 12 Jul 2024 07:49:44 GMT, Antonio Vieiro wrote: > This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. > > The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. > > This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2854#pullrequestreview-2239174900 From duke at openjdk.org Wed Aug 14 22:40:13 2024 From: duke at openjdk.org (Daniel Hu) Date: Wed, 14 Aug 2024 22:40:13 GMT Subject: [jdk17u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved Message-ID: <8MRRKEJZgif7BUHzNkXJzBzoveJx7J5c7io49yfd_dA=.db468128-1350-4353-ad7e-196c1442297d@github.com> Backporting test ------------- Commit messages: - Backport 4676b40f17dd18941f5883cb9b989ad639992a50 Changes: https://git.openjdk.org/jdk17u-dev/pull/2806/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2806&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312049 Stats: 34 lines in 1 file changed: 3 ins; 6 del; 25 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2806.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2806/head:pull/2806 PR: https://git.openjdk.org/jdk17u-dev/pull/2806 From jwtang at openjdk.org Thu Aug 15 01:59:28 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Thu, 15 Aug 2024 01:59:28 GMT Subject: [jdk23u] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option Message-ID: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option ------------- Commit messages: - Backport 55c509708e9b89a7609fd41b6e5a271f250bbacd Changes: https://git.openjdk.org/jdk23u/pull/73/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=73&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337331 Stats: 83 lines in 2 files changed: 78 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk23u/pull/73.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/73/head:pull/73 PR: https://git.openjdk.org/jdk23u/pull/73 From duke at openjdk.org Thu Aug 15 02:13:50 2024 From: duke at openjdk.org (duke) Date: Thu, 15 Aug 2024 02:13:50 GMT Subject: [jdk23u] RFR: 8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed In-Reply-To: <_KjDGBxYYwhtnDw5VMvHyxublzq0DrRzBU9wWsXVNa8=.3348b55b-37ae-4537-87b5-bc6cf07f529b@github.com> References: <_KjDGBxYYwhtnDw5VMvHyxublzq0DrRzBU9wWsXVNa8=.3348b55b-37ae-4537-87b5-bc6cf07f529b@github.com> Message-ID: <0_B-j5cTGVseNWuCrVowhUHd6z4kRySK69u2XPuu4m8=.331e852b-c613-459a-acbe-77444f1aac7e@github.com> On Tue, 13 Aug 2024 05:13:29 GMT, Gui Cao wrote: > Hi, The same issue also exists in the jdk23u. I would like to backport [8337971](https://bugs.openjdk.org/browse/JDK-8337971) to jdk23u. With this backport, we can skip these tests on the linux-riscv64 platform. This is a risc-v specific change. Backport is clean, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (release) @zifeihan Your change (at version 767fa5ea4f357d0a2214173e6c3fdd427518ac56) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/65#issuecomment-2290367333 From gcao at openjdk.org Thu Aug 15 02:18:55 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 15 Aug 2024 02:18:55 GMT Subject: [jdk23u] Integrated: 8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed In-Reply-To: <_KjDGBxYYwhtnDw5VMvHyxublzq0DrRzBU9wWsXVNa8=.3348b55b-37ae-4537-87b5-bc6cf07f529b@github.com> References: <_KjDGBxYYwhtnDw5VMvHyxublzq0DrRzBU9wWsXVNa8=.3348b55b-37ae-4537-87b5-bc6cf07f529b@github.com> Message-ID: <-x2iD1NdxHrHrPqLD1S2P4mzLoKeGthpxqCJHyUIZJs=.61d5aa27-8c1e-4f79-b2ba-af05cdc7b588@github.com> On Tue, 13 Aug 2024 05:13:29 GMT, Gui Cao wrote: > Hi, The same issue also exists in the jdk23u. I would like to backport [8337971](https://bugs.openjdk.org/browse/JDK-8337971) to jdk23u. With this backport, we can skip these tests on the linux-riscv64 platform. This is a risc-v specific change. Backport is clean, risk is low. > > ### Testing > - [x] Run hotspot:tier1 tests on SOPHON SG2042 (release) This pull request has now been integrated. Changeset: b82bbaec Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk23u/commit/b82bbaec4b9b5592dcf4163615b42fc5690097d0 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed Backport-of: 16df9c33e9bbc9329ae60ba14332c09aadaba3f0 ------------- PR: https://git.openjdk.org/jdk23u/pull/65 From andrewlu at openjdk.org Thu Aug 15 02:29:57 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 15 Aug 2024 02:29:57 GMT Subject: [jdk11u-dev] RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 10:16:33 GMT, Matthias Baesken wrote: > Test seems to be manual, does it still work ? hi @MBaesken , this test needs to be test in linux, my system is mac, can you help to check it? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2891#issuecomment-2290383553 From andrewlu at openjdk.org Thu Aug 15 03:03:56 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 15 Aug 2024 03:03:56 GMT Subject: [jdk11u-dev] RFR: 8328300: Convert PrintDialogsTest.java from Applet to main program [v2] In-Reply-To: References: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> Message-ID: On Wed, 14 Aug 2024 10:00:48 GMT, Matthias Baesken wrote: > Seems the test is marked manual , did you run it manually , does it work ? `@run main/manual PrintDialogsTest` hi @MBaesken , yes, local pass. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2892#issuecomment-2290452847 From andrewlu at openjdk.org Thu Aug 15 05:45:30 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 15 Aug 2024 05:45:30 GMT Subject: [jdk11u-dev] RFR: 8220673: Add test library support for determining platform IP support Message-ID: I backport this for parity with 11.0.25-oracle. these tests are not clean, but all added code is clean test/jdk/java/net/NetworkInterface/Test.java test/jdk/java/net/Socket/CloseAvailable.java test/jdk/java/net/Socket/HttpProxy.java test/jdk/java/net/Socket/SetSoLinger.java test/jdk/java/nio/channels/DatagramChannel/Disconnect.java this class is not exist, ignore, other classes are clean test/jdk/java/nio/channels/etc/PrintSupportedOptions.java ------------- Commit messages: - Backport 0bb6328356f0f0789d1e10d32f6b66981fd68e6b - Backport 0bb6328356f0f0789d1e10d32f6b66981fd68e6b - Backport 0bb6328356f0f0789d1e10d32f6b66981fd68e6b - Backport 0bb6328356f0f0789d1e10d32f6b66981fd68e6b Changes: https://git.openjdk.org/jdk11u-dev/pull/2910/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2910&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8220673 Stats: 387 lines in 56 files changed: 284 ins; 72 del; 31 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2910.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2910/head:pull/2910 PR: https://git.openjdk.org/jdk11u-dev/pull/2910 From andrewlu at openjdk.org Thu Aug 15 06:06:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 15 Aug 2024 06:06:22 GMT Subject: [jdk11u-dev] RFR: 8266161: mark hotspot compiler/rtm tests which ignore VM flags Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport 81b1502701e70c98d3d6a763808a3ae6f2dc8739 Changes: https://git.openjdk.org/jdk11u-dev/pull/2911/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2911&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8266161 Stats: 34 lines in 17 files changed: 17 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2911.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2911/head:pull/2911 PR: https://git.openjdk.org/jdk11u-dev/pull/2911 From andrewlu at openjdk.org Thu Aug 15 06:29:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 15 Aug 2024 06:29:22 GMT Subject: [jdk21u-dev] RFR: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm Message-ID: I backport this for parity with 21.0.5-oracle. add added codes are clean, except line different. ------------- Commit messages: - Backport d1af748ab470e1068d03a8f8bc1a7445eff721fa - Backport d1af748ab470e1068d03a8f8bc1a7445eff721fa - Backport d1af748ab470e1068d03a8f8bc1a7445eff721fa - Backport d1af748ab470e1068d03a8f8bc1a7445eff721fa Changes: https://git.openjdk.org/jdk21u-dev/pull/923/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=923&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309067 Stats: 51 lines in 1 file changed: 19 ins; 17 del; 15 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/923.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/923/head:pull/923 PR: https://git.openjdk.org/jdk21u-dev/pull/923 From andrewlu at openjdk.org Thu Aug 15 06:52:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 15 Aug 2024 06:52:06 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs Message-ID: I backport this for parity with 17.0.13-oracle. modify lines are different, but code is clean. ------------- Commit messages: - Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 Changes: https://git.openjdk.org/jdk17u-dev/pull/2807/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320675 Stats: 234 lines in 1 file changed: 51 ins; 151 del; 32 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2807.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2807/head:pull/2807 PR: https://git.openjdk.org/jdk17u-dev/pull/2807 From andrewlu at openjdk.org Thu Aug 15 06:56:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 15 Aug 2024 06:56:16 GMT Subject: [jdk11u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs Message-ID: I backport this for parity with 11.0.25-oracle. modify lines are different, but code is clean. ------------- Commit messages: - Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 Changes: https://git.openjdk.org/jdk11u-dev/pull/2912/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2912&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320675 Stats: 238 lines in 1 file changed: 54 ins; 153 del; 31 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2912.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2912/head:pull/2912 PR: https://git.openjdk.org/jdk11u-dev/pull/2912 From mbaesken at openjdk.org Thu Aug 15 07:07:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 07:07:50 GMT Subject: [jdk11u-dev] RFR: 8328300: Convert PrintDialogsTest.java from Applet to main program [v2] In-Reply-To: References: <4mwxOZNEsaB1EO36Re1hZ9HtfazQBXyDDe6U5qe4JhU=.f37968f0-0502-4f32-a9a6-dba66522a9e4@github.com> Message-ID: On Thu, 1 Aug 2024 06:28:48 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.25-oracle. >> text block modified as not supported. > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > Backport dea94f4445b9389339cf7ca0eef688ca56c17814 Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2892#pullrequestreview-2239842281 From mbaesken at openjdk.org Thu Aug 15 07:10:55 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 07:10:55 GMT Subject: [jdk11u-dev] RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 02:29:56 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > text block modified as not supported. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2891#pullrequestreview-2239845401 From mbaesken at openjdk.org Thu Aug 15 07:12:49 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 07:12:49 GMT Subject: [jdk23u] Integrated: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 11:29:29 GMT, Matthias Baesken wrote: > 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion This pull request has now been integrated. Changeset: 4e56ca54 Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/4e56ca54e70a5497caa0a8df729e3803ad5e1390 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Backport-of: 00aac4097abd3c5e6144734cfd44228bc31892fb ------------- PR: https://git.openjdk.org/jdk23u/pull/72 From mbaesken at openjdk.org Thu Aug 15 07:17:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 07:17:20 GMT Subject: [jdk23u] RFR: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 Message-ID: <5mXteZOI6S680knizgpGRoITEkAl5YAL0cOKazU4VCA=.d3130787-9134-475a-b7d0-0cee44b06f89@github.com> 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 ------------- Commit messages: - Backport 692f5cbdb9bd94f03e5f18ddf07d56fbb5c0d456 Changes: https://git.openjdk.org/jdk23u/pull/74/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=74&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338101 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/74.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/74/head:pull/74 PR: https://git.openjdk.org/jdk23u/pull/74 From phh at openjdk.org Thu Aug 15 13:50:51 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 13:50:51 GMT Subject: [jdk21u-dev] RFR: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 06:18:52 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. > add added codes are clean, except line different. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/923#pullrequestreview-2240433849 From phh at openjdk.org Thu Aug 15 13:57:02 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 13:57:02 GMT Subject: [jdk11u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 06:49:52 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > modify lines are different, but code is clean. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2912#pullrequestreview-2240445919 From phh at openjdk.org Thu Aug 15 14:00:00 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 14:00:00 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 06:44:25 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. > modify lines are different, but code is clean. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2807#pullrequestreview-2240452758 From phh at openjdk.org Thu Aug 15 14:15:58 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 14:15:58 GMT Subject: [jdk11u-dev] RFR: 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings In-Reply-To: References: Message-ID: <1GZ7a67_xGibuhYW-A7FgxnikcjmlaPg3LEfx-Mpt1Q=.d9d8e827-4bd9-43bb-993b-9cbadba5d6db@github.com> On Sat, 6 Jul 2024 15:00:54 GMT, Andrew John Hughes wrote: > The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from `gcc` builds by changing `WARNING_CFLAGS_JDK` and `WARNING_CFLAGS_JVM`, but not defining `WARNINGS_ENABLE_ALL`, `WARNINGS_ENABLE_ADDITIONAL_JVM` and `DISABLED_WARNINGS`. > > The other more minor issues are the silent inclusion of `-Wreorder` to clang builds (should be a backport of [JDK-8208672](https://bugs.openjdk.org/browse/JDK-8208672)) and `-xc99=%none` (reverting [JDK-8215296](https://bugs.openjdk.org/browse/JDK-8215296)), because new lines were used as is without comparing differences in what was being replaced. > > All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch. > > I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work) Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2838#pullrequestreview-2240483956 From zzambers at openjdk.org Thu Aug 15 14:20:59 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 15 Aug 2024 14:20:59 GMT Subject: [jdk11u-dev] Integrated: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: <1Q890BLLt-CoTORKXRadZYuVMWiWKAmtTqKL_nbR7LY=.885142f1-f517-4117-9367-079eaffc104a@github.com> On Thu, 8 Aug 2024 13:02:21 GMT, Zdenek Zambersky wrote: > Fix of GHA code which removes bundle artifacts. > > Testing in GHA: > bundles-* artifacts got correctly removed This pull request has now been integrated. Changeset: 3caf5017 Author: Zdenek Zambersky Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/3caf5017a11ba0777281c0104dc606873947c615 Stats: 22 lines in 1 file changed: 4 ins; 7 del; 11 mod 8336928: GHA: Bundle artifacts removal broken Backport-of: 98562166e4a4c8921709014423c6cbc993aa0d97 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2898 From phh at openjdk.org Thu Aug 15 14:27:49 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 14:27:49 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Tue, 13 Aug 2024 16:54:05 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. > It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. > This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: > > | Bug | Title | > | ----------- | ---------------------------------------------- | > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | > > > Best, > Xiaolong. > > > Additional tests: > - [x] hotspot_gc_shenandoah > - [ ] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC Thank you. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2797#pullrequestreview-2240510553 From shade at openjdk.org Thu Aug 15 14:46:49 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 15 Aug 2024 14:46:49 GMT Subject: [jdk17u-dev] RFR: 8334166: Enable binary check In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 07:15:39 GMT, Matthias Baesken wrote: > 8334166: Enable binary check Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2800#pullrequestreview-2240552516 From mdoerr at openjdk.org Thu Aug 15 14:47:51 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 15 Aug 2024 14:47:51 GMT Subject: [jdk11u-dev] RFR: 8334166: Enable binary check In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 08:11:44 GMT, Matthias Baesken wrote: > 8334166: Enable binary check Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2907#pullrequestreview-2240554979 From mbaesken at openjdk.org Thu Aug 15 15:24:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 15:24:56 GMT Subject: [jdk17u-dev] RFR: 8334166: Enable binary check In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 07:15:39 GMT, Matthias Baesken wrote: > 8334166: Enable binary check macos error is unrelated, curl fails to get the boot JDK. Hi Aleksey, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2800#issuecomment-2291508056 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2800#issuecomment-2291509363 From mbaesken at openjdk.org Thu Aug 15 15:24:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 15:24:57 GMT Subject: [jdk17u-dev] Integrated: 8334166: Enable binary check In-Reply-To: References: Message-ID: <-gxOT27ttqQLwgxqQXuN8k7AMB57-bYX4PC0nNp80rM=.de4b5d0c-2a3e-476d-a207-76b6133c6afb@github.com> On Wed, 14 Aug 2024 07:15:39 GMT, Matthias Baesken wrote: > 8334166: Enable binary check This pull request has now been integrated. Changeset: 185e69a3 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/185e69a3f73e03b480d6c519fbde26af2b350a8d Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8334166: Enable binary check 8332008: Enable issuestitle check Reviewed-by: shade Backport-of: 108c2e4986bfae9f6993ad03d926298b267cf523 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2800 From mbaesken at openjdk.org Thu Aug 15 15:34:24 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 15:34:24 GMT Subject: [jdk23u] RFR: 8338110: Exclude Fingerprinter::do_type from ubsan checks Message-ID: 8338110: Exclude Fingerprinter::do_type from ubsan checks ------------- Commit messages: - Backport 6a390147959e0fb88de6ee13204cff72cd910f09 Changes: https://git.openjdk.org/jdk23u/pull/75/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=75&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338110 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/75.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/75/head:pull/75 PR: https://git.openjdk.org/jdk23u/pull/75 From mbaesken at openjdk.org Thu Aug 15 15:35:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Aug 2024 15:35:08 GMT Subject: [jdk21u-dev] RFR: 8338110: Exclude Fingerprinter::do_type from ubsan checks Message-ID: 8338110: Exclude Fingerprinter::do_type from ubsan checks ------------- Commit messages: - Backport 6a390147959e0fb88de6ee13204cff72cd910f09 Changes: https://git.openjdk.org/jdk21u-dev/pull/924/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=924&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338110 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/924.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/924/head:pull/924 PR: https://git.openjdk.org/jdk21u-dev/pull/924 From btaylor at openjdk.org Thu Aug 15 17:25:54 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 15 Aug 2024 17:25:54 GMT Subject: [jdk21u-dev] Integrated: 8321206: Make Locale related system properties `StaticProperty` In-Reply-To: References: Message-ID: <8KXQ_uXkyQEKWoxEy6kbrs13d5iJP1h4mz6ZuiYqVIo=.5087a53d-bd67-4eb3-b600-b3f838bd86e5@github.com> On Mon, 12 Aug 2024 19:56:09 GMT, Ben Taylor wrote: > Clean backport of change to make Locale system properties static. Change passes all tier 1 tests locally on x86_64 linux. > > From the original PR: >>Currently, Locale-related system properties, such as user.language or user.country, are initialized when the Locale class is loaded. Making them static properties is safer than relying on the Locale class loading timing, which could potentially be changed depending on the implementation. > > This change also makes [JDK-8321940](https://bugs.openjdk.org/browse/JDK-8321940) clean, which will improve maintainability by reducing the number of manually curated `ADD_EXCL` entries in `cdsHeapVerifier.cpp`. This pull request has now been integrated. Changeset: a3cd6d6b Author: Ben Taylor URL: https://git.openjdk.org/jdk21u-dev/commit/a3cd6d6b916f7d8c03cd4b59324a6da11df467eb Stats: 69 lines in 3 files changed: 49 ins; 7 del; 13 mod 8321206: Make Locale related system properties `StaticProperty` Backport-of: 0c178beb69c4c5fc3e92621340748e42d017d458 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/912 From duke at openjdk.org Thu Aug 15 17:47:04 2024 From: duke at openjdk.org (Daniel Hu) Date: Thu, 15 Aug 2024 17:47:04 GMT Subject: [jdk21u-dev] RFR: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 Message-ID: Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120) afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because [JDK-8310308](https://github.com/openjdk/jdk21u-dev/pull/29) has already backported a later fix to VectorLogicalOpIdentityTest.java; as all logic changes from this backport to the test are overwritten and the only other line change to the file represents an update to the copyright year, this test has been removed from this backport. Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change. ------------- Commit messages: - Backport 60544f9088c11e4718a9cd77f21792c6ba387440 Changes: https://git.openjdk.org/jdk21u-dev/pull/922/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=922&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309894 Stats: 45 lines in 3 files changed: 33 ins; 9 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/922.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/922/head:pull/922 PR: https://git.openjdk.org/jdk21u-dev/pull/922 From btaylor at openjdk.org Thu Aug 15 18:03:18 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 15 Aug 2024 18:03:18 GMT Subject: [jdk21u-dev] RFR: 8321940: Improve CDSHeapVerifier in handling of interned strings Message-ID: Clean backport of a change to fix a false-positive error condition in the cdsHeapVerifier. This change also reduces the number of manually curated `ADD_EXCL` entries in cdsHeapVerifier, improving long-term maintainability. Change passes tier 1 tests locally on x86_64 linux. ------------- Commit messages: - Backport 4f3de09672d203a0182f330645962c3d08e5e206 Changes: https://git.openjdk.org/jdk21u-dev/pull/925/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=925&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321940 Stats: 36 lines in 1 file changed: 6 ins; 30 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/925.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/925/head:pull/925 PR: https://git.openjdk.org/jdk21u-dev/pull/925 From abakhtin at openjdk.org Thu Aug 15 18:35:15 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 15 Aug 2024 18:35:15 GMT Subject: [jdk11u-dev] RFR: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2 Message-ID: <7tBsz-GBWANJyzFoYwKjWpa3ieXlPPmNV2AIbwk1fUU=.bf43fd0a-4c19-4cdd-9b98-3fe2b5b14e71@github.com> Please review the backport of JDK-8296410 to 11u Stream.java is applied cleanly. BodyOutputStream.java, Http2TestServer.java, and Http2TestServerConnection.java test library classes are in another path and the package name. They are applied cleanly after updating the path to the files. New TrailingHeadersTest is updated: - fixed reference to the Http2TestServer module - fixed instanceOf pattern issue Added Http2TestServerConnection::addToOutputQ method required for the test functionality All java/net/httpclient JTREG tests passed ------------- Commit messages: - Backport f4b140b4200fc0f49161395501d3dbcba7a79059 Changes: https://git.openjdk.org/jdk11u-dev/pull/2909/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2909&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296410 Stats: 434 lines in 5 files changed: 392 ins; 14 del; 28 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2909.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2909/head:pull/2909 PR: https://git.openjdk.org/jdk11u-dev/pull/2909 From duke at openjdk.org Thu Aug 15 19:19:57 2024 From: duke at openjdk.org (duke) Date: Thu, 15 Aug 2024 19:19:57 GMT Subject: [jdk11u-dev] Withdrawn: 8334635: tools/pack200/PackTestZip64.java fails with --with-zlib=system In-Reply-To: References: Message-ID: On Thu, 20 Jun 2024 14:13:08 GMT, Antonio Vieiro wrote: > A fix for [JDK-8334635](https://bugs.openjdk.org/browse/JDK-8334635) on a test file. > > Tested on Fedora 40 using the default zlib-ng. Test passes with and without `JAVA_OPTIONS=-DPackTestZip64.enableBigJar` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2799 From ashi at openjdk.org Thu Aug 15 21:59:03 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 15 Aug 2024 21:59:03 GMT Subject: [jdk17u-dev] RFR: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837 Message-ID: Backport of [JDK-8315576](https://bugs.openjdk.org/browse/JDK-8315576) - Changes on `CodeCacheFullCountTest.java` is `clean` Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `CodeCacheFullCountTest.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 343cc0ce2bba797e206f6b7312018a8c6d1bdb66 Changes: https://git.openjdk.org/jdk17u-dev/pull/2808/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2808&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315576 Stats: 13 lines in 1 file changed: 8 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2808.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2808/head:pull/2808 PR: https://git.openjdk.org/jdk17u-dev/pull/2808 From ashi at openjdk.org Thu Aug 15 22:52:23 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 15 Aug 2024 22:52:23 GMT Subject: [jdk17u-dev] RFR: 8308891: TestCDSVMCrash.java needs @requires vm.cds Message-ID: <8febJNhfSE2K3VCcaiTGg0TnHQBjRhcSOVQfym8dSIY=.2550dd8f-2f44-435a-8512-c3643c56a3aa@github.com> Backport of [JDK-8308891](https://bugs.openjdk.org/browse/JDK-8308891) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `TestCDSVMCrash.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 101bf2290da5735fd9624ab647a8183c2c21f22d Changes: https://git.openjdk.org/jdk17u-dev/pull/2809/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2809&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308891 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2809.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2809/head:pull/2809 PR: https://git.openjdk.org/jdk17u-dev/pull/2809 From phh at openjdk.org Thu Aug 15 23:33:55 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 23:33:55 GMT Subject: [jdk21u-dev] RFR: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 22:31:44 GMT, Daniel Hu wrote: > Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120) afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because [JDK-8310308](https://github.com/openjdk/jdk21u-dev/pull/29) has already backported a later fix to VectorLogicalOpIdentityTest.java; as all logic changes from this backport to the test are overwritten and the only other line change to the file represents an update to the copyright year, this test has been removed from this backport. > > Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/922#pullrequestreview-2241507768 From phh at openjdk.org Thu Aug 15 23:37:53 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 23:37:53 GMT Subject: [jdk17u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: <8MRRKEJZgif7BUHzNkXJzBzoveJx7J5c7io49yfd_dA=.db468128-1350-4353-ad7e-196c1442297d@github.com> References: <8MRRKEJZgif7BUHzNkXJzBzoveJx7J5c7io49yfd_dA=.db468128-1350-4353-ad7e-196c1442297d@github.com> Message-ID: <3unKE2zXMrZ20APVjp93GWOmaYTA5hGYuKbzW73_Nq4=.4c4f5c05-83a7-490b-be3d-4cf9c3a57593@github.com> On Wed, 14 Aug 2024 17:09:36 GMT, Daniel Hu wrote: > Backporting JDK-8312049 that improves ClassLoadUnloadTest; already backported to [JDK21](https://github.com/openjdk/jdk21u-dev/pull/909). Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Additionally, some args in exec() were not added until a [later version](https://bugs.openjdk.org/browse/JDK-8289184), thus they have been excluded. > > Passes tier1 tests on Linux x86 and the test itself. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2806#pullrequestreview-2241513908 From phh at openjdk.org Thu Aug 15 23:58:54 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Aug 2024 23:58:54 GMT Subject: [jdk17u-dev] RFR: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837 In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 21:54:29 GMT, Amos Shi wrote: > Backport of [JDK-8315576](https://bugs.openjdk.org/browse/JDK-8315576) > - Changes on `CodeCacheFullCountTest.java` is `clean` > - Changes on `test/hotspot/jtreg/ProblemList-Xcomp.txt` has been ignored, because the line does not exist in `jdk17u-dev` > - `test/hotspot/jtreg/ProblemList-Xcomp.txt.rej` contents > > > @@ -27,8 +27,6 @@ > # > ############################################################################# > > -compiler/codecache/CodeCacheFullCountTest.java 8315576 generic-all > - > vmTestbase/nsk/jvmti/AttachOnDemand/attach020/TestDescription.java 8287324 generic-all > vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java 8205957 generic-all > vmTestbase/nsk/jvmti/SetFieldModificationWatch/setfmodw001/TestDescription.java 8205957 linux-x64,windows-x64 > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `CodeCacheFullCountTest.java`: Test results: passed: 1 > - Pipeline: > - Testing Machine: Looks like a clean backport from 21u. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2808#pullrequestreview-2241534458 From ashi at openjdk.org Fri Aug 16 00:40:52 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 00:40:52 GMT Subject: [jdk17u-dev] RFR: 8295087: Manual Test to Automated Test Conversion In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 12:54:45 GMT, Matthias Baesken wrote: >> Backport of [JDK-8295087](https://bugs.openjdk.org/browse/JDK-8295087) >> - This PR contains two commit >> - `Commit 1` is generated by git apply from original commit >> - `Commit 2` is adding the missing test case `InconsistentEntries.java`, which was originally added by [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779) >> >> Testing >> - Local: Test passed on `MacOS 14.5` on Apple M1 Max >> - `ExtDirs.java`: Test results: passed: 2 >> - `ExtDirsChange.java`: Test results: passed: 1 >> - `ExtDirsDefaultPolicy.java`: Test results: passed: 4 >> - `InconsistentEntries.java`: Test results: passed: 1 >> - Pipeline: >> - Linux, Windows - Passed >> - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) >> - Testing Machine: SAP nightlies Passed on `2024-08-07` >> - Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00 >> - java/lang/ClassLoader/ExtDirs.java: SUCCESSFUL GitHub ? - [20:37:45.782 -> 568 msec] >> - Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00 >> - sun/security/provider/PolicyParser/ExtDirsChange.java: SUCCESSFUL GitHub ? - [21:41:01.101 -> 364 msec] >> - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id0: SUCCESSFUL GitHub ? - [21:41:01.165 -> 39 msec] >> - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id1: SUCCESSFUL GitHub ? - [21:41:01.204 -> 309 msec] >> - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id2: SUCCESSFUL GitHub ? - [21:41:01.465 -> 309 msec] >> - sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java#id3: SUCCESSFUL GitHub ? - [21:41:01.513 -> 362 msec] >> - javax/crypto/CryptoPermissions/InconsistentEntries.java: SUCCESSFUL GitHub ? - [21:30:11.979 -> 4,379 msec] > > You add [test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java](https://github.com/openjdk/jdk17u-dev/pull/2774/files#diff-6921fd8e4c83f33bbb681d27e21f3e6d167036940bd09e42567a4039993c5e5f) with the test, > > But the JBS issue https://bugs.openjdk.org/browse/JDK-8286779 associated with this test is in jdk20 and it seems it was not backported to 17. > So is it really a good idea to backport the test ? Looks a bit inconsistent to me . Hi @MBaesken, The situation: In the original commit - https://github.com/openjdk/jdk/commit/a3693ccc617d06137a61050b34646e8a90ed3d7e#diff-6921fd8e4c83f33bbb681d27e21f3e6d167036940bd09e42567a4039993c5e5f - We have the file `test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java` modified - and this file was added by [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779) - via commit https://github.com/openjdk/jdk/commit/8f400b9aab57d0639721add2ba511bfc0459bd89#diff-6921fd8e4c83f33bbb681d27e21f3e6d167036940bd09e42567a4039993c5e5f In this situation, we have three options here: - Option 1. In current PR simply ignore the file `InconsistentEntries.java` - the benefit is: the PR looks cleaner - the side effect is: later if we need this test case, someone need to apply the `diff` again - Option 2. Backport the dependency Jira [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779), then backport [JDK-8295087](https://bugs.openjdk.org/browse/JDK-8295087) again - the benefit is: both Jira back ports would looks clean - the side effect is: the [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779) touches the file `src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java` - and do we want to Backport this code to `jdk17u-dev` ? currently [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779) is not in the scope - Option 3. Copy the `InconsistentEntries.java` together with current PR on [JDK-8295087](https://bugs.openjdk.org/browse/JDK-8295087) - the benefit is: we get an `de-facto` `clean` backport for [JDK-8295087](https://bugs.openjdk.org/browse/JDK-8295087) So - If you agree on this `Option 3`, please revisit and approve this PR - If you prefer `Option 2`, I will close this PR, and create two PRs, one for [JDK-8286779](https://bugs.openjdk.org/browse/JDK-8286779), after merged will create another PR for [JDK-8295087](https://bugs.openjdk.org/browse/JDK-8295087) - I do not like `Option 1`, because it brings trouble for later Thanks Amos A Happy Developer ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2774#issuecomment-2292514886 From serb at openjdk.org Fri Aug 16 00:56:51 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 16 Aug 2024 00:56:51 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:15:51 GMT, Aleksey Shipilev wrote: >> See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. >> >> This is a `git revert` of https://github.com/openjdk/jdk17u-dev/commit/b37df147b011b23b6c7474d726710e1478af7607. > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337684-revert-http-accept > - 8337684: [17/11u] Revert JDK-8163921 backport Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2775#pullrequestreview-2241582901 From ashi at openjdk.org Fri Aug 16 01:15:58 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 01:15:58 GMT Subject: [jdk17u-dev] RFR: 8302800: Augment NaN handling tests of FDLIBM methods In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 13:03:55 GMT, Matthias Baesken wrote: >> Backport of [JDK-8302800](https://bugs.openjdk.org/browse/JDK-8302800) >> - This PR contains two PR >> - `commit 1` is made by the `git apply` which is `clean` >> - `commit 2` adds the missing file `test/jdk/java/lang/Math/InverseTrigTests.java` currently does not exist in `jdk17u-dev`, it was originally added by [JDK-8302026](https://bugs.openjdk.org/browse/JDK-8302026) via [commit](https://github.com/openjdk/jdk/commit/3ba156082b73c4a8e9d890a57a42fb68df2bf98f) >> >> Testing >> - Local: Test passed on `MacOS 14.5` on Apple M1 Max >> - `CubeRootTests.java`: Test results: passed: 1 >> - `Expm1Tests.java`: Test results: passed: 1 >> - `HyperbolicTests.java`: Test results: passed: 1 >> - `Log10Tests.java`: Test results: passed: 1 >> - `Log1pTests.java`: Test results: passed: 1 >> - `Tests.java`: Not applicable: not a test >> - `InverseTrigTests.java`: Test results: passed: 1 >> - Pipeline: >> - Linux, Windows - Passed >> - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) >> - Testing Machine: SAP nightlies Passed on `2024-08-07` >> - Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00 >> - java/lang/Math/CubeRootTests.java: SUCCESSFUL GitHub ? - [20:41:53.428 -> 166 msec] >> - java/lang/Math/Expm1Tests.java: SUCCESSFUL GitHub ? - [20:41:54.175 -> 253 msec] >> - java/lang/Math/HyperbolicTests.java: SUCCESSFUL GitHub ? - [20:41:54.428 -> 307 msec] >> - java/lang/Math/Log10Tests.java: SUCCESSFUL GitHub ? - [20:41:55.238 -> 196 msec] >> - java/lang/Math/Log1pTests.java: SUCCESSFUL GitHub ? - [20:41:55.434 -> 202 msec] >> - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [20:41:55.038 -> 199 msec] > > JDK-8302026 which contains the 'missing' InverseTrigTests.java test was never backported to 17 so please check again that the test is really stable. Hi @MBaesken , FYI: we have monitored the test case for another week, so far so good, all passed: - Started at `2024-08-15 00:54:43+01:00` - Automated jtreg test: jtreg_jdk_tier1 - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [01:00:38.234 -> 578 msec] - Started at `2024-08-13 22:27:17+01:00` - Automated jtreg test: jtreg_jdk_tier1 - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [22:41:57.003 -> 3,551 msec] - Started at `2024-08-12 09:51:13+01:00` - Automated jtreg test: jtreg_jdk_tier1 - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [09:57:48.239 -> 119 msec] - Started at `2024-08-11 22:25:03+01:00` - Automated jtreg test: jtreg_jdk_tier1 - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [22:39:57.485 -> 454 msec] - Started at `2024-08-09 23:02:03+01:00` - Automated jtreg test: jtreg_jdk_tier1 - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [23:16:11.723 -> 577 msec] - Started at `2024-08-09 18:38:52+01:00` - Automated jtreg test: jtreg_jdk_tier1 - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [18:53:29.160 -> 515 msec] Regards Amos A Happy Developer ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2779#issuecomment-2292542371 From ashi at openjdk.org Fri Aug 16 03:48:27 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 03:48:27 GMT Subject: [jdk11u-dev] RFR: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen" Message-ID: <51RLW8HeekQTJnemJVsQqHluoE3Uz_X5kwz6HM3yUfc=.264a847a-e24d-484e-aed6-0d757545a56f@github.com> Backport of [JDK-8312140](https://bugs.openjdk.org/browse/JDK-8312140) ------------- Commit messages: - Backport 14193a049ebcbd3639962729c631293b8d3a9114 Manual merge - Backport 14193a049ebcbd3639962729c631293b8d3a9114 Changes: https://git.openjdk.org/jdk11u-dev/pull/2913/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2913&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314614 Stats: 106 lines in 15 files changed: 66 ins; 18 del; 22 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2913.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2913/head:pull/2913 PR: https://git.openjdk.org/jdk11u-dev/pull/2913 From ashi at openjdk.org Fri Aug 16 04:49:15 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 04:49:15 GMT Subject: [jdk17u-dev] RFR: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests Message-ID: <_Ne9O7MSmKIMrsEgOHLmyW70MW6cObBcHKLm5MqRIFc=.0ba170a9-5a05-42fb-959f-5c5305230ea7@github.com> Backport of [JDK-8284316](https://bugs.openjdk.org/browse/JDK-8284316) Testing - Local: Manual Test passed on `MacOS 14.6.1` on Apple M1 Max - `TestJProgressBarAccessibility.java`: Manual Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 6a7c023796b0f39f54d0335f4723c1f06ff0032d Changes: https://git.openjdk.org/jdk17u-dev/pull/2810/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2810&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284316 Stats: 236 lines in 4 files changed: 189 ins; 29 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2810.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2810/head:pull/2810 PR: https://git.openjdk.org/jdk17u-dev/pull/2810 From ashi at openjdk.org Fri Aug 16 05:07:17 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 05:07:17 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v2] In-Reply-To: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: <3EuQehrIfJDWXqHM3hgaaQmANs8kKmMciTf_3_EjWe0=.fa2ad2d8-0e30-4789-8b13-a4298f4dc7f6@github.com> > Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) > - This PR has two commits > - `commit 1`: the git apply result, which is `clean` > - `commit 2`: manually merge the following two `.rej` files > - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` > > Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > > > @@ -668,15 +670,21 @@ > > static void assertReductionArraysEquals(double[] r, double rc, double[] a, > FReductionOp f, FReductionAllOp fa) { > + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEquals(double[] r, double rc, double[] a, > + FReductionOp f, FReductionAllOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a)); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); > for (; i < a.length; i += SPECIES.length()) { > - Assert.assertEquals(r[i], f.apply(a, i)); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); > } > } catch (AssertionError e) { > - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); > - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > } > } > > @@ -690,15 +698,22 @@ > > static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > FReductionMaskedOp f, FReductionAllMaskedOp fa) { > + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > + FReductionMaskedOp f, FReductionAllMaskedOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a, mask)); > + Assert.assertEquals(rc, fa.apply(a, mask), Math.abs(rc * relativeError)); > ... Amos Shi has updated the pull request incrementally with one additional commit since the last revision: Fix based on review: move 2 lines to correct location ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2768/files - new: https://git.openjdk.org/jdk17u-dev/pull/2768/files/678979a6..23f5de96 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=00-01 Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2768.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2768/head:pull/2768 PR: https://git.openjdk.org/jdk17u-dev/pull/2768 From ashi at openjdk.org Fri Aug 16 05:07:17 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 05:07:17 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality In-Reply-To: References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: <6i05ZyBVlk8IdbxOXpIejhUrvZZxxJqQxnXRus3m1qQ=.77068343-26ca-4396-bb63-bbe43c6628ee@github.com> On Fri, 9 Aug 2024 08:27:05 GMT, Matthias Baesken wrote: >> Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) >> - This PR has two commits >> - `commit 1`: the git apply result, which is `clean` >> - `commit 2`: manually merge the following two `.rej` files >> - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` >> >> Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> >> >> @@ -668,15 +670,21 @@ >> >> static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> FReductionOp f, FReductionAllOp fa) { >> + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> + FReductionOp f, FReductionAllOp fa, >> + double relativeError) { >> int i = 0; >> try { >> - Assert.assertEquals(rc, fa.apply(a)); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); >> for (; i < a.length; i += SPECIES.length()) { >> - Assert.assertEquals(r[i], f.apply(a, i)); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); >> } >> } catch (AssertionError e) { >> - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); >> - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); >> } >> } >> >> @@ -690,15 +698,22 @@ >> >> static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> FReductionMaskedOp f, FReductionAllMaskedOp fa) { >> + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> + FReductionMaskedOp f, FReductionAllMaskedOp fa, >> + double relativeError) { >> int i = 0; >> try { >> - Assert.assertEquals(rc, fa.apply(a, mask))... > > In the original commit I see in [test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java](https://github.com/openjdk/jdk/commit/e6f23a90d4a53339a3c9c2b76fc5d317940e4472#diff-a1baf5cd2c3bc9046a703b75c78cdb1948a2ca10d84ac1428dee4b471f87546f) > > https://github.com/openjdk/jdk/commit/e6f23a90d4a53339a3c9c2b76fc5d317940e4472 > private static final double RELATIVE_ROUNDING_ERROR = (double)0.000001; > > Is it intentional that it is not in the backport ? Hi @MBaesken, Somehow the git `patch` command has put these two lines to the `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java` file at line `625-626` + 625 // for floating point reduction ops that may introduce rounding errors + 626 private static final double RELATIVE_ROUNDING_ERROR = (double)0.000001; ``` I will move them to earlier lines in respect to the original commit. Regards Amos A Happy Developer ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#issuecomment-2292812891 From ashi at openjdk.org Fri Aug 16 05:25:23 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 05:25:23 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v3] In-Reply-To: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: > Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) > - This PR has two commits > - `commit 1`: the git apply result, which is `clean` > - `commit 2`: manually merge the following two `.rej` files > - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` > > Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > > > @@ -668,15 +670,21 @@ > > static void assertReductionArraysEquals(double[] r, double rc, double[] a, > FReductionOp f, FReductionAllOp fa) { > + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEquals(double[] r, double rc, double[] a, > + FReductionOp f, FReductionAllOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a)); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); > for (; i < a.length; i += SPECIES.length()) { > - Assert.assertEquals(r[i], f.apply(a, i)); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); > } > } catch (AssertionError e) { > - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); > - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > } > } > > @@ -690,15 +698,22 @@ > > static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > FReductionMaskedOp f, FReductionAllMaskedOp fa) { > + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > + FReductionMaskedOp f, FReductionAllMaskedOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a, mask)); > + Assert.assertEquals(rc, fa.apply(a, mask), Math.abs(rc * relativeError)); > ... Amos Shi has updated the pull request incrementally with one additional commit since the last revision: Fix based on review: move 2 lines to correct location ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2768/files - new: https://git.openjdk.org/jdk17u-dev/pull/2768/files/23f5de96..7ffeb081 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=01-02 Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2768.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2768/head:pull/2768 PR: https://git.openjdk.org/jdk17u-dev/pull/2768 From ashi at openjdk.org Fri Aug 16 06:36:22 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 06:36:22 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v4] In-Reply-To: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: > Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) > - This PR has two commits > - `commit 1`: the git apply result, which is `clean` > - `commit 2`: manually merge the following two `.rej` files > - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` > - `commit 3,4`: Fix code postion > - `commit 5`: Add file `Unit-header.template` > > Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > > > @@ -668,15 +670,21 @@ > > static void assertReductionArraysEquals(double[] r, double rc, double[] a, > FReductionOp f, FReductionAllOp fa) { > + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEquals(double[] r, double rc, double[] a, > + FReductionOp f, FReductionAllOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a)); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); > for (; i < a.length; i += SPECIES.length()) { > - Assert.assertEquals(r[i], f.apply(a, i)); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); > } > } catch (AssertionError e) { > - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); > - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > } > } > > @@ -690,15 +698,22 @@ > > static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > FReductionMaskedOp f, FReductionAllMaskedOp fa) { > + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > + FReductionMaskedOp f, FReductionAllMaskedOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a, mask)); > + ... Amos Shi has updated the pull request incrementally with one additional commit since the last revision: Add file Unit-header.template ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2768/files - new: https://git.openjdk.org/jdk17u-dev/pull/2768/files/7ffeb081..1b6851e9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=02-03 Stats: 57 lines in 1 file changed: 57 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2768.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2768/head:pull/2768 PR: https://git.openjdk.org/jdk17u-dev/pull/2768 From ashi at openjdk.org Fri Aug 16 06:36:22 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 06:36:22 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v3] In-Reply-To: References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: <19C_pTfQ4F_QtpmJVJbL2x9xqoaehDeD-VQXAC9gt0o=.4570b4f2-54c2-466e-bca8-7a05726f9b75@github.com> On Fri, 16 Aug 2024 05:25:23 GMT, Amos Shi wrote: >> Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) >> - This PR has two commits >> - `commit 1`: the git apply result, which is `clean` >> - `commit 2`: manually merge the following two `.rej` files >> - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` >> - `commit 3,4`: Fix code postion >> - `commit 5`: Add file `Unit-header.template` >> >> Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> >> >> @@ -668,15 +670,21 @@ >> >> static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> FReductionOp f, FReductionAllOp fa) { >> + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> + FReductionOp f, FReductionAllOp fa, >> + double relativeError) { >> int i = 0; >> try { >> - Assert.assertEquals(rc, fa.apply(a)); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); >> for (; i < a.length; i += SPECIES.length()) { >> - Assert.assertEquals(r[i], f.apply(a, i)); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); >> } >> } catch (AssertionError e) { >> - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); >> - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); >> } >> } >> >> @@ -690,15 +698,22 @@ >> >> static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> FReductionMaskedOp f, FReductionAllMaskedOp fa) { >> + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> + FReductionMaskedOp f, FReductionAllMaskedOp fa, >> + double relativeError) { >> ... > > Amos Shi has updated the pull request incrementally with one additional commit since the last revision: > > Fix based on review: move 2 lines to correct location ### Update - Sending to test server to test again ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#issuecomment-2292905311 From mbaesken at openjdk.org Fri Aug 16 06:58:49 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Aug 2024 06:58:49 GMT Subject: [jdk17u-dev] RFR: 8295087: Manual Test to Automated Test Conversion In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 00:38:07 GMT, Amos Shi wrote: > If you agree on this Option 3, please revisit and approve this PR Not sure if including the test InconsistentEntries without the related src change from https://bugs.openjdk.org/browse/JDK-8286779 is a good idea. On the other hand, I wonder did the test InconsistentEntries work in our nightlies over some time without the src changes? Maybe we can ask Goetz what he prefers, he should be back soon. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2774#issuecomment-2292932356 From mbaesken at openjdk.org Fri Aug 16 07:11:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Aug 2024 07:11:50 GMT Subject: [jdk17u-dev] RFR: 8302800: Augment NaN handling tests of FDLIBM methods In-Reply-To: References: Message-ID: On Sat, 3 Aug 2024 00:04:48 GMT, Amos Shi wrote: > Backport of [JDK-8302800](https://bugs.openjdk.org/browse/JDK-8302800) > - This PR contains two PR > - `commit 1` is made by the `git apply` which is `clean` > - `commit 2` adds the missing file `test/jdk/java/lang/Math/InverseTrigTests.java` currently does not exist in `jdk17u-dev`, it was originally added by [JDK-8302026](https://bugs.openjdk.org/browse/JDK-8302026) via [commit](https://github.com/openjdk/jdk/commit/3ba156082b73c4a8e9d890a57a42fb68df2bf98f) > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `CubeRootTests.java`: Test results: passed: 1 > - `Expm1Tests.java`: Test results: passed: 1 > - `HyperbolicTests.java`: Test results: passed: 1 > - `Log10Tests.java`: Test results: passed: 1 > - `Log1pTests.java`: Test results: passed: 1 > - `Tests.java`: Not applicable: not a test > - `InverseTrigTests.java`: Test results: passed: 1 > - Pipeline: > - Linux, Windows - Passed > - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00 > - java/lang/Math/CubeRootTests.java: SUCCESSFUL GitHub ? - [20:41:53.428 -> 166 msec] > - java/lang/Math/Expm1Tests.java: SUCCESSFUL GitHub ? - [20:41:54.175 -> 253 msec] > - java/lang/Math/HyperbolicTests.java: SUCCESSFUL GitHub ? - [20:41:54.428 -> 307 msec] > - java/lang/Math/Log10Tests.java: SUCCESSFUL GitHub ? - [20:41:55.238 -> 196 msec] > - java/lang/Math/Log1pTests.java: SUCCESSFUL GitHub ? - [20:41:55.434 -> 202 msec] > - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [20:41:55.038 -> 199 msec] Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2779#pullrequestreview-2242067863 From syan at openjdk.org Fri Aug 16 08:27:57 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 08:27:57 GMT Subject: [jdk21u-dev] Integrated: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:05:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. > > This the prefixed backport of [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). > > Thanks! This pull request has now been integrated. Changeset: d85b7c1e Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/d85b7c1e6dafdf02fffb163d924c63710ec43660 Stats: 21 lines in 1 file changed: 15 ins; 1 del; 5 mod 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java Backport-of: f3bb3e21704dd47c6c5d5753ca5882520a538c06 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/915 From mdoerr at openjdk.org Fri Aug 16 08:52:55 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 16 Aug 2024 08:52:55 GMT Subject: [jdk21u-dev] RFR: 8310683: Refactor StandardCharset/standard.java to use JUnit In-Reply-To: <5UXUpT-ZhL3qxUpfriq7hiuP0uBjxzzkzUdGBOsv_yA=.1fb7d360-9afe-4151-accb-e637c47f3e31@github.com> References: <5UXUpT-ZhL3qxUpfriq7hiuP0uBjxzzkzUdGBOsv_yA=.1fb7d360-9afe-4151-accb-e637c47f3e31@github.com> Message-ID: On Thu, 8 Aug 2024 20:20:42 GMT, Amos Shi wrote: > Backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) > - This PR contains three commits > - `commit 1` is the `clean` backport of `Standard.java` file from [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047), which is the dependency of current PR [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) > - `commit 2` is the `clean` backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) original commit > - `commit 3` is fixing the compile error of the test case, to remove the charsets added by [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047) in Java 22 > > > /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:140: error: cannot find symbol > Arguments.of(StandardCharsets.UTF_32BE, "UTF-32BE"), > ^ > symbol: variable UTF_32BE > location: class StandardCharsets > /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:141: error: cannot find symbol > Arguments.of(StandardCharsets.UTF_32LE, "UTF-32LE"), > ^ > symbol: variable UTF_32LE > location: class StandardCharsets > /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:142: error: cannot find symbol > Arguments.of(StandardCharsets.UTF_32, "UTF-32") > ^ > symbol: variable UTF_32 > location: class StandardCharsets > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `Standard.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-15` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-15 04:34:01+01:00` > - java/nio/charset/StandardCharsets/Standard.java: SUCCESSFUL GitHub ? - [04:55:15.771 -> 1,774 msec] LGTM. Thanks for explaining your integration steps. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/903#pullrequestreview-2242250980 From mdoerr at openjdk.org Fri Aug 16 09:16:57 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 16 Aug 2024 09:16:57 GMT Subject: [jdk21u-dev] RFR: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension In-Reply-To: References: Message-ID: <_HMcIAJDfgY7P2CSu_3bLkJDaVj_y4vwCrnc1bRnPw0=.950c23c8-37b3-4acd-b25b-4637f36ad5fa@github.com> On Tue, 30 Jul 2024 06:19:13 GMT, Varada M wrote: > Hi all, > > This pull request contains a backport of commit [4b55fe57](https://github.com/openjdk/jdk/commit/4b55fe577701317e6570f045ed9fe28aa97fc7ea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 18 Apr 2024 and was reviewed by Stefan Karlsson and Martin Doerr. > > Thanks! This backport contains a part of https://github.com/openjdk/jdk/commit/3699666c9325b38d287e1d4d2576f8e3a662ae81. I think it is ok because it is only preprocessor stuff. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/876#pullrequestreview-2242292745 From syan at openjdk.org Fri Aug 16 09:21:58 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 09:21:58 GMT Subject: [jdk17u-dev] Integrated: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 00:42:40 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2c9f741d](https://github.com/openjdk/jdk21u-dev/commit/2c9f741d9ce27cd81e4ad9395a88af1b34a2ba77) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Matthias Baesken. > > Thanks! This pull request has now been integrated. Changeset: 5e0e2e3e Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/5e0e2e3ea928fbae02aacd264a7168f82b32c467 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native Backport-of: 2c9f741d9ce27cd81e4ad9395a88af1b34a2ba77 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2752 From syan at openjdk.org Fri Aug 16 09:21:58 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 09:21:58 GMT Subject: [jdk17u-dev] Integrated: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false" In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:15:50 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [48702345](https://github.com/openjdk/jdk/commit/4870234552d2c63c786641493794a87654b98b7b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 25 May 2023 and was reviewed by Markus Gr?nlund. > > This the one of the several prefixed backports of JDK-8323196. > > Thanks! This pull request has now been integrated. Changeset: 1f45ae8e Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/1f45ae8ec4ac47e73121f52eb97def830a0381c6 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false" Backport-of: 4870234552d2c63c786641493794a87654b98b7b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2796 From mdoerr at openjdk.org Fri Aug 16 09:40:52 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 16 Aug 2024 09:40:52 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v4] In-Reply-To: References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: On Fri, 16 Aug 2024 06:36:22 GMT, Amos Shi wrote: >> Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) >> - This PR has two commits >> - `commit 1`: the git apply result, which is `clean` >> - `commit 2`: manually merge the following two `.rej` files >> - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` >> - `commit 3,4`: Fix code postion >> - `commit 5`: Add file `Unit-header.template` >> >> Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> >> >> @@ -668,15 +670,21 @@ >> >> static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> FReductionOp f, FReductionAllOp fa) { >> + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> + FReductionOp f, FReductionAllOp fa, >> + double relativeError) { >> int i = 0; >> try { >> - Assert.assertEquals(rc, fa.apply(a)); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); >> for (; i < a.length; i += SPECIES.length()) { >> - Assert.assertEquals(r[i], f.apply(a, i)); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); >> } >> } catch (AssertionError e) { >> - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); >> - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); >> } >> } >> >> @@ -690,15 +698,22 @@ >> >> static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> FReductionMaskedOp f, FReductionAllMaskedOp fa) { >> + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> + FReductionMaskedOp f, FReductionAllMaskedOp fa, >> + double relativeError) { >> ... > > Amos Shi has updated the pull request incrementally with one additional commit since the last revision: > > Add file Unit-header.template Looks basically good. I only found a couple of formatting differences which should get removed. test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java line 612: > 610: } > 611: > 612: This empty line should not get removed. test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java line 612: > 610: } > 611: > 612: This empty line should not get removed. test/jdk/jdk/incubator/vector/templates/Unit-header.template line 184: > 182: Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > 183: } > 184: } 1 space too much. test/jdk/jdk/incubator/vector/templates/Unit-header.template line 228: > 226: Assert.assertEquals(r[i], f.apply(a, i, mask), Math.abs(r[i] * relativeError), "at index #" + i); > 227: } > 228: } 1 space too much. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2768#pullrequestreview-2242314518 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1719596433 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1719598000 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1719607476 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1719607685 From mbaesken at openjdk.org Fri Aug 16 09:43:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Aug 2024 09:43:21 GMT Subject: [jdk21u-dev] RFR: 8316895: SeenThread::print_action_queue called on a null pointer Message-ID: 8316895: SeenThread::print_action_queue called on a null pointer ------------- Commit messages: - Backport fd52be2a3c53912598afe600d680de77090f9f43 Changes: https://git.openjdk.org/jdk21u-dev/pull/927/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=927&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316895 Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/927.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/927/head:pull/927 PR: https://git.openjdk.org/jdk21u-dev/pull/927 From mbaesken at openjdk.org Fri Aug 16 10:06:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Aug 2024 10:06:22 GMT Subject: [jdk21u-dev] RFR: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage Message-ID: Backport of 8333149, diff in stride ------------- Commit messages: - Backport 43a2f17342af8f5bf1f5823df9fa0bf0bdfdfce2 Changes: https://git.openjdk.org/jdk21u-dev/pull/928/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=928&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333149 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/928.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/928/head:pull/928 PR: https://git.openjdk.org/jdk21u-dev/pull/928 From mbaesken at openjdk.org Fri Aug 16 10:18:18 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Aug 2024 10:18:18 GMT Subject: [jdk21u-dev] RFR: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' Message-ID: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' ------------- Commit messages: - Backport 8162832832ac6e8c17f942e718e309a3489e0da6 Changes: https://git.openjdk.org/jdk21u-dev/pull/929/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=929&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333354 Stats: 131 lines in 10 files changed: 50 ins; 64 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/929.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/929/head:pull/929 PR: https://git.openjdk.org/jdk21u-dev/pull/929 From mbaesken at openjdk.org Fri Aug 16 10:38:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Aug 2024 10:38:23 GMT Subject: [jdk23u] RFR: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero Message-ID: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero ------------- Commit messages: - Backport 34eea6a5fa27121bc0e9e8ace0894833d4a9f826 Changes: https://git.openjdk.org/jdk23u/pull/76/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=76&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333088 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/76.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/76/head:pull/76 PR: https://git.openjdk.org/jdk23u/pull/76 From mbaesken at openjdk.org Fri Aug 16 10:39:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Aug 2024 10:39:22 GMT Subject: [jdk21u-dev] RFR: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero Message-ID: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero ------------- Commit messages: - Backport 34eea6a5fa27121bc0e9e8ace0894833d4a9f826 Changes: https://git.openjdk.org/jdk21u-dev/pull/930/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=930&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333088 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/930.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/930/head:pull/930 PR: https://git.openjdk.org/jdk21u-dev/pull/930 From duke at openjdk.org Fri Aug 16 12:12:57 2024 From: duke at openjdk.org (duke) Date: Fri, 16 Aug 2024 12:12:57 GMT Subject: [jdk17u-dev] RFR: 8318089: Class space not marked as such with NMT when CDS is off In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 12:06:26 GMT, Andreas Steiner wrote: > 8318089: Class space not marked as such with NMT when CDS is off @ansteiner Your change (at version 88795d15348fa6ea3a5e855dc78aad677f904a9d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2794#issuecomment-2293393669 From asteiner at openjdk.org Fri Aug 16 12:18:51 2024 From: asteiner at openjdk.org (Andreas Steiner) Date: Fri, 16 Aug 2024 12:18:51 GMT Subject: [jdk17u-dev] Integrated: 8318089: Class space not marked as such with NMT when CDS is off In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 12:06:26 GMT, Andreas Steiner wrote: > 8318089: Class space not marked as such with NMT when CDS is off This pull request has now been integrated. Changeset: d90d0288 Author: Andreas Steiner Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/d90d028816577a486c93cc0586fae39ddc1f96ec Stats: 9 lines in 1 file changed: 3 ins; 6 del; 0 mod 8318089: Class space not marked as such with NMT when CDS is off Reviewed-by: stuefe Backport-of: c0e154c876e586660b36af6441cd178bc8ebab89 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2794 From robm at openjdk.org Fri Aug 16 13:14:31 2024 From: robm at openjdk.org (Rob McKenna) Date: Fri, 16 Aug 2024 13:14:31 GMT Subject: [jdk23u] RFR: Merge jdk:jdk23 Message-ID: Merge ------------- Commit messages: - Merge - 8337831: Remove EA from the JDK 23 version string with first RC promotion - 8337716: ByteBuffer hashCode implementations are inconsistent - 8337054: JDK 23 RDP2 L10n resource files update - 8334167: Test java/lang/instrument/NativeMethodPrefixApp.java timed out - 8335967: "text-decoration: none" does not work with "A" HTML tags The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk23u&pr=77&range=00.0 - jdk:jdk23: https://webrevs.openjdk.org/?repo=jdk23u&pr=77&range=00.1 Changes: https://git.openjdk.org/jdk23u/pull/77/files Stats: 341 lines in 16 files changed: 242 ins; 55 del; 44 mod Patch: https://git.openjdk.org/jdk23u/pull/77.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/77/head:pull/77 PR: https://git.openjdk.org/jdk23u/pull/77 From robm at openjdk.org Fri Aug 16 13:18:52 2024 From: robm at openjdk.org (Rob McKenna) Date: Fri, 16 Aug 2024 13:18:52 GMT Subject: [jdk23u] Integrated: Merge jdk:jdk23 In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 13:09:00 GMT, Rob McKenna wrote: > Merge This pull request has now been integrated. Changeset: 5098e8ce Author: Rob McKenna URL: https://git.openjdk.org/jdk23u/commit/5098e8cea7257f3a81a3472b2419ae7837094f61 Stats: 341 lines in 16 files changed: 242 ins; 55 del; 44 mod Merge ------------- PR: https://git.openjdk.org/jdk23u/pull/77 From syan at openjdk.org Fri Aug 16 14:15:56 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 14:15:56 GMT Subject: [jdk21u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:05:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. > > This the prefixed backport of [JDK-8323196](https://bugs.openjdk.org/browse/JDK-8323196). > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/915#issuecomment-2293588480 From syan at openjdk.org Fri Aug 16 14:20:54 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 14:20:54 GMT Subject: [jdk17u-dev] RFR: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false" In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 03:15:50 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [48702345](https://github.com/openjdk/jdk/commit/4870234552d2c63c786641493794a87654b98b7b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 25 May 2023 and was reviewed by Markus Gr?nlund. > > This the one of the several prefixed backports of JDK-8323196. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2796#issuecomment-2293597196 From syan at openjdk.org Fri Aug 16 14:32:20 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 14:32:20 GMT Subject: [jdk21u-dev] RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" Message-ID: Hi all, This pull request contains a backport of commit [fa7521b2](https://github.com/openjdk/jdk/commit/fa7521b29eef39aeecb307f239c6d16898085984) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Erik Gahlin on 24 Jun 2024 and was reviewed by Markus Gr?nlund. We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196. Clean backport , test fix only, no risk. Thanks! ------------- Commit messages: - Backport fa7521b29eef39aeecb307f239c6d16898085984 Changes: https://git.openjdk.org/jdk21u-dev/pull/931/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=931&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323196 Stats: 37 lines in 1 file changed: 16 ins; 0 del; 21 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/931.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/931/head:pull/931 PR: https://git.openjdk.org/jdk21u-dev/pull/931 From duke at openjdk.org Fri Aug 16 15:13:58 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 16 Aug 2024 15:13:58 GMT Subject: [jdk21u-dev] RFR: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist Message-ID: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> Clean backport of a performance fix, originally authored by @bplb and reviewed by @AlanBateman Test suites run on linux-x86_64-server-release: - [x] tier1 - [x] jdk/java/nio ------------- Commit messages: - Backport 51be857f3cafa23eb7cd73e5fe3db17e6d01684c Changes: https://git.openjdk.org/jdk21u-dev/pull/926/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=926&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322166 Stats: 126 lines in 6 files changed: 76 ins; 28 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/926.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/926/head:pull/926 PR: https://git.openjdk.org/jdk21u-dev/pull/926 From syan at openjdk.org Fri Aug 16 15:55:51 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 15:55:51 GMT Subject: [jdk21u-dev] RFR: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp In-Reply-To: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> References: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> Message-ID: On Wed, 14 Aug 2024 16:07:32 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [bf13a4e2](https://github.com/openjdk/jdk/commit/bf13a4e2819fa5bcb3e4f2281121d4e0b5535403) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by sunyaqi on 26 Feb 2024 and was reviewed by Brian Burkhalter. > > Thanks! The GHA test runner report maxos-x64 failure `Unexpected token '<', " Hi all, This pull request contains a backport of commit [af6c5854](https://github.com/openjdk/jdk21u-dev/commit/af6c5854235573a29b6b418e9f759e2564bca63a) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. The commit being backported was authored by Goetz Lindenmaier on 22 Apr 2024 and had no reviewers. The backport not clean because jdk17u-dev doesn't have `test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java`. Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low. Thanks! ------------- Commit messages: - Backport af6c5854235573a29b6b418e9f759e2564bca63a Changes: https://git.openjdk.org/jdk17u-dev/pull/2811/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2811&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327474 Stats: 190 lines in 10 files changed: 65 ins; 13 del; 112 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2811.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2811/head:pull/2811 PR: https://git.openjdk.org/jdk17u-dev/pull/2811 From syan at openjdk.org Fri Aug 16 16:14:57 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 16:14:57 GMT Subject: [jdk17u-dev] RFR: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 00:42:40 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2c9f741d](https://github.com/openjdk/jdk21u-dev/commit/2c9f741d9ce27cd81e4ad9395a88af1b34a2ba77) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Matthias Baesken. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2752#issuecomment-2293782384 From ashi at openjdk.org Fri Aug 16 17:11:52 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:11:52 GMT Subject: [jdk17u-dev] Integrated: 8325022: Incorrect error message on client authentication In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 00:44:15 GMT, Amos Shi wrote: > Backport of [JDK-8325022](https://bugs.openjdk.org/browse/JDK-8325022) > > Testing > - Local: > - Build passed on `MacOS 14.6.1` on Apple M1 Max > - No applicable test case > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-15` (No side effect found) This pull request has now been integrated. Changeset: 7b205d6c Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/7b205d6c7d77cb273c6109b29597aa88fa08a59f Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8325022: Incorrect error message on client authentication Backport-of: fe78c0f1911c9fdc1d30e23847d102748dfa2063 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2789 From ashi at openjdk.org Fri Aug 16 17:14:53 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:14:53 GMT Subject: [jdk21u-dev] Integrated: 8325022: Incorrect error message on client authentication In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 00:41:10 GMT, Amos Shi wrote: > Backport of [JDK-8325022](https://bugs.openjdk.org/browse/JDK-8325022) > > Testing > - Local: > - Build passed on `MacOS 14.6.1` on Apple M1 Max > - No applicable test case > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-14,15` (No side effect found) This pull request has now been integrated. Changeset: e7e92e0b Author: Amos Shi URL: https://git.openjdk.org/jdk21u-dev/commit/e7e92e0ba75a062b2b7397fd7eed589750b22f58 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8325022: Incorrect error message on client authentication Backport-of: fe78c0f1911c9fdc1d30e23847d102748dfa2063 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/905 From ashi at openjdk.org Fri Aug 16 17:16:51 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:16:51 GMT Subject: [jdk17u-dev] Integrated: 8314837: 5 compiled/codecache tests ignore VM flags In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 21:03:26 GMT, Amos Shi wrote: > Backport of [JDK-8314837](https://bugs.openjdk.org/browse/JDK-8314837) > - This PR has two commits > - `commit 1` generated by git patch, so it is `considered as Clean` > - `commit 2` is the manual merge of `test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java.rej`, content as bellow > > > @@ -54,7 +55,7 @@ > } > > public static void runTest() throws Throwable { > - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( > + ProcessBuilder pb = ProcessTools.createTestJvm( > "-XX:ReservedCodeCacheSize=2496k", "-XX:-UseCodeCacheFlushing", "-XX:-MethodFlushing", "CodeCacheFullCountTest", "WasteCodeCache"); > OutputAnalyzer oa = ProcessTools.executeProcess(pb); > // Ignore adapter creation failures > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `CheckCodeCacheInfo.java`: Test results: passed: 1 > - `CodeCacheFullCountTest.java`: Test results: passed: 1 > - `TestSegmentedCodeCacheOption.java`: Test results: passed: 1 > - `TestCodeHeapSizeOptions.java`: Test results: passed: 1 > - `TestPrintCodeCacheOption.java`: Test results: passed: 1 > - Pipeline: 1 failing (`macos-x64`) and 18 successful checks > - Testing Machine: SAP nightlies Passed on `2024-08-15` > - Automated jtreg test: `jtreg_hotspot_tier1`, Started at `2024-08-14 22:02:58+01:00` > - compiler/codecache/CheckCodeCacheInfo.java: `SUCCESSFUL` GitHub ? - [22:03:42.440 -> 1,493 msec] > - compiler/codecache/CodeCacheFullCountTest.java: `SUCCESSFUL` GitHub ? - [22:03:46.390 -> 6,931 msec] > - compiler/codecache/cli/TestSegmentedCodeCacheOption.java: `SUCCESSFUL` GitHub ? - [22:10:17.893 -> 1,271 msec] > - compiler/codecache/cli/codeheapsize/TestCodeHeapSizeOptions.java: `SUCCESSFUL` GitHub ? - [22:10:15.984 -> 8,110 msec] > - compiler/codecache/cli/printcodecache/TestPrintCodeCacheOption.java: `SUCCESSFUL` GitHub ? - [22:10:17.300 -> 2,223 msec] This pull request has now been integrated. Changeset: e291bfa5 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/e291bfa501cc37e9344e86ceb21354dcf27a08f3 Stats: 11 lines in 5 files changed: 4 ins; 2 del; 5 mod 8314837: 5 compiled/codecache tests ignore VM flags Backport-of: 2a11bc41baec20cf670393ff29689043ed2d2114 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2788 From ashi at openjdk.org Fri Aug 16 17:17:49 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:17:49 GMT Subject: [jdk21u-dev] Integrated: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic" In-Reply-To: <9gNSVk2yba0kDH1wd8UOTGVxkszrhIqXOFlfwrKq9T0=.f4c938d0-327d-4e69-9fc5-9662d5b819ed@github.com> References: <9gNSVk2yba0kDH1wd8UOTGVxkszrhIqXOFlfwrKq9T0=.f4c938d0-327d-4e69-9fc5-9662d5b819ed@github.com> Message-ID: On Thu, 8 Aug 2024 21:49:05 GMT, Amos Shi wrote: > Backport of [JDK-8317738](https://bugs.openjdk.org/browse/JDK-8317738) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `CodeCacheFullCountTest.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-15` > - Automated jtreg test: `jtreg_hotspot_tier1`, Started at `2024-08-15 02:12:39+01:00` > - compiler/codecache/CodeCacheFullCountTest.java: `SUCCESSFUL` GitHub ? - [02:13:19.170 -> 6,082 msec] This pull request has now been integrated. Changeset: 9b331b0c Author: Amos Shi URL: https://git.openjdk.org/jdk21u-dev/commit/9b331b0c1017ab66be1ba354e38b4e16a2208969 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic" Backport-of: 0fd807118c9b2cb8381b5c0f5d22d4e3451e8f10 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/904 From ashi at openjdk.org Fri Aug 16 17:18:59 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:18:59 GMT Subject: [jdk21u-dev] Integrated: 8310683: Refactor StandardCharset/standard.java to use JUnit In-Reply-To: <5UXUpT-ZhL3qxUpfriq7hiuP0uBjxzzkzUdGBOsv_yA=.1fb7d360-9afe-4151-accb-e637c47f3e31@github.com> References: <5UXUpT-ZhL3qxUpfriq7hiuP0uBjxzzkzUdGBOsv_yA=.1fb7d360-9afe-4151-accb-e637c47f3e31@github.com> Message-ID: On Thu, 8 Aug 2024 20:20:42 GMT, Amos Shi wrote: > Backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) > - This PR contains three commits > - `commit 1` is the `clean` backport of `Standard.java` file from [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047), which is the dependency of current PR [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) > - `commit 2` is the `clean` backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) original commit > - `commit 3` is fixing the compile error of the test case, to remove the charsets added by [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047) in Java 22 > > > /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:140: error: cannot find symbol > Arguments.of(StandardCharsets.UTF_32BE, "UTF-32BE"), > ^ > symbol: variable UTF_32BE > location: class StandardCharsets > /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:141: error: cannot find symbol > Arguments.of(StandardCharsets.UTF_32LE, "UTF-32LE"), > ^ > symbol: variable UTF_32LE > location: class StandardCharsets > /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:142: error: cannot find symbol > Arguments.of(StandardCharsets.UTF_32, "UTF-32") > ^ > symbol: variable UTF_32 > location: class StandardCharsets > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `Standard.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-15` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-15 04:34:01+01:00` > - java/nio/charset/StandardCharsets/Standard.java: SUCCESSFUL GitHub ? - [04:55:15.771 -> 1,774 msec] This pull request has now been integrated. Changeset: 4e84d4dc Author: Amos Shi URL: https://git.openjdk.org/jdk21u-dev/commit/4e84d4dc514192e4cdf8e2c7c474847832987ab9 Stats: 128 lines in 1 file changed: 49 ins; 28 del; 51 mod 8310683: Refactor StandardCharset/standard.java to use JUnit Reviewed-by: mdoerr Backport-of: d82ade354570a930d8282684a8ffd368c613defc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/903 From ashi at openjdk.org Fri Aug 16 17:22:52 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:22:52 GMT Subject: [jdk17u-dev] Integrated: 8320608: Many jtreg printing tests are missing the @printer keyword In-Reply-To: References: Message-ID: On Thu, 1 Aug 2024 22:33:02 GMT, Amos Shi wrote: > Backport of [JDK-8320608](https://bugs.openjdk.org/browse/JDK-8320608) > - This PR contains two commits > - `commit 1`: changes made by `git apply`, which is `clean` > - `commit 2`: manual merge the `test/jdk/TEST.ROOT.rej` > > Contents of `test/jdk/TEST.ROOT.rej` > > > @@ -9,17 +9,41 @@ > # should be taken to handle test failures of intermittent or > # randomness tests. > # > -# A "headful" test requires a graphical environment to meaningfully > -# run. Tests that are not headful are "headless". > -# A test flagged with key sound needs audio devices on the system, this > -# may be accompanied by the headful keyword since audio device access > +# A test flagged with cgroups uses cgroups. > +# > +# Notes on "client" keywords : headful sound printer multimon > +# =========================================================== > +# > +# These keywords are there to help with test selection so that > +# tests that need a particular resource can be selected to run on a system > +# with that resource. Conversely "!somekeyword" can be used to exclude tests > +# on a system without such a resource. > +# Caution: If you are always excluding tests using any of these keywords then you > +# are likely missing many important tests. > +# > +# "headful". A "headful" test requires a graphical environment to meaningfully run. > +# This does not have to mean a physical host, since a VM can be configured as headful. > +# Tests that are not headful are "headless". > +# Note: all manual tests are assumed to be headful and do not need the keyword. > +# > +# "printer". Not all tests of printing APIs require a printer, but many do. > +# So a "printer" test requires a printer to be installed to do anything meaningful. > +# Tests may not fail if there is none, instead just silently return. > +# But they also may legitimately throw an Exception depending on the test. > +# Also printer tests are not necessarily headful, but some are, and some are automated. > +# > +# "sound". Similarly, not all sound tests require audio devices, but many do. > +# A test flagged with key "sound" needs audio devices on the system. > +# Also they are not necessarily "headful", since they don't require a display etc. > +# But sometimes they may be accompanied by the headful keyword, since sound > # is often linked to access to desktop resources and headful systems are > # also more likely to have audio devices (ie meaning both input and output) > -# A test flagged with key "printer" requires a printer to succeed, else > -# throws a PrinterException or the like. > -# A test flagged with cg... This pull request has now been integrated. Changeset: d642a137 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/d642a137ef6a49be0cc486962bea6e9c821db597 Stats: 247 lines in 139 files changed: 140 ins; 23 del; 84 mod 8320608: Many jtreg printing tests are missing the @printer keyword Reviewed-by: mbaesken Backport-of: 76fea807071eee80a1e00aae7bc4784a6d35bf4b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2770 From ashi at openjdk.org Fri Aug 16 17:22:57 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:22:57 GMT Subject: [jdk17u-dev] Integrated: 8313256: Exclude failing multicast tests on AIX In-Reply-To: References: Message-ID: <3tuMhBADbDD_wlrhaf214JGKI21VaQLzDiLl8MOSrhc=.fa6d524b-bc81-42f4-ba01-1e5d6cd714ae@github.com> On Sat, 3 Aug 2024 01:59:45 GMT, Amos Shi wrote: > Backport of [JDK-8313256](https://bugs.openjdk.org/browse/JDK-8313256) > - This PR contains two commit > - `commit 1` is generated by git apply command, which is `clean` > - `commit 2` is the manual merge of the `test/jdk/ProblemList.txt.rej` file > > Contents of `test/jdk/ProblemList.txt.rej` > > > @@ -586,13 +587,16 @@ > > # jdk_net > > -java/net/MulticastSocket/NoLoopbackPackets.java 7122846 macosx-all > -java/net/MulticastSocket/SetLoopbackMode.java 7122846 macosx-all > +java/net/MulticastSocket/NoLoopbackPackets.java 7122846,8308807 macosx-all,aix-ppc64 > +java/net/MulticastSocket/SetLoopbackMode.java 7122846,8308807 macosx-all,aix-ppc64 > > -java/net/MulticastSocket/Test.java 7145658 macosx-all > +java/net/MulticastSocket/Test.java 7145658,8308807 macosx-all,aix-ppc64 > > java/net/ServerSocket/AcceptInheritHandle.java 8211854 aix-ppc64 > > +java/net/MulticastSocket/B6427403.java 8308807 aix-ppc64 > +java/net/MulticastSocket/SetOutgoingIf.java 8308807 aix-ppc64 > + > ############################################################################ > > # jdk_nio > > > Testing > - Local: Not applicable (`aix-ppc64`) > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier3, Started at 2024-08-06 22:04:38+01:00 > - sun/management/jdp/JdpDefaultsTest.java: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - sun/management/jdp/JdpJmxRemoteDynamicPortTest.java: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - sun/management/jdp/JdpSpecificAddressTest.java: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - sun/management/jdp/JdpOffTest.java: SUCCESSFUL GitHub ? - [22:20:33.777 -> 12,159 msec] > - Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00 > - java/net/MulticastSocket/NoLoopbackPackets.java: SKIPPED[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - java/net/MulticastSocket/SetLoopbackMode.java: SKIPPED[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > - java/net/MulticastSocket/Test.java: SKIPPED[Filter: jtregExcludeLis... This pull request has now been integrated. Changeset: dfc21bf6 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/dfc21bf6aaa39b3eca07cb1b19ec095a1007bdef Stats: 12 lines in 1 file changed: 6 ins; 0 del; 6 mod 8313256: Exclude failing multicast tests on AIX Reviewed-by: mbaesken Backport-of: 98a915a54ce62da7cebc1f0ab07dab276291a1d1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2780 From ashi at openjdk.org Fri Aug 16 17:23:50 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:23:50 GMT Subject: [jdk17u-dev] Integrated: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 21:59:40 GMT, Amos Shi wrote: > Backport of [JDK-8313674](https://bugs.openjdk.org/browse/JDK-8313674) > - Manually merged based original commit. Although `Unclean`, all code is in line with current latest code base. > > Testing > - Local: `(os.family == "linux")` > - `BlockDeviceSize.java`: Test results: passed: 1, on [WSL](https://ubuntu.com/desktop/wsl) based `Ubuntu Linux 22.04` > - see comments bellow by @Harry-Junhua-Huang > - Pipeline > - `Linux`, Windows - `Passed` > - MacOS - skipped > - Testing Machine: SAP nightlies skipped on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00 > - java/nio/channels/FileChannel/BlockDeviceSize.java: `SKIPPED` [Filter: Composite Filter - Filtered out by a composite filter.] GitHub ? - [0 msec] This pull request has now been integrated. Changeset: 698f0e37 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/698f0e37746bffe61fc59cd553d3582d0e004097 Stats: 38 lines in 1 file changed: 17 ins; 10 del; 11 mod 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices Reviewed-by: mbaesken Backport-of: e91492ab4333c61f39b50eb428fa932131a5b908 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2756 From ashi at openjdk.org Fri Aug 16 17:24:00 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 16 Aug 2024 17:24:00 GMT Subject: [jdk17u-dev] Integrated: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 23:18:18 GMT, Amos Shi wrote: > Backport of [JDK-8298596](https://bugs.openjdk.org/browse/JDK-8298596) > - The change on file `test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java` is `clean` > - The change on file `test/hotspot/jtreg/ProblemList-zgc.txt` has been **ignored**, because the line does not exist in `jdk17u-dev` > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `OneeFinalizerTest.java`: Test results: passed: 1 > - `PhantomReferenceEvilTest.java`: Test results: passed: 1 > - `PhantomReferenceTest.java`: Test results: passed: 1 > - `ReferencesGC.java`: Test results: passed: 1 > - `soft001.java`: Test results: passed: 1 > - `weak001.java`: Test results: passed: 1 > - `WeakReferenceGC.java`: Test results: passed: 1 > - Pipeline: > - Linux, Windows - Passed > - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_notstresshotspot_tier4, Started at 2024-08-06 23:51:31+01:00 > - vmTestbase/gc/gctests/OneeFinalizerTest/OneeFinalizerTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/PhantomReference/PhantomReferenceEvilTest/PhantomReferenceEvilTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/PhantomReference/PhantomReferenceTest/PhantomReferenceTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/SoftReference/soft001/soft001.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/WeakReference/weak001/weak001.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!stress)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - vmTestbase/gc/gctests/WeakRe... This pull request has now been integrated. Changeset: 25537e9c Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/25537e9cb269ac523856654bab1ec13e5e17ecfc Stats: 15 lines in 1 file changed: 12 ins; 2 del; 1 mod 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" Reviewed-by: mbaesken Backport-of: c3242ee452c25b5038283c68e65541122a10df0d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2778 From ashi at openjdk.org Sat Aug 17 02:49:34 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 02:49:34 GMT Subject: [jdk17u-dev] RFR: 8330814: Cleanups for KeepAliveCache tests Message-ID: <9d_WP3KuuW_bibAXvhtr5JgqXBHgxmHuO6G_H8tGMVw=.14f7df27-f341-4fa2-b6ea-bc4117dd9870@github.com> Backport of [JDK-8330814](https://bugs.openjdk.org/browse/JDK-8330814) - This PR has two commits - `commit 1` is a `clean` git patch from original commit - `commit 2` is fixing the following compile error ----------System.err:(8/634)---------- /Users/I048686/SAPDevelop/github.com/dev-8330814-17/test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java:73: error: no suitable method found for create(InetSocketAddress,int,String,SimpleHttpTransactionHandler) server = HttpServer.create(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0), 10, "/", new SimpleHttpTransactionHandler()); ^ method HttpServer.create() is not applicable (actual and formal argument lists differ in length) method HttpServer.create(InetSocketAddress,int) is not applicable (actual and formal argument lists differ in length) 1 error result: Failed. Compilation failed: Compilation failed Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `B5045306.java`: Test results: passed: 1 - `B8291637.java`: Test results: passed: 1 - `B8293562.java`: Test results: passed: 1 - `KeepAliveProperty.java`: Test results: passed: 1 - `KeepAliveTimerThread.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport a5005c87c4d5598eb54e9824105767d833f9660b Fix Compilation error - Backport a5005c87c4d5598eb54e9824105767d833f9660b Changes: https://git.openjdk.org/jdk17u-dev/pull/2813/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2813&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330814 Stats: 290 lines in 5 files changed: 113 ins; 69 del; 108 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2813.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2813/head:pull/2813 PR: https://git.openjdk.org/jdk17u-dev/pull/2813 From ashi at openjdk.org Sat Aug 17 03:43:27 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 03:43:27 GMT Subject: [jdk17u-dev] RFR: 8310683: Refactor StandardCharset/standard.java to use JUnit Message-ID: Backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `Standard.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 4e84d4dc514192e4cdf8e2c7c474847832987ab9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2814/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2814&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310683 Stats: 128 lines in 1 file changed: 49 ins; 28 del; 51 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2814.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2814/head:pull/2814 PR: https://git.openjdk.org/jdk17u-dev/pull/2814 From ashi at openjdk.org Sat Aug 17 04:11:29 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 04:11:29 GMT Subject: [jdk21u-dev] RFR: 8311644: Server should not send bad_certificate alert when the client does not send any certificates Message-ID: Backport of [JDK-8311644](https://bugs.openjdk.org/browse/JDK-8311644) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `CertMsgCheck.java`: Test results: passed: 1 - `CheckSessionContext.java`: Test results: passed: 1 - `LegacyDHEKeyExchange.java`: Test results: passed: 1 - `SigAlgosExtTestWithTLS12.java`: Test results: passed: 1 - `SigAlgosExtTestWithTLS13.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport f62b5789add23adda2634a1cfb80f48b4387be74 Changes: https://git.openjdk.org/jdk21u-dev/pull/932/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=932&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311644 Stats: 270 lines in 8 files changed: 191 ins; 24 del; 55 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/932.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/932/head:pull/932 PR: https://git.openjdk.org/jdk21u-dev/pull/932 From ashi at openjdk.org Sat Aug 17 06:58:24 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 06:58:24 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v5] In-Reply-To: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: > Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) > - This PR has two commits > - `commit 1`: the git apply result, which is `clean` > - `commit 2`: manually merge the following two `.rej` files > - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` > - `commit 3,4`: Fix code postion > - `commit 5`: Add file `Unit-header.template` > > Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > > > @@ -668,15 +670,21 @@ > > static void assertReductionArraysEquals(double[] r, double rc, double[] a, > FReductionOp f, FReductionAllOp fa) { > + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEquals(double[] r, double rc, double[] a, > + FReductionOp f, FReductionAllOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a)); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); > for (; i < a.length; i += SPECIES.length()) { > - Assert.assertEquals(r[i], f.apply(a, i)); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); > } > } catch (AssertionError e) { > - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); > - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > } > } > > @@ -690,15 +698,22 @@ > > static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > FReductionMaskedOp f, FReductionAllMaskedOp fa) { > + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > + FReductionMaskedOp f, FReductionAllMaskedOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a, mask)); > + ... Amos Shi has updated the pull request incrementally with one additional commit since the last revision: Fix based on review: space and new line ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2768/files - new: https://git.openjdk.org/jdk17u-dev/pull/2768/files/1b6851e9..a7ff7735 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=03-04 Stats: 3 lines in 3 files changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2768.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2768/head:pull/2768 PR: https://git.openjdk.org/jdk17u-dev/pull/2768 From ashi at openjdk.org Sat Aug 17 07:01:51 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 07:01:51 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v3] In-Reply-To: References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: On Fri, 16 Aug 2024 09:27:05 GMT, Martin Doerr wrote: >> Amos Shi has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix based on review: move 2 lines to correct location > > test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java line 612: > >> 610: >> 611: static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, >> 612: FTernMaskOp f) { > > This empty line should not get removed. Fixed. It is indeed there are 2 empty lines at https://github.com/openjdk/jdk/blob/e6f23a90d4a53339a3c9c2b76fc5d317940e4472/test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java#L720-L721 ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1720682505 From ashi at openjdk.org Sat Aug 17 07:11:07 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 07:11:07 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v6] In-Reply-To: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: > Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) > - This PR has two commits > - `commit 1`: the git apply result, which is `clean` > - `commit 2`: manually merge the following two `.rej` files > - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` > - `commit 3,4`: Fix code postion > - `commit 5`: Add file `Unit-header.template` > > Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > > > @@ -668,15 +670,21 @@ > > static void assertReductionArraysEquals(double[] r, double rc, double[] a, > FReductionOp f, FReductionAllOp fa) { > + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEquals(double[] r, double rc, double[] a, > + FReductionOp f, FReductionAllOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a)); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); > for (; i < a.length; i += SPECIES.length()) { > - Assert.assertEquals(r[i], f.apply(a, i)); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); > } > } catch (AssertionError e) { > - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); > - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > } > } > > @@ -690,15 +698,22 @@ > > static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > FReductionMaskedOp f, FReductionAllMaskedOp fa) { > + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > + FReductionMaskedOp f, FReductionAllMaskedOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a, mask)); > + ... Amos Shi has updated the pull request incrementally with one additional commit since the last revision: Fix based on review: space and new line ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2768/files - new: https://git.openjdk.org/jdk17u-dev/pull/2768/files/a7ff7735..2b9e3b34 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2768&range=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2768.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2768/head:pull/2768 PR: https://git.openjdk.org/jdk17u-dev/pull/2768 From ashi at openjdk.org Sat Aug 17 07:11:08 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 07:11:08 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v4] In-Reply-To: References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: On Fri, 16 Aug 2024 09:37:32 GMT, Martin Doerr wrote: >> Amos Shi has updated the pull request incrementally with one additional commit since the last revision: >> >> Add file Unit-header.template > > test/jdk/jdk/incubator/vector/templates/Unit-header.template line 184: > >> 182: Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); >> 183: } >> 184: } > > 1 space too much. Fixed. Extra space removed. > test/jdk/jdk/incubator/vector/templates/Unit-header.template line 228: > >> 226: Assert.assertEquals(r[i], f.apply(a, i, mask), Math.abs(r[i] * relativeError), "at index #" + i); >> 227: } >> 228: } > > 1 space too much. Fixed. 1 extra space removed. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1720686109 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1720688357 From ashi at openjdk.org Sat Aug 17 07:11:07 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 17 Aug 2024 07:11:07 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v3] In-Reply-To: References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: On Fri, 16 Aug 2024 09:28:28 GMT, Martin Doerr wrote: >> Amos Shi has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix based on review: move 2 lines to correct location > > test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java line 612: > >> 610: >> 611: static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, >> 612: FTernMaskOp f) { > > This empty line should not get removed. Fixed. Now it is in line with https://github.com/openjdk/jdk/blob/e6f23a90d4a53339a3c9c2b76fc5d317940e4472/test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java#L720-L721 ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1720685854 From mdoerr at openjdk.org Sun Aug 18 18:56:00 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Sun, 18 Aug 2024 18:56:00 GMT Subject: [jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v6] In-Reply-To: References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: <8HSyxe84ewRsJ1A4RkFZ-UoIZWTygMKEf4aKtfRujKo=.c31cccea-7b8b-4adf-bf3d-564774928caf@github.com> On Sat, 17 Aug 2024 07:11:07 GMT, Amos Shi wrote: >> Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) >> - This PR has two commits >> - `commit 1`: the git apply result, which is `clean` >> - `commit 2`: manually merge the following two `.rej` files >> - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` >> - `commit 3,4`: Fix code postion >> - `commit 5`: Add file `Unit-header.template` >> >> Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` >> >> >> @@ -668,15 +670,21 @@ >> >> static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> FReductionOp f, FReductionAllOp fa) { >> + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEquals(double[] r, double rc, double[] a, >> + FReductionOp f, FReductionAllOp fa, >> + double relativeError) { >> int i = 0; >> try { >> - Assert.assertEquals(rc, fa.apply(a)); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); >> for (; i < a.length; i += SPECIES.length()) { >> - Assert.assertEquals(r[i], f.apply(a, i)); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); >> } >> } catch (AssertionError e) { >> - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); >> - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); >> + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); >> + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); >> } >> } >> >> @@ -690,15 +698,22 @@ >> >> static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> FReductionMaskedOp f, FReductionAllMaskedOp fa) { >> + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); >> + } >> + >> + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, >> + FReductionMaskedOp f, FReductionAllMaskedOp fa, >> + double relativeError) { >> ... > > Amos Shi has updated the pull request incrementally with one additional commit since the last revision: > > Fix based on review: space and new line Thanks for the update! ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2768#pullrequestreview-2244379228 From varadam at openjdk.org Mon Aug 19 06:17:48 2024 From: varadam at openjdk.org (Varada M) Date: Mon, 19 Aug 2024 06:17:48 GMT Subject: [jdk21u-dev] RFR: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension In-Reply-To: References: Message-ID: <2a07mQUCUVAqZ0fKtsuC-d4x-aPlDDbjDmJTe676UUs=.2b785f0f-5327-434d-8bd3-9f1d10b55921@github.com> On Tue, 30 Jul 2024 06:19:13 GMT, Varada M wrote: > Hi all, > > This pull request contains a backport of commit [4b55fe57](https://github.com/openjdk/jdk/commit/4b55fe577701317e6570f045ed9fe28aa97fc7ea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 18 Apr 2024 and was reviewed by Stefan Karlsson and Martin Doerr. > > Thanks! Thank you ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/876#issuecomment-2295745479 From duke at openjdk.org Mon Aug 19 06:17:49 2024 From: duke at openjdk.org (duke) Date: Mon, 19 Aug 2024 06:17:49 GMT Subject: [jdk21u-dev] RFR: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension In-Reply-To: References: Message-ID: <4yY13FnziGqRsVBpI5rNjbN4hTL4WbPRmzcW7Y-0hRE=.632e5415-f79d-4037-ae23-2f8f74fb8b29@github.com> On Tue, 30 Jul 2024 06:19:13 GMT, Varada M wrote: > Hi all, > > This pull request contains a backport of commit [4b55fe57](https://github.com/openjdk/jdk/commit/4b55fe577701317e6570f045ed9fe28aa97fc7ea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 18 Apr 2024 and was reviewed by Stefan Karlsson and Martin Doerr. > > Thanks! @varada1110 Your change (at version a239d287f09885f239fb7562d3d1a828a473cb32) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/876#issuecomment-2295747116 From syan at openjdk.org Mon Aug 19 06:43:24 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 19 Aug 2024 06:43:24 GMT Subject: [jdk23u] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment Message-ID: Hi all, This pull request contains a backport of commit [2f7ba781](https://github.com/openjdk/jdk/commit/2f7ba781bf2e4e6d0fa658c19f86c6c05d60358a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 19 Aug 2024 and was reviewed by Jaikiran Pai. Thanks! ------------- Commit messages: - Backport 2f7ba781bf2e4e6d0fa658c19f86c6c05d60358a Changes: https://git.openjdk.org/jdk23u/pull/78/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=78&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335150 Stats: 18 lines in 1 file changed: 7 ins; 6 del; 5 mod Patch: https://git.openjdk.org/jdk23u/pull/78.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/78/head:pull/78 PR: https://git.openjdk.org/jdk23u/pull/78 From mbaesken at openjdk.org Mon Aug 19 07:20:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 19 Aug 2024 07:20:23 GMT Subject: [jdk21u-dev] RFR: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range Message-ID: <86Q4msjMBFafr9YN00zuRlt1zdx1-ag8xnkLDdJYsa4=.0497584a-ca19-4ecd-b2a7-374599556d0f@github.com> Backport of 8311306, diff in stride ------------- Commit messages: - Backport e1fd663f224909c09f2f6fab7ad20f7b7864b62b Changes: https://git.openjdk.org/jdk21u-dev/pull/933/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=933&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311306 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/933.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/933/head:pull/933 PR: https://git.openjdk.org/jdk21u-dev/pull/933 From mdoerr at openjdk.org Mon Aug 19 08:23:55 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 19 Aug 2024 08:23:55 GMT Subject: [jdk21u-dev] RFR: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 06:19:13 GMT, Varada M wrote: > Hi all, > > This pull request contains a backport of commit [4b55fe57](https://github.com/openjdk/jdk/commit/4b55fe577701317e6570f045ed9fe28aa97fc7ea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 18 Apr 2024 and was reviewed by Stefan Karlsson and Martin Doerr. > > Thanks! Can you enable the GHA pre-submit tests, please? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/876#issuecomment-2295960601 From shade at openjdk.org Mon Aug 19 11:22:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Aug 2024 11:22:53 GMT Subject: [jdk23u] Integrated: 8335007: Inline OopMapCache table In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 14:25:53 GMT, Aleksey Shipilev wrote: > Clean backport to improve OopMapCache. I actually want this change in 21u-dev, so I am backporting to 23u on its way there. The change is pretty simple, so there is only a little risk. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `tier{1,2,3}` This pull request has now been integrated. Changeset: 045c990a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/045c990aeb67e862639c6a2ca962c0975dc5d792 Stats: 17 lines in 2 files changed: 0 ins; 5 del; 12 mod 8335007: Inline OopMapCache table Backport-of: 50dd962b0d0fe36634d96dbbd9d94fbc34d9ff7f ------------- PR: https://git.openjdk.org/jdk23u/pull/64 From shade at openjdk.org Mon Aug 19 11:23:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Aug 2024 11:23:55 GMT Subject: [jdk23u] Integrated: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 10:57:03 GMT, Aleksey Shipilev wrote: > Clean backport to fix potential `CME` in `ReferencedKeyMap`. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk/internal/util java/lang/invoke` This pull request has now been integrated. Changeset: 2369d92f Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/2369d92f5f51a0f2aa290d9e5af9e12a3a2dc621 Stats: 11 lines in 1 file changed: 7 ins; 1 del; 3 mod 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException Backport-of: bfb75b96266f4c5840e2edea13f9aa2c801518cf ------------- PR: https://git.openjdk.org/jdk23u/pull/66 From shade at openjdk.org Mon Aug 19 15:23:08 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Aug 2024 15:23:08 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Tue, 13 Aug 2024 16:54:05 GMT, Xiaolong Peng wrote: > Hi, > This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. > It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. > This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: > > | Bug | Title | > | ----------- | ---------------------------------------------- | > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | > > > Best, > Xiaolong. > > > Additional tests: > - [x] hotspot_gc_shenandoah > - [x] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC Looks fine, with minor nit. src/hotspot/share/gc/shenandoah/shenandoahLock.cpp line 47: > 45: Thread* thread = Thread::current(); > 46: if (allow_block_for_safepoint && thread->is_Java_thread()) { > 47: contended_lock_internal(static_cast(thread)); The preferred style in older JDKs is `thread->as_Java_thread()`. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2797#pullrequestreview-2245837398 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#discussion_r1721963335 From xpeng at openjdk.org Mon Aug 19 15:29:29 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Mon, 19 Aug 2024 15:29:29 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2] In-Reply-To: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: > Hi, > This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. > It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. > This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: > > | Bug | Title | > | ----------- | ---------------------------------------------- | > | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | > | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | > | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | > | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | > > > Best, > Xiaolong. > > > Additional tests: > - [x] hotspot_gc_shenandoah > - [x] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: Use thread->as_Java_thread() instead of static_cast ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2797/files - new: https://git.openjdk.org/jdk17u-dev/pull/2797/files/9696c8a2..22086ff2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2797&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2797&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2797.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2797/head:pull/2797 PR: https://git.openjdk.org/jdk17u-dev/pull/2797 From xpeng at openjdk.org Mon Aug 19 15:29:29 2024 From: xpeng at openjdk.org (Xiaolong Peng) Date: Mon, 19 Aug 2024 15:29:29 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2] In-Reply-To: References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Mon, 19 Aug 2024 15:19:16 GMT, Aleksey Shipilev wrote: >> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: >> >> Use thread->as_Java_thread() instead of static_cast > > src/hotspot/share/gc/shenandoah/shenandoahLock.cpp line 47: > >> 45: Thread* thread = Thread::current(); >> 46: if (allow_block_for_safepoint && thread->is_Java_thread()) { >> 47: contended_lock_internal(static_cast(thread)); > > The preferred style in older JDKs is `thread->as_Java_thread()`. Thanks, I have updated code to use thread->as_Java_thread() instead. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#discussion_r1721974050 From shade at openjdk.org Mon Aug 19 15:35:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Aug 2024 15:35:55 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2] In-Reply-To: References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: On Mon, 19 Aug 2024 15:29:29 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. >> It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. >> This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: >> >> | Bug | Title | >> | ----------- | ---------------------------------------------- | >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | >> >> >> Best, >> Xiaolong. >> >> >> Additional tests: >> - [x] hotspot_gc_shenandoah >> - [x] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Use thread->as_Java_thread() instead of static_cast Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2797#pullrequestreview-2245870133 From serb at openjdk.org Mon Aug 19 19:44:28 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 19 Aug 2024 19:44:28 GMT Subject: [jdk11u-dev] RFR: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 Message-ID: Hi all, This pull request contains a backport of commit [1017a2c2](https://github.com/openjdk/jdk/commit/1017a2c2d7ae99e0076abcfaf5e730fec3cb9c6c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This backport contains a patch imported to openjdk/jdk from the lcms 2.14 library in advance. Unfortunately this backport was not pushed to the jdk11u-dev as is, and not as part of the lcms update to 2.14(see https://github.com/openjdk/jdk11u-dev/pull/1659) as a result the implementation of the lcms library in jdk11u-dev is incomplete. The patch is not clean, the change in the MTTransformReplacedProfile test is dropped, that test does not exist in the jdk11 and I have no plans to backport the patch which added that test. @GoeLin please take a look. ------------- Commit messages: - Backport 1017a2c2d7ae99e0076abcfaf5e730fec3cb9c6c Changes: https://git.openjdk.org/jdk11u-dev/pull/2914/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2914&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273135 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2914.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2914/head:pull/2914 PR: https://git.openjdk.org/jdk11u-dev/pull/2914 From szaldana at openjdk.org Mon Aug 19 20:10:23 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 19 Aug 2024 20:10:23 GMT Subject: [jdk21u-dev] RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect Message-ID: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> Hi all, This pull request contains a backport of commit [330e520c](https://github.com/openjdk/jdk/commit/330e520c1d42d3a9f3e187873dcd8ed7fd561aaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Fernando Guallini on 18 Jul 2024 and was reviewed by Bradford Wetmore, Matthew Donovan and Rajan Halade. Thanks! ------------- Commit messages: - Backport 330e520c1d42d3a9f3e187873dcd8ed7fd561aaf Changes: https://git.openjdk.org/jdk21u-dev/pull/934/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=934&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8028127 Stats: 96 lines in 1 file changed: 60 ins; 5 del; 31 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/934.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/934/head:pull/934 PR: https://git.openjdk.org/jdk21u-dev/pull/934 From phh at openjdk.org Mon Aug 19 20:10:57 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 19 Aug 2024 20:10:57 GMT Subject: [jdk11u-dev] RFR: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 In-Reply-To: References: Message-ID: <45-ynGGh2xaQwlvdXU8PtpFtavdHcyiExnGtFmVqxMY=.8dab38c0-8877-4815-b9bf-03757e575862@github.com> On Mon, 19 Aug 2024 16:55:58 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [1017a2c2](https://github.com/openjdk/jdk/commit/1017a2c2d7ae99e0076abcfaf5e730fec3cb9c6c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This backport contains a patch imported to openjdk/jdk from the lcms 2.14 library in advance. Unfortunately this backport was not pushed to the jdk11u-dev as is, and not as part of the lcms update to 2.14(see https://github.com/openjdk/jdk11u-dev/pull/1659) as a result the implementation of the lcms library in jdk11u-dev is incomplete. > > The patch is not clean, the change in the MTTransformReplacedProfile test is dropped, that test does not exist in the jdk11 and I have no plans to backport the patch which added that test. > > @GoeLin please take a look. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2914#pullrequestreview-2246368505 From szaldana at openjdk.org Mon Aug 19 21:25:00 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 19 Aug 2024 21:25:00 GMT Subject: [jdk17u-dev] RFR: 8273216: JCMD does not work across container boundaries with Podman Message-ID: Hi all, This pull request contains a backport of commit [9180d9a2](https://github.com/openjdk/jdk/commit/9180d9a2f990e71ca6ac9c14e55a21f7372929ac) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Severin Gehwolf on 30 Sep 2021 and was reviewed by Mikhailo Seledtsov and Harold Seigel. Thanks! ------------- Commit messages: - Backport 9180d9a2f990e71ca6ac9c14e55a21f7372929ac Changes: https://git.openjdk.org/jdk17u-dev/pull/2815/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2815&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273216 Stats: 105 lines in 1 file changed: 91 ins; 4 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2815.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2815/head:pull/2815 PR: https://git.openjdk.org/jdk17u-dev/pull/2815 From ashi at openjdk.org Mon Aug 19 23:28:56 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 19 Aug 2024 23:28:56 GMT Subject: [jdk21u-dev] RFR: 8311644: Server should not send bad_certificate alert when the client does not send any certificates In-Reply-To: References: Message-ID: <_tyapQ-jFzfoY8WT85lT0z_1RdbHUDgJYPF2vOFaefo=.bd42f3c0-b406-4a05-90af-ecb5272987fd@github.com> On Sat, 17 Aug 2024 04:05:35 GMT, Amos Shi wrote: > Backport of [JDK-8311644](https://bugs.openjdk.org/browse/JDK-8311644) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `CertMsgCheck.java`: Test results: passed: 1 > - `CheckSessionContext.java`: Test results: passed: 1 > - `LegacyDHEKeyExchange.java`: Test results: passed: 1 > - `SigAlgosExtTestWithTLS12.java`: Test results: passed: 1 > - `SigAlgosExtTestWithTLS13.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: Testing Machine note on `2024-08-18` - javax/net/ssl/SSLSession/`CertMsgCheck.jtr` - on `linuxaarch64` - on `linuxx86_64` - on `linuxppc64le` ----------System.err:(73/5183)---------- Server ready on port 34603 Client connected using port 32780 (write)client(SSLSocket[hostname=localhost, port=34603, Session(1724013817426|SSL_NULL_WITH_NULL_NULL)]): Hello javax.net.ssl.SSLHandshakeException: (certificate_required) Received fatal alert: certificate_required at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:130) at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:365) at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:287) at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:204) at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:172) at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1509) at java.base/sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1480) at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:1066) at java.base/sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:350) at java.base/sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:393) at java.base/sun.nio.cs.StreamDecoder.lockedRead(StreamDecoder.java:217) at java.base/sun.nio.cs.StreamDecoder.read(StreamDecoder.java:171) at java.base/java.io.InputStreamReader.read(InputStreamReader.java:188) at java.base/java.io.BufferedReader.fill(BufferedReader.java:160) at java.base/java.io.BufferedReader.implReadLine(BufferedReader.java:370) at java.base/java.io.BufferedReader.readLine(BufferedReader.java:347) at java.base/java.io.BufferedReader.readLine(BufferedReader.java:436) at TLSBase.read(TLSBase.java:82) at TLSBase$Client.read(TLSBase.java:351) at TLSBase$Client.connect(TLSBase.java:342) at TLSBase$Client.(TLSBase.java:328) at CertMsgCheck.main(CertMsgCheck.java:42) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:1583) javax.net.ssl.SSLHandshakeException: (certificate_required) Empty client certificate chain at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:130) at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:365) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:321) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:312) at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.onConsumeCertificate(CertificateMessage.java:1157) at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.consume(CertificateMessage.java:1144) at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:393) at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:476) at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:447) at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:201) at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:172) at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1506) at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1421) at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:455) at java.base/sun.security.ssl.SSLSocketImpl.ensureNegotiated(SSLSocketImpl.java:922) at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:1013) at java.base/sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:350) at java.base/sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:393) at java.base/sun.nio.cs.StreamDecoder.lockedRead(StreamDecoder.java:217) at java.base/sun.nio.cs.StreamDecoder.read(StreamDecoder.java:171) at java.base/java.io.InputStreamReader.read(InputStreamReader.java:188) at java.base/java.io.BufferedReader.fill(BufferedReader.java:160) at java.base/java.io.BufferedReader.implReadLine(BufferedReader.java:370) at java.base/java.io.BufferedReader.readLine(BufferedReader.java:347) at java.base/java.io.BufferedReader.readLine(BufferedReader.java:436) at TLSBase.read(TLSBase.java:82) at TLSBase$Server.lambda$new$0(TLSBase.java:178) at java.base/java.lang.Thread.run(Thread.java:1583) Server ready on port 34603 java.lang.Exception: Failed to find expected alert: certificate_required at CertMsgCheck.main(CertMsgCheck.java:56) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:1583) JavaTest Message: Test threw exception: java.lang.Exception: Failed to find expected alert: certificate_required JavaTest Message: shutting down test ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/932#issuecomment-2297684810 From duke at openjdk.org Mon Aug 19 23:47:54 2024 From: duke at openjdk.org (duke) Date: Mon, 19 Aug 2024 23:47:54 GMT Subject: [jdk23u] RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 09:41:11 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8335743. > It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. > I created the pull request https://github.com/openjdk/jdk23u/pull/60 which backports JDK-8336284. @tkiriyama Your change (at version 219d5c7f674bd229b48425000d91ed53fc62f04d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/59#issuecomment-2297703965 From duke at openjdk.org Tue Aug 20 06:47:34 2024 From: duke at openjdk.org (HempushpaSahu) Date: Tue, 20 Aug 2024 06:47:34 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts Message-ID: Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 ------------- Commit messages: - Backport OCSP 2836c34b64e4626e25c86a53e5bef2bf32f95d2e Changes: https://git.openjdk.org/jdk17u-dev/pull/2754/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2754&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8179502 Stats: 911 lines in 7 files changed: 794 ins; 25 del; 92 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2754.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2754/head:pull/2754 PR: https://git.openjdk.org/jdk17u-dev/pull/2754 From duke at openjdk.org Tue Aug 20 06:47:34 2024 From: duke at openjdk.org (HempushpaSahu) Date: Tue, 20 Aug 2024 06:47:34 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: On Wed, 31 Jul 2024 13:53:39 GMT, HempushpaSahu wrote: > Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. > OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. > > Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2754#issuecomment-2298054886 From mbaesken at openjdk.org Tue Aug 20 08:14:51 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 20 Aug 2024 08:14:51 GMT Subject: [jdk11u-dev] Integrated: 8334166: Enable binary check In-Reply-To: References: Message-ID: <-JN-JPEnsreQjCIjXdviJhhd11i8nATwCl_XXOerIe4=.532b7d1a-3151-4264-840a-74bc5e95dbde@github.com> On Wed, 14 Aug 2024 08:11:44 GMT, Matthias Baesken wrote: > 8334166: Enable binary check This pull request has now been integrated. Changeset: cd9e6cb5 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/cd9e6cb584bfeb232bcea7a642664cb6dd4424f3 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8334166: Enable binary check 8332008: Enable issuestitle check Reviewed-by: mdoerr Backport-of: 108c2e4986bfae9f6993ad03d926298b267cf523 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2907 From sgehwolf at openjdk.org Tue Aug 20 08:21:50 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 08:21:50 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:15:51 GMT, Aleksey Shipilev wrote: >> See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. >> >> This is a `git revert` of https://github.com/openjdk/jdk17u-dev/commit/b37df147b011b23b6c7474d726710e1478af7607. >> >> Additional testing: >> - [x] Linux AArch64 server fastdebug, `jdk_net` >> - [ ] Linux AArch64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337684-revert-http-accept > - 8337684: [17/11u] Revert JDK-8163921 backport I'm OK with this change. Do you plan on doing a more targeted fix for https://bugs.openjdk.org/browse/JDK-8163921 (e.g. by fixing the syntax error in the default accept header only)? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2775#issuecomment-2298257067 From amitkumar at openjdk.org Tue Aug 20 08:21:54 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 20 Aug 2024 08:21:54 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: <2rJTgF_Drc5f_0rCkwDuCAT-hUwCeuz8WTLeJYmJLiI=.d0ccc24d-af2e-443d-b1a1-c45fe7689b66@github.com> On Wed, 31 Jul 2024 13:53:39 GMT, HempushpaSahu wrote: > Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. > OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. > > Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 Please close this PR in favour of https://github.com/openjdk/jdk17u-dev/pull/2747 & enable test on your repo by going to the repo and then on actions. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2754#issuecomment-2298257401 From shade at openjdk.org Tue Aug 20 08:35:49 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 08:35:49 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 08:18:45 GMT, Severin Gehwolf wrote: > I'm OK with this change. Do you plan on doing a more targeted fix for https://bugs.openjdk.org/browse/JDK-8163921 (e.g. by fixing the syntax error in the default accept header only)? Not at this time. The far-reaching unintended consequences of the original fix tells me this is a fiddly piece of code, so we are a bit averse trying to do more things than necessary here. I think we just let JDK 11 and 17 be as they are, even though it leaves HTTP client de-jure non-compliant to RFC. Let applications first encounter any default policy change in JDK 21. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2775#issuecomment-2298288482 From shade at openjdk.org Tue Aug 20 08:53:50 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 08:53:50 GMT Subject: [jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2] In-Reply-To: References: <_qYiW6BDLjeMn_GDZuKj2Jaqr-Xle6k9scy-uQdrI1w=.5e9195a9-4c33-4ff4-817d-daa29d52f8b6@github.com> Message-ID: <0ArlKBfEujHBB74_0WgZkd_bAtqj3qzip8iqEQ9WPAQ=.8c0ac8d4-cdd1-43c5-9eba-4b17701829a2@github.com> On Mon, 19 Aug 2024 15:29:29 GMT, Xiaolong Peng wrote: >> Hi, >> This PR is a Backport of [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587): Shenandoah: ShenandoahLock should allow blocking in VM, the original commit was authored by Aleksey Shipilev on 21 Feb 2024 and was reviewed by Robbin Ehn and Roman Kennke, and already backported to jdk21. >> It is not a clean backport for JDK17 due to code style change(NULL -> nullptr) and thread header file and API changes. >> This is the first backport of a series of improvements for ShenandoahLock to improve contention issue which we I have seem in our customer's production load running with JDK17, here are the series of improvements I'm going to backport to JDK17: >> >> | Bug | Title | >> | ----------- | ---------------------------------------------- | >> | [JDK-8325587](https://bugs.openjdk.org/browse/JDK-8325587) | ShenandoahLock should allow blocking in VM | >> | [JDK-8331405](https://bugs.openjdk.org/browse/JDK-8331405) | Optimize ShenandoahLock with TTAS | >> | [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411) | Reconsider spinning duration in ShenandoahLock | >> | [JDK-8335904](https://bugs.openjdk.org/browse/JDK-8335904) | Fix invalid comment in ShenandoahLock | >> >> >> Best, >> Xiaolong. >> >> >> Additional tests: >> - [x] hotspot_gc_shenandoah >> - [x] Linux x86_64 server fastdebug, all passes with -XX:+UseShenandoahGC > > Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: > > Use thread->as_Java_thread() instead of static_cast I agree it is a good time to bring all 4 backports into JDK 17u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#issuecomment-2298324192 From varadam at openjdk.org Tue Aug 20 09:38:01 2024 From: varadam at openjdk.org (Varada M) Date: Tue, 20 Aug 2024 09:38:01 GMT Subject: [jdk21u-dev] RFR: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 06:19:13 GMT, Varada M wrote: > Hi all, > > This pull request contains a backport of commit [4b55fe57](https://github.com/openjdk/jdk/commit/4b55fe577701317e6570f045ed9fe28aa97fc7ea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 18 Apr 2024 and was reviewed by Stefan Karlsson and Martin Doerr. > > Thanks! Hi Martin, I enabled GHA and all checks have passed ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/876#issuecomment-2298414578 From andrewlu at openjdk.org Tue Aug 20 09:51:26 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 20 Aug 2024 09:51:26 GMT Subject: [jdk11u-dev] RFR: 8220673: Add test library support for determining platform IP support [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.25-oracle. > these tests are not clean, but all added code is clean > test/jdk/java/net/NetworkInterface/Test.java > test/jdk/java/net/Socket/CloseAvailable.java > test/jdk/java/net/Socket/HttpProxy.java > test/jdk/java/net/Socket/SetSoLinger.java > test/jdk/java/nio/channels/DatagramChannel/Disconnect.java > > this class is not exist, ignore, other classes are clean > test/jdk/java/nio/channels/etc/PrintSupportedOptions.java Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2910/files - new: https://git.openjdk.org/jdk11u-dev/pull/2910/files/20d6ea1a..11b6db11 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2910&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2910&range=00-01 Stats: 75 lines in 51 files changed: 21 ins; 1 del; 53 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2910.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2910/head:pull/2910 PR: https://git.openjdk.org/jdk11u-dev/pull/2910 From shade at openjdk.org Tue Aug 20 10:54:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 10:54:32 GMT Subject: [jdk23u] RFR: 8338286: GHA: Demote x86_32 to hotspot build only Message-ID: This should make GHAs cleaner for future backports. Additional testing: - [ ] GHA ------------- Commit messages: - Backport da7311bbe37c2b9632b117d52a77c659047820b7 Changes: https://git.openjdk.org/jdk23u/pull/79/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=79&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338286 Stats: 19 lines in 1 file changed: 1 ins; 11 del; 7 mod Patch: https://git.openjdk.org/jdk23u/pull/79.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/79/head:pull/79 PR: https://git.openjdk.org/jdk23u/pull/79 From shade at openjdk.org Tue Aug 20 11:01:25 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 11:01:25 GMT Subject: [jdk21u-dev] RFR: 8338286: GHA: Demote x86_32 to hotspot build only Message-ID: This should make GHAs cleaner and more efficient for future backports. Additional testing: - [ ] GHA ------------- Commit messages: - Backport da7311bbe37c2b9632b117d52a77c659047820b7 Changes: https://git.openjdk.org/jdk21u-dev/pull/935/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=935&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338286 Stats: 19 lines in 1 file changed: 1 ins; 11 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/935.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/935/head:pull/935 PR: https://git.openjdk.org/jdk21u-dev/pull/935 From varadam at openjdk.org Tue Aug 20 11:55:50 2024 From: varadam at openjdk.org (Varada M) Date: Tue, 20 Aug 2024 11:55:50 GMT Subject: [jdk21u-dev] Integrated: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 06:19:13 GMT, Varada M wrote: > Hi all, > > This pull request contains a backport of commit [4b55fe57](https://github.com/openjdk/jdk/commit/4b55fe577701317e6570f045ed9fe28aa97fc7ea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 18 Apr 2024 and was reviewed by Stefan Karlsson and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: fee20949 Author: Varada M Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/fee209491beb07c09119a81c78d86d455c79c58b Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension Reviewed-by: mdoerr Backport-of: 4b55fe577701317e6570f045ed9fe28aa97fc7ea ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/876 From shade at openjdk.org Tue Aug 20 12:10:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 12:10:09 GMT Subject: [jdk17u-dev] RFR: 8338286: GHA: Demote x86_32 to hotspot build only Message-ID: This should make GHAs cleaner and more efficient for future backports. This backport is a bit unclean: there was a minor conflict in `default` line, which does not include some platform builds that are present past JDK 17. Additional testing: - [ ] GHA ------------- Commit messages: - Backport da7311bbe37c2b9632b117d52a77c659047820b7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2816/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2816&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338286 Stats: 19 lines in 1 file changed: 1 ins; 11 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2816.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2816/head:pull/2816 PR: https://git.openjdk.org/jdk17u-dev/pull/2816 From mbaesken at openjdk.org Tue Aug 20 12:28:54 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 20 Aug 2024 12:28:54 GMT Subject: [jdk23u] Integrated: 8338110: Exclude Fingerprinter::do_type from ubsan checks In-Reply-To: References: Message-ID: <36vS2yMZ4JnyeeGIdBwbOuHR-NSQYhtVDyba-4wB03I=.82471db8-67e0-4747-a3f0-27dec52ccf08@github.com> On Thu, 15 Aug 2024 15:27:37 GMT, Matthias Baesken wrote: > 8338110: Exclude Fingerprinter::do_type from ubsan checks This pull request has now been integrated. Changeset: d03c704c Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/d03c704c9868aae3997810df874c9475156bcf0e Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8338110: Exclude Fingerprinter::do_type from ubsan checks Backport-of: 6a390147959e0fb88de6ee13204cff72cd910f09 ------------- PR: https://git.openjdk.org/jdk23u/pull/75 From mbaesken at openjdk.org Tue Aug 20 12:40:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 20 Aug 2024 12:40:50 GMT Subject: [jdk23u] Integrated: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 10:32:47 GMT, Matthias Baesken wrote: > 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero This pull request has now been integrated. Changeset: 0cf6cc3d Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/0cf6cc3d8408c36030d32bea222533e3d7254c43 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero Backport-of: 34eea6a5fa27121bc0e9e8ace0894833d4a9f826 ------------- PR: https://git.openjdk.org/jdk23u/pull/76 From shade at openjdk.org Tue Aug 20 12:54:57 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 12:54:57 GMT Subject: [jdk21u-dev] RFR: 8331572: Allow using OopMapCache outside of STW GC phases [v3] In-Reply-To: References: <49YutDmQvYgxmebaYPJSIGEVyHUVPP4Ok9ZdiohkYB8=.8b1a8a83-6d66-4700-a319-d9d77de734fe@github.com> Message-ID: On Thu, 8 Aug 2024 16:31:09 GMT, Aleksey Shipilev wrote: >> Unclean backport to improve GC and general stack walk performance when walking interpreted frames. >> >> This is one of few backports that gets `OopMapCache` behavior similar to mainline. This makes [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely. >> >> The point of uncleanliness comes from the way we hook up the cleanup notifications to Service Thread. In later JDKs, [JDK-8329488](https://bugs.openjdk.org/browse/JDK-8329488) made Service Thread wake up regularly to do various cleanups. In JDK 21, we still need to hook up the clean up to the "usual" place in safepoint epilog. >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8331572-oopmap-cache-all > - Backport 05ff3185edd25b381a97f6879f496e97b62dddc2 > - Merge branch 'master' into JDK-8331572-oopmap-cache-all > - Backport d999b81e7110751be402012e1ed41b3256f5895e Re-ran `all` tests with all GC combinations, and they are clean. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/610#issuecomment-2298786483 From shade at openjdk.org Tue Aug 20 12:54:58 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 12:54:58 GMT Subject: [jdk21u-dev] Integrated: 8331572: Allow using OopMapCache outside of STW GC phases In-Reply-To: <49YutDmQvYgxmebaYPJSIGEVyHUVPP4Ok9ZdiohkYB8=.8b1a8a83-6d66-4700-a319-d9d77de734fe@github.com> References: <49YutDmQvYgxmebaYPJSIGEVyHUVPP4Ok9ZdiohkYB8=.8b1a8a83-6d66-4700-a319-d9d77de734fe@github.com> Message-ID: On Tue, 28 May 2024 09:44:28 GMT, Aleksey Shipilev wrote: > Unclean backport to improve GC and general stack walk performance when walking interpreted frames. > > This is one of few backports that gets `OopMapCache` behavior similar to mainline. This makes [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely. > > The point of uncleanliness comes from the way we hook up the cleanup notifications to Service Thread. In later JDKs, [JDK-8329488](https://bugs.openjdk.org/browse/JDK-8329488) made Service Thread wake up regularly to do various cleanups. In JDK 21, we still need to hook up the clean up to the "usual" place in safepoint epilog. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` This pull request has now been integrated. Changeset: ed77abd4 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/ed77abd487b53c845b6242174a2928174f121143 Stats: 117 lines in 12 files changed: 75 ins; 14 del; 28 mod 8331572: Allow using OopMapCache outside of STW GC phases 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572 Reviewed-by: phh Backport-of: d999b81e7110751be402012e1ed41b3256f5895e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/610 From shade at openjdk.org Tue Aug 20 13:14:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Aug 2024 13:14:05 GMT Subject: [jdk21u-dev] RFR: 8335007: Inline OopMapCache table Message-ID: Almost clean backport to improve `OopMapCache` footprint and performance. The conflict is in copyright header years, bots still think this is clean. Additionally, this is one of few backports that gets `OopMapCache` behavior similar to mainline. This makes [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely. Additional testing: - [ ] Linux x86_64 server fastdebug, `all` ------------- Commit messages: - Backport 50dd962b0d0fe36634d96dbbd9d94fbc34d9ff7f Changes: https://git.openjdk.org/jdk21u-dev/pull/936/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=936&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335007 Stats: 17 lines in 2 files changed: 0 ins; 5 del; 12 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/936.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/936/head:pull/936 PR: https://git.openjdk.org/jdk21u-dev/pull/936 From mbaesken at openjdk.org Tue Aug 20 14:05:58 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 20 Aug 2024 14:05:58 GMT Subject: [jdk23u] Integrated: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 In-Reply-To: <5mXteZOI6S680knizgpGRoITEkAl5YAL0cOKazU4VCA=.d3130787-9134-475a-b7d0-0cee44b06f89@github.com> References: <5mXteZOI6S680knizgpGRoITEkAl5YAL0cOKazU4VCA=.d3130787-9134-475a-b7d0-0cee44b06f89@github.com> Message-ID: On Thu, 15 Aug 2024 07:12:27 GMT, Matthias Baesken wrote: > 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 This pull request has now been integrated. Changeset: a67b103b Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/a67b103bfe0a9b3616038cc3a3c0fef182dda288 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 Backport-of: 692f5cbdb9bd94f03e5f18ddf07d56fbb5c0d456 ------------- PR: https://git.openjdk.org/jdk23u/pull/74 From syan at openjdk.org Tue Aug 20 15:10:53 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 15:10:53 GMT Subject: [jdk23u] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 06:35:12 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2f7ba781](https://github.com/openjdk/jdk/commit/2f7ba781bf2e4e6d0fa658c19f86c6c05d60358a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Aug 2024 and was reviewed by Jaikiran Pai. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/78#issuecomment-2299093515 From duke at openjdk.org Tue Aug 20 15:10:53 2024 From: duke at openjdk.org (duke) Date: Tue, 20 Aug 2024 15:10:53 GMT Subject: [jdk23u] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 06:35:12 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2f7ba781](https://github.com/openjdk/jdk/commit/2f7ba781bf2e4e6d0fa658c19f86c6c05d60358a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Aug 2024 and was reviewed by Jaikiran Pai. > > Thanks! @sendaoYan Your change (at version 19be2dad9135f59b433cea1257e093dafc9407cd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/78#issuecomment-2299096845 From gcao at openjdk.org Tue Aug 20 15:31:05 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 20 Aug 2024 15:31:05 GMT Subject: [jdk21u-dev] RFR: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV Message-ID: <6vFptnpY5HR-ZhSDbo9lVv4KExAaySRX3vZHCTMQ3FI=.146a596c-c6a0-4332-8f5a-7ce4da4b3c73@github.com> Hi, at [JDK-8334078](https://bugs.openjdk.org/browse/JDK-8334078), modified the matching logic for the linux-riscv64 rvv test, here i would like to backport this to jdk21u-dev, to simplify the subsequent functionality and testing of the backport to jdk21u-dev. This is a risc-v specific change. Backport is clean, risk is low. ### Testing - [ ] Run tier1-3 tests on SOPHON SG2042 (fastdebug) ------------- Commit messages: - Backport 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV Changes: https://git.openjdk.org/jdk21u-dev/pull/937/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=937&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334078 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/937.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/937/head:pull/937 PR: https://git.openjdk.org/jdk21u-dev/pull/937 From phh at openjdk.org Tue Aug 20 15:42:51 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 Aug 2024 15:42:51 GMT Subject: [jdk17u-dev] RFR: 8338286: GHA: Demote x86_32 to hotspot build only In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 12:05:20 GMT, Aleksey Shipilev wrote: > This should make GHAs cleaner and more efficient for future backports. > > This backport is a bit unclean: there was a minor conflict in `default` line, which does not include some platform builds that are present past JDK 17. > > Additional testing: > - [ ] GHA Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2816#pullrequestreview-2248374756 From syan at openjdk.org Tue Aug 20 15:43:55 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 15:43:55 GMT Subject: [jdk23u] Integrated: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 06:35:12 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2f7ba781](https://github.com/openjdk/jdk/commit/2f7ba781bf2e4e6d0fa658c19f86c6c05d60358a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Aug 2024 and was reviewed by Jaikiran Pai. > > Thanks! This pull request has now been integrated. Changeset: 403fa376 Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/403fa3760f629873258447cc9aefa09f9a27e7a4 Stats: 18 lines in 1 file changed: 7 ins; 6 del; 5 mod 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment Backport-of: 2f7ba781bf2e4e6d0fa658c19f86c6c05d60358a ------------- PR: https://git.openjdk.org/jdk23u/pull/78 From duke at openjdk.org Tue Aug 20 15:58:58 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Tue, 20 Aug 2024 15:58:58 GMT Subject: [jdk23u] Integrated: 8335743: jhsdb jstack cannot print some information on the waiting thread In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 09:41:11 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8335743. > It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. > I created the pull request https://github.com/openjdk/jdk23u/pull/60 which backports JDK-8336284. This pull request has now been integrated. Changeset: a4dcbb3b Author: KIRIYAMA Takuya Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/a4dcbb3bc629a8f89ddd18a026fa557f0444c667 Stats: 25 lines in 4 files changed: 18 ins; 0 del; 7 mod 8335743: jhsdb jstack cannot print some information on the waiting thread Backport-of: d6c6847e32673d36a1958cefd1851ec9f3b1e2ad ------------- PR: https://git.openjdk.org/jdk23u/pull/59 From syan at openjdk.org Tue Aug 20 15:55:51 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 15:55:51 GMT Subject: [jdk23u] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 06:35:12 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [2f7ba781](https://github.com/openjdk/jdk/commit/2f7ba781bf2e4e6d0fa658c19f86c6c05d60358a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Aug 2024 and was reviewed by Jaikiran Pai. > > Thanks! Thanks for ths sponsor. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/78#issuecomment-2299191290 From duke at openjdk.org Tue Aug 20 16:06:26 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Tue, 20 Aug 2024 16:06:26 GMT Subject: [jdk23u] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request is the backport of JDK-8336284 . > It is clean. This change resolves a test failure introduced by JDK-8335743. > JDK-8335743 will be backported in https://github.com/openjdk/jdk23u/pull/59. > I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/60/files - new: https://git.openjdk.org/jdk23u/pull/60/files/8462a060..8462a060 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=60&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=60&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/60.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/60/head:pull/60 PR: https://git.openjdk.org/jdk23u/pull/60 From phh at openjdk.org Tue Aug 20 22:46:08 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 Aug 2024 22:46:08 GMT Subject: [jdk23u] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v2] In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 16:06:26 GMT, KIRIYAMA Takuya wrote: >> Hi all, >> This pull request is the backport of JDK-8336284 . >> It is clean. This change resolves a test failure introduced by JDK-8335743. >> JDK-8335743 will be backported in https://github.com/openjdk/jdk23u/pull/59. >> I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. > > KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Right, looks like this PR includes https://github.com/openjdk/jdk23u/pull/59. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/60#issuecomment-2299883122 From ashi at openjdk.org Wed Aug 21 00:05:22 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 00:05:22 GMT Subject: [jdk11u-dev] RFR: 8206440: Remove javac -source/-target 6 from jdk regression tests Message-ID: Backport of [JDK-8206440](https://bugs.openjdk.org/browse/JDK-8206440) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `OldenCompilingWithDefaults.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport d2de786263e01b2036609621268853b14a1f46c3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2915/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2915&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8206440 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2915.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2915/head:pull/2915 PR: https://git.openjdk.org/jdk11u-dev/pull/2915 From ashi at openjdk.org Wed Aug 21 00:19:35 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 00:19:35 GMT Subject: [jdk11u-dev] RFR: 8210338: Better output for GenerationTests.java Message-ID: Backport of [JDK-8210338](https://bugs.openjdk.org/browse/JDK-8210338) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `GenerationTests.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport a5f7028279d61313b2293bbac3eaba0c880a7430 Changes: https://git.openjdk.org/jdk11u-dev/pull/2916/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2916&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8210338 Stats: 13 lines in 1 file changed: 4 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2916.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2916/head:pull/2916 PR: https://git.openjdk.org/jdk11u-dev/pull/2916 From ashi at openjdk.org Wed Aug 21 00:32:23 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 00:32:23 GMT Subject: [jdk11u-dev] RFR: 8224081: SOCKS v4 tests require IPv4 Message-ID: <0PCaA37dhYcHBhDP5LQLoLQVw-NERKM5Oq5a6RJGSsg=.daf30e5e-61bb-46e2-8ebd-27abfa433d0a@github.com> Backport of [JDK-8224081](https://bugs.openjdk.org/browse/JDK-8224081) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `SocksProxyVersion.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport acad8d1d68c8c0ad5fc93b0d1c01197428a25bfe Changes: https://git.openjdk.org/jdk11u-dev/pull/2917/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2917&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8224081 Stats: 15 lines in 2 files changed: 6 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2917.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2917/head:pull/2917 PR: https://git.openjdk.org/jdk11u-dev/pull/2917 From ashi at openjdk.org Wed Aug 21 00:50:29 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 00:50:29 GMT Subject: [jdk11u-dev] RFR: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 Message-ID: <38IYoRPEjj1aqwGRuDD5-RkCwTzOEdgEVyW3Bne7jlM=.5d0c0ecc-9c44-479a-8295-9b7734777afa@github.com> Backport of [JDK-8225045](https://bugs.openjdk.org/browse/JDK-8225045) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `JInternalFrameIconTest.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport a483869a6a98ccf296763732a32894f6a39fff40 Manual merge - Backport a483869a6a98ccf296763732a32894f6a39fff40 Changes: https://git.openjdk.org/jdk11u-dev/pull/2918/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2918&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8225045 Stats: 13 lines in 2 files changed: 11 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2918.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2918/head:pull/2918 PR: https://git.openjdk.org/jdk11u-dev/pull/2918 From duke at openjdk.org Wed Aug 21 01:38:02 2024 From: duke at openjdk.org (duke) Date: Wed, 21 Aug 2024 01:38:02 GMT Subject: [jdk23u] RFR: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 01:54:31 GMT, Jiawei Tang wrote: > 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option @jia-wei-tang Your change (at version 872d2c10bf47d3618e3b418229b1f67b93a98395) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/73#issuecomment-2300062354 From syan at openjdk.org Wed Aug 21 03:59:42 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 03:59:42 GMT Subject: [jdk21u-dev] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment Message-ID: Hi all, This pull request contains a backport of commit [403fa376](https://github.com/openjdk/jdk23u/commit/403fa3760f629873258447cc9aefa09f9a27e7a4) from the [openjdk/jdk23u](https://git.openjdk.org/jdk23u) repository. The commit being backported was authored by SendaoYan on 20 Aug 2024 and had no reviewers. Make the test more robustness, test fix only, no risk. Thanks! ------------- Commit messages: - Backport 403fa3760f629873258447cc9aefa09f9a27e7a4 Changes: https://git.openjdk.org/jdk21u-dev/pull/938/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=938&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335150 Stats: 18 lines in 1 file changed: 7 ins; 6 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/938.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/938/head:pull/938 PR: https://git.openjdk.org/jdk21u-dev/pull/938 From duke at openjdk.org Wed Aug 21 05:37:32 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Wed, 21 Aug 2024 05:37:32 GMT Subject: [jdk23u] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v3] In-Reply-To: References: Message-ID: > Hi all, > This pull request is the backport of JDK-8336284 . > It is clean. This change resolves a test failure introduced by JDK-8335743. > JDK-8335743 will be backported in https://github.com/openjdk/jdk23u/pull/59. > I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge Master - 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 - 8335743: jhsdb jstack cannot print some information on the waiting thread ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/60/files - new: https://git.openjdk.org/jdk23u/pull/60/files/8462a060..4dc86c16 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=60&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=60&range=01-02 Stats: 10104 lines in 40 files changed: 9870 ins; 93 del; 141 mod Patch: https://git.openjdk.org/jdk23u/pull/60.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/60/head:pull/60 PR: https://git.openjdk.org/jdk23u/pull/60 From syan at openjdk.org Wed Aug 21 06:39:33 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 06:39:33 GMT Subject: [jdk23u] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... Message-ID: Hi all, This pull request contains a backport of commit [284671a1](https://github.com/openjdk/jdk/commit/284671a1e4fb5bfe15b20b7f41fc24415b1235ed) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Calvin Cheung on 8 Jul 2024 and was reviewed by Matias Saavedra Silva and Ioi Lam. Clean backport to make the test more robustness, test fix only, no risk. Thanks! ------------- Commit messages: - Backport 284671a1e4fb5bfe15b20b7f41fc24415b1235ed Changes: https://git.openjdk.org/jdk23u/pull/80/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=80&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335449 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/80.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/80/head:pull/80 PR: https://git.openjdk.org/jdk23u/pull/80 From syan at openjdk.org Wed Aug 21 07:57:38 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 07:57:38 GMT Subject: [jdk17u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags Message-ID: Hi all, This backport of https://github.com/openjdk/jdk/pull/16666 to jdk17u-dev, to make the test will support VM flags passed to jtreg, and a couple tests that ignore VM flags should use ProcessTools::createLimtiedTestJavaProcessBuilder and marks the test with @requires vm.flagless. Addiontial testing: - [ ] linux x64 whole jtreg tests - [ ] linux aarch64 whole jtreg tests ------------- Commit messages: - Backport 1588dd934ce4e00a060e329b80f721d894559597 Changes: https://git.openjdk.org/jdk17u-dev/pull/2817/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2817&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319567 Stats: 553 lines in 16 files changed: 126 ins; 278 del; 149 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2817.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2817/head:pull/2817 PR: https://git.openjdk.org/jdk17u-dev/pull/2817 From goetz at openjdk.org Wed Aug 21 08:05:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Aug 2024 08:05:03 GMT Subject: [jdk21u-dev] RFR: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 22:31:44 GMT, Daniel Hu wrote: > Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120) afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because [JDK-8310308](https://github.com/openjdk/jdk21u-dev/pull/29) has already backported a later fix to VectorLogicalOpIdentityTest.java; as all logic changes from this backport to the test are overwritten and the only other line change to the file represents an update to the copyright year, this test has been removed from this backport. > > Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change. Hi, I had a look at approving this. I don't understand why you omit the Copyright change to the 4th file. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/922#issuecomment-2301407033 From goetz at openjdk.org Wed Aug 21 08:20:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Aug 2024 08:20:15 GMT Subject: [jdk21u-dev] RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> References: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> Message-ID: On Mon, 19 Aug 2024 17:14:54 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [330e520c](https://github.com/openjdk/jdk/commit/330e520c1d42d3a9f3e187873dcd8ed7fd561aaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fernando Guallini on 18 Jul 2024 and was reviewed by Bradford Wetmore, Matthew Donovan and Rajan Halade. > > Thanks! Hi @SoniaZaldana , work on 21.0.6 will only start after next Wednesday. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/934#issuecomment-2301440919 From goetz at openjdk.org Wed Aug 21 08:30:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Aug 2024 08:30:17 GMT Subject: [jdk17u-dev] RFR: 8302800: Augment NaN handling tests of FDLIBM methods In-Reply-To: References: Message-ID: On Sat, 3 Aug 2024 00:04:48 GMT, Amos Shi wrote: > Backport of [JDK-8302800](https://bugs.openjdk.org/browse/JDK-8302800) > - This PR contains two PR > - `commit 1` is made by the `git apply` which is `clean` > - `commit 2` adds the missing file `test/jdk/java/lang/Math/InverseTrigTests.java` currently does not exist in `jdk17u-dev`, it was originally added by [JDK-8302026](https://bugs.openjdk.org/browse/JDK-8302026) via [commit](https://github.com/openjdk/jdk/commit/3ba156082b73c4a8e9d890a57a42fb68df2bf98f) > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `CubeRootTests.java`: Test results: passed: 1 > - `Expm1Tests.java`: Test results: passed: 1 > - `HyperbolicTests.java`: Test results: passed: 1 > - `Log10Tests.java`: Test results: passed: 1 > - `Log1pTests.java`: Test results: passed: 1 > - `Tests.java`: Not applicable: not a test > - `InverseTrigTests.java`: Test results: passed: 1 > - Pipeline: > - Linux, Windows - Passed > - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00 > - java/lang/Math/CubeRootTests.java: SUCCESSFUL GitHub ? - [20:41:53.428 -> 166 msec] > - java/lang/Math/Expm1Tests.java: SUCCESSFUL GitHub ? - [20:41:54.175 -> 253 msec] > - java/lang/Math/HyperbolicTests.java: SUCCESSFUL GitHub ? - [20:41:54.428 -> 307 msec] > - java/lang/Math/Log10Tests.java: SUCCESSFUL GitHub ? - [20:41:55.238 -> 196 msec] > - java/lang/Math/Log1pTests.java: SUCCESSFUL GitHub ? - [20:41:55.434 -> 202 msec] > - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [20:41:55.038 -> 199 msec] There are red tests, what is wrong? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2779#issuecomment-2301462947 From fyang at openjdk.org Wed Aug 21 08:30:06 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 21 Aug 2024 08:30:06 GMT Subject: [jdk21u-dev] RFR: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV In-Reply-To: <6vFptnpY5HR-ZhSDbo9lVv4KExAaySRX3vZHCTMQ3FI=.146a596c-c6a0-4332-8f5a-7ce4da4b3c73@github.com> References: <6vFptnpY5HR-ZhSDbo9lVv4KExAaySRX3vZHCTMQ3FI=.146a596c-c6a0-4332-8f5a-7ce4da4b3c73@github.com> Message-ID: On Tue, 20 Aug 2024 15:25:10 GMT, Gui Cao wrote: > Hi, at [JDK-8334078](https://bugs.openjdk.org/browse/JDK-8334078), modified the matching logic for the linux-riscv64 rvv test, here i would like to backport this to jdk21u-dev, to simplify the subsequent functionality and testing of the backport to jdk21u-dev. This is a risc-v specific change. Backport is clean, risk is low. > > ### Testing > - [ ] Run tier1-3 tests on SOPHON SG2042 (fastdebug) LGTM. Thanks. ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/937#pullrequestreview-2250140979 From goetz at openjdk.org Wed Aug 21 08:36:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Aug 2024 08:36:17 GMT Subject: [jdk11u-dev] RFR: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 10:34:00 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. There are red tests! What is wrong? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2908#issuecomment-2301473698 From syan at openjdk.org Wed Aug 21 08:43:03 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 08:43:03 GMT Subject: [jdk21u-dev] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 03:53:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [403fa376](https://github.com/openjdk/jdk23u/commit/403fa3760f629873258447cc9aefa09f9a27e7a4) from the [openjdk/jdk23u](https://git.openjdk.org/jdk23u) repository. > > The commit being backported was authored by SendaoYan on 20 Aug 2024 and had no reviewers. > > Make the test more robustness, test fix only, no risk. > > Thanks! Thanks for the approved. I will integrate this backport PR tomorrow. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/938#issuecomment-2301491461 From goetz at openjdk.org Wed Aug 21 08:43:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Aug 2024 08:43:12 GMT Subject: [jdk11u-dev] RFR: 8266161: mark hotspot compiler/rtm tests which ignore VM flags In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 06:01:33 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. There are red tests. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2911#issuecomment-2301490926 From goetz at openjdk.org Wed Aug 21 08:43:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Aug 2024 08:43:13 GMT Subject: [jdk11u-dev] RFR: 8209362: sun/security/ssl/SSLSocketImpl/ReuseAddr.java failed due to "BindException: Address already in use (Bind failed)" In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 08:09:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java > "protected volatile int serverPort = 0;" > "protected void doServerSide() throws Exception" > already protected, no need to change, make it clean. There are red tests. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2884#issuecomment-2301489818 From goetz at openjdk.org Wed Aug 21 08:44:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Aug 2024 08:44:10 GMT Subject: [jdk11u-dev] RFR: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 16:55:58 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [1017a2c2](https://github.com/openjdk/jdk/commit/1017a2c2d7ae99e0076abcfaf5e730fec3cb9c6c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This backport contains a patch imported to openjdk/jdk from the lcms 2.14 library in advance. Unfortunately this backport was not pushed to the jdk11u-dev as is, and not as part of the lcms update to 2.14(see https://github.com/openjdk/jdk11u-dev/pull/1659) as a result the implementation of the lcms library in jdk11u-dev is incomplete. > > The patch is not clean, the change in the MTTransformReplacedProfile test is dropped, that test does not exist in the jdk11 and I have no plans to backport the patch which added that test. > > @GoeLin please take a look. There are failed test. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2914#issuecomment-2301493021 From andrewlu at openjdk.org Wed Aug 21 09:00:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 09:00:12 GMT Subject: [jdk17u-dev] Integrated: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 10:34:16 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 61e0a111 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/61e0a11132d4d85986b9f5d91439cc6f28ca03c7 Stats: 62 lines in 1 file changed: 60 ins; 0 del; 2 mod 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java Backport-of: 0f77d250b67ae0678756f986607eb239641dfb9e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2802 From andrewlu at openjdk.org Wed Aug 21 09:00:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 09:00:16 GMT Subject: [jdk11u-dev] Integrated: 8316973: GC: Make TestDisableDefaultGC use createTestJvm In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 08:51:08 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. > jdk11 use '-XX:-UseZGC', not '-XX:-UseShenandoahGC', so not clean. This pull request has now been integrated. Changeset: cd4ae8cc Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/cd4ae8cc8983642f85648b4e33cd951e04c32320 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod 8316973: GC: Make TestDisableDefaultGC use createTestJvm Reviewed-by: mbaesken Backport-of: 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2904 From andrewlu at openjdk.org Wed Aug 21 09:01:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 09:01:07 GMT Subject: [jdk17u-dev] Integrated: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 10:33:49 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: d5d26be7 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/d5d26be717f5540de73e9d411d324f870d3d224b Stats: 45 lines in 1 file changed: 35 ins; 6 del; 4 mod 8315936: Parallelize gc/stress/TestStressG1Humongous.java test Backport-of: 3f19df685c342cef212305cca630331878a24e79 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2801 From andrewlu at openjdk.org Wed Aug 21 09:01:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 09:01:07 GMT Subject: [jdk17u-dev] Integrated: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 10:43:01 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 27c92b6d Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/27c92b6d50cf30bb08fe7829d4a3bce3f5b3f390 Stats: 32 lines in 1 file changed: 19 ins; 0 del; 13 mod 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram Backport-of: 49eb00da8dc66cff3ca430f06ab21357ee6180ef ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2804 From andrewlu at openjdk.org Wed Aug 21 09:01:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 09:01:17 GMT Subject: [jdk17u-dev] Integrated: 8303891: Speed up Zip64SizeTest using a small ZIP64 file In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 10:34:32 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 2e3ca314 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/2e3ca3149709f40996eac5fe96021cac259b29c2 Stats: 147 lines in 1 file changed: 75 ins; 10 del; 62 mod 8303891: Speed up Zip64SizeTest using a small ZIP64 file 8259866: two java.util tests failed with "IOException: There is not enough space on the disk" Backport-of: 842b895f093e15ecd8aa0153d712f5f81cf1cf67 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2803 From andrewlu at openjdk.org Wed Aug 21 09:01:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 09:01:17 GMT Subject: [jdk21u-dev] Integrated: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram In-Reply-To: References: Message-ID: <9V3LqDqi6nCHaOyC_B-dSHtNd1PYOB2SEUEXPlyp7Bk=.844a1765-6024-40b4-abe1-ab7abace15e5@github.com> On Wed, 14 Aug 2024 10:45:08 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: cd5ac19b Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/cd5ac19b4966741904314d42c6ee30ac1d9e0ca9 Stats: 32 lines in 1 file changed: 19 ins; 0 del; 13 mod 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram Backport-of: 49eb00da8dc66cff3ca430f06ab21357ee6180ef ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/919 From andrewlu at openjdk.org Wed Aug 21 08:58:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 08:58:09 GMT Subject: [jdk21u-dev] Integrated: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 06:18:52 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. > add added codes are clean, except line different. This pull request has now been integrated. Changeset: 4c86bf57 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/4c86bf5723f439d42855bac5669309c1aa4e2c1d Stats: 51 lines in 1 file changed: 19 ins; 17 del; 15 mod 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm Reviewed-by: phh Backport-of: d1af748ab470e1068d03a8f8bc1a7445eff721fa ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/923 From syan at openjdk.org Wed Aug 21 09:15:44 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 09:15:44 GMT Subject: [jdk17u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags [v2] In-Reply-To: References: Message-ID: > Hi all, > This backport of https://github.com/openjdk/jdk/pull/16666 to jdk17u-dev, to make the test will support VM flags passed to jtreg, and a couple tests that ignore VM flags should use ProcessTools::createLimtiedTestJavaProcessBuilder and marks the test with @requires vm.flagless. > > Addiontial testing: > > - [ ] linux x64 whole jtreg tests > - [ ] linux aarch64 whole jtreg tests SendaoYan has updated the pull request incrementally with one additional commit since the last revision: withdraw // create target releated 4 sentences ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2817/files - new: https://git.openjdk.org/jdk17u-dev/pull/2817/files/df2847b5..5edcea76 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2817&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2817&range=00-01 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2817.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2817/head:pull/2817 PR: https://git.openjdk.org/jdk17u-dev/pull/2817 From andrewlu at openjdk.org Wed Aug 21 09:26:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 21 Aug 2024 09:26:10 GMT Subject: [jdk11u-dev] RFR: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 08:33:15 GMT, Goetz Lindenmaier wrote: > There are red tests! What is wrong? Hi @GoeLin? the mac GHA test fail has failed for some time, seems all prs will fail. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2908#issuecomment-2301581954 From sgehwolf at openjdk.org Wed Aug 21 09:44:09 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 21 Aug 2024 09:44:09 GMT Subject: [jdk17u-dev] RFR: 8337684: [17/11u] Revert JDK-8163921 backport [v2] In-Reply-To: References: Message-ID: On Fri, 2 Aug 2024 13:15:51 GMT, Aleksey Shipilev wrote: >> See the issue for more discussion and rationale. This is the actual code change, should we decide to go forward. >> >> This is a `git revert` of https://github.com/openjdk/jdk17u-dev/commit/b37df147b011b23b6c7474d726710e1478af7607. >> >> Additional testing: >> - [x] Linux AArch64 server fastdebug, `jdk_net` >> - [x] Linux AArch64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8337684-revert-http-accept > - 8337684: [17/11u] Revert JDK-8163921 backport @GoeLin What's your take on this? If we revert, we should probably get it in soon. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2775#issuecomment-2301617580 From syan at openjdk.org Wed Aug 21 09:59:07 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 09:59:07 GMT Subject: [jdk17u-dev] Withdrawn: 8319567: Update java/lang/invoke tests to support vm flags In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 07:50:43 GMT, SendaoYan wrote: > Hi all, > This backport of https://github.com/openjdk/jdk/pull/16666 to jdk17u-dev, to make the test will support VM flags passed to jtreg, and a couple tests that ignore VM flags should use ProcessTools::createLimtiedTestJavaProcessBuilder and marks the test with @requires vm.flagless. > > Addiontial testing: > > - [ ] linux x64 whole jtreg tests > - [ ] linux aarch64 whole jtreg tests This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2817 From duke at openjdk.org Wed Aug 21 10:43:14 2024 From: duke at openjdk.org (duke) Date: Wed, 21 Aug 2024 10:43:14 GMT Subject: [jdk23u] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v3] In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 05:37:32 GMT, KIRIYAMA Takuya wrote: >> Hi all, >> This pull request is the backport of JDK-8336284 . >> It is clean. This change resolves a test failure introduced by JDK-8335743. >> JDK-8335743 will be backported in https://github.com/openjdk/jdk23u/pull/59. >> I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. > > KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge Master > - 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 > - 8335743: jhsdb jstack cannot print some information on the waiting thread @tkiriyama Your change (at version 4dc86c1645541a77150f4669aafc5b5a08c64829) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/60#issuecomment-2301736756 From duke at openjdk.org Wed Aug 21 10:51:09 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Wed, 21 Aug 2024 10:51:09 GMT Subject: [jdk23u] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v2] In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 22:43:22 GMT, Paul Hohensee wrote: >> KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. > > Right, looks like this PR includes https://github.com/openjdk/jdk23u/pull/59. @phohensee I merged the changes from the master branch into this PR. Would you sponsor it, please? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/60#issuecomment-2301753119 From szaldana at openjdk.org Wed Aug 21 13:11:16 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 21 Aug 2024 13:11:16 GMT Subject: [jdk21u-dev] RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: References: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> Message-ID: On Wed, 21 Aug 2024 08:16:58 GMT, Goetz Lindenmaier wrote: >> Hi all, >> >> This pull request contains a backport of commit [330e520c](https://github.com/openjdk/jdk/commit/330e520c1d42d3a9f3e187873dcd8ed7fd561aaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Fernando Guallini on 18 Jul 2024 and was reviewed by Bradford Wetmore, Matthew Donovan and Rajan Halade. >> >> Thanks! > > Hi @SoniaZaldana , work on 21.0.6 will only start after next Wednesday. Hi @GoeLin, sounds good. I might close this PR for now then since I'll be going on holiday at the end of this week. Cheers! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/934#issuecomment-2302015901 From szaldana at openjdk.org Wed Aug 21 13:11:16 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 21 Aug 2024 13:11:16 GMT Subject: [jdk21u-dev] Withdrawn: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect In-Reply-To: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> References: <43hz561PTsIN4ZqMvROzIm1AwZjYCdcLmBfaBTlrRKQ=.2b3ec82a-8ab3-4df9-973f-c328f25c8988@github.com> Message-ID: On Mon, 19 Aug 2024 17:14:54 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [330e520c](https://github.com/openjdk/jdk/commit/330e520c1d42d3a9f3e187873dcd8ed7fd561aaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fernando Guallini on 18 Jul 2024 and was reviewed by Bradford Wetmore, Matthew Donovan and Rajan Halade. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/934 From szaldana at openjdk.org Wed Aug 21 13:15:07 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 21 Aug 2024 13:15:07 GMT Subject: [jdk17u-dev] Integrated: 8273216: JCMD does not work across container boundaries with Podman In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 18:16:12 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [9180d9a2](https://github.com/openjdk/jdk/commit/9180d9a2f990e71ca6ac9c14e55a21f7372929ac) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Severin Gehwolf on 30 Sep 2021 and was reviewed by Mikhailo Seledtsov and Harold Seigel. > > Thanks! This pull request has now been integrated. Changeset: 6cbedd92 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk17u-dev/commit/6cbedd928985e9ddf8a370470c8ee9f4d5f0826b Stats: 105 lines in 1 file changed: 91 ins; 4 del; 10 mod 8273216: JCMD does not work across container boundaries with Podman Backport-of: 9180d9a2f990e71ca6ac9c14e55a21f7372929ac ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2815 From duke at openjdk.org Wed Aug 21 14:16:07 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Wed, 21 Aug 2024 14:16:07 GMT Subject: [jdk23u] Integrated: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 In-Reply-To: References: Message-ID: On Wed, 7 Aug 2024 10:37:48 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8336284 . > It is clean. This change resolves a test failure introduced by JDK-8335743. > JDK-8335743 will be backported in https://github.com/openjdk/jdk23u/pull/59. > I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. This pull request has now been integrated. Changeset: 5c32f21d Author: KIRIYAMA Takuya Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/5c32f21d236110efc471e8ac4914d7c2176fd265 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 Backport-of: 1fe3ada001e188754df5de00bf6804f028ad274b ------------- PR: https://git.openjdk.org/jdk23u/pull/60 From syan at openjdk.org Wed Aug 21 15:53:20 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 15:53:20 GMT Subject: [jdk21u-dev] RFR: 8338748: Test Disconnect.java compile error: cannot find symbol after JDK-8299813 Message-ID: Hi all, Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u. Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. ------------- Commit messages: - 8338748: Test java/nio/channels/DatagramChannel/Disconnect.java compile error: cannot find symbol InetAddress.ofLiteral after JDK-8299813 Changes: https://git.openjdk.org/jdk21u-dev/pull/939/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=939&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338748 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/939.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/939/head:pull/939 PR: https://git.openjdk.org/jdk21u-dev/pull/939 From duke at openjdk.org Wed Aug 21 16:05:03 2024 From: duke at openjdk.org (Daniel Hu) Date: Wed, 21 Aug 2024 16:05:03 GMT Subject: [jdk21u-dev] RFR: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 08:02:10 GMT, Goetz Lindenmaier wrote: > Hi, I had a look at approving this. I don't understand why you omit the Copyright change to the 4th file. Ah I assumed that since no other changes were being made to the file, that the Copyright year change should be omitted as well. I'll add it now ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/922#issuecomment-2302448324 From duke at openjdk.org Wed Aug 21 16:12:24 2024 From: duke at openjdk.org (Daniel Hu) Date: Wed, 21 Aug 2024 16:12:24 GMT Subject: [jdk21u-dev] RFR: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 [v2] In-Reply-To: References: Message-ID: > Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120) afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because [JDK-8310308](https://github.com/openjdk/jdk21u-dev/pull/29) has already backported a later fix to VectorLogicalOpIdentityTest.java; as all logic changes from this backport to the test are overwritten and the only other line change to the file represents an update to the copyright year, this test has been removed from this backport. > > Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change. Daniel Hu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Updated copyright year for VectorLogicalOpIdentityTest - Merge branch 'openjdk:master' into JDK-8309894 - Backport 60544f9088c11e4718a9cd77f21792c6ba387440 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/922/files - new: https://git.openjdk.org/jdk21u-dev/pull/922/files/fcaf9eb0..2172e385 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=922&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=922&range=00-01 Stats: 434 lines in 23 files changed: 236 ins; 67 del; 131 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/922.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/922/head:pull/922 PR: https://git.openjdk.org/jdk21u-dev/pull/922 From shade at openjdk.org Wed Aug 21 17:30:16 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 21 Aug 2024 17:30:16 GMT Subject: [jdk23u] RFR: 8334229: Optimize InterpreterOopMap layout Message-ID: <8Wz03YoeGv51nc4Zl3uTsPo5FM1Frlda8Rub7M_5QXw=.d2ecc0a5-5814-4938-8890-a0d4fc202439@github.com> Semi-clean backport to improve OopMapCache. I actually want this change in 21u-dev, so I am backporting to 23u on its way there. The change is pretty simple, so there is only a little risk. It is different from mainline change, because [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) went into 23u first. It removes one of the definitions we move: https://github.com/openjdk/jdk/commit/7ab96c74e2c39f430a5c2f65a981da7314a2385b#diff-d47427bcae3d32d55540df020532bf223ed3cdc6496c3277068e0125fa7be22cL91-L93 Applying this backport yields no difference in `oopMapCache.hpp` with mainline version, which is what we want. Additional testing: - [ ] Confirm `pahole` improvements ------------- Commit messages: - Backport fac74b118f5fda4ec297e46238d34ce5b9be1e21 Changes: https://git.openjdk.org/jdk23u/pull/81/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=81&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334229 Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/81.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/81/head:pull/81 PR: https://git.openjdk.org/jdk23u/pull/81 From serb at openjdk.org Wed Aug 21 17:40:16 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 17:40:16 GMT Subject: [jdk11u-dev] RFR: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 In-Reply-To: References: Message-ID: <-Du8XMNNSw1qrCN0uiDWxOodN4fWYYyfmLtPfvLQqog=.68b163da-76c5-472f-b93d-f3a34d3e77ff@github.com> On Wed, 21 Aug 2024 08:41:45 GMT, Goetz Lindenmaier wrote: > There are failed test. There are no failed tests, but broken builds on macos due to deprecated '[sprintf](https://github.com/openjdk/jdk11u-dev/pull/2849)'. same problem exists in all recent PRs for jdk11u-dev. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2914#issuecomment-2302623870 From phh at openjdk.org Wed Aug 21 19:13:09 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Aug 2024 19:13:09 GMT Subject: [jdk21u-dev] RFR: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 [v2] In-Reply-To: References: Message-ID: <1-s62BvBwEyFpcTnCVOQTXFY5DjYx8dMjYNII03n9AQ=.ec1eb584-06a3-45f0-be71-63d8c6a7b962@github.com> On Wed, 21 Aug 2024 16:12:24 GMT, Daniel Hu wrote: >> Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120) afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because [JDK-8310308](https://github.com/openjdk/jdk21u-dev/pull/29) has already backported a later fix to VectorLogicalOpIdentityTest.java; as all logic changes from this backport to the test are overwritten and the only other line change to the file represents an update to the copyright year, this test has been removed from this backport. >> >> Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change. > > Daniel Hu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Updated copyright year for VectorLogicalOpIdentityTest > - Merge branch 'openjdk:master' into JDK-8309894 > - Backport 60544f9088c11e4718a9cd77f21792c6ba387440 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/922#pullrequestreview-2251729211 From phh at openjdk.org Wed Aug 21 21:08:07 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Aug 2024 21:08:07 GMT Subject: [jdk23u] RFR: 8334229: Optimize InterpreterOopMap layout In-Reply-To: <8Wz03YoeGv51nc4Zl3uTsPo5FM1Frlda8Rub7M_5QXw=.d2ecc0a5-5814-4938-8890-a0d4fc202439@github.com> References: <8Wz03YoeGv51nc4Zl3uTsPo5FM1Frlda8Rub7M_5QXw=.d2ecc0a5-5814-4938-8890-a0d4fc202439@github.com> Message-ID: On Wed, 21 Aug 2024 17:25:05 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve OopMapCache. I actually want this change in 21u-dev, so I am backporting to 23u on its way there. The change is pretty simple, so there is only a little risk. > > It is different from mainline change, because [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) went into 23u first. It removes one of the definitions we move: https://github.com/openjdk/jdk/commit/7ab96c74e2c39f430a5c2f65a981da7314a2385b#diff-d47427bcae3d32d55540df020532bf223ed3cdc6496c3277068e0125fa7be22cL91-L93 > > Applying this backport yields no difference in `oopMapCache.hpp` with mainline version, which is what we want. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk23u/pull/81#pullrequestreview-2251943249 From bulasevich at openjdk.org Wed Aug 21 21:36:21 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Wed, 21 Aug 2024 21:36:21 GMT Subject: [jdk21u-dev] RFR: 8321308: AArch64: Fix matching predication for cbz/cbnz Message-ID: <6ZbthRNyFF-b9jXEweyrQqAjh_-PT2cSLJ7HQ2mv38c=.56d099f5-a4b5-42d8-a70c-eb46a3421852@github.com> Clean backport to improve aarch code generation for array length `if (a.length > 0)` Testing: jtreg tier1-3 on linux-aarch64. ------------- Commit messages: - Backport 2c9185eb81c9dfcc30d160a6254089c474b56b0d Changes: https://git.openjdk.org/jdk21u-dev/pull/940/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=940&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321308 Stats: 131 lines in 3 files changed: 116 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/940.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/940/head:pull/940 PR: https://git.openjdk.org/jdk21u-dev/pull/940 From bulasevich at openjdk.org Wed Aug 21 22:05:15 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Wed, 21 Aug 2024 22:05:15 GMT Subject: [jdk21u-dev] RFR: 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result Message-ID: This is a clean backport to avoid a potentially rscratch1 register clobbering in C2_MacroAssembler::fast_lock. Testing: jtreg tier1-3 on linux-aarch64. ------------- Commit messages: - Backport 387504c9e4b93d162dcef7c90c57c27295858d2e Changes: https://git.openjdk.org/jdk21u-dev/pull/941/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=941&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317575 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/941.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/941/head:pull/941 PR: https://git.openjdk.org/jdk21u-dev/pull/941 From ashi at openjdk.org Wed Aug 21 23:21:09 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 23:21:09 GMT Subject: [jdk17u-dev] Integrated: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests In-Reply-To: <_Ne9O7MSmKIMrsEgOHLmyW70MW6cObBcHKLm5MqRIFc=.0ba170a9-5a05-42fb-959f-5c5305230ea7@github.com> References: <_Ne9O7MSmKIMrsEgOHLmyW70MW6cObBcHKLm5MqRIFc=.0ba170a9-5a05-42fb-959f-5c5305230ea7@github.com> Message-ID: <6sVf5T32m6qiwiK1a7tW4EOjqp22q4M9_nfKuWPL1yM=.a8961ec9-5502-40d2-a675-2ee348233f63@github.com> On Fri, 16 Aug 2024 04:45:22 GMT, Amos Shi wrote: > Backport of [JDK-8284316](https://bugs.openjdk.org/browse/JDK-8284316) > > Testing > - Local: Manual Test passed on `MacOS 14.6.1` on Apple M1 Max > - `TestJProgressBarAccessibility.java`: **Manual** Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies `SKIPPED` on `2024-08-17` > - Automated jtreg test: `jtreg_jdk_tier4`, Started at `2024-08-16 23:03:14+01:00` > - javax/accessibility/manual/TestJProgressBarAccessibility.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!printer)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - Note. **manual** test cannot be executed in testing server This pull request has now been integrated. Changeset: d12077dc Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/d12077dc7d92eac99da9ab40c19a01b48f5dc121 Stats: 236 lines in 4 files changed: 189 ins; 29 del; 18 mod 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests Backport-of: 6a7c023796b0f39f54d0335f4723c1f06ff0032d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2810 From ashi at openjdk.org Wed Aug 21 23:22:16 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 23:22:16 GMT Subject: [jdk11u-dev] Integrated: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen" In-Reply-To: <51RLW8HeekQTJnemJVsQqHluoE3Uz_X5kwz6HM3yUfc=.264a847a-e24d-484e-aed6-0d757545a56f@github.com> References: <51RLW8HeekQTJnemJVsQqHluoE3Uz_X5kwz6HM3yUfc=.264a847a-e24d-484e-aed6-0d757545a56f@github.com> Message-ID: On Fri, 16 Aug 2024 03:42:48 GMT, Amos Shi wrote: > Backport of [JDK-8312140](https://bugs.openjdk.org/browse/JDK-8312140) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `AnalyzeSnippetTest.java`: Test results: passed: 1 > - `CustomInputToolBuilder.java`: Test results: passed: 1 > - `FailOverDirectExecutionControlTest.java`: Test results: passed: 1 > - `FailOverExecutionControlDyingLaunchTest.java`: Test results: passed: 1 > - `FailOverExecutionControlHangingLaunchTest.java`: Test results: passed: 1 > - `FailOverExecutionControlHangingListenTest.java`: Test results: passed: 1 > - `FailOverExecutionControlTest.java`: Test results: passed: 1 > - `IdGeneratorTest.java`: Test results: passed: 1 > - `StartOptionTest.java`: Test results: passed: 1 > - `ToolReloadTest.java`: Test results: passed: 1 > - Pipeline: > - Linux and Windows - passed > - Mac - `adlparse.cpp:214:11: error: 'sprintf' is deprecated` - this message is not caused by current PR > - `src/hotspot/share/adlc/archDesc.cpp:813:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.` > - The line `archDesc.cpp:813` was introduced 13 years ago via https://github.com/openjdk/jdk11u-dev/commit/07d9df5a7fb64f3c7252686d647fa3a5da8e8771 > - See https://github.com/openjdk/jdk11u-dev/blame/master/src/hotspot/share/adlc/archDesc.cpp#L813C5-L813C46 > - Testing Machine: SAP nightlies Passed on `2024-08-17` > - Automated jtreg test: `jtreg_langtools`, Started at `2024-08-16 22:12:29+01:00` > - jdk/jshell/AnalyzeSnippetTest.java: SUCCESSFUL GitHub ? - [22:14:56.692 -> 45,114 msec] > - jdk/jshell/CustomInputToolBuilder.java: SUCCESSFUL GitHub ? - [22:15:23.955 -> 44,166 msec] > - jdk/jshell/FailOverDirectExecutionControlTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - jdk/jshell/FailOverExecutionControlDyingLaunchTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] > - jdk/jshell/FailOverExecutionControlHangingLaunchTest.java: SUCCESSFUL GitHub ? - [22:15:43.642 -> 45,575 msec] > - jdk/jshell/FailOverExecutionControlHangingListenTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!intermittent))) & !manual & !ignore] Gi... This pull request has now been integrated. Changeset: 828d6452 Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/828d645208f490b8a74d5e007d37bad7dcad50b1 Stats: 106 lines in 15 files changed: 66 ins; 18 del; 22 mod 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen" 8312140: jdk/jshell tests failed with JDI socket timeouts Backport-of: 14193a049ebcbd3639962729c631293b8d3a9114 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2913 From ashi at openjdk.org Wed Aug 21 23:24:12 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 23:24:12 GMT Subject: [jdk17u-dev] Integrated: 8308891: TestCDSVMCrash.java needs @requires vm.cds In-Reply-To: <8febJNhfSE2K3VCcaiTGg0TnHQBjRhcSOVQfym8dSIY=.2550dd8f-2f44-435a-8512-c3643c56a3aa@github.com> References: <8febJNhfSE2K3VCcaiTGg0TnHQBjRhcSOVQfym8dSIY=.2550dd8f-2f44-435a-8512-c3643c56a3aa@github.com> Message-ID: On Thu, 15 Aug 2024 22:46:20 GMT, Amos Shi wrote: > Backport of [JDK-8308891](https://bugs.openjdk.org/browse/JDK-8308891) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `TestCDSVMCrash.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies Passed on `2024-08-17` > - Automated jtreg test: `jtreg_hotspot_tier1`, Started at `2024-08-16 20:49:01+01:00` > - runtime/cds/TestCDSVMCrash.java: SUCCESSFUL GitHub ? - [20:52:31.382 -> 2,093 msec] This pull request has now been integrated. Changeset: c1034091 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/c10340918cfe6d316c1d4d57e9f586c94c6d3098 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8308891: TestCDSVMCrash.java needs @requires vm.cds Backport-of: 101bf2290da5735fd9624ab647a8183c2c21f22d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2809 From ashi at openjdk.org Wed Aug 21 23:29:09 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 21 Aug 2024 23:29:09 GMT Subject: [jdk17u-dev] Integrated: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837 In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 21:54:29 GMT, Amos Shi wrote: > Backport of [JDK-8315576](https://bugs.openjdk.org/browse/JDK-8315576) > - Changes on `CodeCacheFullCountTest.java` is `clean` > - Changes on `test/hotspot/jtreg/ProblemList-Xcomp.txt` has been ignored, because the line does not exist in `jdk17u-dev` > - `test/hotspot/jtreg/ProblemList-Xcomp.txt.rej` contents > > > @@ -27,8 +27,6 @@ > # > ############################################################################# > > -compiler/codecache/CodeCacheFullCountTest.java 8315576 generic-all > - > vmTestbase/nsk/jvmti/AttachOnDemand/attach020/TestDescription.java 8287324 generic-all > vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java 8205957 generic-all > vmTestbase/nsk/jvmti/SetFieldModificationWatch/setfmodw001/TestDescription.java 8205957 linux-x64,windows-x64 > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `CodeCacheFullCountTest.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-17` > - Automated jtreg test: `jtreg_hotspot_tier1`, Started at `2024-08-16 20:49:01+01:00` > - compiler/codecache/CodeCacheFullCountTest.java: SUCCESSFUL GitHub ? - [20:49:52.546 -> 9,652 msec] This pull request has now been integrated. Changeset: 8dbd6772 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/8dbd6772f9b65ab1ae6ef683c7300092e4745951 Stats: 13 lines in 1 file changed: 8 ins; 0 del; 5 mod 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837 Reviewed-by: phh Backport-of: 343cc0ce2bba797e206f6b7312018a8c6d1bdb66 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2808 From ashi at openjdk.org Thu Aug 22 00:19:08 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 22 Aug 2024 00:19:08 GMT Subject: [jdk17u-dev] RFR: 8302800: Augment NaN handling tests of FDLIBM methods In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 08:27:51 GMT, Goetz Lindenmaier wrote: > There are red tests, what is wrong? Reason - `This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.` Action - I will re-trigger ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2779#issuecomment-2303332909 From ashi at openjdk.org Thu Aug 22 00:52:30 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 22 Aug 2024 00:52:30 GMT Subject: [jdk17u-dev] RFR: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException Message-ID: Backport of [JDK-8332248](https://bugs.openjdk.org/browse/JDK-8332248) Testing - Local: Test not executed on `MacOS 14.6.1` on Apple M1 Max, because `@requires (os.family == "linux")` - `BlockDeviceSize.java`: Test results: **no tests selected** - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 0bb5ae645165b97527ecccf02308df6072c363d8 Changes: https://git.openjdk.org/jdk17u-dev/pull/2818/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2818&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332248 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2818.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2818/head:pull/2818 PR: https://git.openjdk.org/jdk17u-dev/pull/2818 From andrewlu at openjdk.org Thu Aug 22 06:02:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 22 Aug 2024 06:02:48 GMT Subject: [jdk17u-dev] RFR: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests Message-ID: I backport this for parity with 17.0.13-oracle. test/jdk/java/net/httpclient/AuthFilterCacheTest.java test/jdk/java/net/httpclient/ConcurrentResponses.java ignored this commit: https://github.com/openjdk/jdk/commit/736b90d54b51830de7757a8de3ad9c98437c824a test/jdk/java/net/httpclient/MappingResponseSubscriber.java ignored this commit https://github.com/openjdk/jdk/commit/49d60fee49b9f5f7182dcd1557d9b2f886901100 ------------- Commit messages: - Backport 05e9c41eddf8961d1384c88ccedf993d86822a6b Changes: https://git.openjdk.org/jdk17u-dev/pull/2819/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2819&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310731 Stats: 318 lines in 19 files changed: 265 ins; 24 del; 29 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2819.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2819/head:pull/2819 PR: https://git.openjdk.org/jdk17u-dev/pull/2819 From gcao at openjdk.org Thu Aug 22 08:17:18 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 22 Aug 2024 08:17:18 GMT Subject: [jdk21u-dev] RFR: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV In-Reply-To: <6vFptnpY5HR-ZhSDbo9lVv4KExAaySRX3vZHCTMQ3FI=.146a596c-c6a0-4332-8f5a-7ce4da4b3c73@github.com> References: <6vFptnpY5HR-ZhSDbo9lVv4KExAaySRX3vZHCTMQ3FI=.146a596c-c6a0-4332-8f5a-7ce4da4b3c73@github.com> Message-ID: <1F06P9nk_UBGpDitM-lnkGqRlQQdJheA7t-BYz8lzR0=.ce079321-3a87-4440-a807-8905eea3237f@github.com> On Tue, 20 Aug 2024 15:25:10 GMT, Gui Cao wrote: > Hi, at [JDK-8334078](https://bugs.openjdk.org/browse/JDK-8334078), modified the matching logic for the linux-riscv64 rvv test, here i would like to backport this to jdk21u-dev, to simplify the subsequent functionality and testing of the backport to jdk21u-dev. This is a risc-v specific change, risk is low. > > ### Testing > - [x] Run tier1 tests on SOPHON SG2042 (fastdebug) Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/937#issuecomment-2304049698 From gcao at openjdk.org Thu Aug 22 08:17:18 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 22 Aug 2024 08:17:18 GMT Subject: [jdk21u-dev] Integrated: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV In-Reply-To: <6vFptnpY5HR-ZhSDbo9lVv4KExAaySRX3vZHCTMQ3FI=.146a596c-c6a0-4332-8f5a-7ce4da4b3c73@github.com> References: <6vFptnpY5HR-ZhSDbo9lVv4KExAaySRX3vZHCTMQ3FI=.146a596c-c6a0-4332-8f5a-7ce4da4b3c73@github.com> Message-ID: On Tue, 20 Aug 2024 15:25:10 GMT, Gui Cao wrote: > Hi, at [JDK-8334078](https://bugs.openjdk.org/browse/JDK-8334078), modified the matching logic for the linux-riscv64 rvv test, here i would like to backport this to jdk21u-dev, to simplify the subsequent functionality and testing of the backport to jdk21u-dev. This is a risc-v specific change, risk is low. > > ### Testing > - [x] Run tier1 tests on SOPHON SG2042 (fastdebug) This pull request has now been integrated. Changeset: 846962d7 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk21u-dev/commit/846962d7dc16d698f705213be51a0fb1f2e9ba58 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV Reviewed-by: fyang Backport-of: ef7923e1277ce86c6e5331871f1031c28bf82e31 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/937 From andrewlu at openjdk.org Thu Aug 22 08:20:52 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 22 Aug 2024 08:20:52 GMT Subject: [jdk11u-dev] RFR: 8220673: Add test library support for determining platform IP support [v3] In-Reply-To: References: Message-ID: <66wsadH0KDHL4ZtfvqIXM6q5aUvipB_HSivkkCslaXA=.9ea839f2-f118-4301-af2a-f81e2dbf60f1@github.com> > I backport this for parity with 11.0.25-oracle. > these tests are not clean, but all added code is clean > test/jdk/java/net/NetworkInterface/Test.java > test/jdk/java/net/Socket/CloseAvailable.java > test/jdk/java/net/Socket/HttpProxy.java > test/jdk/java/net/Socket/SetSoLinger.java > test/jdk/java/nio/channels/DatagramChannel/Disconnect.java > > this class is not exist, ignore, other classes are clean > test/jdk/java/nio/channels/etc/PrintSupportedOptions.java > > As https://bugs.openjdk.org/browse/JDK-8239355 is already backported, https://github.com/openjdk/jdk11u-dev/commit/f4288be071133267f3647475c510be4d77dcf608 > so not modify the test/lib/jdk/test/lib/net/IPSupport.java > it missed to backported to modify the test/jdk/java/net/IPSupport/MinimumPermissions.policy > so here edit it. > > also add backport for https://bugs.openjdk.org/browse/JDK-8223652 > otherwise other tests will fail due to the throwSkippedExceptionIfNonOperational() change Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2910/files - new: https://git.openjdk.org/jdk11u-dev/pull/2910/files/11b6db11..50f618ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2910&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2910&range=01-02 Stats: 6 lines in 2 files changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2910.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2910/head:pull/2910 PR: https://git.openjdk.org/jdk11u-dev/pull/2910 From andrewlu at openjdk.org Thu Aug 22 08:26:52 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 22 Aug 2024 08:26:52 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.13-oracle. > modify lines are different, but code is clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2807/files - new: https://git.openjdk.org/jdk17u-dev/pull/2807/files/a39ac49b..856ea72b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2807.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2807/head:pull/2807 PR: https://git.openjdk.org/jdk17u-dev/pull/2807 From andrewlu at openjdk.org Thu Aug 22 08:29:14 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 22 Aug 2024 08:29:14 GMT Subject: [jdk17u-dev] RFR: 8320675: PrinterJob/SecurityDialogTest.java hangs [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.13-oracle. > modify lines are different, but code is clean. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into andrewLu_backport_8320675 - fix - Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2807/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2807&range=02 Stats: 234 lines in 1 file changed: 51 ins; 151 del; 32 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2807.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2807/head:pull/2807 PR: https://git.openjdk.org/jdk17u-dev/pull/2807 From sgehwolf at openjdk.org Thu Aug 22 09:26:03 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 09:26:03 GMT Subject: [jdk21u-dev] RFR: 8321308: AArch64: Fix matching predication for cbz/cbnz In-Reply-To: <6ZbthRNyFF-b9jXEweyrQqAjh_-PT2cSLJ7HQ2mv38c=.56d099f5-a4b5-42d8-a70c-eb46a3421852@github.com> References: <6ZbthRNyFF-b9jXEweyrQqAjh_-PT2cSLJ7HQ2mv38c=.56d099f5-a4b5-42d8-a70c-eb46a3421852@github.com> Message-ID: On Wed, 21 Aug 2024 21:31:34 GMT, Boris Ulasevich wrote: > Clean backport to improve aarch code generation for array length `if (a.length > 0)` > > Testing: jtreg tier1-3 on linux-aarch64. We should not backport about anything to JDK 21. Especially when it comes to performance improvements. This P4 enhancement doesn't strike me as anything important enough for a stable update release. Let's be more diligent with performance enhancements. You may consider backporting to 23u. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/940#issuecomment-2304192202 From sgehwolf at openjdk.org Thu Aug 22 09:42:12 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 09:42:12 GMT Subject: [jdk21u-dev] RFR: 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 22:00:46 GMT, Boris Ulasevich wrote: > This is a clean backport to avoid a potentially rscratch1 register clobbering in C2_MacroAssembler::fast_lock. > > Testing: jtreg tier1-3 on linux-aarch64. Please turn on GHA testing on your fork. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/941#issuecomment-2304222835 From sgehwolf at openjdk.org Thu Aug 22 10:57:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 10:57:10 GMT Subject: [jdk21u-dev] RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 11:06:05 GMT, Aleksey Shipilev wrote: > Clean backport to fix potential `CME` in `ReferencedKeyMap`. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk/internal/util java/lang/invoke` OK, on the basis that this is pretty new class which does not have many usages yet. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/916#issuecomment-2304371066 From bulasevich at openjdk.org Thu Aug 22 11:01:36 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 22 Aug 2024 11:01:36 GMT Subject: [jdk21u-dev] RFR: 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result [v2] In-Reply-To: References: Message-ID: > This is a clean backport to avoid a potentially rscratch1 register clobbering in C2_MacroAssembler::fast_lock. > > Testing: jtreg tier1-3 on linux-aarch64. Boris Ulasevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 387504c9e4b93d162dcef7c90c57c27295858d2e ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/941/files - new: https://git.openjdk.org/jdk21u-dev/pull/941/files/0b7747c1..0403e0e0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=941&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=941&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/941.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/941/head:pull/941 PR: https://git.openjdk.org/jdk21u-dev/pull/941 From sgehwolf at openjdk.org Thu Aug 22 11:14:05 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 11:14:05 GMT Subject: [jdk21u-dev] RFR: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist In-Reply-To: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> References: <3qaZi5FvChcLH-QQyN31nKi7NFmSRQan7gX2Kagv_PE=.5c7cf259-e94e-477f-810a-6a6131f1d029@github.com> Message-ID: On Fri, 16 Aug 2024 00:23:54 GMT, Todd V. Jonker wrote: > Clean backport of a performance fix, originally authored by @bplb and reviewed by @AlanBateman > > Test suites run on linux-x86_64-server-release: > - [x] tier1 > - [x] jdk/java/nio This hasn't been in any released JDK version. Deferred to 21.0.6. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/926#issuecomment-2304403675 From shade at openjdk.org Thu Aug 22 11:24:14 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 22 Aug 2024 11:24:14 GMT Subject: [jdk21u-dev] Integrated: 8335007: Inline OopMapCache table In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 13:08:25 GMT, Aleksey Shipilev wrote: > Almost clean backport to improve `OopMapCache` footprint and performance. > > The conflict is in copyright header years, bots still think this is clean. > > Additionally, this is one of few backports that gets `OopMapCache` behavior similar to mainline. This makes [JDK-8335409](https://bugs.openjdk.org/browse/JDK-8335409) backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` This pull request has now been integrated. Changeset: 38eeb50c Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/38eeb50c6d7b3e06e08a88d13997f7f330938df3 Stats: 17 lines in 2 files changed: 0 ins; 5 del; 12 mod 8335007: Inline OopMapCache table Backport-of: 50dd962b0d0fe36634d96dbbd9d94fbc34d9ff7f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/936 From shade at openjdk.org Thu Aug 22 11:25:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 22 Aug 2024 11:25:05 GMT Subject: [jdk21u-dev] Integrated: 8330981: ZGC: Should not dedup strings in the finalizer graph In-Reply-To: References: Message-ID: <3S9loltD7Le8IIMKYfmQLmbs0j62tdJqXgacth7Kuuw=.91826175-9229-4d37-8820-d754a9b32740@github.com> On Tue, 13 Aug 2024 13:17:58 GMT, Aleksey Shipilev wrote: > Clean backport to fix a ZGC corner case. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` with `-XX:+UseZGC` > - [x] Linux x86_64 server fastdebug, `all` with `-XX:+UseZGC -XX:+ZGenerational` This pull request has now been integrated. Changeset: d5b8ea8d Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/d5b8ea8dacdfb7cbd9e9d5fb98a2571db2e1bf6b Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod 8330981: ZGC: Should not dedup strings in the finalizer graph Backport-of: 2f2dc2289bce47d8071a86215218f345cce71dba ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/917 From jwtang at openjdk.org Thu Aug 22 11:26:06 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Thu, 22 Aug 2024 11:26:06 GMT Subject: [jdk23u] Integrated: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 01:54:31 GMT, Jiawei Tang wrote: > 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option This pull request has now been integrated. Changeset: be9b43c2 Author: Jiawei Tang Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/be9b43c23f6c5f0bae9c395eae086d87d3442603 Stats: 83 lines in 2 files changed: 78 ins; 1 del; 4 mod 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option Backport-of: 55c509708e9b89a7609fd41b6e5a271f250bbacd ------------- PR: https://git.openjdk.org/jdk23u/pull/73 From shade at openjdk.org Thu Aug 22 11:23:06 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 22 Aug 2024 11:23:06 GMT Subject: [jdk21u-dev] RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 11:06:05 GMT, Aleksey Shipilev wrote: > Clean backport to fix potential `CME` in `ReferencedKeyMap`. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk/internal/util java/lang/invoke` Yes, thank you. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/916#issuecomment-2304418861 From shade at openjdk.org Thu Aug 22 11:23:07 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 22 Aug 2024 11:23:07 GMT Subject: [jdk21u-dev] Integrated: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 11:06:05 GMT, Aleksey Shipilev wrote: > Clean backport to fix potential `CME` in `ReferencedKeyMap`. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk/internal/util java/lang/invoke` This pull request has now been integrated. Changeset: affb895c Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/affb895c9c7a18390f29ca4aa4003fee0b5ec26b Stats: 11 lines in 1 file changed: 7 ins; 1 del; 3 mod 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException Backport-of: bfb75b96266f4c5840e2edea13f9aa2c801518cf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/916 From syan at openjdk.org Thu Aug 22 11:27:06 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 22 Aug 2024 11:27:06 GMT Subject: [jdk23u] Integrated: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: <-ZHmBnOy7HPJwySf_PC0T4DzZgZUsw_tYU4YtB9Y5G8=.f268b255-61c6-47f9-ad83-a8f743135de5@github.com> On Wed, 14 Aug 2024 01:35:10 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! This pull request has now been integrated. Changeset: 39884205 Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/39884205fbc0e85ce9d78303dfbabf125ff36535 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Backport-of: f132b347e13a57d9654f0ab11db0636999576036 ------------- PR: https://git.openjdk.org/jdk23u/pull/69 From sgehwolf at openjdk.org Thu Aug 22 11:38:08 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 11:38:08 GMT Subject: [jdk21u-dev] RFR: 8320192: SHAKE256 does not work correctly if n >= 137 In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 14:09:26 GMT, Dmitry Chuyko wrote: > This is a clean backport of KAT fix for SHAKE256. The test provided in the bug description currently fails on JDK 21. This also adds `SHAKE128.java`, which I believe isn't needed for this bug-fix. Please remove it and get it reviewed. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/902#issuecomment-2304448778 From sgehwolf at openjdk.org Thu Aug 22 11:42:09 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 11:42:09 GMT Subject: [jdk21u-dev] RFR: 8321940: Improve CDSHeapVerifier in handling of interned strings In-Reply-To: References: Message-ID: <7MM_6Ys4zOn03ytfVKUl6wmG9XbL7f1t5IwxFHLDfGc=.af944218-6459-442f-8608-146173d0960f@github.com> On Thu, 15 Aug 2024 17:54:31 GMT, Ben Taylor wrote: > Clean backport of a change to fix a false-positive error condition in the cdsHeapVerifier. > This change also reduces the number of manually curated `ADD_EXCL` entries in cdsHeapVerifier, improving long-term maintainability. > > Change passes tier 1 tests locally on x86_64 linux. @benty-amzn This hasn't been in any released JDK version yet. Deferring to next 21 cycle. It would be good if you can clarify "improving long-term maintainability". What do you mean by that exactly? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/925#issuecomment-2304455806 From shade at openjdk.org Thu Aug 22 12:32:30 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 22 Aug 2024 12:32:30 GMT Subject: [jdk21u-dev] RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 Message-ID: This fixes the regression introduced by [JDK-8329665](https://bugs.openjdk.org/browse/JDK-8329665), which added `ResourceMark` in `frame::oops_interpreted_do`. This is not really correct, as closures we call with that method can do resource allocations. The patch avoids this problem by cleanly allocating on C heap. The mainline patch wants `has_valid_mask` infrastructure added as part of [JDK-8315954](https://bugs.openjdk.org/browse/JDK-8315954). That patch has implications for Graal, and have unresolved bug tail. Therefore, I just picked up relevant infra hunks here. Additional testing: - [ ] Linux x86_64 server fastedebug, `all` - [ ] Linux AArch64 server fastedebug, `all` ------------- Commit messages: - Backport 7ab96c74e2c39f430a5c2f65a981da7314a2385b Changes: https://git.openjdk.org/jdk21u-dev/pull/942/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=942&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335409 Stats: 57 lines in 3 files changed: 12 ins; 17 del; 28 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/942.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/942/head:pull/942 PR: https://git.openjdk.org/jdk21u-dev/pull/942 From syan at openjdk.org Thu Aug 22 12:42:09 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 22 Aug 2024 12:42:09 GMT Subject: [jdk23u] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 01:35:10 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/69#issuecomment-2304569329 From syan at openjdk.org Thu Aug 22 12:55:12 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 22 Aug 2024 12:55:12 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Message-ID: Hi all, This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. Thanks! ------------- Commit messages: - Backport 39884205fbc0e85ce9d78303dfbabf125ff36535 Changes: https://git.openjdk.org/jdk21u-dev/pull/943/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=943&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336854 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/943.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/943/head:pull/943 PR: https://git.openjdk.org/jdk21u-dev/pull/943 From syan at openjdk.org Thu Aug 22 12:55:36 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 22 Aug 2024 12:55:36 GMT Subject: [jdk17u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Message-ID: Hi all, This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. Thanks! ------------- Commit messages: - Backport 39884205fbc0e85ce9d78303dfbabf125ff36535 Changes: https://git.openjdk.org/jdk17u-dev/pull/2820/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2820&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336854 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2820.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2820/head:pull/2820 PR: https://git.openjdk.org/jdk17u-dev/pull/2820 From sgehwolf at openjdk.org Thu Aug 22 13:03:22 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 13:03:22 GMT Subject: [jdk11u-dev] RFR: 8296812: sprintf is deprecated in Xcode 14 [v4] In-Reply-To: References: <4nCoTNA6Dj1NbaY2uePRlg57kHlcCTHfq2awRsoHprE=.3bf98695-f619-4684-a353-653d36b70f28@github.com> Message-ID: On Tue, 16 Jul 2024 19:56:28 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) . >> >> The new GHA build platform (macos-13 / XCode 14) fails because `sprintf` is deprecated. An alternative (`os::snprintf_checked`) was introduced in JDK-8296812. >> >> This is sadly not a clean backport, as different issues have not been backported to 11 (JDK-8324824, JDK-8303575, JDK-8301050, JDK-8298472, JDK-8298472 to name a few). >> >> The backport required changes to the following files: >> >> >> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp >> src/hotspot/os/bsd/os_bsd.cpp >> src/hotspot/share/adlc/adlc.hpp >> src/hotspot/share/adlc/adlparse.cpp >> src/hotspot/share/adlc/formssel.cpp >> src/hotspot/share/adlc/output_c.cpp >> src/hotspot/share/c1/c1_Runtime1.cpp >> src/hotspot/share/compiler/compileBroker.cpp >> src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp >> src/hotspot/share/runtime/perfData.cpp >> src/hotspot/share/utilities/utf8.cpp >> >> >> And these files were not backported: >> >> >> src/hotspot/share/cds/filemap.cpp >> src/hotspot/share/interpreter/bootstrapInfo.cpp >> src/hotspot/share/jfr/support/jfrSymbolTable.cpp >> >> >> While we are at it, this change also replaces `strcat` in `src/hotspot/cpu/aarch64/vm_version_aarch64.cpp` with the newly introduced `os::snprintf_checked` to avoid possible buffer overflows. >> >> Builds on the new `macos-13` will continue to fail until different issues are backported. The new macos builds report a clash with the standard `assert` macro (see [1]) what suggests that [JDK-8299254](https://bugs.openjdk.org/browse/JDK-8299254) "Support dealing with standard assert macro" should be backported next. >> >> [1] >> >> In file included from /Users/runner/work/jdk11u-dev/jdk11u-dev/test/hotspot/gtest/jfr/test_networkUtilization.cpp:223: >> /Users/runner/work/jdk11u-dev/jdk11u-dev/src/hotspot/share/jfr/periodic/jfrNetworkUtilization.cpp:58:25: error: too many arguments provided to function-like macro invocation >> assert(iface != NULL, "invariant"); > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Replace comment + newline in src/hotspot/share/adlc/adlc.hpp @adinn Could you please help review this patch. In particular the changes in `vm_version_aarch64.cpp`? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2836#issuecomment-2304613431 From sgehwolf at openjdk.org Thu Aug 22 13:29:13 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 13:29:13 GMT Subject: [jdk11u-dev] RFR: 8296812: sprintf is deprecated in Xcode 14 [v4] In-Reply-To: References: <4nCoTNA6Dj1NbaY2uePRlg57kHlcCTHfq2awRsoHprE=.3bf98695-f619-4684-a353-653d36b70f28@github.com> Message-ID: <7MsTJT4lfzqaK0ljDM4iuDBKAgsYkwyaq8oofi1Cwic=.7d84f3a5-8ada-4d8f-b94f-087617ee3a8a@github.com> On Tue, 16 Jul 2024 19:56:28 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) . >> >> The new GHA build platform (macos-13 / XCode 14) fails because `sprintf` is deprecated. An alternative (`os::snprintf_checked`) was introduced in JDK-8296812. >> >> This is sadly not a clean backport, as different issues have not been backported to 11 (JDK-8324824, JDK-8303575, JDK-8301050, JDK-8298472, JDK-8298472 to name a few). >> >> The backport required changes to the following files: >> >> >> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp >> src/hotspot/os/bsd/os_bsd.cpp >> src/hotspot/share/adlc/adlc.hpp >> src/hotspot/share/adlc/adlparse.cpp >> src/hotspot/share/adlc/formssel.cpp >> src/hotspot/share/adlc/output_c.cpp >> src/hotspot/share/c1/c1_Runtime1.cpp >> src/hotspot/share/compiler/compileBroker.cpp >> src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp >> src/hotspot/share/runtime/perfData.cpp >> src/hotspot/share/utilities/utf8.cpp >> >> >> And these files were not backported: >> >> >> src/hotspot/share/cds/filemap.cpp >> src/hotspot/share/interpreter/bootstrapInfo.cpp >> src/hotspot/share/jfr/support/jfrSymbolTable.cpp >> >> >> While we are at it, this change also replaces `strcat` in `src/hotspot/cpu/aarch64/vm_version_aarch64.cpp` with the newly introduced `os::snprintf_checked` to avoid possible buffer overflows. >> >> Builds on the new `macos-13` will continue to fail until different issues are backported. The new macos builds report a clash with the standard `assert` macro (see [1]) what suggests that [JDK-8299254](https://bugs.openjdk.org/browse/JDK-8299254) "Support dealing with standard assert macro" should be backported next. >> >> [1] >> >> In file included from /Users/runner/work/jdk11u-dev/jdk11u-dev/test/hotspot/gtest/jfr/test_networkUtilization.cpp:223: >> /Users/runner/work/jdk11u-dev/jdk11u-dev/src/hotspot/share/jfr/periodic/jfrNetworkUtilization.cpp:58:25: error: too many arguments provided to function-like macro invocation >> assert(iface != NULL, "invariant"); > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Replace comment + newline in src/hotspot/share/adlc/adlc.hpp This seems OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2836#pullrequestreview-2254523627 From syan at openjdk.org Thu Aug 22 13:34:51 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 22 Aug 2024 13:34:51 GMT Subject: [jdk11u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Message-ID: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> Hi all, This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. This PR not clean, because this file has changed by JDK-8328638 and JDK-8329213 which not backported to jdk11u-dev. Thanks! ------------- Commit messages: - manual backport, instead of cherry-pick - Backport f132b347e13a57d9654f0ab11db0636999576036 Changes: https://git.openjdk.org/jdk11u-dev/pull/2919/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2919&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336854 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2919.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2919/head:pull/2919 PR: https://git.openjdk.org/jdk11u-dev/pull/2919 From sshivang at openjdk.org Thu Aug 22 15:44:39 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Thu, 22 Aug 2024 15:44:39 GMT Subject: [jdk23u] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Message-ID: <44iHrY0PBsttXHDPjNioUsJDqfRDE5jfzrqjVlYf-pI=.af4ecf50-f635-46ca-915e-af25d18d22ab@github.com> This is a manual test. Here are the run results:- /Users/dk-23.0.1.jdk/Contents/Home/bin/java -cp . Password Two passwords will be prompted for. The first one should have echo off, the second one on. Otherwise, this test fails Invisible: Visible: hello You input hello and hello ------------- Commit messages: - Backport a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 Changes: https://git.openjdk.org/jdk23u/pull/82/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=82&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335172 Stats: 17 lines in 3 files changed: 13 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/82.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/82/head:pull/82 PR: https://git.openjdk.org/jdk23u/pull/82 From dchuyko at openjdk.org Thu Aug 22 15:48:38 2024 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 22 Aug 2024 15:48:38 GMT Subject: [jdk21u-dev] RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v2] In-Reply-To: References: Message-ID: <3uYV4BZlYy9tlgvoA3gUBv9ldA7qPfYJjNja-ESTz5g=.f157d60a-209d-46a0-b202-096450ff441a@github.com> > This is a clean backport of KAT fix for SHAKE256. The test provided in the bug description currently fails on JDK 21. Dmitry Chuyko has updated the pull request incrementally with one additional commit since the last revision: Deleted SHAKE128 implementation ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/902/files - new: https://git.openjdk.org/jdk21u-dev/pull/902/files/f28895af..4b5656f7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=902&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=902&range=00-01 Stats: 49 lines in 1 file changed: 0 ins; 49 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/902.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/902/head:pull/902 PR: https://git.openjdk.org/jdk21u-dev/pull/902 From dchuyko at openjdk.org Thu Aug 22 15:48:38 2024 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 22 Aug 2024 15:48:38 GMT Subject: [jdk21u-dev] RFR: 8320192: SHAKE256 does not work correctly if n >= 137 In-Reply-To: References: Message-ID: On Thu, 8 Aug 2024 14:09:26 GMT, Dmitry Chuyko wrote: > This is a clean backport of KAT fix for SHAKE256. The test provided in the bug description currently fails on JDK 21. Thanks, Severin. I missed that the class is public, now it's removed from the backport. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/902#issuecomment-2305087540 From btaylor at openjdk.org Thu Aug 22 17:31:09 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 22 Aug 2024 17:31:09 GMT Subject: [jdk21u-dev] RFR: 8321940: Improve CDSHeapVerifier in handling of interned strings In-Reply-To: <7MM_6Ys4zOn03ytfVKUl6wmG9XbL7f1t5IwxFHLDfGc=.af944218-6459-442f-8608-146173d0960f@github.com> References: <7MM_6Ys4zOn03ytfVKUl6wmG9XbL7f1t5IwxFHLDfGc=.af944218-6459-442f-8608-146173d0960f@github.com> Message-ID: On Thu, 22 Aug 2024 11:39:42 GMT, Severin Gehwolf wrote: >> Clean backport of a change to fix a false-positive error condition in the cdsHeapVerifier. >> This change also reduces the number of manually curated `ADD_EXCL` entries in cdsHeapVerifier, improving long-term maintainability. >> >> Change passes tier 1 tests locally on x86_64 linux. > > @benty-amzn This hasn't been in any released JDK version yet. Deferring to next 21 cycle. It would be good if you can clarify "improving long-term maintainability". What do you mean by that exactly? @jerboaa The comment in `cdsHeapVerifier` reads > // Unfortunately this needs to be manually maintained. If > // test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumTest.java fails, > // you might need to fix the core library code, or fix the ADD_EXCL entries below. I simply meant that this change reduces the number of manually-maintained entries in that file, which will reduce the amount of work required to keep that list up-to-date going forward. Delaying one cycle so the code can be released in another version first makes sense. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/925#issuecomment-2305282980 From mbaesken at openjdk.org Thu Aug 22 17:53:10 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 22 Aug 2024 17:53:10 GMT Subject: [jdk23u] Integrated: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' In-Reply-To: <83rlLFTwXhU1YzlYaACkVFsXP_f4Sky5GMLhdorekq0=.31c488d0-21c6-4803-bee6-b29cb35124f4@github.com> References: <83rlLFTwXhU1YzlYaACkVFsXP_f4Sky5GMLhdorekq0=.31c488d0-21c6-4803-bee6-b29cb35124f4@github.com> Message-ID: On Wed, 14 Aug 2024 11:15:05 GMT, Matthias Baesken wrote: > 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' This pull request has now been integrated. Changeset: 447800fa Author: Matthias Baesken URL: https://git.openjdk.org/jdk23u/commit/447800fab11caf2c03aa94996fa56f3ab36bfeed Stats: 131 lines in 10 files changed: 50 ins; 64 del; 17 mod 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' Backport-of: 8162832832ac6e8c17f942e718e309a3489e0da6 ------------- PR: https://git.openjdk.org/jdk23u/pull/71 From mbaesken at openjdk.org Thu Aug 22 17:53:16 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 22 Aug 2024 17:53:16 GMT Subject: [jdk21u-dev] Integrated: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 10:13:06 GMT, Matthias Baesken wrote: > 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' This pull request has now been integrated. Changeset: fa8ef0f4 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/fa8ef0f4bde150083a97547340a45e4dde0e8113 Stats: 131 lines in 10 files changed: 50 ins; 64 del; 17 mod 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' Backport-of: 8162832832ac6e8c17f942e718e309a3489e0da6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/929 From mbaesken at openjdk.org Thu Aug 22 17:58:06 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 22 Aug 2024 17:58:06 GMT Subject: [jdk21u-dev] Integrated: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 10:01:13 GMT, Matthias Baesken wrote: > Backport of 8333149, diff in stride This pull request has now been integrated. Changeset: 24f453c0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/24f453c00706b4c8b49175bbb01b8360853f22c9 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage Backport-of: 43a2f17342af8f5bf1f5823df9fa0bf0bdfdfce2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/928 From mbaesken at openjdk.org Thu Aug 22 17:58:05 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 22 Aug 2024 17:58:05 GMT Subject: [jdk21u-dev] Integrated: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 10:33:04 GMT, Matthias Baesken wrote: > 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero This pull request has now been integrated. Changeset: dc8365c9 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/dc8365c947b72f77ecba1065e2e9e0851e98f844 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero Backport-of: 34eea6a5fa27121bc0e9e8ace0894833d4a9f826 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/930 From duke at openjdk.org Thu Aug 22 18:31:16 2024 From: duke at openjdk.org (duke) Date: Thu, 22 Aug 2024 18:31:16 GMT Subject: [jdk11u-dev] Withdrawn: 8228960: [TESTBUG] containers/docker/TestJcmdWithSideCar.java: jcmd reports main class as 'Unknown' In-Reply-To: References: Message-ID: On Thu, 27 Jun 2024 10:36:59 GMT, Antonio Vieiro wrote: > Backport of [JDK-8228960](https://bugs.openjdk.org/browse/JDK-8228960) for parity with 11.0.24-oracle > This also paves the way for future container-related tests. > > Tested on Fedora 40 with Docker version 27.0.1, build 7fafd33 > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg/containers/docker/TestJcmdWithSideCar.java > 1 1 0 0 > ============================== > TEST SUCCESS > > > Backport is clean but for a single empty newline in `test/hotspot/jtreg/ProblemList.txt`, that was introduced by [JDK-8228904](https://bugs.openjdk.org/browse/JDK-8228904) (see commit [e3aa4909](https://github.com/openjdk/jdk/commit/e3aa4909dffc2346b28364aed7fdfff4ff1771b6) ) which was not backported to 11. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2822 From duke at openjdk.org Thu Aug 22 19:42:44 2024 From: duke at openjdk.org (Mimoun Ghordou) Date: Thu, 22 Aug 2024 19:42:44 GMT Subject: [jdk23u] RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java [v2] In-Reply-To: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> References: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Message-ID: > Clean Backport > > Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine Mimoun Ghordou has updated the pull request incrementally with one additional commit since the last revision: 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/57/files - new: https://git.openjdk.org/jdk23u/pull/57/files/a509fe08..89e960e7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=57&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=57&range=00-01 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk23u/pull/57.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/57/head:pull/57 PR: https://git.openjdk.org/jdk23u/pull/57 From phh at openjdk.org Thu Aug 22 22:20:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Aug 2024 22:20:11 GMT Subject: [jdk21u-dev] RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 In-Reply-To: References: Message-ID: <2MUsNKYHuXlPZVgaxtIYF4zCSJsrNBo0pu0h4M4jETQ=.716e31f3-e3af-46a2-9ee0-79418984997c@github.com> On Thu, 22 Aug 2024 12:27:44 GMT, Aleksey Shipilev wrote: > This fixes the regression introduced by [JDK-8329665](https://bugs.openjdk.org/browse/JDK-8329665), which added `ResourceMark` in `frame::oops_interpreted_do`. This is not really correct, as closures we call with that method can do resource allocations. The patch avoids this problem by cleanly allocating on C heap. > > The mainline patch wants `has_valid_mask` infrastructure added as part of [JDK-8315954](https://bugs.openjdk.org/browse/JDK-8315954). That patch has implications for Graal, and have unresolved bug tail. Therefore, I just picked up relevant infra hunks here. > > Additional testing: > - [ ] Linux x86_64 server fastedebug, `all` > - [ ] Linux AArch64 server fastedebug, `all` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/942#pullrequestreview-2255895416 From duke at openjdk.org Fri Aug 23 01:14:10 2024 From: duke at openjdk.org (duke) Date: Fri, 23 Aug 2024 01:14:10 GMT Subject: [jdk21u-dev] RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread In-Reply-To: References: Message-ID: <4fw-gQjPtbjKc_WKru2Y7mGL99yEgLCSY2VnetOIVOA=.be90d520-5325-4248-b773-c600ae2decad@github.com> On Fri, 19 Jul 2024 09:02:41 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8335743. > It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. > I created the pull request https://github.com/openjdk/jdk21u-dev/pull/854 which backports JDK-8336284. > > Testing: > hotspot/jtreg/serviceability/sa and jdk/sun/tools/jhsdb @tkiriyama Your change (at version 5dc91bfef77e64cae973a330bb850177b59fcd21) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/853#issuecomment-2305995995 From syan at openjdk.org Fri Aug 23 09:51:03 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 23 Aug 2024 09:51:03 GMT Subject: [jdk21u-dev] RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 14:26:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [fa7521b2](https://github.com/openjdk/jdk/commit/fa7521b29eef39aeecb307f239c6d16898085984) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 24 Jun 2024 and was reviewed by Markus Gr?nlund. > > We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196. Clean backport , test fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/931#issuecomment-2306721382 From duke at openjdk.org Fri Aug 23 09:51:04 2024 From: duke at openjdk.org (duke) Date: Fri, 23 Aug 2024 09:51:04 GMT Subject: [jdk21u-dev] RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 14:26:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [fa7521b2](https://github.com/openjdk/jdk/commit/fa7521b29eef39aeecb307f239c6d16898085984) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 24 Jun 2024 and was reviewed by Markus Gr?nlund. > > We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196. Clean backport , test fix only, no risk. > > Thanks! @sendaoYan Your change (at version 2082e2af768538ad648461803f764b16e2394e94) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/931#issuecomment-2306722634 From qxing at openjdk.org Fri Aug 23 10:00:38 2024 From: qxing at openjdk.org (Qizheng Xing) Date: Fri, 23 Aug 2024 10:00:38 GMT Subject: [jdk23u] RFR: 8333334: C2: Make result of `Node::dominates` more precise to enhance scalar replacement Message-ID: Hi all, This pull request contains a backport of commit [965dd1ac](https://github.com/openjdk/jdk/commit/965dd1acd0ce5b225d85e2c55cc097856e0e9f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Qizheng Xing on 23 Aug 2024 and was reviewed by Christian Hagedorn, Vladimir Kozlov and Tobias Hartmann. Thanks! ------------- Commit messages: - Backport 965dd1acd0ce5b225d85e2c55cc097856e0e9f3c Changes: https://git.openjdk.org/jdk23u/pull/83/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=83&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333334 Stats: 240 lines in 6 files changed: 190 ins; 4 del; 46 mod Patch: https://git.openjdk.org/jdk23u/pull/83.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/83/head:pull/83 PR: https://git.openjdk.org/jdk23u/pull/83 From thartmann at openjdk.org Fri Aug 23 10:18:04 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Fri, 23 Aug 2024 10:18:04 GMT Subject: [jdk23u] RFR: 8333334: C2: Make result of `Node::dominates` more precise to enhance scalar replacement In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 09:55:09 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [965dd1ac](https://github.com/openjdk/jdk/commit/965dd1acd0ce5b225d85e2c55cc097856e0e9f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 23 Aug 2024 and was reviewed by Christian Hagedorn, Vladimir Kozlov and Tobias Hartmann. > > Thanks! What's the justification to backport this? The bar for backporting enhancements is quite high. Please note that you also need maintainer approval. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/83#issuecomment-2306771741 From duke at openjdk.org Fri Aug 23 10:24:10 2024 From: duke at openjdk.org (HempushpaSahu) Date: Fri, 23 Aug 2024 10:24:10 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: <45UzLuBpkdqiMiRzz-SVYtQbplWB-oWRcC9k6w5gYps=.dd750e61-a429-420c-8bd1-ccc35787bed0@github.com> On Wed, 31 Jul 2024 13:53:39 GMT, HempushpaSahu wrote: > Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. > OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. > > Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 Duplicate of https://github.com/openjdk/jdk17u-dev/pull/2747. Hence, closing this PR Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2754#issuecomment-2306782385 From duke at openjdk.org Fri Aug 23 10:24:10 2024 From: duke at openjdk.org (HempushpaSahu) Date: Fri, 23 Aug 2024 10:24:10 GMT Subject: [jdk17u-dev] Withdrawn: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts In-Reply-To: References: Message-ID: <53pE9GNes3sDJP8ig-o-_54VuROth59bLIYoVpPWMO0=.f8a6155f-b8c3-4f2d-9cf2-ca929aeda733@github.com> On Wed, 31 Jul 2024 13:53:39 GMT, HempushpaSahu wrote: > Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. > OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue. > > Reported issue : https://bugs.openjdk.org/browse/JDK-8179502 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2754 From shade at openjdk.org Fri Aug 23 10:37:08 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 23 Aug 2024 10:37:08 GMT Subject: [jdk21u-dev] RFR: 8338748: Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 15:48:49 GMT, SendaoYan wrote: > Hi all, > Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u. > Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. Is this a 17u/21u-specific fix? I believe the style is to prepend the synopsis with `[17u, 21u] ...` then. Missing context: [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) is only available in JDK 22, this is why this fails. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2306805323 From shade at openjdk.org Fri Aug 23 10:39:07 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 23 Aug 2024 10:39:07 GMT Subject: [jdk23u] RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java [v2] In-Reply-To: References: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Message-ID: On Thu, 22 Aug 2024 19:42:44 GMT, Mimoun Ghordou wrote: >> Clean Backport >> >> Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine > > Mimoun Ghordou has updated the pull request incrementally with one additional commit since the last revision: > > 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation Marked as reviewed by shade (Reviewer). Please enable GHA workflows: https://github.com/ghmaimon/jdk23u/actions -- and trigger it on your branch to make sure nothing is broken. ------------- PR Review: https://git.openjdk.org/jdk23u/pull/57#pullrequestreview-2256922742 PR Comment: https://git.openjdk.org/jdk23u/pull/57#issuecomment-2306807255 From robm at openjdk.org Fri Aug 23 11:43:34 2024 From: robm at openjdk.org (Rob McKenna) Date: Fri, 23 Aug 2024 11:43:34 GMT Subject: [jdk23u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Message-ID: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) ------------- Commit messages: - Backport c89a1c35bda9002ee687b3fa267f3ef9cba78b00 Changes: https://git.openjdk.org/jdk23u/pull/84/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=84&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338696 Stats: 21 lines in 1 file changed: 12 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk23u/pull/84.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/84/head:pull/84 PR: https://git.openjdk.org/jdk23u/pull/84 From syan at openjdk.org Fri Aug 23 15:01:10 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 23 Aug 2024 15:01:10 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 10:34:32 GMT, Aleksey Shipilev wrote: > Is this a 17u/21u-specific fix? I believe the style is to prepend the synopsis with `[17u, 21u] ...` then. > > Missing context: [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) is only available in JDK 22, this is why this fails. Thanks for the reminding, it's a 17u/21u-specific fix, the jbs title has been updated, and the missing context has been added. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2307268023 From bpb at openjdk.org Fri Aug 23 15:28:03 2024 From: bpb at openjdk.org (Brian Burkhalter) Date: Fri, 23 Aug 2024 15:28:03 GMT Subject: [jdk23u] RFR: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: <5dS3--E38olED-JYHWlwyRhenvAAtSx1vhewdjxUtlk=.fc3d8028-076b-4447-8bf9-e0aaaa0d38e0@github.com> On Fri, 23 Aug 2024 11:38:15 GMT, Rob McKenna wrote: > 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Looks fine. ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/84#pullrequestreview-2257519255 From syan at openjdk.org Fri Aug 23 15:37:04 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 23 Aug 2024 15:37:04 GMT Subject: [jdk21u-dev] Integrated: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" In-Reply-To: References: Message-ID: <9fjbo8ChjgieSzQBrkbhUL_w_nkwEQ861TzVrxpe3EA=.00278712-f4bf-470f-b35a-496efc99f2f7@github.com> On Fri, 16 Aug 2024 14:26:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [fa7521b2](https://github.com/openjdk/jdk/commit/fa7521b29eef39aeecb307f239c6d16898085984) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 24 Jun 2024 and was reviewed by Markus Gr?nlund. > > We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196. Clean backport , test fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: e79f9b44 Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/e79f9b447c9bf1bcb2244689a08c9207737539c9 Stats: 37 lines in 1 file changed: 16 ins; 0 del; 21 mod 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" Backport-of: fa7521b29eef39aeecb307f239c6d16898085984 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/931 From duke at openjdk.org Fri Aug 23 15:38:12 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Fri, 23 Aug 2024 15:38:12 GMT Subject: [jdk21u-dev] Integrated: 8335743: jhsdb jstack cannot print some information on the waiting thread In-Reply-To: References: Message-ID: On Fri, 19 Jul 2024 09:02:41 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8335743. > It is clean, but JDK-8336284 reports that the tests fails due to JDK-8335743. I think that JDK-8335743 and JDK-8336284 should be backported at the same time. > I created the pull request https://github.com/openjdk/jdk21u-dev/pull/854 which backports JDK-8336284. > > Testing: > hotspot/jtreg/serviceability/sa and jdk/sun/tools/jhsdb This pull request has now been integrated. Changeset: b8038eac Author: KIRIYAMA Takuya Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/b8038eac4b92b0bc1a82aa2c423d8c479ccc6e41 Stats: 25 lines in 4 files changed: 18 ins; 0 del; 7 mod 8335743: jhsdb jstack cannot print some information on the waiting thread Backport-of: d6c6847e32673d36a1958cefd1851ec9f3b1e2ad ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/853 From duke at openjdk.org Fri Aug 23 15:42:46 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Fri, 23 Aug 2024 15:42:46 GMT Subject: [jdk21u-dev] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request is the backport of JDK-8336284 . > It is clean. This change resolves a test failure introduced by JDK-8335743. > JDK-8335743 will be backported in https://github.com/openjdk/jdk21u-dev/pull/853. > I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/854/files - new: https://git.openjdk.org/jdk21u-dev/pull/854/files/31a4b739..31a4b739 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=854&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=854&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/854.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/854/head:pull/854 PR: https://git.openjdk.org/jdk21u-dev/pull/854 From syan at openjdk.org Fri Aug 23 15:58:04 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 23 Aug 2024 15:58:04 GMT Subject: [jdk21u-dev] RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" In-Reply-To: References: Message-ID: <7LREDsAh-FuUuo2ggUxzuOIL5sj0gA9osMUnthg_uqc=.65f322d8-6752-44e3-960b-e50af8196046@github.com> On Fri, 16 Aug 2024 14:26:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [fa7521b2](https://github.com/openjdk/jdk/commit/fa7521b29eef39aeecb307f239c6d16898085984) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 24 Jun 2024 and was reviewed by Markus Gr?nlund. > > We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196. Clean backport , test fix only, no risk. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/931#issuecomment-2307367089 From phh at openjdk.org Fri Aug 23 16:31:07 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 23 Aug 2024 16:31:07 GMT Subject: [jdk21u-dev] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v2] In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 15:42:46 GMT, KIRIYAMA Takuya wrote: >> Hi all, >> This pull request is the backport of JDK-8336284 . >> It is clean. This change resolves a test failure introduced by JDK-8335743. >> JDK-8335743 will be backported in https://github.com/openjdk/jdk21u-dev/pull/853. >> I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. > > KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. This PR contains code from the backport of JDK-8335743, which latter has been merged. Please remerge this PR. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/854#pullrequestreview-2257629428 From robm at openjdk.org Fri Aug 23 16:39:03 2024 From: robm at openjdk.org (Rob McKenna) Date: Fri, 23 Aug 2024 16:39:03 GMT Subject: [jdk23u] Integrated: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 11:38:15 GMT, Rob McKenna wrote: > 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) This pull request has now been integrated. Changeset: 3e845108 Author: Rob McKenna URL: https://git.openjdk.org/jdk23u/commit/3e8451082235e638d92792fe0b5e45abe6522b2f Stats: 21 lines in 1 file changed: 12 ins; 0 del; 9 mod 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Reviewed-by: bpb Backport-of: c89a1c35bda9002ee687b3fa267f3ef9cba78b00 ------------- PR: https://git.openjdk.org/jdk23u/pull/84 From duke at openjdk.org Fri Aug 23 17:11:13 2024 From: duke at openjdk.org (duke) Date: Fri, 23 Aug 2024 17:11:13 GMT Subject: [jdk17u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: <8MRRKEJZgif7BUHzNkXJzBzoveJx7J5c7io49yfd_dA=.db468128-1350-4353-ad7e-196c1442297d@github.com> References: <8MRRKEJZgif7BUHzNkXJzBzoveJx7J5c7io49yfd_dA=.db468128-1350-4353-ad7e-196c1442297d@github.com> Message-ID: On Wed, 14 Aug 2024 17:09:36 GMT, Daniel Hu wrote: > Backporting JDK-8312049 that improves ClassLoadUnloadTest; already backported to [JDK21](https://github.com/openjdk/jdk21u-dev/pull/909). Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Additionally, some args in exec() were not added until a [later version](https://bugs.openjdk.org/browse/JDK-8289184), thus they have been excluded. > > Passes tier1 tests on Linux x86 and the test itself. @cost0much Your change (at version ccdfa9a5f7963fc92e74721a7ca2ee41c2101dc6) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2806#issuecomment-2307485185 From duke at openjdk.org Fri Aug 23 17:11:04 2024 From: duke at openjdk.org (duke) Date: Fri, 23 Aug 2024 17:11:04 GMT Subject: [jdk21u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 22:51:33 GMT, Daniel Hu wrote: > Clean backport. Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes tier1 tests on linux x64 and the test itself. @cost0much Your change (at version 71f2cdddb3ece681c620e5052a0a82c8a9442711) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/918#issuecomment-2307485772 From duke at openjdk.org Fri Aug 23 17:19:40 2024 From: duke at openjdk.org (Daniel Hu) Date: Fri, 23 Aug 2024 17:19:40 GMT Subject: [jdk17u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Message-ID: Backport of improvements to DataDescriptorSignatureMissing test; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/913). Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. Affected test passes. ------------- Commit messages: - Backport 07eaea8c25bae6ed852685f082f8b50c5b20c1a9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2812/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2812&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303920 Stats: 158 lines in 1 file changed: 52 ins; 38 del; 68 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2812.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2812/head:pull/2812 PR: https://git.openjdk.org/jdk17u-dev/pull/2812 From duke at openjdk.org Fri Aug 23 17:21:04 2024 From: duke at openjdk.org (Daniel Hu) Date: Fri, 23 Aug 2024 17:21:04 GMT Subject: [jdk21u-dev] Integrated: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 22:51:33 GMT, Daniel Hu wrote: > Clean backport. Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes tier1 tests on linux x64 and the test itself. This pull request has now been integrated. Changeset: 4f286127 Author: Daniel Hu Committer: Ben Taylor URL: https://git.openjdk.org/jdk21u-dev/commit/4f286127b4221c6173f914e22d9ddb9790b1f634 Stats: 12 lines in 1 file changed: 2 ins; 0 del; 10 mod 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Backport-of: f6be922952642f40dcf0d27b7896c9a6acdd6378 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/918 From duke at openjdk.org Fri Aug 23 17:42:09 2024 From: duke at openjdk.org (Daniel Hu) Date: Fri, 23 Aug 2024 17:42:09 GMT Subject: [jdk17u-dev] Integrated: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: <8MRRKEJZgif7BUHzNkXJzBzoveJx7J5c7io49yfd_dA=.db468128-1350-4353-ad7e-196c1442297d@github.com> References: <8MRRKEJZgif7BUHzNkXJzBzoveJx7J5c7io49yfd_dA=.db468128-1350-4353-ad7e-196c1442297d@github.com> Message-ID: <2sSOzfz3kQ0dns-VFyj1d0-oU043_U9bQK7YIa0ewik=.fbc28278-f161-4aca-b986-aa4ea75850bf@github.com> On Wed, 14 Aug 2024 17:09:36 GMT, Daniel Hu wrote: > Backporting JDK-8312049 that improves ClassLoadUnloadTest; already backported to [JDK21](https://github.com/openjdk/jdk21u-dev/pull/909). Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Additionally, some args in exec() were not added until a [later version](https://bugs.openjdk.org/browse/JDK-8289184), thus they have been excluded. > > Passes tier1 tests on Linux x86 and the test itself. This pull request has now been integrated. Changeset: be4f913e Author: Daniel Hu Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/be4f913efab46b601f7cc472d654b4da883df152 Stats: 34 lines in 1 file changed: 3 ins; 6 del; 25 mod 8312049: runtime/logging/ClassLoadUnloadTest can be improved Reviewed-by: phh Backport-of: 4676b40f17dd18941f5883cb9b989ad639992a50 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2806 From phh at openjdk.org Fri Aug 23 18:30:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 23 Aug 2024 18:30:11 GMT Subject: [jdk17u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 21:11:51 GMT, Daniel Hu wrote: > Backport of improvements to DataDescriptorSignatureMissing test; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/913). Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. Affected test passes. Looks like a clean backport from 21u. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2812#pullrequestreview-2257851515 From duke at openjdk.org Fri Aug 23 20:19:31 2024 From: duke at openjdk.org (Daniel Hu) Date: Fri, 23 Aug 2024 20:19:31 GMT Subject: [jdk17u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Message-ID: Clean backport; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/918). Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes affected test. ------------- Commit messages: - Backport f6be922952642f40dcf0d27b7896c9a6acdd6378 Changes: https://git.openjdk.org/jdk17u-dev/pull/2821/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2821&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316193 Stats: 12 lines in 1 file changed: 2 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2821.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2821/head:pull/2821 PR: https://git.openjdk.org/jdk17u-dev/pull/2821 From duke at openjdk.org Fri Aug 23 20:50:42 2024 From: duke at openjdk.org (Daniel Hu) Date: Fri, 23 Aug 2024 20:50:42 GMT Subject: [jdk11u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved Message-ID: Backport that improves ClassLoadUnloadTest; already backported to [JDK21](https://github.com/openjdk/jdk21u-dev/pull/909) and [JDK17](https://github.com/openjdk/jdk17u-dev/pull/2806). Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Some args in exec() also were not added until a [later version](https://bugs.openjdk.org/browse/JDK-8289184), thus they are excluded. Additionally, [these flags](https://bugs.openjdk.org/browse/JDK-8256718) were deprecated in a later version and thus removed from this test; simple modifications are added so that these later removed cases follow the backport logic. Affected test passes. ------------- Commit messages: - Backport 4676b40f17dd18941f5883cb9b989ad639992a50 Changes: https://git.openjdk.org/jdk11u-dev/pull/2920/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2920&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312049 Stats: 42 lines in 1 file changed: 3 ins; 6 del; 33 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2920.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2920/head:pull/2920 PR: https://git.openjdk.org/jdk11u-dev/pull/2920 From ashi at openjdk.org Sat Aug 24 03:31:14 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 24 Aug 2024 03:31:14 GMT Subject: [jdk11u-dev] RFR: 8232367: Update Reactive Streams to 1.0.3 -- tests only Message-ID: Backport of [JDK-8232367](https://bugs.openjdk.org/browse/JDK-8232367) Testing - Local: Compile passed on `MacOS 14.6.1` on Apple M1 Max - Not a test or directory containing tests: `java/net/httpclient/reactivestreams-tck/org/reactivestreams/tck/SubscriberWhiteboxVerification.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 9f6af13f9d9d9b1f7a2b6eaac96240a51cadfd72 Changes: https://git.openjdk.org/jdk11u-dev/pull/2921/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2921&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8232367 Stats: 10 lines in 1 file changed: 8 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2921.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2921/head:pull/2921 PR: https://git.openjdk.org/jdk11u-dev/pull/2921 From ashi at openjdk.org Sat Aug 24 03:39:41 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 24 Aug 2024 03:39:41 GMT Subject: [jdk21u-dev] RFR: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" Message-ID: <2zmijgxTUg-cIGusT6cUsxgqLiOlfvHmHs0HNNdNfmk=.4c5b04ca-5de5-4087-9546-e3cd4b4ef12e@github.com> Backport of [JDK-8240343](https://bugs.openjdk.org/browse/JDK-8240343) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `vmTestbase/nsk/jdi/ListeningConnector/stopListening/stoplis001/TestDescription.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 28b201955907e145f208d756b607ab545a83b2d3 Changes: https://git.openjdk.org/jdk21u-dev/pull/944/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=944&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8240343 Stats: 34 lines in 3 files changed: 6 ins; 28 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/944.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/944/head:pull/944 PR: https://git.openjdk.org/jdk21u-dev/pull/944 From ashi at openjdk.org Sat Aug 24 04:05:41 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 24 Aug 2024 04:05:41 GMT Subject: [jdk17u-dev] RFR: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" Message-ID: Backport of [JDK-8240343](https://bugs.openjdk.org/browse/JDK-8240343) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `vmTestbase/nsk/jdi/ListeningConnector/stopListening/stoplis001/TestDescription.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 28b201955907e145f208d756b607ab545a83b2d3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2822/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2822&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8240343 Stats: 34 lines in 3 files changed: 6 ins; 28 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2822.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2822/head:pull/2822 PR: https://git.openjdk.org/jdk17u-dev/pull/2822 From syan at openjdk.org Sat Aug 24 11:10:08 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 24 Aug 2024 11:10:08 GMT Subject: [jdk21u-dev] RFR: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp In-Reply-To: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> References: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> Message-ID: On Wed, 14 Aug 2024 16:07:32 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [bf13a4e2](https://github.com/openjdk/jdk/commit/bf13a4e2819fa5bcb3e4f2281121d4e0b5535403) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by sunyaqi on 26 Feb 2024 and was reviewed by Brian Burkhalter. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/921#issuecomment-2308356311 From duke at openjdk.org Sat Aug 24 11:10:08 2024 From: duke at openjdk.org (duke) Date: Sat, 24 Aug 2024 11:10:08 GMT Subject: [jdk21u-dev] RFR: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp In-Reply-To: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> References: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> Message-ID: On Wed, 14 Aug 2024 16:07:32 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [bf13a4e2](https://github.com/openjdk/jdk/commit/bf13a4e2819fa5bcb3e4f2281121d4e0b5535403) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by sunyaqi on 26 Feb 2024 and was reviewed by Brian Burkhalter. > > Thanks! @sendaoYan Your change (at version aba43306691fbabd77cb9e9792f96b767f716d5a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/921#issuecomment-2308356532 From duke at openjdk.org Sat Aug 24 11:11:02 2024 From: duke at openjdk.org (duke) Date: Sat, 24 Aug 2024 11:11:02 GMT Subject: [jdk21u-dev] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 03:53:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [403fa376](https://github.com/openjdk/jdk23u/commit/403fa3760f629873258447cc9aefa09f9a27e7a4) from the [openjdk/jdk23u](https://git.openjdk.org/jdk23u) repository. > > The commit being backported was authored by SendaoYan on 20 Aug 2024 and had no reviewers. > > Make the test more robustness, test fix only, no risk. > > Thanks! @sendaoYan Your change (at version e5950c33099b17510be64509ca5f4c35b5e631fd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/938#issuecomment-2308356808 From syan at openjdk.org Sat Aug 24 11:24:07 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 24 Aug 2024 11:24:07 GMT Subject: [jdk23u] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 06:32:37 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [284671a1](https://github.com/openjdk/jdk/commit/284671a1e4fb5bfe15b20b7f41fc24415b1235ed) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Calvin Cheung on 8 Jul 2024 and was reviewed by Matias Saavedra Silva and Ioi Lam. > > Clean backport to make the test more robustness, test fix only, no risk. > > Thanks! The GHA test runner report two failures: 1. Test `compiler/c2/TestStressRecompilation.java` report JVM crash `PhaseOutput::fill_buffer(C2_MacroAssembler*, unsigned int*)` on macos-x64, I have created a jbs to record this issue. I think it's unreleated to this PR. 2. Test `java/util/Collections/RotateHuge.java` report fails `Agent 3 timed out with a timeout of 480 seconds`, I think it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/80#issuecomment-2308359777 From fyang at openjdk.org Sun Aug 25 02:29:52 2024 From: fyang at openjdk.org (Fei Yang) Date: Sun, 25 Aug 2024 02:29:52 GMT Subject: [jdk17u-dev] RFR: 8337780: RISC-V: C2: Change C calling convention for sp to NS Message-ID: 8337780: RISC-V: C2: Change C calling convention for sp to NS ------------- Commit messages: - Backport 53db937dd0766695906dc20c1dbbd3228c02fe1e Changes: https://git.openjdk.org/jdk17u-dev/pull/2823/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2823&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337780 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2823.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2823/head:pull/2823 PR: https://git.openjdk.org/jdk17u-dev/pull/2823 From fyang at openjdk.org Sun Aug 25 02:30:23 2024 From: fyang at openjdk.org (Fei Yang) Date: Sun, 25 Aug 2024 02:30:23 GMT Subject: [jdk21u-dev] RFR: 8337780: RISC-V: C2: Change C calling convention for sp to NS Message-ID: 8337780: RISC-V: C2: Change C calling convention for sp to NS ------------- Commit messages: - Backport 53db937dd0766695906dc20c1dbbd3228c02fe1e Changes: https://git.openjdk.org/jdk21u-dev/pull/945/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=945&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337780 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/945.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/945/head:pull/945 PR: https://git.openjdk.org/jdk21u-dev/pull/945 From syan at openjdk.org Sun Aug 25 09:40:33 2024 From: syan at openjdk.org (SendaoYan) Date: Sun, 25 Aug 2024 09:40:33 GMT Subject: [jdk23u] RFR: 8337165: Test jdk/jfr/event/gc/stacktrace/TestG1YoungAllocationPendingStackTrace.java failed: IndexOutOfBoundsException: Index 64 out of bounds for length 64 Message-ID: Hi all, This pull request contains a backport of commit [9124a94e](https://github.com/openjdk/jdk/commit/9124a94e383f5bc6a3376eecc97ee8bd22f9e420) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Erik Gahlin on 29 Jul 2024 and was reviewed by Paul Hohensee. Thanks! ------------- Commit messages: - Backport 9124a94e383f5bc6a3376eecc97ee8bd22f9e420 Changes: https://git.openjdk.org/jdk23u/pull/85/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=85&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337165 Stats: 31 lines in 10 files changed: 20 ins; 1 del; 10 mod Patch: https://git.openjdk.org/jdk23u/pull/85.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/85/head:pull/85 PR: https://git.openjdk.org/jdk23u/pull/85 From duke at openjdk.org Mon Aug 26 01:03:28 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Mon, 26 Aug 2024 01:03:28 GMT Subject: [jdk21u-dev] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v3] In-Reply-To: References: Message-ID: <8plZ0pI7Mnk8A2w1TXyCR3-QWs3U6e1qQy-pS0FRNd0=.d6efae01-90d0-4401-9e06-d7de3b52d0a6@github.com> > Hi all, > This pull request is the backport of JDK-8336284 . > It is clean. This change resolves a test failure introduced by JDK-8335743. > JDK-8335743 will be backported in https://github.com/openjdk/jdk21u-dev/pull/853. > I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge Master - 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 - 8335743: jhsdb jstack cannot print some information on the waiting thread ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/854/files - new: https://git.openjdk.org/jdk21u-dev/pull/854/files/31a4b739..47aecb2b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=854&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=854&range=01-02 Stats: 7169 lines in 172 files changed: 3696 ins; 1989 del; 1484 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/854.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/854/head:pull/854 PR: https://git.openjdk.org/jdk21u-dev/pull/854 From duke at openjdk.org Mon Aug 26 01:03:28 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Mon, 26 Aug 2024 01:03:28 GMT Subject: [jdk21u-dev] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v2] In-Reply-To: References: Message-ID: <3u153kvaEu-RBS9fNQ3dMlZXh1XzEWxgGTj_1p2bI-M=.ea8cac21-cb26-4847-bfe6-f71188c008ec@github.com> On Fri, 23 Aug 2024 16:28:00 GMT, Paul Hohensee wrote: >> KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. > > This PR contains code from the backport of JDK-8335743, which latter has been merged. Please remerge this PR. @phohensee Sorry, I remerged the latest changes from the master branch into this PR. Would you sponsor it, please? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/854#issuecomment-2309100913 From duke at openjdk.org Mon Aug 26 01:24:03 2024 From: duke at openjdk.org (duke) Date: Mon, 26 Aug 2024 01:24:03 GMT Subject: [jdk21u-dev] RFR: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 [v3] In-Reply-To: <8plZ0pI7Mnk8A2w1TXyCR3-QWs3U6e1qQy-pS0FRNd0=.d6efae01-90d0-4401-9e06-d7de3b52d0a6@github.com> References: <8plZ0pI7Mnk8A2w1TXyCR3-QWs3U6e1qQy-pS0FRNd0=.d6efae01-90d0-4401-9e06-d7de3b52d0a6@github.com> Message-ID: On Mon, 26 Aug 2024 01:03:28 GMT, KIRIYAMA Takuya wrote: >> Hi all, >> This pull request is the backport of JDK-8336284 . >> It is clean. This change resolves a test failure introduced by JDK-8335743. >> JDK-8335743 will be backported in https://github.com/openjdk/jdk21u-dev/pull/853. >> I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. > > KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge Master > - 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 > - 8335743: jhsdb jstack cannot print some information on the waiting thread @tkiriyama Your change (at version 47aecb2bca21d1c023c7be263d66834ae72d4800) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/854#issuecomment-2309120004 From stuefe at openjdk.org Mon Aug 26 09:14:09 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 26 Aug 2024 09:14:09 GMT Subject: [jdk21u-dev] RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 In-Reply-To: References: Message-ID: <7eEGEVsM-oSzSb9dx08p60OxMDBwfwGwthCU9hWFJZA=.285c00d4-fe76-42d6-b705-cd08670375a1@github.com> On Thu, 22 Aug 2024 12:27:44 GMT, Aleksey Shipilev wrote: > This fixes the regression introduced by [JDK-8329665](https://bugs.openjdk.org/browse/JDK-8329665), which added `ResourceMark` in `frame::oops_interpreted_do`. This is not really correct, as closures we call with that method can do resource allocations. The patch avoids this problem by cleanly allocating on C heap. > > The mainline patch wants `has_valid_mask` infrastructure added as part of [JDK-8315954](https://bugs.openjdk.org/browse/JDK-8315954). That patch has implications for Graal, and have unresolved bug tail. Therefore, I just picked up relevant infra hunks here. > > Additional testing: > - [x] Linux x86_64 server fastedebug, `all` > - [x] Linux AArch64 server fastedebug, `all` This looks good to me. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/942#pullrequestreview-2260202755 From goetz at openjdk.org Mon Aug 26 09:27:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 26 Aug 2024 09:27:08 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! Hi, all three PRs for this change have failed. tests. Why? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2309757369 From syan at openjdk.org Mon Aug 26 09:34:03 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 26 Aug 2024 09:34:03 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 09:24:03 GMT, Goetz Lindenmaier wrote: > Hi, all three PRs for this change have failed. tests. Why? Do you mean the CA tests run failed. `The test security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java fails often for very different reasons.`, that's why the prefixed PR of CA tests [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441) has marked CA tests as manually, - Sporadic networking issues. - Issues on CA side - including shaky infrastructure. - No longer valid certificates. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2309767852 From goetz at openjdk.org Mon Aug 26 09:47:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 26 Aug 2024 09:47:13 GMT Subject: [jdk17u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 21:11:51 GMT, Daniel Hu wrote: > Backport of improvements to DataDescriptorSignatureMissing test; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/913). Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. Affected test passes. Hi @cost0much, It seems you fixed the same issue as in the 21u backport. If you base your backport to 17u on the 21u commit, it is more likely to be clean. This saves work for the reviewer. ... just for the next time... ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2812#issuecomment-2309796246 From duke at openjdk.org Mon Aug 26 11:28:11 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 26 Aug 2024 11:28:11 GMT Subject: [jdk11u-dev] Withdrawn: 8336451: [11u] GHA macos-13 builder is unable to resolve local hostname In-Reply-To: References: Message-ID: On Tue, 16 Jul 2024 15:39:30 GMT, Antonio Vieiro wrote: > This fixes [JDK-8336451](https://bugs.openjdk.org/browse/JDK-8336451). > > This is a problem with the latest Github macos runners (see https://github.com/actions/runner-images/issues/8649) that makes it impossible for `getaddrinfo` to properly resolve the builder's hostname. The issue has been opened since late 2023. > > Not being able to resolve the local hostname makes `jdk/tier1` and `langtools/tier1` to fail on this platform, as the [socket transport ](https://github.com/openjdk/jdk11u-dev/blob/697d8566b1d4801cb7926fa35bbf471f8f4ba066/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c#L329) cannot establish a connection. > > There are still some other `sprintf`s in the codebase, but these do not affect the macos builds, and can be possibly backported later on, once the macos builds are again in place. > > The macos builds and tests are expected to succeed after this fix is in place. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2861 From duke at openjdk.org Mon Aug 26 11:28:10 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 26 Aug 2024 11:28:10 GMT Subject: [jdk11u-dev] RFR: 8336451: [11u] GHA macos-13 builder is unable to resolve local hostname In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 20:52:58 GMT, Martin Doerr wrote: >> This fixes [JDK-8336451](https://bugs.openjdk.org/browse/JDK-8336451). >> >> This is a problem with the latest Github macos runners (see https://github.com/actions/runner-images/issues/8649) that makes it impossible for `getaddrinfo` to properly resolve the builder's hostname. The issue has been opened since late 2023. >> >> Not being able to resolve the local hostname makes `jdk/tier1` and `langtools/tier1` to fail on this platform, as the [socket transport ](https://github.com/openjdk/jdk11u-dev/blob/697d8566b1d4801cb7926fa35bbf471f8f4ba066/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c#L329) cannot establish a connection. >> >> There are still some other `sprintf`s in the codebase, but these do not affect the macos builds, and can be possibly backported later on, once the macos builds are again in place. >> >> The macos builds and tests are expected to succeed after this fix is in place. > > LGTM, but I'm not an expert in this area. Hi @TheRealMDoerr . Thanks for the review. Github has now deployed new images that solve the problem, so this PR is no longer required, closing the PR then. [Here's a test](https://github.com/vieiro/gha-macos-resolve-hostname/actions/runs/10558777738) to verify the images work properly with `getaddrinfo`. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2861#issuecomment-2309975004 From duke at openjdk.org Mon Aug 26 11:43:11 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 26 Aug 2024 11:43:11 GMT Subject: [jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 20:56:21 GMT, Martin Doerr wrote: >> This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. >> >> The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. >> >> This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary. > > LGTM. Hi @TheRealMDoerr . Thanks for the review. Would it be possible to rerun macos jobs? (I don't have permissions to do that ). Thanks!. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2854#issuecomment-2310000072 From sshivang at openjdk.org Mon Aug 26 11:50:08 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 26 Aug 2024 11:50:08 GMT Subject: [jdk23u] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test In-Reply-To: <44iHrY0PBsttXHDPjNioUsJDqfRDE5jfzrqjVlYf-pI=.af4ecf50-f635-46ca-915e-af25d18d22ab@github.com> References: <44iHrY0PBsttXHDPjNioUsJDqfRDE5jfzrqjVlYf-pI=.af4ecf50-f635-46ca-915e-af25d18d22ab@github.com> Message-ID: On Thu, 22 Aug 2024 15:35:14 GMT, Shivangi Gupta wrote: > This is a manual test. Here are the run results:- > > /Users/dk-23.0.1.jdk/Contents/Home/bin/java -cp . Password > Two passwords will be prompted for. The first one should have echo off, the second one on. Otherwise, this test fails > Invisible: > Visible: hello > You input hello and hello @coffeys Please sponsor this change ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/82#issuecomment-2310010276 From duke at openjdk.org Mon Aug 26 11:50:08 2024 From: duke at openjdk.org (duke) Date: Mon, 26 Aug 2024 11:50:08 GMT Subject: [jdk23u] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test In-Reply-To: <44iHrY0PBsttXHDPjNioUsJDqfRDE5jfzrqjVlYf-pI=.af4ecf50-f635-46ca-915e-af25d18d22ab@github.com> References: <44iHrY0PBsttXHDPjNioUsJDqfRDE5jfzrqjVlYf-pI=.af4ecf50-f635-46ca-915e-af25d18d22ab@github.com> Message-ID: On Thu, 22 Aug 2024 15:35:14 GMT, Shivangi Gupta wrote: > This is a manual test. Here are the run results:- > > /Users/dk-23.0.1.jdk/Contents/Home/bin/java -cp . Password > Two passwords will be prompted for. The first one should have echo off, the second one on. Otherwise, this test fails > Invisible: > Visible: hello > You input hello and hello @openjdk[bot] Your change (at version 89bb9e39fe1517057e0fd2631f9e4c2aa0bb1887) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/82#issuecomment-2310013049 From sshivang at openjdk.org Mon Aug 26 12:09:03 2024 From: sshivang at openjdk.org (Shivangi Gupta) Date: Mon, 26 Aug 2024 12:09:03 GMT Subject: [jdk23u] Integrated: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test In-Reply-To: <44iHrY0PBsttXHDPjNioUsJDqfRDE5jfzrqjVlYf-pI=.af4ecf50-f635-46ca-915e-af25d18d22ab@github.com> References: <44iHrY0PBsttXHDPjNioUsJDqfRDE5jfzrqjVlYf-pI=.af4ecf50-f635-46ca-915e-af25d18d22ab@github.com> Message-ID: On Thu, 22 Aug 2024 15:35:14 GMT, Shivangi Gupta wrote: > This is a manual test. Here are the run results:- > > /Users/dk-23.0.1.jdk/Contents/Home/bin/java -cp . Password > Two passwords will be prompted for. The first one should have echo off, the second one on. Otherwise, this test fails > Invisible: > Visible: hello > You input hello and hello This pull request has now been integrated. Changeset: 069283b6 Author: Shivangi Gupta Committer: Sean Coffey URL: https://git.openjdk.org/jdk23u/commit/069283b6193f8e5302be12012ade3bb38a22b8b3 Stats: 17 lines in 3 files changed: 13 ins; 2 del; 2 mod 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Backport-of: a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 ------------- PR: https://git.openjdk.org/jdk23u/pull/82 From mdoerr at openjdk.org Mon Aug 26 12:59:11 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 26 Aug 2024 12:59:11 GMT Subject: [jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 20:56:21 GMT, Martin Doerr wrote: >> This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. >> >> The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. >> >> This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary. > > LGTM. > Hi @TheRealMDoerr . Thanks for the review. Would it be possible to rerun macos jobs? (I don't have permissions to do that ). Thanks!. I can only rerun jobs in my own PRs. You should find a rerun button next to the failing test. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2854#issuecomment-2310149110 From rob.mckenna at oracle.com Mon Aug 26 14:04:10 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 26 Aug 2024 14:04:10 +0000 Subject: CFV: New JDK Updates Committer - Ravi Reddy Message-ID: I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. Ravi is a member of the JDK Sustaining team in Oracle. He has been contributing to JDK Updates for several years now and has built up around 16 contributions across the main JDK project and various JDK Updates repositories. Votes are due by 23:59 UTC on Monday, Sept 2, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Thanks, -Rob [1] https://openjdk.org/census#rreddy [2] https://github.com/openjdk/jdk18u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk20u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ [3] https://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#committer-vote From duke at openjdk.org Mon Aug 26 14:08:13 2024 From: duke at openjdk.org (duke) Date: Mon, 26 Aug 2024 14:08:13 GMT Subject: [jdk11u-dev] Withdrawn: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop In-Reply-To: References: Message-ID: On Mon, 1 Jul 2024 08:51:13 GMT, Antonio Vieiro wrote: > Backport of [JDK-8272973](https://bugs.openjdk.org/browse/JDK-8272973). > > Parity with 11.0.25-oracle. > > Test passes in both `release` and `fastdebug` mode with `private static final int iter = 10_000;` > > But with `private static final int iter = 20_000;` the test passes in `release` mode, but **fails in `fastdebug` mode** with **`assert(n->req() == 2 && n->in(1) != __null) failed: Only one data input expected`**: > > > # To suppress the following error report, specify this argument > # after -XX: or in .hotspotrc: SuppressErrorAt=/cfgnode.cpp:621 > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (/home/avieirov/REPOS/OPENJDK/jdk11u-dev/src/hotspot/share/opto/cfgnode.cpp:621), pid=1641259, tid=1641275 > # assert(n->req() == 2 && n->in(1) != __null) failed: Only one data input expected > # > # JRE version: OpenJDK Runtime Environment (11.0.25) (fastdebug build 11.0.25-internal+0-adhoc.avieirov.jdk11u-dev) > # Java VM: OpenJDK 64-Bit Server VM (fastdebug 11.0.25-internal+0-adhoc.avieirov.jdk11u-dev, mixed mode, compressed oops, g1 gc, linux-amd64) > ... > > > We may either: > > 1. Keep max iteration to `10_000`, so at least this test runs (in both `release` and `fastdebug` modes) which seems to be the goal of 8272973. > 2. Or try to first backport [JDK-8312438](https://bugs.openjdk.org/browse/JDK-8312438) which in turn seems to be related to [JDK-8263577](https://bugs.openjdk.org/browse/JDK-8263577) with seems to be a significant change [20297a1b](https://github.com/openjdk/jdk/commit/20297a1b) > > Please let me know preferred way to proceed. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2828 From rob.mckenna at oracle.com Mon Aug 26 14:14:47 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 26 Aug 2024 14:14:47 +0000 Subject: CFV: New JDK Updates Committer - Ravi Reddy In-Reply-To: References: Message-ID: Apologies, the deadline should be Monday, Sep 9 2024. -Rob ________________________________________ From: Robert Mckenna Sent: Monday 26 August 2024 15:04 To: jdk-updates-dev at openjdk.org Cc: Robert Mckenna; Ravi Reddy Subject: CFV: New JDK Updates Committer - Ravi Reddy I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. Ravi is a member of the JDK Sustaining team in Oracle. He has been contributing to JDK Updates for several years now and has built up around 16 contributions across the main JDK project and various JDK Updates repositories. Votes are due by 23:59 UTC on Monday, Sept 2, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Thanks, -Rob [1] https://openjdk.org/census#rreddy [2] https://github.com/openjdk/jdk18u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk20u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ [3] https://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#committer-vote From sean.coffey at oracle.com Mon Aug 26 15:57:31 2024 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=C3=A1n_Coffey?=) Date: Mon, 26 Aug 2024 16:57:31 +0100 Subject: CFV: New JDK Updates Committer - Ravi Reddy In-Reply-To: References: Message-ID: <38686814-c9a4-432c-98df-f3fa6e4c8992@oracle.com> Vote: Yes regards, Sean. On 26/08/2024 15:04, Robert Mckenna wrote: > I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. > > Ravi is a member of the JDK Sustaining team in Oracle. He has been contributing to JDK Updates for several years now and has built up around 16 contributions across the main JDK project and various JDK Updates repositories. > > Votes are due by 23:59 UTC on Monday, Sept 2, 2024. > > Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > For Lazy Consensus voting instructions, see [4]. > > Thanks, > > -Rob > > [1] https://openjdk.org/census#rreddy > [2] https://github.com/openjdk/jdk18u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk20u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > [3] https://openjdk.java.net/census#jdk-updates > [4] http://openjdk.java.net/projects/#committer-vote From duke at openjdk.org Mon Aug 26 16:12:04 2024 From: duke at openjdk.org (duke) Date: Mon, 26 Aug 2024 16:12:04 GMT Subject: [jdk17u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 21:11:51 GMT, Daniel Hu wrote: > Backport of improvements to DataDescriptorSignatureMissing test; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/913). Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. Affected test passes. @cost0much Your change (at version 1913854ea58a0540d44fbfdda73a68c152d9658a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2812#issuecomment-2310564784 From duke at openjdk.org Mon Aug 26 16:12:11 2024 From: duke at openjdk.org (duke) Date: Mon, 26 Aug 2024 16:12:11 GMT Subject: [jdk21u-dev] RFR: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 [v2] In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 16:12:24 GMT, Daniel Hu wrote: >> Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120) afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because [JDK-8310308](https://github.com/openjdk/jdk21u-dev/pull/29) has already backported a later fix to VectorLogicalOpIdentityTest.java. >> >> Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change. > > Daniel Hu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Updated copyright year for VectorLogicalOpIdentityTest > - Merge branch 'openjdk:master' into JDK-8309894 > - Backport 60544f9088c11e4718a9cd77f21792c6ba387440 @cost0much Your change (at version 2172e385626c81fa44678fddae2202f903abfab9) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/922#issuecomment-2310565449 From duke at openjdk.org Mon Aug 26 16:12:17 2024 From: duke at openjdk.org (duke) Date: Mon, 26 Aug 2024 16:12:17 GMT Subject: [jdk17u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 17:37:07 GMT, Daniel Hu wrote: > Clean backport; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/918). Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes affected test. @cost0much Your change (at version c01da060f2b5d3473223f4516138ed8f2a22d574) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2821#issuecomment-2310565147 From ashi at openjdk.org Mon Aug 26 16:18:07 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 16:18:07 GMT Subject: [jdk11u-dev] Integrated: 8206440: Remove javac -source/-target 6 from jdk regression tests In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 00:00:16 GMT, Amos Shi wrote: > Backport of [JDK-8206440](https://bugs.openjdk.org/browse/JDK-8206440) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `OldenCompilingWithDefaults.java`: Test results: passed: 1 > - Pipeline: All passed except `macOS` > -`macOS`: `/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here` The issue exists in all recent PR in [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/pulls) and not caused by Current PR > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier1`, Started at `2024-08-22 20:22:52+01:00` > - java/lang/reflect/OldenCompilingWithDefaults.java: SUCCESSFUL GitHub ? - [20:28:58.734 -> 249 msec] This pull request has now been integrated. Changeset: d3ce405a Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/d3ce405a142008b2265efdca4fc9b764c877d882 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8206440: Remove javac -source/-target 6 from jdk regression tests Backport-of: d2de786263e01b2036609621268853b14a1f46c3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2915 From ashi at openjdk.org Mon Aug 26 16:19:08 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 16:19:08 GMT Subject: [jdk11u-dev] Integrated: 8224081: SOCKS v4 tests require IPv4 In-Reply-To: <0PCaA37dhYcHBhDP5LQLoLQVw-NERKM5Oq5a6RJGSsg=.daf30e5e-61bb-46e2-8ebd-27abfa433d0a@github.com> References: <0PCaA37dhYcHBhDP5LQLoLQVw-NERKM5Oq5a6RJGSsg=.daf30e5e-61bb-46e2-8ebd-27abfa433d0a@github.com> Message-ID: On Wed, 21 Aug 2024 00:26:24 GMT, Amos Shi wrote: > Backport of [JDK-8224081](https://bugs.openjdk.org/browse/JDK-8224081) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `SocksProxyVersion.java`: Test results: passed: 1 > - Pipeline: All passed except `macOS` > - `macOS`: `/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here` The issue exists in all recent PR in [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/pulls) and not caused by Current PR > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-22 21:36:00+01:00` > - java/net/Socks/SocksProxyVersion.java: SUCCESSFUL GitHub ? - [21:49:09.044 -> 548 msec] This pull request has now been integrated. Changeset: 9ba9dd27 Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/9ba9dd276cebd7e0069bc229ed7b5b4db795fb2c Stats: 15 lines in 2 files changed: 6 ins; 0 del; 9 mod 8224081: SOCKS v4 tests require IPv4 Backport-of: acad8d1d68c8c0ad5fc93b0d1c01197428a25bfe ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2917 From ashi at openjdk.org Mon Aug 26 16:20:16 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 16:20:16 GMT Subject: [jdk11u-dev] Integrated: 8210338: Better output for GenerationTests.java In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 00:12:53 GMT, Amos Shi wrote: > Backport of [JDK-8210338](https://bugs.openjdk.org/browse/JDK-8210338) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `GenerationTests.java`: Test results: passed: 1 > - Pipeline: All passed except `macOS` > - `macOS`: `/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here` The issue exists in all recent PR in [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/pulls) and not caused by Current PR > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-22 21:36:00+01:00` > - javax/xml/crypto/dsig/GenerationTests.java: SUCCESSFUL GitHub ? - [21:59:45.106 -> 127,518 msec] This pull request has now been integrated. Changeset: 3df18523 Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/3df18523abaf771a5ce8981dd3663f4004fefd62 Stats: 13 lines in 1 file changed: 4 ins; 0 del; 9 mod 8210338: Better output for GenerationTests.java Backport-of: a5f7028279d61313b2293bbac3eaba0c880a7430 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2916 From duke at openjdk.org Mon Aug 26 16:23:14 2024 From: duke at openjdk.org (Daniel Hu) Date: Mon, 26 Aug 2024 16:23:14 GMT Subject: [jdk17u-dev] Integrated: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 17:37:07 GMT, Daniel Hu wrote: > Clean backport; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/918). Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes affected test. This pull request has now been integrated. Changeset: 97e4a937 Author: Daniel Hu Committer: Victor Rudometov URL: https://git.openjdk.org/jdk17u-dev/commit/97e4a9374922bd8fd84e1315f89b189669a7b6d0 Stats: 12 lines in 1 file changed: 2 ins; 0 del; 10 mod 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Backport-of: f6be922952642f40dcf0d27b7896c9a6acdd6378 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2821 From duke at openjdk.org Mon Aug 26 16:24:06 2024 From: duke at openjdk.org (Daniel Hu) Date: Mon, 26 Aug 2024 16:24:06 GMT Subject: [jdk17u-dev] Integrated: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 21:11:51 GMT, Daniel Hu wrote: > Backport of improvements to DataDescriptorSignatureMissing test; already [backported to 21](https://github.com/openjdk/jdk21u-dev/pull/913). Unclean for this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport. Affected test passes. This pull request has now been integrated. Changeset: 64ab2faa Author: Daniel Hu Committer: Victor Rudometov URL: https://git.openjdk.org/jdk17u-dev/commit/64ab2faaddb0e7a81dd0139dbb178ef31b1aa40e Stats: 158 lines in 1 file changed: 52 ins; 38 del; 68 mod 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Reviewed-by: phh Backport-of: 07eaea8c25bae6ed852685f082f8b50c5b20c1a9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2812 From duke at openjdk.org Mon Aug 26 16:24:09 2024 From: duke at openjdk.org (Daniel Hu) Date: Mon, 26 Aug 2024 16:24:09 GMT Subject: [jdk21u-dev] Integrated: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 In-Reply-To: References: Message-ID: <18CnTqVvADu1Ti8QzfDSZc2IE5kqcVygxi143Sn2Fl0=.bbb450f6-97c8-4192-826b-83cf8878581c@github.com> On Wed, 14 Aug 2024 22:31:44 GMT, Daniel Hu wrote: > Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120) afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because [JDK-8310308](https://github.com/openjdk/jdk21u-dev/pull/29) has already backported a later fix to VectorLogicalOpIdentityTest.java. > > Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change. This pull request has now been integrated. Changeset: fe470759 Author: Daniel Hu Committer: Victor Rudometov URL: https://git.openjdk.org/jdk21u-dev/commit/fe470759515e0e9fa689b251eda53506787c3b34 Stats: 46 lines in 4 files changed: 33 ins; 9 del; 4 mod 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 Reviewed-by: phh Backport-of: 60544f9088c11e4718a9cd77f21792c6ba387440 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/922 From ashi at openjdk.org Mon Aug 26 17:31:10 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 17:31:10 GMT Subject: [jdk17u-dev] Integrated: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException In-Reply-To: References: Message-ID: <2amlH_PbZVx5oU_BwEZP6oDfQOUFgW64fnY4OIPcaA0=.0f4b5ac9-1922-4ebb-b028-1837fba08f0d@github.com> On Thu, 22 Aug 2024 00:46:49 GMT, Amos Shi wrote: > Backport of [JDK-8332248](https://bugs.openjdk.org/browse/JDK-8332248) > > Testing > - Local: Test not executed on `MacOS 14.6.1` on Apple M1 Max, because `@requires (os.family == "linux")` > - `BlockDeviceSize.java`: Test results: **no tests selected** > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-23 19:44:34+01:00` > - java/nio/channels/FileChannel/BlockDeviceSize.java: SUCCESSFUL GitHub ? - [19:56:22.058 -> 143 msec] This pull request has now been integrated. Changeset: 1887a802 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/1887a80260abc7d5ef4fb70a7a7a740751fdb398 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException Backport-of: 0bb5ae645165b97527ecccf02308df6072c363d8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2818 From aleksej.efimov at oracle.com Mon Aug 26 18:05:41 2024 From: aleksej.efimov at oracle.com (Aleksei Efimov) Date: Mon, 26 Aug 2024 18:05:41 +0000 Subject: CFV: New JDK Updates Committer - Ravi Reddy In-Reply-To: References: Message-ID: Vote: yes With Best Regards, Aleksei ________________________________ From: jdk-updates-dev on behalf of Robert Mckenna Sent: 26 August 2024 3:04 PM To: jdk-updates-dev at openjdk.org Cc: Robert Mckenna ; Ravi Reddy Subject: CFV: New JDK Updates Committer - Ravi Reddy I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. Ravi is a member of the JDK Sustaining team in Oracle. He has been contributing to JDK Updates for several years now and has built up around 16 contributions across the main JDK project and various JDK Updates repositories. Votes are due by 23:59 UTC on Monday, Sept 2, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Thanks, -Rob [1] https://openjdk.org/census#rreddy [2] https://github.com/openjdk/jdk18u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk20u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ [3] https://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#committer-vote -------------- next part -------------- An HTML attachment was scrubbed... URL: From lance.andersen at oracle.com Mon Aug 26 18:11:46 2024 From: lance.andersen at oracle.com (Lance Andersen) Date: Mon, 26 Aug 2024 18:11:46 +0000 Subject: CFV: New JDK Updates Committer - Ravi Reddy In-Reply-To: References: Message-ID: <5DCBB6F3-90A2-45AE-B539-2DFE26CE3D93@oracle.com> Vote: yes ________________________________ From: jdk-updates-dev > on behalf of Robert Mckenna > Sent: 26 August 2024 3:04 PM To: jdk-updates-dev at openjdk.org > Cc: Robert Mckenna >; Ravi Reddy > Subject: CFV: New JDK Updates Committer - Ravi Reddy I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. Ravi is a member of the JDK Sustaining team in Oracle. He has been contributing to JDK Updates for several years now and has built up around 16 contributions across the main JDK project and various JDK Updates repositories. Votes are due by 23:59 UTC on Monday, Sept 2, 2024. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ashi at openjdk.org Mon Aug 26 18:51:14 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 18:51:14 GMT Subject: [jdk11u-dev] Integrated: 8325022: Incorrect error message on client authentication In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 00:56:35 GMT, Amos Shi wrote: > Backport of [JDK-8325022](https://bugs.openjdk.org/browse/JDK-8325022) > > Testing > - Local: > - Build passed on `MacOS 14.6.1` on Apple M1 Max > - No applicable test case > - Pipeline: > - Linux and Windows - passed > - Mac - `adlparse.cpp:214:11: error: 'sprintf' is deprecated` - this message is not caused by current PR > - `src/hotspot/share/adlc/archDesc.cpp:813:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.` > - The line `archDesc.cpp:813` was introduced 13 years ago via https://github.com/openjdk/jdk11u-dev/commit/07d9df5a7fb64f3c7252686d647fa3a5da8e8771 > - See https://github.com/openjdk/jdk11u-dev/blame/master/src/hotspot/share/adlc/archDesc.cpp#L813C5-L813C46 > - Testing Machine: SAP nightlies Passed on `2024-08-16` (No side effect caused by this PR found) This pull request has now been integrated. Changeset: c67fe36b Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/c67fe36b5fefee554c0d1067f209387606011615 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8325022: Incorrect error message on client authentication Backport-of: fe78c0f1911c9fdc1d30e23847d102748dfa2063 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2899 From ashi at openjdk.org Mon Aug 26 18:51:14 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 18:51:14 GMT Subject: [jdk17u-dev] Integrated: 8310683: Refactor StandardCharset/standard.java to use JUnit In-Reply-To: References: Message-ID: On Sat, 17 Aug 2024 03:38:02 GMT, Amos Shi wrote: > Backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `Standard.java`: Test results: passed: 1 > - Pipeline: All passed except `macos-aarch64` > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-23 19:44:34+01:00` > - java/nio/charset/StandardCharsets/Standard.java: SUCCESSFUL GitHub ? - [19:56:50.020 -> 3,680 msec] This pull request has now been integrated. Changeset: cd0bb4d3 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/cd0bb4d31ee53947234c717782f9d9bf9b488986 Stats: 128 lines in 1 file changed: 49 ins; 28 del; 51 mod 8310683: Refactor StandardCharset/standard.java to use JUnit Backport-of: 4e84d4dc514192e4cdf8e2c7c474847832987ab9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2814 From ashi at openjdk.org Mon Aug 26 18:52:09 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 18:52:09 GMT Subject: [jdk17u-dev] Integrated: 8302800: Augment NaN handling tests of FDLIBM methods In-Reply-To: References: Message-ID: On Sat, 3 Aug 2024 00:04:48 GMT, Amos Shi wrote: > Backport of [JDK-8302800](https://bugs.openjdk.org/browse/JDK-8302800) > - This PR contains two PR > - `commit 1` is made by the `git apply` which is `clean` > - `commit 2` adds the missing file `test/jdk/java/lang/Math/InverseTrigTests.java` currently does not exist in `jdk17u-dev`, it was originally added by [JDK-8302026](https://bugs.openjdk.org/browse/JDK-8302026) via [commit](https://github.com/openjdk/jdk/commit/3ba156082b73c4a8e9d890a57a42fb68df2bf98f) > > Testing > - Local: Test passed on `MacOS 14.5` on Apple M1 Max > - `CubeRootTests.java`: Test results: passed: 1 > - `Expm1Tests.java`: Test results: passed: 1 > - `HyperbolicTests.java`: Test results: passed: 1 > - `Log10Tests.java`: Test results: passed: 1 > - `Log1pTests.java`: Test results: passed: 1 > - `Tests.java`: Not applicable: not a test > - `InverseTrigTests.java`: Test results: passed: 1 > - Pipeline: > - Linux, Windows - Passed > - MacOS - Skipped (`This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.`) > - Testing Machine: SAP nightlies Passed on `2024-08-07` > - Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00 > - java/lang/Math/CubeRootTests.java: SUCCESSFUL GitHub ? - [20:41:53.428 -> 166 msec] > - java/lang/Math/Expm1Tests.java: SUCCESSFUL GitHub ? - [20:41:54.175 -> 253 msec] > - java/lang/Math/HyperbolicTests.java: SUCCESSFUL GitHub ? - [20:41:54.428 -> 307 msec] > - java/lang/Math/Log10Tests.java: SUCCESSFUL GitHub ? - [20:41:55.238 -> 196 msec] > - java/lang/Math/Log1pTests.java: SUCCESSFUL GitHub ? - [20:41:55.434 -> 202 msec] > - java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub ? - [20:41:55.038 -> 199 msec] This pull request has now been integrated. Changeset: 803c2c27 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/803c2c27d88ee0948611f11f1d099d7fe5c7d593 Stats: 363 lines in 7 files changed: 269 ins; 77 del; 17 mod 8302800: Augment NaN handling tests of FDLIBM methods Reviewed-by: mbaesken Backport-of: dfce4e1943f2f95b74b5a9cdde9d738dcffd0b43 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2779 From ashi at openjdk.org Mon Aug 26 18:53:10 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 18:53:10 GMT Subject: [jdk17u-dev] Integrated: 8315024: Vector API FP reduction tests should not test for exact equality In-Reply-To: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> References: <-edGmhIpY4b7FfFodre93CB9JtPnyMR4UkCpUSIIMxo=.0716a2fe-a617-4ffb-a578-267d438a59b3@github.com> Message-ID: On Thu, 1 Aug 2024 17:10:40 GMT, Amos Shi wrote: > Backport of [JDK-8315024](https://bugs.openjdk.org/browse/JDK-8315024) > - This PR has two commits > - `commit 1`: the git apply result, which is `clean` > - `commit 2`: manually merge the following two `.rej` files > - `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > - `test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java.rej` > - `commit 3,4`: Fix code postion > - `commit 5`: Add file `Unit-header.template` > > Content of `test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java.rej` > > > @@ -668,15 +670,21 @@ > > static void assertReductionArraysEquals(double[] r, double rc, double[] a, > FReductionOp f, FReductionAllOp fa) { > + assertReductionArraysEquals(r, rc, a, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEquals(double[] r, double rc, double[] a, > + FReductionOp f, FReductionAllOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a)); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError)); > for (; i < a.length; i += SPECIES.length()) { > - Assert.assertEquals(r[i], f.apply(a, i)); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError)); > } > } catch (AssertionError e) { > - Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); > - Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); > + Assert.assertEquals(rc, fa.apply(a), Math.abs(rc * relativeError), "Final result is incorrect!"); > + Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i); > } > } > > @@ -690,15 +698,22 @@ > > static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > FReductionMaskedOp f, FReductionAllMaskedOp fa) { > + assertReductionArraysEqualsMasked(r, rc, a, mask, f, fa, (double)0.0); > + } > + > + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, > + FReductionMaskedOp f, FReductionAllMaskedOp fa, > + double relativeError) { > int i = 0; > try { > - Assert.assertEquals(rc, fa.apply(a, mask)); > + ... This pull request has now been integrated. Changeset: 03cbfaa7 Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/03cbfaa733bc6a59da6ba5c0d0918245e534752a Stats: 417 lines in 13 files changed: 297 ins; 0 del; 120 mod 8315024: Vector API FP reduction tests should not test for exact equality Reviewed-by: mdoerr Backport-of: e6f23a90d4a53339a3c9c2b76fc5d317940e4472 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2768 From serb at openjdk.org Mon Aug 26 19:44:04 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 26 Aug 2024 19:44:04 GMT Subject: [jdk11u-dev] RFR: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 In-Reply-To: <38IYoRPEjj1aqwGRuDD5-RkCwTzOEdgEVyW3Bne7jlM=.5d0c0ecc-9c44-479a-8295-9b7734777afa@github.com> References: <38IYoRPEjj1aqwGRuDD5-RkCwTzOEdgEVyW3Bne7jlM=.5d0c0ecc-9c44-479a-8295-9b7734777afa@github.com> Message-ID: On Wed, 21 Aug 2024 00:44:50 GMT, Amos Shi wrote: > Backport of [JDK-8225045](https://bugs.openjdk.org/browse/JDK-8225045) > - This PR contains two commits > - `commit 1` is generated by git `patch` command, is a clean backport for `JInternalFrameIconTest.java` > - `commit 2` is the manual merge of `test/jdk/ProblemList.txt.rej` file. The content of the file is bellow. > > > @@ -751,7 +751,6 @@ > javax/swing/JComboBox/8182031/ComboPopupTest.java 8196465 linux-all,macosx-all > javax/swing/JFileChooser/6738668/bug6738668.java 8194946 generic-all > javax/swing/JInternalFrame/Test6325652.java 8224977 macosx-all > -javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java 8225045 linux-all > javax/swing/JPopupMenu/4870644/bug4870644.java 8194130 macosx-all,linux-all > javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java 8065099,8208565 macosx-all,linux-all > javax/swing/UIDefaults/6302464/bug6302464.java 8199079 macosx-all > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `JInternalFrameIconTest.java`: Test results: passed: 1 > - Pipeline: `(Re-trigger)` > - Testing Machine: SAP nightlies **SKIPPED** on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier4`, Started at `2024-08-22 21:03:43+01:00` > - javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!printer)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] This bug was reported on linux so you need to test the backport on linux as well. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2918#issuecomment-2310946273 From duke at openjdk.org Mon Aug 26 19:51:43 2024 From: duke at openjdk.org (Daniel Hu) Date: Mon, 26 Aug 2024 19:51:43 GMT Subject: [jdk21u-dev] RFR: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture Message-ID: Clean backport that adds architecture matching attribute for the IR testing framework. This aims to make future backports involving this attribute to be more convenient; specifically, I'd like to backport [JDK-8319960](https://bugs.openjdk.org/browse/JDK-8319960) afterwards which uses this attribute. Affected tests pass on Linux x64. ------------- Commit messages: - Backport a8549b63674be433617b986f392e4ff7afef5185 Changes: https://git.openjdk.org/jdk21u-dev/pull/946/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=946&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280120 Stats: 285 lines in 6 files changed: 280 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/946.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/946/head:pull/946 PR: https://git.openjdk.org/jdk21u-dev/pull/946 From duke at openjdk.org Mon Aug 26 21:04:14 2024 From: duke at openjdk.org (Daniel Hu) Date: Mon, 26 Aug 2024 21:04:14 GMT Subject: [jdk11u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Message-ID: Clean backport that makes TestListenerLeak more robust; already backported to 17 and 21. Passes affected test on Linux x64. MacOS GHA failing due to unrelated deprecated code during compile. ------------- Commit messages: - Backport f6be922952642f40dcf0d27b7896c9a6acdd6378 Changes: https://git.openjdk.org/jdk11u-dev/pull/2923/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2923&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316193 Stats: 12 lines in 1 file changed: 2 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2923.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2923/head:pull/2923 PR: https://git.openjdk.org/jdk11u-dev/pull/2923 From duke at openjdk.org Mon Aug 26 21:04:40 2024 From: duke at openjdk.org (Daniel Hu) Date: Mon, 26 Aug 2024 21:04:40 GMT Subject: [jdk11u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Message-ID: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64. MacOS GHA failing due to unrelated deprecated code during compile ------------- Commit messages: - Backport 79349b8bb30e3a358a1fec2382d44aabcf15239b Changes: https://git.openjdk.org/jdk11u-dev/pull/2922/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2922&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303920 Stats: 158 lines in 1 file changed: 52 ins; 38 del; 68 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2922.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2922/head:pull/2922 PR: https://git.openjdk.org/jdk11u-dev/pull/2922 From ashi at openjdk.org Mon Aug 26 22:25:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 26 Aug 2024 22:25:39 GMT Subject: [jdk17u-dev] RFR: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic" Message-ID: Backport of [JDK-8317738](https://bugs.openjdk.org/browse/JDK-8317738) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - `CodeCacheFullCountTest.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 0fd807118c9b2cb8381b5c0f5d22d4e3451e8f10 Changes: https://git.openjdk.org/jdk17u-dev/pull/2824/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2824&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317738 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2824.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2824/head:pull/2824 PR: https://git.openjdk.org/jdk17u-dev/pull/2824 From duke at openjdk.org Mon Aug 26 23:01:11 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Mon, 26 Aug 2024 23:01:11 GMT Subject: [jdk21u-dev] Integrated: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 In-Reply-To: References: Message-ID: On Fri, 19 Jul 2024 09:12:04 GMT, KIRIYAMA Takuya wrote: > Hi all, > This pull request is the backport of JDK-8336284 . > It is clean. This change resolves a test failure introduced by JDK-8335743. > JDK-8335743 will be backported in https://github.com/openjdk/jdk21u-dev/pull/853. > I verified that TestClhsdbJstackLock.java and TestJhsdbJstackLock.java are passed with -Xcomp. This pull request has now been integrated. Changeset: f2c5ecfc Author: KIRIYAMA Takuya Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/f2c5ecfce428052df1a64cdd81718b28b8ed3b7a Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743 Backport-of: 1fe3ada001e188754df5de00bf6804f028ad274b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/854 From syan at openjdk.org Mon Aug 26 23:03:05 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 26 Aug 2024 23:03:05 GMT Subject: [jdk21u-dev] Integrated: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp In-Reply-To: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> References: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> Message-ID: On Wed, 14 Aug 2024 16:07:32 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [bf13a4e2](https://github.com/openjdk/jdk/commit/bf13a4e2819fa5bcb3e4f2281121d4e0b5535403) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by sunyaqi on 26 Feb 2024 and was reviewed by Brian Burkhalter. > > Thanks! This pull request has now been integrated. Changeset: 15664b1b Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/15664b1bbfe7c7dc2e545cfa4ad4c0e7690b5e3c Stats: 11 lines in 1 file changed: 1 ins; 0 del; 10 mod 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp Backport-of: bf13a4e2819fa5bcb3e4f2281121d4e0b5535403 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/921 From syan at openjdk.org Mon Aug 26 23:03:05 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 26 Aug 2024 23:03:05 GMT Subject: [jdk21u-dev] Integrated: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 03:53:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [403fa376](https://github.com/openjdk/jdk23u/commit/403fa3760f629873258447cc9aefa09f9a27e7a4) from the [openjdk/jdk23u](https://git.openjdk.org/jdk23u) repository. > > The commit being backported was authored by SendaoYan on 20 Aug 2024 and had no reviewers. > > Make the test more robustness, test fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: dccf4de4 Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/dccf4de431671ff151c482d271bd6636fbbf2525 Stats: 18 lines in 1 file changed: 7 ins; 6 del; 5 mod 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment Backport-of: 403fa3760f629873258447cc9aefa09f9a27e7a4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/938 From serb at openjdk.org Mon Aug 26 23:59:11 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 26 Aug 2024 23:59:11 GMT Subject: [jdk11u-dev] Integrated: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 16:55:58 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [1017a2c2](https://github.com/openjdk/jdk/commit/1017a2c2d7ae99e0076abcfaf5e730fec3cb9c6c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This backport contains a patch imported to openjdk/jdk from the lcms 2.14 library in advance. Unfortunately this backport was not pushed to the jdk11u-dev as is, and not as part of the lcms update to 2.14(see https://github.com/openjdk/jdk11u-dev/pull/1659) as a result the implementation of the lcms library in jdk11u-dev is incomplete. > > The patch is not clean, the change in the MTTransformReplacedProfile test is dropped, that test does not exist in the jdk11 and I have no plans to backport the patch which added that test. > > @GoeLin please take a look. This pull request has now been integrated. Changeset: a83d9303 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/a83d9303d5d1f7f3415436e145ea414b2680f783 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 Reviewed-by: phh Backport-of: 1017a2c2d7ae99e0076abcfaf5e730fec3cb9c6c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2914 From ashi at openjdk.org Tue Aug 27 00:16:18 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 27 Aug 2024 00:16:18 GMT Subject: [jdk17u-dev] RFR: 8262895: [macos_aarch64] runtime/CompressedOops/CompressedClassPointers.java fails with 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr Message-ID: Backport of [JDK-8262895](https://bugs.openjdk.org/browse/JDK-8262895) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `runtime/CompressedOops/CompressedClassSpaceSize.java` - Passed: `runtime/CompressedOops/CompressedKlassPointerAndOops.java` - Passed: `runtime/CompressedOops/ObjectAlignment.java` - Passed: `runtime/CompressedOops/UseCompressedOops.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport f5a12768fba4a6508fb0359aedd608fd9d6d9024 Changes: https://git.openjdk.org/jdk17u-dev/pull/2825/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2825&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8262895 Stats: 18 lines in 1 file changed: 4 ins; 8 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2825.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2825/head:pull/2825 PR: https://git.openjdk.org/jdk17u-dev/pull/2825 From ashi at openjdk.org Tue Aug 27 01:29:43 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 27 Aug 2024 01:29:43 GMT Subject: [jdk11u-dev] RFR: 8247706: Unintentional use of new Date(year...) with absolute year Message-ID: Backport of [JDK-8247706](https://bugs.openjdk.org/browse/JDK-8247706) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `java/text/Format/DateFormat/DateFormatRegression.java` - Passed: `java/time/tck/java/time/format/TCKLocalizedPrinterParser.java` - Passed: `java/util/Calendar/FieldStateTest.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 175b597ad2fbbcceac2946ca26b27d069a6003fd Changes: https://git.openjdk.org/jdk11u-dev/pull/2924/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2924&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8247706 Stats: 7 lines in 3 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2924.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2924/head:pull/2924 PR: https://git.openjdk.org/jdk11u-dev/pull/2924 From syan at openjdk.org Tue Aug 27 01:55:11 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 01:55:11 GMT Subject: [jdk21u-dev] RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment In-Reply-To: References: Message-ID: <3NVJVWLVGMw-N0wkdWRGx9qsTVpLo-HBbLstOrzyZhQ=.7d306eaf-1745-4d9b-8cda-013f38d1e2dc@github.com> On Wed, 21 Aug 2024 03:53:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [403fa376](https://github.com/openjdk/jdk23u/commit/403fa3760f629873258447cc9aefa09f9a27e7a4) from the [openjdk/jdk23u](https://git.openjdk.org/jdk23u) repository. > > The commit being backported was authored by SendaoYan on 20 Aug 2024 and had no reviewers. > > Make the test more robustness, test fix only, no risk. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/938#issuecomment-2311415608 From syan at openjdk.org Tue Aug 27 01:57:14 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 01:57:14 GMT Subject: [jdk21u-dev] RFR: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp In-Reply-To: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> References: <9rjxNIYKF7_dqJTlwDeFXj1coBwjLyDXvL_dV8ZPdYI=.5dec2f2f-c8fc-42ea-8bc3-7a072f333edb@github.com> Message-ID: On Wed, 14 Aug 2024 16:07:32 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [bf13a4e2](https://github.com/openjdk/jdk/commit/bf13a4e2819fa5bcb3e4f2281121d4e0b5535403) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by sunyaqi on 26 Feb 2024 and was reviewed by Brian Burkhalter. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/921#issuecomment-2311417425 From ashi at openjdk.org Tue Aug 27 01:57:42 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 27 Aug 2024 01:57:42 GMT Subject: [jdk11u-dev] RFR: 8249678: @ignore should be used instead of ProblemList for 8158860, 8163894, 8193479, 8194310 Message-ID: Backport of [JDK-8249678](https://bugs.openjdk.org/browse/JDK-8249678) Testing - Local: - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 4a4003e9002b1d01ea5c5c707b2a0c0d12a0d5ba Manual merge - Backport 4a4003e9002b1d01ea5c5c707b2a0c0d12a0d5ba Clean backport Changes: https://git.openjdk.org/jdk11u-dev/pull/2925/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2925&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8249678 Stats: 10 lines in 5 files changed: 4 ins; 5 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2925.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2925/head:pull/2925 PR: https://git.openjdk.org/jdk11u-dev/pull/2925 From ashi at openjdk.org Tue Aug 27 03:26:36 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 27 Aug 2024 03:26:36 GMT Subject: [jdk11u-dev] RFR: 8249836: java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore Message-ID: Backport of [JDK-8249836](https://bugs.openjdk.org/browse/JDK-8249836) Testing - Local: - Pipeline: - Testing Machine: ------------- Commit messages: - Backport c859fb02f3c11ceca491f99ef6fd2a80291383b0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2926/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2926&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8249836 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2926.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2926/head:pull/2926 PR: https://git.openjdk.org/jdk11u-dev/pull/2926 From mbaesken at openjdk.org Tue Aug 27 06:19:14 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 27 Aug 2024 06:19:14 GMT Subject: [jdk21u-dev] Integrated: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range In-Reply-To: <86Q4msjMBFafr9YN00zuRlt1zdx1-ag8xnkLDdJYsa4=.0497584a-ca19-4ecd-b2a7-374599556d0f@github.com> References: <86Q4msjMBFafr9YN00zuRlt1zdx1-ag8xnkLDdJYsa4=.0497584a-ca19-4ecd-b2a7-374599556d0f@github.com> Message-ID: On Mon, 19 Aug 2024 07:13:55 GMT, Matthias Baesken wrote: > Backport of 8311306, diff in stride This pull request has now been integrated. Changeset: ec5976d5 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/ec5976d531b8702d1b99604af8db5afcf63bfd19 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range Backport-of: e1fd663f224909c09f2f6fab7ad20f7b7864b62b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/933 From duke at openjdk.org Tue Aug 27 08:49:04 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 27 Aug 2024 08:49:04 GMT Subject: [jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 12:56:31 GMT, Martin Doerr wrote: >> LGTM. > >> Hi @TheRealMDoerr . Thanks for the review. Would it be possible to rerun macos jobs? (I don't have permissions to do that ). Thanks!. > > I can only rerun jobs in my own PRs. You should find a rerun button next to the failing test. Thanks, @TheRealMDoerr . I couldn't rerun failed jobs, so I ran the whole workflow. Checks are green now. I think I'll wait for reviews on the remaining integration blockers/PRs before requesting an approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2854#issuecomment-2311926498 From goetz at openjdk.org Tue Aug 27 10:33:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Aug 2024 10:33:08 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! I want to know why the GHA action tests failed. Actually, I want to make sure you have checked the results of these... There is a failure on macos-aarch64 here. It is not uncommon that I am asked to approve changes that cause failures in the GHA actions. Therefore I insist that the Fix request comment explains why the GHA actions failed if they do so. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2312152106 From goetz at openjdk.org Tue Aug 27 10:37:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Aug 2024 10:37:07 GMT Subject: [jdk11u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> References: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> Message-ID: On Mon, 26 Aug 2024 18:25:41 GMT, Daniel Hu wrote: > Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile There are failed tests. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2922#issuecomment-2312159520 From goetz at openjdk.org Tue Aug 27 10:37:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Aug 2024 10:37:10 GMT Subject: [jdk11u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 18:36:20 GMT, Daniel Hu wrote: > Clean backport that makes TestListenerLeak more robust; already backported to 17 and 21. Passes affected test on Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile. There are failed tests. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2923#issuecomment-2312160752 From duke at openjdk.org Tue Aug 27 11:04:14 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 27 Aug 2024 11:04:14 GMT Subject: [jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype In-Reply-To: References: Message-ID: On Fri, 12 Jul 2024 07:49:44 GMT, Antonio Vieiro wrote: > This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. > > The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. > > This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary. @GoeLin You're asking why many tests fail on macos. Here's a short explanation: - In [late june](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) github removed the `macos-11` runners, so many jdk builds (21, 17, 11, 8) started hanging. - The problem was required fixing [JDK-8318039 - GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8318039), i.e., bumping the macos github runners to `macos-13` / `XCode 14`. - This was resolved in [jdk-21](https://github.com/openjdk/jdk21u-dev/pull/254) and [jdk-17](https://github.com/openjdk/jdk17u-dev/commit/7144027dff495b623428bd9cd891c0ed912035a4) - The backport of [JDK-8318039](https://bugs.openjdk.org/browse/JDK-8318039) for 11 is in now place (this PR builds fine with `macos-13` GHA runners), but requires this PR (_and the other nested PRs_/integration blockers) to be reviewed. Hope this clarifies, Antonio ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2854#issuecomment-2312217026 From shade at openjdk.org Tue Aug 27 11:36:07 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 27 Aug 2024 11:36:07 GMT Subject: [jdk21u-dev] RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:27:44 GMT, Aleksey Shipilev wrote: > This fixes the regression introduced by [JDK-8329665](https://bugs.openjdk.org/browse/JDK-8329665), which added `ResourceMark` in `frame::oops_interpreted_do`. This is not really correct, as closures we call with that method can do resource allocations. The patch avoids this problem by cleanly allocating on C heap. > > The mainline patch wants `has_valid_mask` infrastructure added as part of [JDK-8315954](https://bugs.openjdk.org/browse/JDK-8315954). That patch has implications for Graal, and have unresolved bug tail. Therefore, I just picked up relevant infra hunks here. > > Additional testing: > - [x] Linux x86_64 server fastedebug, `all` > - [x] Linux AArch64 server fastedebug, `all` Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/942#issuecomment-2312310707 From shade at openjdk.org Tue Aug 27 11:36:11 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 27 Aug 2024 11:36:11 GMT Subject: [jdk21u-dev] Integrated: 8338286: GHA: Demote x86_32 to hotspot build only In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 10:54:51 GMT, Aleksey Shipilev wrote: > This should make GHAs cleaner and more efficient for future backports. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 345b4174 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/345b4174556d9e9c6827ed08b8ab36ff0bb31349 Stats: 19 lines in 1 file changed: 1 ins; 11 del; 7 mod 8338286: GHA: Demote x86_32 to hotspot build only Backport-of: da7311bbe37c2b9632b117d52a77c659047820b7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/935 From shade at openjdk.org Tue Aug 27 11:36:11 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 27 Aug 2024 11:36:11 GMT Subject: [jdk23u] Integrated: 8338286: GHA: Demote x86_32 to hotspot build only In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 10:49:12 GMT, Aleksey Shipilev wrote: > This should make GHAs cleaner and more efficient for future backports. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: bf77a6cf Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk23u/commit/bf77a6cf926bd1b493fc795da4b9a0b57b2222d0 Stats: 19 lines in 1 file changed: 1 ins; 11 del; 7 mod 8338286: GHA: Demote x86_32 to hotspot build only Backport-of: da7311bbe37c2b9632b117d52a77c659047820b7 ------------- PR: https://git.openjdk.org/jdk23u/pull/79 From shade at openjdk.org Tue Aug 27 11:36:07 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 27 Aug 2024 11:36:07 GMT Subject: [jdk21u-dev] Integrated: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:27:44 GMT, Aleksey Shipilev wrote: > This fixes the regression introduced by [JDK-8329665](https://bugs.openjdk.org/browse/JDK-8329665), which added `ResourceMark` in `frame::oops_interpreted_do`. This is not really correct, as closures we call with that method can do resource allocations. The patch avoids this problem by cleanly allocating on C heap. > > The mainline patch wants `has_valid_mask` infrastructure added as part of [JDK-8315954](https://bugs.openjdk.org/browse/JDK-8315954). That patch has implications for Graal, and have unresolved bug tail. Therefore, I just picked up relevant infra hunks here. > > Additional testing: > - [x] Linux x86_64 server fastedebug, `all` > - [x] Linux AArch64 server fastedebug, `all` This pull request has now been integrated. Changeset: db914b77 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/db914b770b82b8d8cc4e95da83b1c7b7ac3fd9b0 Stats: 57 lines in 3 files changed: 12 ins; 17 del; 28 mod 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 Reviewed-by: phh, stuefe Backport-of: 7ab96c74e2c39f430a5c2f65a981da7314a2385b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/942 From clanger at openjdk.org Tue Aug 27 12:37:16 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 27 Aug 2024 12:37:16 GMT Subject: [jdk17u-dev] RFR: 8330814: Cleanups for KeepAliveCache tests In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 05:12:38 GMT, Christoph Langer wrote: > Backporting the cleanups for KeepAliveCache tests. Now with all prerequisites in place, it applies nearly clean. Only in test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java there was a little modification due to the different HttpServer API in 17 which lacks the constructor with all the options that is used in higher releases. Closing in favor of #2813. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2790#issuecomment-2312440965 From clanger at openjdk.org Tue Aug 27 12:37:16 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 27 Aug 2024 12:37:16 GMT Subject: [jdk17u-dev] Withdrawn: 8330814: Cleanups for KeepAliveCache tests In-Reply-To: References: Message-ID: On Fri, 9 Aug 2024 05:12:38 GMT, Christoph Langer wrote: > Backporting the cleanups for KeepAliveCache tests. Now with all prerequisites in place, it applies nearly clean. Only in test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java there was a little modification due to the different HttpServer API in 17 which lacks the constructor with all the options that is used in higher releases. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2790 From clanger at openjdk.org Tue Aug 27 12:41:12 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 27 Aug 2024 12:41:12 GMT Subject: [jdk17u-dev] RFR: 8330814: Cleanups for KeepAliveCache tests In-Reply-To: <9d_WP3KuuW_bibAXvhtr5JgqXBHgxmHuO6G_H8tGMVw=.14f7df27-f341-4fa2-b6ea-bc4117dd9870@github.com> References: <9d_WP3KuuW_bibAXvhtr5JgqXBHgxmHuO6G_H8tGMVw=.14f7df27-f341-4fa2-b6ea-bc4117dd9870@github.com> Message-ID: On Sat, 17 Aug 2024 02:44:39 GMT, Amos Shi wrote: > Backport of [JDK-8330814](https://bugs.openjdk.org/browse/JDK-8330814) > - This PR has two commits > - `commit 1` is a `clean` git patch from original commit > - `commit 2` is fixing the following compile error > - The fix is in line with https://github.com/openjdk/jdk17u-dev/commit/e96daf3b5ba1b341acbc3bf005746d0c9aacc803#diff-9aaf6eb570572e1a22b661c23e76f330d090280ef60e7390d0ab421d48a6558eR68 from @RealCLanger > > > ----------System.err:(8/634)---------- > /Users/I048686/SAPDevelop/github.com/dev-8330814-17/test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java:73: error: no suitable method found for create(InetSocketAddress,int,String,SimpleHttpTransactionHandler) > server = HttpServer.create(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0), 10, "/", new SimpleHttpTransactionHandler()); > ^ > method HttpServer.create() is not applicable > (actual and formal argument lists differ in length) > method HttpServer.create(InetSocketAddress,int) is not applicable > (actual and formal argument lists differ in length) > 1 error > result: Failed. Compilation failed: Compilation failed > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `B5045306.java`: Test results: passed: 1 > - `B8291637.java`: Test results: passed: 1 > - `B8293562.java`: Test results: passed: 1 > - `KeepAliveProperty.java`: Test results: passed: 1 > - `KeepAliveTimerThread.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-23 19:44:34+01:00` > - sun/net/www/http/KeepAliveCache/B5045306.java: SUCCESSFUL GitHub ? - [20:10:08.445 -> 14,486 msec] > - sun/net/www/http/KeepAliveCache/B8291637.java: SUCCESSFUL GitHub ? - [20:10:08.455 -> 20,795 msec] > - sun/net/www/http/KeepAliveCache/B8293562.java: SUCCESSFUL GitHub ? - [20:10:09.152 -> 7,188 msec] > - sun/net/www/http/KeepAliveCache/KeepAliveProperty.java: SUCCESSFUL GitHub ? - [20:10:09.356 -> 13,344 msec] > - sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java: SUCCESSFUL GitHub ? - [20:10:09.722 -> 2,621 msec] Looks good and similar to my intial attempt in #2790 which still had an issue in B5045306. This seems to be fixed in this PR through the change in line 73 of B5045306.java: > server = HttpServer.create(new InetSocketAddress(InetAddress.getLocalHost(), 0), 10); to > server = HttpServer.create(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0), 10); Otherwise looks the same and passes testing, so LGTM. ------------- Marked as reviewed by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2813#pullrequestreview-2263220312 From andrew at openjdk.org Tue Aug 27 12:52:11 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 27 Aug 2024 12:52:11 GMT Subject: [jdk11u-dev] RFR: 8335801: [11u] Backport of 8210988 to 11u removes gcc warnings In-Reply-To: References: Message-ID: On Sat, 6 Jul 2024 15:00:54 GMT, Andrew John Hughes wrote: > The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from `gcc` builds by changing `WARNING_CFLAGS_JDK` and `WARNING_CFLAGS_JVM`, but not defining `WARNINGS_ENABLE_ALL`, `WARNINGS_ENABLE_ADDITIONAL_JVM` and `DISABLED_WARNINGS`. > > The other more minor issues are the silent inclusion of `-Wreorder` to clang builds (should be a backport of [JDK-8208672](https://bugs.openjdk.org/browse/JDK-8208672)) and `-xc99=%none` (reverting [JDK-8215296](https://bugs.openjdk.org/browse/JDK-8215296)), because new lines were used as is without comparing differences in what was being replaced. > > All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch. > > I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work) Thanks Paul! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2838#issuecomment-2312475303 From syan at openjdk.org Tue Aug 27 13:02:10 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 13:02:10 GMT Subject: [jdk23u] RFR: 8337165: Test jdk/jfr/event/gc/stacktrace/TestG1YoungAllocationPendingStackTrace.java failed: IndexOutOfBoundsException: Index 64 out of bounds for length 64 In-Reply-To: References: Message-ID: On Sun, 25 Aug 2024 09:36:00 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [9124a94e](https://github.com/openjdk/jdk/commit/9124a94e383f5bc6a3376eecc97ee8bd22f9e420) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 29 Jul 2024 and was reviewed by Paul Hohensee. > > Thanks! Seems not needed to backport. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/85#issuecomment-2312496130 From syan at openjdk.org Tue Aug 27 13:02:10 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 13:02:10 GMT Subject: [jdk23u] Withdrawn: 8337165: Test jdk/jfr/event/gc/stacktrace/TestG1YoungAllocationPendingStackTrace.java failed: IndexOutOfBoundsException: Index 64 out of bounds for length 64 In-Reply-To: References: Message-ID: On Sun, 25 Aug 2024 09:36:00 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [9124a94e](https://github.com/openjdk/jdk/commit/9124a94e383f5bc6a3376eecc97ee8bd22f9e420) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 29 Jul 2024 and was reviewed by Paul Hohensee. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/85 From syan at openjdk.org Tue Aug 27 13:14:04 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 13:14:04 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! Sorry for the misunderstand. The GHA report `macos-aarch64 langtools/tier1` [failed](https://github.com/openjdk-bots/jdk21u-dev/actions/runs/10508271788/job/29112766390). Unfortunately the GHA doesn't show any messages for this failed, it seems like a environmental issue. This PR change the tests in `test/jdk` directory, this PR will not change the behavior of `langtools/tier1` in theory, so I think the failed unreleated to this PR. I will try to rerun the failed test. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2312524509 From syan at openjdk.org Tue Aug 27 13:18:11 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 13:18:11 GMT Subject: [jdk17u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! The GHA report `windows-x64 hs/tier1` [failed](https://github.com/openjdk-bots/jdk17u-dev/actions/runs/10508277724/job/29115505997). Unfortunately the GHA doesn't show any messages for this failed, it seems like a environmental issue. This PR change the tests in `test/jdk` directory, this PR will not change the behavior of `hotspot/tier1` in theory, so I think the failed unreleated to this PR. I will try to rerun the failed test. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2820#issuecomment-2312534194 From syan at openjdk.org Tue Aug 27 13:25:10 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 13:25:10 GMT Subject: [jdk11u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> References: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> Message-ID: On Thu, 22 Aug 2024 13:15:13 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > This PR not clean, because this file has changed by JDK-8328638 and JDK-8329213 which not backported to jdk11u-dev. > > Thanks! GHA report macos-x64 and macos-aarch64 build failed. The build failed issue has been recorded by [JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635) and is fixing by https://github.com/openjdk/jdk11u-dev/pull/2844. The failures releated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2919#issuecomment-2312552162 From goetz at openjdk.org Tue Aug 27 14:56:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Aug 2024 14:56:18 GMT Subject: [jdk21u-dev] RFR: 8331266: Bump update version for OpenJDK: jdk-21.0.5 Message-ID: <52tzuDm2JTDht3zL4vinyzgZIc1P-bCJCtv7Nlj_eFs=.0aafe00c-823f-497f-9acc-3c39ee647c0d@github.com> We need this to start the next release. ------------- Commit messages: - 8331266: Bump update version for OpenJDK: jdk-21.0.5 Changes: https://git.openjdk.org/jdk21u-dev/pull/947/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=947&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331266 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/947.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/947/head:pull/947 PR: https://git.openjdk.org/jdk21u-dev/pull/947 From goetz at openjdk.org Tue Aug 27 15:03:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Aug 2024 15:03:39 GMT Subject: [jdk21u-dev] RFR: 8331266: Bump update version for OpenJDK: jdk-21.0.5 [v2] In-Reply-To: <52tzuDm2JTDht3zL4vinyzgZIc1P-bCJCtv7Nlj_eFs=.0aafe00c-823f-497f-9acc-3c39ee647c0d@github.com> References: <52tzuDm2JTDht3zL4vinyzgZIc1P-bCJCtv7Nlj_eFs=.0aafe00c-823f-497f-9acc-3c39ee647c0d@github.com> Message-ID: > We need this to start the next release. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8339080: Bump update version for OpenJDK: jdk-21.0.6 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/947/files - new: https://git.openjdk.org/jdk21u-dev/pull/947/files/a535838b..3edd5ebe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=947&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=947&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/947.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/947/head:pull/947 PR: https://git.openjdk.org/jdk21u-dev/pull/947 From goetz at openjdk.org Tue Aug 27 15:05:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Aug 2024 15:05:41 GMT Subject: [jdk17u-dev] RFR: 8339081: Bump update version for OpenJDK: jdk-17.0.14 Message-ID: We need this to start the next release. ------------- Commit messages: - 8339081: Bump update version for OpenJDK: jdk-17.0.14 Changes: https://git.openjdk.org/jdk17u-dev/pull/2826/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2826&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339081 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2826.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2826/head:pull/2826 PR: https://git.openjdk.org/jdk17u-dev/pull/2826 From goetz at openjdk.org Tue Aug 27 15:09:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Aug 2024 15:09:24 GMT Subject: [jdk11u-dev] RFR: 8339082: Bump update version for OpenJDK: jdk-11.0.26 Message-ID: We need this for the next release. ------------- Commit messages: - 8339082: Bump update version for OpenJDK: jdk-11.0.26 Changes: https://git.openjdk.org/jdk11u-dev/pull/2927/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2927&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339082 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2927.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2927/head:pull/2927 PR: https://git.openjdk.org/jdk11u-dev/pull/2927 From phh at openjdk.org Tue Aug 27 15:23:08 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 27 Aug 2024 15:23:08 GMT Subject: [jdk11u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test In-Reply-To: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> References: <2FkJtZlLbZWhK2aIJHoyLV4XWKx86kmR1oi5_Fb7pMI=.bc2e5379-7efb-4679-ade6-e2f9d9081725@github.com> Message-ID: On Mon, 26 Aug 2024 18:25:41 GMT, Daniel Hu wrote: > Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile MacOS GHA build failures are sprintf related, i.e., unrelated to this backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2922#issuecomment-2312861897 From phh at openjdk.org Tue Aug 27 15:24:13 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 27 Aug 2024 15:24:13 GMT Subject: [jdk11u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 18:36:20 GMT, Daniel Hu wrote: > Clean backport that makes TestListenerLeak more robust; already backported to 17 and 21. Passes affected test on Linux x64. > MacOS GHA failing due to unrelated deprecated code during compile. MacOS GHA build failures are sprintf related, i.e., unrelated to this backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2923#issuecomment-2312864424 From phh at openjdk.org Tue Aug 27 15:31:09 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 27 Aug 2024 15:31:09 GMT Subject: [jdk11u-dev] RFR: 8312049: runtime/logging/ClassLoadUnloadTest can be improved In-Reply-To: References: Message-ID: <4tlrlLf2HxSmRFeT1hSaJTBiiZTIkTDJBRT03A06ju4=.59184dfc-62bb-45a0-9412-e164495788bc@github.com> On Fri, 23 Aug 2024 19:29:43 GMT, Daniel Hu wrote: > Backport that improves ClassLoadUnloadTest; already backported to [JDK21](https://github.com/openjdk/jdk21u-dev/pull/909) and [JDK17](https://github.com/openjdk/jdk17u-dev/pull/2806). Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later [version](https://bugs.openjdk.org/browse/JDK-8193513), thus these cases are excluded. Some args in exec() also were not added until a [later version](https://bugs.openjdk.org/browse/JDK-8289184), thus they are excluded. Additionally, [these flags](https://bugs.openjdk.org/browse/JDK-8256718) were deprecated in a later version and thus removed from this test; simple modifications are added so that these later removed cases follow the backport logic. Affected test passes. > > MacOS GHA not passing due to unrelated deprecated sprintf Marked as reviewed by phh (Reviewer). MacOS GHA build failures are sprintf related, i.e., not related to this backport. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2920#pullrequestreview-2263770297 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2920#issuecomment-2312880857 From sgehwolf at openjdk.org Tue Aug 27 15:46:04 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 27 Aug 2024 15:46:04 GMT Subject: [jdk21u-dev] RFR: 8339080: Bump update version for OpenJDK: jdk-21.0.6 [v2] In-Reply-To: References: <52tzuDm2JTDht3zL4vinyzgZIc1P-bCJCtv7Nlj_eFs=.0aafe00c-823f-497f-9acc-3c39ee647c0d@github.com> Message-ID: On Tue, 27 Aug 2024 15:03:39 GMT, Goetz Lindenmaier wrote: >> We need this to start the next release. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8339080: Bump update version for OpenJDK: jdk-21.0.6 Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/947#pullrequestreview-2263816506 From sgehwolf at openjdk.org Tue Aug 27 15:49:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 27 Aug 2024 15:49:10 GMT Subject: [jdk11u-dev] RFR: 8339082: Bump update version for OpenJDK: jdk-11.0.26 In-Reply-To: References: Message-ID: On Tue, 27 Aug 2024 15:04:56 GMT, Goetz Lindenmaier wrote: > We need this for the next release. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2927#pullrequestreview-2263825303 From sgehwolf at openjdk.org Tue Aug 27 15:50:11 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 27 Aug 2024 15:50:11 GMT Subject: [jdk17u-dev] RFR: 8339081: Bump update version for OpenJDK: jdk-17.0.14 In-Reply-To: References: Message-ID: On Tue, 27 Aug 2024 15:01:11 GMT, Goetz Lindenmaier wrote: > We need this to start the next release. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2826#pullrequestreview-2263828259 From duke at openjdk.org Tue Aug 27 16:11:14 2024 From: duke at openjdk.org (duke) Date: Tue, 27 Aug 2024 16:11:14 GMT Subject: [jdk21u-dev] RFR: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 17:12:57 GMT, Daniel Hu wrote: > Clean backport that adds architecture matching attribute for the IR testing framework. This aims to make future backports involving this attribute to be more convenient; specifically, I'd like to backport [JDK-8319960](https://bugs.openjdk.org/browse/JDK-8319960) afterwards which uses this attribute. Affected tests pass on Linux x64. @cost0much Your change (at version 35ec2f913cf2af58c3419dd7cb4fd096e8674a53) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/946#issuecomment-2312977290 From duke at openjdk.org Tue Aug 27 16:49:13 2024 From: duke at openjdk.org (Daniel Hu) Date: Tue, 27 Aug 2024 16:49:13 GMT Subject: [jdk21u-dev] Integrated: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 17:12:57 GMT, Daniel Hu wrote: > Clean backport that adds architecture matching attribute for the IR testing framework. This aims to make future backports involving this attribute to be more convenient; specifically, I'd like to backport [JDK-8319960](https://bugs.openjdk.org/browse/JDK-8319960) afterwards which uses this attribute. Affected tests pass on Linux x64. This pull request has now been integrated. Changeset: 33f4d805 Author: Daniel Hu Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/33f4d805747ed1c63ab7fba169149d2dfbb2cded Stats: 285 lines in 6 files changed: 280 ins; 1 del; 4 mod 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture Backport-of: a8549b63674be433617b986f392e4ff7afef5185 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/946 From phh at openjdk.org Tue Aug 27 17:24:09 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 27 Aug 2024 17:24:09 GMT Subject: [jdk11u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> References: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> Message-ID: On Thu, 22 Aug 2024 13:15:13 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > This PR not clean, because this file has changed by JDK-8328638 and JDK-8329213 which not backported to jdk11u-dev. > > Thanks! I believe you meant "unrelated to this PR". :) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2919#issuecomment-2313125764 From duke at openjdk.org Tue Aug 27 20:44:36 2024 From: duke at openjdk.org (Daniel Hu) Date: Tue, 27 Aug 2024 20:44:36 GMT Subject: [jdk21u-dev] RFR: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 Message-ID: Backport of [JDK-8319970](https://bugs.openjdk.org/browse/JDK-8319970) that enables tests for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64. Not clean because [RISC-V intrinsics for divideUnsigned and remainderUnsigned were only added in JDK22](https://github.com/openjdk/jdk/commit/40a3c35aa5614be4505013d4e92ddb1b556a3622); aarch64 intrinsics for divideUnsigned and remainderUnsigned confirmed to be [released in JDK20](https://bugs.openjdk.org/browse/JDK-8287926). This includes backport of [JDK-8319960](https://bugs.openjdk.org/browse/JDK-8319960) because the `UDivModI` or `UDivModL` nodes are supplied from x86_64.ad, thus the node check is intended for x64 platforms. Although originally intended to fix the test failing for RISC-V intrinsics, without this exclusion the test will also fail for aarch64 platforms, thus it is included as part of the backport. Passes affected tests on Linux aarch64 and Mac aarch64. ------------- Commit messages: - Backport 856c280d9372381622fc7d59a8fdc4d98a5577d0 - Merge branch 'openjdk:master' into JDK-8319970 - Merge branch 'openjdk:master' into JDK-8319970 - Backport c80e691adf6f9ac1a41b2329ce366710e604e34e Changes: https://git.openjdk.org/jdk21u-dev/pull/914/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=914&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319970 Stats: 10 lines in 2 files changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/914.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/914/head:pull/914 PR: https://git.openjdk.org/jdk21u-dev/pull/914 From syan at openjdk.org Wed Aug 28 02:12:24 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 02:12:24 GMT Subject: [jdk11u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> Message-ID: <_-2KuBze_U4Tijykwi0WR-SCUbp-JPWqKl7GF0NcK60=.6c8e4a67-1b97-4f95-9c4e-e5784eecf2de@github.com> On Tue, 27 Aug 2024 17:21:47 GMT, Paul Hohensee wrote: > I believe you meant "unrelated to this PR". :) Sorry for the typo. The typo has been corrected. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2919#issuecomment-2313948716 From syan at openjdk.org Wed Aug 28 02:18:30 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 02:18:30 GMT Subject: [jdk17u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! I rerun all the GHA tests, and the `windows-x64 hs/tier1` failed disappear. Th new GHA report macos-aarch64 failed at `Get bundles` stage, the failed seems to be GHA environmental issue. I think the failed unreleated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2820#issuecomment-2313953669 From syan at openjdk.org Wed Aug 28 02:20:27 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 02:20:27 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! All the GHA tests passed after I rerun it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2313954944 From syan at openjdk.org Wed Aug 28 02:23:24 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 02:23:24 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 09:29:22 GMT, SendaoYan wrote: > Hi, all three PRs for this change have failed. tests. Why? 1. GHA job of jdk21u-dev passed after I rerun it. 2. GHA job of jdk17u-dev failed seems to be GHA environmental issue. 3. GHA job of jdk11u-dev failed cause by [known bug](https://bugs.openjdk.org/browse/JDK-8299635) which is fixing by https://github.com/openjdk/jdk11u-dev/pull/2844 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2313957969 From goetz at openjdk.org Wed Aug 28 04:38:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Aug 2024 04:38:25 GMT Subject: [jdk11u-dev] RFR: 8339082: Bump update version for OpenJDK: jdk-11.0.26 In-Reply-To: References: Message-ID: On Tue, 27 Aug 2024 15:04:56 GMT, Goetz Lindenmaier wrote: > We need this for the next release. GHA issues: hs-minimal: infra issue, wget macos: also infra issues,with artifact upload ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2927#issuecomment-2314241229 From goetz at openjdk.org Wed Aug 28 05:12:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Aug 2024 05:12:29 GMT Subject: [jdk21u-dev] Integrated: 8339080: Bump update version for OpenJDK: jdk-21.0.6 In-Reply-To: <52tzuDm2JTDht3zL4vinyzgZIc1P-bCJCtv7Nlj_eFs=.0aafe00c-823f-497f-9acc-3c39ee647c0d@github.com> References: <52tzuDm2JTDht3zL4vinyzgZIc1P-bCJCtv7Nlj_eFs=.0aafe00c-823f-497f-9acc-3c39ee647c0d@github.com> Message-ID: On Tue, 27 Aug 2024 14:51:23 GMT, Goetz Lindenmaier wrote: > We need this to start the next release. This pull request has now been integrated. Changeset: 669c2b4f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/669c2b4f07a89c5f73f5915a8c97eb201965797d Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8339080: Bump update version for OpenJDK: jdk-21.0.6 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/947 From duke at openjdk.org Wed Aug 28 06:27:27 2024 From: duke at openjdk.org (Junhua Huang) Date: Wed, 28 Aug 2024 06:27:27 GMT Subject: [jdk21u-dev] RFR: 8311644: Server should not send bad_certificate alert when the client does not send any certificates In-Reply-To: References: Message-ID: <2OXcopWiEdL1HMtRF2gDkd-tNrLqEA0-yGV46fwR-QM=.6eba812e-b825-4853-9a73-0444fd380b7b@github.com> On Sat, 17 Aug 2024 04:05:35 GMT, Amos Shi wrote: > Backport of [JDK-8311644](https://bugs.openjdk.org/browse/JDK-8311644) > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `CertMsgCheck.java`: Test results: passed: 1 > - `CheckSessionContext.java`: Test results: passed: 1 > - `LegacyDHEKeyExchange.java`: Test results: passed: 1 > - `SigAlgosExtTestWithTLS12.java`: Test results: passed: 1 > - `SigAlgosExtTestWithTLS13.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: Test on local linux machine System info - `tail /etc/lsb-release` DISTRIB_ID=Ubuntu DISTRIB_RELEASE=22.04 DISTRIB_CODENAME=jammy DISTRIB_DESCRIPTION="Ubuntu 22.04.4 LTS" - `lscpu` Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 48 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: AuthenticAMD Model name: AMD Ryzen 7 5800H with Radeon Graphics CPU family: 25 Model: 80 Thread(s) per core: 2 Core(s) per socket: 8 Socket(s): 1 Stepping: 0 BogoMIPS: 6387.77 Test result: `All passed` - Passed: `javax/net/ssl/SSLSession/CertMsgCheck.java` - Passed: `javax/net/ssl/SSLSession/CheckSessionContext.java` - Passed: `sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java` - Passed: `sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS12.java` - Passed: `sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS13.java` ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/932#issuecomment-2314417098 From duke at openjdk.org Wed Aug 28 06:35:27 2024 From: duke at openjdk.org (Junhua Huang) Date: Wed, 28 Aug 2024 06:35:27 GMT Subject: [jdk11u-dev] RFR: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 In-Reply-To: <38IYoRPEjj1aqwGRuDD5-RkCwTzOEdgEVyW3Bne7jlM=.5d0c0ecc-9c44-479a-8295-9b7734777afa@github.com> References: <38IYoRPEjj1aqwGRuDD5-RkCwTzOEdgEVyW3Bne7jlM=.5d0c0ecc-9c44-479a-8295-9b7734777afa@github.com> Message-ID: <9NDag6jVblyowgrayeEROfGjO6p0MYIZJwfesPhHLLI=.e289bf89-81a4-4a0b-b73f-b2d0a08638a1@github.com> On Wed, 21 Aug 2024 00:44:50 GMT, Amos Shi wrote: > Backport of [JDK-8225045](https://bugs.openjdk.org/browse/JDK-8225045) > - This PR contains two commits > - `commit 1` is generated by git `patch` command, is a clean backport for `JInternalFrameIconTest.java` > - `commit 2` is the manual merge of `test/jdk/ProblemList.txt.rej` file. The content of the file is bellow. > > > @@ -751,7 +751,6 @@ > javax/swing/JComboBox/8182031/ComboPopupTest.java 8196465 linux-all,macosx-all > javax/swing/JFileChooser/6738668/bug6738668.java 8194946 generic-all > javax/swing/JInternalFrame/Test6325652.java 8224977 macosx-all > -javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java 8225045 linux-all > javax/swing/JPopupMenu/4870644/bug4870644.java 8194130 macosx-all,linux-all > javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java 8065099,8208565 macosx-all,linux-all > javax/swing/UIDefaults/6302464/bug6302464.java 8199079 macosx-all > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `JInternalFrameIconTest.java`: Test results: passed: 1 > - Local: `TODO` Test on Linux machine > - Pipeline: All passed except `macOS` > - `macOS`: `/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here` The issue exists in all recent PR in [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/pulls) and not caused by Current PR > - Testing Machine: SAP nightlies **SKIPPED** on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier4`, Started at `2024-08-22 21:03:43+01:00` > - javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java: `SKIPPED` [Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!printer)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] Test on local linux machine System info - `tail /etc/lsb-release` DISTRIB_ID=Ubuntu DISTRIB_RELEASE=22.04 DISTRIB_CODENAME=jammy DISTRIB_DESCRIPTION="Ubuntu 22.04.4 LTS" - `lscpu` Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 48 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: AuthenticAMD Model name: AMD Ryzen 7 5800H with Radeon Graphics CPU family: 25 Model: 80 Thread(s) per core: 2 Core(s) per socket: 8 Socket(s): 1 Stepping: 0 BogoMIPS: 6387.77 Test result: `passed` - Passed: `javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java` ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2918#issuecomment-2314428224 From ashi at openjdk.org Wed Aug 28 07:03:27 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 28 Aug 2024 07:03:27 GMT Subject: [jdk17u-dev] Integrated: 8330814: Cleanups for KeepAliveCache tests In-Reply-To: <9d_WP3KuuW_bibAXvhtr5JgqXBHgxmHuO6G_H8tGMVw=.14f7df27-f341-4fa2-b6ea-bc4117dd9870@github.com> References: <9d_WP3KuuW_bibAXvhtr5JgqXBHgxmHuO6G_H8tGMVw=.14f7df27-f341-4fa2-b6ea-bc4117dd9870@github.com> Message-ID: <6qVi3g5dycbIyT-EXd-ctF-TdCqG3CSns8xCacsZYQ0=.f1103688-41ad-4895-9dbc-8d91822b4532@github.com> On Sat, 17 Aug 2024 02:44:39 GMT, Amos Shi wrote: > Backport of [JDK-8330814](https://bugs.openjdk.org/browse/JDK-8330814) > - This PR has two commits > - `commit 1` is a `clean` git patch from original commit > - `commit 2` is fixing the following compile error > - The fix is in line with https://github.com/openjdk/jdk17u-dev/commit/e96daf3b5ba1b341acbc3bf005746d0c9aacc803#diff-9aaf6eb570572e1a22b661c23e76f330d090280ef60e7390d0ab421d48a6558eR68 from @RealCLanger > > > ----------System.err:(8/634)---------- > /Users/I048686/SAPDevelop/github.com/dev-8330814-17/test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java:73: error: no suitable method found for create(InetSocketAddress,int,String,SimpleHttpTransactionHandler) > server = HttpServer.create(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0), 10, "/", new SimpleHttpTransactionHandler()); > ^ > method HttpServer.create() is not applicable > (actual and formal argument lists differ in length) > method HttpServer.create(InetSocketAddress,int) is not applicable > (actual and formal argument lists differ in length) > 1 error > result: Failed. Compilation failed: Compilation failed > > > Testing > - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max > - `B5045306.java`: Test results: passed: 1 > - `B8291637.java`: Test results: passed: 1 > - `B8293562.java`: Test results: passed: 1 > - `KeepAliveProperty.java`: Test results: passed: 1 > - `KeepAliveTimerThread.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies SUCCESSFUL on `2024-08-23` > - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-23 19:44:34+01:00` > - sun/net/www/http/KeepAliveCache/B5045306.java: SUCCESSFUL GitHub ? - [20:10:08.445 -> 14,486 msec] > - sun/net/www/http/KeepAliveCache/B8291637.java: SUCCESSFUL GitHub ? - [20:10:08.455 -> 20,795 msec] > - sun/net/www/http/KeepAliveCache/B8293562.java: SUCCESSFUL GitHub ? - [20:10:09.152 -> 7,188 msec] > - sun/net/www/http/KeepAliveCache/KeepAliveProperty.java: SUCCESSFUL GitHub ? - [20:10:09.356 -> 13,344 msec] > - sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java: SUCCESSFUL GitHub ? - [20:10:09.722 -> 2,621 msec] This pull request has now been integrated. Changeset: 99b7468e Author: Amos Shi URL: https://git.openjdk.org/jdk17u-dev/commit/99b7468ef39571d5276b071f7040e2dfb01f703c Stats: 290 lines in 5 files changed: 113 ins; 69 del; 108 mod 8330814: Cleanups for KeepAliveCache tests Reviewed-by: clanger Backport-of: a5005c87c4d5598eb54e9824105767d833f9660b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2813 From mbaesken at openjdk.org Wed Aug 28 08:06:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 08:06:23 GMT Subject: [jdk21u-dev] Integrated: 8338110: Exclude Fingerprinter::do_type from ubsan checks In-Reply-To: References: Message-ID: <0LphXVs13Im3LLGM6U3qDbiXjp-T5I53n6V4RYCY4NM=.16c1538a-6718-43c4-be9d-7f97c769c84d@github.com> On Thu, 15 Aug 2024 15:30:17 GMT, Matthias Baesken wrote: > 8338110: Exclude Fingerprinter::do_type from ubsan checks This pull request has now been integrated. Changeset: b0da5c7b Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/b0da5c7bf7455082249d5cc181d8a3f15b619811 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8338110: Exclude Fingerprinter::do_type from ubsan checks Backport-of: 6a390147959e0fb88de6ee13204cff72cd910f09 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/924 From mbaesken at openjdk.org Wed Aug 28 08:09:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 08:09:29 GMT Subject: [jdk21u-dev] Integrated: 8316895: SeenThread::print_action_queue called on a null pointer In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 09:37:54 GMT, Matthias Baesken wrote: > 8316895: SeenThread::print_action_queue called on a null pointer This pull request has now been integrated. Changeset: eb80936a Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/eb80936a7fd049369972f44be998733e48a05398 Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod 8316895: SeenThread::print_action_queue called on a null pointer Backport-of: fd52be2a3c53912598afe600d680de77090f9f43 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/927 From mbaesken at openjdk.org Wed Aug 28 08:20:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 08:20:33 GMT Subject: [jdk21u-dev] RFR: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Message-ID: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling ------------- Commit messages: - Backport 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc Changes: https://git.openjdk.org/jdk21u-dev/pull/948/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=948&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334567 Stats: 12 lines in 1 file changed: 5 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/948.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/948/head:pull/948 PR: https://git.openjdk.org/jdk21u-dev/pull/948 From mbaesken at openjdk.org Wed Aug 28 08:20:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 08:20:50 GMT Subject: [jdk23u] RFR: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Message-ID: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling ------------- Commit messages: - Backport 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc Changes: https://git.openjdk.org/jdk23u/pull/86/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=86&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334567 Stats: 12 lines in 1 file changed: 5 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/86.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/86/head:pull/86 PR: https://git.openjdk.org/jdk23u/pull/86 From goetz at openjdk.org Wed Aug 28 08:53:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Aug 2024 08:53:29 GMT Subject: [jdk17u-dev] Integrated: 8339081: Bump update version for OpenJDK: jdk-17.0.14 In-Reply-To: References: Message-ID: On Tue, 27 Aug 2024 15:01:11 GMT, Goetz Lindenmaier wrote: > We need this to start the next release. This pull request has now been integrated. Changeset: e50b8150 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e50b81503b0ee3cd3116345ff6bf31fa591dd3fc Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8339081: Bump update version for OpenJDK: jdk-17.0.14 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2826 From goetz at openjdk.org Wed Aug 28 10:28:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Aug 2024 10:28:31 GMT Subject: [jdk11u-dev] Integrated: 8339082: Bump update version for OpenJDK: jdk-11.0.26 In-Reply-To: References: Message-ID: On Tue, 27 Aug 2024 15:04:56 GMT, Goetz Lindenmaier wrote: > We need this for the next release. This pull request has now been integrated. Changeset: ce572dfe Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ce572dfede792da0eb1b98ac3d8d1df7064dea33 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8339082: Bump update version for OpenJDK: jdk-11.0.26 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2927 From mbaesken at openjdk.org Wed Aug 28 12:02:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 12:02:34 GMT Subject: [jdk17u-dev] RFR: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int' Message-ID: Backport of 8332904, COPYRIGHT header needs manual adjustment ------------- Commit messages: - Backport 9b64ece514cf941ebc727991d97c43453d8a488d Changes: https://git.openjdk.org/jdk17u-dev/pull/2827/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2827&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332904 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2827.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2827/head:pull/2827 PR: https://git.openjdk.org/jdk17u-dev/pull/2827 From mbaesken at openjdk.org Wed Aug 28 12:10:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 12:10:20 GMT Subject: [jdk17u-dev] Integrated: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 11:55:06 GMT, Matthias Baesken wrote: > 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' This pull request has now been integrated. Changeset: 6f382d1f Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/6f382d1fcfb514ab11e991ceb3c94967e8cbc054 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' Backport-of: 113a2c028dc3b9abb6229d5f0b812b54a9b61011 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2805 From mbaesken at openjdk.org Wed Aug 28 12:12:25 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 12:12:25 GMT Subject: [jdk17u-dev] RFR: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int' In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 11:57:15 GMT, Matthias Baesken wrote: > Backport of 8332904, COPYRIGHT header needs manual adjustment Only COPYRIGHT headers needed manual adjustment (year info). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2827#issuecomment-2315150981 From mbaesken at openjdk.org Wed Aug 28 12:30:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 12:30:36 GMT Subject: [jdk17u-dev] RFR: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' Message-ID: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' ------------- Commit messages: - Backport 2baacfc16916220846743c6e49a99a6c41cac510 Changes: https://git.openjdk.org/jdk17u-dev/pull/2828/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2828&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331789 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2828.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2828/head:pull/2828 PR: https://git.openjdk.org/jdk17u-dev/pull/2828 From mbaesken at openjdk.org Wed Aug 28 12:49:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Aug 2024 12:49:37 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null Message-ID: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null ------------- Commit messages: - Backport be1d374bc54d43aae3b3c1feace22d38fe2156b6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2829/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2829&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332825 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2829.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2829/head:pull/2829 PR: https://git.openjdk.org/jdk17u-dev/pull/2829 From stuefe at openjdk.org Wed Aug 28 13:02:25 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 28 Aug 2024 13:02:25 GMT Subject: [jdk17u-dev] RFR: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 12:44:10 GMT, Matthias Baesken wrote: > 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null src/hotspot/share/memory/guardedMemory.cpp line 38: > 36: if (ptr != nullptr) { > 37: memcpy(innerp, ptr, len); > 38: } Hmm. innerp can never be null. If anything, we should assert. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2829#discussion_r1734634157 From rvansa at openjdk.org Wed Aug 28 15:19:53 2024 From: rvansa at openjdk.org (Radim Vansa) Date: Wed, 28 Aug 2024 15:19:53 GMT Subject: [jdk17u-dev] RFR: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp Message-ID: Hi all, This pull request contains a backport of commit[ 02f79008](https://github.com/openjdk/jdk/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson. The backport is not clean; some method return types differ in later JDK versions. Thanks! ------------- Commit messages: - Backport 02f79008828b3dcce3bd6492efaa43e99376c0c5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2830/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2830&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276932 Stats: 55 lines in 1 file changed: 3 ins; 4 del; 48 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2830.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2830/head:pull/2830 PR: https://git.openjdk.org/jdk17u-dev/pull/2830 From rvansa at openjdk.org Wed Aug 28 15:34:34 2024 From: rvansa at openjdk.org (Radim Vansa) Date: Wed, 28 Aug 2024 15:34:34 GMT Subject: [jdk17u-dev] RFR: 8273979: move some os time related functions to os_posix for POSIX platforms Message-ID: Hi all, This pull request contains a backport of commit[ 1c6fa113](https://github.com/openjdk/jdk/commit/1c6fa113bd06585945e077f0d2004a291c27946d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Matthias Baesken on 23 Sep 2021 and was reviewed by David Holmes and Lutz Schmidt. The backport applies cleanly, was created by the /backport command. Thanks! ------------- Commit messages: - Backport 1c6fa113bd06585945e077f0d2004a291c27946d Changes: https://git.openjdk.org/jdk17u-dev/pull/2831/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2831&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273979 Stats: 238 lines in 4 files changed: 63 ins; 173 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2831.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2831/head:pull/2831 PR: https://git.openjdk.org/jdk17u-dev/pull/2831 From clanger at openjdk.org Wed Aug 28 16:47:20 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 28 Aug 2024 16:47:20 GMT Subject: [jdk17u-dev] RFR: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int' In-Reply-To: References: Message-ID: <9jGYlV684ZxdmmY6udI-ZY8mEhPfRxToUF05EunVnE0=.c8acae35-cf68-4ce3-8866-9425f4c7b443@github.com> On Wed, 28 Aug 2024 11:57:15 GMT, Matthias Baesken wrote: > Backport of 8332904, COPYRIGHT header needs manual adjustment Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2827#pullrequestreview-2266793029 From phh at openjdk.org Wed Aug 28 18:32:20 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 28 Aug 2024 18:32:20 GMT Subject: [jdk17u-dev] RFR: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp In-Reply-To: References: Message-ID: <1n1ulWKHtYJnGyFaTJiAf_BIqwo5HUsJYIpnEv1XKOc=.dff8e643-2c7b-4ec9-b7ce-ac074e9128a5@github.com> On Wed, 28 Aug 2024 15:16:04 GMT, Radim Vansa wrote: > Hi all, > > This pull request contains a backport of commit[ 02f79008](https://github.com/openjdk/jdk/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson. > > The backport is not clean; some method return types differ in later JDK versions. > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2830#pullrequestreview-2266991729 From phh at openjdk.org Wed Aug 28 18:42:30 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 28 Aug 2024 18:42:30 GMT Subject: [jdk21u-dev] RFR: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 22:57:04 GMT, Daniel Hu wrote: > Backport of [JDK-8319970](https://bugs.openjdk.org/browse/JDK-8319970) that enables tests for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64. Not clean because [RISC-V intrinsics for divideUnsigned and remainderUnsigned were added in JDK22](https://github.com/openjdk/jdk/commit/40a3c35aa5614be4505013d4e92ddb1b556a3622); aarch64 intrinsics for divideUnsigned and remainderUnsigned confirmed to be [released in JDK20](https://bugs.openjdk.org/browse/JDK-8287926). > > This includes backport of [JDK-8319960](https://bugs.openjdk.org/browse/JDK-8319960) because the `UDivModI` or `UDivModL` nodes are supplied from x86_64.ad, thus these node checks are intended for x64 platforms. Although originally intended to fix the test failing for RISC-V intrinsics, without this exclusion the test will also fail for aarch64 platforms, thus it is included as part of the backport. > > Passes affected tests on Linux aarch64 and Mac aarch64. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/914#pullrequestreview-2267010554 From ashi at openjdk.org Thu Aug 29 00:28:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 29 Aug 2024 00:28:39 GMT Subject: [jdk17u-dev] RFR: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails Message-ID: Backport of [JDK-8254759](https://bugs.openjdk.org/browse/JDK-8254759) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `javax/swing/JInternalFrame/4202966/IntFrameCoord.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 2dd882af0830f174810840affa79045db4f04ef0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2832/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2832&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8254759 Stats: 145 lines in 1 file changed: 145 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2832.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2832/head:pull/2832 PR: https://git.openjdk.org/jdk17u-dev/pull/2832 From ashi at openjdk.org Thu Aug 29 00:43:37 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 29 Aug 2024 00:43:37 GMT Subject: [jdk11u-dev] RFR: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails Message-ID: Backport of [JDK-8254759](https://bugs.openjdk.org/browse/JDK-8254759) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `javax/swing/JInternalFrame/4202966/IntFrameCoord.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 2dd882af0830f174810840affa79045db4f04ef0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2928/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2928&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8254759 Stats: 145 lines in 1 file changed: 145 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2928.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2928/head:pull/2928 PR: https://git.openjdk.org/jdk11u-dev/pull/2928 From ashi at openjdk.org Thu Aug 29 01:05:00 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 29 Aug 2024 01:05:00 GMT Subject: [jdk17u-dev] RFR: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak" Message-ID: Backport of [JDK-8258734](https://bugs.openjdk.org/browse/JDK-8258734) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `jdk/jfr/event/oldobject/TestClassLoaderLeak.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport aefd4ac4a336f00c067bcb91b95472ccc9a6bf83 Changes: https://git.openjdk.org/jdk17u-dev/pull/2833/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2833&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8258734 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2833.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2833/head:pull/2833 PR: https://git.openjdk.org/jdk17u-dev/pull/2833 From ashi at openjdk.org Thu Aug 29 01:12:54 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 29 Aug 2024 01:12:54 GMT Subject: [jdk11u-dev] RFR: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak" Message-ID: Directory "build/jtreg-test" not found: creating Directory "JTreport" not found: creating Passed: jdk/jfr/event/oldobject/TestClassLoaderLeak.java Test results: passed: 1 Report written to /Users/I048686/SAPDevelop/github.com/dev-8258734-17/JTreport/html/report.html Results written to /Users/I048686/SAPDevelop/github.com/dev-8258734-17/build/jtreg-test ------------- Commit messages: - Backport aefd4ac4a336f00c067bcb91b95472ccc9a6bf83 Changes: https://git.openjdk.org/jdk11u-dev/pull/2929/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2929&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8258734 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2929.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2929/head:pull/2929 PR: https://git.openjdk.org/jdk11u-dev/pull/2929 From syan at openjdk.org Thu Aug 29 02:21:21 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 02:21:21 GMT Subject: [jdk23u] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 06:32:37 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [284671a1](https://github.com/openjdk/jdk/commit/284671a1e4fb5bfe15b20b7f41fc24415b1235ed) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Calvin Cheung on 8 Jul 2024 and was reviewed by Matias Saavedra Silva and Ioi Lam. > > Clean backport to make the test more robustness, test fix only, no risk. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/80#issuecomment-2316585313 From duke at openjdk.org Thu Aug 29 02:21:21 2024 From: duke at openjdk.org (duke) Date: Thu, 29 Aug 2024 02:21:21 GMT Subject: [jdk23u] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 06:32:37 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [284671a1](https://github.com/openjdk/jdk/commit/284671a1e4fb5bfe15b20b7f41fc24415b1235ed) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Calvin Cheung on 8 Jul 2024 and was reviewed by Matias Saavedra Silva and Ioi Lam. > > Clean backport to make the test more robustness, test fix only, no risk. > > Thanks! @sendaoYan Your change (at version 7483ce4443c443cf1c9d5df71cae30a2a93b3cfb) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/80#issuecomment-2316586094 From bulasevich at openjdk.org Thu Aug 29 02:49:59 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 29 Aug 2024 02:49:59 GMT Subject: [jdk21u-dev] RFR: 8331393: AArch64: u32 _partial_subtype_ctr loaded/stored as 64 Message-ID: Clean backport. A small change to use properly sized store/load instructions. Affects only: AARCH fastdebug. Tested: jtreg (hotspot&jdk) tier 1-3 ------------- Commit messages: - Backport f215899a088d1abe86adccf0e65a073189272ddd Changes: https://git.openjdk.org/jdk21u-dev/pull/949/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=949&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331393 Stats: 9 lines in 2 files changed: 0 ins; 7 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/949.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/949/head:pull/949 PR: https://git.openjdk.org/jdk21u-dev/pull/949 From duke at openjdk.org Thu Aug 29 06:35:31 2024 From: duke at openjdk.org (duke) Date: Thu, 29 Aug 2024 06:35:31 GMT Subject: [jdk11u-dev] Withdrawn: 8292177: InitialSecurityProperty JFR event In-Reply-To: References: Message-ID: On Sat, 29 Jun 2024 16:21:19 GMT, Andrew John Hughes wrote: > This backport introduces the JFR security event, `InitialSecurityProperty`, and along with it, the caching of the initial security properties which is also used by [JDK-8281658](https://bugs.openjdk.org/browse/JDK-8281658) to show the security properties with `-XshowSettings`. > > The change was backported to the Oracle fork of 11u in 11.0.20. > > The following changes were necessary for the backport: > > * `JavaSecurityPropertiesAccess` is moved to `jdk.internal.misc` where `SharedSecrets` lives in 11u > * `ensureClassInitialized` in `SharedSecrets` is called from the `unsafe` instance in 11u, as with other `get*Access()` methods in that class > * The patch to `module-info.java` is not needed as `jdk.jfr` already has access to `jdk.internal.misc` in 11u. The 17u addition is to `jdk.internal.access`. > * There are context differences in `JDKEvents.java` due to events introduced in later JDK versions. > * The `EventNames.java` test includes a huge unrelated change to reorganise the order of the variable modifiers. This was applied manually to the names in 11u, which differ slightly from those in 17u. > > All `jdk.jfr.event` tests passed, including the new one, with the exception of `TestNative`, but that seems to be a setup issue rather than a regression caused by this patch (`Error. Use -nativepath to specify the location of native code`) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2827 From goetz.lindenmaier at sap.com Thu Aug 29 09:31:38 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 29 Aug 2024 09:31:38 +0000 Subject: Vulnerability of the non LTS JDK releases In-Reply-To: References: <556e1e33-f609-43b5-937c-c8ae98102423@oracle.com> Message-ID: Hi Lovro, There is no central place where this is decided. This is an open source project. Activities depend on people/parties that engage in this project. Oracle decided to support 11, 17, 21 etc long term in their commercial version. Also, they support all Java versions for 2 releases in OpenJDK. Other parties decided to take over support for some of the Java versions after that. I.e., Red Hat and SAP decided to dedicate people to support 11, 17 and 21 for a longer time. Azul had dedicated people to support 13 and 15 for some time after the first two updates. The community is helping with this effort. In the end, various parties are building binaries from the maintained repos. So if you have need of longer support of the non-LTS, you can turn them into LTS releases by taking up support in the OpenJDK. There are mails announcing end of engagement of the current supportee of versions, e.g., https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-November/027149.html All activities around updates after Java 8 are bundled in the jdk-updates project of OpenJDK. Lead of this project is Rob McKenna. Best regards, Goetz. From: jdk-dev On Behalf Of Lovro Pand?ic Sent: Thursday, August 29, 2024 10:09 AM To: Chen Liang ; jdk-dev at openjdk.org Subject: Re: Vulnerability of the non LTS JDK releases Some people who received this message don't often get email from lovro.pandzic at infobip.com. Learn why this is important Thank you for clarification. Maybe I should clarify my original mail as well: I'm not asking for any specific jdk vendor version support or any jdk version support change at all for that matter. I'm asking for a right place to ask where it was decided that versions are 6 months apart and that each non LTS version will only have supported up until the next one is out. My observation is that current process and state of things put people into an uncomfortable position where they either have to accept to be on unsupported version of non lts for some time and risk security vulnerabilites and all the stress that comes with that or if they don't want to deal with that - they must pick LTS versions. This state of affairs is unfortunate and makes non LTS version seem as if non LTS versions are "for development" only and not ready for production use. They are only ok for production use if you control all the software you're running on and you have guarantees that on day 1 of next non LTS release you can upgrade all in one go - which in my experience is never true. Hope this clarifies things a bit. Thank you, [cid:image001.png at 01DAFA04.5AFF60B0] Lovro Pand?i? Senior Principal Engineer E Lovro.Pandzic at infobip.com M +385921001403 A Utinjska 29A, 10000 Zagreb, Croatia www.infobip.com From: Chen Liang > Date: Monday, 26 August 2024 at 17:25 To: Lovro Pand?i? >, jdk-dev at openjdk.org > Subject: [EXTERNAL] Re: Vulnerability of the non LTS JDK releases Hello Lovro, To clarify Alan's remarks, there's a dedicated jdk-updates-dev list and a jdk-updates project responsible for any released jdk; for example, if 23 is released, the subsequent releases of 23.0.1 and 23.0.2, etc. are their responsibility. A request for backporting critical security fixes to 1 release before the latest should be raised to the jdk-updates project., which is usually constituted of "the companies and organizations that make supported JDK releases available." For the frequency of security fixes: there's a https://openjdk.org/groups/vulnerability/ vulnerabiltiy group that releases security fixes every quarter (see https://mail.openjdk.org/pipermail/vuln-announce/), usually in Jan, Apr, Jul, and Oct. Do you wish for Apr and Oct vulnerability fixes to be incorporated into the last release before the latest (released just one month prior)? You can raise this request to the jdk-updates-dev list there. I have heard that even backporting even security fixes would be a heavy maintenance cost; so, the updates group might reject your request of 1 year of security fixes, as new releases roll out every half a year. But a security fix for the one version before the latest released version release makes sense to me, especially that the new version is just released for one month. Ultimately, it is up to jdk-update project's discretion, so go ask them. Regards, Chen Liang ________________________________ From: jdk-dev > on behalf of Alan Bateman > Sent: Monday, August 26, 2024 2:23 AM To: Lovro Pand?i? >; jdk-dev at openjdk.org > Subject: Re: Vulnerability of the non LTS JDK releases On 26/08/2024 06:38, Lovro Pand?i? wrote: Hello all, Not sure if this is the right address to talk about this issue so feel free to redirect me to another if it's more appropriate. Your question isn't unreasonable but it's not really a question for the OpenJDK project, instead it's a question for the companies and organizations that make supported JDK releases available. : Projects that want to follow the train in it's tracks and be on latest, usually non lts, version and that use any non trivial kind of dependency (Spring, Sonar, ...) they must accept the fact that there will be periods of time (usually a month or two) where they'll be forced to stay on an unsupported non LTS version until all of their dependencies add support for latest JDK version so they can upgrade as well. Just a reminder that there Early Access (EA) builds published weekly so these projects don't need to wait until the GA to test. Ongoing testing with EA builds help find issues earlier and allows these projects to align their releases with the JDK releases. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.png Type: image/png Size: 2551 bytes Desc: image001.png URL: From goetz.lindenmaier at sap.com Thu Aug 29 09:40:25 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 29 Aug 2024 09:40:25 +0000 Subject: BasicFileAttributeView/CreationTime.java still failing after 8337038. Message-ID: Hi Sendao, we still see this test failing with the same error as reported in 8337038. Last appearance is in jdk17u after the latest tag, which includes 8337038. I think we should assure the tests are not run in parallel. Would main/othervm be a better mode to run them? Best regards, Goetz -------------- next part -------------- An HTML attachment was scrubbed... URL: From qxing at openjdk.org Thu Aug 29 10:48:21 2024 From: qxing at openjdk.org (Qizheng Xing) Date: Thu, 29 Aug 2024 10:48:21 GMT Subject: [jdk23u] RFR: 8333334: C2: Make result of `Node::dominates` more precise to enhance scalar replacement In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 10:15:38 GMT, Tobias Hartmann wrote: > What's the justification to backport this? The bar for backporting enhancements is quite high. Please note that you also need maintainer approval. @TobiHartmann Sorry for that, I haven't backported enhancement patches before. I'll close this PR. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/83#issuecomment-2317301049 From qxing at openjdk.org Thu Aug 29 10:48:22 2024 From: qxing at openjdk.org (Qizheng Xing) Date: Thu, 29 Aug 2024 10:48:22 GMT Subject: [jdk23u] Withdrawn: 8333334: C2: Make result of `Node::dominates` more precise to enhance scalar replacement In-Reply-To: References: Message-ID: On Fri, 23 Aug 2024 09:55:09 GMT, Qizheng Xing wrote: > Hi all, > > This pull request contains a backport of commit [965dd1ac](https://github.com/openjdk/jdk/commit/965dd1acd0ce5b225d85e2c55cc097856e0e9f3c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Qizheng Xing on 23 Aug 2024 and was reviewed by Christian Hagedorn, Vladimir Kozlov and Tobias Hartmann. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/83 From mbaesken at openjdk.org Thu Aug 29 12:14:44 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 29 Aug 2024 12:14:44 GMT Subject: [jdk17u-dev] RFR: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null Message-ID: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null ------------- Commit messages: - Backport 16dba04e8dfa871f8056480a42a9baeb24a2fb24 Changes: https://git.openjdk.org/jdk17u-dev/pull/2834/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2834&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332589 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2834.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2834/head:pull/2834 PR: https://git.openjdk.org/jdk17u-dev/pull/2834 From alexey.ivanov at oracle.com Thu Aug 29 12:16:32 2024 From: alexey.ivanov at oracle.com (Aleksei Ivanov) Date: Thu, 29 Aug 2024 12:16:32 +0000 Subject: CFV: New JDK Updates Committer - Ravi Reddy In-Reply-To: References: Message-ID: Vote: yes > On 26 Aug 2024, at 15:04, Robert Mckenna wrote: > > I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. -- Regards, Alexey From goetz at openjdk.org Thu Aug 29 13:03:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Aug 2024 13:03:25 GMT Subject: [jdk21u-dev] RFR: 8337780: RISC-V: C2: Change C calling convention for sp to NS In-Reply-To: References: Message-ID: On Sun, 25 Aug 2024 02:25:31 GMT, Fei Yang wrote: > Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. Gtest & Tier1-3 tested on linux-riscv64 platform. Please backport to 23 first. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/945#issuecomment-2317595827 From syan at openjdk.org Thu Aug 29 13:14:24 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 13:14:24 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2317620733 From duke at openjdk.org Thu Aug 29 13:14:25 2024 From: duke at openjdk.org (duke) Date: Thu, 29 Aug 2024 13:14:25 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! @sendaoYan Your change (at version 8981228d250434f7f4a53f6df52e8ba7c2500b03) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2317622122 From fyang at openjdk.org Thu Aug 29 13:14:30 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 29 Aug 2024 13:14:30 GMT Subject: [jdk21u-dev] RFR: 8337780: RISC-V: C2: Change C calling convention for sp to NS In-Reply-To: References: Message-ID: On Thu, 29 Aug 2024 13:01:06 GMT, Goetz Lindenmaier wrote: > Please backport to 23 first. Ah, I missed that. Will do. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/945#issuecomment-2317621517 From syan at openjdk.org Thu Aug 29 13:15:23 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 13:15:23 GMT Subject: [jdk17u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2820#issuecomment-2317621374 From duke at openjdk.org Thu Aug 29 13:15:23 2024 From: duke at openjdk.org (duke) Date: Thu, 29 Aug 2024 13:15:23 GMT Subject: [jdk17u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! @sendaoYan Your change (at version aaf33f16fc46ab488ee09e1f01e5d4911da70b6f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2820#issuecomment-2317625030 From goetz at openjdk.org Thu Aug 29 13:31:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Aug 2024 13:31:21 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v2] In-Reply-To: References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: On Mon, 13 May 2024 09:39:44 GMT, SendaoYan wrote: >> Hi, >> This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport >> [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) >> >> Only change the testcase, the change has been verify on below binary: >> >> - [x] linux x64 release >> - [x] linux x64 fastdebug >> - [x] linux x86 release >> - [x] linux x86 fastdebug >> [linux-x64-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142005/linux-x64-fastdebug.log) >> [linux-x64-release.log](https://github.com/openjdk/jdk17u-dev/files/15142006/linux-x64-release.log) >> [linux-x86-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142007/linux-x86-fastdebug.log) >> [linux-x86-release.log](https://github.com/openjdk/jdk17u-dev/files/15142009/linux-x86-release.log) >> >> It's not clean backport: >> 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 >> 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev >> 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev >> 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8290023 > - Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2 > > Signed-off-by: sendaoYan Hi Sendao, please only label for approval if you have a review. I will only approve reviewed changes, but there is no way I can filter for this. So I revisit changes labeled for approval but not reviewed every time I do approvals, badly wasting my time. I will remove the fix-request labels next time I visit changes not reviewed. You can label again once a review is there. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2438#issuecomment-2317661873 From goetz at openjdk.org Thu Aug 29 13:34:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Aug 2024 13:34:26 GMT Subject: [jdk17u-dev] RFR: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' In-Reply-To: References: Message-ID: <_HIQlqKmYfr5UsVjKZ7G0-MWMqBgclfo0MfW0-qieo4=.f297793a-1a52-471c-a64f-ce5ba0b54231@github.com> On Wed, 28 Aug 2024 12:26:18 GMT, Matthias Baesken wrote: > 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' Hi, you have failing tests. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2828#issuecomment-2317670281 From mbaesken at openjdk.org Thu Aug 29 13:38:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 29 Aug 2024 13:38:20 GMT Subject: [jdk17u-dev] RFR: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 12:26:18 GMT, Matthias Baesken wrote: > 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' macos aarch64 has some strange error in serviceability/sa/ClhsdbCDSJstackPrintAll; most likely this is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2828#issuecomment-2317679173 From syan at openjdk.org Thu Aug 29 14:13:21 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 14:13:21 GMT Subject: [jdk17u-dev] Integrated: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! This pull request has now been integrated. Changeset: ada58fa5 Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/ada58fa55bb265aa62bbe9389d08cbc39e3e32e0 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Backport-of: 39884205fbc0e85ce9d78303dfbabf125ff36535 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2820 From syan at openjdk.org Thu Aug 29 14:27:24 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 14:27:24 GMT Subject: [jdk21u-dev] Integrated: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! This pull request has now been integrated. Changeset: e9397610 Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/e93976109dfb06c782ce6d4aa9eb228e9f3556c9 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Backport-of: 39884205fbc0e85ce9d78303dfbabf125ff36535 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/943 From syan at openjdk.org Thu Aug 29 14:29:26 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 14:29:26 GMT Subject: [jdk23u] Integrated: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 06:32:37 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [284671a1](https://github.com/openjdk/jdk/commit/284671a1e4fb5bfe15b20b7f41fc24415b1235ed) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Calvin Cheung on 8 Jul 2024 and was reviewed by Matias Saavedra Silva and Ioi Lam. > > Clean backport to make the test more robustness, test fix only, no risk. > > Thanks! This pull request has now been integrated. Changeset: b8037f83 Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/b8037f835bd373396ad9df9855466bec04908f36 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... Backport-of: 284671a1e4fb5bfe15b20b7f41fc24415b1235ed ------------- PR: https://git.openjdk.org/jdk23u/pull/80 From duke at openjdk.org Thu Aug 29 15:27:48 2024 From: duke at openjdk.org (Mimoun Ghordou) Date: Thu, 29 Aug 2024 15:27:48 GMT Subject: [jdk23u] RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java [v3] In-Reply-To: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> References: <3pwEzQxTiZJbliKX3l1Y-v60JbKRh5qznRRty61UFnM=.31156468-b7ad-408e-a1da-a4b79cf257ef@github.com> Message-ID: > Clean Backport > > Tested open/test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java, works fine Mimoun Ghordou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into backport-8335397 - 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation - 8335397: Improve reliability of TestRecursiveMonitorChurn.java ------------- Changes: - all: https://git.openjdk.org/jdk23u/pull/57/files - new: https://git.openjdk.org/jdk23u/pull/57/files/89e960e7..e664bc93 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk23u&pr=57&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk23u&pr=57&range=01-02 Stats: 10405 lines in 61 files changed: 10044 ins; 171 del; 190 mod Patch: https://git.openjdk.org/jdk23u/pull/57.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/57/head:pull/57 PR: https://git.openjdk.org/jdk23u/pull/57 From syan at openjdk.org Thu Aug 29 15:28:21 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 15:28:21 GMT Subject: [jdk17u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: <0dZRb-Xju87GIL_4sZOLf2WniiskUpK0TMnzRqaDeTg=.a6615c5f-b225-44df-92c5-5ab103846bd5@github.com> On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2820#issuecomment-2318142195 From syan at openjdk.org Thu Aug 29 15:32:25 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 15:32:25 GMT Subject: [jdk23u] RFR: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ... In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 06:32:37 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [284671a1](https://github.com/openjdk/jdk/commit/284671a1e4fb5bfe15b20b7f41fc24415b1235ed) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Calvin Cheung on 8 Jul 2024 and was reviewed by Matias Saavedra Silva and Ioi Lam. > > Clean backport to make the test more robustness, test fix only, no risk. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/80#issuecomment-2318151573 From syan at openjdk.org Thu Aug 29 15:38:21 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 15:38:21 GMT Subject: [jdk21u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:49:48 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > Thanks! Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/943#issuecomment-2318168156 From syan at openjdk.org Thu Aug 29 15:46:24 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 15:46:24 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v2] In-Reply-To: References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: On Thu, 29 Aug 2024 13:28:48 GMT, Goetz Lindenmaier wrote: > Hi Sendao, please only label for approval if you have a review. I will only approve reviewed changes, but there is no way I can filter for this. So I revisit changes labeled for approval but not reviewed every time I do approvals, badly wasting my time. I will remove the fix-request labels next time I visit changes not reviewed. You can label again once a review is there. Thanks. Sorry for that. I will cancel approval of all the PRs which have not been review yet. Sorry. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2438#issuecomment-2318187739 From mbaesken at openjdk.org Thu Aug 29 15:48:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 29 Aug 2024 15:48:32 GMT Subject: [jdk17u-dev] RFR: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null Message-ID: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null ------------- Commit messages: - Backport e529101ea30b49a6601088ce5ab81df590fc52f0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2835/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2835&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332473 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2835.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2835/head:pull/2835 PR: https://git.openjdk.org/jdk17u-dev/pull/2835 From syan at openjdk.org Thu Aug 29 15:54:28 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 15:54:28 GMT Subject: [jdk21u-dev] RFR: 8338748: [17u, 21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 15:48:49 GMT, SendaoYan wrote: > Hi all, > Test `java/nio/channels/DatagramChannel/Disconnect.java` compile error: `cannot find symbol InetAddress.ofLiteral` after JDK-8299813. There is no `InetAddress.ofLiteral` API in jdk21u and jdk17u, the `InetAddress.ofLiteral` API was added by [JDK-8272215](https://bugs.openjdk.org/browse/JDK-8272215) in jdk22. > Change `InetAddress.ofLiteral`to `Inet6Address.getByName`, change has been verified, test fix only, no risk. Before this PR has been reviewed, the approval label should not seted. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/939#issuecomment-2318208938 From syan at openjdk.org Thu Aug 29 15:55:33 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 15:55:33 GMT Subject: [jdk11u-dev] RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> References: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> Message-ID: On Thu, 22 Aug 2024 13:15:13 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > This PR not clean, because this file has changed by JDK-8328638 and JDK-8329213 which not backported to jdk11u-dev. > > Thanks! Before this PR has been reviewed, the approval label should not be seted. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2919#issuecomment-2318210617 From shade at openjdk.org Thu Aug 29 16:28:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Aug 2024 16:28:26 GMT Subject: [jdk17u-dev] Integrated: 8338286: GHA: Demote x86_32 to hotspot build only In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 12:05:20 GMT, Aleksey Shipilev wrote: > This should make GHAs cleaner and more efficient for future backports. > > This backport is a bit unclean: there was a minor conflict in `default` line, which does not include some platform builds that are present past JDK 17. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: fd38e86f Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/fd38e86f84b0c1044ef6fce3836fc319e3df646e Stats: 19 lines in 1 file changed: 1 ins; 11 del; 7 mod 8338286: GHA: Demote x86_32 to hotspot build only Reviewed-by: phh Backport-of: da7311bbe37c2b9632b117d52a77c659047820b7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2816 From shade at openjdk.org Thu Aug 29 16:28:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Aug 2024 16:28:33 GMT Subject: [jdk17u-dev] Integrated: 8336342: Fix known X11 library locations in sysroot In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 18:10:17 GMT, Aleksey Shipilev wrote: > Allows cleaner cross-builds without supplying `--x-libraries` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 17u-dev builds, and there were no problems. This pull request has now been integrated. Changeset: a9d755ca Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/a9d755ca35b6bd952c5e48c2975d1c813cb5b0cd Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8336342: Fix known X11 library locations in sysroot Backport-of: ee365d75cca6f33e5781fe514e557caba2b67c32 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2785 From shade at openjdk.org Thu Aug 29 16:28:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Aug 2024 16:28:34 GMT Subject: [jdk17u-dev] Integrated: 8336343: Add more known sysroot library locations for ALSA In-Reply-To: References: Message-ID: On Mon, 5 Aug 2024 18:17:35 GMT, Aleksey Shipilev wrote: > Allows cleaner cross-builds without supplying `--with-alsa` for custom-generated sysroots, e.g. crosstool-ng ones. I have been running with this patch for 3+ weeks in 17u-dev builds, and there were no problems. This pull request has now been integrated. Changeset: 7374e7d9 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/7374e7d9060abc9519180aeeb7f0a6f1234e62e7 Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod 8336343: Add more known sysroot library locations for ALSA Backport-of: 9e6e0a8f341389215f0db6b2260f2b16351f02be ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2786 From duke at openjdk.org Thu Aug 29 17:22:20 2024 From: duke at openjdk.org (duke) Date: Thu, 29 Aug 2024 17:22:20 GMT Subject: [jdk21u-dev] RFR: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 In-Reply-To: References: Message-ID: <4h2zENdqe21V8ARFe0T-7fqoIPeOwqjNA8-JnJ8JmG8=.bc6bbb3c-cb69-4343-a3b8-1279464f5f21@github.com> On Mon, 12 Aug 2024 22:57:04 GMT, Daniel Hu wrote: > Backport of [JDK-8319970](https://bugs.openjdk.org/browse/JDK-8319970) that enables tests for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64. Not clean because [RISC-V intrinsics for divideUnsigned and remainderUnsigned were added in JDK22](https://github.com/openjdk/jdk/commit/40a3c35aa5614be4505013d4e92ddb1b556a3622); aarch64 intrinsics for divideUnsigned and remainderUnsigned confirmed to be [released in JDK20](https://bugs.openjdk.org/browse/JDK-8287926). > > This includes backport of [JDK-8319960](https://bugs.openjdk.org/browse/JDK-8319960) because the `UDivModI` or `UDivModL` nodes are supplied from x86_64.ad, thus these node checks are intended for x64 platforms. Although originally intended to fix the test failing for RISC-V intrinsics, without this exclusion the test will also fail for aarch64 platforms, thus it is included as part of the backport. > > Passes affected tests on Linux aarch64 and Mac aarch64. @cost0much Your change (at version 95c8f0a6839ee1d92475cc6e683e020c2f2e1d75) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/914#issuecomment-2318427127 From duke at openjdk.org Thu Aug 29 17:43:32 2024 From: duke at openjdk.org (Daniel Hu) Date: Thu, 29 Aug 2024 17:43:32 GMT Subject: [jdk21u-dev] Integrated: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 22:57:04 GMT, Daniel Hu wrote: > Backport of [JDK-8319970](https://bugs.openjdk.org/browse/JDK-8319970) that enables tests for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64. Not clean because [RISC-V intrinsics for divideUnsigned and remainderUnsigned were added in JDK22](https://github.com/openjdk/jdk/commit/40a3c35aa5614be4505013d4e92ddb1b556a3622); aarch64 intrinsics for divideUnsigned and remainderUnsigned confirmed to be [released in JDK20](https://bugs.openjdk.org/browse/JDK-8287926). > > This includes backport of [JDK-8319960](https://bugs.openjdk.org/browse/JDK-8319960) because the `UDivModI` or `UDivModL` nodes are supplied from x86_64.ad, thus these node checks are intended for x64 platforms. Although originally intended to fix the test failing for RISC-V intrinsics, without this exclusion the test will also fail for aarch64 platforms, thus it is included as part of the backport. > > Passes affected tests on Linux aarch64 and Mac aarch64. This pull request has now been integrated. Changeset: fb728705 Author: Daniel Hu Committer: Ben Taylor URL: https://git.openjdk.org/jdk21u-dev/commit/fb72870565681eb67545613cc6c323275198e021 Stats: 10 lines in 2 files changed: 2 ins; 0 del; 8 mod 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes" Reviewed-by: phh Backport-of: c80e691adf6f9ac1a41b2329ce366710e604e34e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/914 From ashi at openjdk.org Thu Aug 29 18:53:59 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 29 Aug 2024 18:53:59 GMT Subject: [jdk17u-dev] RFR: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11 Message-ID: Backport of [JDK-8284291](https://bugs.openjdk.org/browse/JDK-8284291) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `sun/security/krb5/auto/Renew.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 05ae7ed1aac6fabc9c8820c12b6567fe93a3546f Changes: https://git.openjdk.org/jdk17u-dev/pull/2836/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2836&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284291 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2836.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2836/head:pull/2836 PR: https://git.openjdk.org/jdk17u-dev/pull/2836 From ashi at openjdk.org Thu Aug 29 19:05:00 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 29 Aug 2024 19:05:00 GMT Subject: [jdk11u-dev] RFR: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11 Message-ID: Backport of [JDK-8284291](https://bugs.openjdk.org/browse/JDK-8284291) Testing - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max - Passed: `sun/security/krb5/auto/Renew.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 05ae7ed1aac6fabc9c8820c12b6567fe93a3546f Changes: https://git.openjdk.org/jdk11u-dev/pull/2930/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2930&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284291 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2930.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2930/head:pull/2930 PR: https://git.openjdk.org/jdk11u-dev/pull/2930 From ashi at openjdk.org Thu Aug 29 22:37:35 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 29 Aug 2024 22:37:35 GMT Subject: [jdk17u-dev] RFR: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test Message-ID: Backport of [JDK-8292309](https://bugs.openjdk.org/browse/JDK-8292309) Testing - Local: - Pipeline: - Testing Machine: ------------- Commit messages: - Backport b22a38dedb06199f2cba3b6f8962ddf2f9f4f16d Changes: https://git.openjdk.org/jdk17u-dev/pull/2837/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2837&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292309 Stats: 336 lines in 1 file changed: 52 ins; 224 del; 60 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2837.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2837/head:pull/2837 PR: https://git.openjdk.org/jdk17u-dev/pull/2837 From duke at openjdk.org Fri Aug 30 00:29:20 2024 From: duke at openjdk.org (duke) Date: Fri, 30 Aug 2024 00:29:20 GMT Subject: [jdk17u-dev] RFR: 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer [v2] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:38:03 GMT, Todd V. Jonker wrote: >> Backports a fix for a potential data-loss defect from JDK19 to JDK17. >> >> This change is not clean, but the conflict is minimal and localized to `StreamDecoder.java`. >> >> Viewing this diff alongside the original fix [here](https://github.com/openjdk/jdk/commit/6520843f86f638fe4d1e5b3358fab5799daca654?diff=unified&w=0#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eR184-R227) and expanding context upward a bit should be illuminating. The conflict is due to structural/indentation difference when the lock acquisition at L158 was hoisted into a separate method. That happened [here](https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84?diff=unified&w=1#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eL154-L190) (wherein this file has an ugly diff obscuring relatively simple changes). >> >> Additional testing: >> - [x] New regression test fails without the fix, passes with it >> - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test` (tier1-3) > > Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into inputstreamreader for testing > - Backport 6520843f86f638fe4d1e5b3358fab5799daca654 @toddjonker Your change (at version cbc1398810aa928440e8f5f89c9e6ab212f76259) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2726#issuecomment-2319539654 From duke at openjdk.org Fri Aug 30 00:33:27 2024 From: duke at openjdk.org (duke) Date: Fri, 30 Aug 2024 00:33:27 GMT Subject: [jdk17u-dev] RFR: 8319817: Charset constructor should make defensive copy of aliases [v2] In-Reply-To: References: <6cD_If-pKlvZDkDjOVIZciiV3ew1B8FY2SjVGDlwBzE=.c5966432-fe63-4b53-82d2-6452808331e6@github.com> Message-ID: <82YQRJNY_BjI4uOqmN4Yd-ZVN7Mg_69WS-6ns-jicjQ=.fc6a3be4-a51a-430e-8706-3d411fee19c4@github.com> On Tue, 13 Aug 2024 20:36:09 GMT, Todd V. Jonker wrote: >> Clean backport. >> >> Additional testing: >> - [x] New regression test fails without the fix, passes with it >> - [x] macosx-aarch64-server-release: `make test-tier1` >> - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` >> * These tests fail repeatedly, but also fail on `master`: >> * `build/AbsPathsInImage.java` >> * `jdk/internal/platform/docker/TestDockerMemoryMetrics.java` > > Todd V. Jonker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into charset-ctor for testing > - Backport d6d7bdc7748c10963c3e58c0287b2472646bf36f @toddjonker Your change (at version 99dbada0d64af9de7449873adc77bf692eb62363) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2713#issuecomment-2319546839 From syan at openjdk.org Fri Aug 30 01:22:14 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 30 Aug 2024 01:22:14 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v3] In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, the change has been verify on below binary: > > - [x] linux x64 release > - [x] linux x64 fastdebug > - [x] linux x86 release > - [x] linux x86 fastdebug > [linux-x64-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142005/linux-x64-fastdebug.log) > [linux-x64-release.log](https://github.com/openjdk/jdk17u-dev/files/15142006/linux-x64-release.log) > [linux-x86-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142007/linux-x86-fastdebug.log) > [linux-x86-release.log](https://github.com/openjdk/jdk17u-dev/files/15142009/linux-x86-release.log) > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8290023 - Merge branch 'openjdk:master' into jbs8290023 - Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2 Signed-off-by: sendaoYan ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2438/files - new: https://git.openjdk.org/jdk17u-dev/pull/2438/files/13b8a714..a0e75cb0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=01-02 Stats: 77002 lines in 1285 files changed: 48230 ins; 23312 del; 5460 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438 PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From fyang at openjdk.org Fri Aug 30 01:51:55 2024 From: fyang at openjdk.org (Fei Yang) Date: Fri, 30 Aug 2024 01:51:55 GMT Subject: [jdk23u] RFR: 8337780: RISC-V: C2: Change C calling convention for sp to NS Message-ID: Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. Gtest & Tier1-3 tested on linux-riscv64 platform. ------------- Commit messages: - Backport 53db937dd0766695906dc20c1dbbd3228c02fe1e Changes: https://git.openjdk.org/jdk23u/pull/87/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=87&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337780 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk23u/pull/87.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/87/head:pull/87 PR: https://git.openjdk.org/jdk23u/pull/87 From lmao at openjdk.org Fri Aug 30 06:39:52 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 30 Aug 2024 06:39:52 GMT Subject: [jdk17u-dev] RFR: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs Message-ID: Clean backport of fix of soft-ref cleaning in Parallel Full GC. ------------- Commit messages: - Backport cff9e246cc2fbd3914f40bb71daa85dcf7731396 Changes: https://git.openjdk.org/jdk17u-dev/pull/2838/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2838&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335493 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2838.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2838/head:pull/2838 PR: https://git.openjdk.org/jdk17u-dev/pull/2838 From dmitry.markov at oracle.com Fri Aug 30 09:00:35 2024 From: dmitry.markov at oracle.com (Dmitrii Markov) Date: Fri, 30 Aug 2024 09:00:35 +0000 Subject: CFV: New JDK Updates Committer - Ravi Reddy In-Reply-To: References: Message-ID: <281C5BFA-8D2E-41FD-AB56-3A7592A6CBDE@oracle.com> Vote: yes Regards, Dmitrii > On 26 Aug 2024, at 15:04, Robert Mckenna wrote: > > I hereby nominate Ravi Reddy (rreddy)[1] to JDK Updates Committer. > > Ravi is a member of the JDK Sustaining team in Oracle. He has been contributing to JDK Updates for several years now and has built up around 16 contributions across the main JDK project and various JDK Updates repositories. > > Votes are due by 23:59 UTC on Monday, Sept 2, 2024. > > Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > For Lazy Consensus voting instructions, see [4]. > > Thanks, > > -Rob > > [1] https://openjdk.org/census#rreddy > [2] https://github.com/openjdk/jdk18u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk20u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Araviniitw2012+is%3Aclosed+ > [3] https://openjdk.java.net/census#jdk-updates > [4] http://openjdk.java.net/projects/#committer-vote From mbaesken at openjdk.org Fri Aug 30 12:06:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Aug 2024 12:06:29 GMT Subject: [jdk17u-dev] Integrated: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int' In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 11:57:15 GMT, Matthias Baesken wrote: > Backport of 8332904, COPYRIGHT header needs manual adjustment This pull request has now been integrated. Changeset: acfce696 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/acfce69612d5e6f18c48551417ba6702ab84e5b6 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int' Reviewed-by: clanger Backport-of: 9b64ece514cf941ebc727991d97c43453d8a488d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2827 From mbaesken at openjdk.org Fri Aug 30 12:12:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Aug 2024 12:12:29 GMT Subject: [jdk21u-dev] Integrated: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling In-Reply-To: References: Message-ID: <-S4Y_kK2FeMfxKoZFBaKK1h5qZioyP3KNgEBEcNQO1g=.085cadef-8af3-4520-9d87-f155e4a50fa5@github.com> On Wed, 28 Aug 2024 08:15:36 GMT, Matthias Baesken wrote: > 8334567: [test] runtime/os/TestTracePageSizes move ppc handling This pull request has now been integrated. Changeset: 38e8bfeb Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/38e8bfeb65486bb138747317aedb161d503740d1 Stats: 12 lines in 1 file changed: 5 ins; 6 del; 1 mod 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Backport-of: 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/948 From mbaesken at openjdk.org Fri Aug 30 13:07:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Aug 2024 13:07:36 GMT Subject: [jdk23u] RFR: 8333522: JFR SwapSpace event might read wrong free swap space size Message-ID: 8333522: JFR SwapSpace event might read wrong free swap space size ------------- Commit messages: - Backport de55db2352f84c101f8197ee7aca80d72807fbc5 Changes: https://git.openjdk.org/jdk23u/pull/88/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=88&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333522 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk23u/pull/88.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/88/head:pull/88 PR: https://git.openjdk.org/jdk23u/pull/88 From mbaesken at openjdk.org Fri Aug 30 13:34:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Aug 2024 13:34:29 GMT Subject: [jdk21u-dev] Integrated: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion In-Reply-To: References: Message-ID: <2wdLTVP5BQpb-jQCxmMeJrhCNkJVBsGSOcdUQ6qMvCg=.82951d87-8c02-441c-adb9-092cf03bc11f@github.com> On Wed, 14 Aug 2024 11:32:18 GMT, Matthias Baesken wrote: > 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion This pull request has now been integrated. Changeset: 922360f2 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/922360f21336928cde843bd0375801fcc21f245e Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion Backport-of: 00aac4097abd3c5e6144734cfd44228bc31892fb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/920 From mbaesken at openjdk.org Fri Aug 30 13:43:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Aug 2024 13:43:04 GMT Subject: [jdk21u-dev] RFR: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 Message-ID: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058 ------------- Commit messages: - Backport 692f5cbdb9bd94f03e5f18ddf07d56fbb5c0d456 Changes: https://git.openjdk.org/jdk21u-dev/pull/950/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=950&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338101 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/950.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/950/head:pull/950 PR: https://git.openjdk.org/jdk21u-dev/pull/950 From goetz at openjdk.org Fri Aug 30 14:22:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Aug 2024 14:22:29 GMT Subject: [jdk17u-dev] RFR: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 15:16:04 GMT, Radim Vansa wrote: > Hi all, > > This pull request contains a backport of commit[ 02f79008](https://github.com/openjdk/jdk/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson. > > The backport is not clean; some method return types differ in later JDK versions. > > Thanks! There are GHA errors. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2830#issuecomment-2321415937 From mbaesken at openjdk.org Fri Aug 30 14:36:27 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 30 Aug 2024 14:36:27 GMT Subject: [jdk17u-dev] Integrated: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 12:26:18 GMT, Matthias Baesken wrote: > 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' This pull request has now been integrated. Changeset: 3ddae292 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/3ddae292e04a66e03d2cb761826dfab08ace7108 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool' Backport-of: 2baacfc16916220846743c6e49a99a6c41cac510 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2828 From duke at openjdk.org Fri Aug 30 15:38:20 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 30 Aug 2024 15:38:20 GMT Subject: [jdk17u-dev] Integrated: 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer In-Reply-To: References: Message-ID: On Thu, 18 Jul 2024 22:50:53 GMT, Todd V. Jonker wrote: > Backports a fix for a potential data-loss defect from JDK19 to JDK17. > > This change is not clean, but the conflict is minimal and localized to `StreamDecoder.java`. > > Viewing this diff alongside the original fix [here](https://github.com/openjdk/jdk/commit/6520843f86f638fe4d1e5b3358fab5799daca654?diff=unified&w=0#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eR184-R227) and expanding context upward a bit should be illuminating. The conflict is due to structural/indentation difference when the lock acquisition at L158 was hoisted into a separate method. That happened [here](https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84?diff=unified&w=1#diff-e720d7662e29697b70409dd2aae7864f4e89d4bec33aa8d2ffce83cab365115eL154-L190) (wherein this file has an ugly diff obscuring relatively simple changes). > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test` (tier1-3) This pull request has now been integrated. Changeset: 42b5e12b Author: Todd V. Jonker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/42b5e12b58f6f6014ff841fe980fcf160c0330e0 Stats: 33 lines in 2 files changed: 24 ins; 1 del; 8 mod 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer Reviewed-by: phh Backport-of: 6520843f86f638fe4d1e5b3358fab5799daca654 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2726 From duke at openjdk.org Fri Aug 30 15:38:28 2024 From: duke at openjdk.org (Todd V. Jonker) Date: Fri, 30 Aug 2024 15:38:28 GMT Subject: [jdk17u-dev] Integrated: 8319817: Charset constructor should make defensive copy of aliases In-Reply-To: <6cD_If-pKlvZDkDjOVIZciiV3ew1B8FY2SjVGDlwBzE=.c5966432-fe63-4b53-82d2-6452808331e6@github.com> References: <6cD_If-pKlvZDkDjOVIZciiV3ew1B8FY2SjVGDlwBzE=.c5966432-fe63-4b53-82d2-6452808331e6@github.com> Message-ID: On Mon, 15 Jul 2024 21:47:56 GMT, Todd V. Jonker wrote: > Clean backport. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] macosx-aarch64-server-release: `make test-tier1` > - [x] linux-x86_64-server-release: `JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all` > * These tests fail repeatedly, but also fail on `master`: > * `build/AbsPathsInImage.java` > * `jdk/internal/platform/docker/TestDockerMemoryMetrics.java` This pull request has now been integrated. Changeset: b2c92fd6 Author: Todd V. Jonker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/b2c92fd6d16caedba818aa5d4f94bba2f1b9efaf Stats: 76 lines in 2 files changed: 74 ins; 1 del; 1 mod 8319817: Charset constructor should make defensive copy of aliases Backport-of: d6d7bdc7748c10963c3e58c0287b2472646bf36f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2713 From rvansa at openjdk.org Fri Aug 30 15:39:25 2024 From: rvansa at openjdk.org (Radim Vansa) Date: Fri, 30 Aug 2024 15:39:25 GMT Subject: [jdk17u-dev] RFR: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 14:19:56 GMT, Goetz Lindenmaier wrote: >> Hi all, >> >> This pull request contains a backport of commit[ 02f79008](https://github.com/openjdk/jdk/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson. >> >> The backport is not clean; some method return types differ in later JDK versions. >> >> Thanks! > > There are GHA errors. @GoeLin Thanks, one failure was failure to fetch JTReg (infra problem), I am re-running the failed ClhsdbSource test since I find it difficult to relate to changes in this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2830#issuecomment-2321656452 From goetz at openjdk.org Fri Aug 30 15:48:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 30 Aug 2024 15:48:11 GMT Subject: [jdk21u] RFR: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Message-ID: A backport to jdk21u as this fixes a jck issue. I had to remove the namespace from LogConfiguration::StdoutLog as JDK-8299825 is not in 21. I also had to adapt TestVerboseClassLoading, as 'cause' is not known to the logging in 21. ------------- Commit messages: - Fix build and test - 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Changes: https://git.openjdk.org/jdk21u/pull/449/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=449&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338139 Stats: 204 lines in 6 files changed: 198 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk21u/pull/449.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/449/head:pull/449 PR: https://git.openjdk.org/jdk21u/pull/449 From abakhtin at openjdk.org Fri Aug 30 21:39:04 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 30 Aug 2024 21:39:04 GMT Subject: [jdk21u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases Message-ID: ? on older docker releases Please review the fix for regression on the old Docker versions (before v18.04). [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) was backported to JDK21, requiring statx syscall support. In the old Docker versions, the default seccomp profile does not allow statx syscall and fails with EPERM error code. Suggest fixing this issue by fallback to alternative implementation at runtime if syscall is not allowed. The same issue with copy_file_range syscall. The fix was initially submitted against upstream jdk ( https://github.com/openjdk/jdk/pull/20484 ) but after discussion submitted to JDK21 ------------- Commit messages: - 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases Changes: https://git.openjdk.org/jdk21u-dev/pull/951/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=951&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337966 Stats: 20 lines in 3 files changed: 10 ins; 6 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/951.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/951/head:pull/951 PR: https://git.openjdk.org/jdk21u-dev/pull/951