[jdk17u-dev] RFR: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared [v2]

[duke]

On Mon, 5 Aug 2024 10:21:19 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [408cec51](https://github.com/openjdk/jdk/commit/408cec516bb5fd82fb6dcddeee934ac0c5ecffaf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Stefan Johansson on 4 May 2023 and was reviewed by Coleen Phillimore and Serguei Spitsyn.
>> 
>> It's clean except for the surrounding context changing between NULL and nullptr which was trivial to resolve. It comes with its own test, but I also confirmed that it fixes the reproducer shared on the issue.
>> 
>> Edit: This now also backports 8307448/https://github.com/openjdk/jdk/commit/29233e0a001adde71a3fa5d56292ccfba8409ea5 to fix the flaky test. 8307448 applied cleanly.
>> 
>> Testing - looks good, just 3 unrelated tests failing on my machine.
>> 
>> 
>>  JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all
>> 
>>    TEST                                              TOTAL  PASS  FAIL ERROR
>>    jtreg:test/hotspot/jtreg:all                       6131  6131     0     0
>>>> jtreg:test/jdk:all                                 9140  9137     3     0 <<
>>    jtreg:test/langtools:all                           4251  4251     0     0
>>    jtreg:test/jaxp:all                                 467   467     0     0
>>    jtreg:test/lib-test:all                              30    30     0     0
>>    
>> build/AbsPathsInImage.java                                                                                         Failed. Execution failed: `main' threw exception: java.lang.Exception: Test failed
>> java/nio/channels/FileChannel/directio/DirectIOTest.java                                                           Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: DirectIO is not working properly with read. File still exists in cache!
>> jdk/internal/platform/docker/TestDockerMemoryMetrics.java                                                          Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Expected to get exit value of [0]
>> 
>> 
>> Thanks!
>
> Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 29233e0a001adde71a3fa5d56292ccfba8409ea5

@olivergillespie 
Your change (at version 9409b2f3111624ac1aec76658d1a065f0212a140) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2776#issuecomment-2270741887