[jdk21u-dev] RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

Aleksey Shipilev shade at openjdk.org
Tue Aug 13 08:19:54 UTC 2024


On Mon, 12 Aug 2024 21:14:16 GMT, Daniel Hu <duke at openjdk.org> wrote:

> Backport of improvements to DataDescriptorSignatureMissing test. Unclean for 2 minor reasons: updated copyright year and this [trivial issue fix in 22](https://github.com/openjdk/jdk/commit/34653c1e73452c0e07beb1f5e2eb8029fdb3befc) that adds a bug-id for `@ignore`. Otherwise, it's a clean backport.
> 
> Passes tier1 tests and the test itself on Linux x64

Good, except for:

test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 3:

> 1: /*
> 2:  * Copyright 2012 Google, Inc.  All Rights Reserved.
> 3:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.

Yeah, but the original hunk has `2023`. Leave it as-as, i.e. at `2023`:
https://github.com/openjdk/jdk/commit/07eaea8c25bae6ed852685f082f8b50c5b20c1a9#diff-20b351f8e90d650865fb32bf9208e9a8a0f77ad2deefd38dbbf062b0cc88fb5cR3

-------------

Changes requested by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/913#pullrequestreview-2234849095
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/913#discussion_r1714870119


More information about the jdk-updates-dev mailing list