[jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype

Martin Doerr mdoerr at openjdk.org
Wed Aug 14 20:58:55 UTC 2024


On Fri, 12 Jul 2024 07:49:44 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

> This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. 
> 
> The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. 
> 
> This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary.

LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2854#pullrequestreview-2239174900


More information about the jdk-updates-dev mailing list