[jdk21u-dev] RFR: 8310683: Refactor StandardCharset/standard.java to use JUnit

[Martin Doerr]

On Thu, 8 Aug 2024 20:20:42 GMT, Amos Shi <ashi at openjdk.org> wrote:

> Backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683)
> - This PR contains three commits
> - `commit 1` is the `clean` backport of `Standard.java` file from [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047), which is the dependency of current PR [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683)
> - `commit 2` is the `clean` backport of [JDK-8310683](https://bugs.openjdk.org/browse/JDK-8310683) original commit
> - `commit 3` is fixing the compile error of the test case, to remove the charsets added by [JDK-8310047](https://bugs.openjdk.org/browse/JDK-8310047) in Java 22
> 
> 
> /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:140: error: cannot find symbol
>                 Arguments.of(StandardCharsets.UTF_32BE, "UTF-32BE"),
>                                              ^
>   symbol:   variable UTF_32BE
>   location: class StandardCharsets
> /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:141: error: cannot find symbol
>                 Arguments.of(StandardCharsets.UTF_32LE, "UTF-32LE"),
>                                              ^
>   symbol:   variable UTF_32LE
>   location: class StandardCharsets
> /Users/I048686/SAPDevelop/github.com/dev-8310683-21/test/jdk/java/nio/charset/StandardCharsets/Standard.java:142: error: cannot find symbol
>                 Arguments.of(StandardCharsets.UTF_32, "UTF-32")
>                                              ^
>   symbol:   variable UTF_32
>   location: class StandardCharsets
> 
> 
> Testing
> - Local: Test passed on `MacOS 14.6.1` on Apple M1 Max
>   - `Standard.java`: Test results: passed: 1
> - Pipeline: All checks have passed
> - Testing Machine: SAP nightlies Passed on `2024-08-15`
>   - Automated jtreg test: `jtreg_jdk_tier2`, Started at `2024-08-15 04:34:01+01:00`
>   - java/nio/charset/StandardCharsets/Standard.java: SUCCESSFUL GitHub 📊 - [04:55:15.771 -> 1,774 msec]

LGTM. Thanks for explaining your integration steps.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/903#pullrequestreview-2242250980