[jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v3]

Amos Shi ashi at openjdk.org
Sat Aug 17 07:01:51 UTC 2024


On Fri, 16 Aug 2024 09:27:05 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amos Shi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix based on review: move 2 lines to correct location
>
> test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java line 612:
> 
>> 610: 
>> 611:     static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask,
>> 612:                                                   FTernMaskOp f) {
> 
> This empty line should not get removed.

Fixed.
It is indeed there are 2 empty lines at https://github.com/openjdk/jdk/blob/e6f23a90d4a53339a3c9c2b76fc5d317940e4472/test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java#L720-L721

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1720682505


More information about the jdk-updates-dev mailing list