[jdk17u-dev] RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v4]

Amos Shi ashi at openjdk.org
Sat Aug 17 07:11:08 UTC 2024


On Fri, 16 Aug 2024 09:37:32 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amos Shi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add file Unit-header.template
>
> test/jdk/jdk/incubator/vector/templates/Unit-header.template line 184:
> 
>> 182:             Assert.assertEquals(r[i], f.apply(a, i), Math.abs(r[i] * relativeError), "at index #" + i);
>> 183:         }
>> 184:      }
> 
> 1 space too much.

Fixed.
Extra space removed.

> test/jdk/jdk/incubator/vector/templates/Unit-header.template line 228:
> 
>> 226:             Assert.assertEquals(r[i], f.apply(a, i, mask), Math.abs(r[i] * relativeError), "at index #" + i);
>> 227:         }
>> 228:      }
> 
> 1 space too much.

Fixed. 
1 extra space removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1720686109
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2768#discussion_r1720688357


More information about the jdk-updates-dev mailing list