[jdk17u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM [v2]

Xiaolong Peng xpeng at openjdk.org
Mon Aug 19 15:29:29 UTC 2024


On Mon, 19 Aug 2024 15:19:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use thread->as_Java_thread() instead of static_cast
>
> src/hotspot/share/gc/shenandoah/shenandoahLock.cpp line 47:
> 
>> 45:   Thread* thread = Thread::current();
>> 46:   if (allow_block_for_safepoint && thread->is_Java_thread()) {
>> 47:     contended_lock_internal<ThreadBlockInVM>(static_cast<JavaThread*>(thread));
> 
> The preferred style in older JDKs is `thread->as_Java_thread()`.

Thanks, I have updated code to use thread->as_Java_thread() instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2797#discussion_r1721974050


More information about the jdk-updates-dev mailing list