[jdk21u-dev] RFR: 8321940: Improve CDSHeapVerifier in handling of interned strings

[Ben Taylor]

On Thu, 22 Aug 2024 11:39:42 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport of a change to fix a false-positive error condition in the cdsHeapVerifier. 
>> This change also reduces the number of manually curated `ADD_EXCL` entries in cdsHeapVerifier, improving long-term maintainability.
>> 
>> Change passes tier 1 tests locally on x86_64 linux.
>
> @benty-amzn This hasn't been in any released JDK version yet. Deferring to next 21 cycle. It would be good if you can clarify "improving long-term maintainability". What do you mean by that exactly?

@jerboaa The comment in `cdsHeapVerifier` reads

> // Unfortunately this needs to be manually maintained. If
>  // test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumTest.java fails,
> // you might need to fix the core library code, or fix the ADD_EXCL entries below.

I simply meant that this change reduces the number of manually-maintained entries in that file, which will reduce the amount of work required to keep that list up-to-date going forward.

Delaying one cycle so the code can be released in another version first makes sense.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/925#issuecomment-2305282980