[jdk21u-dev] RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
Thomas Stuefe
stuefe at openjdk.org
Mon Aug 26 09:14:09 UTC 2024
On Thu, 22 Aug 2024 12:27:44 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> This fixes the regression introduced by [JDK-8329665](https://bugs.openjdk.org/browse/JDK-8329665), which added `ResourceMark` in `frame::oops_interpreted_do`. This is not really correct, as closures we call with that method can do resource allocations. The patch avoids this problem by cleanly allocating on C heap.
>
> The mainline patch wants `has_valid_mask` infrastructure added as part of [JDK-8315954](https://bugs.openjdk.org/browse/JDK-8315954). That patch has implications for Graal, and have unresolved bug tail. Therefore, I just picked up relevant infra hunks here.
>
> Additional testing:
> - [x] Linux x86_64 server fastedebug, `all`
> - [x] Linux AArch64 server fastedebug, `all`
This looks good to me.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk21u-dev/pull/942#pullrequestreview-2260202755
More information about the jdk-updates-dev
mailing list