[jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype

[Martin Doerr]

On Wed, 14 Aug 2024 20:56:21 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. 
>> 
>> The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. 
>> 
>> This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary.
>
> LGTM.

> Hi @TheRealMDoerr . Thanks for the review. Would it be possible to rerun macos jobs? (I don't have permissions to do that ). Thanks!.

I can only rerun jobs in my own PRs. You should find a rerun button next to the failing test.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2854#issuecomment-2310149110