[jdk11u-dev] RFR: 8336292: [11u] awt_ImagingLib passes arguments to function without a prototype

[Antonio Vieiro]

On Fri, 12 Jul 2024 07:49:44 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

> This is a fix to [JDK-8336292](https://bugs.openjdk.org/browse/JDK-8336292): Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c. 
> 
> The fix adds disables the `deprecated-non-prototype` when building with clang, for the build to pass. 
> 
> This is a 11u only issue, as the make infrastructure was reorganized in [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) after OpenJDK 15, and enhanced afterwards. Backporting [JDK-8244044](https://bugs.openjdk.org/browse/JDK-8244044) is an important change that should be avoided unless strictly necessary.

@GoeLin You're asking why many tests fail on macos. Here's a short explanation:

- In [late june](https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/) github removed the `macos-11`  runners, so many jdk builds (21, 17, 11, 8) started hanging.
- The problem was required fixing [JDK-8318039 - GHA: Bump macOS and Xcode versions](https://bugs.openjdk.org/browse/JDK-8318039), i.e., bumping the macos github runners to `macos-13` / `XCode 14`.
-  This was resolved in [jdk-21](https://github.com/openjdk/jdk21u-dev/pull/254) and [jdk-17](https://github.com/openjdk/jdk17u-dev/commit/7144027dff495b623428bd9cd891c0ed912035a4)
- The backport of [JDK-8318039](https://bugs.openjdk.org/browse/JDK-8318039) for 11 is in now place (this PR builds fine with `macos-13` GHA runners), but requires this PR (_and the other nested PRs_/integration blockers) to be reviewed.

Hope this clarifies,
Antonio

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2854#issuecomment-2312217026