[jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v2]

[Goetz Lindenmaier]

On Mon, 13 May 2024 09:39:44 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi,
>>  This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport 
>> [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 )
>> 
>> Only change the testcase, the change has been verify on below binary:
>> 
>> - [x]  linux x64 release
>> - [x]  linux x64 fastdebug
>> - [x]  linux x86 release
>> - [x]  linux x86 fastdebug
>> [linux-x64-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142005/linux-x64-fastdebug.log)
>> [linux-x64-release.log](https://github.com/openjdk/jdk17u-dev/files/15142006/linux-x64-release.log)
>> [linux-x86-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142007/linux-x86-fastdebug.log)
>> [linux-x86-release.log](https://github.com/openjdk/jdk17u-dev/files/15142009/linux-x86-release.log)
>> 
>> It's not clean backport:
>> 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20
>> 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev
>> 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023`  in jdk17u-dev
>> 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs8290023
>  - Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2
>    
>    Signed-off-by: sendaoYan <yansendao.ysd at alibaba-inc.com>

Hi Sendao, 
please only label for approval if you have a review.
I will only approve reviewed changes, but there is no way I can filter for this.
So I revisit changes labeled for approval but not reviewed every time I do approvals, badly wasting my time.
I will remove the fix-request labels next time I visit changes not reviewed. You can label again once a review is there.
Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2438#issuecomment-2317661873