From goetz at openjdk.org Mon Dec 2 08:10:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 08:10:39 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v2] In-Reply-To: References: Message-ID: > Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) > > The patch is based on the commit to 23, the version for 22/22.0.1 is identical. > > I can reproduce the error with the test, and the patch fixes the issue. > > I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. > jdk.jfr has no main, so I exclude it from the tests. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Remove jdk.jfr from net.foo module-info ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1189/files - new: https://git.openjdk.org/jdk21u-dev/pull/1189/files/b514ecc4..28d42dc0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1189&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1189&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1189.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1189/head:pull/1189 PR: https://git.openjdk.org/jdk21u-dev/pull/1189 From goetz at openjdk.org Mon Dec 2 08:10:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 08:10:40 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v2] In-Reply-To: References: Message-ID: <8FDDzsMPvcu-4C_uGXaDf-cfQG4uwWYFt3WA8si3040=.ed0f4194-bbe6-4ecf-ba75-6d4b3c7f97ad@github.com> On Fri, 29 Nov 2024 10:25:25 GMT, Severin Gehwolf wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove jdk.jfr from net.foo module-info > > test/jdk/tools/jlink/plugins/SystemModuleDescriptors/src/net.foo/module-info.java line 25: > >> 23: >> 24: module net.foo { >> 25: requires jdk.jfr; > > Not needed if there is no main class in that module. Hi @jerboaa, thanks for looking at this change. I updated the module info. The test still passes. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1189#discussion_r1865396701 From goetz at openjdk.org Mon Dec 2 09:07:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 09:07:25 GMT Subject: [jdk17u-dev] RFR: 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true' Message-ID: I would like to backport this small bugfix. I had to resolve because "8284112: Minor cleanup could be done in javax.crypto" is not in 17. Therefore the template parameters of the patched code differ: this change: processedPermissions = new Hashtable<>(); jdk17: processedPermissions = new Hashtable>(); Test passes. ------------- Commit messages: - Backport 8f400b9aab57d0639721add2ba511bfc0459bd89 Changes: https://git.openjdk.org/jdk17u-dev/pull/3080/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3080&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286779 Stats: 104 lines in 2 files changed: 97 ins; 4 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3080.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3080/head:pull/3080 PR: https://git.openjdk.org/jdk17u-dev/pull/3080 From goetz at openjdk.org Mon Dec 2 09:15:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 09:15:38 GMT Subject: [jdk21u-dev] RFR: 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% In-Reply-To: References: Message-ID: On Fri, 29 Nov 2024 18:11:30 GMT, Dmitry Cherepanov wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8343285 > > Tested with LibreOffice - hangs without the fix and works with the fix Please integrate by Tue Dec 3rd to make the January update. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1190#issuecomment-2510969717 From goetz at openjdk.org Mon Dec 2 09:15:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 09:15:46 GMT Subject: [jdk17u-dev] RFR: 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% In-Reply-To: <90mo2KekX6zwcKUcxN6WXX43Sph-quOCCIFpTE9EGJo=.fdbae526-4a12-4e2d-bdf1-b1f09c5ff66d@github.com> References: <90mo2KekX6zwcKUcxN6WXX43Sph-quOCCIFpTE9EGJo=.fdbae526-4a12-4e2d-bdf1-b1f09c5ff66d@github.com> Message-ID: On Fri, 29 Nov 2024 18:20:59 GMT, Dmitry Cherepanov wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8343285 > > Tested with LibreOffice - it hangs without the fix and works with the fix Please integrate by Tue Dec 3rd to make the January update. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3079#issuecomment-2510970076 From sgehwolf at openjdk.org Mon Dec 2 09:19:46 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 2 Dec 2024 09:19:46 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v2] In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 08:10:39 GMT, Goetz Lindenmaier wrote: >> Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) >> >> The patch is based on the commit to 23, the version for 22/22.0.1 is identical. >> >> I can reproduce the error with the test, and the patch fixes the issue. >> >> I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. >> jdk.jfr has no main, so I exclude it from the tests. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove jdk.jfr from net.foo module-info Please remove the commented out modules as well. Good otherwise. test/jdk/tools/jlink/plugins/SystemModuleDescriptors/src/com.foo/com/foo/Main.java line 41: > 39: checkMainClass("com.foo", "com.foo.Main"); > 40: checkMainClass("net.foo", "net.foo.Main"); > 41: Stream.of("jdk.httpserver"/*, "jdk.jfr"*/).forEach(mn -> Suggestion: Stream.of("jdk.httpserver").forEach(mn -> test/jdk/tools/jlink/plugins/SystemModuleDescriptors/src/net.foo/net/foo/Main.java line 41: > 39: checkMainClass("com.foo", "com.foo.Main"); > 40: checkMainClass("net.foo", "net.foo.Main"); > 41: Stream.of("jdk.httpserver"/*, "jdk.jfr"*/).forEach(mn -> Suggestion: Stream.of("jdk.httpserver").forEach(mn -> ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1189#pullrequestreview-2472143512 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1189#discussion_r1865491404 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1189#discussion_r1865493100 From goetz at openjdk.org Mon Dec 2 09:32:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 09:32:12 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v3] In-Reply-To: References: Message-ID: > Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) > > The patch is based on the commit to 23, the version for 22/22.0.1 is identical. > > I can reproduce the error with the test, and the patch fixes the issue. > > I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. > jdk.jfr has no main, so I exclude it from the tests. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Remove commented module name ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1189/files - new: https://git.openjdk.org/jdk21u-dev/pull/1189/files/28d42dc0..d2659792 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1189&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1189&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1189.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1189/head:pull/1189 PR: https://git.openjdk.org/jdk21u-dev/pull/1189 From goetz at openjdk.org Mon Dec 2 09:32:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 09:32:12 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v2] In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 09:16:38 GMT, Severin Gehwolf wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove jdk.jfr from net.foo module-info > > test/jdk/tools/jlink/plugins/SystemModuleDescriptors/src/net.foo/net/foo/Main.java line 41: > >> 39: checkMainClass("com.foo", "com.foo.Main"); >> 40: checkMainClass("net.foo", "net.foo.Main"); >> 41: Stream.of("jdk.httpserver"/*, "jdk.jfr"*/).forEach(mn -> > > Suggestion: > > Stream.of("jdk.httpserver").forEach(mn -> Good point, so done. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1189#discussion_r1865512808 From sgehwolf at openjdk.org Mon Dec 2 09:45:48 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 2 Dec 2024 09:45:48 GMT Subject: [jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v3] In-Reply-To: References: Message-ID: <0XR-alEap-8Jms7xOOcdtHQMJbqqarWxRCmp3wWyp74=.02d945e4-3ed8-41ce-8226-1de999e42e21@github.com> On Mon, 2 Dec 2024 09:32:12 GMT, Goetz Lindenmaier wrote: >> Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) >> >> The patch is based on the commit to 23, the version for 22/22.0.1 is identical. >> >> I can reproduce the error with the test, and the patch fixes the issue. >> >> I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. >> jdk.jfr has no main, so I exclude it from the tests. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove commented module name Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1189#pullrequestreview-2472207172 From duke at openjdk.org Mon Dec 2 09:49:08 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Mon, 2 Dec 2024 09:49:08 GMT Subject: [jdk17u-dev] RFR: 8331863: DUIterator_Fast used before it is constructed [v2] In-Reply-To: References: Message-ID: > Backport of JDK-8331863 from 21u. > > Clean backport. Passed tier1 tests. Radek ??p has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3070/files - new: https://git.openjdk.org/jdk17u-dev/pull/3070/files/ed30b9c1..21829938 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3070&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3070&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3070.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3070/head:pull/3070 PR: https://git.openjdk.org/jdk17u-dev/pull/3070 From dcherepanov at openjdk.org Mon Dec 2 09:52:48 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 2 Dec 2024 09:52:48 GMT Subject: [jdk21u-dev] Integrated: 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% In-Reply-To: References: Message-ID: On Fri, 29 Nov 2024 18:11:30 GMT, Dmitry Cherepanov wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8343285 > > Tested with LibreOffice - hangs without the fix and works with the fix This pull request has now been integrated. Changeset: 92aa77c5 Author: Dmitry Cherepanov URL: https://git.openjdk.org/jdk21u-dev/commit/92aa77c5e8179633f8e9062ea2795842e8bdb365 Stats: 7 lines in 1 file changed: 0 ins; 1 del; 6 mod 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% Backport-of: c00e20c399cf9b3b21258bd5654a92d703c8fcd2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1190 From dcherepanov at openjdk.org Mon Dec 2 09:53:54 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 2 Dec 2024 09:53:54 GMT Subject: [jdk17u-dev] Integrated: 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% In-Reply-To: <90mo2KekX6zwcKUcxN6WXX43Sph-quOCCIFpTE9EGJo=.fdbae526-4a12-4e2d-bdf1-b1f09c5ff66d@github.com> References: <90mo2KekX6zwcKUcxN6WXX43Sph-quOCCIFpTE9EGJo=.fdbae526-4a12-4e2d-bdf1-b1f09c5ff66d@github.com> Message-ID: On Fri, 29 Nov 2024 18:20:59 GMT, Dmitry Cherepanov wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8343285 > > Tested with LibreOffice - it hangs without the fix and works with the fix This pull request has now been integrated. Changeset: c3ee57ce Author: Dmitry Cherepanov URL: https://git.openjdk.org/jdk17u-dev/commit/c3ee57ce2f98a4ec12e5b1de091d797fcb3f839d Stats: 7 lines in 1 file changed: 0 ins; 1 del; 6 mod 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100% Backport-of: c00e20c399cf9b3b21258bd5654a92d703c8fcd2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3079 From adinn at redhat.com Mon Dec 2 10:34:10 2024 From: adinn at redhat.com (Andrew Dinn) Date: Mon, 2 Dec 2024 10:34:10 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: References: Message-ID: <9ebbc7d6-e52c-4b52-b717-27f4b16c41a7@redhat.com> Vote: yes On 27/11/2024 15:17, Doerr, Martin wrote: > Hi, > > I hereby nominate Amit Kumar [1] for the role of JDK Updates Project > Committer. > > Amit works for IBM, is a JDK Committer and has taken responsibility for > the s390 port. He?s contributing to the jdk-updates projects focusing on > s390 [5]. > > Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. > > Only current JDK-Updates Committers [3] are eligible to vote on this > nomination.?Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > > Martin > > [1] https://openjdk.org/census#amitkumar > > [2] https://github.com/openjdk/jdk/commits?author=offamitkumar > > [3] https://openjdk.org/census > > [4] https://openjdk.java.net/projects/#committer-vote > > [5]?backports: > > jdk22u (2) : https://github.com/openjdk/jdk22u/pulls? > q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls? > q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk21u (3) : https://github.com/openjdk/jdk21u/pulls? > q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls? > q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls? > q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls? > q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > -- regards, Andrew Dinn ----------- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill From goetz at openjdk.org Mon Dec 2 10:38:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 10:38:10 GMT Subject: [jdk17u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v2] In-Reply-To: References: Message-ID: > This is a backport of the 21 PR code, but it needs further adaptions. > > SystemModulesPlugin.java had to be resolved. The code to be patched does the > same, but uses different Java syntax. > > Also, I had to remove one more case from the test as jdk.httpserver has no main > specified. This was added in [8245095: Implementation of JEP 408: Simple Web Server](https://bugs.openjdk.org/browse/JDK-8245095). > But the test still shows the same failure as in head when the fix misses > in the JVM, and passes if the fix is present. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Cleanups as in 21 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3078/files - new: https://git.openjdk.org/jdk17u-dev/pull/3078/files/9538a185..0fe2ccb5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3078&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3078&range=00-01 Stats: 14 lines in 4 files changed: 0 ins; 14 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3078.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3078/head:pull/3078 PR: https://git.openjdk.org/jdk17u-dev/pull/3078 From goetz at openjdk.org Mon Dec 2 10:38:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 10:38:10 GMT Subject: [jdk17u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order In-Reply-To: References: Message-ID: On Fri, 29 Nov 2024 08:22:00 GMT, Goetz Lindenmaier wrote: > This is a backport of the 21 PR code, but it needs further adaptions. > > SystemModulesPlugin.java had to be resolved. The code to be patched does the > same, but uses different Java syntax. > > Also, I had to remove one more case from the test as jdk.httpserver has no main > specified. This was added in [8245095: Implementation of JEP 408: Simple Web Server](https://bugs.openjdk.org/browse/JDK-8245095). > But the test still shows the same failure as in head when the fix misses > in the JVM, and passes if the fix is present. In the second commit, I removed the modules not suitable for this test as I did in 21. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3078#issuecomment-2511161070 From goetz at openjdk.org Mon Dec 2 11:27:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 11:27:12 GMT Subject: [jdk17u-dev] RFR: 8339892: Several security shell tests don't set TESTJAVAOPTS Message-ID: <1T4prBfi_bezOw3RWxfhUreW08EjyhHA6GRYCvB2SRI=.1e138f03-689c-4590-9d8f-bbe92ffee34e@github.com> I backport this for parity with 17.0.14-oracle. Resolved one Copyright, probably clean. ------------- Commit messages: - Backport 8a2a75e56de4497da48f43b3be3eb71bf3ef75ab Changes: https://git.openjdk.org/jdk17u-dev/pull/3081/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3081&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339892 Stats: 22 lines in 10 files changed: 0 ins; 0 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3081.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3081/head:pull/3081 PR: https://git.openjdk.org/jdk17u-dev/pull/3081 From goetz at openjdk.org Mon Dec 2 12:28:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 12:28:12 GMT Subject: [jdk17u-dev] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport fef70d78baec9ce11d50b9a4c1fb26a1b854ccbf Changes: https://git.openjdk.org/jdk17u-dev/pull/3082/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3082&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299077 Stats: 228 lines in 4 files changed: 68 ins; 76 del; 84 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3082.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3082/head:pull/3082 PR: https://git.openjdk.org/jdk17u-dev/pull/3082 From goetz at openjdk.org Mon Dec 2 12:38:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 12:38:22 GMT Subject: [jdk17u-dev] RFR: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 04f30185e914c10c918d0eff1fb63fd96e1139fb Changes: https://git.openjdk.org/jdk17u-dev/pull/3083/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3083&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299739 Stats: 18 lines in 2 files changed: 9 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3083.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3083/head:pull/3083 PR: https://git.openjdk.org/jdk17u-dev/pull/3083 From goetz at openjdk.org Mon Dec 2 13:15:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 13:15:05 GMT Subject: [jdk17u-dev] RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM Message-ID: I backport this for parity with 17.0.15-oracle. I had to resolve the makefile. Also, I had to resolve jni.cpp because of nullptr in the context. I include follow-up JDK-8309171, this applies after adding the problemlisting JDK-8309231. ------------- Commit messages: - Backport 8309171 - Backport 1e6770fb978e630b38a70a05120c50f723bb66dc Changes: https://git.openjdk.org/jdk17u-dev/pull/3084/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3084&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308341 Stats: 176 lines in 4 files changed: 161 ins; 2 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3084.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3084/head:pull/3084 PR: https://git.openjdk.org/jdk17u-dev/pull/3084 From thomas.stuefe at gmail.com Mon Dec 2 13:43:53 2024 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Mon, 2 Dec 2024 14:43:53 +0100 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: References: Message-ID: Vote: yes On Wed, Nov 27, 2024 at 4:18?PM Doerr, Martin wrote: > Hi, > > > > I hereby nominate Amit Kumar [1] for the role of JDK Updates Project > Committer. > > Amit works for IBM, is a JDK Committer and has taken responsibility for > the s390 port. He?s contributing to the jdk-updates projects focusing on > s390 [5]. > > Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. > > > > Only current JDK-Updates Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing list. > > > > For Lazy Consensus voting instructions, see [4]. > > > > Best regards, > > Martin > > > > [1] https://openjdk.org/census#amitkumar > > [2] https://github.com/openjdk/jdk/commits?author=offamitkumar > > [3] https://openjdk.org/census > > [4] https://openjdk.java.net/projects/#committer-vote > > [5] backports: > > jdk22u (2) : > https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk23u (4 + 4 open): > https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk21u (3) : > https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk21u-dev (10 + 2 open): > https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk17u-dev (6) : > https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > jdk11u-dev (1) : > https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Mon Dec 2 13:49:48 2024 From: duke at openjdk.org (duke) Date: Mon, 2 Dec 2024 13:49:48 GMT Subject: [jdk17u-dev] RFR: 8331863: DUIterator_Fast used before it is constructed [v2] In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 09:49:08 GMT, Radek ??p wrote: >> Backport of JDK-8331863 from 21u. >> >> Clean backport. Passed tier1 tests. > > Radek ??p has updated the pull request incrementally with one additional commit since the last revision: > > Update full name @RadekCap Your change (at version 21829938bb9aa64e06e4cd8308a70449a9bc9389) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3070#issuecomment-2511588523 From duke at openjdk.org Mon Dec 2 14:25:47 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Mon, 2 Dec 2024 14:25:47 GMT Subject: [jdk17u-dev] Integrated: 8331863: DUIterator_Fast used before it is constructed In-Reply-To: References: Message-ID: On Thu, 21 Nov 2024 17:04:05 GMT, Radek ??p wrote: > Backport of JDK-8331863 from 21u. > > Clean backport. Passed tier1 tests. This pull request has now been integrated. Changeset: 20927ac8 Author: RadekCap Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/20927ac8405b4adca463e4c691ea573abdac1c4f Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod 8331863: DUIterator_Fast used before it is constructed Backport-of: d13f75c9ef000b05442f9f468b2f45df9a8450cf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3070 From duke at openjdk.org Mon Dec 2 14:59:09 2024 From: duke at openjdk.org (Radek =?UTF-8?B?xIzDoXA=?=) Date: Mon, 2 Dec 2024 14:59:09 GMT Subject: [jdk11u-dev] RFR: 8331863: DUIterator_Fast used before it is constructed Message-ID: Backport of JDK-8331863 from 17u-dev. Clean backport. Passed tier1 tests. Passed gtests. ------------- Commit messages: - Backport ed30b9c1452042ed94fc7aa5a18e2a647788e2ae Changes: https://git.openjdk.org/jdk11u-dev/pull/2973/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2973&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331863 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2973.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2973/head:pull/2973 PR: https://git.openjdk.org/jdk11u-dev/pull/2973 From syan at openjdk.org Mon Dec 2 15:13:49 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 2 Dec 2024 15:13:49 GMT Subject: [jdk21u-dev] RFR: 8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails In-Reply-To: References: Message-ID: On Wed, 27 Nov 2024 09:08:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [3a625f38](https://github.com/openjdk/jdk/commit/3a625f38aa4ab611fe5c7dffe420abce826d0d7e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Doug Simon on 26 Nov 2024 and was reviewed by SendaoYan, Dean Long and Hamlin Li. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1185#issuecomment-2511799726 From syan at openjdk.org Mon Dec 2 15:13:49 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 2 Dec 2024 15:13:49 GMT Subject: [jdk21u-dev] Integrated: 8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails In-Reply-To: References: Message-ID: On Wed, 27 Nov 2024 09:08:19 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [3a625f38](https://github.com/openjdk/jdk/commit/3a625f38aa4ab611fe5c7dffe420abce826d0d7e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Doug Simon on 26 Nov 2024 and was reviewed by SendaoYan, Dean Long and Hamlin Li. > > Thanks! This pull request has now been integrated. Changeset: e5699972 Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/e5699972a4f202605a09e5d9612caf531bc6c292 Stats: 19 lines in 1 file changed: 13 ins; 0 del; 6 mod 8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails Backport-of: 3a625f38aa4ab611fe5c7dffe420abce826d0d7e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1185 From duke at openjdk.org Mon Dec 2 15:25:46 2024 From: duke at openjdk.org (Ryan Flegel) Date: Mon, 2 Dec 2024 15:25:46 GMT Subject: [jdk21u-dev] RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v3] In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 14:28:29 GMT, Ryan Flegel wrote: >> I am backporting this fix because I am being affected by [JDK-8335181](https://bugs.openjdk.org/browse/JDK-8335181). I had to downgrade to HTTP/1.1 in order to use `HttpClient`. >> >> I needed to resolve two minor conflicts in `MultiExchange.java` due to [JDK-8191494](https://bugs.openjdk.org/browse/JDK-8191494) being applied slightly differently in different projects. In both cases, I kept the change closer to upstream. >> >> The conflicts were: >> * Explicit vs implicit null field initialization >> * Different debug log message >> >> ### Tests >> >> All tests in the GitHub actions have passed. >> >> I have run the `jdk/java/net` tests locally and there were several failures, including 4 within `java/net/httpclient`. However, I have confirmed that all the failed tests also fail before applying the patch, so they seem to be unrelated. >> >> Here is a full list of the failures: >> >> * java/net/DatagramSocket/B6411513.java: java.net.DatagramSocket.receive: packet isn't received >> * java/net/DatagramSocket/SendReceiveMaxSize.java: This test verifies that on macOS, the send buffer size is configured by default so that none of our implementations of the UDP protocol will fail with a "packet too large" exception when trying to send a packet of the maximum possible size allowed by the protocol. >> * java/net/httpclient/ConnectTimeoutNoProxyAsync.java: Tests for connection related timeouts >> * java/net/httpclient/ConnectTimeoutNoProxySync.java: Tests for connection related timeouts >> * java/net/httpclient/ConnectTimeoutWithProxyAsync.java: Tests for connection related timeouts >> * java/net/httpclient/ConnectTimeoutWithProxySync.java: Tests for connection related timeouts >> >> UPDATE: I've run the rest of the tier2 tests and there were two additional JDK failures that appear to be unrelated: >> >> * com/sun/jndi/dns/ConfigTests/Timeout.java: Tests that we can set the initial UDP timeout interval and the number of retries. >> * com/sun/jndi/ldap/LdapPoolTimeoutTest.java: Multi-threaded client timeout tests for ldap pool > > Ryan Flegel has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'master' of https://git.openjdk.org/jdk21u-dev into backport-720b44648b > - Merge remote-tracking branch 'origin/master' into backport-720b44648b > - Backport 720b44648bcff997278af92746f942b2425298a5 Hi - just wondering if there's any chance of this being backported? As someone affected by [JDK-8335181](https://bugs.openjdk.org/browse/JDK-8335181), I was hoping to see this fixed. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1020#issuecomment-2511830802 From goetz at openjdk.org Mon Dec 2 15:55:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 2 Dec 2024 15:55:52 GMT Subject: [jdk21u-dev] Integrated: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order In-Reply-To: References: Message-ID: On Thu, 28 Nov 2024 10:52:17 GMT, Goetz Lindenmaier wrote: > Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile) > > The patch is based on the commit to 23, the version for 22/22.0.1 is identical. > > I can reproduce the error with the test, and the patch fixes the issue. > > I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21. > jdk.jfr has no main, so I exclude it from the tests. This pull request has now been integrated. Changeset: d383ba54 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d383ba546ca749d21ad39288e47335135e7b2142 Stats: 289 lines in 6 files changed: 282 ins; 0 del; 7 mod 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order Reviewed-by: sgehwolf, mbaesken Backport-of: f3be138eb80c9e7f6cc21afb75cda9e49b667c8a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1189 From hohensee at amazon.com Mon Dec 2 16:09:00 2024 From: hohensee at amazon.com (Hohensee, Paul) Date: Mon, 2 Dec 2024 16:09:00 +0000 Subject: CFV: New JDK Updates Committer - Amit Kumar Message-ID: <31ED5014-2EEA-42A7-B56F-9CEBDA9A4C90@amazon.com> Vote: yes From: jdk-updates-dev on behalf of "Doerr, Martin" Date: Wednesday, November 27, 2024 at 7:18?AM To: "jdk-updates-dev at openjdk.org" Subject: CFV: New JDK Updates Committer - Amit Kumar Hi, I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk-updates projects focusing on s390 [5]. Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. Only current JDK-Updates Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Martin [1] https://openjdk.org/census#amitkumar [2] https://github.com/openjdk/jdk/commits?author=offamitkumar [3] https://openjdk.org/census [4] https://openjdk.java.net/projects/#committer-vote [5] backports: jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed -------------- next part -------------- An HTML attachment was scrubbed... URL: From vladimir.kozlov at oracle.com Mon Dec 2 17:32:40 2024 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Mon, 2 Dec 2024 09:32:40 -0800 Subject: CFV: New JDK Updates Committer - Amit Kumar In-Reply-To: References: Message-ID: <248dc1da-b74c-481c-8d23-e56ec5ab370d@oracle.com> Vote: yes Thanks, Vladimir K On 11/27/24 7:17 AM, Doerr, Martin wrote: > Hi, > > I hereby nominate Amit Kumar [1] for the role of JDK Updates Project Committer. > > Amit works for IBM, is a JDK Committer and has taken responsibility for the s390 port. He?s contributing to the jdk- > updates projects focusing on s390 [5]. > > Votes are due by Thursday, 12 Dec 2024 at 09:00 UTC. > > Only current JDK-Updates Committers [3] are eligible to vote on this nomination.?Votes must be cast in the open by > replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > > Martin > > [1] https://openjdk.org/census#amitkumar > > [2] https://github.com/openjdk/jdk/commits?author=offamitkumar > > [3] https://openjdk.org/census > > [4] https://openjdk.java.net/projects/#committer-vote > > [5]?backports: > > jdk22u (2) : https://github.com/openjdk/jdk22u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk23u (4 + 4 open): https://github.com/openjdk/jdk23u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk21u (3) : https://github.com/openjdk/jdk21u/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk21u-dev (10 + 2 open): https://github.com/openjdk/jdk21u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk17u-dev (6) : https://github.com/openjdk/jdk17u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > > jdk11u-dev (1) : https://github.com/openjdk/jdk11u-dev/pulls?q=is%3Apr+author%3Aoffamitkumar+is%3Aclosed > From phh at openjdk.org Mon Dec 2 21:01:02 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 2 Dec 2024 21:01:02 GMT Subject: [jdk17u-dev] RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 13:08:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I had to resolve the makefile. > Also, I had to resolve jni.cpp because of nullptr in the context. > > I include follow-up JDK-8309171, this applies after adding the problemlisting JDK-8309231. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3084#pullrequestreview-2473903029 From mbalao at openjdk.org Mon Dec 2 21:34:50 2024 From: mbalao at openjdk.org (Martin Balao) Date: Mon, 2 Dec 2024 21:34:50 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21 In-Reply-To: References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: On Wed, 27 Nov 2024 19:45:30 GMT, Severin Gehwolf wrote: >> Hi, >> >> In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. >> >> Thanks, >> Martin.- > > @martinuy Please submit a dependent PR for 8328366 so that we can approve them both. Thanks. @jerboaa May I have an approval for this PR now that @franferrax proposed the follow up fix as a dependent PR? (see https://github.com/openjdk/jdk21u-dev/pull/1192) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#issuecomment-2512943480 From fferrari at openjdk.org Mon Dec 2 22:01:08 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Mon, 2 Dec 2024 22:01:08 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux Message-ID: Hi, I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. The backport is not clean, for the following reasons: * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 This pull request depends on @martinuy's #1181. #### Testing As part of our testing, we observed all the tests pass in the following categories: * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) * `jdk/java/util/concurrent/forkjoin` * `jdk/java/util/concurrent/tck` Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1181 Commit messages: - Backport 872ae1347198408ffd62559ca8c1a7420c4a8108 Changes: https://git.openjdk.org/jdk21u-dev/pull/1192/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1192&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342905 Stats: 18 lines in 3 files changed: 15 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1192.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1192/head:pull/1192 PR: https://git.openjdk.org/jdk21u-dev/pull/1192 From mbalao at openjdk.org Mon Dec 2 22:01:08 2024 From: mbalao at openjdk.org (Martin Balao) Date: Mon, 2 Dec 2024 22:01:08 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 20:20:54 GMT, Francisco Ferrari Bihurriet wrote: > Hi, > > I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. > > The backport is not clean, for the following reasons: > > * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) > * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) > * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method > * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 > > This pull request depends on @martinuy's #1181. > > #### Testing > > As part of our testing, we observed all the tests pass in the following categories: > > * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) > * `jdk/java/util/concurrent/forkjoin` > * `jdk/java/util/concurrent/tck` > > Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. The proposed backport looks good to me. I agree with not considering JDK-8296244 a dependency. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1192#pullrequestreview-2474001184 From mbalao at openjdk.org Mon Dec 2 22:17:44 2024 From: mbalao at openjdk.org (Martin Balao) Date: Mon, 2 Dec 2024 22:17:44 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 20:20:54 GMT, Francisco Ferrari Bihurriet wrote: > Hi, > > I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. > > The backport is not clean, for the following reasons: > > * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) > * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) > * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method > * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 > > This pull request depends on @martinuy's #1181. > > #### Testing > > As part of our testing, we observed all the tests pass in the following categories: > > * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) > * `jdk/java/util/concurrent/forkjoin` > * `jdk/java/util/concurrent/tck` > > Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. Sending the approval again, after being moved out of Draft for the Skara bot to get it. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1192#pullrequestreview-2474053171 From srl at openjdk.org Mon Dec 2 22:25:55 2024 From: srl at openjdk.org (Steven Loomis) Date: Mon, 2 Dec 2024 22:25:55 GMT Subject: [jdk11u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v3] In-Reply-To: <-vkps507KhQ9HKpJ3Sw26fY_qopj7e8TbZruHr4R7u0=.ac422fce-bd04-4a76-a4d1-5d94f5f21361@github.com> References: <3j_Tqw92GYtmWFYtRJkbplIF1_KiA4VXBe9lt1dMvTc=.5f342d4c-074a-4b56-bb3d-8c93fc5a47d7@github.com> <-vkps507KhQ9HKpJ3Sw26fY_qopj7e8TbZruHr4R7u0=.ac422fce-bd04-4a76-a4d1-5d94f5f21361@github.com> Message-ID: On Mon, 4 Nov 2024 16:29:27 GMT, Steven Loomis wrote: >> @srl295 Could not automatically backport b8f2ec90 to openjdk/jdk11u-dev due to conflicts in the following files: >> >> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m >> Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know. >> >> # Fetch the up-to-date version of the target branch >> $ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master >> >> # Check out the target branch and create your own branch to backport >> $ git checkout master >> $ git checkout -b backport-srl295-b8f2ec90-master >> >> # Fetch the commit you want to backport >> $ git fetch --no-tags https://git.openjdk.org/jdk.git b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd >> >> # Backport the commit >> $ git cherry-pick --no-commit b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd >> # Resolve conflicts now >> >> # Commit the files you have modified >> $ git add files/with/resolved/conflicts >> $ git commit -m 'Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd' >> Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd. >> >> Below you can find a suggestion for the pull request body: >> >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> >> PR: https://github.com/openjdk/jdk/pull/17921 >> >> Thanks! > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - 8195675: merge from master > - 8195675: empty commit to trigger build > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd Any update on triage? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2954#issuecomment-2513080824 From abakhtin at openjdk.org Tue Dec 3 00:38:43 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 3 Dec 2024 00:38:43 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: References: <1UUqQN-7Z73RTII7FWXHU6iNA9QEIHEdh42lEewXD3s=.cde8dd2b-6c02-4490-981c-9dd4f2c1c622@github.com> Message-ID: On Thu, 14 Nov 2024 18:53:15 GMT, Alexey Bakhtin wrote: >>> java.nio.file.FileSystemException: app.jar: Function not implemented >> >> This looks like a different issue. > >> java.nio.file.FileSystemException: app.jar: Function not implemented > > @akhilesh-delphix, It looks like a similar issue, but the state syscall returns `ENOSYS` error code instead of `EPERM`. So, this PR does not fix your issue. > Could you please describe your environment? Maybe we will need a follow-up to handle `ENOSYS` as well. > hi @alexeybakhtin, > > Pls let me know if you need further details on this. > > Additionally , is it possible for you confirm that the issue faced by me (`java.nio.file.FileSystemException: app.jar: Function not implemented`) is a JDK issue (possibly regression of https://bugs.openjdk.org/browse/JDK-8316304). It will help us communicate with our stakeholders Yes, As soon as I can see, it is a regression of JDK-8316304. There is a possible workaround for docker containers: add statx to the seccomp filter and run the docker container with update seccomp filter `--security-opt seccomp=` ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2883#issuecomment-2513276731 From jpai at openjdk.org Tue Dec 3 06:26:48 2024 From: jpai at openjdk.org (Jaikiran Pai) Date: Tue, 3 Dec 2024 06:26:48 GMT Subject: [jdk21u-dev] RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v3] In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 14:28:29 GMT, Ryan Flegel wrote: >> I am backporting this fix because I am being affected by [JDK-8335181](https://bugs.openjdk.org/browse/JDK-8335181). I had to downgrade to HTTP/1.1 in order to use `HttpClient`. >> >> I needed to resolve two minor conflicts in `MultiExchange.java` due to [JDK-8191494](https://bugs.openjdk.org/browse/JDK-8191494) being applied slightly differently in different projects. In both cases, I kept the change closer to upstream. >> >> The conflicts were: >> * Explicit vs implicit null field initialization >> * Different debug log message >> >> ### Tests >> >> All tests in the GitHub actions have passed. >> >> I have run the `jdk/java/net` tests locally and there were several failures, including 4 within `java/net/httpclient`. However, I have confirmed that all the failed tests also fail before applying the patch, so they seem to be unrelated. >> >> Here is a full list of the failures: >> >> * java/net/DatagramSocket/B6411513.java: java.net.DatagramSocket.receive: packet isn't received >> * java/net/DatagramSocket/SendReceiveMaxSize.java: This test verifies that on macOS, the send buffer size is configured by default so that none of our implementations of the UDP protocol will fail with a "packet too large" exception when trying to send a packet of the maximum possible size allowed by the protocol. >> * java/net/httpclient/ConnectTimeoutNoProxyAsync.java: Tests for connection related timeouts >> * java/net/httpclient/ConnectTimeoutNoProxySync.java: Tests for connection related timeouts >> * java/net/httpclient/ConnectTimeoutWithProxyAsync.java: Tests for connection related timeouts >> * java/net/httpclient/ConnectTimeoutWithProxySync.java: Tests for connection related timeouts >> >> UPDATE: I've run the rest of the tier2 tests and there were two additional JDK failures that appear to be unrelated: >> >> * com/sun/jndi/dns/ConfigTests/Timeout.java: Tests that we can set the initial UDP timeout interval and the number of retries. >> * com/sun/jndi/ldap/LdapPoolTimeoutTest.java: Multi-threaded client timeout tests for ldap pool > > Ryan Flegel has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'master' of https://git.openjdk.org/jdk21u-dev into backport-720b44648b > - Merge remote-tracking branch 'origin/master' into backport-720b44648b > - Backport 720b44648bcff997278af92746f942b2425298a5 Hello Ryan, I don't follow the JDK updates project, so I can't say if/when this will be backported. However, the fix for the original issue is in JDK 24, which hasn't yet been released. So backporting this might be a bit too early at this point, especially since it isn't a regression (the issue has been present since Java 11). My opinion is that this is worth backporting but only after the fix has seen some usage in a GA version of Java 24 or beyond. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1020#issuecomment-2513663198 From goetz at openjdk.org Tue Dec 3 08:18:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 08:18:46 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21 In-Reply-To: References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: On Wed, 27 Nov 2024 19:45:30 GMT, Severin Gehwolf wrote: >> Hi, >> >> In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. >> >> Thanks, >> Martin.- > > @martinuy Please submit a dependent PR for 8328366 so that we can approve them both. Thanks. Hi @jerboaa, @martinuy, today is the last day before cut-off of the January update. I'm not sure whether we should push this on last notice. One other thing I wonder is that Oracle has not backported the follow-up fix JDK-8342905 to 21.0.6-oracle. Has this been overseen, @AlanBateman? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#issuecomment-2513827318 From mbaesken at openjdk.org Tue Dec 3 08:38:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 3 Dec 2024 08:38:47 GMT Subject: [jdk17u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v2] In-Reply-To: References: Message-ID: <49bP_-7IFjJfxjtfB_aSevwSQiMRcfrueyfRyVlW5ko=.cf50a7a3-8ea4-4554-94a4-e4168e341a2f@github.com> On Mon, 2 Dec 2024 10:38:10 GMT, Goetz Lindenmaier wrote: >> This is a backport of the 21 PR code, but it needs further adaptions. >> >> SystemModulesPlugin.java had to be resolved. The code to be patched does the >> same, but uses different Java syntax. >> >> Also, I had to remove one more case from the test as jdk.httpserver has no main >> specified. This was added in [8245095: Implementation of JEP 408: Simple Web Server](https://bugs.openjdk.org/browse/JDK-8245095). >> But the test still shows the same failure as in head when the fix misses >> in the JVM, and passes if the fix is present. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Cleanups as in 21 Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3078#pullrequestreview-2474923877 From goetz at openjdk.org Tue Dec 3 09:12:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 09:12:48 GMT Subject: [jdk17u-dev] Integrated: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order In-Reply-To: References: Message-ID: On Fri, 29 Nov 2024 08:22:00 GMT, Goetz Lindenmaier wrote: > This is a backport of the 21 PR code, but it needs further adaptions. > > SystemModulesPlugin.java had to be resolved. The code to be patched does the > same, but uses different Java syntax. > > Also, I had to remove one more case from the test as jdk.httpserver has no main > specified. This was added in [8245095: Implementation of JEP 408: Simple Web Server](https://bugs.openjdk.org/browse/JDK-8245095). > But the test still shows the same failure as in head when the fix misses > in the JVM, and passes if the fix is present. This pull request has now been integrated. Changeset: 4d268db0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4d268db07f4d32f3c5abd5083fa9bab1765cc74f Stats: 257 lines in 6 files changed: 248 ins; 0 del; 9 mod 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order Reviewed-by: mbaesken Backport-of: f3be138eb80c9e7f6cc21afb75cda9e49b667c8a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3078 From goetz at openjdk.org Tue Dec 3 09:13:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 09:13:51 GMT Subject: [jdk17u-dev] Integrated: 8339892: Several security shell tests don't set TESTJAVAOPTS In-Reply-To: <1T4prBfi_bezOw3RWxfhUreW08EjyhHA6GRYCvB2SRI=.1e138f03-689c-4590-9d8f-bbe92ffee34e@github.com> References: <1T4prBfi_bezOw3RWxfhUreW08EjyhHA6GRYCvB2SRI=.1e138f03-689c-4590-9d8f-bbe92ffee34e@github.com> Message-ID: On Mon, 2 Dec 2024 11:21:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. > > Resolved one Copyright, probably clean. This pull request has now been integrated. Changeset: f23d6bf3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f23d6bf3f74d9221124e31e69691af891ecb3309 Stats: 22 lines in 10 files changed: 0 ins; 0 del; 22 mod 8339892: Several security shell tests don't set TESTJAVAOPTS Backport-of: 8a2a75e56de4497da48f43b3be3eb71bf3ef75ab ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3081 From sgehwolf at openjdk.org Tue Dec 3 09:19:47 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 09:19:47 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21 In-Reply-To: References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: On Wed, 27 Nov 2024 19:45:30 GMT, Severin Gehwolf wrote: >> Hi, >> >> In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. >> >> Thanks, >> Martin.- > > @martinuy Please submit a dependent PR for 8328366 so that we can approve them both. Thanks. > Hi @jerboaa, @martinuy, > today is the last day before cut-off of the January update. > I'm not sure whether we should push this on last notice. @GoeLin I've we get it in before ramp-down it still has the full rampdown-cycle (two months). So last notice is relative IMO. We've had fairly good testing on 21.0.5 for this and the follow up clears the issue causing the back-out. It would be good to have it in the January release as it fixes a class unloading issue in 21. I won't insist, though. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#issuecomment-2513958188 From goetz at openjdk.org Tue Dec 3 09:25:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 09:25:46 GMT Subject: [jdk21u-dev] RFR: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21 In-Reply-To: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: On Mon, 25 Nov 2024 22:17:04 GMT, Martin Balao wrote: > Hi, > > In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. > > Thanks, > Martin.- Well then let's go ahead. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1181#issuecomment-2513973113 From sgehwolf at openjdk.org Tue Dec 3 09:42:44 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 09:42:44 GMT Subject: [jdk17u-dev] RFR: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases In-Reply-To: References: Message-ID: On Mon, 16 Sep 2024 17:06:28 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK21 > > The only difference is an additional EPERM check in the stat1 method. This method was removed in JDK21 as part of JDK-8283335 `Function not implemented` suggests `ENOSYS`, which can have other causes too. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2883#issuecomment-2514010278 From goetz at openjdk.org Tue Dec 3 09:47:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 09:47:09 GMT Subject: [jdk21u-dev] RFR: 8345370: Bump update version for OpenJDK: jdk-21.0.7 Message-ID: The required version bump. ------------- Commit messages: - 8345370: Bump update version for OpenJDK: jdk-21.0.7 Changes: https://git.openjdk.org/jdk21u-dev/pull/1198/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1198&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345370 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1198.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1198/head:pull/1198 PR: https://git.openjdk.org/jdk21u-dev/pull/1198 From goetz at openjdk.org Tue Dec 3 09:56:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 09:56:08 GMT Subject: [jdk17u-dev] RFR: 8345371: Bump update version for OpenJDK: jdk-17.0.15 Message-ID: The required version bump ------------- Commit messages: - 8345371: Bump update version for OpenJDK: jdk-17.0.15 Changes: https://git.openjdk.org/jdk17u-dev/pull/3085/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3085&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345371 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3085.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3085/head:pull/3085 PR: https://git.openjdk.org/jdk17u-dev/pull/3085 From mdoerr at openjdk.org Tue Dec 3 10:08:38 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 3 Dec 2024 10:08:38 GMT Subject: [jdk21u-dev] RFR: 8345370: Bump update version for OpenJDK: jdk-21.0.7 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 09:42:37 GMT, Goetz Lindenmaier wrote: > The required version bump. Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1198#pullrequestreview-2475176304 From mdoerr at openjdk.org Tue Dec 3 10:08:42 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 3 Dec 2024 10:08:42 GMT Subject: [jdk17u-dev] RFR: 8345371: Bump update version for OpenJDK: jdk-17.0.15 In-Reply-To: References: Message-ID: <2Ew_PFbpXJsKSwut05wpgbXOWXa53iw8MYQE-r6MUcI=.7b7f3bc1-d06a-49b7-a132-ddbfe44662d1@github.com> On Tue, 3 Dec 2024 09:50:35 GMT, Goetz Lindenmaier wrote: > The required version bump Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3085#pullrequestreview-2475175477 From mbaesken at openjdk.org Tue Dec 3 10:19:43 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 3 Dec 2024 10:19:43 GMT Subject: [jdk17u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 22:09:05 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK21u patch > The only manual merge is for jar.properties because of JDK-8302819 not backported to JDK17 > > JTREG tests passed test/jdk/tools/jar/MultipleManifestTest.java seems to have some issue with the file ending ? but this is also present in 21u-dev so probably okay. ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3075#pullrequestreview-2475202668 From mdoerr at openjdk.org Tue Dec 3 10:29:42 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 3 Dec 2024 10:29:42 GMT Subject: [jdk17u-dev] RFR: 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true' In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 09:01:52 GMT, Goetz Lindenmaier wrote: > I would like to backport this small bugfix. > > I had to resolve because "8284112: Minor cleanup could be done in javax.crypto" is not in 17. > Therefore the template parameters of the patched code differ: > this change: processedPermissions = new Hashtable<>(); > jdk17: processedPermissions = new Hashtable>(); > > Test passes. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3080#pullrequestreview-2475229741 From sgehwolf at openjdk.org Tue Dec 3 10:29:41 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 10:29:41 GMT Subject: [jdk21u-dev] RFR: 8345370: Bump update version for OpenJDK: jdk-21.0.7 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 09:42:37 GMT, Goetz Lindenmaier wrote: > The required version bump. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1198#pullrequestreview-2475230264 From sgehwolf at openjdk.org Tue Dec 3 10:30:41 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 10:30:41 GMT Subject: [jdk17u-dev] RFR: 8345371: Bump update version for OpenJDK: jdk-17.0.15 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 09:50:35 GMT, Goetz Lindenmaier wrote: > The required version bump Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3085#pullrequestreview-2475232375 From mdoerr at openjdk.org Tue Dec 3 11:03:48 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 3 Dec 2024 11:03:48 GMT Subject: [jdk17u-dev] RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 13:08:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I had to resolve the makefile. > Also, I had to resolve jni.cpp because of nullptr in the context. > > I include follow-up JDK-8309171, this applies after adding the problemlisting JDK-8309231. The original change bumps the Copyright year in JtregNativeHotspot.gmk. It would be better to do the same. What's the point regarding the ProblemList? Does one part add it and the other one remove it, so it's a nop? ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3084#pullrequestreview-2475314630 From sgehwolf at openjdk.org Tue Dec 3 11:42:49 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 11:42:49 GMT Subject: [jdk21u-dev] RFR: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 13:47:36 GMT, Roland Westrelin wrote: > clean backport of JDK-8340824 Keep open. 21.0.7 development starts this Thursday. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1122#issuecomment-2514316848 From rrich at openjdk.org Tue Dec 3 12:58:49 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 3 Dec 2024 12:58:49 GMT Subject: [jdk21u-dev] RFR: 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR Message-ID: Hi all, This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/ed6809666b12b0de66f68d5e7e389dde1708aaf3 from the openjdk/jdk repository. The commit being backported was authored by Richard Reingruber on 16 Oct 2024 and was reviewed by Martin Doerr and Matthias Baesken. The risk of the backport is low. It's small and therefore obvious that only `LM_MONITOR` is handled differently which is experimental anyway. The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. Thanks, Richard. ------------- Commit messages: - Backport ed6809666b12b0de66f68d5e7e389dde1708aaf3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1186/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1186&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341862 Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1186.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1186/head:pull/1186 PR: https://git.openjdk.org/jdk21u-dev/pull/1186 From rrich at openjdk.org Tue Dec 3 12:58:50 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 3 Dec 2024 12:58:50 GMT Subject: [jdk21u-dev] RFR: 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR In-Reply-To: References: Message-ID: On Wed, 27 Nov 2024 11:00:25 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/ed6809666b12b0de66f68d5e7e389dde1708aaf3 from the openjdk/jdk repository. > > The commit being backported was authored by Richard Reingruber on 16 Oct 2024 and was reviewed by Martin Doerr and Matthias Baesken. > > The risk of the backport is low. It's small and therefore obvious that only `LM_MONITOR` is handled differently which is experimental anyway. > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. > > Thanks, Richard. Test failure is unrelated. [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk21u-dev/jdk21u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip Error: sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1186#issuecomment-2514488635 From goetz at openjdk.org Tue Dec 3 13:13:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 13:13:49 GMT Subject: [jdk17u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 22:09:05 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK21u patch > The only manual merge is for jar.properties because of JDK-8302819 not backported to JDK17 > > JTREG tests passed GHA test failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3075#issuecomment-2514521164 From rrich at openjdk.org Tue Dec 3 13:54:56 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 3 Dec 2024 13:54:56 GMT Subject: [jdk21u-dev] RFR: 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking Message-ID: Backport of https://github.com/openjdk/jdk/commit/f9208fadde8141e18a025ddb6ce28423861ba391 The change removes instructions that check if an ObjectMonitor is owned by the current thread before unlocking it in a c1/c2 compiled nmethod. The check is imprecise. It can fail if the lock was inflated into an ObjectMonitor by another thread. It is also redundant since only bytecode with symmetric locking operations is compiled. See JBS-Issue for details. Note that there existed a special diagnostic locking mode to do the same check also on x86. Purpose was to protect against missbehaving JNI code. It got removed though with [JDK-8210381](https://bugs.openjdk.org/browse/JDK-8210381) in jdk12. On ppc64le it was not removed as the check was done in default mode as well (unclear why). The fix didn't apply because in jdk21 there is still just one method to handle LM_LEGACY and LM_LIGHTWEIGHT and LM_LIGHTWEIGHT requires the owner check to handle ANONYMOUS owner. Also RTM is still supported in jdk21. I'd consider the risk low. Aside from the assertions, the change is very small and it just brings ppc64 in line with how unlocking is done on other platforms. The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. ------------- Commit messages: - Adapt for RTM and LM_LIGHTWEIGHT - 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking Changes: https://git.openjdk.org/jdk21u-dev/pull/1191/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1191&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341715 Stats: 37 lines in 1 file changed: 31 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1191.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1191/head:pull/1191 PR: https://git.openjdk.org/jdk21u-dev/pull/1191 From mbaesken at openjdk.org Tue Dec 3 14:09:54 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 3 Dec 2024 14:09:54 GMT Subject: [jdk11u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 23:04:54 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK17u > > The only trivial manual merge is for jar.properties because of JDK-8276766 and Main.java because of JDK-8266835 are not backported to JDK11 > > JTREG tests passed Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2970#pullrequestreview-2475782678 From mbalao at openjdk.org Tue Dec 3 15:28:50 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 3 Dec 2024 15:28:50 GMT Subject: [jdk21u-dev] Integrated: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21 In-Reply-To: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> References: <0oFkU_c0EY4Xuel1w052U71cM3ErEydkAaIim7UDWsA=.f4aa87e6-2308-4887-a993-b18100dc646a@github.com> Message-ID: <14MMFomVLjWVfIjxHag5i9JI05vKtCSJCDHJQz-2_BY=.84e4e9e5-69b4-4847-8b55-34fe9a5e2446@github.com> On Mon, 25 Nov 2024 22:17:04 GMT, Martin Balao wrote: > Hi, > > In this PR I back out 8341989 for 8327501 and 8328366 to be re-introduced to JDK 21u. I plan to propose a backport of 8342905 thereafter. Reversion of 8341989 was clean. > > Thanks, > Martin.- This pull request has now been integrated. Changeset: 96a3a88e Author: Martin Balao URL: https://git.openjdk.org/jdk21u-dev/commit/96a3a88ee206680ba06c6ed876b538de41ff511c Stats: 11 lines in 2 files changed: 8 ins; 2 del; 1 mod 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1181 From fferrari at openjdk.org Tue Dec 3 15:34:26 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 3 Dec 2024 15:34:26 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v2] In-Reply-To: References: Message-ID: <6ATwPpJcGvxHk_4HEY4widODQNC1crn3Q0pFUpHgRaU=.44a7fddb-8267-4ca4-8801-0e80e3727f7a@github.com> > Hi, > > I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. > > The backport is not clean, for the following reasons: > > * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) > * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) > * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method > * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 > > This pull request depends on @martinuy's #1181. > > #### Testing > > As part of our testing, we observed all the tests pass in the following categories: > > * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) > * `jdk/java/util/concurrent/forkjoin` > * `jdk/java/util/concurrent/tck` > > Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. Francisco Ferrari Bihurriet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1192/files - new: https://git.openjdk.org/jdk21u-dev/pull/1192/files/f02d74fb..f02d74fb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1192&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1192&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1192.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1192/head:pull/1192 PR: https://git.openjdk.org/jdk21u-dev/pull/1192 From szaldana at openjdk.org Tue Dec 3 15:37:23 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 3 Dec 2024 15:37:23 GMT Subject: [jdk21u-dev] RFR: 8327390: JitTester: Implement temporary folder functionality Message-ID: Hi all, This pull request contains a backport of commit [5aae8030](https://github.com/openjdk/jdk/commit/5aae80304c0b1b49341777b9da103638183877d5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Evgeny Nikitin on 7 Mar 2024 and was reviewed by Guoxiong Li and Leonid Mesnik. Thanks! ------------- Commit messages: - Backport 5aae80304c0b1b49341777b9da103638183877d5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1193/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1193&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327390 Stats: 76 lines in 4 files changed: 63 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1193.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1193/head:pull/1193 PR: https://git.openjdk.org/jdk21u-dev/pull/1193 From szaldana at openjdk.org Tue Dec 3 15:39:22 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 3 Dec 2024 15:39:22 GMT Subject: [jdk21u-dev] RFR: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java Message-ID: Hi all, This pull request contains a backport of commit [f927c121](https://github.com/openjdk/jdk/commit/f927c1210ee0675bb1196572177ffb505826d57a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eirik Bj?rsn?s on 30 Aug 2024 and was reviewed by Lance Andersen. Thanks! ------------- Commit messages: - Backport f927c1210ee0675bb1196572177ffb505826d57a Changes: https://git.openjdk.org/jdk21u-dev/pull/1195/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1195&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339154 Stats: 119 lines in 1 file changed: 76 ins; 9 del; 34 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1195.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1195/head:pull/1195 PR: https://git.openjdk.org/jdk21u-dev/pull/1195 From szaldana at openjdk.org Tue Dec 3 15:40:57 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 3 Dec 2024 15:40:57 GMT Subject: [jdk21u-dev] RFR: 8334490: Normalize string with locale invariant `toLowerCase()` Message-ID: <6rEu0CTVNJYCS8ID9zgtgAduIcEP_Ldp-kFy0Fo4QnI=.332a52c7-6ced-4faf-a1dc-80ba19e1eea7@github.com> Hi all, This pull request contains a backport of commit [265a0f55](https://github.com/openjdk/jdk/commit/265a0f5547d0ddb220391aef679c122768f02a00) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Naoto Sato on 20 Jun 2024 and was reviewed by Justin Lu, Daniel Fuchs, Lance Andersen and Roger Riggs. Thanks! ------------- Commit messages: - Backport 265a0f5547d0ddb220391aef679c122768f02a00 Changes: https://git.openjdk.org/jdk21u-dev/pull/1197/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1197&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334490 Stats: 7 lines in 1 file changed: 1 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1197.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1197/head:pull/1197 PR: https://git.openjdk.org/jdk21u-dev/pull/1197 From sgehwolf at openjdk.org Tue Dec 3 15:53:43 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 15:53:43 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v2] In-Reply-To: <6ATwPpJcGvxHk_4HEY4widODQNC1crn3Q0pFUpHgRaU=.44a7fddb-8267-4ca4-8801-0e80e3727f7a@github.com> References: <6ATwPpJcGvxHk_4HEY4widODQNC1crn3Q0pFUpHgRaU=.44a7fddb-8267-4ca4-8801-0e80e3727f7a@github.com> Message-ID: <86LBFI2-ZaRdMlQhJshzhWx79omIfH4_YSGJX_F-wNE=.f756f2cd-b4d1-4f09-b8db-43f8f35e9004@github.com> On Tue, 3 Dec 2024 15:34:26 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. >> >> The backport is not clean, for the following reasons: >> >> * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) >> * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) >> * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method >> * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 >> >> This pull request depends on @martinuy's #1181. >> >> #### Testing >> >> As part of our testing, we observed all the tests pass in the following categories: >> >> * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) >> * `jdk/java/util/concurrent/forkjoin` >> * `jdk/java/util/concurrent/tck` >> >> Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. > > Francisco Ferrari Bihurriet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. @franferrax Please merge master since the dependency integrated. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1192#issuecomment-2514939258 From fferrari at openjdk.org Tue Dec 3 16:11:58 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 3 Dec 2024 16:11:58 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v3] In-Reply-To: References: Message-ID: > Hi, > > I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. > > The backport is not clean, for the following reasons: > > * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) > * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) > * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method > * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 > > This pull request depends on @martinuy's #1181. > > #### Testing > > As part of our testing, we observed all the tests pass in the following categories: > > * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) > * `jdk/java/util/concurrent/forkjoin` > * `jdk/java/util/concurrent/tck` > > Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. Francisco Ferrari Bihurriet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - Backport 872ae1347198408ffd62559ca8c1a7420c4a8108 - 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK Revert "8341989: [21u] Back out JDK-8327501 and JDK-8328366" This reverts commit dfcd8d2eecfe62e91070244d8eb10906dc3c812d. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1192/files - new: https://git.openjdk.org/jdk21u-dev/pull/1192/files/f02d74fb..84a0ff07 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1192&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1192&range=01-02 Stats: 400 lines in 13 files changed: 325 ins; 37 del; 38 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1192.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1192/head:pull/1192 PR: https://git.openjdk.org/jdk21u-dev/pull/1192 From fferrari at openjdk.org Tue Dec 3 16:42:45 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 3 Dec 2024 16:42:45 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v3] In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 16:11:58 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. >> >> The backport is not clean, for the following reasons: >> >> * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) >> * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) >> * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method >> * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 >> >> This pull request depends on @martinuy's #1181. >> >> #### Testing >> >> As part of our testing, we observed all the tests pass in the following categories: >> >> * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) >> * `jdk/java/util/concurrent/forkjoin` >> * `jdk/java/util/concurrent/tck` >> >> Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. > > Francisco Ferrari Bihurriet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - Backport 872ae1347198408ffd62559ca8c1a7420c4a8108 > - 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK > > Revert "8341989: [21u] Back out JDK-8327501 and JDK-8328366" > > This reverts commit dfcd8d2eecfe62e91070244d8eb10906dc3c812d. Please note that the old PR diff exactly matches the new one: * Old diff: f02d74fb73125f57ed1bac82474a0d9a224a35bf (previous tip of this PR branch) against its parent, 67a36bded7f03fc7aee54372e71f8016d67971fd (tip of #1181, on which this PR depended) * New diff: 84a0ff07baa37d1a93e698f29a3c1bd6fa0bfd45 (current tip of this PR branch) against its second parent, 96a3a88ee206680ba06c6ed876b538de41ff511c (current tip of `master`) For example the following commands: git diff 67a36bded7f03fc7aee54372e71f8016d67971fd f02d74fb73125f57ed1bac82474a0d9a224a35bf | sha512sum git diff 96a3a88ee206680ba06c6ed876b538de41ff511c 84a0ff07baa37d1a93e698f29a3c1bd6fa0bfd45 | sha512sum Both produce the same output: 0a7bdece0a0182399b03b7760046a12866781c7d7e519cfa052e93da9bf65b3f9d12e389bee37e86d52cf1fa0a841f5bc8aba94e9d6524aacff441468b67f2a4 - Anyway, we'll want to wait for [run 12143610533](https://github.com/franferrax/jdk21u-dev/actions/runs/12143610533) before integrating. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1192#issuecomment-2515061046 From sgehwolf at openjdk.org Tue Dec 3 16:50:41 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 16:50:41 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v3] In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 16:11:58 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. >> >> The backport is not clean, for the following reasons: >> >> * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) >> * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) >> * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method >> * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 >> >> This pull request depends on @martinuy's #1181. >> >> #### Testing >> >> As part of our testing, we observed all the tests pass in the following categories: >> >> * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) >> * `jdk/java/util/concurrent/forkjoin` >> * `jdk/java/util/concurrent/tck` >> >> Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. > > Francisco Ferrari Bihurriet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - Backport 872ae1347198408ffd62559ca8c1a7420c4a8108 > - 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK > > Revert "8341989: [21u] Back out JDK-8327501 and JDK-8328366" > > This reverts commit dfcd8d2eecfe62e91070244d8eb10906dc3c812d. Looks OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1192#pullrequestreview-2476260099 From sgehwolf at openjdk.org Tue Dec 3 16:53:41 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 16:53:41 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v3] In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 16:40:09 GMT, Francisco Ferrari Bihurriet wrote: > Please note that the old PR diff exactly matches the new one: Yes, understood. But for dependent PRs it's advised to merge master once the dependent PR integrates before actually integrating since the base revision changes and the actual commit might not be right. Not a problem in this case, but still good to merge master. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1192#issuecomment-2515089802 From fferrari at openjdk.org Tue Dec 3 17:30:46 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 3 Dec 2024 17:30:46 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v3] In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 16:51:23 GMT, Severin Gehwolf wrote: > > Please note that the old PR diff exactly matches the new one: > > Yes, understood. But for dependent PRs it's advised to merge master once the dependent PR integrates before actually integrating since the base revision changes and the actual commit might not be right. Not a problem in this case, but still good to merge master. Thanks! Yes, once the Skara bot changes the base, the PR gets a conflict and the rebase or merge becomes strictly necessary. Sorry for the confusion, I should have mentioned I was showing the same-diff evidence only to make the re-review process faster after the merge (in case @martinuy was going to re-review, and wanted to rely on his previous review by acknowledging that nothing changed). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1192#issuecomment-2515172037 From sgehwolf at openjdk.org Tue Dec 3 17:37:45 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 3 Dec 2024 17:37:45 GMT Subject: [jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v3] In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 16:11:58 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. >> >> The backport is not clean, for the following reasons: >> >> * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) >> * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) >> * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method >> * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 >> >> This pull request depends on @martinuy's #1181. >> >> #### Testing >> >> As part of our testing, we observed all the tests pass in the following categories: >> >> * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) >> * `jdk/java/util/concurrent/forkjoin` >> * `jdk/java/util/concurrent/tck` >> >> Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. > > Francisco Ferrari Bihurriet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - Backport 872ae1347198408ffd62559ca8c1a7420c4a8108 > - 8344993: [21u] Re-introduce 8327501 and 8328366 to the JDK > > Revert "8341989: [21u] Back out JDK-8327501 and JDK-8328366" > > This reverts commit dfcd8d2eecfe62e91070244d8eb10906dc3c812d. Thanks. Please integrate once GHA is clean. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1192#issuecomment-2515188093 From phh at openjdk.org Tue Dec 3 17:53:52 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Dec 2024 17:53:52 GMT Subject: [jdk17u-dev] RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 13:08:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I had to resolve the makefile. > Also, I had to resolve jni.cpp because of nullptr in the context. > > I include follow-up JDK-8309171, this applies after adding the problemlisting JDK-8309231. It appeared to me that indeed one part added it and one removed it. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3084#issuecomment-2515226231 From fferrari at openjdk.org Tue Dec 3 19:08:51 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 3 Dec 2024 19:08:51 GMT Subject: [jdk21u-dev] Integrated: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux In-Reply-To: References: Message-ID: <72Xf2s_yHD0c-A9zVNF8zL-CZLruTrLeaup33NJe9y4=.11ad5729-f4d2-49f2-b456-0c65f7c7f7ca@github.com> On Mon, 2 Dec 2024 20:20:54 GMT, Francisco Ferrari Bihurriet wrote: > Hi, > > I would like to propose a [JDK-8342905](https://bugs.openjdk.org/browse/JDK-8342905 "Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux") (openjdk/jdk23u at 872ae1347198408ffd62559ca8c1a7420c4a8108) backport from 23u to 21u. > > The backport is not clean, for the following reasons: > > * The `jdk.internal.access.JavaLangAccess` import context in `ForkJoinPool.java` has changed from 21u to 23u, due to [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899 "java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"") (openjdk/jdk at 667cca9d7aef1ff4abe630cefaac34c0b1646925) > * The `jdk.internal.access.JavaLangAccess::allowSecurityManager` method didn't exist in 21u, so I picked it from [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") (openjdk/jdk at d32746ef4a0ce6fec558274244321991be141698) > * We don't need [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs"), just the access to the `System::allowSecurityManager` private method > * I don't see [JDK-8296244](https://bugs.openjdk.org/browse/JDK-8296244 "Alternate implementation of user-based authorization Subject APIs that doesn?t depend on Security Manager APIs") as a possible dependency candidate, given it is a much broader change with its own CSR affecting the Java SE API and only approved for 23 > > This pull request depends on @martinuy's #1181. > > #### Testing > > As part of our testing, we observed all the tests pass in the following categories: > > * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk21u-dev/actions/runs/12126257318)) > * `jdk/java/util/concurrent/forkjoin` > * `jdk/java/util/concurrent/tck` > > Additionally, an internal test for [JDK-8237117](https://bugs.openjdk.org/browse/JDK-8237117 "Better ForkJoinPool behavior") was executed without issues. This pull request has now been integrated. Changeset: 3f648b4f Author: Francisco Ferrari Bihurriet URL: https://git.openjdk.org/jdk21u-dev/commit/3f648b4f65dac89d91ae318f410e66e596589f3b Stats: 18 lines in 3 files changed: 15 ins; 2 del; 1 mod 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux Reviewed-by: sgehwolf, mbalao Backport-of: 872ae1347198408ffd62559ca8c1a7420c4a8108 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1192 From abakhtin at openjdk.org Tue Dec 3 20:06:51 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 3 Dec 2024 20:06:51 GMT Subject: [jdk21u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: <_T_A_ALckOyOPoqLwPTGVThDlLeIgVLmoA2zvbJvKX0=.d403e4b2-dba4-4559-a5d3-50a368f4f568@github.com> References: <_T_A_ALckOyOPoqLwPTGVThDlLeIgVLmoA2zvbJvKX0=.d403e4b2-dba4-4559-a5d3-50a368f4f568@github.com> Message-ID: On Fri, 22 Nov 2024 22:59:12 GMT, Henry Jen wrote: > LGTM @slowhog, Thank you for review. Can anybody with review status accept it also? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1177#issuecomment-2515442880 From szaldana at openjdk.org Tue Dec 3 20:29:02 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 3 Dec 2024 20:29:02 GMT Subject: [jdk21u-dev] RFR: 8331993: Add counting leading/trailing zero tests for Integer Message-ID: Hi all, This pull request contains a backport of commit [675fbe69](https://github.com/openjdk/jdk/commit/675fbe699ed1aad37f34429cbe1f4f3e029be03f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Hamlin Li on 10 May 2024 and was reviewed by Christian Hagedorn. Thanks! ------------- Commit messages: - Backport 675fbe699ed1aad37f34429cbe1f4f3e029be03f Changes: https://git.openjdk.org/jdk21u-dev/pull/1194/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1194&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331993 Stats: 67 lines in 3 files changed: 44 ins; 0 del; 23 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1194.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1194/head:pull/1194 PR: https://git.openjdk.org/jdk21u-dev/pull/1194 From szaldana at openjdk.org Tue Dec 3 21:31:55 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 3 Dec 2024 21:31:55 GMT Subject: [jdk21u-dev] RFR: 8336012: Fix usages of jtreg-reserved properties Message-ID: Hi all, This pull request contains a backport of commit [e6c5aa7a](https://github.com/openjdk/jdk/commit/e6c5aa7a6cb54c647d261facdcffa6a410849627) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christian Stein on 10 Jul 2024 and was reviewed by Jonathan Gibbons. Thanks! ------------- Commit messages: - Backport e6c5aa7a6cb54c647d261facdcffa6a410849627 Changes: https://git.openjdk.org/jdk21u-dev/pull/1196/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1196&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336012 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1196.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1196/head:pull/1196 PR: https://git.openjdk.org/jdk21u-dev/pull/1196 From goetz at openjdk.org Tue Dec 3 22:04:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 22:04:44 GMT Subject: [jdk21u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Fri, 22 Nov 2024 21:08:42 GMT, Alexey Bakhtin wrote: > Clean backport of jar tool enhancement from JDK23 > > JTREG tests passed This is the same change as the pull request targeted to 23. (Not really a clean _backport_, as the PR for 23 was never pushed.) Wrt. to the head version it adds the enum OptionType.EXTRACT, which is needed to implement flags applicable in addition to the parameter or mode "extract". JDK-8173970 adds a different flag, independent of this one. So it's a good idea to reuse this code snippet. Besides this the change is identical to head. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1177#pullrequestreview-2476844228 From goetz at openjdk.org Tue Dec 3 22:10:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 3 Dec 2024 22:10:43 GMT Subject: [jdk21u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Fri, 22 Nov 2024 21:08:42 GMT, Alexey Bakhtin wrote: > Clean backport of jar tool enhancement from JDK23 > > JTREG tests passed GHA failure One is the well known wget error, unrelated. The other is a jtreg failure, serviceability/sa/CDSJMapClstats.java fails. ACtually it throws SIGBUS, and then terminates with IOException: LingeredApp terminated with non-zero exit code 137 I would not expect this change to affect CDSJMapClstats, but please have a second look and best restart this test. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1177#issuecomment-2515650684 From mbalao at openjdk.org Tue Dec 3 23:37:38 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 3 Dec 2024 23:37:38 GMT Subject: [jdk21u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Fri, 22 Nov 2024 21:08:42 GMT, Alexey Bakhtin wrote: > Clean backport of jar tool enhancement from JDK23 > > JTREG tests passed Thanks for this contribution. Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1177#pullrequestreview-2476966615 From mbalao at openjdk.org Tue Dec 3 23:39:44 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 3 Dec 2024 23:39:44 GMT Subject: [jdk17u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: <89FLXZok_tEOKpWY_1lLBbY40vhvXRItZRcxU_nTtLQ=.afde7d3e-7608-4d41-9839-9db2485abc40@github.com> On Mon, 25 Nov 2024 22:09:05 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK21u patch > The only manual merge is for jar.properties because of JDK-8302819 not backported to JDK17 > > JTREG tests passed Thanks for this contribution. Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3075#pullrequestreview-2476968512 From mbalao at openjdk.org Tue Dec 3 23:46:51 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 3 Dec 2024 23:46:51 GMT Subject: [jdk11u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 23:04:54 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK17u > > The only trivial manual merge is for jar.properties because of JDK-8276766 and Main.java because of JDK-8266835 are not backported to JDK11 > > JTREG tests passed Thanks for this contribution. Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2970#pullrequestreview-2476974159 From abakhtin at openjdk.org Wed Dec 4 01:05:50 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 01:05:50 GMT Subject: [jdk21u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 22:08:21 GMT, Goetz Lindenmaier wrote: > GHA failure One is the well known wget error, unrelated. The other is a jtreg failure, serviceability/sa/CDSJMapClstats.java fails. ACtually it throws SIGBUS, and then terminates with IOException: LingeredApp terminated with non-zero exit code 137 > > I would not expect this change to affect CDSJMapClstats, but please have a second look and best restart this test. Thank you for the review! The tests are passed after the restart. I do not think the previous failure was caused by these changes. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1177#issuecomment-2515908153 From abakhtin at openjdk.org Wed Dec 4 01:05:51 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 01:05:51 GMT Subject: [jdk21u-dev] Integrated: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: <-erKXNR5_F4CsRpi7T2F2xTS5KafBxjIWwmFy5g4EHI=.f8ae274c-5233-480b-9f97-4d230d79a557@github.com> On Fri, 22 Nov 2024 21:08:42 GMT, Alexey Bakhtin wrote: > Clean backport of jar tool enhancement from JDK23 > > JTREG tests passed This pull request has now been integrated. Changeset: e45287d1 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk21u-dev/commit/e45287d1ad9dcadf8a23d3271f1b675b8dade0ac Stats: 528 lines in 5 files changed: 526 ins; 0 del; 2 mod 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Reviewed-by: henryjen, goetz, mbalao Backport-of: 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1177 From abakhtin at openjdk.org Wed Dec 4 01:06:45 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 01:06:45 GMT Subject: [jdk17u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 22:09:05 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK21u patch > The only manual merge is for jar.properties because of JDK-8302819 not backported to JDK17 > > JTREG tests passed Thank you for review ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3075#issuecomment-2515910378 From abakhtin at openjdk.org Wed Dec 4 01:06:46 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 01:06:46 GMT Subject: [jdk17u-dev] Integrated: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 22:09:05 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK21u patch > The only manual merge is for jar.properties because of JDK-8302819 not backported to JDK17 > > JTREG tests passed This pull request has now been integrated. Changeset: bdc07d20 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk17u-dev/commit/bdc07d202a917384625f3a17c630e92dcd9f2fcf Stats: 528 lines in 5 files changed: 526 ins; 0 del; 2 mod 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Reviewed-by: mbaesken, mbalao Backport-of: 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3075 From goetz at openjdk.org Wed Dec 4 07:09:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 07:09:49 GMT Subject: [jdk17u-dev] RFR: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 12:33:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3083#issuecomment-2516368199 From goetz at openjdk.org Wed Dec 4 07:18:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 07:18:38 GMT Subject: [jdk17u-dev] RFR: 8345371: Bump update version for OpenJDK: jdk-17.0.15 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 09:50:35 GMT, Goetz Lindenmaier wrote: > The required version bump GAH failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3085#issuecomment-2516383905 From goetz at openjdk.org Wed Dec 4 07:39:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 07:39:40 GMT Subject: [jdk21u-dev] Integrated: 8345370: Bump update version for OpenJDK: jdk-21.0.7 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 09:42:37 GMT, Goetz Lindenmaier wrote: > The required version bump. This pull request has now been integrated. Changeset: 17ba5136 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/17ba5136ceb50edea3d3e405f7b18be61df60f9b Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8345370: Bump update version for OpenJDK: jdk-21.0.7 Reviewed-by: mdoerr, sgehwolf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1198 From goetz at openjdk.org Wed Dec 4 07:47:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 07:47:47 GMT Subject: [jdk17u-dev] Integrated: 8345371: Bump update version for OpenJDK: jdk-17.0.15 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 09:50:35 GMT, Goetz Lindenmaier wrote: > The required version bump This pull request has now been integrated. Changeset: 63aa0769 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/63aa0769a76a86d864bdff5fd4b025948d2caf96 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8345371: Bump update version for OpenJDK: jdk-17.0.15 Reviewed-by: mdoerr, sgehwolf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3085 From goetz at openjdk.org Wed Dec 4 07:50:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 07:50:45 GMT Subject: [jdk17u-dev] Integrated: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 12:22:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: c1a9356b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c1a9356b30f4a5bfc4195b3f564ffcc1e4511f80 Stats: 228 lines in 4 files changed: 68 ins; 76 del; 84 mod 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus 8299127: [REDO] JDK-8194048 Regression automated test '/open/test/jdk/javax/swing/text/DefaultCaret/HidingSelection/HidingSelectionTest.java' fails 8299128: [REDO] JDK-8213562 Test javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java fails Backport-of: fef70d78baec9ce11d50b9a4c1fb26a1b854ccbf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3082 From goetz at openjdk.org Wed Dec 4 07:52:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 07:52:41 GMT Subject: [jdk17u-dev] Integrated: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 12:33:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: be22b1a8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/be22b1a8aae14d2d7f802ea0db32580bdb6d1f61 Stats: 18 lines in 2 files changed: 9 ins; 0 del; 9 mod 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException Backport-of: 04f30185e914c10c918d0eff1fb63fd96e1139fb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3083 From goetz at openjdk.org Wed Dec 4 07:53:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 07:53:42 GMT Subject: [jdk17u-dev] Integrated: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 13:08:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I had to resolve the makefile. > Also, I had to resolve jni.cpp because of nullptr in the context. > > I include follow-up JDK-8309171, this applies after adding the problemlisting JDK-8309231. This pull request has now been integrated. Changeset: ed63b718 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ed63b718fe5b4e9f77154f6015516762800d13d6 Stats: 176 lines in 4 files changed: 161 ins; 2 del; 13 mod 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM 8309231: ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java 8309171: Test vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java fails after JDK-8308341 Reviewed-by: phh Backport-of: 1e6770fb978e630b38a70a05120c50f723bb66dc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3084 From sgehwolf at openjdk.org Wed Dec 4 08:39:49 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Dec 2024 08:39:49 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 15:26:56 GMT, Kerem Kat wrote: >> Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. >> >> It fixes crashes when accessing jmethodIDs of a class being unloaded. >> >> Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). >> >> This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. >> >> To run the repro: >> >> >> javac Main.java >> gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so >> >> java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main > > cc @coleenp @fisk @krk @shipilev Andrew Haley has approved this PR. Do you plan to integrate it? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2935#issuecomment-2516553692 From sgehwolf at openjdk.org Wed Dec 4 08:46:40 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Dec 2024 08:46:40 GMT Subject: [jdk21u-dev] RFR: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() In-Reply-To: References: Message-ID: <90-mdLN6aZONGfNP7PzDRdUvwXDMqZEg2zlnqfVHRLM=.0741feb4-1c14-475c-ba79-c9da7cfaefee@github.com> On Tue, 5 Nov 2024 08:53:40 GMT, Roland Westrelin wrote: >> Hi @rwestrel, should we target 21.0.7 as oracle does? This has no coverage in a released version yet and is brand new. > > @GoeLin that would be fine with me. What would be the process then? Do I need to close this one for now and re-apply for approval later on? jdk21u-dev is now 21.0.7 development. Approved. Feel free to integrate @rwestrel ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1122#issuecomment-2516568537 From sgehwolf at openjdk.org Wed Dec 4 09:15:24 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Dec 2024 09:15:24 GMT Subject: [jdk11u-dev] RFR: 8345466: Bump update version for OpenJDK: jdk-11.0.27 Message-ID: Mandatory version bump for the April 2025 cycle. ------------- Commit messages: - 8345466: Bump update version for OpenJDK: jdk-11.0.27 Changes: https://git.openjdk.org/jdk11u-dev/pull/2974/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2974&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345466 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2974.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2974/head:pull/2974 PR: https://git.openjdk.org/jdk11u-dev/pull/2974 From duke at openjdk.org Wed Dec 4 10:35:41 2024 From: duke at openjdk.org (Kerem Kat) Date: Wed, 4 Dec 2024 10:35:41 GMT Subject: [jdk11u-dev] Integrated: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Wed, 18 Sep 2024 15:10:33 GMT, Kerem Kat wrote: > Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. > > It fixes crashes when accessing jmethodIDs of a class being unloaded. > > Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). > > This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. > > To run the repro: > > > javac Main.java > gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so > > java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main This pull request has now been integrated. Changeset: 50da3f66 Author: Kerem Kat Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/50da3f663a52255bc17b72ab78709b34d635dd7a Stats: 31 lines in 2 files changed: 20 ins; 9 del; 2 mod 8268364: jmethod clearing should be done during unloading Reviewed-by: coleenp Backport-of: 3d84398d128bb2eed6280ebbc3f57afb3b89908f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2935 From goetz at openjdk.org Wed Dec 4 10:56:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 10:56:56 GMT Subject: [jdk17u-dev] RFR: 8319569: Several java/util tests should be updated to accept VM flags Message-ID: I backport this for parity with 17.0.15-oracle. I skipped PropertiesTest.sh to PropertiesTestRun.java as the test was refactored by backport of "8210410: Refactor java.util.Currency:i18n shell tests to plain java tests" which already includes the fix of this change. MissingResourceCauseTestRun.java: Copyright. ------------- Commit messages: - Backport 2bb4b9398d65e3f37f34e45476c969ff0afb1540 Changes: https://git.openjdk.org/jdk17u-dev/pull/3086/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3086&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319569 Stats: 178 lines in 11 files changed: 20 ins; 42 del; 116 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3086.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3086/head:pull/3086 PR: https://git.openjdk.org/jdk17u-dev/pull/3086 From goetz at openjdk.org Wed Dec 4 11:11:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 11:11:16 GMT Subject: [jdk17u-dev] RFR: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d53a06 Changes: https://git.openjdk.org/jdk17u-dev/pull/3087/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3087&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319647 Stats: 14 lines in 7 files changed: 7 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3087.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3087/head:pull/3087 PR: https://git.openjdk.org/jdk17u-dev/pull/3087 From goetz at openjdk.org Wed Dec 4 11:29:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 11:29:53 GMT Subject: [jdk17u-dev] RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump Message-ID: I backport this for parity with 17.0.15-oracle. Trivial resolve. 21 has some additional documentation lines. ------------- Commit messages: - Backport 16d917a85f9311611a14a63f1e53afae970efc73 Changes: https://git.openjdk.org/jdk17u-dev/pull/3088/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3088&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313710 Stats: 106 lines in 2 files changed: 0 ins; 0 del; 106 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3088.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3088/head:pull/3088 PR: https://git.openjdk.org/jdk17u-dev/pull/3088 From goetz at openjdk.org Wed Dec 4 11:48:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 11:48:13 GMT Subject: [jdk17u-dev] RFR: 8319673: Few security tests ignore VM flags Message-ID: I backport this for parity with 17.0.15-oracle. ConfigFileTest uses new Java calls, adapted to Java 17. See extra commit. ------------- Commit messages: - Adapt test to Java 17 - Backport 430290066c23d09166a84f2f6f89e770c6ba04ff Changes: https://git.openjdk.org/jdk17u-dev/pull/3089/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3089&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319673 Stats: 49 lines in 3 files changed: 12 ins; 13 del; 24 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3089.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3089/head:pull/3089 PR: https://git.openjdk.org/jdk17u-dev/pull/3089 From goetz at openjdk.org Wed Dec 4 12:23:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 12:23:11 GMT Subject: [jdk17u-dev] RFR: 8319648: java/lang/SecurityManager tests ignore vm flags Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 437cf354e2d1f7df79fa32265ccf86a0e84257b5 Changes: https://git.openjdk.org/jdk17u-dev/pull/3090/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3090&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319648 Stats: 9 lines in 2 files changed: 1 ins; 3 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3090.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3090/head:pull/3090 PR: https://git.openjdk.org/jdk17u-dev/pull/3090 From goetz at openjdk.org Wed Dec 4 12:31:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 12:31:56 GMT Subject: [jdk21u-dev] RFR: 8327857: Remove applet usage from JColorChooser tests Test4222508 Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport 7c6fd337d00d4bdeaac724a6ea26fac3654846e0 Changes: https://git.openjdk.org/jdk21u-dev/pull/1199/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1199&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327857 Stats: 76 lines in 2 files changed: 22 ins; 40 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1199.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1199/head:pull/1199 PR: https://git.openjdk.org/jdk21u-dev/pull/1199 From goetz at openjdk.org Wed Dec 4 12:33:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 12:33:13 GMT Subject: [jdk17u-dev] RFR: 8327857: Remove applet usage from JColorChooser tests Test4222508 Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 7c6fd337d00d4bdeaac724a6ea26fac3654846e0 Changes: https://git.openjdk.org/jdk17u-dev/pull/3091/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3091&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327857 Stats: 76 lines in 2 files changed: 22 ins; 40 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3091.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3091/head:pull/3091 PR: https://git.openjdk.org/jdk17u-dev/pull/3091 From sgehwolf at openjdk.org Wed Dec 4 12:57:48 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Dec 2024 12:57:48 GMT Subject: [jdk11u-dev] RFR: 8345466: Bump update version for OpenJDK: jdk-11.0.27 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 09:10:21 GMT, Severin Gehwolf wrote: > Mandatory version bump for the April 2025 cycle. PTAL @gnu-andrew ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2974#issuecomment-2517272071 From goetz at openjdk.org Wed Dec 4 13:14:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 13:14:49 GMT Subject: [jdk17u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic Message-ID: I backport this for parity with 17.0.15-oracle. Config.java: Resolve and adapt because of unsupported switch syntax. SunPKCS11.java: I had to resolve becuase "8301553: Support Password-Based Cryptography in SunPKCS11" is not in 17. Context code has different control flow. Patched code is unchanged. ------------- Commit messages: - Backport 1b476f52ba85f9ceaabe785d36cb07df831fd0e8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3092/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3092&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293345 Stats: 51 lines in 2 files changed: 25 ins; 25 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3092.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3092/head:pull/3092 PR: https://git.openjdk.org/jdk17u-dev/pull/3092 From goetz at openjdk.org Wed Dec 4 13:15:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 13:15:15 GMT Subject: [jdk21u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport 1b476f52ba85f9ceaabe785d36cb07df831fd0e8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1200/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1200&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293345 Stats: 51 lines in 2 files changed: 25 ins; 25 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1200.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1200/head:pull/1200 PR: https://git.openjdk.org/jdk21u-dev/pull/1200 From goetz at openjdk.org Wed Dec 4 13:29:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 13:29:55 GMT Subject: [jdk17u-dev] RFR: 8334490: Normalize string with locale invariant `toLowerCase()` Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 265a0f5547d0ddb220391aef679c122768f02a00 Changes: https://git.openjdk.org/jdk17u-dev/pull/3093/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3093&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334490 Stats: 7 lines in 1 file changed: 1 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3093.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3093/head:pull/3093 PR: https://git.openjdk.org/jdk17u-dev/pull/3093 From goetz at openjdk.org Wed Dec 4 14:06:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:06:17 GMT Subject: [jdk17u-dev] RFR: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 3733fe3a207078b585421cd2a098e808fafaa817 Changes: https://git.openjdk.org/jdk17u-dev/pull/3094/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3094&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335789 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3094.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3094/head:pull/3094 PR: https://git.openjdk.org/jdk17u-dev/pull/3094 From goetz at openjdk.org Wed Dec 4 14:06:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:06:53 GMT Subject: [jdk21u-dev] RFR: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport 3733fe3a207078b585421cd2a098e808fafaa817 Changes: https://git.openjdk.org/jdk21u-dev/pull/1201/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1201&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335789 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1201.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1201/head:pull/1201 PR: https://git.openjdk.org/jdk21u-dev/pull/1201 From goetz at openjdk.org Wed Dec 4 14:12:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:12:50 GMT Subject: [jdk17u-dev] RFR: 8336012: Fix usages of jtreg-reserved properties Message-ID: <9-ML6S4VPDf4xkan-T8hGo8eYqWg0aw1oYE2PgJxmNY=.3b8d2021-3b80-4be5-9b6a-e36e04faf173@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport e6c5aa7a6cb54c647d261facdcffa6a410849627 Changes: https://git.openjdk.org/jdk17u-dev/pull/3095/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3095&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336012 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3095.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3095/head:pull/3095 PR: https://git.openjdk.org/jdk17u-dev/pull/3095 From goetz at openjdk.org Wed Dec 4 14:24:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:24:53 GMT Subject: [jdk21u-dev] RFR: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep Message-ID: I backport this for parity with 21.0.7-oracle. Resolved. Several virtual threads changes touched this file. ------------- Commit messages: - Backport ed6499446dadc339599271a282ceca4a52dbeed4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1202/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1202&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333391 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1202.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1202/head:pull/1202 PR: https://git.openjdk.org/jdk21u-dev/pull/1202 From szaldana at openjdk.org Wed Dec 4 14:26:51 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 4 Dec 2024 14:26:51 GMT Subject: [jdk21u-dev] Integrated: 8327390: JitTester: Implement temporary folder functionality In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 20:25:14 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [5aae8030](https://github.com/openjdk/jdk/commit/5aae80304c0b1b49341777b9da103638183877d5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Evgeny Nikitin on 7 Mar 2024 and was reviewed by Guoxiong Li and Leonid Mesnik. > > Thanks! This pull request has now been integrated. Changeset: f7ba9cc7 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/f7ba9cc7d6df770de32c55d3bbeb639e69782968 Stats: 76 lines in 4 files changed: 63 ins; 4 del; 9 mod 8327390: JitTester: Implement temporary folder functionality Backport-of: 5aae80304c0b1b49341777b9da103638183877d5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1193 From szaldana at openjdk.org Wed Dec 4 14:27:51 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 4 Dec 2024 14:27:51 GMT Subject: [jdk21u-dev] Integrated: 8331993: Add counting leading/trailing zero tests for Integer In-Reply-To: References: Message-ID: <4SI_WPAsAOZR3FtQvJt0ljo7mTibAPpyn8hisaqFu-Q=.fc821d98-91d5-4775-be1e-62cfcee8bcc5@github.com> On Mon, 2 Dec 2024 20:58:47 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [675fbe69](https://github.com/openjdk/jdk/commit/675fbe699ed1aad37f34429cbe1f4f3e029be03f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Hamlin Li on 10 May 2024 and was reviewed by Christian Hagedorn. > > Thanks! This pull request has now been integrated. Changeset: 64f02636 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/64f02636f84f3f0217c8e690708d0defcbcf7091 Stats: 67 lines in 3 files changed: 44 ins; 0 del; 23 mod 8331993: Add counting leading/trailing zero tests for Integer Backport-of: 675fbe699ed1aad37f34429cbe1f4f3e029be03f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1194 From szaldana at openjdk.org Wed Dec 4 14:29:43 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 4 Dec 2024 14:29:43 GMT Subject: [jdk21u-dev] Integrated: 8336012: Fix usages of jtreg-reserved properties In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 21:12:34 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [e6c5aa7a](https://github.com/openjdk/jdk/commit/e6c5aa7a6cb54c647d261facdcffa6a410849627) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christian Stein on 10 Jul 2024 and was reviewed by Jonathan Gibbons. > > Thanks! This pull request has now been integrated. Changeset: 2909f65d Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/2909f65dd12d1bd8ca24a2e5ae530bd3bba99c4b Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8336012: Fix usages of jtreg-reserved properties Backport-of: e6c5aa7a6cb54c647d261facdcffa6a410849627 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1196 From szaldana at openjdk.org Wed Dec 4 14:29:49 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 4 Dec 2024 14:29:49 GMT Subject: [jdk21u-dev] Integrated: 8334490: Normalize string with locale invariant `toLowerCase()` In-Reply-To: <6rEu0CTVNJYCS8ID9zgtgAduIcEP_Ldp-kFy0Fo4QnI=.332a52c7-6ced-4faf-a1dc-80ba19e1eea7@github.com> References: <6rEu0CTVNJYCS8ID9zgtgAduIcEP_Ldp-kFy0Fo4QnI=.332a52c7-6ced-4faf-a1dc-80ba19e1eea7@github.com> Message-ID: On Mon, 2 Dec 2024 21:28:51 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [265a0f55](https://github.com/openjdk/jdk/commit/265a0f5547d0ddb220391aef679c122768f02a00) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Naoto Sato on 20 Jun 2024 and was reviewed by Justin Lu, Daniel Fuchs, Lance Andersen and Roger Riggs. > > Thanks! This pull request has now been integrated. Changeset: eb295799 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/eb29579949f64a5f789939b482ecf3e9272fbf8c Stats: 7 lines in 1 file changed: 1 ins; 0 del; 6 mod 8334490: Normalize string with locale invariant `toLowerCase()` Backport-of: 265a0f5547d0ddb220391aef679c122768f02a00 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1197 From szaldana at openjdk.org Wed Dec 4 14:32:47 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 4 Dec 2024 14:32:47 GMT Subject: [jdk21u-dev] Integrated: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java In-Reply-To: References: Message-ID: <_pxSW32EcE-0RUf0OWqNauSI2IGlMmUSL7tJ7r2pXq0=.24884be2-cb7f-43bd-9232-9c0ee1845183@github.com> On Mon, 2 Dec 2024 21:04:49 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [f927c121](https://github.com/openjdk/jdk/commit/f927c1210ee0675bb1196572177ffb505826d57a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Eirik Bj?rsn?s on 30 Aug 2024 and was reviewed by Lance Andersen. > > Thanks! This pull request has now been integrated. Changeset: c2c40df1 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/c2c40df1156b860694d532996228144963bad069 Stats: 119 lines in 1 file changed: 76 ins; 9 del; 34 mod 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java Backport-of: f927c1210ee0675bb1196572177ffb505826d57a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1195 From goetz at openjdk.org Wed Dec 4 14:37:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:37:52 GMT Subject: [jdk17u-dev] RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Message-ID: <5y1Nz5A_ZRLZ90akhio4IzpMBJTQqyYhYiMFsILlpBo=.f63be56d-5ddc-4a50-befe-932d95c8a34d@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3096/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3096&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335172 Stats: 17 lines in 3 files changed: 13 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3096.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3096/head:pull/3096 PR: https://git.openjdk.org/jdk17u-dev/pull/3096 From goetz at openjdk.org Wed Dec 4 14:44:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:44:08 GMT Subject: [jdk17u-dev] RFR: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F Message-ID: I backport this for parity with 17.0.15-oracle. Resolved Copyright, probably clean. ------------- Commit messages: - Backport b8e8e965e541881605f9dbcd4d9871d4952b9232 Changes: https://git.openjdk.org/jdk17u-dev/pull/3097/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3097&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338668 Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3097.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3097/head:pull/3097 PR: https://git.openjdk.org/jdk17u-dev/pull/3097 From goetz at openjdk.org Wed Dec 4 14:46:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:46:13 GMT Subject: [jdk21u-dev] RFR: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F Message-ID: <-kkWSuXIo69yIyKjDZnsjBZKbp03d9ZZ4fJHSK4duXQ=.7816c450-9c5f-4f38-8f6b-902774023e3d@github.com> I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport b8e8e965e541881605f9dbcd4d9871d4952b9232 Changes: https://git.openjdk.org/jdk21u-dev/pull/1203/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1203&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338668 Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1203.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1203/head:pull/1203 PR: https://git.openjdk.org/jdk21u-dev/pull/1203 From goetz at openjdk.org Wed Dec 4 14:53:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:53:11 GMT Subject: [jdk21u-dev] RFR: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport a505a1dda3bc6975bb11f390543b38618ddf2626 Changes: https://git.openjdk.org/jdk21u-dev/pull/1204/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1204&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337951 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1204.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1204/head:pull/1204 PR: https://git.openjdk.org/jdk21u-dev/pull/1204 From goetz at openjdk.org Wed Dec 4 14:53:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:53:17 GMT Subject: [jdk17u-dev] RFR: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java Message-ID: <68IcYKnZMJyt7UrnEAq4jsD5K2L81JB5GB7kPq9KXJE=.08fdec72-7f4e-4a3a-8569-8249a28f56ed@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport f927c1210ee0675bb1196572177ffb505826d57a Changes: https://git.openjdk.org/jdk17u-dev/pull/3098/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3098&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339154 Stats: 119 lines in 1 file changed: 76 ins; 9 del; 34 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3098.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3098/head:pull/3098 PR: https://git.openjdk.org/jdk17u-dev/pull/3098 From goetz at openjdk.org Wed Dec 4 14:54:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 14:54:15 GMT Subject: [jdk17u-dev] RFR: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport a505a1dda3bc6975bb11f390543b38618ddf2626 Changes: https://git.openjdk.org/jdk17u-dev/pull/3099/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3099&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337951 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3099.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3099/head:pull/3099 PR: https://git.openjdk.org/jdk17u-dev/pull/3099 From roland at openjdk.org Wed Dec 4 15:06:43 2024 From: roland at openjdk.org (Roland Westrelin) Date: Wed, 4 Dec 2024 15:06:43 GMT Subject: [jdk21u-dev] Integrated: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 13:47:36 GMT, Roland Westrelin wrote: > clean backport of JDK-8340824 This pull request has now been integrated. Changeset: 1f6b4011 Author: Roland Westrelin URL: https://git.openjdk.org/jdk21u-dev/commit/1f6b4011cf163fdcffb3a40995765e6bbc099e46 Stats: 89 lines in 2 files changed: 14 ins; 11 del; 64 mod 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() Backport-of: 90c944fefe4a7827c08a8e6a81f137c3157a749b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1122 From goetz at openjdk.org Wed Dec 4 15:07:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 15:07:14 GMT Subject: [jdk21u-dev] RFR: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java Message-ID: <5-R-LygXQzqBhdfLi4XhFYvG2W5XZQX0sEqVpbirvzU=.78a39061-1350-4f7c-882e-e47067f5531d@github.com> I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 1447967f53fe27f67e4bb766464f941e39506d41 Changes: https://git.openjdk.org/jdk21u-dev/pull/1205/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1205&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339261 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1205.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1205/head:pull/1205 PR: https://git.openjdk.org/jdk21u-dev/pull/1205 From goetz at openjdk.org Wed Dec 4 15:08:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 15:08:56 GMT Subject: [jdk17u-dev] RFR: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 1447967f53fe27f67e4bb766464f941e39506d41 Changes: https://git.openjdk.org/jdk17u-dev/pull/3100/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339261 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3100.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3100/head:pull/3100 PR: https://git.openjdk.org/jdk17u-dev/pull/3100 From goetz at openjdk.org Wed Dec 4 15:11:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 15:11:14 GMT Subject: [jdk17u-dev] RFR: 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport e94e3bba3932f3d92c0a135d333d1ccd6e72b964 Changes: https://git.openjdk.org/jdk17u-dev/pull/3101/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3101&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324672 Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3101.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3101/head:pull/3101 PR: https://git.openjdk.org/jdk17u-dev/pull/3101 From goetz at openjdk.org Wed Dec 4 15:13:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 4 Dec 2024 15:13:12 GMT Subject: [jdk21u-dev] RFR: 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport e94e3bba3932f3d92c0a135d333d1ccd6e72b964 Changes: https://git.openjdk.org/jdk21u-dev/pull/1206/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1206&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324672 Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1206.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1206/head:pull/1206 PR: https://git.openjdk.org/jdk21u-dev/pull/1206 From andrew at openjdk.org Wed Dec 4 16:24:52 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 16:24:52 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading In-Reply-To: References: Message-ID: On Thu, 19 Sep 2024 15:26:56 GMT, Kerem Kat wrote: >> Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. >> >> It fixes crashes when accessing jmethodIDs of a class being unloaded. >> >> Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). >> >> This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. >> >> To run the repro: >> >> >> javac Main.java >> gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so >> >> java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main > > cc @coleenp @fisk > @krk @shipilev Andrew Haley has approved this PR. Do you plan to integrate it? This really should have waited until the rampdown changes were in place. I've manually moved this one to 11.0.27. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2935#issuecomment-2517923926 From rrich at openjdk.org Wed Dec 4 16:27:41 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 4 Dec 2024 16:27:41 GMT Subject: [jdk21u-dev] Integrated: 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR In-Reply-To: References: Message-ID: On Wed, 27 Nov 2024 11:00:25 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/ed6809666b12b0de66f68d5e7e389dde1708aaf3 from the openjdk/jdk repository. > > The commit being backported was authored by Richard Reingruber on 16 Oct 2024 and was reviewed by Martin Doerr and Matthias Baesken. > > The risk of the backport is low. It's small and therefore obvious that only `LM_MONITOR` is handled differently which is experimental anyway. > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. > > Thanks, Richard. This pull request has now been integrated. Changeset: 71bf10ed Author: Richard Reingruber URL: https://git.openjdk.org/jdk21u-dev/commit/71bf10ed8c012d9b202ef82bdd0bc0af585125e9 Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR Backport-of: ed6809666b12b0de66f68d5e7e389dde1708aaf3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1186 From duke at openjdk.org Wed Dec 4 16:28:53 2024 From: duke at openjdk.org (Kerem Kat) Date: Wed, 4 Dec 2024 16:28:53 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading [v2] In-Reply-To: References: Message-ID: On Mon, 30 Sep 2024 16:42:03 GMT, Kerem Kat wrote: >> Backport of [8268364](https://bugs.openjdk.org/browse/JDK-8268364), single hunk conflict resolved by accepting "empty" from the backport commit vs. `clear_jmethod_ids` invocation in the dtor. Backport commit moves the `clear_jmethod_ids` invocation to `unload` method instead. >> >> It fixes crashes when accessing jmethodIDs of a class being unloaded. >> >> Here is the reproducer that crashes JVM in ~1 second without the patch, but works fine with it: [gist](https://gist.github.com/krk/a0800bac5bc5a01709be85637285a965). >> >> This fix also resolves the issue reported at https://github.com/async-profiler/async-profiler/issues/974 for Java 11. >> >> To run the repro: >> >> >> javac Main.java >> gcc -shared -I"$JAVA_HOME/include" -I"$JAVA_HOME/include/linux" -fPIC repro.cpp -orepro.so >> >> java -agentpath:"$(pwd)/repro.so" -Xmx100m -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:+ExplicitGCInvokesConcurrent Main > > Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into JDK-8268364-jmethodid-fix > - Backport 3d84398d128bb2eed6280ebbc3f57afb3b89908f Sorry for the confusion, thanks for moving it. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2935#issuecomment-2517944928 From gnu.andrew at redhat.com Wed Dec 4 16:38:34 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 4 Dec 2024 16:38:34 +0000 Subject: [RAMPDOWN] 11.0.26 Now in Rampdown Stage Message-ID: 11.0.26 is in rampdown for release in January 2025. jdk11u-dev is CLOSED for commits until https://bugs.openjdk.org/browse/JDK-8345509 is integrated to begin the 11.0.27 release cycle. For critical fixes (i.e. regressions or urgent fixes like tzdata & cacerts updates) for 11.0.26, please file a PR against https://github.com/openjdk/jdk11u and use jdk11u-critical-request to obtain approval to push (automatic with the /approval request command [0]). [0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Wed Dec 4 16:38:57 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 16:38:57 GMT Subject: [jdk11u-dev] RFR: 8268364: jmethod clearing should be done during unloading [v2] In-Reply-To: References: Message-ID: <2PCO8LxeUbbeh9aGje4v5_maxzjratMOe-s1Whpsd-0=.0975215c-469a-4938-b45d-ac957197feb5@github.com> On Wed, 4 Dec 2024 16:26:05 GMT, Kerem Kat wrote: > Sorry for the confusion, thanks for moving it. Thanks. I'm a little late in doing the transition myself with being away at the beginning of the week, but the right version should be used automatically once https://bugs.openjdk.org/browse/JDK-8345509 is integrated. I just thought you should be aware that this will be in the April release. The cut-off for January was Friday. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2935#issuecomment-2517971870 From andrew at openjdk.org Wed Dec 4 17:39:57 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 17:39:57 GMT Subject: [jdk11u-dev] RFR: 8345509: Bump update version of OpenJDK: 11.0.27 Message-ID: Rampdown for 11.0.26 [has begun](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-December/039745.html). 11u-dev needs to transition to 11.0.27. ------------- Commit messages: - 8345509: Bump update version of OpenJDK: 11.0.27 Changes: https://git.openjdk.org/jdk11u-dev/pull/2975/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2975&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345509 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2975.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2975/head:pull/2975 PR: https://git.openjdk.org/jdk11u-dev/pull/2975 From mdoerr at openjdk.org Wed Dec 4 17:51:45 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 4 Dec 2024 17:51:45 GMT Subject: [jdk21u-dev] RFR: 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking In-Reply-To: References: Message-ID: <3PBt_RL2t-IT7rZvIVFxuZACnEXl-uV7linukVffF4c=.a942dd51-f186-4b52-ac49-f3d388675a02@github.com> On Mon, 2 Dec 2024 16:45:46 GMT, Richard Reingruber wrote: > Backport of https://github.com/openjdk/jdk/commit/f9208fadde8141e18a025ddb6ce28423861ba391 > > The change removes instructions that check if an ObjectMonitor is owned by the current thread before unlocking it in a c1/c2 compiled nmethod. > > The check is imprecise. It can fail if the lock was inflated into an ObjectMonitor by another thread. > It is also redundant since only bytecode with symmetric locking operations is compiled. > See JBS-Issue for details. > > Note that there existed a special diagnostic locking mode to do the same check also on x86. Purpose was to protect against missbehaving JNI code. It got removed though with [JDK-8210381](https://bugs.openjdk.org/browse/JDK-8210381) in jdk12. On ppc64le it was not removed as the check was done in default mode as well (unclear why). > > The fix didn't apply because in jdk21 there is still just one method to handle LM_LEGACY and LM_LIGHTWEIGHT and LM_LIGHTWEIGHT requires the owner check to handle ANONYMOUS owner. Also RTM is still supported in jdk21. > > I'd consider the risk low. Aside from the assertions, the change is very small and it just brings ppc64 in line with how unlocking is done on other platforms. > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. Looks correct. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1191#pullrequestreview-2479479345 From amitkumar at openjdk.org Wed Dec 4 23:35:44 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 4 Dec 2024 23:35:44 GMT Subject: [jdk23u] Integrated: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR In-Reply-To: References: Message-ID: On Wed, 27 Nov 2024 08:16:48 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [9201e9fc](https://github.com/openjdk/jdk/commit/9201e9fcc28cff37cf9996e8db38f9aee7511b1c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 18 Oct 2024 and was reviewed by Richard Reingruber and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: 1d258ba6 Author: Amit Kumar Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/1d258ba6b08d73cf4bace0a9ed72437882354fba Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR Backport-of: 9201e9fcc28cff37cf9996e8db38f9aee7511b1c ------------- PR: https://git.openjdk.org/jdk23u/pull/229 From phh at openjdk.org Wed Dec 4 23:35:52 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 4 Dec 2024 23:35:52 GMT Subject: [jdk21u-dev] RFR: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 In-Reply-To: References: Message-ID: <0NBNSnz8SvUmWcAFpafpuK_G6NC_TUf6tw_Vu1PSlf4=.7ef0a4e9-1e92-4fd3-a100-9d8b29e01acd@github.com> On Wed, 20 Nov 2024 19:40:14 GMT, Chad Rakoczy wrote: > Backport [JDK-8341194](https://bugs.openjdk.org/browse/JDK-8341194) [REDO] Implement C2 VectorizedHashCode on AArch64 > > Backport is clean. Trivial merge conflicts with includes and already present code. Original implementation [JDK-8322770](https://bugs.openjdk.org/browse/JDK-8322770) caused build and test failures. Build failures that were reproducible with `make bootcycle-images` run on `linux-aarch64 fastdebug/release` successfully. All jtreg and new asmtest pass on `linux-aarch64 release`. Reasonable. :) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1170#issuecomment-2518770391 From amitkumar at openjdk.org Wed Dec 4 23:40:48 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 4 Dec 2024 23:40:48 GMT Subject: [jdk23u] Integrated: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java In-Reply-To: References: Message-ID: On Mon, 18 Nov 2024 04:53:38 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [3245f56e](https://github.com/openjdk/jdk/commit/3245f56e53792b3cfc9788799ba1594d6af15bea) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 15 Nov 2024 and was reviewed by Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: cb43c266 Author: Amit Kumar Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/cb43c26600539b563131533c768507e670cc368d Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java Backport-of: 3245f56e53792b3cfc9788799ba1594d6af15bea ------------- PR: https://git.openjdk.org/jdk23u/pull/226 From amitkumar at openjdk.org Wed Dec 4 23:40:48 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 4 Dec 2024 23:40:48 GMT Subject: [jdk23u] Integrated: 8319947: Recursive lightweight locking: s390x implementation In-Reply-To: References: Message-ID: <_CfTpcJBx5qMJswk3ouOYxN0-0-L-gbtvUJY4aNJEtw=.1e677523-2723-46eb-85e9-63326f145d9b@github.com> On Mon, 11 Nov 2024 14:34:25 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d457609f](https://github.com/openjdk/jdk/commit/d457609f700bbb1fed233f1a04501c995852e5ac) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 28 Jun 2024 and was reviewed by Axel Boldt-Christmas and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: 38dc6db8 Author: Amit Kumar Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/38dc6db8145fb6a9834c857e2c56256bf589d708 Stats: 553 lines in 9 files changed: 426 ins; 64 del; 63 mod 8319947: Recursive lightweight locking: s390x implementation Backport-of: d457609f700bbb1fed233f1a04501c995852e5ac ------------- PR: https://git.openjdk.org/jdk23u/pull/221 From amitkumar at openjdk.org Wed Dec 4 23:41:45 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 4 Dec 2024 23:41:45 GMT Subject: [jdk23u] Integrated: 8336012: Fix usages of jtreg-reserved properties In-Reply-To: References: Message-ID: On Tue, 12 Nov 2024 03:08:38 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [e6c5aa7a](https://github.com/openjdk/jdk/commit/e6c5aa7a6cb54c647d261facdcffa6a410849627) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > `test/jdk/java/lang/invoke/PrivateInvokeTest.java` is failing on s390x JDK23 - CI consistently. error: > > > STDERR: > STARTED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' > java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" > at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) > at java.base/java.lang.Integer.parseInt(Integer.java:588) > at java.base/java.lang.Integer.parseInt(Integer.java:685) > at test.java.lang.invoke.PrivateInvokeTest.(PrivateInvokeTest.java:72) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) > at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) > FAILED test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' [60ms] > STARTED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' > java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]" > at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) > at java.base/java.lang.Integer.parseInt(Integer.java:588) > at java.base/java.lang.Integer.parseInt(Integer.java:685) > at test.java.lang.invoke.PrivateInvokeTest.(PrivateInvokeTest.java:72) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501) > at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485) > FAILED test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' [4ms] > JavaTest Message: JUnit Platform Failure(s): 2 > > [ JUnit Containers: found 4, started 4, succeeded 4, failed 0, aborted 0, skipped 0] > [ JUnit Tests: found 2, started 2, succeeded 0, failed 2, aborted 0, skipped 0] > > java.lang.Exception: JUnit test failure > at com.sun.javatest.regtest.agent.JUnitRunner.runWithJUnitPlatform(JUnitRunner.java:155) > at com.sun.javatest.regtest.agent.JUnitRunner.main(JUnitRunner.java:99) > at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333) > at java.base/java.lang.Thread.run(Thre... This pull request has now been integrated. Changeset: 9101cc14 Author: Amit Kumar Committer: Paul Hohensee URL: https://git.openjdk.org/jdk23u/commit/9101cc14972ce6bdeb966e67bcacc8b693c37d0a Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8336012: Fix usages of jtreg-reserved properties Backport-of: e6c5aa7a6cb54c647d261facdcffa6a410849627 ------------- PR: https://git.openjdk.org/jdk23u/pull/222 From rrich at openjdk.org Thu Dec 5 08:08:44 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 5 Dec 2024 08:08:44 GMT Subject: [jdk21u-dev] RFR: 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 16:45:46 GMT, Richard Reingruber wrote: > Backport of https://github.com/openjdk/jdk/commit/f9208fadde8141e18a025ddb6ce28423861ba391 > > The change removes instructions that check if an ObjectMonitor is owned by the current thread before unlocking it in a c1/c2 compiled nmethod. > > The check is imprecise. It can fail if the lock was inflated into an ObjectMonitor by another thread. > It is also redundant since only bytecode with symmetric locking operations is compiled. > See JBS-Issue for details. > > Note that there existed a special diagnostic locking mode to do the same check also on x86. Purpose was to protect against missbehaving JNI code. It got removed though with [JDK-8210381](https://bugs.openjdk.org/browse/JDK-8210381) in jdk12. On ppc64le it was not removed as the check was done in default mode as well (unclear why). > > The fix didn't apply because in jdk21 there is still just one method to handle LM_LEGACY and LM_LIGHTWEIGHT and LM_LIGHTWEIGHT requires the owner check to handle ANONYMOUS owner. Also RTM is still supported in jdk21. > > I'd consider the risk low. Aside from the assertions, the change is very small and it just brings ppc64 in line with how unlocking is done on other platforms. > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. Danke f?r Deinen Review mit Approval. Eins reicht, oder? Gr??e, Richard. > Looks correct. Oh, oh, nicht korrekt, aber nicht unbedingt gut... ? From: Martin ***@***.***> Date: Wednesday, 4. December 2024 at 18:49 To: openjdk/jdk21u-dev ***@***.***> Cc: Reingruber, Richard ***@***.***>, Author ***@***.***> Subject: Re: [openjdk/jdk21u-dev] 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking (PR #1191) @TheRealMDoerr approved this pull request. Looks correct. ? Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***> ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1191#issuecomment-2519521381 From sgehwolf at openjdk.org Thu Dec 5 10:29:51 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 5 Dec 2024 10:29:51 GMT Subject: [jdk11u-dev] RFR: 8345466: Bump update version for OpenJDK: jdk-11.0.27 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 09:10:21 GMT, Severin Gehwolf wrote: > Mandatory version bump for the April 2025 cycle. Duplicate of #2975 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2974#issuecomment-2519893973 From sgehwolf at openjdk.org Thu Dec 5 10:29:51 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 5 Dec 2024 10:29:51 GMT Subject: [jdk11u-dev] Withdrawn: 8345466: Bump update version for OpenJDK: jdk-11.0.27 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 09:10:21 GMT, Severin Gehwolf wrote: > Mandatory version bump for the April 2025 cycle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2974 From sgehwolf at openjdk.org Thu Dec 5 10:30:47 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 5 Dec 2024 10:30:47 GMT Subject: [jdk11u-dev] RFR: 8345509: Bump update version of OpenJDK: 11.0.27 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 17:34:56 GMT, Andrew John Hughes wrote: > Rampdown for 11.0.26 [has begun](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-December/039745.html). 11u-dev needs to transition to 11.0.27. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2975#pullrequestreview-2481250130 From cushon at openjdk.org Thu Dec 5 16:25:49 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Thu, 5 Dec 2024 16:25:49 GMT Subject: [jdk21u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <1A8Pjqodey4brM-cndhW3u6TUyNDzospAEl8UmaGdN0=.8536dd69-12ea-445b-8fae-35ae640f02cb@github.com> References: <1A8Pjqodey4brM-cndhW3u6TUyNDzospAEl8UmaGdN0=.8536dd69-12ea-445b-8fae-35ae640f02cb@github.com> Message-ID: <-GpE48HyNqpwoLxkfy6PqCi7eXyEGXi546I6JlxSh2A=.83ac459b-8141-4f8e-9c66-3df9ae122724@github.com> On Tue, 5 Nov 2024 18:53:41 GMT, Liam Miller-Cushon wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero > Feel free to ask for assistance if you need help with progressing this pull request towards integration! Assistance progressing this pull request towards integration is welcome ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1037#issuecomment-2520822116 From andrew at openjdk.org Fri Dec 6 00:06:47 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Dec 2024 00:06:47 GMT Subject: [jdk11u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 23:04:54 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK17u > > The only trivial manual merge is for jar.properties because of JDK-8276766 and Main.java because of JDK-8266835 are not backported to JDK11 > > JTREG tests passed Backport also cherry-picks `OptionType.EXTRACT` from by [JDK-8173970](https://bugs.openjdk.org/browse/JDK-8173970). This is only mentioned in the obsolete 23u backport, but affects 11,17 & 21 when compared to trunk. I'll approve this once #2975 is integrated. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2970#pullrequestreview-2483298537 From yan at azul.com Fri Dec 6 07:02:08 2024 From: yan at azul.com (Yuri Nesterenko) Date: Fri, 6 Dec 2024 11:02:08 +0400 Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) Message-ID: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> I hereby nominate Alexey Bakhtin (abakhtin) [1] for the role of OpenJDK Updates Project Reviewer. Alexey has worked in the Azul JDK Team since 2016 and has contributed over 100 OpenJDK commits [2][3][4][5][6]. Alexey is a Committer in the JDK, JDK Updates, and JDK8 Updates Projects and a Member of the Vulnerability Group [7]. Votes are due by 21th December 2024, 17:00 UTC. Only current JDK Updates Reviewers [8] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [9]. Regards, Yuri [1] https://openjdk.java.net/census#abakhtin [2] https://github.com/openjdk/jdk21u-dev/commits/master?author=abakhtin%40openjdk.org [3] https://github.com/openjdk/jdk17u-dev/commits/master?author=abakhtin%40openjdk.org [4] https://github.com/openjdk/jdk15u-dev/commits/master?author=abakhtin%40openjdk.org [5] https://github.com/openjdk/jdk13u-dev/commits/master?author=abakhtin%40openjdk.org [6] https://github.com/openjdk/jdk11u-dev/commits/master?author=abakhtin%40openjdk.org [7] https://openjdk.org/census#vulnerability [8] https://openjdk.java.net/census#jdk-updates [9] https://openjdk.java.net/bylaws#three-vote-consensus From goetz.lindenmaier at sap.com Fri Dec 6 08:25:28 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 6 Dec 2024 08:25:28 +0000 Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) In-Reply-To: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> References: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> Message-ID: Vote: yes Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Yuri Nesterenko > Sent: Friday, December 6, 2024 8:02 AM > To: jdk-updates-dev at openjdk.org > Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) > > I hereby nominate Alexey Bakhtin (abakhtin) [1] for the role of OpenJDK > Updates Project Reviewer. > Alexey has worked in the Azul JDK Team since 2016 and > has contributed over 100 OpenJDK commits [2][3][4][5][6]. > Alexey is a Committer in the JDK, JDK Updates, and JDK8 Updates Projects and > a Member of the > Vulnerability Group [7]. > > Votes are due by 21th December 2024, 17:00 UTC. Only current JDK Updates > Reviewers [8] are eligible to > vote on this nomination. > Votes must be cast in the open by replying to this mailing list. For Three-Vote > Consensus voting > instructions, see [9]. > > Regards, > Yuri > > [1] > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenjd > k.java.net%2Fcensus%23abakhtin&data=05%7C02%7Cgoetz.lindenmaier%40s > ap.com%7Cc1c5cbaf5228477c4e7f08dd15c3f53e%7C42f7676cf455423c82f6dc > 2d99791af7%7C0%7C0%7C638690653580760893%7CUnknown%7CTWFpbGZ > sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIs > IkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Tj1hmZ8B926 > P%2BlEco6gScTtHHUU9cGpdmclaQomxRT4%3D&reserved=0 > [2] https://github.com/openjdk/jdk21u- > dev/commits/master?author=abakhtin%40openjdk.org > [3] https://github.com/openjdk/jdk17u- > dev/commits/master?author=abakhtin%40openjdk.org > [4] https://github.com/openjdk/jdk15u- > dev/commits/master?author=abakhtin%40openjdk.org > [5] https://github.com/openjdk/jdk13u- > dev/commits/master?author=abakhtin%40openjdk.org > [6] https://github.com/openjdk/jdk11u- > dev/commits/master?author=abakhtin%40openjdk.org > [7] https://openjdk.org/census#vulnerability > [8] > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenjd > k.java.net%2Fcensus%23jdk- > updates&data=05%7C02%7Cgoetz.lindenmaier%40sap.com%7Cc1c5cbaf5228 > 477c4e7f08dd15c3f53e%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0% > 7C638690653580778086%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGki > OnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy > fQ%3D%3D%7C0%7C%7C%7C&sdata=OYR4A0zwEiT9nsJk%2FkE3la4KGwbpJX > gcNfPytwogk0Q%3D&reserved=0 > [9] > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenjd > k.java.net%2Fbylaws%23three-vote- > consensus&data=05%7C02%7Cgoetz.lindenmaier%40sap.com%7Cc1c5cbaf52 > 28477c4e7f08dd15c3f53e%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0 > %7C638690653580789393%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG > kiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIj > oyfQ%3D%3D%7C0%7C%7C%7C&sdata=40YZVYMEvZsRzlEfpdgFGB7MEHKh% > 2BR%2FSxYZamOfk9Zk%3D&reserved=0 From goetz at openjdk.org Fri Dec 6 09:01:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 09:01:49 GMT Subject: [jdk17u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 13:10:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > Config.java: > Resolve and adapt because of unsupported switch syntax. > > SunPKCS11.java: I had to resolve becuase > "8301553: Support Password-Based Cryptography in SunPKCS11" > is not in 17. Context code has different control flow. > Patched code is unchanged. Hi @martinuy could you have a look at this change? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3092#issuecomment-2522558727 From goetz at openjdk.org Fri Dec 6 09:12:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 09:12:39 GMT Subject: [jdk17u-dev] RFR: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java In-Reply-To: References: Message-ID: <5lm_RigrrhnW8oE8NPJJkMc7U2LHGKsomVbmCbroOcs=.17a3d7bd-7bc8-4625-9960-72458dae7e5b@github.com> On Wed, 4 Dec 2024 15:02:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3100#issuecomment-2522596836 From goetz at openjdk.org Fri Dec 6 09:12:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 09:12:48 GMT Subject: [jdk21u-dev] RFR: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 14:00:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1201#issuecomment-2522597499 From goetz at openjdk.org Fri Dec 6 09:13:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 09:13:45 GMT Subject: [jdk17u-dev] RFR: 8319648: java/lang/SecurityManager tests ignore vm flags In-Reply-To: References: Message-ID: <08RuibvU04CETkcVGlLI6-3-RILp6_sIwjxCJexdfcM=.0da53f45-51c4-43e6-906c-f2964917d7be@github.com> On Wed, 4 Dec 2024 12:18:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3090#issuecomment-2522601644 From goetz at openjdk.org Fri Dec 6 09:13:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 09:13:47 GMT Subject: [jdk21u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 13:09:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1200#issuecomment-2522600450 From goetz at openjdk.org Fri Dec 6 09:14:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 09:14:48 GMT Subject: [jdk17u-dev] RFR: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags In-Reply-To: References: Message-ID: <3qw7NlU-xj_Cc1FnMhg77W8eQQRMaKuisevGpoxFIF0=.190e747f-422e-4ddf-b824-da5371059b88@github.com> On Wed, 4 Dec 2024 11:07:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3087#issuecomment-2522602351 From lucy at openjdk.org Fri Dec 6 09:21:49 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 6 Dec 2024 09:21:49 GMT Subject: [jdk21u-dev] RFR: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 14:19:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > Resolved. Several virtual threads changes touched this file. LGTM ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1202#pullrequestreview-2484148054 From lucy at openjdk.org Fri Dec 6 09:25:45 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 6 Dec 2024 09:25:45 GMT Subject: [jdk17u-dev] RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 11:24:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > Trivial resolve. 21 has some additional documentation lines. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3088#pullrequestreview-2484161223 From sgehwolf at openjdk.org Fri Dec 6 09:30:51 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 6 Dec 2024 09:30:51 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v5] In-Reply-To: References: Message-ID: <98NAl0GH9ajo3Ch14pVOob-yG4hZVBQrxCNQ-DoYhs4=.4f5bf0ee-7392-4dce-9079-0ec733f21370@github.com> On Thu, 28 Nov 2024 09:12:16 GMT, Antonio Vieiro wrote: > Next efforts should go to fix the Clhsdb test failure (adding log for the record). Agreed. Looks like a backport of https://bugs.openjdk.org/browse/JDK-8243455 would fix it (test only change). ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2522634505 From dcherepanov at azul.com Fri Dec 6 09:47:28 2024 From: dcherepanov at azul.com (Dmitry Cherepanov) Date: Fri, 6 Dec 2024 13:47:28 +0400 Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) In-Reply-To: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> References: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> Message-ID: <6711be2e-44fc-4d0f-80a0-84ccccf917e9@azul.com> Vote: yes On 06.12.24 11:02, Yuri Nesterenko wrote: > Caution: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > I hereby nominate Alexey Bakhtin (abakhtin) [1] for the role of > OpenJDK Updates Project Reviewer. > Alexey has worked in the Azul JDK Team since 2016 and > has contributed over 100 OpenJDK commits [2][3][4][5][6]. > Alexey is a Committer in the JDK, JDK Updates, and JDK8 Updates > Projects and a Member of the > Vulnerability Group [7]. > > Votes are due by 21th December 2024, 17:00 UTC. Only current JDK > Updates Reviewers [8] are eligible to > vote on this nomination. > Votes must be cast in the open by replying to this mailing list. For > Three-Vote Consensus voting > instructions, see [9]. > > Regards, > Yuri > > [1] https://openjdk.java.net/census#abakhtin > [2] > https://github.com/openjdk/jdk21u-dev/commits/master?author=abakhtin%40openjdk.org > [3] > https://github.com/openjdk/jdk17u-dev/commits/master?author=abakhtin%40openjdk.org > [4] > https://github.com/openjdk/jdk15u-dev/commits/master?author=abakhtin%40openjdk.org > [5] > https://github.com/openjdk/jdk13u-dev/commits/master?author=abakhtin%40openjdk.org > [6] > https://github.com/openjdk/jdk11u-dev/commits/master?author=abakhtin%40openjdk.org > [7] https://openjdk.org/census#vulnerability > [8] https://openjdk.java.net/census#jdk-updates > [9] https://openjdk.java.net/bylaws#three-vote-consensus > From mbaesken at openjdk.org Fri Dec 6 10:12:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 6 Dec 2024 10:12:38 GMT Subject: [jdk17u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 13:10:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > Config.java: > Resolve and adapt because of unsupported switch syntax. > > SunPKCS11.java: I had to resolve becuase > "8301553: Support Password-Based Cryptography in SunPKCS11" > is not in 17. Context code has different control flow. > Patched code is unchanged. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3092#pullrequestreview-2484267121 From lucy at openjdk.org Fri Dec 6 10:50:38 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 6 Dec 2024 10:50:38 GMT Subject: [jdk17u-dev] RFR: 8319673: Few security tests ignore VM flags In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 11:43:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > ConfigFileTest uses new Java calls, adapted to Java 17. See extra commit. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3089#pullrequestreview-2484351451 From lucy at openjdk.org Fri Dec 6 12:19:48 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 6 Dec 2024 12:19:48 GMT Subject: [jdk17u-dev] RFR: 8319569: Several java/util tests should be updated to accept VM flags In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 10:52:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I skipped PropertiesTest.sh to PropertiesTestRun.java as the > test was refactored by backport of "8210410: Refactor java.util.Currency:i18n shell tests to plain java tests" > which already includes the fix of this change. > > MissingResourceCauseTestRun.java: Copyright. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3086#pullrequestreview-2484695229 From yan at azul.com Fri Dec 6 13:28:51 2024 From: yan at azul.com (Yuri Nesterenko) Date: Fri, 6 Dec 2024 17:28:51 +0400 Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) In-Reply-To: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> References: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> Message-ID: <92eb4466-c26a-496d-9715-81c2a0af9fdd@azul.com> Vote: yes Thanks! --yan On 06.12.2024 11:02, Yuri Nesterenko wrote: > I hereby nominate Alexey Bakhtin (abakhtin) [1] for the role of OpenJDK Updates Project Reviewer. > Alexey has worked in the Azul JDK Team since 2016 and > has contributed over 100 OpenJDK commits [2][3][4][5][6]. > Alexey is a Committer in the JDK, JDK Updates, and JDK8 Updates Projects and a Member of the > Vulnerability Group [7]. > > Votes are due by 21th December 2024, 17:00 UTC. Only current JDK Updates Reviewers [8] are eligible to > vote on this nomination. > Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting > instructions, see [9]. > > Regards, > Yuri > > [1] https://openjdk.java.net/census#abakhtin > [2] https://github.com/openjdk/jdk21u-dev/commits/master?author=abakhtin%40openjdk.org > [3] https://github.com/openjdk/jdk17u-dev/commits/master?author=abakhtin%40openjdk.org > [4] https://github.com/openjdk/jdk15u-dev/commits/master?author=abakhtin%40openjdk.org > [5] https://github.com/openjdk/jdk13u-dev/commits/master?author=abakhtin%40openjdk.org > [6] https://github.com/openjdk/jdk11u-dev/commits/master?author=abakhtin%40openjdk.org > [7] https://openjdk.org/census#vulnerability > [8] https://openjdk.java.net/census#jdk-updates > [9] https://openjdk.java.net/bylaws#three-vote-consensus > From martin.doerr at sap.com Fri Dec 6 13:57:21 2024 From: martin.doerr at sap.com (Doerr, Martin) Date: Fri, 6 Dec 2024 13:57:21 +0000 Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) In-Reply-To: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> References: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> Message-ID: Vote: yes Best regards, Martin Von: jdk-updates-dev im Auftrag von Yuri Nesterenko Datum: Freitag, 6. Dezember 2024 um 08:02 An: jdk-updates-dev at openjdk.org Betreff: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) I hereby nominate Alexey Bakhtin (abakhtin) [1] for the role of OpenJDK Updates Project Reviewer. Alexey has worked in the Azul JDK Team since 2016 and has contributed over 100 OpenJDK commits [2][3][4][5][6]. Alexey is a Committer in the JDK, JDK Updates, and JDK8 Updates Projects and a Member of the Vulnerability Group [7]. Votes are due by 21th December 2024, 17:00 UTC. Only current JDK Updates Reviewers [8] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [9]. Regards, Yuri -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew at openjdk.org Fri Dec 6 14:48:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Dec 2024 14:48:43 GMT Subject: [jdk11u-dev] Integrated: 8345509: Bump update version of OpenJDK: 11.0.27 In-Reply-To: References: Message-ID: <9wrCqwy3aTGVBAZFVAUai96Gg5eXQq0DnQxvnYTHMTQ=.699f4cf7-995f-43a4-b612-0c9ebabaecc9@github.com> On Wed, 4 Dec 2024 17:34:56 GMT, Andrew John Hughes wrote: > Rampdown for 11.0.26 [has begun](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-December/039745.html). 11u-dev needs to transition to 11.0.27. This pull request has now been integrated. Changeset: 3b7bcdbd Author: Andrew John Hughes URL: https://git.openjdk.org/jdk11u-dev/commit/3b7bcdbd10665bbdc5015889d6c57345d69a4b6f Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8345509: Bump update version of OpenJDK: 11.0.27 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2975 From hohensee at amazon.com Fri Dec 6 15:28:39 2024 From: hohensee at amazon.com (Hohensee, Paul) Date: Fri, 6 Dec 2024 15:28:39 +0000 Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) Message-ID: <610C55BC-6D0A-4AD9-A30E-1842EC0C209B@amazon.com> Vote: yes ?On 12/5/24, 11:03 PM, "jdk-updates-dev on behalf of Yuri Nesterenko" on behalf of yan at azul.com > wrote: I hereby nominate Alexey Bakhtin (abakhtin) [1] for the role of OpenJDK Updates Project Reviewer. Alexey has worked in the Azul JDK Team since 2016 and has contributed over 100 OpenJDK commits [2][3][4][5][6]. Alexey is a Committer in the JDK, JDK Updates, and JDK8 Updates Projects and a Member of the Vulnerability Group [7]. Votes are due by 21th December 2024, 17:00 UTC. Only current JDK Updates Reviewers [8] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [9]. Regards, Yuri [1] https://openjdk.java.net/census#abakhtin [2] https://github.com/openjdk/jdk21u-dev/commits/master?author=abakhtin%40openjdk.org [3] https://github.com/openjdk/jdk17u-dev/commits/master?author=abakhtin%40openjdk.org [4] https://github.com/openjdk/jdk15u-dev/commits/master?author=abakhtin%40openjdk.org [5] https://github.com/openjdk/jdk13u-dev/commits/master?author=abakhtin%40openjdk.org [6] https://github.com/openjdk/jdk11u-dev/commits/master?author=abakhtin%40openjdk.org [7] https://openjdk.org/census#vulnerability [8] https://openjdk.java.net/census#jdk-updates [9] https://openjdk.java.net/bylaws#three-vote-consensus From liach at openjdk.org Fri Dec 6 17:04:13 2024 From: liach at openjdk.org (Chen Liang) Date: Fri, 6 Dec 2024 17:04:13 GMT Subject: [jdk21u-dev] RFR: 8343377: Performance regression in reflective invocation of native methods Message-ID: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> The reimplementation of core reflection with Method Handles blanket-forced all native methods to use the native accessor due to bootstrapping issues. However, these are already covered by a `VM.isJavaLangInvokeInited()` check, and this blanket enforcement causes performance regression in reflective invocation of native methods like `Object::hashCode` or `Thread::currentThread`. The patch is not clean due to the comment update to `useNativeAccessor` - it edits a previously added comment not in JDK 21. The code changes are all clean. ------------- Commit messages: - 8343377: Performance regression in reflective invocation of native methods Changes: https://git.openjdk.org/jdk21u-dev/pull/1207/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1207&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343377 Stats: 137 lines in 3 files changed: 122 ins; 2 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1207.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1207/head:pull/1207 PR: https://git.openjdk.org/jdk21u-dev/pull/1207 From liach at openjdk.org Fri Dec 6 17:04:13 2024 From: liach at openjdk.org (Chen Liang) Date: Fri, 6 Dec 2024 17:04:13 GMT Subject: [jdk21u-dev] RFR: 8343377: Performance regression in reflective invocation of native methods In-Reply-To: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> References: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> Message-ID: On Fri, 6 Dec 2024 16:45:39 GMT, Chen Liang wrote: > The reimplementation of core reflection with Method Handles blanket-forced all native methods to use the native accessor due to bootstrapping issues. However, these are already covered by a `VM.isJavaLangInvokeInited()` check, and this blanket enforcement causes performance regression in reflective invocation of native methods like `Object::hashCode` or `Thread::currentThread`. > > The patch is not clean due to the comment update to `useNativeAccessor` - it edits a previously added comment not in JDK 21. The code changes are all clean. Can anyone help run higher-tier tests besides those available from GHA? I will write an approval request after. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1207#issuecomment-2523746605 From abakhtin at openjdk.org Fri Dec 6 17:35:51 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 6 Dec 2024 17:35:51 GMT Subject: [jdk11u-dev] Integrated: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 23:04:54 GMT, Alexey Bakhtin wrote: > Almost clean backport from JDK17u > > The only trivial manual merge is for jar.properties because of JDK-8276766 and Main.java because of JDK-8266835 are not backported to JDK11 > > JTREG tests passed This pull request has now been integrated. Changeset: bf34fd4d Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk11u-dev/commit/bf34fd4d415acf418da1667210c5175312fab224 Stats: 528 lines in 5 files changed: 526 ins; 0 del; 2 mod 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Reviewed-by: mbaesken, mbalao, andrew Backport-of: 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2970 From goetz at openjdk.org Fri Dec 6 19:35:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:35:46 GMT Subject: [jdk21u-dev] Integrated: 8327857: Remove applet usage from JColorChooser tests Test4222508 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 12:26:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: da281fa9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/da281fa9fba5d4dce98bbe16892ff820888f54d5 Stats: 76 lines in 2 files changed: 22 ins; 40 del; 14 mod 8327857: Remove applet usage from JColorChooser tests Test4222508 Backport-of: 7c6fd337d00d4bdeaac724a6ea26fac3654846e0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1199 From goetz at openjdk.org Fri Dec 6 19:37:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:37:45 GMT Subject: [jdk21u-dev] Integrated: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 14:00:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: a3788f24 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/a3788f2432c538f312edc9e56643bd3209db43ff Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ Backport-of: 3733fe3a207078b585421cd2a098e808fafaa817 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1201 From goetz at openjdk.org Fri Dec 6 19:38:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:38:47 GMT Subject: [jdk21u-dev] Integrated: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 14:19:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > Resolved. Several virtual threads changes touched this file. This pull request has now been integrated. Changeset: 739b5fb8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/739b5fb886ef828949b401810caabff6b7a8f827 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep Reviewed-by: lucy Backport-of: ed6499446dadc339599271a282ceca4a52dbeed4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1202 From goetz at openjdk.org Fri Dec 6 19:39:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:39:53 GMT Subject: [jdk17u-dev] Integrated: 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true' In-Reply-To: References: Message-ID: <-hk6uUxmwzBwPGQCwzDueO-EWSlnw-j_tNVA1uHayWU=.3125b5c0-97ec-454d-9988-d2a00a54a405@github.com> On Mon, 2 Dec 2024 09:01:52 GMT, Goetz Lindenmaier wrote: > I would like to backport this small bugfix. > > I had to resolve because "8284112: Minor cleanup could be done in javax.crypto" is not in 17. > Therefore the template parameters of the patched code differ: > this change: processedPermissions = new Hashtable<>(); > jdk17: processedPermissions = new Hashtable>(); > > Test passes. This pull request has now been integrated. Changeset: fc658cc3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fc658cc3d70285601ede3461b2961aadd405641a Stats: 104 lines in 2 files changed: 97 ins; 4 del; 3 mod 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true' Reviewed-by: mdoerr Backport-of: 8f400b9aab57d0639721add2ba511bfc0459bd89 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3080 From goetz at openjdk.org Fri Dec 6 19:40:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:40:38 GMT Subject: [jdk21u-dev] Integrated: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F In-Reply-To: <-kkWSuXIo69yIyKjDZnsjBZKbp03d9ZZ4fJHSK4duXQ=.7816c450-9c5f-4f38-8f6b-902774023e3d@github.com> References: <-kkWSuXIo69yIyKjDZnsjBZKbp03d9ZZ4fJHSK4duXQ=.7816c450-9c5f-4f38-8f6b-902774023e3d@github.com> Message-ID: On Wed, 4 Dec 2024 14:40:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: f554fcff Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/f554fcff70bd6a07ffff890871e92f0e8a8bf8cc Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F Backport-of: b8e8e965e541881605f9dbcd4d9871d4952b9232 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1203 From goetz at openjdk.org Fri Dec 6 19:40:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:40:48 GMT Subject: [jdk17u-dev] Integrated: 8319569: Several java/util tests should be updated to accept VM flags In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 10:52:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I skipped PropertiesTest.sh to PropertiesTestRun.java as the > test was refactored by backport of "8210410: Refactor java.util.Currency:i18n shell tests to plain java tests" > which already includes the fix of this change. > > MissingResourceCauseTestRun.java: Copyright. This pull request has now been integrated. Changeset: b90cef21 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b90cef210eb6fb50529034c25fc7f8ea032559e2 Stats: 178 lines in 11 files changed: 20 ins; 42 del; 116 mod 8319569: Several java/util tests should be updated to accept VM flags Reviewed-by: lucy Backport-of: 2bb4b9398d65e3f37f34e45476c969ff0afb1540 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3086 From goetz at openjdk.org Fri Dec 6 19:41:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:41:46 GMT Subject: [jdk17u-dev] Integrated: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 11:07:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 81e55d3a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/81e55d3a9c85f91129343e070a34d5b21b218a3c Stats: 14 lines in 7 files changed: 7 ins; 0 del; 7 mod 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags Backport-of: 62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d53a06 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3087 From goetz at openjdk.org Fri Dec 6 19:41:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:41:47 GMT Subject: [jdk21u-dev] Integrated: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation In-Reply-To: References: Message-ID: <3oIl-JOaqRt_WPdu8tBYmlaeGKUlyZkqLAnPLbUpTDw=.641a7364-0656-4314-83f3-8e7c76ddab79@github.com> On Wed, 4 Dec 2024 14:48:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: e2daa351 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e2daa351d3688dc7f3dd86f982a746d8d1a89e44 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation Backport-of: a505a1dda3bc6975bb11f390543b38618ddf2626 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1204 From goetz at openjdk.org Fri Dec 6 19:43:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:43:41 GMT Subject: [jdk21u-dev] Integrated: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java In-Reply-To: <5-R-LygXQzqBhdfLi4XhFYvG2W5XZQX0sEqVpbirvzU=.78a39061-1350-4f7c-882e-e47067f5531d@github.com> References: <5-R-LygXQzqBhdfLi4XhFYvG2W5XZQX0sEqVpbirvzU=.78a39061-1350-4f7c-882e-e47067f5531d@github.com> Message-ID: On Wed, 4 Dec 2024 15:02:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: d0f15d53 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d0f15d53c89e048094415c0ed5c2f5192a14c735 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java Backport-of: 1447967f53fe27f67e4bb766464f941e39506d41 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1205 From goetz at openjdk.org Fri Dec 6 19:44:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:44:48 GMT Subject: [jdk21u-dev] Integrated: 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 15:07:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 532c49aa Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/532c49aa8406b513b7f1d9a25249dbd877dc394b Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust Backport-of: e94e3bba3932f3d92c0a135d333d1ccd6e72b964 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1206 From mbalao at openjdk.org Fri Dec 6 19:47:42 2024 From: mbalao at openjdk.org (Martin Balao) Date: Fri, 6 Dec 2024 19:47:42 GMT Subject: [jdk17u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 13:10:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > Config.java: > Resolve and adapt because of unsupported switch syntax. > > SunPKCS11.java: I had to resolve becuase > "8301553: Support Password-Based Cryptography in SunPKCS11" > is not in 17. Context code has different control flow. > Patched code is unchanged. Thanks for this contribution. Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3092#pullrequestreview-2485726752 From goetz at openjdk.org Fri Dec 6 19:49:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:49:44 GMT Subject: [jdk17u-dev] Integrated: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 11:24:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > Trivial resolve. 21 has some additional documentation lines. This pull request has now been integrated. Changeset: b90bb122 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b90bb122629b8831ed3170ee4506661b07bd3bd5 Stats: 106 lines in 2 files changed: 0 ins; 0 del; 106 mod 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump Reviewed-by: lucy Backport-of: 16d917a85f9311611a14a63f1e53afae970efc73 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3088 From goetz at openjdk.org Fri Dec 6 19:51:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:51:40 GMT Subject: [jdk17u-dev] Integrated: 8319673: Few security tests ignore VM flags In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 11:43:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > ConfigFileTest uses new Java calls, adapted to Java 17. See extra commit. This pull request has now been integrated. Changeset: 964c828d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/964c828dc9580f2bed1b210e1a2205a8abae574b Stats: 49 lines in 3 files changed: 12 ins; 13 del; 24 mod 8319673: Few security tests ignore VM flags Reviewed-by: lucy Backport-of: 430290066c23d09166a84f2f6f89e770c6ba04ff ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3089 From goetz at openjdk.org Fri Dec 6 19:52:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:52:40 GMT Subject: [jdk17u-dev] Integrated: 8319648: java/lang/SecurityManager tests ignore vm flags In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 12:18:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 2c64d33a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2c64d33ade0be2d8c6c200388638a150aaa9028e Stats: 9 lines in 2 files changed: 1 ins; 3 del; 5 mod 8319648: java/lang/SecurityManager tests ignore vm flags Backport-of: 437cf354e2d1f7df79fa32265ccf86a0e84257b5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3090 From goetz at openjdk.org Fri Dec 6 19:54:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:54:41 GMT Subject: [jdk17u-dev] Integrated: 8327857: Remove applet usage from JColorChooser tests Test4222508 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 12:28:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 34d31853 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/34d31853b5230fcb70e1e5dda776ef9823c009ec Stats: 76 lines in 2 files changed: 22 ins; 40 del; 14 mod 8327857: Remove applet usage from JColorChooser tests Test4222508 Backport-of: 7c6fd337d00d4bdeaac724a6ea26fac3654846e0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3091 From goetz at openjdk.org Fri Dec 6 19:59:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 19:59:39 GMT Subject: [jdk17u-dev] Integrated: 8334490: Normalize string with locale invariant `toLowerCase()` In-Reply-To: References: Message-ID: <9oPgyTp5HPTmqgevQQpXA7Ceu4NYKM8ObUKIMwVxGp4=.6b5077e3-bbbe-4cdf-9456-74447467ac9a@github.com> On Wed, 4 Dec 2024 13:24:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 4f2f67da Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4f2f67da3c8f17b0e01875b0329a0bb58ec47f6e Stats: 7 lines in 1 file changed: 1 ins; 0 del; 6 mod 8334490: Normalize string with locale invariant `toLowerCase()` Backport-of: 265a0f5547d0ddb220391aef679c122768f02a00 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3093 From goetz at openjdk.org Fri Dec 6 20:00:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:00:43 GMT Subject: [jdk17u-dev] Integrated: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 14:01:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 3c7596fd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/3c7596fd959bed7ec1c2efc6fd1c48b8eafdafc5 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ Backport-of: 3733fe3a207078b585421cd2a098e808fafaa817 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3094 From goetz at openjdk.org Fri Dec 6 20:02:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:02:44 GMT Subject: [jdk17u-dev] Integrated: 8336012: Fix usages of jtreg-reserved properties In-Reply-To: <9-ML6S4VPDf4xkan-T8hGo8eYqWg0aw1oYE2PgJxmNY=.3b8d2021-3b80-4be5-9b6a-e36e04faf173@github.com> References: <9-ML6S4VPDf4xkan-T8hGo8eYqWg0aw1oYE2PgJxmNY=.3b8d2021-3b80-4be5-9b6a-e36e04faf173@github.com> Message-ID: <2-Jrozv_pGHKJv0Zq0V3VtWPimrDAe3OnWOruiwWSig=.16bbdb01-d114-4379-a8cc-e5afa06e2617@github.com> On Wed, 4 Dec 2024 14:08:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 98526a63 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/98526a632076775d0d7dba28a1e083ef348bc82a Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8336012: Fix usages of jtreg-reserved properties Backport-of: e6c5aa7a6cb54c647d261facdcffa6a410849627 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3095 From goetz at openjdk.org Fri Dec 6 20:03:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:03:43 GMT Subject: [jdk17u-dev] Integrated: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test In-Reply-To: <5y1Nz5A_ZRLZ90akhio4IzpMBJTQqyYhYiMFsILlpBo=.f63be56d-5ddc-4a50-befe-932d95c8a34d@github.com> References: <5y1Nz5A_ZRLZ90akhio4IzpMBJTQqyYhYiMFsILlpBo=.f63be56d-5ddc-4a50-befe-932d95c8a34d@github.com> Message-ID: On Wed, 4 Dec 2024 14:32:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 37c1efa9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/37c1efa928de21f6ff1bd8469c735415e7ae421e Stats: 17 lines in 3 files changed: 13 ins; 2 del; 2 mod 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Backport-of: a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3096 From goetz at openjdk.org Fri Dec 6 20:04:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:04:45 GMT Subject: [jdk17u-dev] Integrated: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 14:39:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > Resolved Copyright, probably clean. This pull request has now been integrated. Changeset: 2f7f75d3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2f7f75d389253db4fb186f0979e74fa1ead7589d Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F Backport-of: b8e8e965e541881605f9dbcd4d9871d4952b9232 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3097 From goetz at openjdk.org Fri Dec 6 20:05:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:05:40 GMT Subject: [jdk17u-dev] Integrated: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java In-Reply-To: <68IcYKnZMJyt7UrnEAq4jsD5K2L81JB5GB7kPq9KXJE=.08fdec72-7f4e-4a3a-8569-8249a28f56ed@github.com> References: <68IcYKnZMJyt7UrnEAq4jsD5K2L81JB5GB7kPq9KXJE=.08fdec72-7f4e-4a3a-8569-8249a28f56ed@github.com> Message-ID: On Wed, 4 Dec 2024 14:47:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: c665a756 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c665a7563d040f6909eb2fd9c84940106e39285c Stats: 119 lines in 1 file changed: 76 ins; 9 del; 34 mod 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java Backport-of: f927c1210ee0675bb1196572177ffb505826d57a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3098 From goetz at openjdk.org Fri Dec 6 20:06:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:06:42 GMT Subject: [jdk17u-dev] Integrated: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 14:48:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: c15715a5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c15715a5f1cc8023d7f2244815ce92ff39457030 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation Backport-of: a505a1dda3bc6975bb11f390543b38618ddf2626 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3099 From goetz at openjdk.org Fri Dec 6 20:08:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:08:40 GMT Subject: [jdk17u-dev] Integrated: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 15:02:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 0ebe1e0f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0ebe1e0fb61c8ad0e2b2749528ec171043d9e0b2 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java Backport-of: 1447967f53fe27f67e4bb766464f941e39506d41 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3100 From goetz at openjdk.org Fri Dec 6 20:10:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 6 Dec 2024 20:10:40 GMT Subject: [jdk17u-dev] Integrated: 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 15:06:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 4dc682a3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4dc682a311db4ddea94e733adfee2007b23db01a Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust Backport-of: e94e3bba3932f3d92c0a135d333d1ccd6e72b964 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3101 From abakhtin at openjdk.org Fri Dec 6 23:18:48 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 6 Dec 2024 23:18:48 GMT Subject: [jdk23u] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: <5Fsd63CNusFWqb5KS4kRYDlcTG1ltBr6iU3ZX5Eg1iY=.12ee37e8-2ba9-4f9c-ab7d-24e32bedce6b@github.com> References: <5Fsd63CNusFWqb5KS4kRYDlcTG1ltBr6iU3ZX5Eg1iY=.12ee37e8-2ba9-4f9c-ab7d-24e32bedce6b@github.com> Message-ID: On Tue, 19 Nov 2024 15:53:34 GMT, Henry Jen wrote: >> Please review the JAR tool enhancement. >> It allows suppressing the overwriting of existing files with a new cmd line option. >> The backport is almost clean except of src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java line 264 >> OptionType.EXTRACT was defined by JDK-8173970 but not backported to JDK23 yet. >> >> All related JTREG tests passed > > Marked as reviewed by henryjen (Committer). @slowhog, Thank you for review. Can anybody with reviewer status look at this PR in addition please? ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/227#issuecomment-2524596145 From liach at openjdk.org Sat Dec 7 01:46:51 2024 From: liach at openjdk.org (Chen Liang) Date: Sat, 7 Dec 2024 01:46:51 GMT Subject: [jdk21u-dev] Withdrawn: 8343377: Performance regression in reflective invocation of native methods In-Reply-To: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> References: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> Message-ID: On Fri, 6 Dec 2024 16:45:39 GMT, Chen Liang wrote: > The reimplementation of core reflection with Method Handles blanket-forced all native methods to use the native accessor due to bootstrapping issues. However, these are already covered by a `VM.isJavaLangInvokeInited()` check, and this blanket enforcement causes performance regression in reflective invocation of native methods like `Object::hashCode` or `Thread::currentThread`. > > The patch is not clean due to the comment update to `useNativeAccessor` - it edits a previously added comment not in JDK 21. The code changes are all clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1207 From syan at openjdk.org Sat Dec 7 01:55:40 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 7 Dec 2024 01:55:40 GMT Subject: [jdk17u-dev] RFR: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless Message-ID: Hi all, This pull request contains a backport of commit [470701f0](https://github.com/openjdk/jdk/commit/470701f0bb269834cc0e1cb40f7d34e92226454b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Leonid Mesnik on 6 Dec 2024 and was reviewed by SendaoYan and Erik Gahlin. Thanks! ------------- Commit messages: - Backport 470701f0bb269834cc0e1cb40f7d34e92226454b Changes: https://git.openjdk.org/jdk17u-dev/pull/3102/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340969 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3102.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3102/head:pull/3102 PR: https://git.openjdk.org/jdk17u-dev/pull/3102 From syan at openjdk.org Sat Dec 7 01:55:58 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 7 Dec 2024 01:55:58 GMT Subject: [jdk21u-dev] RFR: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless Message-ID: Hi all, This pull request contains a backport of commit [470701f0](https://github.com/openjdk/jdk/commit/470701f0bb269834cc0e1cb40f7d34e92226454b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Leonid Mesnik on 6 Dec 2024 and was reviewed by SendaoYan and Erik Gahlin. Thanks! ------------- Commit messages: - Backport 470701f0bb269834cc0e1cb40f7d34e92226454b Changes: https://git.openjdk.org/jdk21u-dev/pull/1208/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1208&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340969 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1208.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1208/head:pull/1208 PR: https://git.openjdk.org/jdk21u-dev/pull/1208 From goetz at openjdk.org Sun Dec 8 10:16:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 8 Dec 2024 10:16:31 GMT Subject: [jdk17u-dev] RFR: 8295087: Manual Test to Automated Test Conversion Message-ID: I backport this for parity with 17.0.13-oracle. Tests pass. ------------- Commit messages: - Backport a3693ccc617d06137a61050b34646e8a90ed3d7e Changes: https://git.openjdk.org/jdk17u-dev/pull/3103/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295087 Stats: 173 lines in 13 files changed: 71 ins; 32 del; 70 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3103.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3103/head:pull/3103 PR: https://git.openjdk.org/jdk17u-dev/pull/3103 From christoph.langer at sap.com Mon Dec 9 00:09:04 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 9 Dec 2024 00:09:04 +0000 Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) In-Reply-To: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> References: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> Message-ID: Vote:yes /Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of Yuri > Nesterenko > Sent: Freitag, 6. Dezember 2024 08:02 > To: jdk-updates-dev at openjdk.org > Subject: CFV: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) > > I hereby nominate Alexey Bakhtin (abakhtin) [1] for the role of OpenJDK > Updates Project Reviewer. > Alexey has worked in the Azul JDK Team since 2016 and has contributed over > 100 OpenJDK commits [2][3][4][5][6]. > Alexey is a Committer in the JDK, JDK Updates, and JDK8 Updates Projects and a > Member of the Vulnerability Group [7]. > > Votes are due by 21th December 2024, 17:00 UTC. Only current JDK Updates > Reviewers [8] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. For Three-Vote > Consensus voting instructions, see [9]. > > Regards, > Yuri > > [1] > https://openjdk.j/ > ava.net%2Fcensus%23abakhtin&data=05%7C02%7Cchristoph.langer%40sap.co > m%7Cc1c5cbaf5228477c4e7f08dd15c3f53e%7C42f7676cf455423c82f6dc2d99 > 791af7%7C0%7C0%7C638690653579401713%7CUnknown%7CTWFpbGZsb3d8 > eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiT > WFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=xjdKqISX6k8ylIhYeOW3Xi > oF8WT89O07pKc1RNr3neU%3D&reserved=0 > [2] https://github.com/openjdk/jdk21u- > dev/commits/master?author=abakhtin%40openjdk.org > [3] https://github.com/openjdk/jdk17u- > dev/commits/master?author=abakhtin%40openjdk.org > [4] https://github.com/openjdk/jdk15u- > dev/commits/master?author=abakhtin%40openjdk.org > [5] https://github.com/openjdk/jdk13u- > dev/commits/master?author=abakhtin%40openjdk.org > [6] https://github.com/openjdk/jdk11u- > dev/commits/master?author=abakhtin%40openjdk.org > [7] https://openjdk.org/census#vulnerability > [8] > https://openjdk.j/ > ava.net%2Fcensus%23jdk- > updates&data=05%7C02%7Cchristoph.langer%40sap.com%7Cc1c5cbaf5228477 > c4e7f08dd15c3f53e%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C6 > 38690653579431155%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnR > ydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3 > D%3D%7C0%7C%7C%7C&sdata=zimjuth5Qc2EMkWyP0z7sOh2tJk6K4LekeTviSK > Bh6g%3D&reserved=0 > [9] > https://openjdk.j/ > ava.net%2Fbylaws%23three-vote- > consensus&data=05%7C02%7Cchristoph.langer%40sap.com%7Cc1c5cbaf52284 > 77c4e7f08dd15c3f53e%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7 > C638690653579446530%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiO > nRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ% > 3D%3D%7C0%7C%7C%7C&sdata=Gb8%2BcEqFb%2B%2FdNIz8Xx28eTbq81gND > 4dwvC2rX0grrn0%3D&reserved=0 From rrich at openjdk.org Mon Dec 9 07:40:48 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 9 Dec 2024 07:40:48 GMT Subject: [jdk21u-dev] RFR: 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 16:45:46 GMT, Richard Reingruber wrote: > Backport of https://github.com/openjdk/jdk/commit/f9208fadde8141e18a025ddb6ce28423861ba391 > > The change removes instructions that check if an ObjectMonitor is owned by the current thread before unlocking it in a c1/c2 compiled nmethod. > > The check is imprecise. It can fail if the lock was inflated into an ObjectMonitor by another thread. > It is also redundant since only bytecode with symmetric locking operations is compiled. > See JBS-Issue for details. > > Note that there existed a special diagnostic locking mode to do the same check also on x86. Purpose was to protect against missbehaving JNI code. It got removed though with [JDK-8210381](https://bugs.openjdk.org/browse/JDK-8210381) in jdk12. On ppc64le it was not removed as the check was done in default mode as well (unclear why). > > The fix didn't apply because in jdk21 there is still just one method to handle LM_LEGACY and LM_LIGHTWEIGHT and LM_LIGHTWEIGHT requires the owner check to handle ANONYMOUS owner. Also RTM is still supported in jdk21. > > I'd consider the risk low. Aside from the assertions, the change is very small and it just brings ppc64 in line with how unlocking is done on other platforms. > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. Thanks for the review Martin. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1191#issuecomment-2527157643 From rrich at openjdk.org Mon Dec 9 07:40:48 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 9 Dec 2024 07:40:48 GMT Subject: [jdk21u-dev] Integrated: 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking In-Reply-To: References: Message-ID: <0AOtHtSCXIsZlCGPGsul_mi1nTq0q66p2JWlthN9A98=.6ef2c7c3-229a-4509-a976-8c5a49fcca19@github.com> On Mon, 2 Dec 2024 16:45:46 GMT, Richard Reingruber wrote: > Backport of https://github.com/openjdk/jdk/commit/f9208fadde8141e18a025ddb6ce28423861ba391 > > The change removes instructions that check if an ObjectMonitor is owned by the current thread before unlocking it in a c1/c2 compiled nmethod. > > The check is imprecise. It can fail if the lock was inflated into an ObjectMonitor by another thread. > It is also redundant since only bytecode with symmetric locking operations is compiled. > See JBS-Issue for details. > > Note that there existed a special diagnostic locking mode to do the same check also on x86. Purpose was to protect against missbehaving JNI code. It got removed though with [JDK-8210381](https://bugs.openjdk.org/browse/JDK-8210381) in jdk12. On ppc64le it was not removed as the check was done in default mode as well (unclear why). > > The fix didn't apply because in jdk21 there is still just one method to handle LM_LEGACY and LM_LIGHTWEIGHT and LM_LIGHTWEIGHT requires the owner check to handle ANONYMOUS owner. Also RTM is still supported in jdk21. > > I'd consider the risk low. Aside from the assertions, the change is very small and it just brings ppc64 in line with how unlocking is done on other platforms. > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. This pull request has now been integrated. Changeset: a0ed69d5 Author: Richard Reingruber URL: https://git.openjdk.org/jdk21u-dev/commit/a0ed69d5a380c41546d6e0c9dbaa235adfe7f237 Stats: 37 lines in 1 file changed: 31 ins; 1 del; 5 mod 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking Reviewed-by: mdoerr Backport-of: f9208fadde8141e18a025ddb6ce28423861ba391 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1191 From syan at openjdk.org Mon Dec 9 07:50:43 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 9 Dec 2024 07:50:43 GMT Subject: [jdk21u-dev] RFR: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless In-Reply-To: References: Message-ID: <8KjXF_rnGK6t5TJJQbcEXwEeVisv5vNO1Czj2xFPpGQ=.d5149ca3-dc0f-4066-9194-242b85253e0b@github.com> On Sat, 7 Dec 2024 01:50:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [470701f0](https://github.com/openjdk/jdk/commit/470701f0bb269834cc0e1cb40f7d34e92226454b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 6 Dec 2024 and was reviewed by SendaoYan and Erik Gahlin. > > Thanks! GHA report 1 test failures: 1. linux-x64/build job at `Get JTReg` stage fails as `wget exited with exit code 4`, seems like infra issue or environment issue, it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1208#issuecomment-2527174974 From duke at openjdk.org Mon Dec 9 08:50:58 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 9 Dec 2024 08:50:58 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v5] In-Reply-To: <98NAl0GH9ajo3Ch14pVOob-yG4hZVBQrxCNQ-DoYhs4=.4f5bf0ee-7392-4dce-9079-0ec733f21370@github.com> References: <98NAl0GH9ajo3Ch14pVOob-yG4hZVBQrxCNQ-DoYhs4=.4f5bf0ee-7392-4dce-9079-0ec733f21370@github.com> Message-ID: <3EPIo8DUAr1dPFRDL1XpQNb180H1pFILiL-WO6t9Fwc=.1a747418-47b0-4d77-9d2c-409dcd4d88df@github.com> On Fri, 6 Dec 2024 09:27:54 GMT, Severin Gehwolf wrote: > Agreed. Looks like a backport of https://bugs.openjdk.org/browse/JDK-8243455 would fix it (test only change). Yep, but that's far away from the current state in 11 ([8244670](https://bugs.openjdk.org/browse/JDK-8244670), [8273928](https://bugs.openjdk.org/browse/JDK-8273928), [8264775](https://bugs.openjdk.org/browse/JDK-8264775), [8243455](https://bugs.openjdk.org/browse/JDK-8243455), [8261929](https://bugs.openjdk.org/browse/JDK-8261929), [8261098](https://bugs.openjdk.org/browse/JDK-8261098), [8247514](https://bugs.openjdk.org/browse/JDK-8247514) and/or [8260296](https://bugs.openjdk.org/browse/JDK-8260296)) may need to be applied first. Also it seems this is in ProblemList.txt because of ([8294316](https://bugs.openjdk.org/browse/JDK-8294316) and [8267433](https://bugs.openjdk.org/browse/JDK-8267433)). I'll try to investigate during the next weeks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2527292670 From goetz at openjdk.org Mon Dec 9 09:20:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Dec 2024 09:20:03 GMT Subject: [jdk21u-dev] RFR: 8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate Message-ID: A simple change to improve code heap analytics. ------------- Commit messages: - Backport 1230aed61d286fe9c09f46e2bab626d0e8fe0273 Changes: https://git.openjdk.org/jdk21u-dev/pull/1209/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1209&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316885 Stats: 21 lines in 2 files changed: 21 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1209.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1209/head:pull/1209 PR: https://git.openjdk.org/jdk21u-dev/pull/1209 From goetz at openjdk.org Mon Dec 9 09:51:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Dec 2024 09:51:14 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error Message-ID: I would like to backport this fix for the mac build. I had to move the code to another file, the code is the same, though. "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to a new file. ------------- Commit messages: - Backport 715fa8f9fe7242e86b985aece3d078b226f53fb9 Changes: https://git.openjdk.org/jdk21u-dev/pull/1210/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1210&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336498 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1210.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1210/head:pull/1210 PR: https://git.openjdk.org/jdk21u-dev/pull/1210 From lucy at openjdk.org Mon Dec 9 10:38:43 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Mon, 9 Dec 2024 10:38:43 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 09:45:55 GMT, Goetz Lindenmaier wrote: > I would like to backport this fix for the mac build. > > I had to move the code to another file, the code is the same, though. > "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to > a new file. Looks good. ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1210#pullrequestreview-2488400040 From goetz at openjdk.org Mon Dec 9 10:41:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Dec 2024 10:41:46 GMT Subject: [jdk17u-dev] RFR: 8295087: Manual Test to Automated Test Conversion In-Reply-To: References: Message-ID: <-kSETIBxODbLGYVOkAZ-aZ3G9_OeW5343STLVjxKxRg=.b03ed557-94d2-479c-b18c-3cc7cd86f831@github.com> On Sun, 8 Dec 2024 10:11:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.13-oracle. > > Tests pass. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3103#issuecomment-2527547790 From goetz at openjdk.org Mon Dec 9 10:42:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Dec 2024 10:42:50 GMT Subject: [jdk17u-dev] RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 13:10:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > Config.java: > Resolve and adapt because of unsupported switch syntax. > > SunPKCS11.java: I had to resolve becuase > "8301553: Support Password-Based Cryptography in SunPKCS11" > is not in 17. Context code has different control flow. > Patched code is unchanged. Thanks for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3092#issuecomment-2527550226 From duke at openjdk.org Mon Dec 9 11:26:37 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Mon, 9 Dec 2024 11:26:37 GMT Subject: [jdk21u-dev] RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform In-Reply-To: References: Message-ID: On Tue, 26 Nov 2024 13:21:15 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8344275 : tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform > > Original patch does not apply cleanly because JDK-8340311 and JDK-8343314 are not applied to jdk21. > JDK-8340311 and JDK-8343314 are enhancement, so I don't backport them. > > Testing: tools/jpackage tests importing jdk.jpackage.test.Executor on Windows Server 2019 (Japanese and English locales) > > Thanks. Could anyone review this backport please? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1182#issuecomment-2527650923 From duke at openjdk.org Mon Dec 9 13:15:19 2024 From: duke at openjdk.org (Fabian Meumertzheim) Date: Mon, 9 Dec 2024 13:15:19 GMT Subject: [jdk21u-dev] RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE Message-ID: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE ------------- Commit messages: - Backport d7ef3ac0b7e677c4901c69ad4361b5de8408e8d3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1211/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1211&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345684 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1211.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1211/head:pull/1211 PR: https://git.openjdk.org/jdk21u-dev/pull/1211 From goetz at openjdk.org Mon Dec 9 13:42:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Dec 2024 13:42:48 GMT Subject: [jdk17u-dev] Integrated: 8295087: Manual Test to Automated Test Conversion In-Reply-To: References: Message-ID: On Sun, 8 Dec 2024 10:11:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.13-oracle. > > Tests pass. This pull request has now been integrated. Changeset: ace471e9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ace471e9fb285d5977e85ba1e467717cdd43f922 Stats: 173 lines in 13 files changed: 71 ins; 32 del; 70 mod 8295087: Manual Test to Automated Test Conversion Backport-of: a3693ccc617d06137a61050b34646e8a90ed3d7e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3103 From goetz at openjdk.org Mon Dec 9 13:47:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 9 Dec 2024 13:47:50 GMT Subject: [jdk17u-dev] RFR: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only Message-ID: I backport this for parity with 17.0.13-oracle. Omitted ProblemList change, problem listing it was not backported. ------------- Commit messages: - Backport 20579e48cf598e890aa35c5518ec8d0594f45385 Changes: https://git.openjdk.org/jdk17u-dev/pull/3104/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299994 Stats: 40 lines in 2 files changed: 37 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3104.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3104/head:pull/3104 PR: https://git.openjdk.org/jdk17u-dev/pull/3104 From asemenyuk at openjdk.org Mon Dec 9 17:24:40 2024 From: asemenyuk at openjdk.org (Alexey Semenyuk) Date: Mon, 9 Dec 2024 17:24:40 GMT Subject: [jdk21u-dev] RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform In-Reply-To: References: Message-ID: On Tue, 26 Nov 2024 13:21:15 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8344275 : tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform > > Original patch does not apply cleanly because JDK-8340311 and JDK-8343314 are not applied to jdk21. > JDK-8340311 and JDK-8343314 are enhancement, so I don't backport them. > > Testing: tools/jpackage tests importing jdk.jpackage.test.Executor on Windows Server 2019 (Japanese and English locales) > > Thanks. Marked as reviewed by asemenyuk (Author). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1182#pullrequestreview-2489482435 From phh at openjdk.org Mon Dec 9 17:30:47 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 9 Dec 2024 17:30:47 GMT Subject: [jdk21u-dev] RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform In-Reply-To: References: Message-ID: On Tue, 26 Nov 2024 13:21:15 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8344275 : tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform > > Original patch does not apply cleanly because JDK-8340311 and JDK-8343314 are not applied to jdk21. > JDK-8340311 and JDK-8343314 are enhancement, so I don't backport them. > > Testing: tools/jpackage tests importing jdk.jpackage.test.Executor on Windows Server 2019 (Japanese and English locales) > > Thanks. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1182#pullrequestreview-2489495797 From goetz at openjdk.org Tue Dec 10 08:05:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Dec 2024 08:05:47 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 09:45:55 GMT, Goetz Lindenmaier wrote: > I would like to backport this fix for the mac build. > > I had to move the code to another file, the code is the same, though. > "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to > a new file. GAH failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1210#issuecomment-2530725640 From goetz at openjdk.org Tue Dec 10 08:10:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Dec 2024 08:10:51 GMT Subject: [jdk17u-dev] RFR: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 13:43:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.13-oracle. > > Omitted ProblemList change, problem listing it was not backported. GHA failure: four times the well known wget failure. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3104#issuecomment-2530735473 From syan at openjdk.org Tue Dec 10 08:18:46 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Dec 2024 08:18:46 GMT Subject: [jdk21u-dev] RFR: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless In-Reply-To: References: Message-ID: On Sat, 7 Dec 2024 01:50:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [470701f0](https://github.com/openjdk/jdk/commit/470701f0bb269834cc0e1cb40f7d34e92226454b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 6 Dec 2024 and was reviewed by SendaoYan and Erik Gahlin. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1208#issuecomment-2530752918 From syan at openjdk.org Tue Dec 10 08:18:46 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Dec 2024 08:18:46 GMT Subject: [jdk21u-dev] Integrated: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless In-Reply-To: References: Message-ID: On Sat, 7 Dec 2024 01:50:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [470701f0](https://github.com/openjdk/jdk/commit/470701f0bb269834cc0e1cb40f7d34e92226454b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 6 Dec 2024 and was reviewed by SendaoYan and Erik Gahlin. > > Thanks! This pull request has now been integrated. Changeset: 7511a0be Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/7511a0be92b720eaea7b3dc3c2121f9a670c408d Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless Backport-of: 470701f0bb269834cc0e1cb40f7d34e92226454b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1208 From syan at openjdk.org Tue Dec 10 08:19:50 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Dec 2024 08:19:50 GMT Subject: [jdk17u-dev] RFR: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless In-Reply-To: References: Message-ID: <4U3Exrw54uXqNLjPzzXUKD2h10u5ojKuyd1hSvkHQdc=.25a699f2-645e-483a-90b1-5b4bd7b5f39f@github.com> On Sat, 7 Dec 2024 01:50:44 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [470701f0](https://github.com/openjdk/jdk/commit/470701f0bb269834cc0e1cb40f7d34e92226454b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 6 Dec 2024 and was reviewed by SendaoYan and Erik Gahlin. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3102#issuecomment-2530753771 From syan at openjdk.org Tue Dec 10 08:19:50 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Dec 2024 08:19:50 GMT Subject: [jdk17u-dev] Integrated: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless In-Reply-To: References: Message-ID: On Sat, 7 Dec 2024 01:50:44 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [470701f0](https://github.com/openjdk/jdk/commit/470701f0bb269834cc0e1cb40f7d34e92226454b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Leonid Mesnik on 6 Dec 2024 and was reviewed by SendaoYan and Erik Gahlin. > > Thanks! This pull request has now been integrated. Changeset: e29b0619 Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/e29b0619c955a8ca67cba154ef99accebf6fa803 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless Backport-of: 470701f0bb269834cc0e1cb40f7d34e92226454b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3102 From goetz at openjdk.org Tue Dec 10 10:54:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Dec 2024 10:54:47 GMT Subject: [jdk17u-dev] Integrated: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 13:10:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > Config.java: > Resolve and adapt because of unsupported switch syntax. > > SunPKCS11.java: I had to resolve becuase > "8301553: Support Password-Based Cryptography in SunPKCS11" > is not in 17. Context code has different control flow. > Patched code is unchanged. This pull request has now been integrated. Changeset: 6f16a447 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6f16a44784fbaeedfe4ccd6c4e7fb5280b329c2b Stats: 51 lines in 2 files changed: 25 ins; 25 del; 1 mod 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic Reviewed-by: mbaesken, mbalao Backport-of: 1b476f52ba85f9ceaabe785d36cb07df831fd0e8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3092 From goetz at openjdk.org Tue Dec 10 10:55:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Dec 2024 10:55:46 GMT Subject: [jdk21u-dev] Integrated: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 13:09:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 37df1cb4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/37df1cb487d1a5adebe9b9cea2ffe02bedf5a521 Stats: 51 lines in 2 files changed: 25 ins; 25 del; 1 mod 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic Backport-of: 1b476f52ba85f9ceaabe785d36cb07df831fd0e8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1200 From lucy at openjdk.org Tue Dec 10 14:52:50 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 10 Dec 2024 14:52:50 GMT Subject: [jdk17u-dev] RFR: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 13:43:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.13-oracle. > > Omitted ProblemList change, problem listing it was not backported. Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3104#pullrequestreview-2492578758 From lucy at openjdk.org Tue Dec 10 14:53:44 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 10 Dec 2024 14:53:44 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 09:45:55 GMT, Goetz Lindenmaier wrote: > I would like to backport this fix for the mac build. > > I had to move the code to another file, the code is the same, though. > "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to > a new file. Marked as reviewed by lucy (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1210#pullrequestreview-2492581460 From szaldana at openjdk.org Tue Dec 10 15:01:30 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 10 Dec 2024 15:01:30 GMT Subject: [jdk21u-dev] RFR: 8315882: Open some swing tests 2 Message-ID: <5nRnXi4xkXpyRN3eGFyQsMOPDz_Uzx4Fq64McxDzzrI=.1903f0e6-4d3c-4ea2-82f9-c3d23a5cdbc3@github.com> Hi all, This pull request contains a backport of commit [d2d7d9a8](https://github.com/openjdk/jdk/commit/d2d7d9a8b7c68865553dcbb4d660bbb06fde3974) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alisen Chung on 23 Sep 2023 and was reviewed by Harshitha Onkar and Phil Race. Thanks! ------------- Commit messages: - Backport d2d7d9a8b7c68865553dcbb4d660bbb06fde3974 Changes: https://git.openjdk.org/jdk21u-dev/pull/1212/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1212&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315882 Stats: 228 lines in 3 files changed: 228 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1212.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1212/head:pull/1212 PR: https://git.openjdk.org/jdk21u-dev/pull/1212 From szaldana at openjdk.org Tue Dec 10 15:03:57 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 10 Dec 2024 15:03:57 GMT Subject: [jdk21u-dev] RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop Message-ID: <06TnZyucO7FCdROXAIj9s6aBWS1HjfmgQgMWLLrJZ5I=.3411b0c6-c280-4112-b83b-c09f2cb1c503@github.com> Hi all, This pull request contains a backport of commit [e203df46](https://github.com/openjdk/jdk/commit/e203df46faf610e35e2c2510271ad68199f4fa3f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Roland Westrelin on 5 Sep 2024 and was reviewed by Christian Hagedorn and Tobias Hartmann. Thanks! ------------- Commit messages: - Backport e203df46faf610e35e2c2510271ad68199f4fa3f Changes: https://git.openjdk.org/jdk21u-dev/pull/1213/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1213&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338100 Stats: 308 lines in 7 files changed: 257 ins; 32 del; 19 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1213.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1213/head:pull/1213 PR: https://git.openjdk.org/jdk21u-dev/pull/1213 From szaldana at openjdk.org Tue Dec 10 15:04:27 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 10 Dec 2024 15:04:27 GMT Subject: [jdk21u-dev] RFR: 8316218: Open some swing tests 5 Message-ID: Hi all, This pull request contains a backport of commit [788e6e15](https://github.com/openjdk/jdk/commit/788e6e154824317cf92884510c2ee116bc64f510) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alisen Chung on 26 Sep 2023 and was reviewed by Phil Race and Damon Nguyen. Thanks! ------------- Commit messages: - Backport 788e6e154824317cf92884510c2ee116bc64f510 Changes: https://git.openjdk.org/jdk21u-dev/pull/1214/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1214&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316218 Stats: 262 lines in 4 files changed: 262 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1214.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1214/head:pull/1214 PR: https://git.openjdk.org/jdk21u-dev/pull/1214 From szaldana at openjdk.org Tue Dec 10 15:05:39 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 10 Dec 2024 15:05:39 GMT Subject: [jdk21u-dev] RFR: 8316146: Open some swing tests 4 Message-ID: Hi all, This pull request contains a backport of commit [3105538d](https://github.com/openjdk/jdk/commit/3105538de5569845547b40f243a994a95a84b48f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alisen Chung on 4 Oct 2023 and was reviewed by Harshitha Onkar, Alexey Ivanov and Phil Race. Thanks! ------------- Commit messages: - Backport 3105538de5569845547b40f243a994a95a84b48f Changes: https://git.openjdk.org/jdk21u-dev/pull/1215/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1215&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316146 Stats: 311 lines in 4 files changed: 311 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1215.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1215/head:pull/1215 PR: https://git.openjdk.org/jdk21u-dev/pull/1215 From szaldana at openjdk.org Tue Dec 10 15:06:06 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 10 Dec 2024 15:06:06 GMT Subject: [jdk21u-dev] RFR: 8316371: Open some swing tests 6 Message-ID: <8RhSlYGI_UNpDm8TNU1fP10_0iADk-ypEJZre0bRlMo=.0202b49a-6a1e-47b4-a128-4a30bcd8d7e5@github.com> Hi all, This pull request contains a backport of commit [d3a79b58](https://github.com/openjdk/jdk/commit/d3a79b5861be27227b8c28cb3acdce089b74c50b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alisen Chung on 27 Sep 2023 and was reviewed by Damon Nguyen and Phil Race. Thanks! ------------- Commit messages: - Backport d3a79b5861be27227b8c28cb3acdce089b74c50b Changes: https://git.openjdk.org/jdk21u-dev/pull/1216/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1216&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316371 Stats: 569 lines in 5 files changed: 569 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1216.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1216/head:pull/1216 PR: https://git.openjdk.org/jdk21u-dev/pull/1216 From goetz at openjdk.org Tue Dec 10 15:29:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 10 Dec 2024 15:29:46 GMT Subject: [jdk21u-dev] RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE In-Reply-To: References: Message-ID: <4UQiLuTm4BpjAG4BCf_Oqp4TFkCDCJykd2x352AFEoo=.55e2c34c-3ee3-450d-9df8-ddc819f198a3@github.com> On Mon, 9 Dec 2024 13:08:29 GMT, Fabian Meumertzheim wrote: > 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE Please backport to 24 first. Removing the tag in the meantime, please tag again once it is in 24. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1211#issuecomment-2532042134 From mdoerr at openjdk.org Tue Dec 10 16:04:46 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 10 Dec 2024 16:04:46 GMT Subject: [jdk21u-dev] Integrated: 8343343: Misc crash dump improvements on more platforms after JDK-8294160 In-Reply-To: References: Message-ID: On Wed, 13 Nov 2024 21:31:14 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8343343](https://bugs.openjdk.org/browse/JDK-8343343). PPC64 files use a different frame constructor after [JDK-8290965](https://bugs.openjdk.org/browse/JDK-8290965) (JDK23). Includes [JDK-8343149](https://bugs.openjdk.org/browse/JDK-8343149). This pull request has now been integrated. Changeset: c1bd8d91 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/c1bd8d91240f0802ddbbe0d5542b4ebadd7262d0 Stats: 282 lines in 14 files changed: 63 ins; 214 del; 5 mod 8343343: Misc crash dump improvements on more platforms after JDK-8294160 8343149: Cleanup os::print_tos_pc on AIX Reviewed-by: mbaesken Backport-of: e33dc13567a4f0d9a6c1ae63fa0424ca27d52584 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1154 From mdoerr at openjdk.org Tue Dec 10 16:05:47 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 10 Dec 2024 16:05:47 GMT Subject: [jdk17u-dev] Integrated: 8342607: Enhance register printing on x86_64 platforms In-Reply-To: References: Message-ID: <1KjOFBIK1SSU3-ZN__LskdmUZuxC-ZAvBEunaiYaKB4=.99aa0350-cc56-4538-ab01-b4daebf156f8@github.com> On Tue, 19 Nov 2024 16:32:16 GMT, Martin Doerr wrote: > Clean backport of [JDK-8342607](https://bugs.openjdk.org/browse/JDK-8342607) plus small part of https://github.com/openjdk/jdk/commit/98ce45ff7432a56d73b51046817b5fe84a412042 (2nd commit, may help other backports, too). This pull request has now been integrated. Changeset: 131a032b Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/131a032b8d360a8d26ae0693d5cdc3666761563c Stats: 43 lines in 4 files changed: 38 ins; 0 del; 5 mod 8342607: Enhance register printing on x86_64 platforms Reviewed-by: mbaesken Backport-of: 1bfb57dca4a65ea64a15914b1e8b5c4c509db6f5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3061 From mdoerr at openjdk.org Tue Dec 10 20:35:57 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 10 Dec 2024 20:35:57 GMT Subject: [jdk17u-dev] RFR: 8343724: [PPC64] Disallow OptoScheduling Message-ID: Clean backport of [JDK-8343724](https://bugs.openjdk.org/browse/JDK-8343724). ------------- Commit messages: - Backport f621f26cd113090a0305598cfc50f0eac9a263c6 Changes: https://git.openjdk.org/jdk17u-dev/pull/3105/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343724 Stats: 39 lines in 2 files changed: 22 ins; 16 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3105.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3105/head:pull/3105 PR: https://git.openjdk.org/jdk17u-dev/pull/3105 From cushon at openjdk.org Wed Dec 11 00:53:43 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 11 Dec 2024 00:53:43 GMT Subject: [jdk17u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: References: Message-ID: <7ojjNoHvnkt0juvfSrxMD9difReSSB_uRy_3x2_RXP4=.7fa7539c-e880-4435-b19d-dc932be2e8d5@github.com> On Tue, 5 Nov 2024 18:49:17 GMT, Liam Miller-Cushon wrote: >> This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 > - 8336942: Improve test coverage for class loading elements with annotations of different retentions > > Reviewed-by: vromero Let's keep this open for now ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2955#issuecomment-2533367761 From sgehwolf at openjdk.org Wed Dec 11 10:24:47 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 11 Dec 2024 10:24:47 GMT Subject: [jdk21u-dev] RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE In-Reply-To: <4UQiLuTm4BpjAG4BCf_Oqp4TFkCDCJykd2x352AFEoo=.55e2c34c-3ee3-450d-9df8-ddc819f198a3@github.com> References: <4UQiLuTm4BpjAG4BCf_Oqp4TFkCDCJykd2x352AFEoo=.55e2c34c-3ee3-450d-9df8-ddc819f198a3@github.com> Message-ID: On Tue, 10 Dec 2024 15:26:35 GMT, Goetz Lindenmaier wrote: > Please backport to 24 first. Removing the tag in the meantime, please tag again once it is in 24. For reference the JDK 24u updates repo is not yet created upstream, AFAIK and this is a P4 bug not eligible for backporting to JDK 24 GA during ramp down one phase (jdk24 branch on the jdk repo). I'll ask on the list to get a jdk24u repo created. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1211#issuecomment-2535443639 From sgehwolf at redhat.com Wed Dec 11 10:25:55 2024 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Wed, 11 Dec 2024 11:25:55 +0100 Subject: openjdk/jdk24u repository for 24.0.1? Message-ID: Hi, With JDK 24 now in ramp down and some fixes not eligible for JDK 24 GA (24.0.0), would it make sense to get an updates repository created to collect fixes for JDK 24.0.1 in April, 2025? It doesn't seem to exist yet: https://github.com/openjdk/jdk24u Thanks, Severin From sgehwolf at openjdk.org Wed Dec 11 10:36:44 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 11 Dec 2024 10:36:44 GMT Subject: [jdk21u-dev] RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE In-Reply-To: References: <4UQiLuTm4BpjAG4BCf_Oqp4TFkCDCJykd2x352AFEoo=.55e2c34c-3ee3-450d-9df8-ddc819f198a3@github.com> Message-ID: On Wed, 11 Dec 2024 10:21:39 GMT, Severin Gehwolf wrote: > I'll ask on the list to get a jdk24u repo created. https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-December/039848.html ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1211#issuecomment-2535470766 From mdoerr at openjdk.org Wed Dec 11 11:33:47 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 11 Dec 2024 11:33:47 GMT Subject: [jdk21u-dev] Integrated: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 18:07:40 GMT, Martin Doerr wrote: > Almost clean backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205). I have included `get_c1_thread_count()` and `get_c2_thread_count()` from [JDK-8317562](https://bugs.openjdk.org/browse/JDK-8317562) (see 2nd commit). This pull request has now been integrated. Changeset: 3087c6c7 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/3087c6c74d742b7b5eaf28e4c886b5dc1811ea6f Stats: 29 lines in 2 files changed: 18 ins; 0 del; 11 mod 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory Reviewed-by: phh Backport-of: 75801992a7c626d409f66e2491082dba84c6fe45 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1123 From mdoerr at openjdk.org Wed Dec 11 11:44:48 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 11 Dec 2024 11:44:48 GMT Subject: [jdk17u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory Message-ID: Backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205) from jdk21u-dev. ------------- Commit messages: - Backport 3087c6c74d742b7b5eaf28e4c886b5dc1811ea6f Changes: https://git.openjdk.org/jdk17u-dev/pull/3106/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3106&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343205 Stats: 29 lines in 2 files changed: 18 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3106.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3106/head:pull/3106 PR: https://git.openjdk.org/jdk17u-dev/pull/3106 From kevin.rushforth at oracle.com Wed Dec 11 12:35:07 2024 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 11 Dec 2024 04:35:07 -0800 Subject: openjdk/jdk24u repository for 24.0.1? In-Reply-To: References: Message-ID: <6c3fe13a-836c-416d-b2c0-d15088a6151d@oracle.com> It's being created today. Rob will announce when it is ready. -- Kevin On 12/11/2024 2:25 AM, Severin Gehwolf wrote: > Hi, > > With JDK 24 now in ramp down and some fixes not eligible for JDK 24 GA > (24.0.0), would it make sense to get an updates repository created to > collect fixes for JDK 24.0.1 in April, 2025? > > It doesn't seem to exist yet: > https://github.com/openjdk/jdk24u > > Thanks, > Severin > From duke at openjdk.org Wed Dec 11 13:32:44 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 13:32:44 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: <4EoawSl2HmQ7Af2744k9kHpnypmVr_t8lkfkLJKwO0c=.1f087131-b4a0-407f-a29c-e5fa1374e678@github.com> On Thu, 24 Oct 2024 13:54:06 GMT, Boris Ulasevich wrote: > (not a clean backport) > Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport > > Functional jtreg1-3 tests are Ok. > Manual testing: the reproducer shows the problem is fixed with the change (see comments below) @bulasevich Your change (at version bf98d3a52fb43a640aaea9b5cadb88b672b4c7b8) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2535996034 From duke at openjdk.org Wed Dec 11 13:33:47 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 13:33:47 GMT Subject: [jdk21u-dev] RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 22:15:51 GMT, Boris Ulasevich wrote: > Hi all, > > backport https://bugs.openjdk.org/browse/JDK-8295159 to fix broken Java floating-point arithmetic. > > Minor merge conflicts in os_linux.cpp and os_bsd.cpp have been resolved manually. The conflict is with the NativeLibraryLoadEvent tracing applied on the mainline around the dlopen() call: https://github.com/openjdk/jdk/pull/16903 > > The fix passed tier1-3 jtreg tests. > > Thank you @bulasevich Your change (at version 161842e2eaab7cfa12bc9ecd2473dd5a3cfb1be2) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1111#issuecomment-2535998643 From goetz at openjdk.org Wed Dec 11 13:41:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Dec 2024 13:41:54 GMT Subject: [jdk21u-dev] RFR: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file Message-ID: I backport this to keep testing up to date. ------------- Commit messages: - Backport 00fe9f7bdfd245791bca6b5b1b2d0a98d41af221 Changes: https://git.openjdk.org/jdk21u-dev/pull/1218/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1218&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343100 Stats: 254 lines in 5 files changed: 87 ins; 146 del; 21 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1218.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1218/head:pull/1218 PR: https://git.openjdk.org/jdk21u-dev/pull/1218 From goetz at openjdk.org Wed Dec 11 13:44:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Dec 2024 13:44:18 GMT Subject: [jdk17u-dev] RFR: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file Message-ID: I backport this to keep testing up to date. ------------- Commit messages: - Backport 00fe9f7bdfd245791bca6b5b1b2d0a98d41af221 Changes: https://git.openjdk.org/jdk17u-dev/pull/3107/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3107&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343100 Stats: 254 lines in 5 files changed: 87 ins; 146 del; 21 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3107.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3107/head:pull/3107 PR: https://git.openjdk.org/jdk17u-dev/pull/3107 From bulasevich at openjdk.org Wed Dec 11 14:23:41 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Wed, 11 Dec 2024 14:23:41 GMT Subject: [jdk21u-dev] Integrated: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: <5vzkcxFreDYNLB6aLGzd5pqU_nuEUcBsZukiuXJHolM=.ff1a5b05-c5bc-4123-a11b-91aa22dddb59@github.com> On Thu, 24 Oct 2024 13:54:06 GMT, Boris Ulasevich wrote: > (not a clean backport) > Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport > > Functional jtreg1-3 tests are Ok. > Manual testing: the reproducer shows the problem is fixed with the change (see comments below) This pull request has now been integrated. Changeset: 4b36ef0f Author: Boris Ulasevich Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/4b36ef0f74f9573d210ee680c8c2d4087100bfe5 Stats: 14 lines in 2 files changed: 9 ins; 4 del; 1 mod 8337994: [REDO] Native memory leak when not recording any events Reviewed-by: phh Backport-of: 6a9a867d645b8fe86f4ca2b04a43bf5aa8f9d487 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1095 From bulasevich at openjdk.org Wed Dec 11 14:24:43 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Wed, 11 Dec 2024 14:24:43 GMT Subject: [jdk21u-dev] Integrated: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 22:15:51 GMT, Boris Ulasevich wrote: > Hi all, > > backport https://bugs.openjdk.org/browse/JDK-8295159 to fix broken Java floating-point arithmetic. > > Minor merge conflicts in os_linux.cpp and os_bsd.cpp have been resolved manually. The conflict is with the NativeLibraryLoadEvent tracing applied on the mainline around the dlopen() call: https://github.com/openjdk/jdk/pull/16903 > > The fix passed tier1-3 jtreg tests. > > Thank you This pull request has now been integrated. Changeset: 7e4185a7 Author: Boris Ulasevich Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/7e4185a74e7e47647feac3bda352505c7f8e47cf Stats: 277 lines in 10 files changed: 275 ins; 0 del; 2 mod 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic Reviewed-by: phh Backport-of: df599dbb9b0f0ee96d1ec767ac8821f164ab075d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1111 From szaldana at openjdk.org Wed Dec 11 14:52:30 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 11 Dec 2024 14:52:30 GMT Subject: [jdk21u-dev] Integrated: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop In-Reply-To: <06TnZyucO7FCdROXAIj9s6aBWS1HjfmgQgMWLLrJZ5I=.3411b0c6-c280-4112-b83b-c09f2cb1c503@github.com> References: <06TnZyucO7FCdROXAIj9s6aBWS1HjfmgQgMWLLrJZ5I=.3411b0c6-c280-4112-b83b-c09f2cb1c503@github.com> Message-ID: On Mon, 9 Dec 2024 19:32:06 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [e203df46](https://github.com/openjdk/jdk/commit/e203df46faf610e35e2c2510271ad68199f4fa3f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Roland Westrelin on 5 Sep 2024 and was reviewed by Christian Hagedorn and Tobias Hartmann. > > Thanks! This pull request has now been integrated. Changeset: 14195462 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/1419546268caab4fa3a6a31d259b318693a5ca1a Stats: 308 lines in 7 files changed: 257 ins; 32 del; 19 mod 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop Backport-of: e203df46faf610e35e2c2510271ad68199f4fa3f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1213 From goetz at openjdk.org Wed Dec 11 15:05:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Dec 2024 15:05:31 GMT Subject: [jdk21u-dev] RFR: 8343102: Remove `--compress` from jlink command lines from jpackage tests Message-ID: I backport this to keep 21u testing up to date. Trivial resolves, probably clean. ------------- Commit messages: - Backport 9e451aa36586badc7be58804ae6f12e6b671445d Changes: https://git.openjdk.org/jdk21u-dev/pull/1219/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1219&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343102 Stats: 9 lines in 2 files changed: 0 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1219.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1219/head:pull/1219 PR: https://git.openjdk.org/jdk21u-dev/pull/1219 From goetz at openjdk.org Wed Dec 11 15:23:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 11 Dec 2024 15:23:57 GMT Subject: [jdk21u-dev] RFR: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails Message-ID: I backport this to keep the 21u tests up to date. ------------- Commit messages: - Backport 91ab088d5e64e068bafcda8d08f1769c39ba10d6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1220/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1220&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333116 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1220.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1220/head:pull/1220 PR: https://git.openjdk.org/jdk21u-dev/pull/1220 From robm at openjdk.org Wed Dec 11 16:40:05 2024 From: robm at openjdk.org (Rob McKenna) Date: Wed, 11 Dec 2024 16:40:05 GMT Subject: [jdk24u] RFR: 8346014: Bump version numbers for 24.0.1 Message-ID: version bump ------------- Commit messages: - 8346014: Bump version numbers for 24.0.1 Changes: https://git.openjdk.org/jdk24u/pull/1/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=1&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346014 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk24u/pull/1.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/1/head:pull/1 PR: https://git.openjdk.org/jdk24u/pull/1 From kcr at openjdk.org Wed Dec 11 16:40:40 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Wed, 11 Dec 2024 16:40:40 GMT Subject: [jdk24u] RFR: 8346014: Bump version numbers for 24.0.1 In-Reply-To: References: Message-ID: <_hQ-7fbejaftg3F0Qx4iLrEEz0fPj18AswoB3Gc4qcg=.f8e78962-3eb1-40c6-88fe-984644757668@github.com> On Wed, 11 Dec 2024 16:32:37 GMT, Rob McKenna wrote: > version bump LGTM ------------- Marked as reviewed by kcr (Author). PR Review: https://git.openjdk.org/jdk24u/pull/1#pullrequestreview-2496232670 From duke at openjdk.org Wed Dec 11 16:50:20 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 16:50:20 GMT Subject: [jdk21u-dev] RFR: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 In-Reply-To: References: Message-ID: On Wed, 20 Nov 2024 19:40:14 GMT, Chad Rakoczy wrote: > Backport [JDK-8341194](https://bugs.openjdk.org/browse/JDK-8341194) [REDO] Implement C2 VectorizedHashCode on AArch64 > > Backport is clean. Trivial merge conflicts with includes and already present code. Original implementation [JDK-8322770](https://bugs.openjdk.org/browse/JDK-8322770) caused build and test failures. Build failures that were reproducible with `make bootcycle-images` run on `linux-aarch64 fastdebug/release` successfully. All jtreg and new asmtest pass on `linux-aarch64 release`. @chadrako Your change (at version aeb80d2be126b8ba718fd5e4eef805bd3f84638e) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1170#issuecomment-2536527991 From duke at openjdk.org Wed Dec 11 16:58:23 2024 From: duke at openjdk.org (Chad Rakoczy) Date: Wed, 11 Dec 2024 16:58:23 GMT Subject: [jdk21u-dev] Integrated: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 In-Reply-To: References: Message-ID: On Wed, 20 Nov 2024 19:40:14 GMT, Chad Rakoczy wrote: > Backport [JDK-8341194](https://bugs.openjdk.org/browse/JDK-8341194) [REDO] Implement C2 VectorizedHashCode on AArch64 > > Backport is clean. Trivial merge conflicts with includes and already present code. Original implementation [JDK-8322770](https://bugs.openjdk.org/browse/JDK-8322770) caused build and test failures. Build failures that were reproducible with `make bootcycle-images` run on `linux-aarch64 fastdebug/release` successfully. All jtreg and new asmtest pass on `linux-aarch64 release`. This pull request has now been integrated. Changeset: 990859cc Author: Chad Rakoczy Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/990859cc32776e2d794de539190c9ccced1dfcd9 Stats: 1329 lines in 12 files changed: 748 ins; 0 del; 581 mod 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 Reviewed-by: phh Backport-of: 4fc6d4135e795d18a024a6035908f380b81082d1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1170 From krk at openjdk.org Wed Dec 11 17:31:14 2024 From: krk at openjdk.org (Kerem Kat) Date: Wed, 11 Dec 2024 17:31:14 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed Message-ID: Ref. https://github.com/openjdk/jdk/pull/22479 > We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM Backport depends on [JDK-8339063](https://bugs.openjdk.org/browse/) which is included. JDK-8339063 did not apply cleanly, resolved conflict in `src/hotspot/cpu/aarch64/aarch64.ad` by keeping const qualifiers. These were removed in [JDK-8310948](https://bugs.openjdk.org/browse/JDK-8310948) which doesn't apply cleanly either. Additional testing: - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. ------------- Commit messages: - Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 - 8339063: [aarch64] Skip verify_sve_vector_length after native calls if SVE supports 128 bits VL only Changes: https://git.openjdk.org/jdk21u-dev/pull/1222/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1222&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345296 Stats: 73 lines in 7 files changed: 45 ins; 14 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1222.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1222/head:pull/1222 PR: https://git.openjdk.org/jdk21u-dev/pull/1222 From iris at openjdk.org Wed Dec 11 17:33:33 2024 From: iris at openjdk.org (Iris Clark) Date: Wed, 11 Dec 2024 17:33:33 GMT Subject: [jdk24u] RFR: 8346014: Bump version numbers for 24.0.1 In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 16:32:37 GMT, Rob McKenna wrote: > version bump Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk24u/pull/1#pullrequestreview-2496372148 From aph at openjdk.org Wed Dec 11 17:38:41 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 11 Dec 2024 17:38:41 GMT Subject: [jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well Message-ID: <4LeEOVL3OM57vpgMH9YTOBgyGCucK3L6iWC0XGD60ZQ=.10c0f7c0-897d-45ec-b105-5c4467890d74@github.com> 8180450: secondary_super_cache does not scale well ------------- Commit messages: - Merge from https://github.com/openjdk/jdk21u-dev - 8180450 jdk21u backport - 8337958-Out-of-bounds-array-access-in-secondary_supe.patch - Benchmark - First cut Changes: https://git.openjdk.org/jdk21u-dev/pull/1090/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1090&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8180450 Stats: 1758 lines in 36 files changed: 1709 ins; 20 del; 29 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1090.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1090/head:pull/1090 PR: https://git.openjdk.org/jdk21u-dev/pull/1090 From robm at openjdk.org Wed Dec 11 17:42:33 2024 From: robm at openjdk.org (Rob McKenna) Date: Wed, 11 Dec 2024 17:42:33 GMT Subject: [jdk24u] Integrated: 8346014: Bump version numbers for 24.0.1 In-Reply-To: References: Message-ID: <0b_Tot6pALUUTUceHEiMS3WONumCQQ6piydCvzLiv-8=.449d75f4-8f76-4d5f-8185-fd8393cb474e@github.com> On Wed, 11 Dec 2024 16:32:37 GMT, Rob McKenna wrote: > version bump This pull request has now been integrated. Changeset: f1a12799 Author: Rob McKenna URL: https://git.openjdk.org/jdk24u/commit/f1a12799d240fab5976f59d879c236d565f65c54 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8346014: Bump version numbers for 24.0.1 Reviewed-by: kcr, iris ------------- PR: https://git.openjdk.org/jdk24u/pull/1 From phh at openjdk.org Wed Dec 11 19:17:36 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 11 Dec 2024 19:17:36 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 17:24:05 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Backport depends on [JDK-8339063](https://bugs.openjdk.org/browse/) which is included. > > JDK-8339063 did not apply cleanly, resolved conflict in `src/hotspot/cpu/aarch64/aarch64.ad` by keeping const qualifiers. These were removed in [JDK-8310948](https://bugs.openjdk.org/browse/JDK-8310948) which doesn't apply cleanly either. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. Please add "/issue JDK-8339063" (I'm unsure of the exact syntax, but it's something like that :)), since it's included. Otherwise lgtm. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1222#pullrequestreview-2496607667 From duke at openjdk.org Wed Dec 11 19:27:38 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 19:27:38 GMT Subject: [jdk23u] Withdrawn: 8339475: Clean up return code handling for pthread calls in library coding In-Reply-To: References: Message-ID: <5bR5FY8IdEUyOxve0QlCVpMeEh6uBkilAKwimZC-kwo=.9cc7b6a2-89db-441a-b368-e2b621445b4e@github.com> On Wed, 16 Oct 2024 12:56:45 GMT, Matthias Baesken wrote: > Backport 8339475, includes 8341135 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/184 From rob.mckenna at oracle.com Wed Dec 11 21:59:58 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Wed, 11 Dec 2024 21:59:58 +0000 Subject: [24u Communication] JDK 24 Updates repos are ready Message-ID: https://github.com/openjdk/jdk24u Thanks, -Rob From phh at openjdk.org Thu Dec 12 00:41:40 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 12 Dec 2024 00:41:40 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: <8JvXudLbkNgOM0cRydSOHem2DXiuwhmbUu7XJLBjuQs=.607385c1-4c6b-4088-9d28-cf24e70d434d@github.com> On Wed, 11 Dec 2024 17:24:05 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Backport depends on [JDK-8339063](https://bugs.openjdk.org/browse/) which is included. > > JDK-8339063 did not apply cleanly, resolved conflict in `src/hotspot/cpu/aarch64/aarch64.ad` by keeping const qualifiers. These were removed in [JDK-8310948](https://bugs.openjdk.org/browse/JDK-8310948) which doesn't apply cleanly either. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1222#pullrequestreview-2497317426 From syan at openjdk.org Thu Dec 12 02:38:22 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 12 Dec 2024 02:38:22 GMT Subject: [jdk17u-dev] RFR: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values Message-ID: Hi all, This pull request contains a backport of commit [59fcfae6](https://github.com/openjdk/jdk/commit/59fcfae63090f6659a94a9e3dd0705739ec1b074) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 19 Nov 2024 and was reviewed by David Holmes. Thanks! ------------- Commit messages: - Backport 59fcfae63090f6659a94a9e3dd0705739ec1b074 Changes: https://git.openjdk.org/jdk17u-dev/pull/3108/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3108&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343129 Stats: 20 lines in 1 file changed: 10 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3108.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3108/head:pull/3108 PR: https://git.openjdk.org/jdk17u-dev/pull/3108 From syan at openjdk.org Thu Dec 12 02:39:19 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 12 Dec 2024 02:39:19 GMT Subject: [jdk21u-dev] RFR: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values Message-ID: Hi all, This pull request contains a backport of commit [59fcfae6](https://github.com/openjdk/jdk/commit/59fcfae63090f6659a94a9e3dd0705739ec1b074) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 19 Nov 2024 and was reviewed by David Holmes. Thanks! ------------- Commit messages: - Backport 59fcfae63090f6659a94a9e3dd0705739ec1b074 Changes: https://git.openjdk.org/jdk21u-dev/pull/1223/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1223&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343129 Stats: 20 lines in 1 file changed: 10 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1223.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1223/head:pull/1223 PR: https://git.openjdk.org/jdk21u-dev/pull/1223 From syan at openjdk.org Thu Dec 12 03:14:59 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 12 Dec 2024 03:14:59 GMT Subject: [jdk17u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" Message-ID: Hi all, This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. Thanks! ------------- Commit messages: - Backport 693847452f208446a34186f142fe2c56a49ceceb Changes: https://git.openjdk.org/jdk17u-dev/pull/3109/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320916 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3109.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3109/head:pull/3109 PR: https://git.openjdk.org/jdk17u-dev/pull/3109 From syan at openjdk.org Thu Dec 12 03:16:14 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 12 Dec 2024 03:16:14 GMT Subject: [jdk21u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" Message-ID: <9Q0pipeX67NtZiokcpz5epJ67IbZwQEBym4SXh9PJ-s=.75c8bd21-5d76-42ed-80fc-32f1c14ab013@github.com> Hi all, This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. Thanks! ------------- Commit messages: - Backport 693847452f208446a34186f142fe2c56a49ceceb Changes: https://git.openjdk.org/jdk21u-dev/pull/1224/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1224&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320916 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1224.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1224/head:pull/1224 PR: https://git.openjdk.org/jdk21u-dev/pull/1224 From syan at openjdk.org Thu Dec 12 03:18:40 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 12 Dec 2024 03:18:40 GMT Subject: [jdk11u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" Message-ID: Hi all, This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. Thanks! ------------- Commit messages: - Backport 693847452f208446a34186f142fe2c56a49ceceb Changes: https://git.openjdk.org/jdk11u-dev/pull/2976/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2976&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320916 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2976.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2976/head:pull/2976 PR: https://git.openjdk.org/jdk11u-dev/pull/2976 From goetz at openjdk.org Thu Dec 12 07:14:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 07:14:37 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Mon, 11 Nov 2024 18:17:06 GMT, Boris Ulasevich wrote: >> Reproducer: >> >> import jdk.jfr.consumer.RecordingStream; >> >> /** >> * Stress test to provoke the memory leak: >> * starts 1M empty threads in VM with jfr recording >> */ >> public class PinnedThreadTracker implements AutoCloseable >> { >> private final RecordingStream recordingStream; >> >> public PinnedThreadTracker() { >> recordingStream = new RecordingStream(); >> recordingStream.startAsync(); >> System.out.println("start recording.."); >> } >> >> @Override >> public void close() { >> recordingStream.close(); >> } >> >> class MyThread extends Thread { >> public void run() { >> } >> } >> public void runThreads() { >> for (int i = 0; i < 100; i++) { >> for (int j = 0; j < 100; j++) { >> for (int k = 0; k < 100; k++) { >> new MyThread().start(); >> } >> MyThread thr = new MyThread(); thr.start(); >> try { >> thr.join(); >> } catch (Exception ex) {} >> } >> System.out.print("."); >> } >> } >> >> public static void main(String a[]) { >> PinnedThreadTracker ptt = new PinnedThreadTracker(); >> ptt.runThreads(); >> ptt.close(); >> } >> } >> >> >> Manual testing results on jdk21u: >> >> $ for i in {0..60}; do >> export PID=`ps -ax | grep java | grep PinnedThreadTracker | sed "s/^ *// ; s/ .*//"` >> jcmd $PID VM.native_memory | grep Tracing.*reserved >> sleep 1s >> done >> >> Before the change (jcmd VM.native_memory output once a second): >> - Tracing (reserved=17355KB, committed=17355KB) >> - Tracing (reserved=21646KB, committed=21646KB) >> - Tracing (reserved=25870KB, committed=25870KB) >> - Tracing (reserved=30065KB, committed=30065KB) >> ... >> - Tracing (reserved=240567KB, committed=240567KB) >> - Tracing (reserved=244519KB, committed=244519KB) >> - Tracing (reserved=248525KB, committed=248525KB) >> - Tracing (reserved=252527KB, committed=252527KB) >> >> With the fix: >> - Tracing (reserved=17655KB, committed=17655KB) >> - Tracing (reserved=18125KB, committed=18125KB) >> - Tracing (reserved=18449KB, committed=18449KB) >> - Tracing (reserved=18961KB, committed=18961KB) >> ... >> - ... > >> Hi @bulasevich, can this wait for the April update? It would get some more test coverage. > > Hi @GoeLin > In my opinion, this bug could have a significant impact on customers, and it would be ideal to fix it as soon as possible. However, I understand that some reasonable patience is necessary. I'm not opposed to waiting for the next update. Hi @bulasevich is it possible that your push breaks jdk/jfr/jvm/TestChunkIntegrity.java ? We see this failing in our CI tonight on all platforms. I'll try to reproduce it locally and verify whether it's your change. Veryfying chunk: disassembled/recording_00.jfr 0 Veryfying chunk: disassembled/recording_01.jfr 3338 Veryfying chunk: disassembled/recording_02.jfr 9083 One value null Value A: { type = N/A name = "bootstrap" } Value B: null Field classLoader doesn't match Value A: { type = N/A name = "bootstrap" } Value B: null Field type doesn't match Value A: { classLoader = null name = "jdk/internal/loader/ClassLoaders$AppClassLoader" package = { name = "jdk/internal/loader" module = { name = "java.base" version = "21.0.7-internal" location = "jrt:/java.base" classLoader = null } exported = true } modifiers = 10 hidden = false } Value B: { classLoader = N/A name = "jdk/internal/loader/ClassLoaders$AppClassLoader" package = { name = "jdk/internal/loader" module = { name = "java.base" version = "21.0.7-internal" location = "jrt:/java.base" classLoader = N/A } exported = true } modifiers = 10 hidden = false } Field classLoader doesn't match Value A: { type = jdk.internal.loader.ClassLoaders$AppClassLoader (classLoader = bootstrap) name = "app" } Value B: { type = jdk.internal.loader.ClassLoaders$AppClassLoader (classLoader = null) name = "app" } Field type doesn't match Value A: { classLoader = jdk.internal.loader.ClassLoaders$AppClassLoader (id = 3) name = "jdk/jfr/jvm/TestChunkIntegrity$ClassStressor" package = { name = "jdk/jfr/jvm" module = { name = N/A version = N/A location = N/A classLoader = jdk.internal.loader.ClassLoaders$AppClassLoader (id = 3) } exported = true } modifiers = 8 hidden = false } Value B: { classLoader = jdk.internal.loader.ClassLoaders$AppClassLoader (id = 3) name = "jdk/jfr/jvm/TestChunkIntegrity$ClassStressor" package = { name = "jdk/jfr/jvm" module = { name = N/A version = N/A location = N/A classLoader = jdk.internal.loader.ClassLoaders$AppClassLoader (id = 3) } exported = true } modifiers = 8 hidden = false } Field method doesn't match Value A: { type = jdk.jfr.jvm.TestChunkIntegrity$ClassStressor (classLoader = app) name = "stress" descriptor = "()V" modifiers = 4 hidden = false } Value B: { type = jdk.jfr.jvm.TestChunkIntegrity$ClassStressor (classLoader = app) name = "stress" descriptor = "()V" modifiers = 4 hidden = false } Array contents doesn't match Field frames doesn't match Value A: [Ljava.lang.Object;@16e87903 Value B: [Ljava.lang.Object;@466281af Object A: Clazz { startTime = 01:26:04.779 (2024-12-12) clazz = jdk.jfr.jvm.TestChunkIntegrity$MyClass (classLoader = JFR TestClassLoader) eventThread = "Thread-1" (javaThreadId = 33) stackTrace = [ jdk.jfr.jvm.TestChunkIntegrity$ClassStressor.stress() line: 272 jdk.jfr.jvm.TestChunkIntegrity$StressThread.run() line: 75 ] } Object B: Clazz { startTime = 01:26:04.779 (2024-12-12) clazz = jdk.jfr.jvm.TestChunkIntegrity$MyClass (classLoader = JFR TestClassLoader) eventThread = "Thread-1" (javaThreadId = 33) stackTrace = [ jdk.jfr.jvm.TestChunkIntegrity$ClassStressor.stress() line: 272 jdk.jfr.jvm.TestChunkIntegrity$StressThread.run() line: 75 ] } ----------System.err:(12/755)---------- java.lang.AssertionError: Events don't match. Event number 0 at jdk.jfr.jvm.TestChunkIntegrity.assertEventEquals(TestChunkIntegrity.java:174) at jdk.jfr.jvm.TestChunkIntegrity.main(TestChunkIntegrity.java:131) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:1583) JavaTest Message: Test threw exception: java.lang.AssertionError: Events don't match. Event number 0 JavaTest Message: shutting down test STATUS:Failed.`main' threw exception: java.lang.AssertionError: Events don't match. Event number 0 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2537988846 From goetz at openjdk.org Thu Dec 12 07:33:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 07:33:44 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Mon, 11 Nov 2024 18:17:06 GMT, Boris Ulasevich wrote: >> Reproducer: >> >> import jdk.jfr.consumer.RecordingStream; >> >> /** >> * Stress test to provoke the memory leak: >> * starts 1M empty threads in VM with jfr recording >> */ >> public class PinnedThreadTracker implements AutoCloseable >> { >> private final RecordingStream recordingStream; >> >> public PinnedThreadTracker() { >> recordingStream = new RecordingStream(); >> recordingStream.startAsync(); >> System.out.println("start recording.."); >> } >> >> @Override >> public void close() { >> recordingStream.close(); >> } >> >> class MyThread extends Thread { >> public void run() { >> } >> } >> public void runThreads() { >> for (int i = 0; i < 100; i++) { >> for (int j = 0; j < 100; j++) { >> for (int k = 0; k < 100; k++) { >> new MyThread().start(); >> } >> MyThread thr = new MyThread(); thr.start(); >> try { >> thr.join(); >> } catch (Exception ex) {} >> } >> System.out.print("."); >> } >> } >> >> public static void main(String a[]) { >> PinnedThreadTracker ptt = new PinnedThreadTracker(); >> ptt.runThreads(); >> ptt.close(); >> } >> } >> >> >> Manual testing results on jdk21u: >> >> $ for i in {0..60}; do >> export PID=`ps -ax | grep java | grep PinnedThreadTracker | sed "s/^ *// ; s/ .*//"` >> jcmd $PID VM.native_memory | grep Tracing.*reserved >> sleep 1s >> done >> >> Before the change (jcmd VM.native_memory output once a second): >> - Tracing (reserved=17355KB, committed=17355KB) >> - Tracing (reserved=21646KB, committed=21646KB) >> - Tracing (reserved=25870KB, committed=25870KB) >> - Tracing (reserved=30065KB, committed=30065KB) >> ... >> - Tracing (reserved=240567KB, committed=240567KB) >> - Tracing (reserved=244519KB, committed=244519KB) >> - Tracing (reserved=248525KB, committed=248525KB) >> - Tracing (reserved=252527KB, committed=252527KB) >> >> With the fix: >> - Tracing (reserved=17655KB, committed=17655KB) >> - Tracing (reserved=18125KB, committed=18125KB) >> - Tracing (reserved=18449KB, committed=18449KB) >> - Tracing (reserved=18961KB, committed=18961KB) >> ... >> - ... > >> Hi @bulasevich, can this wait for the April update? It would get some more test coverage. > > Hi @GoeLin > In my opinion, this bug could have a significant impact on customers, and it would be ideal to fix it as soon as possible. However, I understand that some reasonable patience is necessary. I'm not opposed to waiting for the next update. Hi @bulasevich, @phohensee, yes, this is easy to reproduce. I think we should backout this if there is not a simple and quick solution. I will create a backout change around 14:00 CET, this should make the build of our nightly tests. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2538016182 From goetz at openjdk.org Thu Dec 12 07:35:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 07:35:43 GMT Subject: [jdk21u-dev] RFR: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file In-Reply-To: References: Message-ID: <8oUaZ-ZbA9S0mGW9jLpyhJiPwEwe5z0r8GWTeCeco5k=.53b88909-7f6e-4ec8-aa4c-549490764c28@github.com> On Wed, 11 Dec 2024 13:36:52 GMT, Goetz Lindenmaier wrote: > I backport this to keep testing up to date. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1218#issuecomment-2538020844 From goetz at openjdk.org Thu Dec 12 07:37:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 07:37:38 GMT Subject: [jdk21u-dev] RFR: 8343102: Remove `--compress` from jlink command lines from jpackage tests In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 14:45:33 GMT, Goetz Lindenmaier wrote: > I backport this to keep 21u testing up to date. > > Trivial resolves, probably clean. GHA failures: Six times well known wget issue, unrelated. Tests are covered by our nightly CI. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1219#issuecomment-2538023925 From duke at openjdk.org Thu Dec 12 07:52:39 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 12 Dec 2024 07:52:39 GMT Subject: [jdk11u-dev] RFR: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 [v5] In-Reply-To: References: Message-ID: On Wed, 27 Nov 2024 16:01:09 GMT, Antonio Vieiro wrote: >> An implementation of [JDK-8343786](https://bugs.openjdk.org/browse/JDK-8343786) that bumps the GHA runners versions to `macos-13` and `XCode 14.3.1`. >> >> This uses the `--enable-xcode14` configuration flag introduced in https://github.com/openjdk/jdk11u-dev/pull/2966 ([JDK-8344458](https://bugs.openjdk.org/browse/JDK-8344458)) to build and run tier-1 tests on `macos-13` and `XCode 14.3.1`. >> >> Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to [JDK-8260389](https://bugs.openjdk.org/browse/JDK-8260389) or [JDK-8277079](https://bugs.openjdk.org/browse/JDK-8277079). >> >> The rest of `tier1` tests are expected to pass on this platform. > > Antonio Vieiro has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Use --disable-warnings-as-errors for building on XCode 14 and up > - 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 After some investigation it seems that the `ArrayIndexOutOfBoundsException` is just a consequence of a previous error: 2024-11-27T16:35:06.3750870Z Opening core file, please wait... 2024-11-27T16:35:06.3751320Z ERROR: failed to workaround classshareing 2024-11-27T16:35:06.3751780Z Unable to open core file I applied [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) "SA core file support is broken on macosx-x64 starting with macOS 12.x" [in this fork](https://github.com/vieiro/jdk11u-dev/actions/runs/12261423128) and the core files are now properly parsed and the test passes without problems. I'll try to backport JDK-8294316 to upper OpenJDK versions and get it into 11. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2967#issuecomment-2538048579 From clanger at openjdk.org Thu Dec 12 07:54:43 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 12 Dec 2024 07:54:43 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 09:45:55 GMT, Goetz Lindenmaier wrote: > I would like to backport this fix for the mac build. > > I had to move the code to another file, the code is the same, though. > "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to > a new file. Maybe you want to inline https://bugs.openjdk.org/browse/JDK-8342858 in here? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1210#issuecomment-2538052693 From goetz at openjdk.org Thu Dec 12 08:59:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 08:59:42 GMT Subject: [jdk21u-dev] Integrated: 8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 09:14:58 GMT, Goetz Lindenmaier wrote: > A simple change to improve code heap analytics. This pull request has now been integrated. Changeset: d554f2b0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d554f2b08f867e1d3f2a0465d3cbd5ca2e501b3a Stats: 21 lines in 2 files changed: 21 ins; 0 del; 0 mod 8316885: jcmd: Compiler.CodeHeap_Analytics cmd does not inform about missing aggregate Backport-of: 1230aed61d286fe9c09f46e2bab626d0e8fe0273 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1209 From goetz at openjdk.org Thu Dec 12 09:04:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 09:04:43 GMT Subject: [jdk21u-dev] Integrated: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 14:53:09 GMT, Goetz Lindenmaier wrote: > I backport this to keep the 21u tests up to date. This pull request has now been integrated. Changeset: 8600d8e1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/8600d8e1488cb7eaf22fb2683f26cb2b9cb24d7b Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails Backport-of: 91ab088d5e64e068bafcda8d08f1769c39ba10d6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1220 From goetz at openjdk.org Thu Dec 12 09:04:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 09:04:42 GMT Subject: [jdk17u-dev] Integrated: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 13:43:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.13-oracle. > > Omitted ProblemList change, problem listing it was not backported. This pull request has now been integrated. Changeset: c12baf16 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c12baf1697e061bc053aea2f160c8baa31d71a9b Stats: 40 lines in 2 files changed: 37 ins; 0 del; 3 mod 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only Reviewed-by: lucy Backport-of: 20579e48cf598e890aa35c5518ec8d0594f45385 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3104 From goetz at openjdk.org Thu Dec 12 09:10:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 09:10:42 GMT Subject: [jdk21u-dev] Integrated: 8343102: Remove `--compress` from jlink command lines from jpackage tests In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 14:45:33 GMT, Goetz Lindenmaier wrote: > I backport this to keep 21u testing up to date. > > Trivial resolves, probably clean. This pull request has now been integrated. Changeset: c02fd228 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c02fd228bb0ee7865a133ec28bc6e46360529841 Stats: 9 lines in 2 files changed: 0 ins; 6 del; 3 mod 8343102: Remove `--compress` from jlink command lines from jpackage tests Backport-of: 9e451aa36586badc7be58804ae6f12e6b671445d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1219 From goetz at openjdk.org Thu Dec 12 09:11:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 09:11:41 GMT Subject: [jdk21u-dev] Integrated: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 13:36:52 GMT, Goetz Lindenmaier wrote: > I backport this to keep testing up to date. This pull request has now been integrated. Changeset: 814566b1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/814566b10accb1f55b9bcd3c0fe79dc9512d40db Stats: 254 lines in 5 files changed: 87 ins; 146 del; 21 mod 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file Backport-of: 00fe9f7bdfd245791bca6b5b1b2d0a98d41af221 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1218 From goetz at openjdk.org Thu Dec 12 09:12:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 09:12:37 GMT Subject: [jdk17u-dev] Integrated: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 13:38:40 GMT, Goetz Lindenmaier wrote: > I backport this to keep testing up to date. This pull request has now been integrated. Changeset: 8c2f28a2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8c2f28a2bba681bb8e7671f4caade77b040d6250 Stats: 254 lines in 5 files changed: 87 ins; 146 del; 21 mod 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file Backport-of: 00fe9f7bdfd245791bca6b5b1b2d0a98d41af221 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3107 From goetz at openjdk.org Thu Dec 12 09:21:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 09:21:51 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error [v2] In-Reply-To: References: Message-ID: > I would like to backport this fix for the mac build. > > I had to move the code to another file, the code is the same, though. > "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to > a new file. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Backport follow-up fix 8342858 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1210/files - new: https://git.openjdk.org/jdk21u-dev/pull/1210/files/c3500997..48013d48 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1210&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1210&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1210.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1210/head:pull/1210 PR: https://git.openjdk.org/jdk21u-dev/pull/1210 From goetz at openjdk.org Thu Dec 12 09:21:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 09:21:52 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 09:45:55 GMT, Goetz Lindenmaier wrote: > I would like to backport this fix for the mac build. > > I had to move the code to another file, the code is the same, though. > "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to > a new file. Good point, thanks for catching this! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1210#issuecomment-2538300906 From syan at openjdk.org Thu Dec 12 09:37:54 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 12 Dec 2024 09:37:54 GMT Subject: [jdk11u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 03:11:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! GHA report several failures: 1. `linux-x64 / build` fails at `Get JTReg` stage which fails `wget exited with exit code 4`, seems infrastructure issue or environmental issue, it's unralated to this PR. 2. ` linux-x64-hs-minimal / build` fails at `Get JTReg` stage which fails `wget exited with exit code 4`, seems infrastructure issue or environmental issue, it's unralated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2976#issuecomment-2538363917 From shade at openjdk.org Thu Dec 12 10:51:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 12 Dec 2024 10:51:36 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 17:24:05 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Backport depends on [JDK-8339063](https://bugs.openjdk.org/browse/) which is included. > > JDK-8339063 did not apply cleanly, resolved conflict in `src/hotspot/cpu/aarch64/aarch64.ad` by keeping const qualifiers. These were removed in [JDK-8310948](https://bugs.openjdk.org/browse/JDK-8310948) which doesn't apply cleanly either. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. Seeing the report for Corretto 21 that demonstrates this issue affects some MacOS and Alpine configs: https://github.com/corretto/corretto-21/issues/85 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2538532772 From martin.doerr at sap.com Thu Dec 12 11:06:04 2024 From: martin.doerr at sap.com (Doerr, Martin) Date: Thu, 12 Dec 2024 11:06:04 +0000 Subject: Result: New JDK Updates Committer: Amit Kumar Message-ID: Voting [1] for Amit Kumar [2] is now closed. Yes: 12 Veto: 0 Abstain: 0 According to the bylaw's definition of Lazy Consensus [3], this is sufficient to approve the nomination. Thanks, Martin [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-November/039550.html [2] https://openjdk.org/census#amitkumar [3] https://openjdk.org/bylaws#lazy-consensus -------------- next part -------------- An HTML attachment was scrubbed... URL: From shade at openjdk.org Thu Dec 12 11:14:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 12 Dec 2024 11:14:36 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 17:24:05 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Backport depends on [JDK-8339063](https://bugs.openjdk.org/browse/) which is included. > > JDK-8339063 did not apply cleanly, resolved conflict in `src/hotspot/cpu/aarch64/aarch64.ad` by keeping const qualifiers. These were removed in [JDK-8310948](https://bugs.openjdk.org/browse/JDK-8310948) which doesn't apply cleanly either. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. I am not entirely convinced the modifications that [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) does to this code are 100% safe. It tries to install the max vector size and exits the VM if not possible? That sounds like a behavioral change with unknown consequences. And unfortunately, that patch is only in JDK 24, so we do not yet know the impact well. Looks like we are mixing that backport because we need access to new `FloatRegister` constants? If so, I think it would be safer to just take that particular hunk in `register_aarch64.hpp` only. Then if/when we do [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) backport, it would slide right in. And meanwhile, we keep our reliability posture better. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2538581467 From bulasevich at openjdk.org Thu Dec 12 11:27:37 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 12 Dec 2024 11:27:37 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 07:30:02 GMT, Goetz Lindenmaier wrote: >>> Hi @bulasevich, can this wait for the April update? It would get some more test coverage. >> >> Hi @GoeLin >> In my opinion, this bug could have a significant impact on customers, and it would be ideal to fix it as soon as possible. However, I understand that some reasonable patience is necessary. I'm not opposed to waiting for the next update. > > Hi @bulasevich, @phohensee, > yes, this is easy to reproduce. > I think we should backout this if there is not a simple and quick solution. > I will create a backout change around 14:00 CET, this should make the build of our nightly tests. @GoeLin , thanks for reporting. The test passes on my x86 and aarch machines with latest jdk21u-dev. Do you have any insight into why it behaves differently on your side? x86$ /ws/jtreg-7.4/bin/jtreg -jdk:build/linux-x86_64-server-release/jdk/ test/jdk/jdk/jfr/jvm/TestChunkIntegrity.java Test results: passed: 1 x86$ /ws/jtreg-7.4/bin/jtreg -jdk:build/linux-x86_64-server-fastdebug/jdk/ test/jdk/jdk/jfr/jvm/TestChunkIntegrity.java Test results: passed: 1 aarch$ git clone https://github.com/openjdk/jdk21u-dev.git ; cd jdk21u-dev aarch$ bash configure --with-boot-jdk=/ws/jdk-21 ; make aarch$ bash configure --with-boot-jdk=/ws/jdk-21 --with-debug-level=fastdebug; make CONF=debug aarch$ ~/jtreg-7.4/bin/jtreg -jdk:build/linux-aarch64-server-release/jdk/ test/jdk/jdk/jfr/jvm/TestChunkIntegrity.java Test results: passed: 1 aarch$ ~/jtreg-7.4/bin/jtreg -jdk:build/linux-aarch64-server-fastdebug/jdk/ test/jdk/jdk/jfr/jvm/TestChunkIntegrity.java Test results: passed: 1 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2538618401 From krk at openjdk.org Thu Dec 12 11:43:39 2024 From: krk at openjdk.org (Kerem Kat) Date: Thu, 12 Dec 2024 11:43:39 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 17:24:05 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Backport depends on [JDK-8339063](https://bugs.openjdk.org/browse/) which is included. > > JDK-8339063 did not apply cleanly, resolved conflict in `src/hotspot/cpu/aarch64/aarch64.ad` by keeping const qualifiers. These were removed in [JDK-8310948](https://bugs.openjdk.org/browse/JDK-8310948) which doesn't apply cleanly either. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. Thanks for the details. Yes, it was to access the new `FloatRegister` constants. Simplifying this now. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2538653197 From goetz at openjdk.org Thu Dec 12 11:51:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 11:51:16 GMT Subject: [jdk17u-dev] RFR: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: Message-ID: I backport this to improve testing on win. ------------- Commit messages: - Backport 1b104b63a97ec947b34b85658153ab6c182cb56c Changes: https://git.openjdk.org/jdk17u-dev/pull/3110/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314909 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3110.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3110/head:pull/3110 PR: https://git.openjdk.org/jdk17u-dev/pull/3110 From goetz at openjdk.org Thu Dec 12 11:52:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 11:52:25 GMT Subject: [jdk21u-dev] RFR: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: Message-ID: <30042c-FoHR6n6EiF_CxdlbVTmBSRXGduZ1C3SpXhco=.ff95ced1-298c-447a-9e50-164f82f5a111@github.com> I backport this to improve testing on win. ------------- Commit messages: - Backport 1b104b63a97ec947b34b85658153ab6c182cb56c Changes: https://git.openjdk.org/jdk21u-dev/pull/1225/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1225&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314909 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1225.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1225/head:pull/1225 PR: https://git.openjdk.org/jdk21u-dev/pull/1225 From duke at openjdk.org Thu Dec 12 12:03:17 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 12 Dec 2024 12:03:17 GMT Subject: [jdk11u-dev] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 Message-ID: Backport of [JDK-8340387](https://bugs.openjdk.org/browse/JDK-8340387) to update OS detection code to recognize Windows Server 2025. This is a clean backport (but for copyright headers). Passes tier1 tests on Windows. ------------- Commit messages: - Backport d2b244d8de68caf911d0639abba802ead2620b2d Changes: https://git.openjdk.org/jdk11u-dev/pull/2977/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2977&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340387 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2977.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2977/head:pull/2977 PR: https://git.openjdk.org/jdk11u-dev/pull/2977 From goetz at openjdk.org Thu Dec 12 12:43:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 12:43:44 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 24 Oct 2024 13:54:06 GMT, Boris Ulasevich wrote: > (not a clean backport) > Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport > > Functional jtreg1-3 tests are Ok. > Manual testing: the reproducer shows the problem is fixed with the change (see comments below) Hi, no, I did not look deeper into this. I can reproduce it with the current jdk21u-dev. If I remove your change, the test passes. Locally I use the slowdebug build. Our nighttests failed on linux aarch/ppc, mac x64/aarch. linuxx86_64 and windows are pending. The nightly tests use fastdebug. If I use the nightly release build it passes. Maybe you need to try one of the debug builds? ... ah I see you did ... ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2538792180 From goetz at openjdk.org Thu Dec 12 12:56:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 12:56:39 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 24 Oct 2024 13:54:06 GMT, Boris Ulasevich wrote: > (not a clean backport) > Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport > > Functional jtreg1-3 tests are Ok. > Manual testing: the reproducer shows the problem is fixed with the change (see comments below) There are no fixes for TestChunkIntegrity that are missing in 21: https://github.com/openjdk/jdk/commits/master/test/jdk/jdk/jfr/jvm/TestChunkIntegrity.java . It seems to be a timing issue, sometimes it passes with the fastdebug for me locally. The nightly tests run under a lot of stress, so timing problems show there more often. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2538825738 From krk at openjdk.org Thu Dec 12 13:11:39 2024 From: krk at openjdk.org (Kerem Kat) Date: Thu, 12 Dec 2024 13:11:39 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v2] In-Reply-To: References: Message-ID: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Backport depends on [JDK-8339063](https://bugs.openjdk.org/browse/) which is included. > > JDK-8339063 did not apply cleanly, resolved conflict in `src/hotspot/cpu/aarch64/aarch64.ad` by keeping const qualifiers. These were removed in [JDK-8310948](https://bugs.openjdk.org/browse/JDK-8310948) which doesn't apply cleanly either. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1222/files - new: https://git.openjdk.org/jdk21u-dev/pull/1222/files/8ec87dce..3fc28084 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1222&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1222&range=00-01 Stats: 2257 lines in 45 files changed: 1402 ins; 204 del; 651 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1222.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1222/head:pull/1222 PR: https://git.openjdk.org/jdk21u-dev/pull/1222 From krk at openjdk.org Thu Dec 12 13:14:37 2024 From: krk at openjdk.org (Kerem Kat) Date: Thu, 12 Dec 2024 13:14:37 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v2] In-Reply-To: References: Message-ID: <3uAbEQJ9DavSHjH6r0Fop1kyfXXGzzIsazgGbnUqRT0=.822ad7ae-cb25-4936-80e2-f5609ae996cf@github.com> On Thu, 12 Dec 2024 13:11:39 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 Picked only the necessary hunks from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2538870999 From bulasevich at openjdk.org Thu Dec 12 13:15:47 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 12 Dec 2024 13:15:47 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 24 Oct 2024 13:54:06 GMT, Boris Ulasevich wrote: > (not a clean backport) > Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport > > Functional jtreg1-3 tests are Ok. > Manual testing: the reproducer shows the problem is fixed with the change (see comments below) Good. - I reproduce the fail on slowdebug build on jdk21u on x86 and aarch - the fail is introduced by this commit - the test is the same on jdk21u vs mainline, but mainline slowdebug build passes this test ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2538875444 From shade at openjdk.org Thu Dec 12 13:17:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 12 Dec 2024 13:17:41 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v2] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 13:11:39 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 Also need `/issue remove JDK-8339063` now? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2538882448 From bulasevich at openjdk.org Thu Dec 12 13:19:38 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 12 Dec 2024 13:19:38 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 07:30:02 GMT, Goetz Lindenmaier wrote: > I think we should backout this if there is not a simple and quick solution. > I will create a backout change around 14:00 CET, this should make the build of our nightly tests. I do not have simple and quick solution now. What it the procedure? You backout the change now and I will try again later once the solution is found? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2538889408 From krk at openjdk.org Thu Dec 12 13:22:39 2024 From: krk at openjdk.org (Kerem Kat) Date: Thu, 12 Dec 2024 13:22:39 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v2] In-Reply-To: References: Message-ID: <4DNQpDMYcVXhyiLZ8tp1QJf3dvuAnGSrIjetpdP9hU0=.5e71c2e1-a32e-430f-b165-b6e6f11a0abf@github.com> On Thu, 12 Dec 2024 13:11:39 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 I only included an independeny chunk, not implementing JDK-8339063. It could be independently reviewed. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2538899618 From shade at openjdk.org Thu Dec 12 13:29:42 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 12 Dec 2024 13:29:42 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v2] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 13:11:39 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 This looks correct. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1222#pullrequestreview-2499573183 From krk at openjdk.org Thu Dec 12 13:42:00 2024 From: krk at openjdk.org (Kerem Kat) Date: Thu, 12 Dec 2024 13:42:00 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. Kerem Kat has updated the pull request incrementally with one additional commit since the last revision: Fix linux-cross-compile aarch64 build. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1222/files - new: https://git.openjdk.org/jdk21u-dev/pull/1222/files/3fc28084..704459c2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1222&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1222&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1222.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1222/head:pull/1222 PR: https://git.openjdk.org/jdk21u-dev/pull/1222 From duke at openjdk.org Thu Dec 12 13:54:40 2024 From: duke at openjdk.org (Thomas Fitzsimmons) Date: Thu, 12 Dec 2024 13:54:40 GMT Subject: [jdk17u-dev] RFR: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: In-Reply-To: References: Message-ID: <02e1ytdmu3wTC8N7itwx24iKOtLxS5b08uxJ5ZKFwP0=.842255d5-9321-4939-906c-8732e082611e@github.com> On Thu, 12 Dec 2024 11:44:48 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing on win. Typos in the comment: `platfrom == windowws` => `platform == windows`. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3110#issuecomment-2539018747 From shade at openjdk.org Thu Dec 12 13:56:47 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 12 Dec 2024 13:56:47 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 13:42:00 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request incrementally with one additional commit since the last revision: > > Fix linux-cross-compile aarch64 build. Right, include as well. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1222#pullrequestreview-2499709655 From krk at openjdk.org Thu Dec 12 14:16:05 2024 From: krk at openjdk.org (Kerem Kat) Date: Thu, 12 Dec 2024 14:16:05 GMT Subject: [jdk17u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed Message-ID: Ref. https://github.com/openjdk/jdk/pull/22479 > We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. Additional testing: - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. ------------- Commit messages: - Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3111/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345296 Stats: 27 lines in 2 files changed: 23 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3111.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3111/head:pull/3111 PR: https://git.openjdk.org/jdk17u-dev/pull/3111 From shade at openjdk.org Thu Dec 12 15:03:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 12 Dec 2024 15:03:37 GMT Subject: [jdk17u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 14:11:14 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. This looks right, thanks. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3111#pullrequestreview-2499930068 From krk at openjdk.org Thu Dec 12 15:23:50 2024 From: krk at openjdk.org (Kerem Kat) Date: Thu, 12 Dec 2024 15:23:50 GMT Subject: [jdk23u] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed Message-ID: Ref. https://github.com/openjdk/jdk/pull/22479 > We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. Additional testing: - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. ------------- Commit messages: - Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 Changes: https://git.openjdk.org/jdk23u/pull/231/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=231&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345296 Stats: 22 lines in 2 files changed: 19 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk23u/pull/231.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/231/head:pull/231 PR: https://git.openjdk.org/jdk23u/pull/231 From goetz at openjdk.org Thu Dec 12 15:28:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 15:28:42 GMT Subject: [jdk21u-dev] RFR: 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 24 Oct 2024 13:54:06 GMT, Boris Ulasevich wrote: > (not a clean backport) > Reworked to avoid https://github.com/openjdk/jdk/pull/17328/files backport > > Functional jtreg1-3 tests are Ok. > Manual testing: the reproducer shows the problem is fixed with the change (see comments below) Yes, the problem is not obvious enough to find a quick fix, so let's backout. You might want to have a look here: https://github.com/openjdk/jdk21u-dev/pull/1226 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1095#issuecomment-2539281546 From goetz at openjdk.org Thu Dec 12 15:32:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 15:32:46 GMT Subject: [jdk21u-dev] RFR: 8346108: [21u][BACKOUT] 8337994: [REDO] Native memory leak when not recording any events Message-ID: The backport fo 8337994 causes test failures, so I want to back it out. ------------- Commit messages: - 8346108: [21u][BACKOUT] 8337994: [REDO] Native memory leak when not recording any events Changes: https://git.openjdk.org/jdk21u-dev/pull/1226/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1226&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346108 Stats: 14 lines in 2 files changed: 4 ins; 9 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1226.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1226/head:pull/1226 PR: https://git.openjdk.org/jdk21u-dev/pull/1226 From bulasevich at openjdk.org Thu Dec 12 15:32:47 2024 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 12 Dec 2024 15:32:47 GMT Subject: [jdk21u-dev] RFR: 8346108: [21u][BACKOUT] 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 15:24:45 GMT, Goetz Lindenmaier wrote: > The backport fo 8337994 causes test failures, so I want to back it out. All right. Thank you. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1226#issuecomment-2539290430 From duke at openjdk.org Thu Dec 12 15:36:45 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 12 Dec 2024 15:36:45 GMT Subject: [jdk11u-dev] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 In-Reply-To: References: Message-ID: <3YWoCUJl6WHUPHWo8hvPWFNOtEXW8AxaE69FHsVFwkg=.492873c1-c01c-46a6-9608-0713c28a0855@github.com> On Thu, 12 Dec 2024 11:57:30 GMT, Antonio Vieiro wrote: > Backport of [JDK-8340387](https://bugs.openjdk.org/browse/JDK-8340387) to update OS detection code to recognize Windows Server 2025. This is a clean backport (but for copyright headers). Passes tier1 tests on Windows. Build failures are unrelated and are due to - downloads of ant binaries not complying with the [archive.apache.org ban policies](https://infra.apache.org/infra-ban.html) - MacOS GHA runner deprecation https://github.com/openjdk/jdk11u-dev/pull/2967 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2977#issuecomment-2539300542 From mdoerr at openjdk.org Thu Dec 12 15:50:40 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 12 Dec 2024 15:50:40 GMT Subject: [jdk21u-dev] RFR: 8346108: [21u][BACKOUT] 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 15:24:45 GMT, Goetz Lindenmaier wrote: > The backport fo 8337994 causes test failures, so I want to back it out. Backout looks correct. Commit was https://github.com/openjdk/jdk21u-dev/commit/4b36ef0f74f9573d210ee680c8c2d4087100bfe5 ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1226#pullrequestreview-2500065554 From duke at openjdk.org Thu Dec 12 15:59:53 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 12 Dec 2024 15:59:53 GMT Subject: [jdk21u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x Message-ID: A clean backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. The fix doesn't affect directly to SA tests in `21`, but it's being backported to `11` as this is the cause of [an older version of `serviceability/sa/ClhsdbFindPC.java` failing in JDK 11 on macos-13 GHA runners](https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579). Tests in 21 continue to pass in all platforms, including `macos`. ------------- Commit messages: - Backport 269852b90634aa43d4d719c93563608e42792fc6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1227/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1227&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294316 Stats: 17 lines in 2 files changed: 5 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1227.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1227/head:pull/1227 PR: https://git.openjdk.org/jdk21u-dev/pull/1227 From goetz at openjdk.org Thu Dec 12 16:10:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 16:10:39 GMT Subject: [jdk21u-dev] RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform In-Reply-To: References: Message-ID: On Tue, 26 Nov 2024 13:21:15 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8344275 : tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform > > Original patch does not apply cleanly because JDK-8340311 and JDK-8343314 are not applied to jdk21. > JDK-8340311 and JDK-8343314 are enhancement, so I don't backport them. > > Testing: tools/jpackage tests importing jdk.jpackage.test.Executor on Windows Server 2019 (Japanese and English locales) > > Thanks. Hi, I am currently backporting 8343314, will approve after pushing that. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1182#issuecomment-2539386762 From goetz at openjdk.org Thu Dec 12 16:17:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 16:17:37 GMT Subject: [jdk21u-dev] RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 In-Reply-To: References: Message-ID: On Fri, 4 Oct 2024 12:01:25 GMT, Sorna Sarathi wrote: > Hi all, > This pull request contains a backport of commit [3251eea](https://github.com/openjdk/jdk/commit/3251eea1f4289a0505052be204407c02ca38b0ad) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > Tier1 testing is successful. > Thanks! > > JBS Issue: [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499) Hi @Sorna-Sarathi, I still would like to see some more testing. Removing the label in the meantime. Same for 17. Also please check the failures in the Pre-submit tests. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1021#issuecomment-2539401039 From duke at openjdk.org Thu Dec 12 16:24:14 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 12 Dec 2024 16:24:14 GMT Subject: [jdk11u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project Message-ID: <29DqDD531agnTgugS5-XFfKVdpQC5yuYISmpDBdJ7YQ=.2b87ed23-4ea8-4ab4-a59d-0f9421317491@github.com> Backport of [JDK-8343474](https://bugs.openjdk.org/browse/JDK-8343474). All links checked. ------------- Commit messages: - Backport ac1f86887384f0e3cf9becdeb9ee1e54fd4e60cb Changes: https://git.openjdk.org/jdk11u-dev/pull/2978/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2978&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343474 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2978.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2978/head:pull/2978 PR: https://git.openjdk.org/jdk11u-dev/pull/2978 From goetz at openjdk.org Thu Dec 12 16:56:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 16:56:38 GMT Subject: [jdk21u-dev] RFR: 8346108: [21u][BACKOUT] 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 15:24:45 GMT, Goetz Lindenmaier wrote: > The backport fo 8337994 causes test failures, so I want to back it out. GHA failure: three times well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1226#issuecomment-2539496577 From goetz at openjdk.org Thu Dec 12 16:56:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 12 Dec 2024 16:56:38 GMT Subject: [jdk21u-dev] Integrated: 8346108: [21u][BACKOUT] 8337994: [REDO] Native memory leak when not recording any events In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 15:24:45 GMT, Goetz Lindenmaier wrote: > The backport fo 8337994 causes test failures, so I want to back it out. This pull request has now been integrated. Changeset: e7111b2d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e7111b2d0c27518da4751a022b96e1dd7bffa723 Stats: 14 lines in 2 files changed: 4 ins; 9 del; 1 mod 8346108: [21u][BACKOUT] 8337994: [REDO] Native memory leak when not recording any events Reviewed-by: mdoerr ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1226 From sgehwolf at openjdk.org Thu Dec 12 17:27:50 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 12 Dec 2024 17:27:50 GMT Subject: [jdk11u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project In-Reply-To: <29DqDD531agnTgugS5-XFfKVdpQC5yuYISmpDBdJ7YQ=.2b87ed23-4ea8-4ab4-a59d-0f9421317491@github.com> References: <29DqDD531agnTgugS5-XFfKVdpQC5yuYISmpDBdJ7YQ=.2b87ed23-4ea8-4ab4-a59d-0f9421317491@github.com> Message-ID: On Thu, 12 Dec 2024 16:18:15 GMT, Antonio Vieiro wrote: > Backport of [JDK-8343474](https://bugs.openjdk.org/browse/JDK-8343474). > > All links checked. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2978#pullrequestreview-2500339069 From rrich at openjdk.org Thu Dec 12 19:44:54 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 12 Dec 2024 19:44:54 GMT Subject: [jdk21u-dev] RFR: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate() Message-ID: Hi all, This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/93aa7e2fcf87c4dc62de4ea71be543ee677b11be. The commit being backported was authored by Richard Reingruber on 21 Nov 2024 and was reviewed by Tobias Hartmann and Martin Doerr. The original commit did not apply because the `TracePhase` constructor used above the removed line was changed. The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. Thanks, Richard. ------------- Commit messages: - 8328085: C2: Use after free in PhaseChaitin::Register_Allocate() Changes: https://git.openjdk.org/jdk21u-dev/pull/1217/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1217&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328085 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1217.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1217/head:pull/1217 PR: https://git.openjdk.org/jdk21u-dev/pull/1217 From rrich at openjdk.org Thu Dec 12 19:47:44 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 12 Dec 2024 19:47:44 GMT Subject: [jdk21u-dev] RFR: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate() In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 08:47:30 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/93aa7e2fcf87c4dc62de4ea71be543ee677b11be. > > The commit being backported was authored by Richard Reingruber on 21 Nov 2024 and was reviewed by Tobias Hartmann and Martin Doerr. > > The original commit did not apply because the `TracePhase` constructor used above the removed line was changed. > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. > > Thanks, Richard. Test failures are not related. [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk21u-dev/jdk21u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip Error: sh][ERROR] wget exited with exit code 4 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1217#issuecomment-2539871798 From duke at openjdk.org Thu Dec 12 20:54:38 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Dec 2024 20:54:38 GMT Subject: [jdk21u-dev] Withdrawn: 8333867: SHA3 performance can be improved In-Reply-To: References: Message-ID: <69Uc9Exo-9vnVurF7aDdFdg5WA6zyfBOwyNnMawEIQo=.28abbe80-32fe-412a-920b-0442e4c6771f@github.com> On Mon, 23 Sep 2024 12:12:17 GMT, Dmitry Chuyko wrote: > This is a clean backport of multi-platform SHA3 performance improvement. MessageDigests benchmarks show same speedup as for the original change (C2 generated code variant, -XX:-UseSHA3Intrinsics). > > Testing: test/jdk/sun/security, tier1, tier2 (linux-aarch64, linux-amd64). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1000 From serb at openjdk.org Thu Dec 12 21:02:39 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 12 Dec 2024 21:02:39 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 13:42:00 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request incrementally with one additional commit since the last revision: > > Fix linux-cross-compile aarch64 build. @GoeLin We should consider fixing this bug in the upcoming January 2025 release. Jvm crash on different platforms, tested Alpine, AL2, AL2023, macOS 15.2+docker. @shipilev please confirm ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2540004613 From syan at openjdk.org Fri Dec 13 03:12:42 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 13 Dec 2024 03:12:42 GMT Subject: [jdk21u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: <9Q0pipeX67NtZiokcpz5epJ67IbZwQEBym4SXh9PJ-s=.75c8bd21-5d76-42ed-80fc-32f1c14ab013@github.com> References: <9Q0pipeX67NtZiokcpz5epJ67IbZwQEBym4SXh9PJ-s=.75c8bd21-5d76-42ed-80fc-32f1c14ab013@github.com> Message-ID: On Thu, 12 Dec 2024 03:09:21 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1224#issuecomment-2540438538 From syan at openjdk.org Fri Dec 13 03:12:42 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 13 Dec 2024 03:12:42 GMT Subject: [jdk21u-dev] Integrated: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: <9Q0pipeX67NtZiokcpz5epJ67IbZwQEBym4SXh9PJ-s=.75c8bd21-5d76-42ed-80fc-32f1c14ab013@github.com> References: <9Q0pipeX67NtZiokcpz5epJ67IbZwQEBym4SXh9PJ-s=.75c8bd21-5d76-42ed-80fc-32f1c14ab013@github.com> Message-ID: <-qey5BqbQ8dKAfhZoJ8ZfmF8qu_0MkGhnZpFRxXrjAE=.c14263ca-c103-4e66-ad9c-295df9027555@github.com> On Thu, 12 Dec 2024 03:09:21 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! This pull request has now been integrated. Changeset: a0211131 Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/a0211131dbd0d61f1cc5fd1c1250f0339b3cc59b Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" Backport-of: 693847452f208446a34186f142fe2c56a49ceceb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1224 From syan at openjdk.org Fri Dec 13 03:13:44 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 13 Dec 2024 03:13:44 GMT Subject: [jdk17u-dev] Integrated: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 03:09:23 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! This pull request has now been integrated. Changeset: ff496b9c Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/ff496b9c1cf8beaf9f94c1999c8baa2407617e3f Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" Backport-of: 693847452f208446a34186f142fe2c56a49ceceb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3109 From syan at openjdk.org Fri Dec 13 03:13:44 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 13 Dec 2024 03:13:44 GMT Subject: [jdk17u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 03:09:23 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3109#issuecomment-2540438474 From duke at openjdk.org Fri Dec 13 04:10:45 2024 From: duke at openjdk.org (toshiogata) Date: Fri, 13 Dec 2024 04:10:45 GMT Subject: [jdk11u-dev] RFR: 8328242: Add a log area to the PassFailJFrame In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 07:41:09 GMT, toshiogata wrote: > Hi all, > > I would like to backport this patch to improve test maintainability for manual tests. The patch is clean. > Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way. > > Thank you. keep open ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2959#issuecomment-2540508258 From duke at openjdk.org Fri Dec 13 07:46:32 2024 From: duke at openjdk.org (Sorna Sarathi) Date: Fri, 13 Dec 2024 07:46:32 GMT Subject: [jdk24u] RFR: 8344611: Add missing classpath exception Message-ID: Hi, This PR contains the backport of commit [458979d](https://github.com/openjdk/jdk/commit/458979d83ac784273263b54516369d79764010dd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) ------------- Commit messages: - Backport 458979d83ac784273263b54516369d79764010dd Changes: https://git.openjdk.org/jdk24u/pull/2/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=2&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344611 Stats: 18 lines in 6 files changed: 12 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk24u/pull/2.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/2/head:pull/2 PR: https://git.openjdk.org/jdk24u/pull/2 From goetz at openjdk.org Fri Dec 13 08:15:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 08:15:42 GMT Subject: [jdk17u-dev] RFR: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 11:44:48 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing on win. GHA failure: gc/metaspace/TestMetaspacePerfCounters.java#Shenandoah-64 fails. We have seen this failing in the tests before. It used to be quite prominent, lately it's rare. Unrelated to this change. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3110#issuecomment-2540833610 From goetz at openjdk.org Fri Dec 13 08:15:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 08:15:43 GMT Subject: [jdk17u-dev] RFR: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: In-Reply-To: <02e1ytdmu3wTC8N7itwx24iKOtLxS5b08uxJ5ZKFwP0=.842255d5-9321-4939-906c-8732e082611e@github.com> References: <02e1ytdmu3wTC8N7itwx24iKOtLxS5b08uxJ5ZKFwP0=.842255d5-9321-4939-906c-8732e082611e@github.com> Message-ID: On Thu, 12 Dec 2024 13:52:29 GMT, Thomas Fitzsimmons wrote: > Typos in the comment: `platfrom == windowws` => `platform == windows`. Hi @fitzsim, good catch! But this is a backport, so not the right place to fix this. If you want to follow up with this you can file a bug against jdk. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3110#issuecomment-2540836869 From shade at openjdk.org Fri Dec 13 08:23:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 13 Dec 2024 08:23:44 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 21:00:05 GMT, Sergey Bylokhov wrote: > @GoeLin We should consider fixing this bug in the upcoming January 2025 release. Jvm crash on different platforms, tested Alpine, AL2, AL2023, macOS 15.2+docker. @shipilev please confirm Yes, we are planning to pick this fix in Corretto release for January. I think this patch is beneficial to have in all January releases as well. This is ultimately 21u and 17u maintainers' call. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2540849278 From goetz at openjdk.org Fri Dec 13 08:27:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 08:27:19 GMT Subject: [jdk21u-dev] RFR: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file Message-ID: I would like to backport this to make follow-up backports clean. I checked all files that would not patch clean for predecessors that are candidates for backport. The remaining resolves are the following: test/jdk/tools/jpackage/TEST.properties Resolved. Will backport 8314909, which probably makes this clean. test/jdk/tools/jpackage/share/AppContentTest.java One of the removed @modules statements is not in 21. It was added in 24 with 8341443. test/jdk/tools/jpackage/share/RuntimeImageTest.java Trivial resolve test/jdk/tools/jpackage/share/jdk/jpackage/tests/JLinkOptionsTest.java Resolved Copyright. "8308398: Move SunEC crypto provider into java.base" not in 21. test/jdk/tools/jpackage/windows/WinChildProcessTest.java Resolved. "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" not in 21. Some tests touched by this change are not in 21. Some came with new features, but other with bug fixes that are theoretically applicable to 21. Non of these fixes qualify for an obvious and simple backport that could be done as prereq of a pure test rework. Here the list: test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/DirectoryContentVerifierTest.java test/jdk/tools/jpackage/share/InOutPathTest.java Both added by "8325089: jpackage utility creates an "infinite", undeleteable directory tree", a bug that sounds interesting for 21, 17. But it is big and rather new, so don't backport now. test/jdk/tools/jpackage/linux/ServiceAndDesktopTest.java test/jdk/tools/jpackage/linux/UpgradeTest.java Both added by "8301856: Generated .spec file for RPM installers uninstalls desktop launcher on update", a bug that sounds interesting for 21, 17. It was published in 22, so it should be considered as stable. But it is big and Oracle did not address this yet, so let's not backport. test/jdk/tools/jpackage/macosx/SigningOptionsTest.java Added by "8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild" in 22. A new feature, no candidate for backport. test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java Added by "8310933: Copying from runtime image to application image should not follow symlinks" in 22. Enhancement. test/jdk/tools/jpackage/windows/WinNoRestartTest.java Added by "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" in 24. ------------- Commit messages: - Backport c33a8f52b613e5eff02f572eda876cbbfc7c22cf Changes: https://git.openjdk.org/jdk21u-dev/pull/1221/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1221&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343314 Stats: 278 lines in 80 files changed: 4 ins; 113 del; 161 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1221.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1221/head:pull/1221 PR: https://git.openjdk.org/jdk21u-dev/pull/1221 From duke at openjdk.org Fri Dec 13 09:47:42 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 13 Dec 2024 09:47:42 GMT Subject: [jdk21u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x In-Reply-To: References: Message-ID: <_c7pAM3N1CziXXxheVfWBlAZDbmV24YnPzwgoN8eXHk=.e7ff73e1-5063-4808-a150-7fa2e256d2e0@github.com> On Thu, 12 Dec 2024 15:54:47 GMT, Antonio Vieiro wrote: > A clean backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. > > The fix doesn't affect directly to SA tests in `21`, but it's being backported to `11` as this is the cause of [an older version of `serviceability/sa/ClhsdbFindPC.java` failing in JDK 11 on macos-13 GHA runners](https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579). > > Tests in 21 continue to pass in all platforms, including `macos`. Build failures are unrelated and are due to downloads of ant binaries not complying with the [archive.apache.org ban policies](https://infra.apache.org/infra-ban.html) [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk21u-dev/jdk21u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip Error: sh][ERROR] wget exited with exit code 4 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1227#issuecomment-2541009616 From sgehwolf at openjdk.org Fri Dec 13 10:22:42 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 13 Dec 2024 10:22:42 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: <5kzjtLmuwp81jPTucXa5v0OKZB-_Mh3OU5zAawVSYsA=.82067b41-8d66-4c38-b327-aacce5dc1037@github.com> On Thu, 12 Dec 2024 13:42:00 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request incrementally with one additional commit since the last revision: > > Fix linux-cross-compile aarch64 build. Since this is related to prctl returning `-1` in some Docker environments on newer MacOS 15.2+. It does not seem reproducible on native Aarch64 Linux or MacOSX 15.2 and there is a work-around, `-XX:UseSVE=0`, lets keep this on the April schedule for now. It should be a safe change, but I don't see the urgency either. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2541096729 From duke at openjdk.org Fri Dec 13 10:44:47 2024 From: duke at openjdk.org (Sorna Sarathi) Date: Fri, 13 Dec 2024 10:44:47 GMT Subject: [jdk24u] RFR: 8346069: Add missing Classpath exception statements Message-ID: Hi, This PR contains backport of [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704). Backport CPE statements. JDK Issue: [JDK-8346069](https://bugs.openjdk.org/browse/JDK-8346069) ------------- Commit messages: - Backport 09c29d1d4274d9c36e1af98f02e6fc5b3f35133f Changes: https://git.openjdk.org/jdk24u/pull/3/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=3&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346069 Stats: 33 lines in 11 files changed: 22 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk24u/pull/3.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/3/head:pull/3 PR: https://git.openjdk.org/jdk24u/pull/3 From goetz at openjdk.org Fri Dec 13 10:49:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 10:49:16 GMT Subject: [jdk21u-dev] RFR: 8328753: Open source few Undecorated Frame tests Message-ID: I backport this for parity with 21.0.6-oracle. I include follow-up fix JDK-8337886. Tests pass. ------------- Commit messages: - Backport follow-up 8337866 - Backport db159149c1c13a98ee9a85750741c6a3cd39f408 Changes: https://git.openjdk.org/jdk21u-dev/pull/1228/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1228&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328753 Stats: 350 lines in 3 files changed: 350 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1228.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1228/head:pull/1228 PR: https://git.openjdk.org/jdk21u-dev/pull/1228 From goetz at openjdk.org Fri Dec 13 11:02:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 11:02:50 GMT Subject: [jdk21u-dev] RFR: 8336692: Redo fix for JDK-8284620 Message-ID: I backport this for parity with 21.0.6-oracle. ------------- Commit messages: - Backport c5b7af73d07f7458e970f5752eb75640562ddc7b Changes: https://git.openjdk.org/jdk21u-dev/pull/1229/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1229&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336692 Stats: 6 lines in 1 file changed: 2 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1229.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1229/head:pull/1229 PR: https://git.openjdk.org/jdk21u-dev/pull/1229 From goetz at openjdk.org Fri Dec 13 11:06:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 11:06:18 GMT Subject: [jdk17u-dev] RFR: 8336692: Redo fix for JDK-8284620 Message-ID: I backport this for parity with 21.0.6-oracle Resolved due to nullptr differences. ------------- Commit messages: - Backport c5b7af73d07f7458e970f5752eb75640562ddc7b Changes: https://git.openjdk.org/jdk17u-dev/pull/3112/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3112&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336692 Stats: 6 lines in 1 file changed: 2 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3112.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3112/head:pull/3112 PR: https://git.openjdk.org/jdk17u-dev/pull/3112 From duke at openjdk.org Fri Dec 13 11:33:47 2024 From: duke at openjdk.org (duke) Date: Fri, 13 Dec 2024 11:33:47 GMT Subject: [jdk11u-dev] RFR: 8343474: [updates] Customize README.md to specifics of update project In-Reply-To: <29DqDD531agnTgugS5-XFfKVdpQC5yuYISmpDBdJ7YQ=.2b87ed23-4ea8-4ab4-a59d-0f9421317491@github.com> References: <29DqDD531agnTgugS5-XFfKVdpQC5yuYISmpDBdJ7YQ=.2b87ed23-4ea8-4ab4-a59d-0f9421317491@github.com> Message-ID: On Thu, 12 Dec 2024 16:18:15 GMT, Antonio Vieiro wrote: > Backport of [JDK-8343474](https://bugs.openjdk.org/browse/JDK-8343474). > > All links checked. @vieiro Your change (at version 3e7e534d960ae022fb944749c30f7fb93f841616) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2978#issuecomment-2541244587 From goetz at openjdk.org Fri Dec 13 12:23:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 12:23:40 GMT Subject: [jdk21u-dev] Integrated: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: In-Reply-To: <30042c-FoHR6n6EiF_CxdlbVTmBSRXGduZ1C3SpXhco=.ff95ced1-298c-447a-9e50-164f82f5a111@github.com> References: <30042c-FoHR6n6EiF_CxdlbVTmBSRXGduZ1C3SpXhco=.ff95ced1-298c-447a-9e50-164f82f5a111@github.com> Message-ID: On Thu, 12 Dec 2024 11:44:41 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing on win. This pull request has now been integrated. Changeset: 29c1188b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/29c1188b9785c14e42e4468e80a4835021e024b3 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: Backport-of: 1b104b63a97ec947b34b85658153ab6c182cb56c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1225 From duke at openjdk.org Fri Dec 13 12:28:44 2024 From: duke at openjdk.org (duke) Date: Fri, 13 Dec 2024 12:28:44 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 13:42:00 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request incrementally with one additional commit since the last revision: > > Fix linux-cross-compile aarch64 build. @krk Your change (at version 704459c2398f29957425b0224f1c426e8396c166) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2541338468 From krk at openjdk.org Fri Dec 13 12:38:39 2024 From: krk at openjdk.org (Kerem Kat) Date: Fri, 13 Dec 2024 12:38:39 GMT Subject: [jdk21u-dev] Integrated: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 17:24:05 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. This pull request has now been integrated. Changeset: 21b76f3f Author: Kerem Kat URL: https://git.openjdk.org/jdk21u-dev/commit/21b76f3f07a13acec54276c78be1174067ce1454 Stats: 22 lines in 2 files changed: 19 ins; 0 del; 3 mod 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed Reviewed-by: shade, phh Backport-of: 3c60f0b2bb75150d49da9ab94d88b767275de5e2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1222 From mbaesken at openjdk.org Fri Dec 13 12:48:43 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 13 Dec 2024 12:48:43 GMT Subject: [jdk21u-dev] Integrated: 8341820: Check return value of hcreate_r In-Reply-To: <4w7ckR2uzxvbKsDsosQOKQK5n8FhsJkd-MJcEm-jzOA=.ff4970e1-0d64-4d01-ae86-22ad8bff2b50@github.com> References: <4w7ckR2uzxvbKsDsosQOKQK5n8FhsJkd-MJcEm-jzOA=.ff4970e1-0d64-4d01-ae86-22ad8bff2b50@github.com> Message-ID: On Thu, 28 Nov 2024 09:48:31 GMT, Matthias Baesken wrote: > 8341820: Check return value of hcreate_r This pull request has now been integrated. Changeset: 7b2a675f Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/7b2a675f7061850e27d72c3c8d793fae10b96535 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8341820: Check return value of hcreate_r Backport-of: 7c0dbf8e9c69d51aa8e06305e4483002116019f4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1188 From duke at openjdk.org Fri Dec 13 13:04:39 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 13 Dec 2024 13:04:39 GMT Subject: [jdk11u-dev] Integrated: 8343474: [updates] Customize README.md to specifics of update project In-Reply-To: <29DqDD531agnTgugS5-XFfKVdpQC5yuYISmpDBdJ7YQ=.2b87ed23-4ea8-4ab4-a59d-0f9421317491@github.com> References: <29DqDD531agnTgugS5-XFfKVdpQC5yuYISmpDBdJ7YQ=.2b87ed23-4ea8-4ab4-a59d-0f9421317491@github.com> Message-ID: On Thu, 12 Dec 2024 16:18:15 GMT, Antonio Vieiro wrote: > Backport of [JDK-8343474](https://bugs.openjdk.org/browse/JDK-8343474). > > All links checked. This pull request has now been integrated. Changeset: a47c72fa Author: Antonio Vieiro Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/a47c72fad455bfdf9053cb8e94c99e73965ab50d Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod 8343474: [updates] Customize README.md to specifics of update project Reviewed-by: sgehwolf Backport-of: ac1f86887384f0e3cf9becdeb9ee1e54fd4e60cb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2978 From mbaesken at openjdk.org Fri Dec 13 13:52:16 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 13 Dec 2024 13:52:16 GMT Subject: [jdk17u-dev] RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux Message-ID: Backport of 8318442, diffs in the stride and increase ALL timeouts to 400 ------------- Commit messages: - Backport 06d8216a4ef6b883119459da7e52b37d16cd2f03 Changes: https://git.openjdk.org/jdk17u-dev/pull/3113/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3113&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318442 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3113.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3113/head:pull/3113 PR: https://git.openjdk.org/jdk17u-dev/pull/3113 From lucy at openjdk.org Fri Dec 13 13:58:42 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 13 Dec 2024 13:58:42 GMT Subject: [jdk17u-dev] RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 13:47:28 GMT, Matthias Baesken wrote: > Backport of 8318442, diffs in the stride and increase ALL timeouts to 400 LGTM. Quite a generous timeout increase. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3113#pullrequestreview-2502356407 From kcr at openjdk.org Fri Dec 13 14:29:35 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Fri, 13 Dec 2024 14:29:35 GMT Subject: [jdk24u] RFR: 8346069: Add missing Classpath exception statements In-Reply-To: References: Message-ID: <5sIy1-FPPv_3J_ZkILMVElx9xpSQzMc33HZvn8cDdcU=.9bbfdbae-d548-44dd-aeb8-80a70a01188b@github.com> On Fri, 13 Dec 2024 10:38:55 GMT, Sorna Sarathi wrote: > Hi, > This PR contains backport of [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704). > Backport CPE statements. > > JDK Issue: [JDK-8346069](https://bugs.openjdk.org/browse/JDK-8346069) @Sorna-Sarathi This repo is for JDK 24 Updates, starting with 24.0.1. This bug fix is a good candidate for JDK 24 itself. I recommend that you close this PR and instead open a backport PR to the `jdk:jdk24` stabilization branch. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/3#issuecomment-2541577703 From goetz at openjdk.org Fri Dec 13 16:00:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 13 Dec 2024 16:00:57 GMT Subject: [jdk21u-dev] RFR: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file [v2] In-Reply-To: References: Message-ID: > I would like to backport this to make follow-up backports clean. > > I checked all files that would not patch clean for predecessors that are candidates for > backport. The remaining resolves are the following: > > test/jdk/tools/jpackage/TEST.properties > Resolved. Will backport 8314909, which probably makes this clean. > > test/jdk/tools/jpackage/share/AppContentTest.java > One of the removed @modules statements is not in 21. It was added in 24 with 8341443. > > test/jdk/tools/jpackage/share/RuntimeImageTest.java > Trivial resolve > > test/jdk/tools/jpackage/share/jdk/jpackage/tests/JLinkOptionsTest.java > Resolved Copyright. "8308398: Move SunEC crypto provider into java.base" not in 21. > > test/jdk/tools/jpackage/windows/WinChildProcessTest.java > Resolved. "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" not in 21. > > Some tests touched by this change are not in 21. Some came with new features, > but other with bug fixes that are theoretically applicable to 21. Non of these fixes > qualify for an obvious and simple backport that could be done as prereq of a > pure test rework. Here the list: > > > test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/DirectoryContentVerifierTest.java > test/jdk/tools/jpackage/share/InOutPathTest.java > Both added by "8325089: jpackage utility creates an "infinite", undeleteable directory tree", a bug > that sounds interesting for 21, 17. But it is big and rather new, so don't backport now. > > test/jdk/tools/jpackage/linux/ServiceAndDesktopTest.java > test/jdk/tools/jpackage/linux/UpgradeTest.java > Both added by "8301856: Generated .spec file for RPM installers uninstalls desktop launcher > on update", a bug that sounds interesting for 21, 17. It was published in 22, so it should be > considered as stable. But it is big and Oracle did not address this yet, so let's not backport. > > test/jdk/tools/jpackage/macosx/SigningOptionsTest.java > Added by "8311877: [macos] Add CLI options to provide signing identity directly to > codesign and productbuild" in 22. A new feature, no candidate for backport. > > test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java > Added by "8310933: Copying from runtime image to application image should not > follow symlinks" in 22. Enhancement. > > test/jdk/tools/jpackage/windows/WinNoRestartTest.java > Added by "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" in 24. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into goetz_backport_8343314 - Backport c33a8f52b613e5eff02f572eda876cbbfc7c22cf ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1221/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1221&range=01 Stats: 278 lines in 80 files changed: 4 ins; 113 del; 161 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1221.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1221/head:pull/1221 PR: https://git.openjdk.org/jdk21u-dev/pull/1221 From syan at openjdk.org Sun Dec 15 01:47:44 2024 From: syan at openjdk.org (SendaoYan) Date: Sun, 15 Dec 2024 01:47:44 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. > > The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! Can anyone take look this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2543406353 From duke at openjdk.org Mon Dec 16 01:12:43 2024 From: duke at openjdk.org (Lenny Primak) Date: Mon, 16 Dec 2024 01:12:43 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: <6iBWHAXUOYZKirLsI55VUGz4dpykEgpxMNmvQZZAgO0=.8a817cb9-9212-43bc-80e6-cdc386a4a661@github.com> On Fri, 13 Dec 2024 08:21:25 GMT, Aleksey Shipilev wrote: >> @GoeLin We should consider fixing this bug in the upcoming January 2025 release. Jvm crash on different platforms, tested Alpine, AL2, AL2023, macOS 15.2+docker. >> @shipilev please confirm > >> @GoeLin We should consider fixing this bug in the upcoming January 2025 release. Jvm crash on different platforms, tested Alpine, AL2, AL2023, macOS 15.2+docker. @shipilev please confirm > > Yes, we are planning to pick this fix in Corretto release for January. I think this patch is beneficial to have in all January releases as well. This is ultimately 21u and 17u maintainers' call. Hi @shipilev @krk Looking a bit further into this, I do not understand what the "root cause" of this issue is. Is this PR a workaround? For example, running on any Arm machines I have access to (Mac, Graviton Linux, etc.) I cannot get the `-XX:UseSVE=1` to actually work. What architecture does this support currently, if any? It doesn't work on Mac M4, Mac M1, and under VM in Mac M1 or M4, etc. Is the root cause somewhere in MacOS? If it is, I can't find one. Thank you ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2544230995 From duke at openjdk.org Mon Dec 16 06:09:42 2024 From: duke at openjdk.org (Sorna Sarathi) Date: Mon, 16 Dec 2024 06:09:42 GMT Subject: [jdk24u] Withdrawn: 8346069: Add missing Classpath exception statements In-Reply-To: References: Message-ID: <_CAuuccGJfC-XLaCQvDjhMRqmqFaExg6_Q_tt4xeBv4=.460ffcc7-5d3b-476e-9bc5-7ba158bff72b@github.com> On Fri, 13 Dec 2024 10:38:55 GMT, Sorna Sarathi wrote: > Hi, > This PR contains backport of [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704). > Backport CPE statements. > > JDK Issue: [JDK-8346069](https://bugs.openjdk.org/browse/JDK-8346069) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/3 From duke at openjdk.org Mon Dec 16 06:09:45 2024 From: duke at openjdk.org (Sorna Sarathi) Date: Mon, 16 Dec 2024 06:09:45 GMT Subject: [jdk24u] Withdrawn: 8344611: Add missing classpath exception In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 07:40:16 GMT, Sorna Sarathi wrote: > Hi, > This PR contains the backport of [openjdk/jdk#22272](https://github.com/openjdk/jdk/pull/22272). It added the missing CPE statements. > > JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/2 From lucy at openjdk.org Mon Dec 16 07:51:44 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Mon, 16 Dec 2024 07:51:44 GMT Subject: [jdk21u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error [v2] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 09:21:51 GMT, Goetz Lindenmaier wrote: >> I would like to backport this fix for the mac build. >> >> I had to move the code to another file, the code is the same, though. >> "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to >> a new file. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Backport follow-up fix 8342858 Looks good, still. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1210#pullrequestreview-2505385310 From goetz at openjdk.org Mon Dec 16 07:54:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 07:54:47 GMT Subject: [jdk21u-dev] RFR: 8328753: Open source few Undecorated Frame tests In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 10:42:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > I include follow-up fix JDK-8337886. > > Tests pass. GHA failure: both well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1228#issuecomment-2544836893 From goetz at openjdk.org Mon Dec 16 07:54:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 07:54:49 GMT Subject: [jdk21u-dev] RFR: 8336692: Redo fix for JDK-8284620 In-Reply-To: References: Message-ID: <-UKYk1U8007LPqg5eYbptq4xsPsIN0onLKmnuFWIfwM=.1d08b711-df7a-4c8e-864b-7db129fd9f6d@github.com> On Fri, 13 Dec 2024 10:57:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. GHA failure: both well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1229#issuecomment-2544837978 From goetz at openjdk.org Mon Dec 16 07:57:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 07:57:38 GMT Subject: [jdk17u-dev] Integrated: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 11:44:48 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing on win. This pull request has now been integrated. Changeset: 45ee88f1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/45ee88f12423d2a1c517f618c67b7351c5f22f1e Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: Backport-of: 1b104b63a97ec947b34b85658153ab6c182cb56c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3110 From goetz at openjdk.org Mon Dec 16 08:39:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:39:25 GMT Subject: [jdk21u-dev] RFR: 8327859: Remove applet usage from JColorChooser tests Test4319113 Message-ID: <8Tvbzsq1zncyTv2jF-C-k2nun7dPhFcfVuBNLW7UC1A=.78758a41-7d24-4150-ba57-f4243e5ddce6@github.com> I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 89fb0f837b7dbeed581f5db79d915cf405afda31 Changes: https://git.openjdk.org/jdk21u-dev/pull/1231/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1231&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327859 Stats: 108 lines in 2 files changed: 22 ins; 53 del; 33 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1231.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1231/head:pull/1231 PR: https://git.openjdk.org/jdk21u-dev/pull/1231 From goetz at openjdk.org Mon Dec 16 08:41:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:41:10 GMT Subject: [jdk21u-dev] RFR: 8328121: Remove applet usage from JColorChooser tests Test4759306 Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport fab0edc9e636c69d7012e476e97661ddae993a03 Changes: https://git.openjdk.org/jdk21u-dev/pull/1232/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1232&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328121 Stats: 54 lines in 2 files changed: 14 ins; 33 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1232.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1232/head:pull/1232 PR: https://git.openjdk.org/jdk21u-dev/pull/1232 From goetz at openjdk.org Mon Dec 16 08:41:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:41:18 GMT Subject: [jdk17u-dev] RFR: 8327859: Remove applet usage from JColorChooser tests Test4319113 Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 89fb0f837b7dbeed581f5db79d915cf405afda31 Changes: https://git.openjdk.org/jdk17u-dev/pull/3114/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3114&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327859 Stats: 108 lines in 2 files changed: 22 ins; 53 del; 33 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3114.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3114/head:pull/3114 PR: https://git.openjdk.org/jdk17u-dev/pull/3114 From goetz at openjdk.org Mon Dec 16 08:41:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:41:22 GMT Subject: [jdk17u-dev] RFR: 8328121: Remove applet usage from JColorChooser tests Test4759306 Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport fab0edc9e636c69d7012e476e97661ddae993a03 Changes: https://git.openjdk.org/jdk17u-dev/pull/3115/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328121 Stats: 54 lines in 2 files changed: 14 ins; 33 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3115.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3115/head:pull/3115 PR: https://git.openjdk.org/jdk17u-dev/pull/3115 From goetz at openjdk.org Mon Dec 16 08:45:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:45:09 GMT Subject: [jdk21u-dev] RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456 Message-ID: <6GpxIMUZM60-INk9jqbXO2gKMxAXJ8EzMogkk9lJ37A=.b684c835-87f0-4f2b-a91f-011247da35da@github.com> I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 78d1b9046830198cd61c505f04f245a430878a5b Changes: https://git.openjdk.org/jdk21u-dev/pull/1233/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1233&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328380 Stats: 93 lines in 2 files changed: 37 ins; 45 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1233.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1233/head:pull/1233 PR: https://git.openjdk.org/jdk21u-dev/pull/1233 From goetz at openjdk.org Mon Dec 16 08:48:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:48:11 GMT Subject: [jdk17u-dev] RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456 Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 78d1b9046830198cd61c505f04f245a430878a5b Changes: https://git.openjdk.org/jdk17u-dev/pull/3116/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328380 Stats: 93 lines in 2 files changed: 37 ins; 45 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3116.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3116/head:pull/3116 PR: https://git.openjdk.org/jdk17u-dev/pull/3116 From mbaesken at openjdk.org Mon Dec 16 08:52:46 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 16 Dec 2024 08:52:46 GMT Subject: [jdk21u-dev] RFR: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object Message-ID: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object ------------- Commit messages: - Backport ec310fe80971261ab7ee1141c64ffd600e7546c0 Changes: https://git.openjdk.org/jdk21u-dev/pull/1235/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1235&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317919 Stats: 16 lines in 4 files changed: 12 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1235.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1235/head:pull/1235 PR: https://git.openjdk.org/jdk21u-dev/pull/1235 From goetz at openjdk.org Mon Dec 16 08:53:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:53:07 GMT Subject: [jdk21u-dev] RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 27ac39a2bc8250bfae859568cb0ee0963900aafa Changes: https://git.openjdk.org/jdk21u-dev/pull/1234/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1234&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328719 Stats: 131 lines in 2 files changed: 41 ins; 50 del; 40 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1234.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1234/head:pull/1234 PR: https://git.openjdk.org/jdk21u-dev/pull/1234 From goetz at openjdk.org Mon Dec 16 08:53:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 08:53:13 GMT Subject: [jdk17u-dev] RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 27ac39a2bc8250bfae859568cb0ee0963900aafa Changes: https://git.openjdk.org/jdk17u-dev/pull/3117/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3117&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328719 Stats: 131 lines in 2 files changed: 41 ins; 50 del; 40 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3117.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3117/head:pull/3117 PR: https://git.openjdk.org/jdk17u-dev/pull/3117 From goetz at openjdk.org Mon Dec 16 09:01:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:01:45 GMT Subject: [jdk21u-dev] RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport cc5b9c63cbc1743e22f80dce51d803e267c60317 Changes: https://git.openjdk.org/jdk21u-dev/pull/1236/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1236&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328227 Stats: 66 lines in 2 files changed: 21 ins; 34 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1236.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1236/head:pull/1236 PR: https://git.openjdk.org/jdk21u-dev/pull/1236 From goetz at openjdk.org Mon Dec 16 09:01:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:01:50 GMT Subject: [jdk17u-dev] RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 Message-ID: I backport this for parity with 17.0.15-oracle ------------- Commit messages: - Backport cc5b9c63cbc1743e22f80dce51d803e267c60317 Changes: https://git.openjdk.org/jdk17u-dev/pull/3118/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3118&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328227 Stats: 66 lines in 2 files changed: 21 ins; 34 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3118.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3118/head:pull/3118 PR: https://git.openjdk.org/jdk17u-dev/pull/3118 From goetz at openjdk.org Mon Dec 16 09:11:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:11:51 GMT Subject: [jdk21u-dev] RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 1e76e1fdfa67c28ce20b0dc7fb0253670be54554 Changes: https://git.openjdk.org/jdk21u-dev/pull/1237/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1237&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328403 Stats: 63 lines in 2 files changed: 21 ins; 32 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1237.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1237/head:pull/1237 PR: https://git.openjdk.org/jdk21u-dev/pull/1237 From goetz at openjdk.org Mon Dec 16 09:12:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:12:08 GMT Subject: [jdk17u-dev] RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 Message-ID: I backport this for parity with 17.0.15-oracle ------------- Commit messages: - Backport 1e76e1fdfa67c28ce20b0dc7fb0253670be54554 Changes: https://git.openjdk.org/jdk17u-dev/pull/3119/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3119&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328403 Stats: 63 lines in 2 files changed: 21 ins; 32 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3119.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3119/head:pull/3119 PR: https://git.openjdk.org/jdk17u-dev/pull/3119 From goetz at openjdk.org Mon Dec 16 09:29:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:29:47 GMT Subject: [jdk17u-dev] RFR: 8333360: PrintNullString.java doesn't use float arguments Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport aaaa86b57172d45d1126c50efc270c6e49aba7a5 Changes: https://git.openjdk.org/jdk17u-dev/pull/3120/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3120&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333360 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3120.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3120/head:pull/3120 PR: https://git.openjdk.org/jdk17u-dev/pull/3120 From goetz at openjdk.org Mon Dec 16 09:30:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:30:08 GMT Subject: [jdk21u-dev] RFR: 8333360: PrintNullString.java doesn't use float arguments Message-ID: <_iNEU7PdhCTaTuN-JIf-a10kldyfaP89a_JQZZwXozI=.119752cd-c8c6-4fe6-a514-a74bdd54bf54@github.com> I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport aaaa86b57172d45d1126c50efc270c6e49aba7a5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1238/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1238&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333360 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1238.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1238/head:pull/1238 PR: https://git.openjdk.org/jdk21u-dev/pull/1238 From goetz at openjdk.org Mon Dec 16 09:32:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:32:47 GMT Subject: [jdk17u-dev] RFR: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException Message-ID: <3aWsiFboKGNGiUvdaMiTK3iq39Uj1fPR_9k45DeyPNI=.77ff1c63-8c79-4f91-87fd-1806fbfadd1d@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 2a2964759c73b3b9ab6afaad109383c89952977b Changes: https://git.openjdk.org/jdk17u-dev/pull/3121/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3121&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334777 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3121.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3121/head:pull/3121 PR: https://git.openjdk.org/jdk17u-dev/pull/3121 From goetz at openjdk.org Mon Dec 16 09:35:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:35:09 GMT Subject: [jdk21u-dev] RFR: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 2a2964759c73b3b9ab6afaad109383c89952977b Changes: https://git.openjdk.org/jdk21u-dev/pull/1239/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1239&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334777 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1239.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1239/head:pull/1239 PR: https://git.openjdk.org/jdk21u-dev/pull/1239 From goetz at openjdk.org Mon Dec 16 09:40:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 09:40:47 GMT Subject: [jdk17u-dev] RFR: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 739b5fb886ef828949b401810caabff6b7a8f827 Changes: https://git.openjdk.org/jdk17u-dev/pull/3122/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3122&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333391 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3122.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3122/head:pull/3122 PR: https://git.openjdk.org/jdk17u-dev/pull/3122 From shade at openjdk.org Mon Dec 16 10:41:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 16 Dec 2024 10:41:39 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: <6iBWHAXUOYZKirLsI55VUGz4dpykEgpxMNmvQZZAgO0=.8a817cb9-9212-43bc-80e6-cdc386a4a661@github.com> References: <6iBWHAXUOYZKirLsI55VUGz4dpykEgpxMNmvQZZAgO0=.8a817cb9-9212-43bc-80e6-cdc386a4a661@github.com> Message-ID: <1R-v3OVthETfH1yJnkmS6uOA3ZF8dmFuxriFxVlNxbo=.7d6ad110-0284-4b33-b182-3a72be374154@github.com> On Mon, 16 Dec 2024 00:23:53 GMT, Lenny Primak wrote: > Looking a bit further into this, I do not understand what the "root cause" of this issue is. Is this PR a workaround? This fix makes sure VM does not crash if lower layer (whether native OS or whatever sandbox/virtualization layer) does not allow us to execute `prctl(PR_SVE_GET_VL)` to get SVE vector length. Whether this is a fix or a workaround depends on whether prohibiting `prctl(PR_SVE_GET_VL)` is a bug or not from the lower layer perspective :) I tend to think the innocuous `prctl`-s should be enabled, so I tend to think about this fix as the workaround. > What architecture does this support currently, if any? It doesn't work on Mac M4, Mac M1, and under VM in Mac M1 or M4, etc. Is the root cause somewhere in MacOS? If it is, I can't find one. By "this" you mean SVE? SVE is a feature of modern AArch64 CPUs. AFAIU, this means Apple M4+, Graviton 3+, etc. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2545218860 From goetz at openjdk.org Mon Dec 16 10:56:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 10:56:06 GMT Subject: [jdk17u-dev] RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop Message-ID: I backport this for parity with 17.0.15-oracle. Two trivial resolved due to context changes. ------------- Commit messages: - Backport e203df46faf610e35e2c2510271ad68199f4fa3f Changes: https://git.openjdk.org/jdk17u-dev/pull/3123/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3123&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338100 Stats: 68 lines in 3 files changed: 18 ins; 31 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3123.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3123/head:pull/3123 PR: https://git.openjdk.org/jdk17u-dev/pull/3123 From goetz at openjdk.org Mon Dec 16 11:02:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 11:02:38 GMT Subject: [jdk21u-dev] Integrated: 8336498: [macos] [build]: install-file macro may run into permission denied error In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 09:45:55 GMT, Goetz Lindenmaier wrote: > I would like to backport this fix for the mac build. > > I had to move the code to another file, the code is the same, though. > "8326947: Minimize MakeBase.gmk" is not in 21, which moved the code to > a new file. This pull request has now been integrated. Changeset: b682b1fa Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/b682b1faa0e1d8b3ff7aa5c5813e3ab0cd8f159c Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8336498: [macos] [build]: install-file macro may run into permission denied error 8342858: Make target mac-jdk-bundle fails on chmod command Reviewed-by: lucy Backport-of: 715fa8f9fe7242e86b985aece3d078b226f53fb9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1210 From goetz at openjdk.org Mon Dec 16 11:23:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 11:23:19 GMT Subject: [jdk17u-dev] RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop [v2] In-Reply-To: References: Message-ID: <42OBYW7nCgpbqPbYGCV4Qrylo3G2JN9agLqziSzqWUc=.10252348-6254-4087-b0d4-bc960c4e27d8@github.com> > I backport this for parity with 17.0.15-oracle. > > Two trivial resolved due to context changes. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport e203df46faf610e35e2c2510271ad68199f4fa3f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3123/files - new: https://git.openjdk.org/jdk17u-dev/pull/3123/files/d8addd30..e0d01d7d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3123&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3123&range=00-01 Stats: 239 lines in 4 files changed: 239 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3123.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3123/head:pull/3123 PR: https://git.openjdk.org/jdk17u-dev/pull/3123 From goetz at openjdk.org Mon Dec 16 11:31:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 11:31:47 GMT Subject: [jdk17u-dev] RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error Message-ID: I'd like to fix this build issue in 17. ------------- Commit messages: - Backport b682b1faa0e1d8b3ff7aa5c5813e3ab0cd8f159c Changes: https://git.openjdk.org/jdk17u-dev/pull/3124/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3124&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336498 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3124.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3124/head:pull/3124 PR: https://git.openjdk.org/jdk17u-dev/pull/3124 From goetz at openjdk.org Mon Dec 16 11:34:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 11:34:13 GMT Subject: [jdk17u-dev] RFR: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC Message-ID: <1oPReLXHI9-eKHTMFSfQ0FFFOK7kBFylIXn5TiyH9xc=.3688af4f-da45-48ac-9333-f7a25cacb611@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 51b85a1f692fed7a66bdc0fae21438a60aafe7c2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3125/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3125&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339687 Stats: 22 lines in 1 file changed: 3 ins; 2 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3125.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3125/head:pull/3125 PR: https://git.openjdk.org/jdk17u-dev/pull/3125 From goetz at openjdk.org Mon Dec 16 11:35:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 11:35:14 GMT Subject: [jdk21u-dev] RFR: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 51b85a1f692fed7a66bdc0fae21438a60aafe7c2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1240/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1240&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339687 Stats: 22 lines in 1 file changed: 3 ins; 2 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1240.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1240/head:pull/1240 PR: https://git.openjdk.org/jdk21u-dev/pull/1240 From goetz at openjdk.org Mon Dec 16 12:45:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 12:45:01 GMT Subject: [jdk17u-dev] RFR: 8339902: Open source couple TextField related tests Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport fde8508379d2983fa70784faef60699c81f9c359 Changes: https://git.openjdk.org/jdk17u-dev/pull/3126/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339902 Stats: 527 lines in 5 files changed: 527 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3126.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3126/head:pull/3126 PR: https://git.openjdk.org/jdk17u-dev/pull/3126 From goetz at openjdk.org Mon Dec 16 12:45:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 12:45:27 GMT Subject: [jdk21u-dev] RFR: 8339902: Open source couple TextField related tests Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport fde8508379d2983fa70784faef60699c81f9c359 Changes: https://git.openjdk.org/jdk21u-dev/pull/1241/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1241&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339902 Stats: 527 lines in 5 files changed: 527 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1241.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1241/head:pull/1241 PR: https://git.openjdk.org/jdk21u-dev/pull/1241 From goetz at openjdk.org Mon Dec 16 13:22:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 13:22:48 GMT Subject: [jdk17u-dev] RFR: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport b4ab290fd7c3d914154755a1539b48ba33338c26 Changes: https://git.openjdk.org/jdk17u-dev/pull/3127/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3127&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331959 Stats: 221 lines in 4 files changed: 90 ins; 6 del; 125 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3127.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3127/head:pull/3127 PR: https://git.openjdk.org/jdk17u-dev/pull/3127 From goetz at openjdk.org Mon Dec 16 13:22:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 13:22:53 GMT Subject: [jdk21u-dev] RFR: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport b4ab290fd7c3d914154755a1539b48ba33338c26 Changes: https://git.openjdk.org/jdk21u-dev/pull/1242/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1242&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331959 Stats: 221 lines in 4 files changed: 90 ins; 6 del; 125 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1242.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1242/head:pull/1242 PR: https://git.openjdk.org/jdk21u-dev/pull/1242 From fmeum at openjdk.org Mon Dec 16 13:50:38 2024 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Mon, 16 Dec 2024 13:50:38 GMT Subject: [jdk21u-dev] RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 13:08:29 GMT, Fabian Meumertzheim wrote: > 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE I sent the backport request for 24 in https://github.com/openjdk/jdk24u/pull/4. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1211#issuecomment-2545677541 From fmeum at openjdk.org Mon Dec 16 13:51:06 2024 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Mon, 16 Dec 2024 13:51:06 GMT Subject: [jdk24u] RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE Message-ID: Hi all, This pull request contains a backport of commit d7ef3ac0 from the openjdk/jdk repository. The commit being backported was authored by Fabian Meumertzheim on 9 Dec 2024 and was reviewed by David Holmes, Kevin Walls and Severin Gehwolf. Thanks! ------------- Commit messages: - Backport d7ef3ac0b7e677c4901c69ad4361b5de8408e8d3 Changes: https://git.openjdk.org/jdk24u/pull/4/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=4&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345684 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk24u/pull/4.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/4/head:pull/4 PR: https://git.openjdk.org/jdk24u/pull/4 From goetz at openjdk.org Mon Dec 16 14:11:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 14:11:16 GMT Subject: [jdk17u-dev] RFR: 8341978: Improve JButton/bug4490179.java Message-ID: <3QNfea5_b18wTOr2tOi9sgzuanix-1p7NVXFW_m_yCo=.32ba2f23-015b-465f-9ac1-556f6c10bd94@github.com> I backport this for parity with 17.0.14-oracle ------------- Commit messages: - Backport 8174cbd5cb797a80d48246a686897ef6fe64ed57 Changes: https://git.openjdk.org/jdk17u-dev/pull/3128/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3128&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341978 Stats: 88 lines in 1 file changed: 66 ins; 3 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3128.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3128/head:pull/3128 PR: https://git.openjdk.org/jdk17u-dev/pull/3128 From goetz at openjdk.org Mon Dec 16 14:13:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 16 Dec 2024 14:13:18 GMT Subject: [jdk21u-dev] RFR: 8341978: Improve JButton/bug4490179.java Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport 8174cbd5cb797a80d48246a686897ef6fe64ed57 Changes: https://git.openjdk.org/jdk21u-dev/pull/1243/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1243&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341978 Stats: 88 lines in 1 file changed: 66 ins; 3 del; 19 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1243.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1243/head:pull/1243 PR: https://git.openjdk.org/jdk21u-dev/pull/1243 From mbaesken at openjdk.org Mon Dec 16 14:41:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 16 Dec 2024 14:41:39 GMT Subject: [jdk17u-dev] RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 13:47:28 GMT, Matthias Baesken wrote: > Backport of 8318442, diffs in the stride and increase ALL timeouts to 400 GHA failures - 2times getting jtreg failed ; and the other one is about some artifacts infra stuff . Most likely unrelated . ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3113#issuecomment-2545799118 From mbaesken at openjdk.org Mon Dec 16 14:41:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 16 Dec 2024 14:41:39 GMT Subject: [jdk17u-dev] Integrated: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 13:47:28 GMT, Matthias Baesken wrote: > Backport of 8318442, diffs in the stride and increase ALL timeouts to 400 This pull request has now been integrated. Changeset: 25140d11 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/25140d115afbe852e7f274dcd0b1297ab8623c06 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux Reviewed-by: lucy Backport-of: 06d8216a4ef6b883119459da7e52b37d16cd2f03 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3113 From mbaesken at openjdk.org Mon Dec 16 14:43:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 16 Dec 2024 14:43:39 GMT Subject: [jdk17u-dev] Integrated: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed In-Reply-To: <8iWrSWNTA23GIDKFXzeR-JdmvM_EcydSUDSMt2ZSYhA=.b7f6ca84-81ae-4241-9d9b-3a0181e29cd2@github.com> References: <8iWrSWNTA23GIDKFXzeR-JdmvM_EcydSUDSMt2ZSYhA=.b7f6ca84-81ae-4241-9d9b-3a0181e29cd2@github.com> Message-ID: On Thu, 28 Nov 2024 12:22:56 GMT, Matthias Baesken wrote: > 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed This pull request has now been integrated. Changeset: 7db0131a Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/7db0131a18041b3c032cba6b76208a48c5783fe9 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed Backport-of: 2564f0f99866c33d14947609c276a421ce8cc0a2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3077 From mdoerr at openjdk.org Mon Dec 16 14:56:39 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 16 Dec 2024 14:56:39 GMT Subject: [jdk21u-dev] RFR: 8328753: Open source few Undecorated Frame tests In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 10:42:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > I include follow-up fix JDK-8337886. > > Tests pass. Looks like a clean backport of the two individual commits. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1228#pullrequestreview-2506419265 From duke at openjdk.org Mon Dec 16 14:56:44 2024 From: duke at openjdk.org (Lenny Primak) Date: Mon, 16 Dec 2024 14:56:44 GMT Subject: [jdk21u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed [v3] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 13:42:00 GMT, Kerem Kat wrote: >> Ref. https://github.com/openjdk/jdk/pull/22479 >> >>> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM >> >> Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. >> >> Additional testing: >> >> - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. > > Kerem Kat has updated the pull request incrementally with one additional commit since the last revision: > > Fix linux-cross-compile aarch64 build. Ok. I think I get it now. the only machine with SVE I have access to is M4 Mac. My Graviton machines are G1 so they wouldn?t work. So the root cause is that Sonoma 15.2 introduced a regression that breaks SVE. it makes it unavailable natively and crashes JVM under a virtualization environments thank you. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1222#issuecomment-2545839273 From mdoerr at openjdk.org Mon Dec 16 14:58:42 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 16 Dec 2024 14:58:42 GMT Subject: [jdk17u-dev] RFR: 8336692: Redo fix for JDK-8284620 In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 11:02:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle > > Resolved due to nullptr differences. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3112#pullrequestreview-2506428268 From syan at openjdk.org Mon Dec 16 15:00:48 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 16 Dec 2024 15:00:48 GMT Subject: [jdk21u-dev] RFR: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values In-Reply-To: References: Message-ID: <2aCkOe64fI0pknttQ_4PeRw529mVgcuVKSaleOWzd9Q=.7b2056db-65ac-44dc-aac0-3f6ac9218fa4@github.com> On Thu, 12 Dec 2024 02:32:16 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [59fcfae6](https://github.com/openjdk/jdk/commit/59fcfae63090f6659a94a9e3dd0705739ec1b074) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Nov 2024 and was reviewed by David Holmes. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1223#issuecomment-2545849906 From syan at openjdk.org Mon Dec 16 15:00:49 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 16 Dec 2024 15:00:49 GMT Subject: [jdk21u-dev] Integrated: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 02:32:16 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [59fcfae6](https://github.com/openjdk/jdk/commit/59fcfae63090f6659a94a9e3dd0705739ec1b074) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Nov 2024 and was reviewed by David Holmes. > > Thanks! This pull request has now been integrated. Changeset: 1c691358 Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/1c691358f3a6ea61ed23a887e9550a8dbd865057 Stats: 20 lines in 1 file changed: 10 ins; 0 del; 10 mod 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values Backport-of: 59fcfae63090f6659a94a9e3dd0705739ec1b074 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1223 From syan at openjdk.org Mon Dec 16 15:02:40 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 16 Dec 2024 15:02:40 GMT Subject: [jdk17u-dev] RFR: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 02:32:25 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [59fcfae6](https://github.com/openjdk/jdk/commit/59fcfae63090f6659a94a9e3dd0705739ec1b074) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Nov 2024 and was reviewed by David Holmes. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3108#issuecomment-2545850638 From syan at openjdk.org Mon Dec 16 15:02:40 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 16 Dec 2024 15:02:40 GMT Subject: [jdk17u-dev] Integrated: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 02:32:25 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [59fcfae6](https://github.com/openjdk/jdk/commit/59fcfae63090f6659a94a9e3dd0705739ec1b074) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 19 Nov 2024 and was reviewed by David Holmes. > > Thanks! This pull request has now been integrated. Changeset: 9c126b3c Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/9c126b3c86860e98b40e3a2a8b576760d80e0389 Stats: 20 lines in 1 file changed: 10 ins; 0 del; 10 mod 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values Backport-of: 59fcfae63090f6659a94a9e3dd0705739ec1b074 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3108 From mdoerr at openjdk.org Mon Dec 16 16:35:38 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 16 Dec 2024 16:35:38 GMT Subject: [jdk21u-dev] RFR: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file [v2] In-Reply-To: References: Message-ID: <3I32XT4x48uuHtKcXt1f0N5-2wwoy07KcNMEpX_N-oU=.5a83f32f-1563-4394-a919-8b5d573863f9@github.com> On Fri, 13 Dec 2024 16:00:57 GMT, Goetz Lindenmaier wrote: >> I would like to backport this to make follow-up backports clean. >> >> I checked all files that would not patch clean for predecessors that are candidates for >> backport. The remaining resolves are the following: >> >> test/jdk/tools/jpackage/TEST.properties >> Resolved. Will backport 8314909, which probably makes this clean. >> >> test/jdk/tools/jpackage/share/AppContentTest.java >> One of the removed @modules statements is not in 21. It was added in 24 with 8341443. >> >> test/jdk/tools/jpackage/share/RuntimeImageTest.java >> Trivial resolve >> >> test/jdk/tools/jpackage/share/jdk/jpackage/tests/JLinkOptionsTest.java >> Resolved Copyright. "8308398: Move SunEC crypto provider into java.base" not in 21. >> >> test/jdk/tools/jpackage/windows/WinChildProcessTest.java >> Resolved. "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" not in 21. >> >> Some tests touched by this change are not in 21. Some came with new features, >> but other with bug fixes that are theoretically applicable to 21. Non of these fixes >> qualify for an obvious and simple backport that could be done as prereq of a >> pure test rework. Here the list: >> >> >> test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/DirectoryContentVerifierTest.java >> test/jdk/tools/jpackage/share/InOutPathTest.java >> Both added by "8325089: jpackage utility creates an "infinite", undeleteable directory tree", a bug >> that sounds interesting for 21, 17. But it is big and rather new, so don't backport now. >> >> test/jdk/tools/jpackage/linux/ServiceAndDesktopTest.java >> test/jdk/tools/jpackage/linux/UpgradeTest.java >> Both added by "8301856: Generated .spec file for RPM installers uninstalls desktop launcher >> on update", a bug that sounds interesting for 21, 17. It was published in 22, so it should be >> considered as stable. But it is big and Oracle did not address this yet, so let's not backport. >> >> test/jdk/tools/jpackage/macosx/SigningOptionsTest.java >> Added by "8311877: [macos] Add CLI options to provide signing identity directly to >> codesign and productbuild" in 22. A new feature, no candidate for backport. >> >> test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java >> Added by "8310933: Copying from runtime image to application image should not >> follow symlinks" in 22. Enhancement. >> >> test/jdk/tools/jpackage/windows/WinNoRestartTest.java >> Added by "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" in 24. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into goetz_backport_8343314 > - Backport c33a8f52b613e5eff02f572eda876cbbfc7c22cf LGTM. [JDK-8314909](https://bugs.openjdk.org/browse/JDK-8314909) is already backported. Seems like all "@modules jdk.jpackage/jdk.jpackage.internal" are removed. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1221#pullrequestreview-2506712589 From mdoerr at openjdk.org Mon Dec 16 16:47:46 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 16 Dec 2024 16:47:46 GMT Subject: [jdk17u-dev] RFR: 8343724: [PPC64] Disallow OptoScheduling In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 20:30:52 GMT, Martin Doerr wrote: > Clean backport of [JDK-8343724](https://bugs.openjdk.org/browse/JDK-8343724). GHA failures on x64 are unrelated. This PR only touches PPC64 files. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3105#issuecomment-2546126328 From goetz at openjdk.org Tue Dec 17 07:56:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 07:56:06 GMT Subject: [jdk17u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 11:39:50 GMT, Martin Doerr wrote: > Backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205) from jdk21u-dev. Hi, the bug says this applies only to linux x86_64, why is this so? Also, this is at the edge of being applicable to stable 17u. I would like to defer this to the next release to give it some time in 24/21. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3106#issuecomment-2547726228 From goetz at openjdk.org Tue Dec 17 07:59:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 07:59:59 GMT Subject: [jdk21u-dev] RFR: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file [v2] In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 16:00:57 GMT, Goetz Lindenmaier wrote: >> I would like to backport this to make follow-up backports clean. >> >> I checked all files that would not patch clean for predecessors that are candidates for >> backport. The remaining resolves are the following: >> >> test/jdk/tools/jpackage/TEST.properties >> Resolved. Will backport 8314909, which probably makes this clean. >> >> test/jdk/tools/jpackage/share/AppContentTest.java >> One of the removed @modules statements is not in 21. It was added in 24 with 8341443. >> >> test/jdk/tools/jpackage/share/RuntimeImageTest.java >> Trivial resolve >> >> test/jdk/tools/jpackage/share/jdk/jpackage/tests/JLinkOptionsTest.java >> Resolved Copyright. "8308398: Move SunEC crypto provider into java.base" not in 21. >> >> test/jdk/tools/jpackage/windows/WinChildProcessTest.java >> Resolved. "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" not in 21. >> >> Some tests touched by this change are not in 21. Some came with new features, >> but other with bug fixes that are theoretically applicable to 21. Non of these fixes >> qualify for an obvious and simple backport that could be done as prereq of a >> pure test rework. Here the list: >> >> >> test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/DirectoryContentVerifierTest.java >> test/jdk/tools/jpackage/share/InOutPathTest.java >> Both added by "8325089: jpackage utility creates an "infinite", undeleteable directory tree", a bug >> that sounds interesting for 21, 17. But it is big and rather new, so don't backport now. >> >> test/jdk/tools/jpackage/linux/ServiceAndDesktopTest.java >> test/jdk/tools/jpackage/linux/UpgradeTest.java >> Both added by "8301856: Generated .spec file for RPM installers uninstalls desktop launcher >> on update", a bug that sounds interesting for 21, 17. It was published in 22, so it should be >> considered as stable. But it is big and Oracle did not address this yet, so let's not backport. >> >> test/jdk/tools/jpackage/macosx/SigningOptionsTest.java >> Added by "8311877: [macos] Add CLI options to provide signing identity directly to >> codesign and productbuild" in 22. A new feature, no candidate for backport. >> >> test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java >> Added by "8310933: Copying from runtime image to application image should not >> follow symlinks" in 22. Enhancement. >> >> test/jdk/tools/jpackage/windows/WinNoRestartTest.java >> Added by "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" in 24. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into goetz_backport_8343314 > - Backport c33a8f52b613e5eff02f572eda876cbbfc7c22cf Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1221#issuecomment-2547731483 From goetz at openjdk.org Tue Dec 17 08:03:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:03:55 GMT Subject: [jdk21u-dev] RFR: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 13:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1242#issuecomment-2547738243 From goetz at openjdk.org Tue Dec 17 08:03:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:03:58 GMT Subject: [jdk21u-dev] RFR: 8339902: Open source couple TextField related tests In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 12:39:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1241#issuecomment-2547738763 From goetz at openjdk.org Tue Dec 17 08:04:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:04:03 GMT Subject: [jdk17u-dev] RFR: 8341978: Improve JButton/bug4490179.java In-Reply-To: <3QNfea5_b18wTOr2tOi9sgzuanix-1p7NVXFW_m_yCo=.32ba2f23-015b-465f-9ac1-556f6c10bd94@github.com> References: <3QNfea5_b18wTOr2tOi9sgzuanix-1p7NVXFW_m_yCo=.32ba2f23-015b-465f-9ac1-556f6c10bd94@github.com> Message-ID: <2z4RvKwShXRLhkWRZWGH77p3DMctztup-mNV3pVOQwQ=.e029c7da-3766-46f6-b05b-d0a2d24d3073@github.com> On Mon, 16 Dec 2024 14:07:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3128#issuecomment-2547737784 From goetz at openjdk.org Tue Dec 17 08:04:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:04:44 GMT Subject: [jdk21u-dev] RFR: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 09:28:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: Twice well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1239#issuecomment-2547739620 From goetz at openjdk.org Tue Dec 17 08:05:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:05:46 GMT Subject: [jdk21u-dev] RFR: 8333360: PrintNullString.java doesn't use float arguments In-Reply-To: <_iNEU7PdhCTaTuN-JIf-a10kldyfaP89a_JQZZwXozI=.119752cd-c8c6-4fe6-a514-a74bdd54bf54@github.com> References: <_iNEU7PdhCTaTuN-JIf-a10kldyfaP89a_JQZZwXozI=.119752cd-c8c6-4fe6-a514-a74bdd54bf54@github.com> Message-ID: <0Eoub_DvrlUmOZiIY6rqE-wJee6scFcgWUtYZ6Kl75g=.fe010d6e-3ce7-46a9-93ec-f78e0ab1b9ac@github.com> On Mon, 16 Dec 2024 09:24:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1238#issuecomment-2547740117 From goetz at openjdk.org Tue Dec 17 08:05:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:05:47 GMT Subject: [jdk17u-dev] RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:55:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3118#issuecomment-2547741097 From goetz at openjdk.org Tue Dec 17 08:05:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:05:48 GMT Subject: [jdk17u-dev] RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:43:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3116#issuecomment-2547741951 From goetz at openjdk.org Tue Dec 17 08:05:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:05:49 GMT Subject: [jdk17u-dev] RFR: 8328121: Remove applet usage from JColorChooser tests Test4759306 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:35:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3115#issuecomment-2547743048 From goetz at openjdk.org Tue Dec 17 08:05:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:05:55 GMT Subject: [jdk17u-dev] RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main In-Reply-To: References: Message-ID: <2Sazcb92isyOSXlX08ulJG23xHAmiN6QdgVKqEb1Lm0=.f2653b92-006f-4e40-b3b1-f94908218627@github.com> On Mon, 16 Dec 2024 08:47:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3117#issuecomment-2547741533 From goetz at openjdk.org Tue Dec 17 08:06:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:06:40 GMT Subject: [jdk21u-dev] RFR: 8328121: Remove applet usage from JColorChooser tests Test4759306 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:35:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1232#issuecomment-2547743495 From goetz at openjdk.org Tue Dec 17 08:06:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:06:44 GMT Subject: [jdk21u-dev] RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456 In-Reply-To: <6GpxIMUZM60-INk9jqbXO2gKMxAXJ8EzMogkk9lJ37A=.b684c835-87f0-4f2b-a91f-011247da35da@github.com> References: <6GpxIMUZM60-INk9jqbXO2gKMxAXJ8EzMogkk9lJ37A=.b684c835-87f0-4f2b-a91f-011247da35da@github.com> Message-ID: On Mon, 16 Dec 2024 08:39:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1233#issuecomment-2547742526 From goetz at openjdk.org Tue Dec 17 08:06:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:06:47 GMT Subject: [jdk17u-dev] RFR: 8327859: Remove applet usage from JColorChooser tests Test4319113 In-Reply-To: References: Message-ID: <0HU6RtTyqVhEzKvHqtFQqOPOj4L6hl6SSba4wQi34Kw=.d7d90b31-1224-4d70-b501-7ae123a8b829@github.com> On Mon, 16 Dec 2024 08:34:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3114#issuecomment-2547744264 From goetz at openjdk.org Tue Dec 17 08:06:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:06:49 GMT Subject: [jdk17u-dev] RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 09:06:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3119#issuecomment-2547740668 From goetz at openjdk.org Tue Dec 17 08:12:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 08:12:12 GMT Subject: [jdk17u-dev] RFR: 8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing Message-ID: <7lwxMKv86wFIh4LUvXw-wk1SjGL6LLlG8uxuqF2BNzo=.5d15d5a6-5e1b-4462-8e37-48830ebd8d61@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 69c0b24386d0bcf2f2d623ccef0192a54753f916 Changes: https://git.openjdk.org/jdk17u-dev/pull/3129/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3129&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320714 Stats: 6 lines in 2 files changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3129.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3129/head:pull/3129 PR: https://git.openjdk.org/jdk17u-dev/pull/3129 From rrich at openjdk.org Tue Dec 17 08:12:44 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 17 Dec 2024 08:12:44 GMT Subject: [jdk21u-dev] RFR: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate() In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 08:47:30 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/93aa7e2fcf87c4dc62de4ea71be543ee677b11be. > > The commit being backported was authored by Richard Reingruber on 21 Nov 2024 and was reviewed by Tobias Hartmann and Martin Doerr. > > The original commit did not apply because the `TracePhase` constructor used above the removed line was changed. > EDIT: the bot considers the backport to be clean. > // Actually I had to resolve the minimal conflict I mentioned above. > > I'd consider the risk medium. There could be scenarios with higher memory usage in c2 register allocation. > DaCapo tests didn't show higher memory usage. > (the measuring code was part of the [original pull request](https://github.com/openjdk/jdk/pull/22200/commits)) > > > Max. ResourceArea size in KB after C2 PhaseChaitin::merge_multidefs > > DaCapo Benchmark Basline Pull Request > > avrora 2167 2167 > batik 2600 2509 > biojava 3125 3125 > cassandra 482 514 > eclipse 3408 3400 > fop 2863 2895 > graphchi 1331 1331 > h2 3204 3290 > h2o 638 514 > jme 2160 2160 > jython 9617 9649 > kafka 2577 2586 > luindex 2738 2902 > lusearch 2645 2645 > pmd 2931 2723 > spring 2958 3383 > sunflow 1437 1437 > tomcat 2668 2643 > tradebeans 2975 2663 > tradesoap 3124 2663 > xalan 3025 2826 > zxing 2473 2505 > > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. > > Thanks, Richard. Retrying... /integrate ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1217#issuecomment-2547755968 From rrich at openjdk.org Tue Dec 17 08:38:40 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 17 Dec 2024 08:38:40 GMT Subject: [jdk21u-dev] Integrated: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate() In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 08:47:30 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/93aa7e2fcf87c4dc62de4ea71be543ee677b11be. > > The commit being backported was authored by Richard Reingruber on 21 Nov 2024 and was reviewed by Tobias Hartmann and Martin Doerr. > > The original commit did not apply because the `TracePhase` constructor used above the removed line was changed. > EDIT: the bot considers the backport to be clean. > // Actually I had to resolve the minimal conflict I mentioned above. > > I'd consider the risk medium. There could be scenarios with higher memory usage in c2 register allocation. > DaCapo tests didn't show higher memory usage. > (the measuring code was part of the [original pull request](https://github.com/openjdk/jdk/pull/22200/commits)) > > > Max. ResourceArea size in KB after C2 PhaseChaitin::merge_multidefs > > DaCapo Benchmark Basline Pull Request > > avrora 2167 2167 > batik 2600 2509 > biojava 3125 3125 > cassandra 482 514 > eclipse 3408 3400 > fop 2863 2895 > graphchi 1331 1331 > h2 3204 3290 > h2o 638 514 > jme 2160 2160 > jython 9617 9649 > kafka 2577 2586 > luindex 2738 2902 > lusearch 2645 2645 > pmd 2931 2723 > spring 2958 3383 > sunflow 1437 1437 > tomcat 2668 2643 > tradebeans 2975 2663 > tradesoap 3124 2663 > xalan 3025 2826 > zxing 2473 2505 > > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests. > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le and AIX. > > Thanks, Richard. This pull request has now been integrated. Changeset: a21862ab Author: Richard Reingruber URL: https://git.openjdk.org/jdk21u-dev/commit/a21862ab00317842da006eae453865badd4dc30f Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8328085: C2: Use after free in PhaseChaitin::Register_Allocate() Backport-of: 93aa7e2fcf87c4dc62de4ea71be543ee677b11be ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1217 From goetz at openjdk.org Tue Dec 17 09:40:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 09:40:21 GMT Subject: [jdk17u-dev] RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport a021dbcb9e58ab60abfc8c46ff25f3aa8ce3cc9f Changes: https://git.openjdk.org/jdk17u-dev/pull/3130/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3130&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316149 Stats: 393 lines in 5 files changed: 393 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3130.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3130/head:pull/3130 PR: https://git.openjdk.org/jdk17u-dev/pull/3130 From goetz at openjdk.org Tue Dec 17 09:40:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 09:40:31 GMT Subject: [jdk21u-dev] RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests Message-ID: <3X7l35wvp3fRyTuAWysPxz1EZe_lV5s26Umm-k2I7uw=.7b6b9b4b-6aa7-4d28-b54b-36cda5c69719@github.com> I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport a021dbcb9e58ab60abfc8c46ff25f3aa8ce3cc9f Changes: https://git.openjdk.org/jdk21u-dev/pull/1244/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1244&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316149 Stats: 393 lines in 5 files changed: 393 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1244.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1244/head:pull/1244 PR: https://git.openjdk.org/jdk21u-dev/pull/1244 From goetz at openjdk.org Tue Dec 17 09:40:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 09:40:51 GMT Subject: [jdk17u-dev] RFR: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 4e83f4cfc779e39cca0070b5729a508aeaa74654 Changes: https://git.openjdk.org/jdk17u-dev/pull/3131/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3131&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328185 Stats: 174 lines in 1 file changed: 41 ins; 94 del; 39 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3131.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3131/head:pull/3131 PR: https://git.openjdk.org/jdk17u-dev/pull/3131 From goetz at openjdk.org Tue Dec 17 09:42:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 09:42:13 GMT Subject: [jdk21u-dev] RFR: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 4e83f4cfc779e39cca0070b5729a508aeaa74654 Changes: https://git.openjdk.org/jdk21u-dev/pull/1245/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1245&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328185 Stats: 174 lines in 1 file changed: 41 ins; 94 del; 39 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1245.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1245/head:pull/1245 PR: https://git.openjdk.org/jdk21u-dev/pull/1245 From mdoerr at openjdk.org Tue Dec 17 09:55:47 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 17 Dec 2024 09:55:47 GMT Subject: [jdk17u-dev] RFR: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory In-Reply-To: References: Message-ID: <2wuKiu7l1raCWXstL_cOk_Qh9ZeQUq9OEPJVEH_kGFU=.23700176-672e-49a4-b8ba-1390de2ad8b9@github.com> On Wed, 11 Dec 2024 11:39:50 GMT, Martin Doerr wrote: > Backport of [JDK-8343205](https://bugs.openjdk.org/browse/JDK-8343205) from jdk21u-dev. All platforms are affected, but it is only problematic in environments in which `os::free_memory()` is slow. That was reported for some kind of container environment on linux x64. I think we should have this fix in 17u because JDK 17u is probably used in such environments, too. I think the risk is low, but we could also ship it one release later. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3106#issuecomment-2547987474 From mdoerr at openjdk.org Tue Dec 17 09:59:39 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 17 Dec 2024 09:59:39 GMT Subject: [jdk17u-dev] Integrated: 8343724: [PPC64] Disallow OptoScheduling In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 20:30:52 GMT, Martin Doerr wrote: > Clean backport of [JDK-8343724](https://bugs.openjdk.org/browse/JDK-8343724). This pull request has now been integrated. Changeset: 0254b70a Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/0254b70a88109aff32db845745bdb46e73e8df9c Stats: 39 lines in 2 files changed: 22 ins; 16 del; 1 mod 8343724: [PPC64] Disallow OptoScheduling Backport-of: f621f26cd113090a0305598cfc50f0eac9a263c6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3105 From goetz at openjdk.org Tue Dec 17 10:07:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 10:07:11 GMT Subject: [jdk17u-dev] RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 476421efe574eca6ba92aaa7fc86dfca99fdd7b2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3132/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3132&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328370 Stats: 298 lines in 3 files changed: 127 ins; 171 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3132.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3132/head:pull/3132 PR: https://git.openjdk.org/jdk17u-dev/pull/3132 From goetz at openjdk.org Tue Dec 17 10:07:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 10:07:49 GMT Subject: [jdk21u-dev] RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 476421efe574eca6ba92aaa7fc86dfca99fdd7b2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1246/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1246&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328370 Stats: 298 lines in 3 files changed: 127 ins; 171 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1246.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1246/head:pull/1246 PR: https://git.openjdk.org/jdk21u-dev/pull/1246 From mdoerr at openjdk.org Tue Dec 17 10:37:38 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 17 Dec 2024 10:37:38 GMT Subject: [jdk17u-dev] RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop [v2] In-Reply-To: <42OBYW7nCgpbqPbYGCV4Qrylo3G2JN9agLqziSzqWUc=.10252348-6254-4087-b0d4-bc960c4e27d8@github.com> References: <42OBYW7nCgpbqPbYGCV4Qrylo3G2JN9agLqziSzqWUc=.10252348-6254-4087-b0d4-bc960c4e27d8@github.com> Message-ID: <6_lXP9PUYBr2fTiZ4CT8qgP7-Om9xg7hMef9j-2nVJU=.8b38d979-94dc-45f9-9859-9250943614d4@github.com> On Mon, 16 Dec 2024 11:23:19 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.15-oracle. >> >> Two trivial resolved due to context changes. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport e203df46faf610e35e2c2510271ad68199f4fa3f LGTM. src/hotspot/share/opto/loopnode.hpp line 932: > 930: #ifdef ASSERT > 931: bool only_has_infinite_loops(); > 932: #endif The original change deletes the empty line, too. That's probably why this backport is not clean. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3123#pullrequestreview-2508490881 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3123#discussion_r1888287355 From goetz at openjdk.org Tue Dec 17 12:59:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 12:59:06 GMT Subject: [jdk17u-dev] RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.15-oracle. > > Two trivial resolved due to context changes. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Delete empty line ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3123/files - new: https://git.openjdk.org/jdk17u-dev/pull/3123/files/e0d01d7d..e9378b13 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3123&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3123&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3123.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3123/head:pull/3123 PR: https://git.openjdk.org/jdk17u-dev/pull/3123 From goetz at openjdk.org Tue Dec 17 12:59:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 12:59:07 GMT Subject: [jdk17u-dev] RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop [v3] In-Reply-To: <6_lXP9PUYBr2fTiZ4CT8qgP7-Om9xg7hMef9j-2nVJU=.8b38d979-94dc-45f9-9859-9250943614d4@github.com> References: <42OBYW7nCgpbqPbYGCV4Qrylo3G2JN9agLqziSzqWUc=.10252348-6254-4087-b0d4-bc960c4e27d8@github.com> <6_lXP9PUYBr2fTiZ4CT8qgP7-Om9xg7hMef9j-2nVJU=.8b38d979-94dc-45f9-9859-9250943614d4@github.com> Message-ID: On Tue, 17 Dec 2024 10:35:05 GMT, Martin Doerr wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Delete empty line > > src/hotspot/share/opto/loopnode.hpp line 932: > >> 930: #ifdef ASSERT >> 931: bool only_has_infinite_loops(); >> 932: #endif > > The original change deletes the empty line, too. That's probably why this backport is not clean. Let's see... ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3123#discussion_r1888475223 From goetz at openjdk.org Tue Dec 17 13:01:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:01:43 GMT Subject: [jdk21u-dev] Integrated: 8327859: Remove applet usage from JColorChooser tests Test4319113 In-Reply-To: <8Tvbzsq1zncyTv2jF-C-k2nun7dPhFcfVuBNLW7UC1A=.78758a41-7d24-4150-ba57-f4243e5ddce6@github.com> References: <8Tvbzsq1zncyTv2jF-C-k2nun7dPhFcfVuBNLW7UC1A=.78758a41-7d24-4150-ba57-f4243e5ddce6@github.com> Message-ID: On Mon, 16 Dec 2024 08:34:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: fa461666 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/fa4616661ddd89ec484f84181073e8091c2b1bc2 Stats: 108 lines in 2 files changed: 22 ins; 53 del; 33 mod 8327859: Remove applet usage from JColorChooser tests Test4319113 Backport-of: 89fb0f837b7dbeed581f5db79d915cf405afda31 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1231 From goetz at openjdk.org Tue Dec 17 13:05:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:05:42 GMT Subject: [jdk21u-dev] Integrated: 8328121: Remove applet usage from JColorChooser tests Test4759306 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:35:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 8c58f66c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/8c58f66c3a8ec1fc8e943738807bbd38f4634f22 Stats: 54 lines in 2 files changed: 14 ins; 33 del; 7 mod 8328121: Remove applet usage from JColorChooser tests Test4759306 Backport-of: fab0edc9e636c69d7012e476e97661ddae993a03 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1232 From goetz at openjdk.org Tue Dec 17 13:06:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:06:41 GMT Subject: [jdk21u-dev] Integrated: 8328380: Remove applet usage from JColorChooser tests Test6348456 In-Reply-To: <6GpxIMUZM60-INk9jqbXO2gKMxAXJ8EzMogkk9lJ37A=.b684c835-87f0-4f2b-a91f-011247da35da@github.com> References: <6GpxIMUZM60-INk9jqbXO2gKMxAXJ8EzMogkk9lJ37A=.b684c835-87f0-4f2b-a91f-011247da35da@github.com> Message-ID: On Mon, 16 Dec 2024 08:39:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 7478c4b4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/7478c4b43f7447d3eed64c4937ec25111b2ba635 Stats: 93 lines in 2 files changed: 37 ins; 45 del; 11 mod 8328380: Remove applet usage from JColorChooser tests Test6348456 Backport-of: 78d1b9046830198cd61c505f04f245a430878a5b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1233 From goetz at openjdk.org Tue Dec 17 13:07:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:07:47 GMT Subject: [jdk17u-dev] Integrated: 8327859: Remove applet usage from JColorChooser tests Test4319113 In-Reply-To: References: Message-ID: <8RmVTd4GR608R5Xal-X6oLzkKIwipK7vfo_h0Ao8TV4=.91a9b4d0-a10a-431a-bef4-6af27d99ed81@github.com> On Mon, 16 Dec 2024 08:34:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: c0648b38 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c0648b382906c9af3079beac39fcda2d4c5c6d1b Stats: 108 lines in 2 files changed: 22 ins; 53 del; 33 mod 8327859: Remove applet usage from JColorChooser tests Test4319113 Backport-of: 89fb0f837b7dbeed581f5db79d915cf405afda31 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3114 From goetz at openjdk.org Tue Dec 17 13:08:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:08:40 GMT Subject: [jdk21u-dev] Integrated: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:47:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 52daaa95 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/52daaa95e5b5405635c1f6925a891fa9dd1b7ee7 Stats: 131 lines in 2 files changed: 41 ins; 50 del; 40 mod 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main Backport-of: 27ac39a2bc8250bfae859568cb0ee0963900aafa ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1234 From goetz at openjdk.org Tue Dec 17 13:09:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:09:40 GMT Subject: [jdk17u-dev] Integrated: 8328121: Remove applet usage from JColorChooser tests Test4759306 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:35:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 3fe74455 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/3fe74455728c3138d578f9c684ad009454e8fed2 Stats: 54 lines in 2 files changed: 14 ins; 33 del; 7 mod 8328121: Remove applet usage from JColorChooser tests Test4759306 Backport-of: fab0edc9e636c69d7012e476e97661ddae993a03 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3115 From goetz at openjdk.org Tue Dec 17 13:10:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:10:40 GMT Subject: [jdk21u-dev] Integrated: 8328227: Remove applet usage from JColorChooser tests Test4887836 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:56:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 544c4b57 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/544c4b57326e95d0c5bbe5f443bd4fcb896bedaa Stats: 66 lines in 2 files changed: 21 ins; 34 del; 11 mod 8328227: Remove applet usage from JColorChooser tests Test4887836 Backport-of: cc5b9c63cbc1743e22f80dce51d803e267c60317 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1236 From goetz at openjdk.org Tue Dec 17 13:11:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:11:40 GMT Subject: [jdk17u-dev] Integrated: 8328380: Remove applet usage from JColorChooser tests Test6348456 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:43:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: d4cdd73e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d4cdd73e6afcec84addf7315a236774bc992791c Stats: 93 lines in 2 files changed: 37 ins; 45 del; 11 mod 8328380: Remove applet usage from JColorChooser tests Test6348456 Backport-of: 78d1b9046830198cd61c505f04f245a430878a5b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3116 From goetz at openjdk.org Tue Dec 17 13:12:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:12:40 GMT Subject: [jdk21u-dev] Integrated: 8328403: Remove applet usage from JColorChooser tests Test6977726 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 09:06:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 3d710291 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/3d710291136573f1fb1d8087ae5da745d4dd4ba0 Stats: 63 lines in 2 files changed: 21 ins; 32 del; 10 mod 8328403: Remove applet usage from JColorChooser tests Test6977726 Backport-of: 1e76e1fdfa67c28ce20b0dc7fb0253670be54554 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1237 From mbaesken at openjdk.org Tue Dec 17 13:12:45 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 17 Dec 2024 13:12:45 GMT Subject: [jdk21u-dev] Integrated: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:48:36 GMT, Matthias Baesken wrote: > 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object This pull request has now been integrated. Changeset: 2867acd2 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/2867acd233321d59c791e8e73752cc416b4c7897 Stats: 16 lines in 4 files changed: 12 ins; 0 del; 4 mod 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object Backport-of: ec310fe80971261ab7ee1141c64ffd600e7546c0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1235 From goetz at openjdk.org Tue Dec 17 13:13:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:13:43 GMT Subject: [jdk17u-dev] Integrated: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main In-Reply-To: References: Message-ID: <5mt86yhB26FaVRuypepFpFe96HP5iuJGamy9eyw0I-E=.811b6100-60e8-4803-8973-b2efee9e3d43@github.com> On Mon, 16 Dec 2024 08:47:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 525df89a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/525df89a2a06c257d99b573834ec19ea88639b5e Stats: 131 lines in 2 files changed: 41 ins; 50 del; 40 mod 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main Backport-of: 27ac39a2bc8250bfae859568cb0ee0963900aafa ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3117 From goetz at openjdk.org Tue Dec 17 13:14:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:14:47 GMT Subject: [jdk21u-dev] Integrated: 8328753: Open source few Undecorated Frame tests In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 10:42:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. > > I include follow-up fix JDK-8337886. > > Tests pass. This pull request has now been integrated. Changeset: 539990cd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/539990cd9a7241e7e9d8f5dc1fdf832eb0fa7860 Stats: 350 lines in 3 files changed: 350 ins; 0 del; 0 mod 8328753: Open source few Undecorated Frame tests 8337886: java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight color difference Reviewed-by: mdoerr Backport-of: db159149c1c13a98ee9a85750741c6a3cd39f408 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1228 From goetz at openjdk.org Tue Dec 17 13:15:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:15:44 GMT Subject: [jdk17u-dev] Integrated: 8328227: Remove applet usage from JColorChooser tests Test4887836 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 08:55:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle This pull request has now been integrated. Changeset: dc3917c4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/dc3917c4970b8f409789bfa46449c79fbc71ada6 Stats: 66 lines in 2 files changed: 21 ins; 34 del; 11 mod 8328227: Remove applet usage from JColorChooser tests Test4887836 Backport-of: cc5b9c63cbc1743e22f80dce51d803e267c60317 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3118 From goetz at openjdk.org Tue Dec 17 13:16:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:16:39 GMT Subject: [jdk21u-dev] Integrated: 8333360: PrintNullString.java doesn't use float arguments In-Reply-To: <_iNEU7PdhCTaTuN-JIf-a10kldyfaP89a_JQZZwXozI=.119752cd-c8c6-4fe6-a514-a74bdd54bf54@github.com> References: <_iNEU7PdhCTaTuN-JIf-a10kldyfaP89a_JQZZwXozI=.119752cd-c8c6-4fe6-a514-a74bdd54bf54@github.com> Message-ID: On Mon, 16 Dec 2024 09:24:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 35f769da Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/35f769da098c98e93cea916d3313be82624809d8 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8333360: PrintNullString.java doesn't use float arguments Backport-of: aaaa86b57172d45d1126c50efc270c6e49aba7a5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1238 From goetz at openjdk.org Tue Dec 17 13:17:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:17:38 GMT Subject: [jdk21u-dev] Integrated: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 09:28:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: f44b8eac Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/f44b8eacfaf386c48d6ffc32b7e0a2be0369f9f0 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException Backport-of: 2a2964759c73b3b9ab6afaad109383c89952977b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1239 From goetz at openjdk.org Tue Dec 17 13:17:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:17:41 GMT Subject: [jdk17u-dev] Integrated: 8328403: Remove applet usage from JColorChooser tests Test6977726 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 09:06:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle This pull request has now been integrated. Changeset: 0c14fe28 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0c14fe2875f4b2014fbcb2178727da911fc0c824 Stats: 63 lines in 2 files changed: 21 ins; 32 del; 10 mod 8328403: Remove applet usage from JColorChooser tests Test6977726 Backport-of: 1e76e1fdfa67c28ce20b0dc7fb0253670be54554 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3119 From goetz at openjdk.org Tue Dec 17 13:20:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:20:41 GMT Subject: [jdk17u-dev] Integrated: 8333360: PrintNullString.java doesn't use float arguments In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 09:24:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 114a1e50 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/114a1e5024424668f55362d52f6aff7fcea78a53 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8333360: PrintNullString.java doesn't use float arguments Backport-of: aaaa86b57172d45d1126c50efc270c6e49aba7a5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3120 From goetz at openjdk.org Tue Dec 17 13:21:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:21:43 GMT Subject: [jdk21u-dev] Integrated: 8336692: Redo fix for JDK-8284620 In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 10:57:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle. This pull request has now been integrated. Changeset: c609fe54 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c609fe5454a62e132fd950fe43dea4cef05c8a45 Stats: 6 lines in 1 file changed: 2 ins; 3 del; 1 mod 8336692: Redo fix for JDK-8284620 Backport-of: c5b7af73d07f7458e970f5752eb75640562ddc7b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1229 From goetz at openjdk.org Tue Dec 17 13:22:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:22:40 GMT Subject: [jdk21u-dev] Integrated: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 11:29:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: e8842b7b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e8842b7b92baef8ce4e0516168dc2c317ca96564 Stats: 22 lines in 1 file changed: 3 ins; 2 del; 17 mod 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC Backport-of: 51b85a1f692fed7a66bdc0fae21438a60aafe7c2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1240 From goetz at openjdk.org Tue Dec 17 13:22:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:22:44 GMT Subject: [jdk17u-dev] Integrated: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException In-Reply-To: <3aWsiFboKGNGiUvdaMiTK3iq39Uj1fPR_9k45DeyPNI=.77ff1c63-8c79-4f91-87fd-1806fbfadd1d@github.com> References: <3aWsiFboKGNGiUvdaMiTK3iq39Uj1fPR_9k45DeyPNI=.77ff1c63-8c79-4f91-87fd-1806fbfadd1d@github.com> Message-ID: <8FykYl7v3AlyXnZLxIS6dn43vsqpkRoTtfTX7711BRo=.cbca1a9c-7bce-43e5-bd72-469fbbb34eb0@github.com> On Mon, 16 Dec 2024 09:28:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 9b9027c0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9b9027c0e220b20627d303d2167ac8880cf6b315 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException Backport-of: 2a2964759c73b3b9ab6afaad109383c89952977b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3121 From goetz at openjdk.org Tue Dec 17 13:25:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:25:49 GMT Subject: [jdk17u-dev] Integrated: 8336692: Redo fix for JDK-8284620 In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 11:02:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.6-oracle > > Resolved due to nullptr differences. This pull request has now been integrated. Changeset: b532a4a6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b532a4a69b4628e79d52b394f01ecd78db117b90 Stats: 6 lines in 1 file changed: 2 ins; 3 del; 1 mod 8336692: Redo fix for JDK-8284620 Reviewed-by: mdoerr Backport-of: c5b7af73d07f7458e970f5752eb75640562ddc7b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3112 From goetz at openjdk.org Tue Dec 17 13:25:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:25:52 GMT Subject: [jdk21u-dev] Integrated: 8339902: Open source couple TextField related tests In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 12:39:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 6a2ef78a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/6a2ef78a33d2bddc1ec178a763fe892775efb796 Stats: 527 lines in 5 files changed: 527 ins; 0 del; 0 mod 8339902: Open source couple TextField related tests Backport-of: fde8508379d2983fa70784faef60699c81f9c359 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1241 From goetz at openjdk.org Tue Dec 17 13:26:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:26:34 GMT Subject: [jdk17u-dev] RFR: 8328753: Open source few Undecorated Frame tests Message-ID: I backport this for parity with 17.0.14-oracle. ------------- Commit messages: - Backport 539990cd9a7241e7e9d8f5dc1fdf832eb0fa7860 Changes: https://git.openjdk.org/jdk17u-dev/pull/3133/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3133&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328753 Stats: 350 lines in 3 files changed: 350 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3133.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3133/head:pull/3133 PR: https://git.openjdk.org/jdk17u-dev/pull/3133 From goetz at openjdk.org Tue Dec 17 13:26:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:26:49 GMT Subject: [jdk17u-dev] Integrated: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 09:35:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: f706c24e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f706c24e53565fa4ed090d1080e058b1f0073bd6 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep Backport-of: 739b5fb886ef828949b401810caabff6b7a8f827 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3122 From goetz at openjdk.org Tue Dec 17 13:26:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:26:53 GMT Subject: [jdk21u-dev] Integrated: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 13:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: dbf6f67b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/dbf6f67b145d6d31bf926e5787bc9791cbabfadf Stats: 221 lines in 4 files changed: 90 ins; 6 del; 125 mod 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 Backport-of: b4ab290fd7c3d914154755a1539b48ba33338c26 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1242 From goetz at openjdk.org Tue Dec 17 13:28:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:28:43 GMT Subject: [jdk17u-dev] Integrated: 8336498: [macos] [build]: install-file macro may run into permission denied error In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 11:27:31 GMT, Goetz Lindenmaier wrote: > I'd like to fix this build issue in 17. This pull request has now been integrated. Changeset: 585297dd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/585297ddee41995ef5b0b952956c31ee111a3ab9 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8336498: [macos] [build]: install-file macro may run into permission denied error 8342858: Make target mac-jdk-bundle fails on chmod command Backport-of: b682b1faa0e1d8b3ff7aa5c5813e3ab0cd8f159c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3124 From mbaesken at openjdk.org Tue Dec 17 13:29:11 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 17 Dec 2024 13:29:11 GMT Subject: [jdk21u-dev] RFR: 8339475: Clean up return code handling for pthread calls in library coding Message-ID: Backport of 8339475 + follow up 8341135 ------------- Commit messages: - Backport 2a2ecc994e02049d6d84f083b8e92a51368577bf Changes: https://git.openjdk.org/jdk21u-dev/pull/1247/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1247&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339475 Stats: 24 lines in 4 files changed: 9 ins; 8 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1247.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1247/head:pull/1247 PR: https://git.openjdk.org/jdk21u-dev/pull/1247 From goetz at openjdk.org Tue Dec 17 13:31:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:31:41 GMT Subject: [jdk21u-dev] Integrated: 8341978: Improve JButton/bug4490179.java In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 14:06:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 30eeb80f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/30eeb80fac1f56b70cde746890d25208f2743900 Stats: 88 lines in 1 file changed: 66 ins; 3 del; 19 mod 8341978: Improve JButton/bug4490179.java Use latch to synchronize actions in the test. Verify mouseButton3Released does not trigger actionPerformed while mouse button 1 is pressed. Ensure mouse button 1 is released. Verify releasing mouse button 1 triggers actionPerformed. Backport-of: 8174cbd5cb797a80d48246a686897ef6fe64ed57 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1243 From goetz at openjdk.org Tue Dec 17 13:31:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:31:45 GMT Subject: [jdk17u-dev] Integrated: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 10:50:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > Two trivial resolved due to context changes. This pull request has now been integrated. Changeset: 71d5c0b2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/71d5c0b247c22da75c2fb053cd93a167b02bf28f Stats: 308 lines in 7 files changed: 257 ins; 32 del; 19 mod 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop Reviewed-by: mdoerr Backport-of: e203df46faf610e35e2c2510271ad68199f4fa3f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3123 From goetz at openjdk.org Tue Dec 17 13:32:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:32:38 GMT Subject: [jdk17u-dev] Integrated: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC In-Reply-To: <1oPReLXHI9-eKHTMFSfQ0FFFOK7kBFylIXn5TiyH9xc=.3688af4f-da45-48ac-9333-f7a25cacb611@github.com> References: <1oPReLXHI9-eKHTMFSfQ0FFFOK7kBFylIXn5TiyH9xc=.3688af4f-da45-48ac-9333-f7a25cacb611@github.com> Message-ID: On Mon, 16 Dec 2024 11:29:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: fb37a919 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fb37a9190254869d0cfe6510448eec7bbf9edb2c Stats: 22 lines in 1 file changed: 3 ins; 2 del; 17 mod 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC Backport-of: 51b85a1f692fed7a66bdc0fae21438a60aafe7c2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3125 From goetz at openjdk.org Tue Dec 17 13:33:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:33:41 GMT Subject: [jdk21u-dev] Integrated: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 16:06:49 GMT, Goetz Lindenmaier wrote: > I would like to backport this to make follow-up backports clean. > > I checked all files that would not patch clean for predecessors that are candidates for > backport. The remaining resolves are the following: > > test/jdk/tools/jpackage/TEST.properties > Resolved. Will backport 8314909, which probably makes this clean. > > test/jdk/tools/jpackage/share/AppContentTest.java > One of the removed @modules statements is not in 21. It was added in 24 with 8341443. > > test/jdk/tools/jpackage/share/RuntimeImageTest.java > Trivial resolve > > test/jdk/tools/jpackage/share/jdk/jpackage/tests/JLinkOptionsTest.java > Resolved Copyright. "8308398: Move SunEC crypto provider into java.base" not in 21. > > test/jdk/tools/jpackage/windows/WinChildProcessTest.java > Resolved. "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" not in 21. > > Some tests touched by this change are not in 21. Some came with new features, > but other with bug fixes that are theoretically applicable to 21. Non of these fixes > qualify for an obvious and simple backport that could be done as prereq of a > pure test rework. Here the list: > > > test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/DirectoryContentVerifierTest.java > test/jdk/tools/jpackage/share/InOutPathTest.java > Both added by "8325089: jpackage utility creates an "infinite", undeleteable directory tree", a bug > that sounds interesting for 21, 17. But it is big and rather new, so don't backport now. > > test/jdk/tools/jpackage/linux/ServiceAndDesktopTest.java > test/jdk/tools/jpackage/linux/UpgradeTest.java > Both added by "8301856: Generated .spec file for RPM installers uninstalls desktop launcher > on update", a bug that sounds interesting for 21, 17. It was published in 22, so it should be > considered as stable. But it is big and Oracle did not address this yet, so let's not backport. > > test/jdk/tools/jpackage/macosx/SigningOptionsTest.java > Added by "8311877: [macos] Add CLI options to provide signing identity directly to > codesign and productbuild" in 22. A new feature, no candidate for backport. > > test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java > Added by "8310933: Copying from runtime image to application image should not > follow symlinks" in 22. Enhancement. > > test/jdk/tools/jpackage/windows/WinNoRestartTest.java > Added by "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" in 24. This pull request has now been integrated. Changeset: e1b5f3c5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e1b5f3c56d02c6738726106d3d069fea7a633245 Stats: 278 lines in 80 files changed: 4 ins; 113 del; 161 mod 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file Reviewed-by: mdoerr Backport-of: c33a8f52b613e5eff02f572eda876cbbfc7c22cf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1221 From goetz at openjdk.org Tue Dec 17 13:34:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:34:40 GMT Subject: [jdk17u-dev] Integrated: 8339902: Open source couple TextField related tests In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 12:39:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 159bd1cc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/159bd1cc6fd640845b7f11d23e053fc53372c59e Stats: 527 lines in 5 files changed: 527 ins; 0 del; 0 mod 8339902: Open source couple TextField related tests Backport-of: fde8508379d2983fa70784faef60699c81f9c359 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3126 From goetz at openjdk.org Tue Dec 17 13:37:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:37:37 GMT Subject: [jdk17u-dev] Integrated: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 In-Reply-To: References: Message-ID: On Mon, 16 Dec 2024 13:17:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: e3b26387 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e3b26387a3aa24640729086166fa52b6c5a6ea92 Stats: 221 lines in 4 files changed: 90 ins; 6 del; 125 mod 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 Backport-of: b4ab290fd7c3d914154755a1539b48ba33338c26 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3127 From goetz at openjdk.org Tue Dec 17 13:40:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 13:40:38 GMT Subject: [jdk17u-dev] Integrated: 8341978: Improve JButton/bug4490179.java In-Reply-To: <3QNfea5_b18wTOr2tOi9sgzuanix-1p7NVXFW_m_yCo=.32ba2f23-015b-465f-9ac1-556f6c10bd94@github.com> References: <3QNfea5_b18wTOr2tOi9sgzuanix-1p7NVXFW_m_yCo=.32ba2f23-015b-465f-9ac1-556f6c10bd94@github.com> Message-ID: <9t-lq0dugGr20b4Ju_Su4sd_MizDsHfE1Sc9ztv-fK0=.d0da1994-db5b-4edf-95a6-4970a49dba16@github.com> On Mon, 16 Dec 2024 14:07:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle This pull request has now been integrated. Changeset: 6400a16b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6400a16be535bd311574a9c93fdf9dd26eaa37ee Stats: 88 lines in 1 file changed: 66 ins; 3 del; 19 mod 8341978: Improve JButton/bug4490179.java Use latch to synchronize actions in the test. Verify mouseButton3Released does not trigger actionPerformed while mouse button 1 is pressed. Ensure mouse button 1 is released. Verify releasing mouse button 1 triggers actionPerformed. Backport-of: 8174cbd5cb797a80d48246a686897ef6fe64ed57 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3128 From goetz at openjdk.org Tue Dec 17 14:07:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 14:07:50 GMT Subject: [jdk17u-dev] RFR: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main Message-ID: <9rtHiYVUMyD5P3Xh-VxH_sPs9VosC8Y6IOjNK7xgylQ=.4f3a8080-49d1-4bbe-ab84-c77378c185e0@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport a1fbbffb5e0d7e41a9c3041b7e64382780e86f50 Changes: https://git.openjdk.org/jdk17u-dev/pull/3134/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3134&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328717 Stats: 86 lines in 3 files changed: 26 ins; 46 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3134.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3134/head:pull/3134 PR: https://git.openjdk.org/jdk17u-dev/pull/3134 From goetz at openjdk.org Tue Dec 17 14:08:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 14:08:26 GMT Subject: [jdk21u-dev] RFR: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport a1fbbffb5e0d7e41a9c3041b7e64382780e86f50 Changes: https://git.openjdk.org/jdk21u-dev/pull/1248/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1248&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328717 Stats: 86 lines in 3 files changed: 26 ins; 46 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1248.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1248/head:pull/1248 PR: https://git.openjdk.org/jdk21u-dev/pull/1248 From goetz at openjdk.org Tue Dec 17 14:10:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 14:10:14 GMT Subject: [jdk21u-dev] RFR: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport db01fcd6d8c24b01a1f23c71b2917ff396b0686f Changes: https://git.openjdk.org/jdk21u-dev/pull/1249/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1249&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328827 Stats: 398 lines in 3 files changed: 93 ins; 305 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1249.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1249/head:pull/1249 PR: https://git.openjdk.org/jdk21u-dev/pull/1249 From goetz at openjdk.org Tue Dec 17 14:10:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 17 Dec 2024 14:10:19 GMT Subject: [jdk17u-dev] RFR: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main Message-ID: <8jR-DeEekUe4FnfPAIj7zsBP3BQHGpTh5kelZsCLvXg=.0ea2d31b-50ab-490d-b863-35fe308f4cc4@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport db01fcd6d8c24b01a1f23c71b2917ff396b0686f Changes: https://git.openjdk.org/jdk17u-dev/pull/3135/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3135&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328827 Stats: 398 lines in 3 files changed: 93 ins; 305 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3135.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3135/head:pull/3135 PR: https://git.openjdk.org/jdk17u-dev/pull/3135 From phh at openjdk.org Tue Dec 17 15:53:38 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 17 Dec 2024 15:53:38 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. > > The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1068#pullrequestreview-2509276767 From sgehwolf at openjdk.org Tue Dec 17 16:38:45 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 17 Dec 2024 16:38:45 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: <8MvSJ_IZzFp-SYj32IV7isaBjQNRZQnlaqRes6J8-NU=.3e33041a-9676-421b-b905-c2aaf949010c@github.com> On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. > > The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! Seems OK. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1068#pullrequestreview-2509447098 From szaldana at openjdk.org Tue Dec 17 17:47:43 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 17 Dec 2024 17:47:43 GMT Subject: [jdk21u-dev] Integrated: 8315882: Open some swing tests 2 In-Reply-To: <5nRnXi4xkXpyRN3eGFyQsMOPDz_Uzx4Fq64McxDzzrI=.1903f0e6-4d3c-4ea2-82f9-c3d23a5cdbc3@github.com> References: <5nRnXi4xkXpyRN3eGFyQsMOPDz_Uzx4Fq64McxDzzrI=.1903f0e6-4d3c-4ea2-82f9-c3d23a5cdbc3@github.com> Message-ID: On Mon, 9 Dec 2024 16:39:47 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [d2d7d9a8](https://github.com/openjdk/jdk/commit/d2d7d9a8b7c68865553dcbb4d660bbb06fde3974) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alisen Chung on 23 Sep 2023 and was reviewed by Harshitha Onkar and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 85453b6b Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/85453b6b8c4b5127c8686467c0088a1c1a1ed9ab Stats: 228 lines in 3 files changed: 228 ins; 0 del; 0 mod 8315882: Open some swing tests 2 Backport-of: d2d7d9a8b7c68865553dcbb4d660bbb06fde3974 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1212 From szaldana at openjdk.org Tue Dec 17 17:49:45 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 17 Dec 2024 17:49:45 GMT Subject: [jdk21u-dev] Integrated: 8316218: Open some swing tests 5 In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 19:38:49 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [788e6e15](https://github.com/openjdk/jdk/commit/788e6e154824317cf92884510c2ee116bc64f510) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alisen Chung on 26 Sep 2023 and was reviewed by Phil Race and Damon Nguyen. > > Thanks! This pull request has now been integrated. Changeset: 0cdb868b Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/0cdb868b2e497269f3f4caa00f2096323d87bd24 Stats: 262 lines in 4 files changed: 262 ins; 0 del; 0 mod 8316218: Open some swing tests 5 Backport-of: 788e6e154824317cf92884510c2ee116bc64f510 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1214 From szaldana at openjdk.org Tue Dec 17 17:49:52 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 17 Dec 2024 17:49:52 GMT Subject: [jdk21u-dev] Integrated: 8316146: Open some swing tests 4 In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 19:57:41 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [3105538d](https://github.com/openjdk/jdk/commit/3105538de5569845547b40f243a994a95a84b48f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alisen Chung on 4 Oct 2023 and was reviewed by Harshitha Onkar, Alexey Ivanov and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 0cb77050 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/0cb7705075224d1f30c70a6dd3a9fbfd7cab469d Stats: 311 lines in 4 files changed: 311 ins; 0 del; 0 mod 8316146: Open some swing tests 4 Backport-of: 3105538de5569845547b40f243a994a95a84b48f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1215 From szaldana at openjdk.org Tue Dec 17 17:50:47 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 17 Dec 2024 17:50:47 GMT Subject: [jdk21u-dev] Integrated: 8316371: Open some swing tests 6 In-Reply-To: <8RhSlYGI_UNpDm8TNU1fP10_0iADk-ypEJZre0bRlMo=.0202b49a-6a1e-47b4-a128-4a30bcd8d7e5@github.com> References: <8RhSlYGI_UNpDm8TNU1fP10_0iADk-ypEJZre0bRlMo=.0202b49a-6a1e-47b4-a128-4a30bcd8d7e5@github.com> Message-ID: On Mon, 9 Dec 2024 19:59:11 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [d3a79b58](https://github.com/openjdk/jdk/commit/d3a79b5861be27227b8c28cb3acdce089b74c50b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alisen Chung on 27 Sep 2023 and was reviewed by Damon Nguyen and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: cce93361 Author: Sonia Zaldana Calles URL: https://git.openjdk.org/jdk21u-dev/commit/cce9336133d4e3118e478f408a112466ff32a62e Stats: 569 lines in 5 files changed: 569 ins; 0 del; 0 mod 8316371: Open some swing tests 6 Backport-of: d3a79b5861be27227b8c28cb3acdce089b74c50b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1216 From duke at openjdk.org Tue Dec 17 18:02:47 2024 From: duke at openjdk.org (duke) Date: Tue, 17 Dec 2024 18:02:47 GMT Subject: [jdk21u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 15:54:47 GMT, Antonio Vieiro wrote: > A clean backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. > > The fix doesn't affect directly to SA tests in `21`, but it's being backported to `11` as this is the cause of [an older version of `serviceability/sa/ClhsdbFindPC.java` failing in JDK 11 on macos-13 GHA runners](https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579). > > Tests in 21 continue to pass in all platforms, including `macos`. @vieiro Your change (at version 38927c6f0174d28b4c01b48b639ca2f32dedf498) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1227#issuecomment-2549208105 From cushon at openjdk.org Tue Dec 17 19:47:49 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 17 Dec 2024 19:47:49 GMT Subject: [jdk11u-dev] RFR: 8273914: Indy string concat changes order of operations [v4] In-Reply-To: References: <48_6CiXhu6kGwSLVNcSEC9X5wi7rc6JOMY2CaEJ1yu4=.bbf55ed2-ef95-413c-a4d9-85f3b386778c@github.com> Message-ID: <-UzUIQAUeXKYXTNlQRmHjzf-f4w49TbqdFyqKXqvpnU=.19577524-9494-447e-a2f4-02116f03addf@github.com> On Tue, 19 Nov 2024 17:09:19 GMT, Liam Miller-Cushon wrote: >> This is a backport of [JDK-8273914: Indy string concat changes order of operations](https://bugs.openjdk.org/browse/JDK-8273914). >> >> The patch applied cleanly. I downgrade the class file major version in the `.jasm` test inputs for compatibility with JDK 11. >> >> Testing: tier1 langtools tests > > Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into backport-JDK-8273914 > - Downgrade major version for jasm test inputs > - Merge remote-tracking branch 'upstream/master' into backport-JDK-8273914 > - Backport cfee4512f7048e9cf440078e9eb87d37c7ebcdd9 Let's keep this open ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2933#issuecomment-2549460359 From cushon at openjdk.org Tue Dec 17 20:32:58 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 17 Dec 2024 20:32:58 GMT Subject: [jdk21u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v3] In-Reply-To: References: Message-ID: > This change improves annotation processing test coverage, see [JDK-8336942](https://bugs.openjdk.org/browse/JDK-8336942). I resolved a trivial merge conflict with JDK-8323684, which added the `nameToAnnotation` map. The modified test passes. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 - 8336942: Improve test coverage for class loading elements with annotations of different retentions Reviewed-by: vromero ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1037/files - new: https://git.openjdk.org/jdk21u-dev/pull/1037/files/3729338f..a89f69b6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1037&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1037&range=01-02 Stats: 14664 lines in 611 files changed: 8350 ins; 1688 del; 4626 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1037.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1037/head:pull/1037 PR: https://git.openjdk.org/jdk21u-dev/pull/1037 From duke at openjdk.org Tue Dec 17 20:53:48 2024 From: duke at openjdk.org (duke) Date: Tue, 17 Dec 2024 20:53:48 GMT Subject: [jdk17u-dev] RFR: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 14:11:14 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. @krk Your change (at version 0882e5e59b44d4ae56365ea1227d73c3ead818fb) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3111#issuecomment-2549601730 From cushon at openjdk.org Tue Dec 17 22:24:07 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 17 Dec 2024 22:24:07 GMT Subject: [jdk21u-dev] RFR: 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries Message-ID: [JDK-8341779](https://bugs.openjdk.org/browse/JDK-8341779) is a redo of the backport of [JDK-8323093](https://bugs.openjdk.org/browse/JDK-8323093), see also discussion in CSR [JDK-8346471](https://bugs.openjdk.org/browse/JDK-8346471). ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1037 Commit messages: - 8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries Changes: https://git.openjdk.org/jdk21u-dev/pull/1251/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1251&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341779 Stats: 302 lines in 2 files changed: 302 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1251.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1251/head:pull/1251 PR: https://git.openjdk.org/jdk21u-dev/pull/1251 From cushon at openjdk.org Tue Dec 17 22:33:05 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 17 Dec 2024 22:33:05 GMT Subject: [jdk21u-dev] RFR: 8337795: Type annotation attached to incorrect type during class reading Message-ID: <2BCPA80dofBDxNg0jR_7Qm1_Y3MgtcC-iyxk7ENdJ9Q=.cd3d5da7-ec74-451b-9b58-6f110a6a0012@github.com> This is a backport of [JDK-8337795](https://bugs.openjdk.org/browse/JDK-8337795), which is a follow-up to [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377). ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1251 Commit messages: - Backport 8d0831478338e9b084b2c47f46eba9faae3a5eb6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1252/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1252&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337795 Stats: 109 lines in 2 files changed: 25 ins; 44 del; 40 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1252.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1252/head:pull/1252 PR: https://git.openjdk.org/jdk21u-dev/pull/1252 From cushon at openjdk.org Tue Dec 17 22:41:18 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 17 Dec 2024 22:41:18 GMT Subject: [jdk21u-dev] RFR: 8337998: CompletionFailure in getEnclosingType attaching type annotations Message-ID: This is a backport of [JDK-8337998](https://bugs.openjdk.org/browse/JDK-8337998), which is a follow-up to [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377). ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1252 Commit messages: - Backport 9e282e5c966a9c065de8b901b7d30bb5c9ccf243 Changes: https://git.openjdk.org/jdk21u-dev/pull/1253/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1253&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337998 Stats: 116 lines in 4 files changed: 113 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1253.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1253/head:pull/1253 PR: https://git.openjdk.org/jdk21u-dev/pull/1253 From duke at openjdk.org Wed Dec 18 04:06:35 2024 From: duke at openjdk.org (duke) Date: Wed, 18 Dec 2024 04:06:35 GMT Subject: [jdk21u-dev] RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform In-Reply-To: References: Message-ID: <_eanF1jaQOlUKApwfAjh-CfoueEUQUlmGB7IHbZGmes=.dc86df57-d10b-4b39-8016-cd4bfd3b9e36@github.com> On Tue, 26 Nov 2024 13:21:15 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8344275 : tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform > > Original patch does not apply cleanly because JDK-8340311 and JDK-8343314 are not applied to jdk21. > JDK-8340311 and JDK-8343314 are enhancement, so I don't backport them. > > Testing: tools/jpackage tests importing jdk.jpackage.test.Executor on Windows Server 2019 (Japanese and English locales) > > Thanks. @kurashige23 Your change (at version b15a92bf567afe92232334951eeb0d83eabe0302) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1182#issuecomment-2550280232 From mbalao at openjdk.org Wed Dec 18 05:54:45 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 18 Dec 2024 05:54:45 GMT Subject: [jdk23u] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: Message-ID: On Tue, 19 Nov 2024 02:19:31 GMT, Alexey Bakhtin wrote: > Please review the JAR tool enhancement. > It allows suppressing the overwriting of existing files with a new cmd line option. > The backport is almost clean except of src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java line 264 > OptionType.EXTRACT was defined by JDK-8173970 but not backported to JDK23 yet. > > All related JTREG tests passed Thanks @alexeybakhtin for contributing this backport. Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk23u/pull/227#pullrequestreview-2510865591 From syan at openjdk.org Wed Dec 18 07:03:51 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 18 Dec 2024 07:03:51 GMT Subject: [jdk21u-dev] RFR: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null' Message-ID: <6yCLNOM_MnH1C1IO4p8DslaX36Z15ky3Ae24G_Y_FOg=.0f00c09a-965c-4b5b-ba80-8c208b4853b7@github.com> Hi all, This pull request contains a backport of commit [ea50c54a](https://github.com/openjdk/jdk/commit/ea50c54a14d39fcedabe8426a14eaec27ab24af2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by David Holmes on 18 Dec 2024 and was reviewed by Leonid Mesnik and Hamlin Li. Thanks! ------------- Commit messages: - Backport ea50c54a14d39fcedabe8426a14eaec27ab24af2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1254/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1254&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321818 Stats: 53 lines in 9 files changed: 45 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1254.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1254/head:pull/1254 PR: https://git.openjdk.org/jdk21u-dev/pull/1254 From goetz at openjdk.org Wed Dec 18 07:11:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:11:48 GMT Subject: [jdk17u-dev] RFR: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main In-Reply-To: <9rtHiYVUMyD5P3Xh-VxH_sPs9VosC8Y6IOjNK7xgylQ=.4f3a8080-49d1-4bbe-ab84-c77378c185e0@github.com> References: <9rtHiYVUMyD5P3Xh-VxH_sPs9VosC8Y6IOjNK7xgylQ=.4f3a8080-49d1-4bbe-ab84-c77378c185e0@github.com> Message-ID: On Tue, 17 Dec 2024 14:02:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3134#issuecomment-2550526907 From goetz at openjdk.org Wed Dec 18 07:12:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:12:38 GMT Subject: [jdk21u-dev] RFR: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 14:02:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1248#issuecomment-2550527444 From goetz at openjdk.org Wed Dec 18 07:12:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:12:43 GMT Subject: [jdk17u-dev] RFR: 8328753: Open source few Undecorated Frame tests In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 13:18:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. GHA failure: three times well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3133#issuecomment-2550528298 From krk at openjdk.org Wed Dec 18 07:14:39 2024 From: krk at openjdk.org (Kerem Kat) Date: Wed, 18 Dec 2024 07:14:39 GMT Subject: [jdk17u-dev] Integrated: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 14:11:14 GMT, Kerem Kat wrote: > Ref. https://github.com/openjdk/jdk/pull/22479 > >> We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM > > Does not apply cleanly, the backport depends on `FloatRegister` changes from [JDK-8339063](https://bugs.openjdk.org/browse/JDK-8339063) which are included in `src/hotspot/cpu/aarch64/register_aarch64.hpp`. > > Additional testing: > > - [x] Verified the bug is fixed with the seccomp repro from [JDK-8345296](https://bugs.openjdk.org/browse/JDK-8345296?focusedId=14727386&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14727386): Segfault without the patch, works with. This pull request has now been integrated. Changeset: 3f1ba564 Author: Kerem Kat Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/3f1ba564642fd432d733d27756ec1e57d0f89655 Stats: 27 lines in 2 files changed: 23 ins; 3 del; 1 mod 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed Reviewed-by: shade Backport-of: 3c60f0b2bb75150d49da9ab94d88b767275de5e2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3111 From goetz at openjdk.org Wed Dec 18 07:14:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:14:40 GMT Subject: [jdk17u-dev] RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 09:33:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: download of mysys failed. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3130#issuecomment-2550531111 From goetz at openjdk.org Wed Dec 18 07:15:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:15:36 GMT Subject: [jdk17u-dev] RFR: 8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing In-Reply-To: <7lwxMKv86wFIh4LUvXw-wk1SjGL6LLlG8uxuqF2BNzo=.5d15d5a6-5e1b-4462-8e37-48830ebd8d61@github.com> References: <7lwxMKv86wFIh4LUvXw-wk1SjGL6LLlG8uxuqF2BNzo=.5d15d5a6-5e1b-4462-8e37-48830ebd8d61@github.com> Message-ID: <3WMYHEUWzTmnyZiGfOJYU2eITNzof3MiupzLZQQsWSg=.8a5843ea-5852-4175-9154-19b8f23330e4@github.com> On Tue, 17 Dec 2024 08:06:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3129#issuecomment-2550531714 From goetz at openjdk.org Wed Dec 18 07:15:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:15:41 GMT Subject: [jdk17u-dev] RFR: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 09:35:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. mac: Error: fatal: unable to access 'https://github.com/openjdk-bots/jdk17u-dev/': The requested URL returned error: 503 also unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3131#issuecomment-2550532609 From goetz at openjdk.org Wed Dec 18 07:52:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:52:25 GMT Subject: [jdk21u-dev] RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests Message-ID: I combine this with follow-up 8316627 JViewport Test headless failure. This are two clean backports. ------------- Commit messages: - Backport 8316627 JViewport Test headless failure - Backport a021dbcb9e58ab60abfc8c46ff25f3aa8ce3cc9f Changes: https://git.openjdk.org/jdk21u-dev/pull/1255/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1255&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316149 Stats: 370 lines in 5 files changed: 370 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1255.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1255/head:pull/1255 PR: https://git.openjdk.org/jdk21u-dev/pull/1255 From goetz at openjdk.org Wed Dec 18 07:52:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:52:50 GMT Subject: [jdk21u-dev] Withdrawn: 8316149: Open source several Swing JTree JViewport KeyboardManager tests In-Reply-To: <3X7l35wvp3fRyTuAWysPxz1EZe_lV5s26Umm-k2I7uw=.7b6b9b4b-6aa7-4d28-b54b-36cda5c69719@github.com> References: <3X7l35wvp3fRyTuAWysPxz1EZe_lV5s26Umm-k2I7uw=.7b6b9b4b-6aa7-4d28-b54b-36cda5c69719@github.com> Message-ID: On Tue, 17 Dec 2024 09:33:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1244 From goetz at openjdk.org Wed Dec 18 07:52:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 07:52:51 GMT Subject: [jdk17u-dev] Withdrawn: 8316149: Open source several Swing JTree JViewport KeyboardManager tests In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 09:33:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3130 From goetz at openjdk.org Wed Dec 18 08:17:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 08:17:08 GMT Subject: [jdk21u-dev] RFR: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build} Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 7bca0af481e2ab1d9576fdf400079b4e4ca91e89 Changes: https://git.openjdk.org/jdk21u-dev/pull/1256/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1256&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343128 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1256.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1256/head:pull/1256 PR: https://git.openjdk.org/jdk21u-dev/pull/1256 From goetz at openjdk.org Wed Dec 18 08:24:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 08:24:50 GMT Subject: [jdk17u-dev] RFR: 8328130: Remove applet usage from JColorChooser tests Test4759934 Message-ID: <4GTsE3W88K2fJXY1AfSKKrIuyyaRjYVkx-0bS_7yBb0=.f45d6a83-45ad-49e8-9f53-38d684ebbb8d@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b Changes: https://git.openjdk.org/jdk17u-dev/pull/3137/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3137&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328130 Stats: 112 lines in 2 files changed: 44 ins; 54 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3137.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3137/head:pull/3137 PR: https://git.openjdk.org/jdk17u-dev/pull/3137 From goetz at openjdk.org Wed Dec 18 08:26:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 08:26:18 GMT Subject: [jdk21u-dev] RFR: 8328130: Remove applet usage from JColorChooser tests Test4759934 Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b Changes: https://git.openjdk.org/jdk21u-dev/pull/1257/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1257&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328130 Stats: 112 lines in 2 files changed: 44 ins; 54 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1257.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1257/head:pull/1257 PR: https://git.openjdk.org/jdk21u-dev/pull/1257 From goetz at openjdk.org Wed Dec 18 09:02:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 09:02:09 GMT Subject: [jdk21u-dev] RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport cc5cda558736ffeae2a4611d87dfe280b9a4eac3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1258/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1258&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328005 Stats: 68 lines in 2 files changed: 11 ins; 32 del; 25 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1258.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1258/head:pull/1258 PR: https://git.openjdk.org/jdk21u-dev/pull/1258 From goetz at openjdk.org Wed Dec 18 09:02:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 09:02:16 GMT Subject: [jdk17u-dev] RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport cc5cda558736ffeae2a4611d87dfe280b9a4eac3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3138/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3138&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328005 Stats: 68 lines in 2 files changed: 11 ins; 32 del; 25 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3138.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3138/head:pull/3138 PR: https://git.openjdk.org/jdk17u-dev/pull/3138 From goetz at openjdk.org Wed Dec 18 09:16:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 09:16:09 GMT Subject: [jdk17u-dev] RFR: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java Message-ID: <8A18xjwk_e-r_koVD-DNMO8ymggglPZA5_C31xFKT7Y=.fe6d52fb-a4e9-4cc3-8695-b44f652269b0@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport fa502ecd2d1040ee2fe26d0ac5dd547379a0ade7 Changes: https://git.openjdk.org/jdk17u-dev/pull/3139/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3139&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339943 Stats: 74 lines in 1 file changed: 40 ins; 17 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3139.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3139/head:pull/3139 PR: https://git.openjdk.org/jdk17u-dev/pull/3139 From goetz at openjdk.org Wed Dec 18 09:16:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 09:16:45 GMT Subject: [jdk21u-dev] RFR: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport fa502ecd2d1040ee2fe26d0ac5dd547379a0ade7 Changes: https://git.openjdk.org/jdk21u-dev/pull/1259/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1259&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339943 Stats: 74 lines in 1 file changed: 40 ins; 17 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1259.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1259/head:pull/1259 PR: https://git.openjdk.org/jdk21u-dev/pull/1259 From syan at openjdk.org Wed Dec 18 09:34:37 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 18 Dec 2024 09:34:37 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. > > The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! Thanks all for the reviews. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2550826485 From goetz at openjdk.org Wed Dec 18 09:36:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 09:36:10 GMT Subject: [jdk21u-dev] RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 83e9e482b181e76ca9f645e8cc83cfa9337df498 Changes: https://git.openjdk.org/jdk21u-dev/pull/1260/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1260&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325937 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1260.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1260/head:pull/1260 PR: https://git.openjdk.org/jdk21u-dev/pull/1260 From goetz at openjdk.org Wed Dec 18 10:06:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 10:06:09 GMT Subject: [jdk17u-dev] RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 Message-ID: I backport this for parity with 17.0.15-oracle. It does not apply as 8292591: Experimentally add back barrier-less Java thread transitions is not in 17. Resolving this is obvious, the flag tested in the context in 21 is "false" by default. Thus adding the code unconditional is the obvious thing to do. I added one comment from 8292591 in execute(). This change duplicates this comment in doit(), so it's canonical to have it in execute(), too. ------------- Commit messages: - Backport 83e9e482b181e76ca9f645e8cc83cfa9337df498 Changes: https://git.openjdk.org/jdk17u-dev/pull/3140/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3140&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325937 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3140.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3140/head:pull/3140 PR: https://git.openjdk.org/jdk17u-dev/pull/3140 From goetz at openjdk.org Wed Dec 18 10:22:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 10:22:54 GMT Subject: [jdk17u-dev] RFR: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 7e87c071b0fd832473f17ec0f579df40bea62950 Changes: https://git.openjdk.org/jdk17u-dev/pull/3141/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3141&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340116 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3141.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3141/head:pull/3141 PR: https://git.openjdk.org/jdk17u-dev/pull/3141 From goetz at openjdk.org Wed Dec 18 10:23:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 10:23:16 GMT Subject: [jdk21u-dev] RFR: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 0853aee3b377cf9f17340a85f600651db42e6999 Changes: https://git.openjdk.org/jdk21u-dev/pull/1262/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1262&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338426 Stats: 15 lines in 1 file changed: 4 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1262.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1262/head:pull/1262 PR: https://git.openjdk.org/jdk21u-dev/pull/1262 From goetz at openjdk.org Wed Dec 18 10:23:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 10:23:56 GMT Subject: [jdk21u-dev] RFR: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 7e87c071b0fd832473f17ec0f579df40bea62950 Changes: https://git.openjdk.org/jdk21u-dev/pull/1261/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1261&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340116 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1261.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1261/head:pull/1261 PR: https://git.openjdk.org/jdk21u-dev/pull/1261 From goetz at openjdk.org Wed Dec 18 10:26:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 10:26:20 GMT Subject: [jdk17u-dev] RFR: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 0853aee3b377cf9f17340a85f600651db42e6999 Changes: https://git.openjdk.org/jdk17u-dev/pull/3142/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3142&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338426 Stats: 15 lines in 1 file changed: 4 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3142.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3142/head:pull/3142 PR: https://git.openjdk.org/jdk17u-dev/pull/3142 From goetz at openjdk.org Wed Dec 18 10:41:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 10:41:47 GMT Subject: [jdk21u-dev] RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport 342fe42555a0e892d21d187287ab996be199abb1 Changes: https://git.openjdk.org/jdk21u-dev/pull/1263/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1263&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342270 Stats: 33 lines in 2 files changed: 28 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1263.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1263/head:pull/1263 PR: https://git.openjdk.org/jdk21u-dev/pull/1263 From goetz at openjdk.org Wed Dec 18 11:04:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:04:45 GMT Subject: [jdk21u-dev] Integrated: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 09:34:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 57973b78 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/57973b788a8be3c62314a14133330995c70fa44a Stats: 174 lines in 1 file changed: 41 ins; 94 del; 39 mod 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main Backport-of: 4e83f4cfc779e39cca0070b5729a508aeaa74654 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1245 From goetz at openjdk.org Wed Dec 18 11:06:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:06:41 GMT Subject: [jdk21u-dev] Integrated: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 10:01:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 0a65f3c1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/0a65f3c198b74987f374c87fcbcb94c4c22f1de2 Stats: 298 lines in 3 files changed: 127 ins; 171 del; 0 mod 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main Backport-of: 476421efe574eca6ba92aaa7fc86dfca99fdd7b2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1246 From goetz at openjdk.org Wed Dec 18 11:07:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:07:42 GMT Subject: [jdk21u-dev] Integrated: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 14:02:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: c0336dd3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c0336dd33a46f5d3a3c2135cf39b419507446086 Stats: 86 lines in 3 files changed: 26 ins; 46 del; 14 mod 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main Backport-of: a1fbbffb5e0d7e41a9c3041b7e64382780e86f50 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1248 From goetz at openjdk.org Wed Dec 18 11:08:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:08:44 GMT Subject: [jdk17u-dev] Integrated: 8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing In-Reply-To: <7lwxMKv86wFIh4LUvXw-wk1SjGL6LLlG8uxuqF2BNzo=.5d15d5a6-5e1b-4462-8e37-48830ebd8d61@github.com> References: <7lwxMKv86wFIh4LUvXw-wk1SjGL6LLlG8uxuqF2BNzo=.5d15d5a6-5e1b-4462-8e37-48830ebd8d61@github.com> Message-ID: <9nQbY2xG31r4saYnRvQkbhgnd_ggWPc8tYorgfSayrw=.b7cc9ea6-f252-4c42-8fe7-b31c16a7e71c@github.com> On Tue, 17 Dec 2024 08:06:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 219afaf0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/219afaf0f73b1a2e1f9f0970521196f4c9dc41d2 Stats: 6 lines in 2 files changed: 2 ins; 0 del; 4 mod 8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing Backport-of: 69c0b24386d0bcf2f2d623ccef0192a54753f916 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3129 From goetz at openjdk.org Wed Dec 18 11:09:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:09:46 GMT Subject: [jdk21u-dev] Integrated: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main In-Reply-To: References: Message-ID: <4I2C7PQQAUCyiTd9BYVWqVWi8JZ5cW-TuFXybUmWgpE=.84f062e6-f24b-4b87-afe4-66816c691ea6@github.com> On Tue, 17 Dec 2024 14:03:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 1c53e8ca Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1c53e8cadf30d0de6bcdb7c043bd338f100e0fb7 Stats: 398 lines in 3 files changed: 93 ins; 305 del; 0 mod 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main Backport-of: db01fcd6d8c24b01a1f23c71b2917ff396b0686f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1249 From duke at openjdk.org Wed Dec 18 11:10:56 2024 From: duke at openjdk.org (duke) Date: Wed, 18 Dec 2024 11:10:56 GMT Subject: [jdk17u] Withdrawn: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 06:57:11 GMT, Martin Balao wrote: > Hi, > > Can I have a review for the backport of JDK-8263031 to 17u? > > The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved. > > In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing. > > No regressions observed in the jdk/java/net/httpclient tests category. > > Thanks, > Martin.- This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u/pull/400 From goetz at openjdk.org Wed Dec 18 11:12:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:12:40 GMT Subject: [jdk17u-dev] Integrated: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 09:35:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 7d8dd1bf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7d8dd1bfd424b4835b96138b53e0a3cfa751d747 Stats: 174 lines in 1 file changed: 41 ins; 94 del; 39 mod 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main Backport-of: 4e83f4cfc779e39cca0070b5729a508aeaa74654 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3131 From goetz at openjdk.org Wed Dec 18 11:14:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:14:43 GMT Subject: [jdk17u-dev] Integrated: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 10:01:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: bf9edfb5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/bf9edfb5ca6e5069b7047b6306e0062da63a1161 Stats: 298 lines in 3 files changed: 127 ins; 171 del; 0 mod 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main Backport-of: 476421efe574eca6ba92aaa7fc86dfca99fdd7b2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3132 From goetz at openjdk.org Wed Dec 18 11:15:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:15:43 GMT Subject: [jdk17u-dev] Integrated: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main In-Reply-To: <9rtHiYVUMyD5P3Xh-VxH_sPs9VosC8Y6IOjNK7xgylQ=.4f3a8080-49d1-4bbe-ab84-c77378c185e0@github.com> References: <9rtHiYVUMyD5P3Xh-VxH_sPs9VosC8Y6IOjNK7xgylQ=.4f3a8080-49d1-4bbe-ab84-c77378c185e0@github.com> Message-ID: On Tue, 17 Dec 2024 14:02:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 46be5d57 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/46be5d57836598b8e063db04749d79b1d7360e48 Stats: 86 lines in 3 files changed: 26 ins; 46 del; 14 mod 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main Backport-of: a1fbbffb5e0d7e41a9c3041b7e64382780e86f50 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3134 From goetz at openjdk.org Wed Dec 18 11:16:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:16:50 GMT Subject: [jdk17u-dev] Integrated: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main In-Reply-To: <8jR-DeEekUe4FnfPAIj7zsBP3BQHGpTh5kelZsCLvXg=.0ea2d31b-50ab-490d-b863-35fe308f4cc4@github.com> References: <8jR-DeEekUe4FnfPAIj7zsBP3BQHGpTh5kelZsCLvXg=.0ea2d31b-50ab-490d-b863-35fe308f4cc4@github.com> Message-ID: On Tue, 17 Dec 2024 14:04:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 816822a8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/816822a862ab2659ebbe500c9cb472ee939481a1 Stats: 398 lines in 3 files changed: 93 ins; 305 del; 0 mod 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main Backport-of: db01fcd6d8c24b01a1f23c71b2917ff396b0686f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3135 From goetz at openjdk.org Wed Dec 18 11:18:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:18:42 GMT Subject: [jdk17u-dev] Integrated: 8328753: Open source few Undecorated Frame tests In-Reply-To: References: Message-ID: On Tue, 17 Dec 2024 13:18:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.14-oracle. This pull request has now been integrated. Changeset: cdf62864 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/cdf62864a7991a973a5108b8941f59ec1d6ca0ba Stats: 350 lines in 3 files changed: 350 ins; 0 del; 0 mod 8328753: Open source few Undecorated Frame tests 8337886: java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight color difference Backport-of: 539990cd9a7241e7e9d8f5dc1fdf832eb0fa7860 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3133 From goetz at openjdk.org Wed Dec 18 11:22:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:22:10 GMT Subject: [jdk17u-dev] RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree Message-ID: <2Kgx0Eliml03vpgh15_Wg_w4pAXPxgAu-7btS9HEsU4=.fafcb263-b594-4e8b-aeda-3378b132d561@github.com> I backport this for parity with 17.0.15-oracle Resolved imports in PKCS11Test, probably clean. ------------- Commit messages: - Backport 342fe42555a0e892d21d187287ab996be199abb1 Changes: https://git.openjdk.org/jdk17u-dev/pull/3143/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3143&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342270 Stats: 33 lines in 2 files changed: 28 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3143.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3143/head:pull/3143 PR: https://git.openjdk.org/jdk17u-dev/pull/3143 From goetz at openjdk.org Wed Dec 18 11:34:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 11:34:08 GMT Subject: [jdk17u-dev] RFR: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 1b0281dc77f41fc5df323c7f7b25a4138b1ffb9e Changes: https://git.openjdk.org/jdk17u-dev/pull/3144/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3144&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333427 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3144.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3144/head:pull/3144 PR: https://git.openjdk.org/jdk17u-dev/pull/3144 From goetz at openjdk.org Wed Dec 18 12:31:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 12:31:50 GMT Subject: [jdk21u-dev] RFR: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 52c0b09b62ca82f7e0cbe910cb92243131f06765 Changes: https://git.openjdk.org/jdk21u-dev/pull/1264/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1264&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277240 Stats: 82 lines in 1 file changed: 47 ins; 16 del; 19 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1264.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1264/head:pull/1264 PR: https://git.openjdk.org/jdk21u-dev/pull/1264 From goetz at openjdk.org Wed Dec 18 12:32:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 12:32:24 GMT Subject: [jdk17u-dev] RFR: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 52c0b09b62ca82f7e0cbe910cb92243131f06765 Changes: https://git.openjdk.org/jdk17u-dev/pull/3145/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3145&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277240 Stats: 82 lines in 1 file changed: 47 ins; 16 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3145.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3145/head:pull/3145 PR: https://git.openjdk.org/jdk17u-dev/pull/3145 From mbaesken at openjdk.org Wed Dec 18 12:35:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 18 Dec 2024 12:35:37 GMT Subject: [jdk21u-dev] RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 07:47:04 GMT, Goetz Lindenmaier wrote: > I combine this with follow-up 8316627 JViewport Test headless failure. > > This are two clean backports. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1255#pullrequestreview-2511699367 From goetz at openjdk.org Wed Dec 18 12:39:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 12:39:55 GMT Subject: [jdk17u-dev] RFR: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 Message-ID: I backport this for parity with 17.0.15-oracle. I had to resolve because "8308310:` HttpClient: Avoid logging or locking from within synchronized blocks" is not in 17. ------------- Commit messages: - Backport 59ffac84d39250623b0e6bcb871b5b3fe9c9cfe6 Changes: https://git.openjdk.org/jdk17u-dev/pull/3146/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3146&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342811 Stats: 21 lines in 1 file changed: 15 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3146.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3146/head:pull/3146 PR: https://git.openjdk.org/jdk17u-dev/pull/3146 From goetz at openjdk.org Wed Dec 18 12:41:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 12:41:57 GMT Subject: [jdk21u-dev] RFR: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 59ffac84d39250623b0e6bcb871b5b3fe9c9cfe6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1265/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1265&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342811 Stats: 21 lines in 1 file changed: 15 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1265.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1265/head:pull/1265 PR: https://git.openjdk.org/jdk21u-dev/pull/1265 From goetz at openjdk.org Wed Dec 18 13:34:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 13:34:01 GMT Subject: [jdk17u-dev] RFR: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS Message-ID: I backport this for parity with 17.0.15-oracle ------------- Commit messages: - Backport bb7a8403ba1b32b2d97c0bd3ec78dac1832f5289 Changes: https://git.openjdk.org/jdk17u-dev/pull/3147/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3147&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342541 Stats: 29 lines in 1 file changed: 11 ins; 17 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3147.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3147/head:pull/3147 PR: https://git.openjdk.org/jdk17u-dev/pull/3147 From goetz at openjdk.org Wed Dec 18 13:34:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 13:34:58 GMT Subject: [jdk21u-dev] RFR: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS Message-ID: <8mie12fY7sJ-UrYiyjai2Qg0dWUCQOY_QjR3YcEg6So=.393dbc6b-5c6d-4cf6-824c-1450d51b1e4b@github.com> I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport bb7a8403ba1b32b2d97c0bd3ec78dac1832f5289 Changes: https://git.openjdk.org/jdk21u-dev/pull/1266/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1266&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342541 Stats: 29 lines in 1 file changed: 11 ins; 17 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1266.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1266/head:pull/1266 PR: https://git.openjdk.org/jdk21u-dev/pull/1266 From goetz at openjdk.org Wed Dec 18 13:39:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 13:39:00 GMT Subject: [jdk17u-dev] RFR: 8344646: The libjsig deprecation warning should go to stderr not stdout Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport efeacfee015d1105dcd75e489d367a7716441fa8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3148/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3148&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344646 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3148.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3148/head:pull/3148 PR: https://git.openjdk.org/jdk17u-dev/pull/3148 From goetz at openjdk.org Wed Dec 18 13:40:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 18 Dec 2024 13:40:09 GMT Subject: [jdk21u-dev] RFR: 8344646: The libjsig deprecation warning should go to stderr not stdout Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport efeacfee015d1105dcd75e489d367a7716441fa8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1267/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1267&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344646 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1267.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1267/head:pull/1267 PR: https://git.openjdk.org/jdk21u-dev/pull/1267 From abakhtin at openjdk.org Wed Dec 18 14:47:41 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 18 Dec 2024 14:47:41 GMT Subject: [jdk23u] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: References: <5Fsd63CNusFWqb5KS4kRYDlcTG1ltBr6iU3ZX5Eg1iY=.12ee37e8-2ba9-4f9c-ab7d-24e32bedce6b@github.com> Message-ID: On Fri, 6 Dec 2024 23:15:51 GMT, Alexey Bakhtin wrote: >> Marked as reviewed by henryjen (Committer). > > @slowhog, Thank you for review. > Can anybody with reviewer status look at this PR in addition please? > Thanks @alexeybakhtin for contributing this backport. Looks good to me. Thank you for the review ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/227#issuecomment-2551503335 From shade at openjdk.org Wed Dec 18 16:02:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Dec 2024 16:02:09 GMT Subject: [jdk21u-dev] RFR: 8311546: Certificate name constraints improperly validated with leading period Message-ID: Backporting this due to wider customer interest in aligning JDK behavior with other SSL implementations. Both patches apply cleanly. First patch does the fix. Second patch fixes the test. Additional testing: - [x] macos-aarch64-server-release, new test passes with and without the change - [x] macos-aarch64-server-release, `sun/security/x509/` - [ ] linux-x86_64-server-release, `jdk_security` ------------- Commit messages: - Backport a2c0fa6f9ccefd3d1b088c51d0b8170cfb59a885 - Backport bfaf5704e7e71f968b716b5f448860e9cda721b4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1268/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1268&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311546 Stats: 308 lines in 8 files changed: 299 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1268.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1268/head:pull/1268 PR: https://git.openjdk.org/jdk21u-dev/pull/1268 From duke at openjdk.org Wed Dec 18 16:55:39 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 18 Dec 2024 16:55:39 GMT Subject: [jdk21u-dev] Integrated: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform In-Reply-To: References: Message-ID: <3RY1tUDZO4VyAT7mPWU6RCysUtRy5rvvVwwEsID8sbE=.af103994-3b47-4e57-8f5c-4976df576c5d@github.com> On Tue, 26 Nov 2024 13:21:15 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8344275 : tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform > > Original patch does not apply cleanly because JDK-8340311 and JDK-8343314 are not applied to jdk21. > JDK-8340311 and JDK-8343314 are enhancement, so I don't backport them. > > Testing: tools/jpackage tests importing jdk.jpackage.test.Executor on Windows Server 2019 (Japanese and English locales) > > Thanks. This pull request has now been integrated. Changeset: 227c430b Author: Taizo Kurashige <103394724+kurashige23 at users.noreply.github.com> Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/227c430b55e7f9a4257b9249881c8ec75574895c Stats: 34 lines in 2 files changed: 27 ins; 0 del; 7 mod 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform Reviewed-by: asemenyuk, phh Backport-of: 48e3b6511adf3d4e97035014612674d84ae83aa0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1182 From duke at openjdk.org Wed Dec 18 16:57:41 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 18 Dec 2024 16:57:41 GMT Subject: [jdk21u-dev] Integrated: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 15:54:47 GMT, Antonio Vieiro wrote: > A clean backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. > > The fix doesn't affect directly to SA tests in `21`, but it's being backported to `11` as this is the cause of [an older version of `serviceability/sa/ClhsdbFindPC.java` failing in JDK 11 on macos-13 GHA runners](https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579). > > Tests in 21 continue to pass in all platforms, including `macos`. This pull request has now been integrated. Changeset: eaa475f7 Author: Antonio Vieiro Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/eaa475f72ced51cf0f0d0bce9ff1265bfb81ab31 Stats: 17 lines in 2 files changed: 5 ins; 0 del; 12 mod 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x Backport-of: 269852b90634aa43d4d719c93563608e42792fc6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1227 From shade at openjdk.org Wed Dec 18 17:02:27 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Dec 2024 17:02:27 GMT Subject: [jdk17u-dev] RFR: 8311546: Certificate name constraints improperly validated with leading period Message-ID: Backporting this due to wider customer interest in aligning JDK behavior with other SSL implementations. Both patches apply cleanly. First patch does the fix. Second patch fixes the test. Additional testing: - [x] macos-aarch64-server-release, new test passes with and without the change - [x] macos-aarch64-server-release, `sun/security/x509/` - [ ] linux-x86_64-server-release, `jdk_security` ------------- Commit messages: - Backport a2c0fa6f9ccefd3d1b088c51d0b8170cfb59a885 - Backport bfaf5704e7e71f968b716b5f448860e9cda721b4 Changes: https://git.openjdk.org/jdk17u-dev/pull/3149/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3149&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311546 Stats: 308 lines in 8 files changed: 299 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3149.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3149/head:pull/3149 PR: https://git.openjdk.org/jdk17u-dev/pull/3149 From duke at openjdk.org Wed Dec 18 17:08:45 2024 From: duke at openjdk.org (duke) Date: Wed, 18 Dec 2024 17:08:45 GMT Subject: [jdk21u-dev] Withdrawn: 8339341: SurfaceManager cacheMap retains strong references In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 15:46:49 GMT, Nikita Gubarkov wrote: > Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache (and hence GraphicsConfig) from being detected as weakly reachable. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1077 From shade at openjdk.org Wed Dec 18 17:08:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Dec 2024 17:08:43 GMT Subject: [jdk21u-dev] RFR: 8342704: GHA: Report truncation is broken after JDK-8341424 In-Reply-To: References: Message-ID: On Fri, 22 Nov 2024 12:29:45 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects `hs_errs` when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to `17` and `11` too. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. This looks fine, thanks. I found it a bit inconvenient to title this PR as "JDK-8342704: GHA: Report truncation is broken after JDK-8341424", and not as "JDK-8341424): GHA: Collect hs_errs from build time failures", but this is a technicality that does not affect much. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1175#pullrequestreview-2512411977 From shade at openjdk.org Wed Dec 18 17:21:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Dec 2024 17:21:44 GMT Subject: [jdk17u-dev] RFR: 8311546: Certificate name constraints improperly validated with leading period In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 16:55:53 GMT, Aleksey Shipilev wrote: > Backporting this due to wider customer interest in aligning JDK behavior with other SSL implementations. Both patches apply cleanly. First patch does the fix. Second patch fixes the test. > > Additional testing: > - [x] macos-aarch64-server-release, new test passes with and without the change > - [x] macos-aarch64-server-release, `sun/security/x509/` > - [x] linux-x86_64-server-release, `jdk_security` Both backports are actually clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3149#issuecomment-2551878466 From shade at openjdk.org Wed Dec 18 17:21:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Dec 2024 17:21:44 GMT Subject: [jdk21u-dev] RFR: 8311546: Certificate name constraints improperly validated with leading period In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 15:56:26 GMT, Aleksey Shipilev wrote: > Backporting this due to wider customer interest in aligning JDK behavior with other SSL implementations. Both patches apply cleanly. First patch does the fix. Second patch fixes the test. > > Additional testing: > - [x] macos-aarch64-server-release, new test passes with and without the change > - [x] macos-aarch64-server-release, `sun/security/x509/` > - [x] linux-x86_64-server-release, `jdk_security` Both backports are actually clean. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1268#issuecomment-2551878583 From shade at openjdk.org Wed Dec 18 17:24:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Dec 2024 17:24:39 GMT Subject: [jdk21u-dev] RFR: 8311546: Certificate name constraints improperly validated with leading period In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 17:19:11 GMT, Aleksey Shipilev wrote: >> Backporting this due to wider customer interest in aligning JDK behavior with other SSL implementations. Both patches apply cleanly. First patch does the fix. Second patch fixes the test. >> >> Additional testing: >> - [x] macos-aarch64-server-release, new test passes with and without the change >> - [x] macos-aarch64-server-release, `sun/security/x509/` >> - [x] linux-x86_64-server-release, `jdk_security` > > Both backports are actually clean. > @shipilev The `/clean` pull request command is not enabled for this repository :( Ok, then I need some reviews, please. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1268#issuecomment-2551884181 From shade at openjdk.org Wed Dec 18 17:24:45 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 18 Dec 2024 17:24:45 GMT Subject: [jdk17u-dev] RFR: 8311546: Certificate name constraints improperly validated with leading period In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 17:19:07 GMT, Aleksey Shipilev wrote: >> Backporting this due to wider customer interest in aligning JDK behavior with other SSL implementations. Both patches apply cleanly. First patch does the fix. Second patch fixes the test. >> >> Additional testing: >> - [x] macos-aarch64-server-release, new test passes with and without the change >> - [x] macos-aarch64-server-release, `sun/security/x509/` >> - [x] linux-x86_64-server-release, `jdk_security` > > Both backports are actually clean. > @shipilev The `/clean` pull request command is not enabled for this repository :( Ok, then I need some reviews, please. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3149#issuecomment-2551884407 From mdoerr at openjdk.org Wed Dec 18 17:39:37 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 18 Dec 2024 17:39:37 GMT Subject: [jdk21u-dev] RFR: 8339475: Clean up return code handling for pthread calls in library coding In-Reply-To: References: Message-ID: <2hqfkE9076DUgHJqeCfjF6EjRWBLGEvvxbbCEa0mnGc=.042dc8a1-9977-47c7-8caa-6ec67e3f767d@github.com> On Tue, 17 Dec 2024 13:22:48 GMT, Matthias Baesken wrote: > Backport of 8339475 + follow up 8341135 LGTM. splashscreen_sys.c contains a small part of https://github.com/openjdk/jdk/commit/8ea6adc623ca2183046d794eba806065deea916e which looks ok. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1247#pullrequestreview-2512475250 From duke at openjdk.org Wed Dec 18 20:13:57 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 18 Dec 2024 20:13:57 GMT Subject: [jdk17u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x Message-ID: <_dzf8eGIGxy4YUK0Bnhomo7baShodLmr15SGtdCRSpQ=.c764df9c-95b4-4743-b04d-dc39afea45a2@github.com> A clean backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded. The fix doesn't affect directly to SA tests in 17, but it's being backported to 11 as this is the cause of https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579. Tests in 17 continue to pass in all platforms, including macos. ------------- Commit messages: - Backport eaa475f72ced51cf0f0d0bce9ff1265bfb81ab31 Changes: https://git.openjdk.org/jdk17u-dev/pull/3150/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3150&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294316 Stats: 17 lines in 2 files changed: 5 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3150.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3150/head:pull/3150 PR: https://git.openjdk.org/jdk17u-dev/pull/3150 From duke at openjdk.org Wed Dec 18 20:17:36 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 18 Dec 2024 20:17:36 GMT Subject: [jdk21u-dev] RFR: 8342704: GHA: Report truncation is broken after JDK-8341424 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 17:06:07 GMT, Aleksey Shipilev wrote: >> Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) >> >> This collects `hs_errs` when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to `17` and `11` too. >> >> Low risk, as this affects GHA actions only. GHA builds and tests run correctly. > > This looks fine, thanks. > > I found it a bit inconvenient to title this PR as "JDK-8342704: GHA: Report truncation is broken after JDK-8341424", and not as "JDK-8341424): GHA: Collect hs_errs from build time failures", but this is a technicality that does not affect much. @shipilev Thank **you**! Yep, I thought of changing the title, too, but then I forgot. I'll try to do that in 17u. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1175#issuecomment-2552185917 From goetz at openjdk.org Thu Dec 19 07:56:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:56:44 GMT Subject: [jdk21u-dev] RFR: 8344646: The libjsig deprecation warning should go to stderr not stdout In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 13:33:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1267#issuecomment-2553001721 From goetz at openjdk.org Thu Dec 19 07:57:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:57:37 GMT Subject: [jdk17u-dev] RFR: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 13:29:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle GHA failure: twice well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3147#issuecomment-2553002530 From goetz at openjdk.org Thu Dec 19 07:57:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:57:48 GMT Subject: [jdk17u-dev] RFR: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 12:35:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I had to resolve because "8308310:` HttpClient: Avoid logging or locking from within synchronized blocks" is not in 17. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3146#issuecomment-2553003021 From goetz at openjdk.org Thu Dec 19 07:58:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:58:41 GMT Subject: [jdk17u-dev] RFR: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:17:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3141#issuecomment-2553004662 From goetz at openjdk.org Thu Dec 19 07:58:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:58:50 GMT Subject: [jdk21u-dev] RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:36:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1263#issuecomment-2553004271 From goetz at openjdk.org Thu Dec 19 07:58:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:58:47 GMT Subject: [jdk21u-dev] RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 09:30:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1260#issuecomment-2553005104 From goetz at openjdk.org Thu Dec 19 07:59:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:59:43 GMT Subject: [jdk21u-dev] RFR: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 09:11:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1259#issuecomment-2553006693 From goetz at openjdk.org Thu Dec 19 07:59:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 07:59:48 GMT Subject: [jdk17u-dev] RFR: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java In-Reply-To: <8A18xjwk_e-r_koVD-DNMO8ymggglPZA5_C31xFKT7Y=.fe6d52fb-a4e9-4cc3-8695-b44f652269b0@github.com> References: <8A18xjwk_e-r_koVD-DNMO8ymggglPZA5_C31xFKT7Y=.fe6d52fb-a4e9-4cc3-8695-b44f652269b0@github.com> Message-ID: On Wed, 18 Dec 2024 09:12:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3139#issuecomment-2553006293 From goetz at openjdk.org Thu Dec 19 08:01:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 08:01:44 GMT Subject: [jdk21u-dev] RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 07:47:04 GMT, Goetz Lindenmaier wrote: > I combine this with follow-up 8316627 JViewport Test headless failure. > > This are two clean backports. Thanks for the review! GHA failure: twice well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1255#issuecomment-2553007546 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1255#issuecomment-2553008488 From goetz at openjdk.org Thu Dec 19 08:03:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 08:03:46 GMT Subject: [jdk21u-dev] RFR: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed In-Reply-To: References: Message-ID: <8f-EJOB98c5HHbXtpDk3BS5IhI9HgOOD2VspOMhZR2g=.7a2560ad-1598-4d17-b71e-5e47929af3eb@github.com> On Wed, 18 Dec 2024 12:27:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: build failed due to connection issues. Unrelated ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1264#issuecomment-2553012370 From mbaesken at openjdk.org Thu Dec 19 08:42:35 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 19 Dec 2024 08:42:35 GMT Subject: [jdk21u-dev] RFR: 8339475: Clean up return code handling for pthread calls in library coding In-Reply-To: References: Message-ID: <_ydRzjJ0D6mvHZY9Kpz3pkYLDB00aDQunmDuYfMWDiE=.a8f3be34-06d4-4870-81e9-007f1c51f733@github.com> On Tue, 17 Dec 2024 13:22:48 GMT, Matthias Baesken wrote: > Backport of 8339475 + follow up 8341135 macosx-x64 GHA failure is some download issue, unrelated to my change . Hi Martin, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1247#issuecomment-2553084979 From goetz at openjdk.org Thu Dec 19 09:41:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 09:41:01 GMT Subject: [jdk17u-dev] RFR: 8315952: Open source several Swing JToolbar JTooltip JTree tests Message-ID: I backport this for parity with 17.0.15-oracle ------------- Commit messages: - Backport d2b2f6759f7b9eb6df8eaa84b88e064c636b24a8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3151/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3151&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315952 Stats: 262 lines in 5 files changed: 262 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3151.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3151/head:pull/3151 PR: https://git.openjdk.org/jdk17u-dev/pull/3151 From goetz at openjdk.org Thu Dec 19 09:41:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 09:41:19 GMT Subject: [jdk21u-dev] RFR: 8315952: Open source several Swing JToolbar JTooltip JTree tests Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport d2b2f6759f7b9eb6df8eaa84b88e064c636b24a8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1270/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1270&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315952 Stats: 262 lines in 5 files changed: 262 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1270.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1270/head:pull/1270 PR: https://git.openjdk.org/jdk21u-dev/pull/1270 From duke at openjdk.org Thu Dec 19 09:47:38 2024 From: duke at openjdk.org (duke) Date: Thu, 19 Dec 2024 09:47:38 GMT Subject: [jdk21u-dev] RFR: 8341424: GHA: Collect hs_errs from build time failures In-Reply-To: References: Message-ID: On Fri, 22 Nov 2024 12:29:45 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects `hs_errs` when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to `17` and `11` too. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. @vieiro Your change (at version 9039c4d63a4ce07d4de2614957b9bda72cf101ae) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1175#issuecomment-2553228521 From rrich at openjdk.org Thu Dec 19 09:55:40 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 19 Dec 2024 09:55:40 GMT Subject: [jdk17u-dev] RFR: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 12:35:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I had to resolve because "8308310:` HttpClient: Avoid logging or locking from within synchronized blocks" is not in 17. Looks good. Cheers, Richard. ------------- Marked as reviewed by rrich (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3146#pullrequestreview-2513927205 From clanger at openjdk.org Thu Dec 19 09:56:37 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 19 Dec 2024 09:56:37 GMT Subject: [jdk21u-dev] RFR: 8339475: Clean up return code handling for pthread calls in library coding In-Reply-To: <_ydRzjJ0D6mvHZY9Kpz3pkYLDB00aDQunmDuYfMWDiE=.a8f3be34-06d4-4870-81e9-007f1c51f733@github.com> References: <_ydRzjJ0D6mvHZY9Kpz3pkYLDB00aDQunmDuYfMWDiE=.a8f3be34-06d4-4870-81e9-007f1c51f733@github.com> Message-ID: On Thu, 19 Dec 2024 08:39:31 GMT, Matthias Baesken wrote: >> Backport of 8339475 + follow up 8341135 > > macosx-x64 GHA failure is some download issue, unrelated to my change . > > Hi Martin, thanks for the review ! @MBaesken, please add 8341135 via /issue add and also request maintanier approval there. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1247#issuecomment-2553280053 From duke at openjdk.org Thu Dec 19 11:08:46 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 19 Dec 2024 11:08:46 GMT Subject: [jdk21u-dev] Integrated: 8341424: GHA: Collect hs_errs from build time failures In-Reply-To: References: Message-ID: On Fri, 22 Nov 2024 12:29:45 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects `hs_errs` when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to `17` and `11` too. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. This pull request has now been integrated. Changeset: 0011704e Author: Antonio Vieiro Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/0011704ec813414bfe71d7232882a1d03c362b48 Stats: 81 lines in 3 files changed: 67 ins; 14 del; 0 mod 8341424: GHA: Collect hs_errs from build time failures 8342704: GHA: Report truncation is broken after JDK-8341424 Reviewed-by: shade Backport-of: bf92c498391b099b67c313703e48374cade76f87 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1175 From duke at openjdk.org Thu Dec 19 12:08:34 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Thu, 19 Dec 2024 12:08:34 GMT Subject: [jdk17u-dev] RFR: 8341424: GHA: Collect hs_errs from build time failures Message-ID: Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to 17 and 11 too. Low risk, as this affects GHA actions only. GHA builds and tests run correctly. ------------- Commit messages: - Backport 0011704ec813414bfe71d7232882a1d03c362b48 Changes: https://git.openjdk.org/jdk17u-dev/pull/3152/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3152&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341424 Stats: 81 lines in 3 files changed: 67 ins; 14 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3152.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3152/head:pull/3152 PR: https://git.openjdk.org/jdk17u-dev/pull/3152 From duke at openjdk.org Thu Dec 19 12:26:23 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 19 Dec 2024 12:26:23 GMT Subject: [jdk21u-dev] RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ Message-ID: apply clean. ------------- Commit messages: - Backport 78a8a99d990dcc0b77c096bb2ca2c1bb86462e3f Changes: https://git.openjdk.org/jdk21u-dev/pull/1271/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1271&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312488 Stats: 10 lines in 1 file changed: 5 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1271.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1271/head:pull/1271 PR: https://git.openjdk.org/jdk21u-dev/pull/1271 From goetz at openjdk.org Thu Dec 19 12:46:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:46:52 GMT Subject: [jdk21u-dev] Integrated: 8316149: Open source several Swing JTree JViewport KeyboardManager tests In-Reply-To: References: Message-ID: <_hmOVtS9_vNo07gm2_ZewOmN0syXmtEPgjYGHCLSuu4=.648fdd4f-24fa-4316-8408-51c2489f96a2@github.com> On Wed, 18 Dec 2024 07:47:04 GMT, Goetz Lindenmaier wrote: > I combine this with follow-up 8316627 JViewport Test headless failure. > > This are two clean backports. This pull request has now been integrated. Changeset: c89fc273 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c89fc273a893e2c981f7c07cc05ba81125816f2f Stats: 370 lines in 5 files changed: 370 ins; 0 del; 0 mod 8316149: Open source several Swing JTree JViewport KeyboardManager tests 8316627: JViewport Test headless failure Reviewed-by: mbaesken Backport-of: a021dbcb9e58ab60abfc8c46ff25f3aa8ce3cc9f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1255 From goetz at openjdk.org Thu Dec 19 12:47:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:47:46 GMT Subject: [jdk21u-dev] Integrated: 8328130: Remove applet usage from JColorChooser tests Test4759934 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 08:20:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 4ab8e84e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/4ab8e84e58743e7ee56427cf4c3a126427e54ff7 Stats: 112 lines in 2 files changed: 44 ins; 54 del; 14 mod 8328130: Remove applet usage from JColorChooser tests Test4759934 Backport-of: be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1257 From goetz at openjdk.org Thu Dec 19 12:48:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:48:15 GMT Subject: [jdk17u-dev] RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests Message-ID: This will be a clean backport from 21 once I pushed that change and adapted the title to point to the hash in 21. ------------- Commit messages: - Backport 8316149+8316627 from 21 Changes: https://git.openjdk.org/jdk17u-dev/pull/3136/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3136&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316149 Stats: 370 lines in 5 files changed: 370 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3136.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3136/head:pull/3136 PR: https://git.openjdk.org/jdk17u-dev/pull/3136 From goetz at openjdk.org Thu Dec 19 12:49:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:49:39 GMT Subject: [jdk21u-dev] Integrated: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 08:56:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: f70b4f37 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/f70b4f3734c82621ff4045c71c0d4015e63ca10f Stats: 68 lines in 2 files changed: 11 ins; 32 del; 25 mod 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main Backport-of: cc5cda558736ffeae2a4611d87dfe280b9a4eac3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1258 From goetz at openjdk.org Thu Dec 19 12:50:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:50:44 GMT Subject: [jdk21u-dev] Integrated: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 09:11:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 09295265 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/09295265f8c2f8538552de68b53e0bd46bfa527a Stats: 74 lines in 1 file changed: 40 ins; 17 del; 17 mod 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java Backport-of: fa502ecd2d1040ee2fe26d0ac5dd547379a0ade7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1259 From goetz at openjdk.org Thu Dec 19 12:52:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:52:46 GMT Subject: [jdk21u-dev] Integrated: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 In-Reply-To: References: Message-ID: <_id8dv5rbn84SYQNb22qtWRoCyI8Cr8LamguWwgPFYQ=.c511a25c-260b-4e7c-a5de-b8ce7b90a9a4@github.com> On Wed, 18 Dec 2024 09:30:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: e5433159 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e5433159d82fca3747d26bf251ac411c31da13a2 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 Backport-of: 83e9e482b181e76ca9f645e8cc83cfa9337df498 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1260 From goetz at openjdk.org Thu Dec 19 12:53:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:53:47 GMT Subject: [jdk17u-dev] Integrated: 8328130: Remove applet usage from JColorChooser tests Test4759934 In-Reply-To: <4GTsE3W88K2fJXY1AfSKKrIuyyaRjYVkx-0bS_7yBb0=.f45d6a83-45ad-49e8-9f53-38d684ebbb8d@github.com> References: <4GTsE3W88K2fJXY1AfSKKrIuyyaRjYVkx-0bS_7yBb0=.f45d6a83-45ad-49e8-9f53-38d684ebbb8d@github.com> Message-ID: On Wed, 18 Dec 2024 08:20:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: e5c6eb07 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e5c6eb07f5dc10df61cd13b3afd7cf7a569dd624 Stats: 112 lines in 2 files changed: 44 ins; 54 del; 14 mod 8328130: Remove applet usage from JColorChooser tests Test4759934 Backport-of: be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3137 From goetz at openjdk.org Thu Dec 19 12:54:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:54:51 GMT Subject: [jdk21u-dev] Integrated: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:18:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 42d3509d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/42d3509d1234b4a47dba352218e2ae437bc1226d Stats: 15 lines in 1 file changed: 4 ins; 2 del; 9 mod 8338426: Test java/nio/channels/Selector/WakeupNow.java failed Backport-of: 0853aee3b377cf9f17340a85f600651db42e6999 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1262 From goetz at openjdk.org Thu Dec 19 12:55:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:55:40 GMT Subject: [jdk21u-dev] Integrated: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex In-Reply-To: References: Message-ID: <76TnI5tTkhFe90pt3cVqKTwKHUHQkYSxCwtB-qh28HQ=.867bb8ab-3ef8-4509-8d6e-aedb0843f41e@github.com> On Wed, 18 Dec 2024 10:17:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 9f06e332 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/9f06e332e54132992c6333dd791857ad51aba00b Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex Backport-of: 7e87c071b0fd832473f17ec0f579df40bea62950 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1261 From goetz at openjdk.org Thu Dec 19 12:55:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:55:47 GMT Subject: [jdk17u-dev] Integrated: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main In-Reply-To: References: Message-ID: <55zdNOqvUi7Mg5oFDETmucR5OgQrfELEYx8cZLaO0_c=.4cc745e9-c335-4f33-ae94-1fb05e7534d4@github.com> On Wed, 18 Dec 2024 08:56:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 26cb49f2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/26cb49f24ae888f8906d5561538bc2cc00a0b32a Stats: 68 lines in 2 files changed: 11 ins; 32 del; 25 mod 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main Backport-of: cc5cda558736ffeae2a4611d87dfe280b9a4eac3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3138 From goetz at openjdk.org Thu Dec 19 12:56:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:56:40 GMT Subject: [jdk17u-dev] Integrated: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java In-Reply-To: <8A18xjwk_e-r_koVD-DNMO8ymggglPZA5_C31xFKT7Y=.fe6d52fb-a4e9-4cc3-8695-b44f652269b0@github.com> References: <8A18xjwk_e-r_koVD-DNMO8ymggglPZA5_C31xFKT7Y=.fe6d52fb-a4e9-4cc3-8695-b44f652269b0@github.com> Message-ID: <4eNXFvMbKhkjaMrhf3Ruji1eQxqeGA3KV7QOp36WFTA=.169c64ce-7835-4b57-87dc-90e368ae4ecb@github.com> On Wed, 18 Dec 2024 09:12:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 3c634c49 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/3c634c4938f842331e53019c1f119535249f35d8 Stats: 74 lines in 1 file changed: 40 ins; 17 del; 17 mod 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java Backport-of: fa502ecd2d1040ee2fe26d0ac5dd547379a0ade7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3139 From goetz at openjdk.org Thu Dec 19 12:57:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:57:48 GMT Subject: [jdk21u-dev] Integrated: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build} In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 08:11:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 1cfc1e79 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1cfc1e7983d2949c3575f4f3ffff5a01eef62142 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod 8343128: PassFailJFrame.java test result: Error. Bad action for script: build} Use HTML character entity in javadoc to prevent jtreg from recognising PassFailJFrame.java as a test file. Backport-of: 7bca0af481e2ab1d9576fdf400079b4e4ca91e89 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1256 From goetz at openjdk.org Thu Dec 19 12:58:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:58:44 GMT Subject: [jdk17u-dev] Integrated: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:18:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 9d0d036e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9d0d036ed790946312d8a5b7431ba258e02545a4 Stats: 15 lines in 1 file changed: 4 ins; 2 del; 9 mod 8338426: Test java/nio/channels/Selector/WakeupNow.java failed Backport-of: 0853aee3b377cf9f17340a85f600651db42e6999 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3142 From goetz at openjdk.org Thu Dec 19 12:59:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 12:59:42 GMT Subject: [jdk21u-dev] Integrated: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree In-Reply-To: References: Message-ID: <1i-gZE8uYDcXp9tgS9UhAbgbUmOJy7hMOf90iF9YFyQ=.c0e890ad-c025-4b82-a6e9-d432e9ea7cc8@github.com> On Wed, 18 Dec 2024 10:36:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 2924515b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2924515b6657cb0f1ba453dac37f54633680f408 Stats: 33 lines in 2 files changed: 28 ins; 1 del; 4 mod 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree Backport-of: 342fe42555a0e892d21d187287ab996be199abb1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1263 From goetz at openjdk.org Thu Dec 19 13:00:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:00:55 GMT Subject: [jdk21u-dev] Integrated: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed In-Reply-To: References: Message-ID: <7_6e3uRXySu1wQEwYif0F6XI0rX_X51ZU6gBatO9yks=.c0e4c72c-5cee-487a-b5c9-79b0fa1351e5@github.com> On Wed, 18 Dec 2024 12:27:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 9a616985 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/9a6169856e61046691f9eeb47beb69453a356fda Stats: 82 lines in 1 file changed: 47 ins; 16 del; 19 mod 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed Backport-of: 52c0b09b62ca82f7e0cbe910cb92243131f06765 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1264 From goetz at openjdk.org Thu Dec 19 13:02:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:02:23 GMT Subject: [jdk17u-dev] Integrated: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 11:28:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 7203110a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7203110a2b6b7f8dcd386a8266116db295f9439c Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows Backport-of: 1b0281dc77f41fc5df323c7f7b25a4138b1ffb9e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3144 From goetz at openjdk.org Thu Dec 19 13:01:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:01:06 GMT Subject: [jdk17u-dev] Integrated: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:17:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 33ff5192 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/33ff51929f3c7442e5c394a4238c68cfad10ac30 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex Backport-of: 7e87c071b0fd832473f17ec0f579df40bea62950 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3141 From goetz at openjdk.org Thu Dec 19 13:02:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:02:45 GMT Subject: [jdk21u-dev] Integrated: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 12:36:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: e83e6bef Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e83e6bef4e09c6e99bdc64c5dd4c6d955d4363eb Stats: 21 lines in 1 file changed: 15 ins; 0 del; 6 mod 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 Backport-of: 59ffac84d39250623b0e6bcb871b5b3fe9c9cfe6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1265 From goetz at openjdk.org Thu Dec 19 13:03:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:03:55 GMT Subject: [jdk21u-dev] Integrated: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS In-Reply-To: <8mie12fY7sJ-UrYiyjai2Qg0dWUCQOY_QjR3YcEg6So=.393dbc6b-5c6d-4cf6-824c-1450d51b1e4b@github.com> References: <8mie12fY7sJ-UrYiyjai2Qg0dWUCQOY_QjR3YcEg6So=.393dbc6b-5c6d-4cf6-824c-1450d51b1e4b@github.com> Message-ID: On Wed, 18 Dec 2024 13:29:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: d42b931b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d42b931b9a5fd5c53ae872447036a6e44d28a96d Stats: 29 lines in 1 file changed: 11 ins; 17 del; 1 mod 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS Backport-of: bb7a8403ba1b32b2d97c0bd3ec78dac1832f5289 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1266 From goetz at openjdk.org Thu Dec 19 13:03:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:03:55 GMT Subject: [jdk17u-dev] Integrated: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree In-Reply-To: <2Kgx0Eliml03vpgh15_Wg_w4pAXPxgAu-7btS9HEsU4=.fafcb263-b594-4e8b-aeda-3378b132d561@github.com> References: <2Kgx0Eliml03vpgh15_Wg_w4pAXPxgAu-7btS9HEsU4=.fafcb263-b594-4e8b-aeda-3378b132d561@github.com> Message-ID: On Wed, 18 Dec 2024 11:16:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle > > Resolved imports in PKCS11Test, probably clean. This pull request has now been integrated. Changeset: c6bcba22 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c6bcba227955ea985dada45e46202666ea85284a Stats: 33 lines in 2 files changed: 28 ins; 1 del; 4 mod 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree Backport-of: 342fe42555a0e892d21d187287ab996be199abb1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3143 From goetz at openjdk.org Thu Dec 19 13:05:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:05:45 GMT Subject: [jdk17u-dev] Integrated: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 12:27:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 1da01792 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1da01792a43f26e2a3134e93b8bd88a0179b9496 Stats: 82 lines in 1 file changed: 47 ins; 16 del; 19 mod 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed Backport-of: 52c0b09b62ca82f7e0cbe910cb92243131f06765 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3145 From goetz at openjdk.org Thu Dec 19 13:05:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:05:54 GMT Subject: [jdk21u-dev] Integrated: 8344646: The libjsig deprecation warning should go to stderr not stdout In-Reply-To: References: Message-ID: <1j2PAdZEA3ueJluWih-kR-VKWCBO2jd5piQxNInqP7c=.bc813aa2-3eca-457d-8180-0d921ecf1bd7@github.com> On Wed, 18 Dec 2024 13:33:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: b23b738d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/b23b738d0eccc0395126c29c2766d61dee83a5c3 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8344646: The libjsig deprecation warning should go to stderr not stdout Backport-of: efeacfee015d1105dcd75e489d367a7716441fa8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1267 From goetz at openjdk.org Thu Dec 19 13:06:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:06:54 GMT Subject: [jdk17u-dev] Integrated: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 In-Reply-To: References: Message-ID: <6IxnlI7-aMKYDQFHWVDcj-D1-UY2gdE-Kwn3Om4rlP8=.3a34c6f8-64a7-4956-b802-92527a0b6fa8@github.com> On Wed, 18 Dec 2024 12:35:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > I had to resolve because "8308310:` HttpClient: Avoid logging or locking from within synchronized blocks" is not in 17. This pull request has now been integrated. Changeset: 21f2c1bb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/21f2c1bb383e1383eb667c930ec67ca979ef0404 Stats: 21 lines in 1 file changed: 15 ins; 0 del; 6 mod 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 Reviewed-by: rrich Backport-of: 59ffac84d39250623b0e6bcb871b5b3fe9c9cfe6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3146 From goetz at openjdk.org Thu Dec 19 13:07:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:07:38 GMT Subject: [jdk17u-dev] Integrated: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 13:29:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle This pull request has now been integrated. Changeset: e34f9abc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e34f9abc8e5412b282a96571297008349392e4d2 Stats: 29 lines in 1 file changed: 11 ins; 17 del; 1 mod 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS Backport-of: bb7a8403ba1b32b2d97c0bd3ec78dac1832f5289 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3147 From goetz at openjdk.org Thu Dec 19 13:09:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 19 Dec 2024 13:09:48 GMT Subject: [jdk17u-dev] Integrated: 8344646: The libjsig deprecation warning should go to stderr not stdout In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 13:34:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: bfc957aa Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/bfc957aa795dd3656c9f1ecf92e68be2b5144ec0 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8344646: The libjsig deprecation warning should go to stderr not stdout Backport-of: efeacfee015d1105dcd75e489d367a7716441fa8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3148 From aph at openjdk.org Thu Dec 19 14:28:36 2024 From: aph at openjdk.org (Andrew Haley) Date: Thu, 19 Dec 2024 14:28:36 GMT Subject: [jdk17u-dev] RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:01:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > It does not apply as > 8292591: Experimentally add back barrier-less Java thread transitions > is not in 17. > > Resolving this is obvious, the flag tested in the context in 21 is "false" by default. > Thus adding the code unconditional is the obvious thing to do. > > I added one comment from 8292591 in execute(). This change duplicates this comment in doit(), > so it's canonical to have it in execute(), too. Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3140#pullrequestreview-2514948365 From rrich at openjdk.org Thu Dec 19 17:37:39 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 19 Dec 2024 17:37:39 GMT Subject: [jdk17u-dev] RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:01:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > It does not apply as > 8292591: Experimentally add back barrier-less Java thread transitions > is not in 17. > > Resolving this is obvious, the flag tested in the context in 21 is "false" by default. > Thus adding the code unconditional is the obvious thing to do. > > I added one comment from 8292591 in execute(). This change duplicates this comment in doit(), > so it's canonical to have it in execute(), too. Looks good. Cheers, Richard. ------------- Marked as reviewed by rrich (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3140#pullrequestreview-2515724508 From mbaesken at openjdk.org Fri Dec 20 07:49:46 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 20 Dec 2024 07:49:46 GMT Subject: [jdk21u-dev] Integrated: 8339475: Clean up return code handling for pthread calls in library coding In-Reply-To: References: Message-ID: <_DIeV4Z5j0dneMghdPKtwtqUiBehOavZEJi_xD_x8Do=.aaad360d-bd65-4921-96df-a3e55fb7a62b@github.com> On Tue, 17 Dec 2024 13:22:48 GMT, Matthias Baesken wrote: > Backport of 8339475 + follow up 8341135 This pull request has now been integrated. Changeset: a01f0244 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/a01f02445d4c6711ee0df517c278b2e55616643c Stats: 24 lines in 4 files changed: 9 ins; 8 del; 7 mod 8339475: Clean up return code handling for pthread calls in library coding 8341135: Incorrect format string after JDK-8339475 Reviewed-by: mdoerr Backport-of: 2a2ecc994e02049d6d84f083b8e92a51368577bf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1247 From goetz at openjdk.org Fri Dec 20 08:36:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 08:36:57 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> On Wed, 18 Dec 2024 09:32:17 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. >> >> The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. >> >> Additional testing: >> >> - [x] linux-x64 build at alinux3, and run the test passed. >> - [x] linux-x64 build at centos7 docker container, and run the test passed. >> - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command >> >> `libCreationTimeHelper.c` compile test command: >> >> gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c >> >> >> Thanks! > > Thanks all for the reviews. Hi @sendaoYan, This change breaks our Alpine builds: asicFileAttributeView/libCreationTimeHelper.c:30:10: fatal error: bits/types.h: No such file or directory 30 | #include Is it possible that you need a follow-up? Maybe 8338884? I remove the fix request label in the meantime. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556521294 From syan at openjdk.org Fri Dec 20 09:18:45 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 20 Dec 2024 09:18:45 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> Message-ID: On Fri, 20 Dec 2024 08:33:41 GMT, Goetz Lindenmaier wrote: > Is it possible that you need a follow-up? Hi @GoeLin , This PR merge will cause a known issue in the Alpine environment to fail to compile. My original plan was to backport JDK-8342145 to jdk21u-dev immediately after this PR merge. Should I combine [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8342145](https://bugs.openjdk.org/browse/JDK-8342145) together in this PR? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556587380 From duke at openjdk.org Fri Dec 20 09:32:22 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 20 Dec 2024 09:32:22 GMT Subject: [jdk11u-dev] RFR: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 Message-ID: Clean backport of [JDK-8331959](https://bugs.openjdk.org/browse/JDK-8331959) for parity with Oracle's 11.0.27. This adds some new constants and typedefs, and minor formatting of the license file. Passes tier1 tests on Linux. ------------- Commit messages: - Backport e3b26387a3aa24640729086166fa52b6c5a6ea92 Changes: https://git.openjdk.org/jdk11u-dev/pull/2979/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2979&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331959 Stats: 221 lines in 4 files changed: 90 ins; 6 del; 125 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2979.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2979/head:pull/2979 PR: https://git.openjdk.org/jdk11u-dev/pull/2979 From goetz at openjdk.org Fri Dec 20 09:39:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 09:39:38 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. > > The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! Yes, I would prefer if you combine this. In case there are further backports, these can be based on the push to 21 and take them both together... And as this needed a review anyways you don't give up the "cleanness" of the change. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556621849 From sgehwolf at openjdk.org Fri Dec 20 09:39:39 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 20 Dec 2024 09:39:39 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> Message-ID: On Fri, 20 Dec 2024 09:15:53 GMT, SendaoYan wrote: > Should I combine [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8342145](https://bugs.openjdk.org/browse/JDK-8342145) together in this PR? Combine the two issues together will cause this PR need review again. Next time it would be good to mention the follow-up fix on the approval request as well, @sendaoYan Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556623970 From duke at openjdk.org Fri Dec 20 09:53:44 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 20 Dec 2024 09:53:44 GMT Subject: [jdk11u-dev] RFR: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 09:26:54 GMT, Antonio Vieiro wrote: > Clean backport of [JDK-8331959](https://bugs.openjdk.org/browse/JDK-8331959) for parity with Oracle's 11.0.27. > This adds some new constants and typedefs, and minor formatting of the license file. > Passes tier1 tests on Linux. Build failures are unrelated and are due to * downloads of ant binaries not complying with the [archive.apache.org ban policies](https://infra.apache.org/infra-ban.html) 2024-12-20T08:22:54.9429920Z [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk11u-dev/jdk11u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip 2024-12-20T08:25:09.1723144Z [build.sh][ERROR] wget exited with exit code 4 2024-12-20T08:25:09.1744208Z ##[error]Process completed with exit code 1. * MacOS GHA runner deprecation https://github.com/openjdk/jdk11u-dev/pull/2967 ([help is underway, though](https://github.com/openjdk/jdk17u-dev/pull/3150)) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2979#issuecomment-2556649887 From syan at openjdk.org Fri Dec 20 09:57:18 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 20 Dec 2024 09:57:18 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v2] In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: > Hi all, > > This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter. > > The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! SendaoYan has updated the pull request incrementally with one additional commit since the last revision: add patch of JDK-8342145.patch ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1068/files - new: https://git.openjdk.org/jdk21u-dev/pull/1068/files/846f1b57..b17d88eb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1068&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1068&range=00-01 Stats: 11 lines in 1 file changed: 8 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1068.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1068/head:pull/1068 PR: https://git.openjdk.org/jdk21u-dev/pull/1068 From syan at openjdk.org Fri Dec 20 09:59:44 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 20 Dec 2024 09:59:44 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> Message-ID: On Fri, 20 Dec 2024 09:37:25 GMT, Severin Gehwolf wrote: > Next time it would be good to mention the follow-up fix on the approval request as well Sorry, I will pay more attentions for next PRs. Could you review this PR again, since I add the patch of JDK-8342145 to this PR just now. @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556661159 From duke at openjdk.org Fri Dec 20 10:08:44 2024 From: duke at openjdk.org (duke) Date: Fri, 20 Dec 2024 10:08:44 GMT Subject: [jdk11u-dev] Withdrawn: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout In-Reply-To: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> References: <1dNlRz6Z9oH6oAosbrrfWJFAbPUKbV-bdpn0y_9FLKY=.8d0ce01d-85d2-455c-9f76-c3726f57bc4a@github.com> Message-ID: On Thu, 22 Aug 2024 13:15:13 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f132b347](https://github.com/openjdk/jdk/commit/f132b347e13a57d9654f0ab11db0636999576036) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade. > > This PR not clean, because this file has changed by JDK-8328638 and JDK-8329213 which not backported to jdk11u-dev. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2919 From syan at openjdk.org Fri Dec 20 10:20:45 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 20 Dec 2024 10:20:45 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> Message-ID: On Fri, 20 Dec 2024 08:33:41 GMT, Goetz Lindenmaier wrote: > asicFileAttributeView/libCreationTimeHelper.c:30:10: fatal error: bits/types.h: No such file or directory I have verify the compile libCreationTimeHelper.c at `adoptopenjdk/alpine3_build_image` docker container locally. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556697508 From sgehwolf at openjdk.org Fri Dec 20 10:27:38 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 20 Dec 2024 10:27:38 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v2] In-Reply-To: References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: On Fri, 20 Dec 2024 09:57:18 GMT, SendaoYan wrote: >> Hi all, >> >> This PR backport [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) together, and this PR fix test bug which cause test fails on some Linux distribution. Change has been verified locally, risk is low. >> >> The original PR of [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. >> >> [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) backport is cleanly. >> >> Additional testing: >> >> - [x] linux-x64 build at alinux3, and run the test passed. >> - [x] linux-x64 build at centos7 docker container, and run the test passed. >> - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command >> - [x] linux-64 compile libCreationTimeHelper.c at `adoptopenjdk/alpine3_build_image docker container` use below command >> >> `libCreationTimeHelper.c` compile test command: >> >> gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c >> >> >> Thanks! > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > add patch of JDK-8342145.patch Looks good. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1068#pullrequestreview-2517238700 From syan at openjdk.org Fri Dec 20 10:27:38 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 20 Dec 2024 10:27:38 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v2] In-Reply-To: References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: <2en_Uyj8j6onXT5fmV_JnLZRnKmiR0LY3HfvCKWb1js=.0877b775-3e59-4552-a312-03236daf36e6@github.com> On Fri, 20 Dec 2024 09:57:18 GMT, SendaoYan wrote: >> Hi all, >> >> This PR backport [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) together, and this PR fix test bug which cause test fails on some Linux distribution. Change has been verified locally, risk is low. >> >> The original PR of [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. >> >> [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) backport is cleanly. >> >> Additional testing: >> >> - [x] linux-x64 build at alinux3, and run the test passed. >> - [x] linux-x64 build at centos7 docker container, and run the test passed. >> - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command >> - [x] linux-64 compile libCreationTimeHelper.c at `adoptopenjdk/alpine3_build_image docker container` use below command >> >> `libCreationTimeHelper.c` compile test command: >> >> gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c >> >> >> Thanks! > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > add patch of JDK-8342145.patch GHA report several failures: 1. `linux-x86-hs / build(release)` fails at `Get JTReg` stage as `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated to this PR. 2. `linux-x64 / build(release)` same to 1 3. `macos-x64 / build(release)` same to 1 4. `macos-aarch64 / build` fails at `Install toolchain and dependencies` stage as `invalid developer directory`, seems like infrastructure or environmental issue, it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556710346 From goetz at openjdk.org Fri Dec 20 14:09:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 14:09:19 GMT Subject: [jdk17u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags Message-ID: This change did not apply well. I needed the following adaptions: test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java is missing in 17. It was added by "8266310: deadlock between System.loadLibrary and JNI FindClass loading another class" in 18. Skipped. Resolved test/jdk/java/lang/invoke/lambda/LambdaAccessControlTest.java bacause "8284209: Replace remaining usages of 'a the' in source code" not in 17. test/jdk/java/lang/invoke/lambda/LambdaAsm.java resolved because 8292914: Lambda proxies have unstable names and 8304846: Provide a shared utility to dump generated classes defined via Lookup API not in 17 I needed to keep one of the removed imports. test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java This needed an extensive resolve. 8304846: Provide a shared utility to dump generated classes defined via Lookup API and 8307944: ClassFileDumper should only load java.nio.file.Path if enabled not in 17. I had to rework this test significantly. The test assures that a property works that makes the VM dump lambda classes it has generated. This mechanism has changed between 17 and 21. E.g., the property name is different. Also, 17 needs to be passed a directory name, 21 has a default name for this directory. Some error cases are handled differently, sometimes a bug is reported where the other implementation continues silently. I try to take over the test structure of the test in 21, but I adapt it to test for the same VM behaviour the old test in 17 did. The new test compiles the test class to subdirectory "classes/" where the old test compiled them to ".". Also, the new test places all dumped lambda classes in DUMP_LAMBDA_PROXY_CLASS_FILES that is generated in the working directory, where the old test wrote them directly into the working directory. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java resolved as 8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack and 8300139 [AIX] Use pthreads to avoid JNI_createVM call from primordial thread not in 17 ------------- Commit messages: - Backport 1588dd934ce4e00a060e329b80f721d894559597 Changes: https://git.openjdk.org/jdk17u-dev/pull/3153/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3153&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319567 Stats: 550 lines in 16 files changed: 114 ins; 287 del; 149 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3153.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3153/head:pull/3153 PR: https://git.openjdk.org/jdk17u-dev/pull/3153 From wkemper at openjdk.org Fri Dec 20 18:24:18 2024 From: wkemper at openjdk.org (William Kemper) Date: Fri, 20 Dec 2024 18:24:18 GMT Subject: [jdk24u] RFR: 8346688: GenShen: Missing metadata trigger log message Message-ID: Clean backport. Fixes 3 vmTestbase metaspace tests. ------------- Commit messages: - Backport b8e40b9c2dfecdad9096015c1aa208ea077db7f5 Changes: https://git.openjdk.org/jdk24u/pull/5/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=5&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346688 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk24u/pull/5.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/5/head:pull/5 PR: https://git.openjdk.org/jdk24u/pull/5 From wkemper at openjdk.org Fri Dec 20 18:25:10 2024 From: wkemper at openjdk.org (William Kemper) Date: Fri, 20 Dec 2024 18:25:10 GMT Subject: [jdk24u] RFR: 8346690: Shenandoah: Fix log message for end of GC usage report Message-ID: Clean backport. Changes to logging only. ------------- Commit messages: - Backport d2a48634b872b65668b57d3975f805277ae96f83 Changes: https://git.openjdk.org/jdk24u/pull/6/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=6&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346690 Stats: 18 lines in 1 file changed: 3 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk24u/pull/6.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/6/head:pull/6 PR: https://git.openjdk.org/jdk24u/pull/6 From goetz at openjdk.org Fri Dec 20 20:44:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:44:33 GMT Subject: [jdk17u-dev] RFR: 8316056: Open source several Swing JTree tests Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 5f6cee86ef765677b0b9dc3662f4f20b636732bc Changes: https://git.openjdk.org/jdk17u-dev/pull/3154/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3154&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316056 Stats: 347 lines in 5 files changed: 347 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3154.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3154/head:pull/3154 PR: https://git.openjdk.org/jdk17u-dev/pull/3154 From goetz at openjdk.org Fri Dec 20 20:45:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:45:07 GMT Subject: [jdk21u-dev] RFR: 8316056: Open source several Swing JTree tests Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 5f6cee86ef765677b0b9dc3662f4f20b636732bc Changes: https://git.openjdk.org/jdk21u-dev/pull/1272/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1272&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316056 Stats: 347 lines in 5 files changed: 347 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1272.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1272/head:pull/1272 PR: https://git.openjdk.org/jdk21u-dev/pull/1272 From goetz at openjdk.org Fri Dec 20 20:51:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:51:04 GMT Subject: [jdk21u-dev] RFR: 8315883: Open source several Swing JToolbar tests Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 62c0a1b9ac6462233f3ee06af470be9844e9e226 Changes: https://git.openjdk.org/jdk21u-dev/pull/1273/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1273&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315883 Stats: 199 lines in 4 files changed: 199 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1273.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1273/head:pull/1273 PR: https://git.openjdk.org/jdk21u-dev/pull/1273 From goetz at openjdk.org Fri Dec 20 20:51:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:51:29 GMT Subject: [jdk17u-dev] RFR: 8315883: Open source several Swing JToolbar tests Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 62c0a1b9ac6462233f3ee06af470be9844e9e226 Changes: https://git.openjdk.org/jdk17u-dev/pull/3155/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3155&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315883 Stats: 199 lines in 4 files changed: 199 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3155.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3155/head:pull/3155 PR: https://git.openjdk.org/jdk17u-dev/pull/3155 From goetz at openjdk.org Fri Dec 20 20:55:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:55:16 GMT Subject: [jdk17u-dev] RFR: 8329210: Delete Redundant Printer Dialog Modality Test Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 7ac2f914aadf7fb12b7258e54efae959e15d6721 Changes: https://git.openjdk.org/jdk17u-dev/pull/3156/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3156&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329210 Stats: 128 lines in 2 files changed: 0 ins; 127 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3156.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3156/head:pull/3156 PR: https://git.openjdk.org/jdk17u-dev/pull/3156 From goetz at openjdk.org Fri Dec 20 20:55:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:55:54 GMT Subject: [jdk21u-dev] RFR: 8329210: Delete Redundant Printer Dialog Modality Test Message-ID: <3AqOkAC_V9HUuwzIcLeImiP-u-yDWP3ZavwmYKpwMIo=.8e58fcd4-c3f6-4ef2-af25-0895821ed700@github.com> I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 7ac2f914aadf7fb12b7258e54efae959e15d6721 Changes: https://git.openjdk.org/jdk21u-dev/pull/1274/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1274&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329210 Stats: 128 lines in 2 files changed: 0 ins; 127 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1274.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1274/head:pull/1274 PR: https://git.openjdk.org/jdk21u-dev/pull/1274 From goetz at openjdk.org Fri Dec 20 20:56:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:56:59 GMT Subject: [jdk21u-dev] RFR: 8326421: Add jtreg test for large arrayCopy disjoint case. Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 73cdc9a070249791f7d228a93fe5b9335c5f72bd Changes: https://git.openjdk.org/jdk21u-dev/pull/1275/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1275&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326421 Stats: 87 lines in 1 file changed: 87 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1275.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1275/head:pull/1275 PR: https://git.openjdk.org/jdk21u-dev/pull/1275 From goetz at openjdk.org Fri Dec 20 20:57:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 20:57:20 GMT Subject: [jdk17u-dev] RFR: 8326421: Add jtreg test for large arrayCopy disjoint case. Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 73cdc9a070249791f7d228a93fe5b9335c5f72bd Changes: https://git.openjdk.org/jdk17u-dev/pull/3157/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3157&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326421 Stats: 87 lines in 1 file changed: 87 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3157.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3157/head:pull/3157 PR: https://git.openjdk.org/jdk17u-dev/pull/3157 From goetz at openjdk.org Fri Dec 20 21:16:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 21:16:35 GMT Subject: [jdk21u-dev] RFR: 8315952: Open source several Swing JToolbar JTooltip JTree tests In-Reply-To: References: Message-ID: <71SYP-MrBOQC9A_S-NX4aqNquK-06mx-tMJdL-lIbHs=.9d48dd35-de57-46bf-9d3d-25f228483440@github.com> On Thu, 19 Dec 2024 09:35:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. GHA failure: mac jobs just hang. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1270#issuecomment-2557725148 From goetz at openjdk.org Fri Dec 20 21:19:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 20 Dec 2024 21:19:35 GMT Subject: [jdk21u-dev] RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ In-Reply-To: References: Message-ID: On Thu, 19 Dec 2024 12:19:56 GMT, yaqsun wrote: > apply clean. Hi @yaqsun how did you test this? What is the risk of the backport? Why do the GHA tests fail? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1271#issuecomment-2557728252 From wkemper at openjdk.org Sat Dec 21 00:21:09 2024 From: wkemper at openjdk.org (William Kemper) Date: Sat, 21 Dec 2024 00:21:09 GMT Subject: [jdk24u] RFR: 8346737: GenShen: Generational memory pools should not report zero for maximum capacity Message-ID: <1gAcjWPP_ep27scsXnqE1GXTqxzXHNyYCLgupxfzUqo=.e788adb9-bee8-4cc5-806f-17861bb86609@github.com> Clean backport. ------------- Commit messages: - Backport 249f141211c94afcce70d9d536d84e108e07b4e5 Changes: https://git.openjdk.org/jdk24u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=7&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346737 Stats: 6 lines in 2 files changed: 0 ins; 6 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/7.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/7/head:pull/7 PR: https://git.openjdk.org/jdk24u/pull/7 From syan at openjdk.org Sat Dec 21 04:06:55 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 21 Dec 2024 04:06:55 GMT Subject: [jdk17u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Message-ID: Hi all, This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy. Thanks! ------------- Commit messages: - Backport d562d3c7a9e1e857c095ef908b0957b033972949 Changes: https://git.openjdk.org/jdk17u-dev/pull/3158/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3158&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343882 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3158.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3158/head:pull/3158 PR: https://git.openjdk.org/jdk17u-dev/pull/3158 From syan at openjdk.org Sat Dec 21 04:07:27 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 21 Dec 2024 04:07:27 GMT Subject: [jdk21u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Message-ID: Hi all, This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy. Thanks! ------------- Commit messages: - Backport d562d3c7a9e1e857c095ef908b0957b033972949 Changes: https://git.openjdk.org/jdk21u-dev/pull/1276/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1276&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343882 Stats: 18 lines in 1 file changed: 5 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1276.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1276/head:pull/1276 PR: https://git.openjdk.org/jdk21u-dev/pull/1276 From jkratochvil at openjdk.org Sat Dec 21 04:15:21 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sat, 21 Dec 2024 04:15:21 GMT Subject: [jdk23u] RFR: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java Message-ID: A clean backport. ------------- Commit messages: - 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java Changes: https://git.openjdk.org/jdk23u/pull/232/files Webrev: https://webrevs.openjdk.org/?repo=jdk23u&pr=232&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346713 Stats: 22 lines in 3 files changed: 14 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk23u/pull/232.diff Fetch: git fetch https://git.openjdk.org/jdk23u.git pull/232/head:pull/232 PR: https://git.openjdk.org/jdk23u/pull/232 From jkratochvil at openjdk.org Sat Dec 21 04:15:48 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sat, 21 Dec 2024 04:15:48 GMT Subject: [jdk24u] RFR: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java Message-ID: A clean backport. ------------- Commit messages: - 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java Changes: https://git.openjdk.org/jdk24u/pull/8/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=8&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346713 Stats: 22 lines in 3 files changed: 14 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk24u/pull/8.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/8/head:pull/8 PR: https://git.openjdk.org/jdk24u/pull/8 From jkratochvil at openjdk.org Sat Dec 21 04:22:17 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sat, 21 Dec 2024 04:22:17 GMT Subject: [jdk21u-dev] RFR: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java Message-ID: <-nEcg8S-8Gw8WKSzR1--2V_PTZWVVpJ2M_p2UFgZ0fI=.f2e0b59b-3fb4-4e17-a1a9-b4ce6a04c058@github.com> Only `TestPLABAdaptToMinTLABSize.java` is a clean backport. `TestPinnedHumongousFragmentation.java` and `TestPinnedObjectContents.java` did not exist in JDK 21. ------------- Commit messages: - 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java Changes: https://git.openjdk.org/jdk21u-dev/pull/1277/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1277&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346713 Stats: 19 lines in 1 file changed: 13 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1277.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1277/head:pull/1277 PR: https://git.openjdk.org/jdk21u-dev/pull/1277 From goetz at openjdk.org Sat Dec 21 08:20:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 08:20:44 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v2] In-Reply-To: References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: On Fri, 20 Dec 2024 09:57:18 GMT, SendaoYan wrote: >> Hi all, >> >> This PR backport [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) together, and this PR fix test bug which cause test fails on some Linux distribution. Change has been verified locally, risk is low. >> >> The original PR of [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. >> >> [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) backport is cleanly. >> >> Additional testing: >> >> - [x] linux-x64 build at alinux3, and run the test passed. >> - [x] linux-x64 build at centos7 docker container, and run the test passed. >> - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command >> - [x] linux-64 compile libCreationTimeHelper.c at `adoptopenjdk/alpine3_build_image docker container` use below command >> >> `libCreationTimeHelper.c` compile test command: >> >> gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c >> >> >> Thanks! > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > add patch of JDK-8342145.patch LGTM, GHA failures are pointless, SAP builds all pass now. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1068#pullrequestreview-2518609970 From goetz at openjdk.org Sat Dec 21 08:23:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 08:23:47 GMT Subject: [jdk21u-dev] Integrated: 8315952: Open source several Swing JToolbar JTooltip JTree tests In-Reply-To: References: Message-ID: <5SkvcOdkaQeJfVtoJLECwYQGqEvdRhxayrmKqraIwVo=.56fab2c2-3c4b-4b72-9769-81f2d5f0bf4b@github.com> On Thu, 19 Dec 2024 09:35:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 8abf13e2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/8abf13e2b0f6fad47e1cf3c1ed3c7218e7d7225d Stats: 262 lines in 5 files changed: 262 ins; 0 del; 0 mod 8315952: Open source several Swing JToolbar JTooltip JTree tests Backport-of: d2b2f6759f7b9eb6df8eaa84b88e064c636b24a8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1270 From goetz at openjdk.org Sat Dec 21 08:24:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 08:24:46 GMT Subject: [jdk17u-dev] Integrated: 8315952: Open source several Swing JToolbar JTooltip JTree tests In-Reply-To: References: Message-ID: On Thu, 19 Dec 2024 09:35:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle This pull request has now been integrated. Changeset: d9aa7050 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d9aa705004fa32f4291fb038e587e42133eb0969 Stats: 262 lines in 5 files changed: 262 ins; 0 del; 0 mod 8315952: Open source several Swing JToolbar JTooltip JTree tests Backport-of: d2b2f6759f7b9eb6df8eaa84b88e064c636b24a8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3151 From goetz at openjdk.org Sat Dec 21 08:25:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 08:25:45 GMT Subject: [jdk17u-dev] Integrated: 8316149: Open source several Swing JTree JViewport KeyboardManager tests In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 07:57:17 GMT, Goetz Lindenmaier wrote: > This will be a clean backport from 21 once I pushed that change and adapted the title to point to the hash in 21. This pull request has now been integrated. Changeset: 10ea45e2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/10ea45e21484215849e4216004411fad93da635c Stats: 370 lines in 5 files changed: 370 ins; 0 del; 0 mod 8316149: Open source several Swing JTree JViewport KeyboardManager tests 8316627: JViewport Test headless failure Backport-of: c89fc273a893e2c981f7c07cc05ba81125816f2f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3136 From goetz at openjdk.org Sat Dec 21 08:26:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 08:26:41 GMT Subject: [jdk17u-dev] RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 In-Reply-To: References: Message-ID: <_EHHt2yhx5Yp24u4dvAHfgaksdmabUNp8SOsDk1m6-c=.89d998a9-f027-4f82-bbd0-5f2caa59d87f@github.com> On Wed, 18 Dec 2024 10:01:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > It does not apply as > 8292591: Experimentally add back barrier-less Java thread transitions > is not in 17. > > Resolving this is obvious, the flag tested in the context in 21 is "false" by default. > Thus adding the code unconditional is the obvious thing to do. > > I added one comment from 8292591 in execute(). This change duplicates this comment in doit(), > so it's canonical to have it in execute(), too. Thanks for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3140#issuecomment-2558047730 From goetz at openjdk.org Sat Dec 21 08:26:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 08:26:41 GMT Subject: [jdk17u-dev] Integrated: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 10:01:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > > It does not apply as > 8292591: Experimentally add back barrier-less Java thread transitions > is not in 17. > > Resolving this is obvious, the flag tested in the context in 21 is "false" by default. > Thus adding the code unconditional is the obvious thing to do. > > I added one comment from 8292591 in execute(). This change duplicates this comment in doit(), > so it's canonical to have it in execute(), too. This pull request has now been integrated. Changeset: 247815b2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/247815b28d0b49af3094d779b29208dc65b3f59d Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64 Reviewed-by: aph, rrich Backport-of: 83e9e482b181e76ca9f645e8cc83cfa9337df498 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3140 From syan at openjdk.org Sat Dec 21 08:58:43 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 21 Dec 2024 08:58:43 GMT Subject: [jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> <-dMaZiYGWFzJwhPpmjz7hekS4QyfW1TxkLv9VkTdvHo=.e0034b9a-b8ad-4429-a26c-1603568cdc73@github.com> Message-ID: On Fri, 20 Dec 2024 09:37:25 GMT, Severin Gehwolf wrote: >>> Is it possible that you need a follow-up? >> >> Hi @GoeLin , This PR merge will cause a known issue in the Alpine environment to fail to compile. My original plan was to backport JDK-8342145 to jdk21u-dev immediately after this PR merge. After this PR merged, JDK-8342145 can be backported to jdk21u-dev cleanly, so the backport process should be quick. >> >> Should I combine [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8342145](https://bugs.openjdk.org/browse/JDK-8342145) together in this PR? Combine the two issues together will cause this PR need review again. > >> Should I combine [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8342145](https://bugs.openjdk.org/browse/JDK-8342145) together in this PR? Combine the two issues together will cause this PR need review again. > > Next time it would be good to mention the follow-up fix on the approval request as well, @sendaoYan Thanks! @jerboaa @phohensee @GoeLin Thanks all for the reviews. @GoeLin Thanks for the verify and approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2558054592 From syan at openjdk.org Sat Dec 21 08:58:44 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 21 Dec 2024 08:58:44 GMT Subject: [jdk21u-dev] Integrated: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> References: <63T0R9S_C90zcFy1ZFMdc0GJAq_9ghDEAZUJiMfL7v8=.4d7c5e4b-f60e-4060-970f-222e1ffd5cbc@github.com> Message-ID: On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan wrote: > Hi all, > > This PR backport [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) together, and this PR fix test bug which cause test fails on some Linux distribution. Change has been verified locally, risk is low. > > The original PR of [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly. > > [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) backport is cleanly. > > Additional testing: > > - [x] linux-x64 build at alinux3, and run the test passed. > - [x] linux-x64 build at centos7 docker container, and run the test passed. > - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command > - [x] linux-64 compile libCreationTimeHelper.c at `adoptopenjdk/alpine3_build_image docker container` use below command > > `libCreationTimeHelper.c` compile test command: > > gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c > > > Thanks! This pull request has now been integrated. Changeset: c7c7280f Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3 Stats: 135 lines in 3 files changed: 116 ins; 8 del; 11 mod 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 8342145: File libCreationTimeHelper.c compile fails on Alpine Reviewed-by: sgehwolf, goetz, phh Backport-of: daa67f45f0c17d4087eb51a708193d6db124b426 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1068 From syan at openjdk.org Sat Dec 21 09:12:10 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 21 Dec 2024 09:12:10 GMT Subject: [jdk17u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 Message-ID: Hi all, This pull request contains a backport of commit [c7c7280f](https://github.com/openjdk/jdk21u-dev/commit/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. The commit being backported was authored by SendaoYan on 21 Dec 2024 and was reviewed by Severin Gehwolf, Goetz Lindenmaier and Paul Hohensee. Thanks! ------------- Commit messages: - Backport c7c7280f6e25fb68950bad93aa20a96cfc9f35b3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3159/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3159&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341881 Stats: 135 lines in 3 files changed: 116 ins; 8 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3159.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3159/head:pull/3159 PR: https://git.openjdk.org/jdk17u-dev/pull/3159 From goetz at openjdk.org Sat Dec 21 09:17:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 09:17:14 GMT Subject: [jdk21u-dev] RFR: 8343101: Rework BasicTest.testTemp test cases Message-ID: I backport this for parity with 21.0.7-oracle I include follow-up JDK-8343178, without that the test does not compile. Two clean backports. ------------- Commit messages: - Backport follow up 8343178 - Backport a95374f588149d80068275a496ba4aa04b3bb4fd Changes: https://git.openjdk.org/jdk21u-dev/pull/1278/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1278&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343101 Stats: 68 lines in 2 files changed: 34 ins; 17 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk21u-dev/pull/1278 From duke at openjdk.org Sat Dec 21 09:33:35 2024 From: duke at openjdk.org (duke) Date: Sat, 21 Dec 2024 09:33:35 GMT Subject: [jdk17u-dev] RFR: 8341424: GHA: Collect hs_errs from build time failures In-Reply-To: References: Message-ID: <7Tpkj7GS8yvx3_AJXgkVwXtiELjMSWhiD9ew5h5VzJM=.2b8404ea-7181-4e96-a2ce-e5433a431b12@github.com> On Thu, 19 Dec 2024 12:02:17 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to 11 too. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. @vieiro Your change (at version 488891217c3f1fdb494851c0577e170ea6dbed85) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3152#issuecomment-2558063597 From goetz at openjdk.org Sat Dec 21 09:47:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 09:47:07 GMT Subject: [jdk17u-dev] RFR: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build} Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 7bca0af481e2ab1d9576fdf400079b4e4ca91e89 Changes: https://git.openjdk.org/jdk17u-dev/pull/3160/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3160&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343128 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3160.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3160/head:pull/3160 PR: https://git.openjdk.org/jdk17u-dev/pull/3160 From goetz at openjdk.org Sat Dec 21 10:09:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 10:09:06 GMT Subject: [jdk21u-dev] RFR: 8342602: Remove JButton/PressedButtonRightClickTest test Message-ID: I backport this for parity with 21.0.7-oracle, ------------- Commit messages: - Backport 8647c00114385f74939bf705c9c07e709f41a18d Changes: https://git.openjdk.org/jdk21u-dev/pull/1279/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1279&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342602 Stats: 148 lines in 2 files changed: 0 ins; 147 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1279.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1279/head:pull/1279 PR: https://git.openjdk.org/jdk21u-dev/pull/1279 From goetz at openjdk.org Sat Dec 21 10:08:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 10:08:44 GMT Subject: [jdk17u-dev] RFR: 8342602: Remove JButton/PressedButtonRightClickTest test Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 8647c00114385f74939bf705c9c07e709f41a18d Changes: https://git.openjdk.org/jdk17u-dev/pull/3161/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3161&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342602 Stats: 148 lines in 2 files changed: 0 ins; 147 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3161.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3161/head:pull/3161 PR: https://git.openjdk.org/jdk17u-dev/pull/3161 From goetz at openjdk.org Sat Dec 21 11:49:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 11:49:48 GMT Subject: [jdk21u-dev] RFR: 8345414: Google CAInterop test failures Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 8e9ba788ae04a9a617a393709bf2c51a0c157206 Changes: https://git.openjdk.org/jdk21u-dev/pull/1280/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1280&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345414 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1280.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1280/head:pull/1280 PR: https://git.openjdk.org/jdk21u-dev/pull/1280 From goetz at openjdk.org Sat Dec 21 11:50:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 11:50:09 GMT Subject: [jdk17u-dev] RFR: 8345414: Google CAInterop test failures Message-ID: <2rPzPaV-0I19LCD4jqDqV3hx_Y8-vXlD9KLeqMUVdAo=.23e9b4ed-f44d-45ec-8531-d5edab0d758a@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 8e9ba788ae04a9a617a393709bf2c51a0c157206 Changes: https://git.openjdk.org/jdk17u-dev/pull/3162/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3162&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345414 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3162.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3162/head:pull/3162 PR: https://git.openjdk.org/jdk17u-dev/pull/3162 From goetz at openjdk.org Sat Dec 21 11:57:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 21 Dec 2024 11:57:09 GMT Subject: [jdk21u-dev] RFR: 8333647: C2 SuperWord: some additional PopulateIndex tests Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 487c4771818999749bfd507ab85777795bba0832 Changes: https://git.openjdk.org/jdk21u-dev/pull/1281/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1281&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333647 Stats: 99 lines in 2 files changed: 99 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1281.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1281/head:pull/1281 PR: https://git.openjdk.org/jdk21u-dev/pull/1281 From goetz at openjdk.org Sun Dec 22 09:26:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 09:26:44 GMT Subject: [jdk21u-dev] RFR: 8343101: Rework BasicTest.testTemp test cases In-Reply-To: References: Message-ID: <5uITkxEsEg9F74WPhVlB0XX3vUfJO-sVKR-t7E8Bl80=.1825acbc-1118-4030-90f1-24aaaee90a26@github.com> On Sat, 21 Dec 2024 09:11:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle > > I include follow-up JDK-8343178, without that the test does not compile. > > Two clean backports. GHA failure: wget failed. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1278#issuecomment-2558390331 From goetz at openjdk.org Sun Dec 22 09:26:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 09:26:43 GMT Subject: [jdk21u-dev] RFR: 8342602: Remove JButton/PressedButtonRightClickTest test In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 10:04:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle, GHA failure: wget failed. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1279#issuecomment-2558390228 From goetz at openjdk.org Sun Dec 22 09:26:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 09:26:48 GMT Subject: [jdk17u-dev] RFR: 8329210: Delete Redundant Printer Dialog Modality Test In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 20:50:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: three times wget failed. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3156#issuecomment-2558390492 From goetz at openjdk.org Sun Dec 22 09:24:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 09:24:44 GMT Subject: [jdk21u-dev] RFR: 8333647: C2 SuperWord: some additional PopulateIndex tests In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 11:52:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failures: Once the well konwn wget issue. The other tests failed downloading jtharness. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1281#issuecomment-2558389933 From goetz at openjdk.org Sun Dec 22 11:08:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 11:08:16 GMT Subject: [jdk17u-dev] RFR: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 7d1bbff076c063d066951eedb21de7e694e588b3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3164/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3164&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328553 Stats: 12 lines in 1 file changed: 1 ins; 8 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3164.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3164/head:pull/3164 PR: https://git.openjdk.org/jdk17u-dev/pull/3164 From goetz at openjdk.org Sun Dec 22 11:09:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 11:09:20 GMT Subject: [jdk21u-dev] RFR: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 7d1bbff076c063d066951eedb21de7e694e588b3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1282/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1282&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328553 Stats: 12 lines in 1 file changed: 1 ins; 8 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1282.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1282/head:pull/1282 PR: https://git.openjdk.org/jdk21u-dev/pull/1282 From goetz at openjdk.org Mon Dec 23 06:30:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 06:30:35 GMT Subject: [jdk21u-dev] RFR: 8333647: C2 SuperWord: some additional PopulateIndex tests In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 11:52:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failures: once: mac: download failed: Unable to download artifact(s): Artifact not found for name: bundles-macos-x64-debug once well knwon wget issue five times jtharness download failed All unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1281#issuecomment-2558996179 From goetz at openjdk.org Mon Dec 23 06:30:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 06:30:57 GMT Subject: [jdk21u-dev] RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms In-Reply-To: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> References: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> Message-ID: On Sun, 22 Dec 2024 15:03:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > I removed brokenMechanisms.contains() from the code. brokenMechanisms > was introduced by https://bugs.openjdk.org/browse/JDK-8324585 which is not > in 21. But this is a change that might be backported at some point, so I > think we should leave the code in there so that it's easier to recover it > in this case. I also wrote a note in 8324585 to do so. GHA failures: three times wget failed. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1283#issuecomment-2558997212 From duke at openjdk.org Mon Dec 23 01:27:30 2024 From: duke at openjdk.org (yaqsun) Date: Mon, 23 Dec 2024 01:27:30 GMT Subject: [jdk21u-dev] RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ [v2] In-Reply-To: References: Message-ID: <6PEKdUC9RXwAV98b4lxsqaiShyi0urg-nu_9WqqF7m0=.1dea73df-a265-4b2f-80ab-3851b5dfcfc8@github.com> > apply clean. yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-8312488 - Backport 78a8a99d990dcc0b77c096bb2ca2c1bb86462e3f ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1271/files - new: https://git.openjdk.org/jdk21u-dev/pull/1271/files/1bc13d64..b7e3eeea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1271&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1271&range=00-01 Stats: 1331 lines in 35 files changed: 1037 ins; 171 del; 123 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1271.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1271/head:pull/1271 PR: https://git.openjdk.org/jdk21u-dev/pull/1271 From goetz at openjdk.org Sun Dec 22 10:52:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 10:52:22 GMT Subject: [jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner Message-ID: I would like to fix this issue in 17. I think it's important to get this feature rigtht. I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean. ------------- Commit messages: - Backport fc918a73d0dcc28146e60f15e978209424a32576 Changes: https://git.openjdk.org/jdk17u-dev/pull/3163/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3163&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8281234 Stats: 203 lines in 4 files changed: 199 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3163.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3163/head:pull/3163 PR: https://git.openjdk.org/jdk17u-dev/pull/3163 From goetz at openjdk.org Sun Dec 22 10:25:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 10:25:37 GMT Subject: [jdk21u-dev] RFR: 8339341: SurfaceManager cacheMap retains strong references In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 15:46:49 GMT, Nikita Gubarkov wrote: > Now caching level is determined by placement of the SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" proxies and therefore strong refs via them do not prevent the cache (and hence GraphicsConfig) from being detected as weakly reachable. I ran this through SAP's testing which succeeded. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1077#issuecomment-2558406184 From goetz at openjdk.org Sun Dec 22 15:09:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 15:09:19 GMT Subject: [jdk21u-dev] RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms Message-ID: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> I backport this for parity with 21.0.7-oracle. I removed brokenMechanisms.contains() from the code. brokenMechanisms was introduced by https://bugs.openjdk.org/browse/JDK-8324585 which is not in 21. But this is a change that might be backported at some point, so I think we should leave the code in there so that it's easier to recover it in this case. I also wrote a note in 8324585 to do so. ------------- Commit messages: - Backport fdfe503d016086cf78b5a8c27dbe45f0261c68ab Changes: https://git.openjdk.org/jdk21u-dev/pull/1283/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1283&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335288 Stats: 22 lines in 1 file changed: 10 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1283.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1283/head:pull/1283 PR: https://git.openjdk.org/jdk21u-dev/pull/1283 From goetz at openjdk.org Sun Dec 22 09:27:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 22 Dec 2024 09:27:42 GMT Subject: [jdk17u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 14:03:30 GMT, Goetz Lindenmaier wrote: > This change did not apply well. I needed the following adaptions: > > > test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java > is missing in 17. It was added by "8266310: deadlock between System.loadLibrary and JNI FindClass loading another class" > in 18. Skipped. > > Resolved test/jdk/java/lang/invoke/lambda/LambdaAccessControlTest.java > bacause "8284209: Replace remaining usages of 'a the' in source code" not in 17. > > test/jdk/java/lang/invoke/lambda/LambdaAsm.java > resolved because > 8292914: Lambda proxies have unstable names > and 8304846: Provide a shared utility to dump generated classes defined via Lookup API > not in 17 > > I needed to keep one of the removed imports. > > test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java > This needed an extensive resolve. > 8304846: Provide a shared utility to dump generated classes defined via Lookup API > and > 8307944: ClassFileDumper should only load java.nio.file.Path if enabled > not in 17. > > I had to rework this test significantly. > > The test assures that a property works that makes the VM dump > lambda classes it has generated. This mechanism has changed between 17 and 21. > E.g., the property name is different. Also, 17 needs to be passed > a directory name, 21 has a default name for this directory. > Some error cases are handled differently, sometimes a bug > is reported where the other implementation continues silently. > > I try to take over the test structure of the test in 21, > but I adapt it to test for the same VM behaviour the old > test in 17 did. > > The new test compiles the test class to subdirectory "classes/" > where the old test compiled them to ".". > Also, the new test places all dumped lambda classes in > DUMP_LAMBDA_PROXY_CLASS_FILES that is generated in the > working directory, where the old test wrote them directly > into the working directory. > > test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > resolved as > 8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack > and > 8300139 [AIX] Use pthreads to avoid JNI_createVM call from primordial thread > not in 17 GHA failure: wget failted twice, Unrelated ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3153#issuecomment-2558390715 From duke at openjdk.org Mon Dec 23 06:46:42 2024 From: duke at openjdk.org (yaqsun) Date: Mon, 23 Dec 2024 06:46:42 GMT Subject: [jdk21u-dev] RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 21:17:15 GMT, Goetz Lindenmaier wrote: > Hi @yaqsun how did you test this? What is the risk of the backport? Why do the GHA tests fail? The tests passed after the retry. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1271#issuecomment-2559014685 From yan at azul.com Mon Dec 23 08:26:27 2024 From: yan at azul.com (Yuri Nesterenko) Date: Mon, 23 Dec 2024 12:26:27 +0400 Subject: Result: New JDK Updates Reviewer: Alexey Bakhtin (abakhtin) In-Reply-To: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> References: <1331f349-cd5e-4533-bffb-60d3f06f19ff@azul.com> Message-ID: --Voting [1] for Alexey Bakhtin [2] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the bylaw's definition of Lazy Consensus [3], this is sufficient to approve the nomination. Thanks, --Yuri [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-December/039760.html [2] https://openjdk.java.net/census#abakhtin [3] https://openjdk.org/bylaws#lazy-consensus From goetz at openjdk.org Mon Dec 23 09:51:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 09:51:24 GMT Subject: [jdk21u-dev] RFR: 8340313: Crash due to invalid oop in nmethod after C1 patching Message-ID: I backport this for parity with 21.0.7-oracle. I had to do trivial resolves: src/hotspot/cpu/riscv/nativeInst_riscv.cpp The first lock to be changed already uses CodeCache_lock. src/hotspot/share/runtime/mutexLocker.cpp/hpp Resolved due to context ------------- Commit messages: - Backport 58d39c317e332fda994f66529fcd1a0ea0e53151 Changes: https://git.openjdk.org/jdk21u-dev/pull/1284/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1284&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340313 Stats: 166 lines in 10 files changed: 145 ins; 7 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1284.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1284/head:pull/1284 PR: https://git.openjdk.org/jdk21u-dev/pull/1284 From mdoerr at openjdk.org Mon Dec 23 11:12:42 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Dec 2024 11:12:42 GMT Subject: [jdk21u-dev] RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms In-Reply-To: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> References: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> Message-ID: On Sun, 22 Dec 2024 15:03:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > I removed brokenMechanisms.contains() from the code. brokenMechanisms > was introduced by https://bugs.openjdk.org/browse/JDK-8324585 which is not > in 21. But this is a change that might be backported at some point, so I > think we should leave the code in there so that it's easier to recover it > in this case. I also wrote a note in 8324585 to do so. Makes sense. Is there a problem with the test RequiredMechCheck.java in 21u or why did you omit it? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1283#issuecomment-2559474685 From mdoerr at openjdk.org Mon Dec 23 11:17:35 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Dec 2024 11:17:35 GMT Subject: [jdk21u-dev] RFR: 8343101: Rework BasicTest.testTemp test cases In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 09:11:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle > > I include follow-up JDK-8343178, without that the test does not compile. > > Two clean backports. LGTM. Please make sure [JDK-8343178](https://bugs.openjdk.org/browse/JDK-8343178) will also get flagged as backported to 21u. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1278#pullrequestreview-2520412946 From goetz at openjdk.org Mon Dec 23 11:28:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 11:28:44 GMT Subject: [jdk21u-dev] RFR: 8343101: Rework BasicTest.testTemp test cases In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 09:11:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle > > I include follow-up JDK-8343178, without that the test does not compile. > > Two clean backports. Thanks for pointing out! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1278#issuecomment-2559503632 From goetz at openjdk.org Mon Dec 23 11:36:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 11:36:21 GMT Subject: [jdk21u-dev] RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms [v2] In-Reply-To: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> References: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> Message-ID: > I backport this for parity with 21.0.7-oracle. > > I removed brokenMechanisms.contains() from the code. brokenMechanisms > was introduced by https://bugs.openjdk.org/browse/JDK-8324585 which is not > in 21. But this is a change that might be backported at some point, so I > think we should leave the code in there so that it's easier to recover it > in this case. I also wrote a note in 8324585 to do so. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add missing tests ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1283/files - new: https://git.openjdk.org/jdk21u-dev/pull/1283/files/da81fe15..a0c8322b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1283&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1283&range=00-01 Stats: 130 lines in 2 files changed: 130 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1283.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1283/head:pull/1283 PR: https://git.openjdk.org/jdk21u-dev/pull/1283 From goetz at openjdk.org Mon Dec 23 11:36:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 11:36:21 GMT Subject: [jdk21u-dev] RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms In-Reply-To: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> References: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> Message-ID: On Sun, 22 Dec 2024 15:03:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > I removed brokenMechanisms.contains() from the code. brokenMechanisms > was introduced by https://bugs.openjdk.org/browse/JDK-8324585 which is not > in 21. But this is a change that might be backported at some point, so I > think we should leave the code in there so that it's easier to recover it > in this case. I also wrote a note in 8324585 to do so. Oh, I just forgot git add. Thanks for noting. Fixed. I'll run it through our testing once more. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1283#issuecomment-2559514661 From mdoerr at openjdk.org Mon Dec 23 11:52:47 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Dec 2024 11:52:47 GMT Subject: [jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner In-Reply-To: References: Message-ID: On Sun, 22 Dec 2024 10:46:58 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 17. I think it's important to get this feature rigtht. > > I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean. test/jdk/sun/security/tools/jarsigner/AutoKeyStore.java line 64: > 62: -J--add-exports -Jjava.base/sun.security.x509=ALL-UNNAMED > 63: -providerClass AutoKeyStore$AutoProvider > 64: -providerPath $test.classes You changed the code below due to missing "8281175: Add a -providerPath option to jarsigner", but here, there is still "-providerPath". test/lib/jdk/test/lib/SecurityTools.java line 71: > 69: } else { > 70: launcher.addVMArg(jarg); > 71: } For which property is this needed? I can't see such code upstream. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3163#discussion_r1895650979 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3163#discussion_r1895663482 From mdoerr at openjdk.org Mon Dec 23 11:55:42 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Dec 2024 11:55:42 GMT Subject: [jdk21u-dev] RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms [v2] In-Reply-To: References: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> Message-ID: On Mon, 23 Dec 2024 11:36:21 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.7-oracle. >> >> I removed brokenMechanisms.contains() from the code. brokenMechanisms >> was introduced by https://bugs.openjdk.org/browse/JDK-8324585 which is not >> in 21. But this is a change that might be backported at some point, so I >> think we should leave the code in there so that it's easier to recover it >> in this case. I also wrote a note in 8324585 to do so. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add missing tests LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1283#pullrequestreview-2520464927 From goetz at openjdk.org Mon Dec 23 12:50:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 12:50:44 GMT Subject: [jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 11:37:05 GMT, Martin Doerr wrote: >> I would like to fix this issue in 17. I think it's important to get this feature rigtht. >> >> I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean. > > test/jdk/sun/security/tools/jarsigner/AutoKeyStore.java line 64: > >> 62: -J--add-exports -Jjava.base/sun.security.x509=ALL-UNNAMED >> 63: -providerClass AutoKeyStore$AutoProvider >> 64: -providerPath $test.classes > > You changed the code below due to missing "8281175: Add a -providerPath option to jarsigner", but here, there is still "-providerPath". The code above calls keytool which supports the argument. jarsigner does not. For jarsigner it was added by above mentioned change. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3163#discussion_r1895719038 From syan at openjdk.org Mon Dec 23 12:56:09 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 23 Dec 2024 12:56:09 GMT Subject: [jdk21u-dev] RFR: 8322983: Virtual Threads: exclude 2 tests Message-ID: <8GjzAr9Sp9r4yZE25gFF1O7Xkg82-VJb9BvgICNlp6k=.c829fcf7-6580-4e25-9919-a02accce3dd4@github.com> Hi all, This pull request contains a backport of commit [cf28fd4c](https://github.com/openjdk/jdk/commit/cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and was reviewed by Jaikiran Pai, Leonid Mesnik and SendaoYan. Thanks! ------------- Commit messages: - Backport cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1285/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1285&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322983 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1285.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1285/head:pull/1285 PR: https://git.openjdk.org/jdk21u-dev/pull/1285 From syan at openjdk.org Mon Dec 23 13:04:42 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 23 Dec 2024 13:04:42 GMT Subject: [jdk17u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: References: Message-ID: <8LJKCeAb1xbKGP6mUDin7k-nXNHyoKwOTQExIn1MiSQ=.6cbd1bff-22ba-4c36-b07f-ccc297ebad55@github.com> On Sat, 21 Dec 2024 09:06:27 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [c7c7280f](https://github.com/openjdk/jdk21u-dev/commit/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 21 Dec 2024 and was reviewed by Severin Gehwolf, Goetz Lindenmaier and Paul Hohensee. > > Thanks! GHA report 1 failure: 1. Job `linux-x64 / build - Build / test` at `Get JTReg` stage fails `wget exited with exit code 4`, seems like infrastructure issue or environmental issue, it's unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3159#issuecomment-2559669190 From goetz at openjdk.org Mon Dec 23 14:42:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 14:42:14 GMT Subject: [jdk17u-dev] RFR: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only Message-ID: I backport this for parity with 21.0.7-oracle. 17 has the same issue. Resolved Copyright, probably clean anyways. ------------- Commit messages: - Backport 7133d1b983d7b85ba3c8dde26eb654c7ab695b07 Changes: https://git.openjdk.org/jdk17u-dev/pull/3165/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3165&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342609 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3165.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3165/head:pull/3165 PR: https://git.openjdk.org/jdk17u-dev/pull/3165 From goetz at openjdk.org Mon Dec 23 14:43:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 14:43:05 GMT Subject: [jdk21u-dev] RFR: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only Message-ID: I backport this for parity with 21.0.7-oracle. Resolved Copyright, probably clean anyways. ------------- Commit messages: - Backport 7133d1b983d7b85ba3c8dde26eb654c7ab695b07 Changes: https://git.openjdk.org/jdk21u-dev/pull/1286/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1286&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342609 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1286.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1286/head:pull/1286 PR: https://git.openjdk.org/jdk21u-dev/pull/1286 From goetz at openjdk.org Mon Dec 23 15:41:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 15:41:13 GMT Subject: [jdk21u-dev] RFR: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport 965aace297154ab08ee41a4d988553707cae8b32 Changes: https://git.openjdk.org/jdk21u-dev/pull/1287/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1287&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335468 Stats: 67 lines in 6 files changed: 47 ins; 12 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1287.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1287/head:pull/1287 PR: https://git.openjdk.org/jdk21u-dev/pull/1287 From mdoerr at openjdk.org Mon Dec 23 15:46:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 23 Dec 2024 15:46:36 GMT Subject: [jdk17u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 14:03:30 GMT, Goetz Lindenmaier wrote: > This change did not apply well. I needed the following adaptions: > > > test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java > is missing in 17. It was added by "8266310: deadlock between System.loadLibrary and JNI FindClass loading another class" > in 18. Skipped. > > Resolved test/jdk/java/lang/invoke/lambda/LambdaAccessControlTest.java > bacause "8284209: Replace remaining usages of 'a the' in source code" not in 17. > > test/jdk/java/lang/invoke/lambda/LambdaAsm.java > resolved because > 8292914: Lambda proxies have unstable names > and 8304846: Provide a shared utility to dump generated classes defined via Lookup API > not in 17 > > I needed to keep one of the removed imports. > > test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java > This needed an extensive resolve. > 8304846: Provide a shared utility to dump generated classes defined via Lookup API > and > 8307944: ClassFileDumper should only load java.nio.file.Path if enabled > not in 17. > > I had to rework this test significantly. > > The test assures that a property works that makes the VM dump > lambda classes it has generated. This mechanism has changed between 17 and 21. > E.g., the property name is different. Also, 17 needs to be passed > a directory name, 21 has a default name for this directory. > Some error cases are handled differently, sometimes a bug > is reported where the other implementation continues silently. > > I try to take over the test structure of the test in 21, > but I adapt it to test for the same VM behaviour the old > test in 17 did. > > The new test compiles the test class to subdirectory "classes/" > where the old test compiled them to ".". > Also, the new test places all dumped lambda classes in > DUMP_LAMBDA_PROXY_CLASS_FILES that is generated in the > working directory, where the old test wrote them directly > into the working directory. > > test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > resolved as > 8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack > and > 8300139 [AIX] Use pthreads to avoid JNI_createVM call from primordial thread > not in 17 LGTM. Seems like many manual changes were needed because https://github.com/openjdk/jdk/commit/dd59471798ad0118481939c59e58eca18e4365d1 is not in 17u. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3153#pullrequestreview-2520816982 From goetz at openjdk.org Mon Dec 23 15:55:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 15:55:40 GMT Subject: [jdk17u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 14:03:30 GMT, Goetz Lindenmaier wrote: > This change did not apply well. I needed the following adaptions: > > > test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java > is missing in 17. It was added by "8266310: deadlock between System.loadLibrary and JNI FindClass loading another class" > in 18. Skipped. > > Resolved test/jdk/java/lang/invoke/lambda/LambdaAccessControlTest.java > bacause "8284209: Replace remaining usages of 'a the' in source code" not in 17. > > test/jdk/java/lang/invoke/lambda/LambdaAsm.java > resolved because > 8292914: Lambda proxies have unstable names > and 8304846: Provide a shared utility to dump generated classes defined via Lookup API > not in 17 > > I needed to keep one of the removed imports. > > test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java > This needed an extensive resolve. > 8304846: Provide a shared utility to dump generated classes defined via Lookup API > and > 8307944: ClassFileDumper should only load java.nio.file.Path if enabled > not in 17. > > I had to rework this test significantly. > > The test assures that a property works that makes the VM dump > lambda classes it has generated. This mechanism has changed between 17 and 21. > E.g., the property name is different. Also, 17 needs to be passed > a directory name, 21 has a default name for this directory. > Some error cases are handled differently, sometimes a bug > is reported where the other implementation continues silently. > > I try to take over the test structure of the test in 21, > but I adapt it to test for the same VM behaviour the old > test in 17 did. > > The new test compiles the test class to subdirectory "classes/" > where the old test compiled them to ".". > Also, the new test places all dumped lambda classes in > DUMP_LAMBDA_PROXY_CLASS_FILES that is generated in the > working directory, where the old test wrote them directly > into the working directory. > > test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > resolved as > 8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack > and > 8300139 [AIX] Use pthreads to avoid JNI_createVM call from primordial thread > not in 17 Thanks for the review!! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3153#issuecomment-2559941309 From goetz at openjdk.org Mon Dec 23 16:05:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 16:05:59 GMT Subject: [jdk21u-dev] RFR: 8339883: Open source several AWT/2D related tests Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport b26645f64bb6dd3efafaceb92bedeaf8f93906e3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1288/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1288&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339883 Stats: 315 lines in 4 files changed: 315 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1288.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1288/head:pull/1288 PR: https://git.openjdk.org/jdk21u-dev/pull/1288 From goetz at openjdk.org Mon Dec 23 16:07:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 23 Dec 2024 16:07:16 GMT Subject: [jdk17u-dev] RFR: 8339883: Open source several AWT/2D related tests Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport b26645f64bb6dd3efafaceb92bedeaf8f93906e3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3166/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3166&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339883 Stats: 315 lines in 4 files changed: 315 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3166.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3166/head:pull/3166 PR: https://git.openjdk.org/jdk17u-dev/pull/3166 From duke at openjdk.org Mon Dec 23 17:18:42 2024 From: duke at openjdk.org (duke) Date: Mon, 23 Dec 2024 17:18:42 GMT Subject: [jdk24u] RFR: 8346688: GenShen: Missing metadata trigger log message In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 18:17:44 GMT, William Kemper wrote: > Clean backport. Fixes 3 vmTestbase metaspace tests. @earthling-amzn Your change (at version 7352946538128a3dfafff4dd15d5f7ea8338a960) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/5#issuecomment-2560053765 From duke at openjdk.org Mon Dec 23 17:18:47 2024 From: duke at openjdk.org (duke) Date: Mon, 23 Dec 2024 17:18:47 GMT Subject: [jdk24u] RFR: 8346690: Shenandoah: Fix log message for end of GC usage report In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 18:18:18 GMT, William Kemper wrote: > Clean backport. Changes to logging only. @earthling-amzn Your change (at version cdbbe45a6a6530fcd03ae8cc5121903a05f9577a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/6#issuecomment-2560053577 From ysr at openjdk.org Mon Dec 23 21:04:35 2024 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Mon, 23 Dec 2024 21:04:35 GMT Subject: [jdk24u] RFR: 8346688: GenShen: Missing metadata trigger log message In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 18:17:44 GMT, William Kemper wrote: > Clean backport. Fixes 3 vmTestbase metaspace tests. Can you add the names of the failing tests that this fixed, perhaps in the JBS ticket? Thanks! ------------- Marked as reviewed by ysr (Reviewer). PR Review: https://git.openjdk.org/jdk24u/pull/5#pullrequestreview-2521140880 From ysr at openjdk.org Mon Dec 23 21:05:36 2024 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Mon, 23 Dec 2024 21:05:36 GMT Subject: [jdk24u] RFR: 8346690: Shenandoah: Fix log message for end of GC usage report In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 18:18:18 GMT, William Kemper wrote: > Clean backport. Changes to logging only. Marked as reviewed by ysr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk24u/pull/6#pullrequestreview-2521141814 From wkemper at openjdk.org Mon Dec 23 21:08:42 2024 From: wkemper at openjdk.org (William Kemper) Date: Mon, 23 Dec 2024 21:08:42 GMT Subject: [jdk24u] Integrated: 8346688: GenShen: Missing metadata trigger log message In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 18:17:44 GMT, William Kemper wrote: > Clean backport. Fixes 3 vmTestbase metaspace tests. This pull request has now been integrated. Changeset: 79610be0 Author: William Kemper Committer: Y. Srinivas Ramakrishna URL: https://git.openjdk.org/jdk24u/commit/79610be01d1b06251b6a1a0807463ba2b9c733f7 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8346688: GenShen: Missing metadata trigger log message Reviewed-by: ysr Backport-of: b8e40b9c2dfecdad9096015c1aa208ea077db7f5 ------------- PR: https://git.openjdk.org/jdk24u/pull/5 From wkemper at openjdk.org Mon Dec 23 21:10:02 2024 From: wkemper at openjdk.org (William Kemper) Date: Mon, 23 Dec 2024 21:10:02 GMT Subject: [jdk24u] Integrated: 8346690: Shenandoah: Fix log message for end of GC usage report In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 18:18:18 GMT, William Kemper wrote: > Clean backport. Changes to logging only. This pull request has now been integrated. Changeset: 8135af12 Author: William Kemper Committer: Y. Srinivas Ramakrishna URL: https://git.openjdk.org/jdk24u/commit/8135af12ef041c08645112fc599476ee35ec4d00 Stats: 18 lines in 1 file changed: 3 ins; 0 del; 15 mod 8346690: Shenandoah: Fix log message for end of GC usage report Reviewed-by: ysr Backport-of: d2a48634b872b65668b57d3975f805277ae96f83 ------------- PR: https://git.openjdk.org/jdk24u/pull/6 From duke at openjdk.org Tue Dec 24 01:38:54 2024 From: duke at openjdk.org (duke) Date: Tue, 24 Dec 2024 01:38:54 GMT Subject: [jdk21u-dev] RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ [v2] In-Reply-To: <6PEKdUC9RXwAV98b4lxsqaiShyi0urg-nu_9WqqF7m0=.1dea73df-a265-4b2f-80ab-3851b5dfcfc8@github.com> References: <6PEKdUC9RXwAV98b4lxsqaiShyi0urg-nu_9WqqF7m0=.1dea73df-a265-4b2f-80ab-3851b5dfcfc8@github.com> Message-ID: On Mon, 23 Dec 2024 01:27:30 GMT, yaqsun wrote: >> apply clean.And test have been locally verified to pass. > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-8312488 > - Backport 78a8a99d990dcc0b77c096bb2ca2c1bb86462e3f @yaqsun Your change (at version b7e3eeea7b4c5681cda9d84e652046558a2dc497) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1271#issuecomment-2560516390 From syan at openjdk.org Tue Dec 24 06:38:20 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Dec 2024 06:38:20 GMT Subject: [jdk11u-dev] RFR: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out Message-ID: Hi all, This pull request contains a backport of commit [7acfba28](https://github.com/openjdk/jdk/commit/7acfba288ff4d1f43cc36506b2bd2d32107b00c2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. The commit being backported was authored by Mark Sheppard on 5 Jun 2024 and was reviewed by Brian Burkhalter. Thanks! ------------- Commit messages: - Backport 7acfba288ff4d1f43cc36506b2bd2d32107b00c2 Changes: https://git.openjdk.org/jdk11u-dev/pull/2980/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2980&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327650 Stats: 110 lines in 1 file changed: 74 ins; 10 del; 26 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2980.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2980/head:pull/2980 PR: https://git.openjdk.org/jdk11u-dev/pull/2980 From syan at openjdk.org Tue Dec 24 06:48:25 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Dec 2024 06:48:25 GMT Subject: [jdk11u-dev] RFR: 8216539: tools/jar/modularJar/Basic.java timed out Message-ID: Hi all, This pull request contains a backport of commit [518e3a87](https://github.com/openjdk/jdk/commit/518e3a878862fd7be2d9eea42f122fdaa01c7dd8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. Thanks! ------------- Commit messages: - 8216539: tools/jar/modularJar/Basic.java times out Changes: https://git.openjdk.org/jdk11u-dev/pull/2981/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2981&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8216539 Stats: 34 lines in 1 file changed: 24 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2981.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2981/head:pull/2981 PR: https://git.openjdk.org/jdk11u-dev/pull/2981 From syan at openjdk.org Tue Dec 24 07:56:14 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Dec 2024 07:56:14 GMT Subject: [jdk17u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java Message-ID: Hi all, This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR improves logging of a test to be able to debug failures more easily, and it's prefixed PR of JDK-8323196. The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. Thanks! ------------- Commit messages: - Backport f3bb3e21704dd47c6c5d5753ca5882520a538c06 Changes: https://git.openjdk.org/jdk17u-dev/pull/3167/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3167&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331153 Stats: 21 lines in 1 file changed: 15 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3167.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3167/head:pull/3167 PR: https://git.openjdk.org/jdk17u-dev/pull/3167 From yan at openjdk.org Tue Dec 24 09:00:44 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 24 Dec 2024 09:00:44 GMT Subject: [jdk17u-dev] RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts [v3] In-Reply-To: References: Message-ID: On Wed, 13 Nov 2024 18:30:32 GMT, Alexey Bakhtin wrote: >> Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503). >> >> The backport is almost clean except for the following: >> - OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev >> - copyright year in GetPropertyAction.java and URICertStore.java files are updated manually >> - CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes. >> >> All new and related jtreg tests are passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Remove unused DEFAULT_READ_TIMEOUT constant Marked as reviewed by yan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2747#pullrequestreview-2521691760 From goetz at openjdk.org Tue Dec 24 10:57:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 10:57:54 GMT Subject: [jdk21u-dev] RFR: 8340313: Crash due to invalid oop in nmethod after C1 patching In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 09:45:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > I had to do trivial resolves: > > src/hotspot/cpu/riscv/nativeInst_riscv.cpp > The first lock to be changed already uses CodeCache_lock. > > src/hotspot/share/runtime/mutexLocker.cpp/hpp > Resolved due to context GHA failure: Twice well konwn wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1284#issuecomment-2560985569 From goetz at openjdk.org Tue Dec 24 10:58:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 10:58:46 GMT Subject: [jdk17u-dev] RFR: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 14:35:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > 17 has the same issue. > > Resolved Copyright, probably clean anyways. GHA failure: well konwn wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3165#issuecomment-2560986536 From goetz at openjdk.org Tue Dec 24 10:58:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 10:58:55 GMT Subject: [jdk17u-dev] RFR: 8339883: Open source several AWT/2D related tests In-Reply-To: References: Message-ID: <6Rfh-GuEiptmBkmhBkCaowTa5dwuDl1tD_w8aCSrvA8=.7086fedb-0cf1-4f8b-8cc6-fdae9fddd955@github.com> On Mon, 23 Dec 2024 16:00:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: Twice well konwn wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3166#issuecomment-2560987168 From goetz at openjdk.org Tue Dec 24 11:04:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:04:41 GMT Subject: [jdk21u-dev] RFR: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++ In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 06:43:37 GMT, yaqsun wrote: > > Hi @yaqsun how did you test this? What is the risk of the backport? Why do the GHA tests fail? > > The tests passed after the retry. This does not answer any of my questions above. Please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix It;s a good idea to restart the tests if they failed due to an infrastructure issue, but before that you shoudl have a look whether that was the case. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1271#issuecomment-2560992338 From goetz at openjdk.org Tue Dec 24 11:05:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:05:41 GMT Subject: [jdk21u-dev] Integrated: 8316056: Open source several Swing JTree tests In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 20:39:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: a98f9cf4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/a98f9cf44811099193efbf712bf2e642ed70b797 Stats: 347 lines in 5 files changed: 347 ins; 0 del; 0 mod 8316056: Open source several Swing JTree tests Backport-of: 5f6cee86ef765677b0b9dc3662f4f20b636732bc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1272 From goetz at openjdk.org Tue Dec 24 11:08:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:08:37 GMT Subject: [jdk21u-dev] Integrated: 8329210: Delete Redundant Printer Dialog Modality Test In-Reply-To: <3AqOkAC_V9HUuwzIcLeImiP-u-yDWP3ZavwmYKpwMIo=.8e58fcd4-c3f6-4ef2-af25-0895821ed700@github.com> References: <3AqOkAC_V9HUuwzIcLeImiP-u-yDWP3ZavwmYKpwMIo=.8e58fcd4-c3f6-4ef2-af25-0895821ed700@github.com> Message-ID: <2oZshdrFR4Yhva_rtSgOx_uocOu7LwHP8Lmw0p9XjUs=.54e2d52b-8284-45bd-a736-a8bf9e23d05b@github.com> On Fri, 20 Dec 2024 20:50:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: f3e7bb43 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/f3e7bb4301d4cdc607d0929d5e867ad26d58b10a Stats: 128 lines in 2 files changed: 0 ins; 127 del; 1 mod 8329210: Delete Redundant Printer Dialog Modality Test Backport-of: 7ac2f914aadf7fb12b7258e54efae959e15d6721 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1274 From goetz at openjdk.org Tue Dec 24 11:08:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:08:42 GMT Subject: [jdk21u-dev] Integrated: 8315883: Open source several Swing JToolbar tests In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 20:45:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: d91dba3d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d91dba3d82a323c0fe05d572da8aa6e0feb9b8b5 Stats: 199 lines in 4 files changed: 199 ins; 0 del; 0 mod 8315883: Open source several Swing JToolbar tests Backport-of: 62c0a1b9ac6462233f3ee06af470be9844e9e226 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1273 From goetz at openjdk.org Tue Dec 24 11:10:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:10:37 GMT Subject: [jdk21u-dev] Integrated: 8326421: Add jtreg test for large arrayCopy disjoint case. In-Reply-To: References: Message-ID: <_4nNK6TYOiC2UflEFj-U81Vgj1cKaHwztQ48q-qG9M0=.c3eb9432-8fe1-49d4-91ab-7c958a300a5b@github.com> On Fri, 20 Dec 2024 20:51:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 3aa331db Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/3aa331db4b15294689a44a08a279fd0753b866ff Stats: 87 lines in 1 file changed: 87 ins; 0 del; 0 mod 8326421: Add jtreg test for large arrayCopy disjoint case. Backport-of: 73cdc9a070249791f7d228a93fe5b9335c5f72bd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1275 From goetz at openjdk.org Tue Dec 24 11:17:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:17:40 GMT Subject: [jdk21u-dev] Integrated: 8333647: C2 SuperWord: some additional PopulateIndex tests In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 11:52:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 173c3d39 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/173c3d3917d7feb61ac69f7a5049b1355d2de6a4 Stats: 99 lines in 2 files changed: 99 ins; 0 del; 0 mod 8333647: C2 SuperWord: some additional PopulateIndex tests Backport-of: 487c4771818999749bfd507ab85777795bba0832 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1281 From goetz at openjdk.org Tue Dec 24 11:18:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:18:41 GMT Subject: [jdk17u-dev] Integrated: 8316056: Open source several Swing JTree tests In-Reply-To: References: Message-ID: <2pAsZbgvkgE15RmJ1noAdJ0o3CZvcBM9CkIEAYvEEsk=.cc02952c-82ef-4c27-9089-116c1b95be13@github.com> On Fri, 20 Dec 2024 20:39:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: a35aef83 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/a35aef83376ddb934cbbf7ec061b04fc58d62246 Stats: 347 lines in 5 files changed: 347 ins; 0 del; 0 mod 8316056: Open source several Swing JTree tests Backport-of: 5f6cee86ef765677b0b9dc3662f4f20b636732bc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3154 From goetz at openjdk.org Tue Dec 24 11:19:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:19:37 GMT Subject: [jdk21u-dev] Integrated: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java In-Reply-To: References: Message-ID: On Sun, 22 Dec 2024 11:03:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: bf86b342 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/bf86b34260576bcc8826fb784d183a6e2976c288 Stats: 12 lines in 1 file changed: 1 ins; 8 del; 3 mod 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java Backport-of: 7d1bbff076c063d066951eedb21de7e694e588b3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1282 From goetz at openjdk.org Tue Dec 24 11:19:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:19:42 GMT Subject: [jdk17u-dev] Integrated: 8315883: Open source several Swing JToolbar tests In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 20:45:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 409158e2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/409158e280a63fef485cfbf913643102c83b61bb Stats: 199 lines in 4 files changed: 199 ins; 0 del; 0 mod 8315883: Open source several Swing JToolbar tests Backport-of: 62c0a1b9ac6462233f3ee06af470be9844e9e226 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3155 From goetz at openjdk.org Tue Dec 24 11:22:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:22:41 GMT Subject: [jdk21u-dev] Integrated: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms In-Reply-To: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> References: <9AArrijRwzuDpq0X_feDYbIBIuzNS6NnoTOwcHTtVp0=.f7f42d3f-f20a-4194-b272-656d3b6156ff@github.com> Message-ID: On Sun, 22 Dec 2024 15:03:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > I removed brokenMechanisms.contains() from the code. brokenMechanisms > was introduced by https://bugs.openjdk.org/browse/JDK-8324585 which is not > in 21. But this is a change that might be backported at some point, so I > think we should leave the code in there so that it's easier to recover it > in this case. I also wrote a note in 8324585 to do so. This pull request has now been integrated. Changeset: 85e5a5c6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/85e5a5c6e160a92cf599e649413e08fe03df6de5 Stats: 152 lines in 3 files changed: 140 ins; 2 del; 10 mod 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms Reviewed-by: mdoerr Backport-of: fdfe503d016086cf78b5a8c27dbe45f0261c68ab ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1283 From goetz at openjdk.org Tue Dec 24 11:23:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:23:37 GMT Subject: [jdk21u-dev] Integrated: 8343101: Rework BasicTest.testTemp test cases In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 09:11:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle > > I include follow-up JDK-8343178, without that the test does not compile. > > Two clean backports. This pull request has now been integrated. Changeset: fe9284a8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/fe9284a8c523bc747e107836c85114864efab2a1 Stats: 68 lines in 2 files changed: 34 ins; 17 del; 17 mod 8343101: Rework BasicTest.testTemp test cases 8343178: Test BasicTest.java javac compile fails cannot find symbol Reviewed-by: mdoerr Backport-of: a95374f588149d80068275a496ba4aa04b3bb4fd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1278 From goetz at openjdk.org Tue Dec 24 11:24:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:24:36 GMT Subject: [jdk21u-dev] Integrated: 8342602: Remove JButton/PressedButtonRightClickTest test In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 10:04:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle, This pull request has now been integrated. Changeset: 182e9497 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/182e9497b6f3fcf3b93817c8efa2fe696e2bf823 Stats: 148 lines in 2 files changed: 0 ins; 147 del; 1 mod 8342602: Remove JButton/PressedButtonRightClickTest test Backport-of: 8647c00114385f74939bf705c9c07e709f41a18d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1279 From goetz at openjdk.org Tue Dec 24 11:25:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:25:37 GMT Subject: [jdk21u-dev] Integrated: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 11:45:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 36b067cb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/36b067cbb23208cdaa6ea622fe4fe994a1b2ba42 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8345414: Google CAInterop test failures Backport-of: 8e9ba788ae04a9a617a393709bf2c51a0c157206 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1280 From goetz at openjdk.org Tue Dec 24 11:29:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:29:39 GMT Subject: [jdk17u-dev] Integrated: 8329210: Delete Redundant Printer Dialog Modality Test In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 20:50:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 0ea0b86f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0ea0b86f8f300db8e67bae277896d5c001109610 Stats: 128 lines in 2 files changed: 0 ins; 127 del; 1 mod 8329210: Delete Redundant Printer Dialog Modality Test Backport-of: 7ac2f914aadf7fb12b7258e54efae959e15d6721 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3156 From goetz at openjdk.org Tue Dec 24 11:30:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:30:41 GMT Subject: [jdk17u-dev] Integrated: 8326421: Add jtreg test for large arrayCopy disjoint case. In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 20:51:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 0b14f53a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0b14f53ade5355639980da4ec78a169d40e0e01a Stats: 87 lines in 1 file changed: 87 ins; 0 del; 0 mod 8326421: Add jtreg test for large arrayCopy disjoint case. Backport-of: 73cdc9a070249791f7d228a93fe5b9335c5f72bd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3157 From goetz at openjdk.org Tue Dec 24 11:32:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:32:39 GMT Subject: [jdk17u-dev] Integrated: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java In-Reply-To: References: Message-ID: On Sun, 22 Dec 2024 11:03:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: b121ce5a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b121ce5a21265db515e8252d2c8f6e9d7ca03423 Stats: 12 lines in 1 file changed: 1 ins; 8 del; 3 mod 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java Backport-of: 7d1bbff076c063d066951eedb21de7e694e588b3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3164 From goetz at openjdk.org Tue Dec 24 11:33:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:33:39 GMT Subject: [jdk17u-dev] Integrated: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build} In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 09:42:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: e7fedf5e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e7fedf5e1db42adaf1e4f266a718bfec1f28ff95 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod 8343128: PassFailJFrame.java test result: Error. Bad action for script: build} Use HTML character entity in javadoc to prevent jtreg from recognising PassFailJFrame.java as a test file. Backport-of: 7bca0af481e2ab1d9576fdf400079b4e4ca91e89 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3160 From goetz at openjdk.org Tue Dec 24 11:34:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:34:40 GMT Subject: [jdk17u-dev] Integrated: 8342602: Remove JButton/PressedButtonRightClickTest test In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 10:04:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 8f93d8ab Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8f93d8ab9860771d5ab593d92cf71312b608f9f5 Stats: 148 lines in 2 files changed: 0 ins; 147 del; 1 mod 8342602: Remove JButton/PressedButtonRightClickTest test Backport-of: 8647c00114385f74939bf705c9c07e709f41a18d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3161 From goetz at openjdk.org Tue Dec 24 11:35:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 11:35:39 GMT Subject: [jdk17u-dev] Integrated: 8345414: Google CAInterop test failures In-Reply-To: <2rPzPaV-0I19LCD4jqDqV3hx_Y8-vXlD9KLeqMUVdAo=.23e9b4ed-f44d-45ec-8531-d5edab0d758a@github.com> References: <2rPzPaV-0I19LCD4jqDqV3hx_Y8-vXlD9KLeqMUVdAo=.23e9b4ed-f44d-45ec-8531-d5edab0d758a@github.com> Message-ID: On Sat, 21 Dec 2024 11:45:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: e6fb6624 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e6fb662484d3b24406b1ce13f17a087c05bc39cc Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8345414: Google CAInterop test failures Backport-of: 8e9ba788ae04a9a617a393709bf2c51a0c157206 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3162 From syan at openjdk.org Tue Dec 24 12:20:37 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Dec 2024 12:20:37 GMT Subject: [jdk11u-dev] RFR: 8216539: tools/jar/modularJar/Basic.java timed out In-Reply-To: References: Message-ID: On Tue, 24 Dec 2024 06:42:49 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [518e3a87](https://github.com/openjdk/jdk/commit/518e3a878862fd7be2d9eea42f122fdaa01c7dd8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk. > > Thanks! GHA report 2 failures: 1. Job `linux-x64 / build - Build / test` fails at `Get JTReg` stage, report `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated this PR. 2. Job `linux-x64-hs-nopch / build - Build / test` fails at `Get JTReg` stage, report `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2981#issuecomment-2561062179 From syan at openjdk.org Tue Dec 24 12:22:43 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Dec 2024 12:22:43 GMT Subject: [jdk11u-dev] RFR: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded" In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 03:11:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [69384745](https://github.com/openjdk/jdk/commit/693847452f208446a34186f142fe2c56a49ceceb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Albert Mingkun Yang on 30 Nov 2023 and was reviewed by Stefan Johansson and Thomas Schatzl. > > Thanks! GHA report 2 failures: 1. Job `linux-x64 / build - Build / test` fails at `Get JTReg` stage, report `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated this PR. 2. Job `linux-x64-hs-minimal / build - Build / test` fails at `Get JTReg` stage, report `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2976#issuecomment-2561064910 From syan at openjdk.org Tue Dec 24 12:24:46 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 24 Dec 2024 12:24:46 GMT Subject: [jdk17u-dev] RFR: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 04:02:03 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [d562d3c7](https://github.com/openjdk/jdk/commit/d562d3c7a9e1e857c095ef908b0957b033972949) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Test-fix only, change has been verified locally, no risk. > > The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy. > > Thanks! GHA report 2 failures: 1. Job `linux-x64-hs-minimal` fails at `Get JTReg` stage, report `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated this PR. 2. Job `linux-x64-hs-optimized` fails at `Get JTReg` stage, report `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3158#issuecomment-2561066736 From goetz at openjdk.org Tue Dec 24 14:00:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 24 Dec 2024 14:00:01 GMT Subject: [jdk21u-dev] RFR: 8304701: Request with timeout aborts later in-flight request on HTTP/1.1 cxn Message-ID: I would like to fix this issue in 21. ------------- Commit messages: - Backport bddcd086b7c76d915aaa76427c2ae4088ad4239f Changes: https://git.openjdk.org/jdk21u-dev/pull/1289/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1289&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304701 Stats: 179 lines in 2 files changed: 178 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1289.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1289/head:pull/1289 PR: https://git.openjdk.org/jdk21u-dev/pull/1289 From syan at openjdk.org Wed Dec 25 13:20:41 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 25 Dec 2024 13:20:41 GMT Subject: [jdk17u-dev] RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: <4NiW5PvlunisJvIySgSNnVqE8cifjI9-jPpge3YARS0=.053dc62b-7eec-4020-a1f6-d62b846591da@github.com> On Tue, 24 Dec 2024 07:50:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR improves logging of a test to be able to debug failures more easily, and it's prefixed PR of JDK-8323196. > > The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3167#issuecomment-2561888207 From syan at openjdk.org Wed Dec 25 13:20:41 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 25 Dec 2024 13:20:41 GMT Subject: [jdk17u-dev] Integrated: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java In-Reply-To: References: Message-ID: On Tue, 24 Dec 2024 07:50:34 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [f3bb3e21](https://github.com/openjdk/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR improves logging of a test to be able to debug failures more easily, and it's prefixed PR of JDK-8323196. > > The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Gr?nlund. > > Thanks! This pull request has now been integrated. Changeset: 5623e10b Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/5623e10b38634415bb42a05f8c1f9dcbaf25951c Stats: 21 lines in 1 file changed: 15 ins; 1 del; 5 mod 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java Backport-of: f3bb3e21704dd47c6c5d5753ca5882520a538c06 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3167 From goetz at openjdk.org Wed Dec 25 16:38:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Dec 2024 16:38:14 GMT Subject: [jdk21u-dev] RFR: 8313905: Checked_cast assert in CDS compare_by_loader Message-ID: I backport this for parity with 21.0.7-oracle. Resolved because "8313564: Fix -Wconversion warnings in classfile code" is not in 21. Probably clean anyways. ------------- Commit messages: - Backport bd1b9427410c458215e9e89eeff6e4d30592a4a4 Changes: https://git.openjdk.org/jdk21u-dev/pull/1290/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1290&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313905 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1290.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1290/head:pull/1290 PR: https://git.openjdk.org/jdk21u-dev/pull/1290 From goetz at openjdk.org Wed Dec 25 16:51:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Dec 2024 16:51:01 GMT Subject: [jdk17u-dev] RFR: 8315825: Open some swing tests Message-ID: <3Hxa-L7X325DaehG5LPf-jlFxz0hEDOuYrgon2vqR9U=.66a1a8b4-82fa-49e4-900b-90ea0fa4da1f@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport e015e6ce28e263e546cd1b6583a4a3ecc431d576 Changes: https://git.openjdk.org/jdk17u-dev/pull/3168/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3168&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315825 Stats: 449 lines in 4 files changed: 449 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3168.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3168/head:pull/3168 PR: https://git.openjdk.org/jdk17u-dev/pull/3168 From goetz at openjdk.org Wed Dec 25 16:52:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Dec 2024 16:52:23 GMT Subject: [jdk21u-dev] RFR: 8315825: Open some swing tests Message-ID: I backport this for parity with 21.0.7-oracle ------------- Commit messages: - Backport e015e6ce28e263e546cd1b6583a4a3ecc431d576 Changes: https://git.openjdk.org/jdk21u-dev/pull/1291/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1291&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315825 Stats: 449 lines in 4 files changed: 449 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1291.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1291/head:pull/1291 PR: https://git.openjdk.org/jdk21u-dev/pull/1291 From goetz at openjdk.org Wed Dec 25 16:59:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 25 Dec 2024 16:59:15 GMT Subject: [jdk17u-dev] RFR: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main Message-ID: I backport this for parity with 17.0.15-oracle ------------- Commit messages: - Backport ef2bd5721316f208a458fecfffa02ec2c0ea7fe0 Changes: https://git.openjdk.org/jdk17u-dev/pull/3169/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3169&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328558 Stats: 351 lines in 4 files changed: 108 ins; 243 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3169.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3169/head:pull/3169 PR: https://git.openjdk.org/jdk17u-dev/pull/3169 From syan at openjdk.org Thu Dec 26 03:49:08 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 26 Dec 2024 03:49:08 GMT Subject: [jdk17u-dev] RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" Message-ID: <9Uet0EEQ6traXee9R1A4xkk7YdRU8uVCH-APa-bTkVE=.5294228f-4602-4fc9-ad7e-153bcbe174d9@github.com> Hi all, This pull request contains a backport of commit [bdd96604](https://github.com/openjdk/jdk/commit/bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Change has been verified locally, test-fix only, no risk. The commit being backported was authored by Erik Gahlin on 21 Jun 2024 and was reviewed by Markus Gr?nlund. Thanks! ------------- Commit messages: - Backport bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa Changes: https://git.openjdk.org/jdk17u-dev/pull/3170/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3170&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323196 Stats: 37 lines in 1 file changed: 16 ins; 0 del; 21 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3170.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3170/head:pull/3170 PR: https://git.openjdk.org/jdk17u-dev/pull/3170 From duke at openjdk.org Thu Dec 26 14:49:39 2024 From: duke at openjdk.org (duke) Date: Thu, 26 Dec 2024 14:49:39 GMT Subject: [jdk17u-dev] Withdrawn: 8273979: move some os time related functions to os_posix for POSIX platforms In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 15:29:20 GMT, Radim Vansa wrote: > Hi all, > > This pull request contains a backport of commit[ 1c6fa113](https://github.com/openjdk/jdk/commit/1c6fa113bd06585945e077f0d2004a291c27946d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 23 Sep 2021 and was reviewed by David Holmes and Lutz Schmidt. > > The backport applies cleanly, was created by the /backport command. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2831 From fyang at openjdk.org Thu Dec 26 15:03:41 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 26 Dec 2024 15:03:41 GMT Subject: [jdk23u] RFR: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing In-Reply-To: <2ae2lcw7nezGeg4_ShP6mPMK64J08kVWADgZ2jZ6ECY=.921f1b00-16a3-47fd-ac38-ef23e90dca39@github.com> References: <2ae2lcw7nezGeg4_ShP6mPMK64J08kVWADgZ2jZ6ECY=.921f1b00-16a3-47fd-ac38-ef23e90dca39@github.com> Message-ID: On Thu, 31 Oct 2024 03:10:39 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [239d84a8](https://github.com/openjdk/jdk/commit/239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 21 Oct 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson. > > Thanks! keep alive ------------- PR Comment: https://git.openjdk.org/jdk23u/pull/212#issuecomment-2562867845 From syan at openjdk.org Fri Dec 27 01:53:35 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 27 Dec 2024 01:53:35 GMT Subject: [jdk17u-dev] RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" In-Reply-To: <9Uet0EEQ6traXee9R1A4xkk7YdRU8uVCH-APa-bTkVE=.5294228f-4602-4fc9-ad7e-153bcbe174d9@github.com> References: <9Uet0EEQ6traXee9R1A4xkk7YdRU8uVCH-APa-bTkVE=.5294228f-4602-4fc9-ad7e-153bcbe174d9@github.com> Message-ID: On Thu, 26 Dec 2024 03:44:43 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [bdd96604](https://github.com/openjdk/jdk/commit/bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Change has been verified locally, test-fix only, no risk. > > The commit being backported was authored by Erik Gahlin on 21 Jun 2024 and was reviewed by Markus Gr?nlund. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3170#issuecomment-2563227331 From syan at openjdk.org Fri Dec 27 01:53:36 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 27 Dec 2024 01:53:36 GMT Subject: [jdk17u-dev] Integrated: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" In-Reply-To: <9Uet0EEQ6traXee9R1A4xkk7YdRU8uVCH-APa-bTkVE=.5294228f-4602-4fc9-ad7e-153bcbe174d9@github.com> References: <9Uet0EEQ6traXee9R1A4xkk7YdRU8uVCH-APa-bTkVE=.5294228f-4602-4fc9-ad7e-153bcbe174d9@github.com> Message-ID: On Thu, 26 Dec 2024 03:44:43 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [bdd96604](https://github.com/openjdk/jdk/commit/bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Change has been verified locally, test-fix only, no risk. > > The commit being backported was authored by Erik Gahlin on 21 Jun 2024 and was reviewed by Markus Gr?nlund. > > Thanks! This pull request has now been integrated. Changeset: a266ca03 Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/a266ca03fec4d610dba45bada26ee31cd4564a87 Stats: 37 lines in 1 file changed: 16 ins; 0 del; 21 mod 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" Backport-of: bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3170 From syan at openjdk.org Fri Dec 27 01:56:42 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 27 Dec 2024 01:56:42 GMT Subject: [jdk21u-dev] RFR: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null' In-Reply-To: <6yCLNOM_MnH1C1IO4p8DslaX36Z15ky3Ae24G_Y_FOg=.0f00c09a-965c-4b5b-ba80-8c208b4853b7@github.com> References: <6yCLNOM_MnH1C1IO4p8DslaX36Z15ky3Ae24G_Y_FOg=.0f00c09a-965c-4b5b-ba80-8c208b4853b7@github.com> Message-ID: On Wed, 18 Dec 2024 06:59:14 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [ea50c54a](https://github.com/openjdk/jdk/commit/ea50c54a14d39fcedabe8426a14eaec27ab24af2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by David Holmes on 18 Dec 2024 and was reviewed by Leonid Mesnik and Hamlin Li. > > Thanks! Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1254#issuecomment-2563228661 From syan at openjdk.org Fri Dec 27 01:56:42 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 27 Dec 2024 01:56:42 GMT Subject: [jdk21u-dev] Integrated: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null' In-Reply-To: <6yCLNOM_MnH1C1IO4p8DslaX36Z15ky3Ae24G_Y_FOg=.0f00c09a-965c-4b5b-ba80-8c208b4853b7@github.com> References: <6yCLNOM_MnH1C1IO4p8DslaX36Z15ky3Ae24G_Y_FOg=.0f00c09a-965c-4b5b-ba80-8c208b4853b7@github.com> Message-ID: On Wed, 18 Dec 2024 06:59:14 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [ea50c54a](https://github.com/openjdk/jdk/commit/ea50c54a14d39fcedabe8426a14eaec27ab24af2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by David Holmes on 18 Dec 2024 and was reviewed by Leonid Mesnik and Hamlin Li. > > Thanks! This pull request has now been integrated. Changeset: d4c5d69b Author: SendaoYan URL: https://git.openjdk.org/jdk21u-dev/commit/d4c5d69be143d19c7a432bf7533609a2730c7c07 Stats: 53 lines in 9 files changed: 45 ins; 0 del; 8 mod 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null' Backport-of: ea50c54a14d39fcedabe8426a14eaec27ab24af2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1254 From goetz at openjdk.org Fri Dec 27 09:49:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 09:49:35 GMT Subject: [jdk21u-dev] RFR: 8315825: Open some swing tests In-Reply-To: References: Message-ID: On Wed, 25 Dec 2024 16:46:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle GHA failure: three times wget issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1291#issuecomment-2563518512 From goetz at openjdk.org Fri Dec 27 09:50:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 09:50:37 GMT Subject: [jdk21u-dev] RFR: 8313905: Checked_cast assert in CDS compare_by_loader In-Reply-To: References: Message-ID: On Wed, 25 Dec 2024 16:32:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > Resolved because "8313564: Fix -Wconversion warnings in classfile code" is not in 21. > Probably clean anyways. GHA failure: twice wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1290#issuecomment-2563519105 From goetz at openjdk.org Fri Dec 27 09:50:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 09:50:44 GMT Subject: [jdk21u-dev] RFR: 8304701: Request with timeout aborts later in-flight request on HTTP/1.1 cxn In-Reply-To: References: Message-ID: On Tue, 24 Dec 2024 13:55:03 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 21. GHA failure: twice wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1289#issuecomment-2563519560 From goetz at openjdk.org Fri Dec 27 10:04:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 10:04:45 GMT Subject: [jdk21u-dev] Integrated: 8339883: Open source several AWT/2D related tests In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 16:00:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 2f899541 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2f8995412a6d33c69e48e5d83dd7ab6dee0bda71 Stats: 315 lines in 4 files changed: 315 ins; 0 del; 0 mod 8339883: Open source several AWT/2D related tests Backport-of: b26645f64bb6dd3efafaceb92bedeaf8f93906e3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1288 From goetz at openjdk.org Fri Dec 27 10:06:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 10:06:36 GMT Subject: [jdk21u-dev] Integrated: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 14:38:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > Resolved Copyright, probably clean anyways. This pull request has now been integrated. Changeset: 4474fbca Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/4474fbca98cbd9d7b250b2754f4a8d70ef5d6847 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only Backport-of: 7133d1b983d7b85ba3c8dde26eb654c7ab695b07 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1286 From goetz at openjdk.org Fri Dec 27 10:06:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 10:06:45 GMT Subject: [jdk17u-dev] Integrated: 8319567: Update java/lang/invoke tests to support vm flags In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 14:03:30 GMT, Goetz Lindenmaier wrote: > This change did not apply well. I needed the following adaptions: > > > test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java > is missing in 17. It was added by "8266310: deadlock between System.loadLibrary and JNI FindClass loading another class" > in 18. Skipped. > > Resolved test/jdk/java/lang/invoke/lambda/LambdaAccessControlTest.java > bacause "8284209: Replace remaining usages of 'a the' in source code" not in 17. > > test/jdk/java/lang/invoke/lambda/LambdaAsm.java > resolved because > 8292914: Lambda proxies have unstable names > and 8304846: Provide a shared utility to dump generated classes defined via Lookup API > not in 17 > > I needed to keep one of the removed imports. > > test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java > This needed an extensive resolve. > 8304846: Provide a shared utility to dump generated classes defined via Lookup API > and > 8307944: ClassFileDumper should only load java.nio.file.Path if enabled > not in 17. > > I had to rework this test significantly. > > The test assures that a property works that makes the VM dump > lambda classes it has generated. This mechanism has changed between 17 and 21. > E.g., the property name is different. Also, 17 needs to be passed > a directory name, 21 has a default name for this directory. > Some error cases are handled differently, sometimes a bug > is reported where the other implementation continues silently. > > I try to take over the test structure of the test in 21, > but I adapt it to test for the same VM behaviour the old > test in 17 did. > > The new test compiles the test class to subdirectory "classes/" > where the old test compiled them to ".". > Also, the new test places all dumped lambda classes in > DUMP_LAMBDA_PROXY_CLASS_FILES that is generated in the > working directory, where the old test wrote them directly > into the working directory. > > test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > resolved as > 8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack > and > 8300139 [AIX] Use pthreads to avoid JNI_createVM call from primordial thread > not in 17 This pull request has now been integrated. Changeset: 743724ef Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/743724ef7262f3e0bec8f031f7eeaa4e1e4dda78 Stats: 550 lines in 16 files changed: 114 ins; 287 del; 149 mod 8319567: Update java/lang/invoke tests to support vm flags 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags 8319672: Several classloader tests ignore VM flags 8319676: A couple of jdk/modules/incubator/ tests ignore VM flags 8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless Reviewed-by: mdoerr Backport-of: 1588dd934ce4e00a060e329b80f721d894559597 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3153 From goetz at openjdk.org Fri Dec 27 10:07:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 10:07:36 GMT Subject: [jdk21u-dev] Integrated: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 15:35:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: 8a5bbfeb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/8a5bbfebfa055e2ac28d62a43ffa80a2afd033b2 Stats: 67 lines in 6 files changed: 47 ins; 12 del; 8 mod 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor Backport-of: 965aace297154ab08ee41a4d988553707cae8b32 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1287 From goetz at openjdk.org Fri Dec 27 10:13:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 10:13:39 GMT Subject: [jdk17u-dev] Integrated: 8339883: Open source several AWT/2D related tests In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 16:00:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 6ef13abb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6ef13abbb85221ff8b069bb0fda89241237d19c4 Stats: 315 lines in 4 files changed: 315 ins; 0 del; 0 mod 8339883: Open source several AWT/2D related tests Backport-of: b26645f64bb6dd3efafaceb92bedeaf8f93906e3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3166 From goetz at openjdk.org Fri Dec 27 10:16:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 10:16:42 GMT Subject: [jdk17u-dev] Integrated: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 14:35:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > 17 has the same issue. > > Resolved Copyright, probably clean anyways. This pull request has now been integrated. Changeset: ac222190 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ac2221902be1a41b4b904a92901b5e388442d7d3 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only Backport-of: 7133d1b983d7b85ba3c8dde26eb654c7ab695b07 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3165 From goetz at openjdk.org Fri Dec 27 10:48:19 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 10:48:19 GMT Subject: [jdk21u-dev] RFR: 8337660: C2: basic blocks with only BoxLock nodes are wrongly treated as empty Message-ID: I backport this for parity with 21.0.7-oracle I had to adapt the flags in the run command of the test, as the locking mode is experimental in 21: Error: VM option 'LockingMode' is experimental and must be enabled via -XX:+UnlockExperimentalVMOptions. Error: The unlock option must precede 'LockingMode'. Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ------------- Commit messages: - Backport 0105203575182e24a56a38a12da7c1af58ea0a78 Changes: https://git.openjdk.org/jdk21u-dev/pull/1293/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1293&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337660 Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1293.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1293/head:pull/1293 PR: https://git.openjdk.org/jdk21u-dev/pull/1293 From goetz at openjdk.org Fri Dec 27 11:16:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 11:16:42 GMT Subject: [jdk21u-dev] RFR: 8336942: Improve test coverage for class loading elements with annotations of different retentions [v2] In-Reply-To: <-GpE48HyNqpwoLxkfy6PqCi7eXyEGXi546I6JlxSh2A=.83ac459b-8141-4f8e-9c66-3df9ae122724@github.com> References: <1A8Pjqodey4brM-cndhW3u6TUyNDzospAEl8UmaGdN0=.8536dd69-12ea-445b-8fae-35ae640f02cb@github.com> <-GpE48HyNqpwoLxkfy6PqCi7eXyEGXi546I6JlxSh2A=.83ac459b-8141-4f8e-9c66-3df9ae122724@github.com> Message-ID: On Thu, 5 Dec 2024 16:22:52 GMT, Liam Miller-Cushon wrote: >> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into backport-JDK-8336942 >> - 8336942: Improve test coverage for class loading elements with annotations of different retentions >> >> Reviewed-by: vromero > >> Feel free to ask for assistance if you need help with progressing this pull request towards integration! > > Assistance progressing this pull request towards integration is welcome Hi @cushon , this backport looks good to me, and there is a fix-request comment, but the label is missing... ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1037#issuecomment-2563593440 From mdoerr at openjdk.org Fri Dec 27 11:37:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 27 Dec 2024 11:37:36 GMT Subject: [jdk21u-dev] RFR: 8313905: Checked_cast assert in CDS compare_by_loader In-Reply-To: References: Message-ID: On Wed, 25 Dec 2024 16:32:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > Resolved because "8313564: Fix -Wconversion warnings in classfile code" is not in 21. > Probably clean anyways. LGTM. Only the removed code differs because of different casts. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1290#pullrequestreview-2523982561 From goetz at openjdk.org Fri Dec 27 11:39:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 11:39:25 GMT Subject: [jdk17u-dev] RFR: 8315882: Open some swing tests 2 Message-ID: <9CCJ9aPgvLZh1XmEx_W_mpZcumdCAXse4rWIfXY-s8E=.63da4f57-0703-4d7b-aa6b-b640bb586417@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport d2d7d9a8b7c68865553dcbb4d660bbb06fde3974 Changes: https://git.openjdk.org/jdk17u-dev/pull/3171/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3171&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315882 Stats: 228 lines in 3 files changed: 228 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3171.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3171/head:pull/3171 PR: https://git.openjdk.org/jdk17u-dev/pull/3171 From goetz at openjdk.org Fri Dec 27 11:42:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 11:42:23 GMT Subject: [jdk17u-dev] RFR: 8316218: Open some swing tests 5 Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 788e6e154824317cf92884510c2ee116bc64f510 Changes: https://git.openjdk.org/jdk17u-dev/pull/3172/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3172&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316218 Stats: 262 lines in 4 files changed: 262 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3172.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3172/head:pull/3172 PR: https://git.openjdk.org/jdk17u-dev/pull/3172 From goetz at openjdk.org Fri Dec 27 11:44:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 11:44:23 GMT Subject: [jdk17u-dev] RFR: 8316371: Open some swing tests 6 Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport d3a79b5861be27227b8c28cb3acdce089b74c50b Changes: https://git.openjdk.org/jdk17u-dev/pull/3173/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3173&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316371 Stats: 569 lines in 5 files changed: 569 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3173.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3173/head:pull/3173 PR: https://git.openjdk.org/jdk17u-dev/pull/3173 From mdoerr at openjdk.org Fri Dec 27 11:45:43 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 27 Dec 2024 11:45:43 GMT Subject: [jdk21u-dev] RFR: 8340313: Crash due to invalid oop in nmethod after C1 patching In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 09:45:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > I had to do trivial resolves: > > src/hotspot/cpu/riscv/nativeInst_riscv.cpp > The first lock to be changed already uses CodeCache_lock. > > src/hotspot/share/runtime/mutexLocker.cpp/hpp > Resolved due to context LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1284#pullrequestreview-2523988373 From goetz at openjdk.org Fri Dec 27 11:49:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 11:49:59 GMT Subject: [jdk17u-dev] RFR: 8316146: Open some swing tests 4 Message-ID: <_gBJEoV_UT1mRCtuRrP1oJjHQz0USm51NbRgsv0-fjw=.2570ec74-a39d-4bee-9f05-2c39e6c928db@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport 3105538de5569845547b40f243a994a95a84b48f Changes: https://git.openjdk.org/jdk17u-dev/pull/3174/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3174&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316146 Stats: 311 lines in 4 files changed: 311 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3174.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3174/head:pull/3174 PR: https://git.openjdk.org/jdk17u-dev/pull/3174 From duke at openjdk.org Fri Dec 27 11:58:39 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 27 Dec 2024 11:58:39 GMT Subject: [jdk17u-dev] Integrated: 8341424: GHA: Collect hs_errs from build time failures In-Reply-To: References: Message-ID: On Thu, 19 Dec 2024 12:02:17 GMT, Antonio Vieiro wrote: > Backport of [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424) and companion [JDK-8342704](https://bugs.openjdk.org/browse/JDK-8342704) > > This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to 11 too. > > Low risk, as this affects GHA actions only. GHA builds and tests run correctly. This pull request has now been integrated. Changeset: 3bc06ab8 Author: Antonio Vieiro Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/3bc06ab80f09b57dc10b182d9bc1ab1584cf6706 Stats: 81 lines in 3 files changed: 67 ins; 14 del; 0 mod 8341424: GHA: Collect hs_errs from build time failures 8342704: GHA: Report truncation is broken after JDK-8341424 Backport-of: 0011704ec813414bfe71d7232882a1d03c362b48 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3152 From goetz at openjdk.org Fri Dec 27 12:01:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 12:01:15 GMT Subject: [jdk21u-dev] RFR: 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java Message-ID: I backport this for parity with 21.0.7-oracle. ------------- Commit messages: - Backport b1b4cd429a4135840966975dd0c068fe428e2ee6 Changes: https://git.openjdk.org/jdk21u-dev/pull/1294/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1294&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332158 Stats: 15 lines in 2 files changed: 10 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1294.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1294/head:pull/1294 PR: https://git.openjdk.org/jdk21u-dev/pull/1294 From goetz at openjdk.org Fri Dec 27 12:02:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 12:02:30 GMT Subject: [jdk17u-dev] RFR: 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport b1b4cd429a4135840966975dd0c068fe428e2ee6 Changes: https://git.openjdk.org/jdk17u-dev/pull/3175/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3175&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332158 Stats: 15 lines in 2 files changed: 10 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3175.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3175/head:pull/3175 PR: https://git.openjdk.org/jdk17u-dev/pull/3175 From goetz at openjdk.org Fri Dec 27 12:25:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 12:25:21 GMT Subject: [jdk17u-dev] RFR: 8343101: Rework BasicTest.testTemp test cases Message-ID: I backport this for parity with 17.0.15-oracle. This is based on the commit to 21. I needed to resolve again, though: https://bugs.openjdk.org/browse/JDK-8291978: jpackage: allow to override primary l10n files on Windows is not in 17. I include some of the edits of 8291978 in this change, as they nicely clean up the code. ------------- Commit messages: - Backport fe9284a8c523bc747e107836c85114864efab2a1 Changes: https://git.openjdk.org/jdk17u-dev/pull/3176/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3176&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343101 Stats: 101 lines in 3 files changed: 52 ins; 32 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3176.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3176/head:pull/3176 PR: https://git.openjdk.org/jdk17u-dev/pull/3176 From goetz at openjdk.org Fri Dec 27 12:29:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 27 Dec 2024 12:29:36 GMT Subject: [jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner In-Reply-To: References: Message-ID: On Sun, 22 Dec 2024 10:46:58 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 17. I think it's important to get this feature rigtht. > > I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean. This parses the -J$java.classes I added above. It replaces it by -J/path/to/jtreg/workdir/classes/0/sun/security/tools/jarsigner/AutoKeyStore.d I think this is a bit of exagerated gymnastics to be able to use plain """ strings in the test. But as the original test introduced this $test.classes syntax I thought I better keep it that way. I coudl add to the docu above that it now supports {https://github.com/code -J$sysProp}. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3163#issuecomment-2563654790 From syan at openjdk.org Fri Dec 27 12:33:39 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 27 Dec 2024 12:33:39 GMT Subject: [jdk17u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 09:06:27 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [c7c7280f](https://github.com/openjdk/jdk21u-dev/commit/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 21 Dec 2024 and was reviewed by Severin Gehwolf, Goetz Lindenmaier and Paul Hohensee. > > Thanks! Thanks all for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3159#issuecomment-2563656572 From syan at openjdk.org Fri Dec 27 12:33:40 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 27 Dec 2024 12:33:40 GMT Subject: [jdk17u-dev] Integrated: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 09:06:27 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [c7c7280f](https://github.com/openjdk/jdk21u-dev/commit/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by SendaoYan on 21 Dec 2024 and was reviewed by Severin Gehwolf, Goetz Lindenmaier and Paul Hohensee. > > Thanks! This pull request has now been integrated. Changeset: 81d7b70c Author: SendaoYan URL: https://git.openjdk.org/jdk17u-dev/commit/81d7b70c5d01d459d2bf4a3934d46ae2aff83a67 Stats: 135 lines in 3 files changed: 116 ins; 8 del; 11 mod 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 8342145: File libCreationTimeHelper.c compile fails on Alpine Backport-of: c7c7280f6e25fb68950bad93aa20a96cfc9f35b3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3159 From mdoerr at openjdk.org Fri Dec 27 12:36:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 27 Dec 2024 12:36:36 GMT Subject: [jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner In-Reply-To: References: Message-ID: On Sun, 22 Dec 2024 10:46:58 GMT, Goetz Lindenmaier wrote: > I would like to fix this issue in 17. I think it's important to get this feature rigtht. > > I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean. I think this is ok. Yes, adding it the the docs would be nice. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3163#issuecomment-2563659785 From mdoerr at openjdk.org Fri Dec 27 18:39:49 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 27 Dec 2024 18:39:49 GMT Subject: [jdk21u-dev] RFR: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats Message-ID: Almost clean backport of [JDK-8345146](https://bugs.openjdk.org/browse/JDK-8345146). Two hunks had to be integrated manually due to unrelated differences in the context. The test updates had to be integrated manually because the RISCV part is not backported. ------------- Commit messages: - Backport b42d79eb6a6d497dc63718c2854609bebca4498c Changes: https://git.openjdk.org/jdk21u-dev/pull/1295/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1295&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345146 Stats: 181 lines in 14 files changed: 178 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1295.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1295/head:pull/1295 PR: https://git.openjdk.org/jdk21u-dev/pull/1295 From mdoerr at openjdk.org Fri Dec 27 19:38:38 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 27 Dec 2024 19:38:38 GMT Subject: [jdk17u-dev] RFR: 8314610: hotspot can't compile with the latest of gtest because of In-Reply-To: <_DaWIQJpWtTrcrT4QsAb4BIS2QR_uu7MA_mCPB0IYOI=.646e8ec4-9c4d-4f53-9fd5-2e5bb8a9bc8c@github.com> References: <_DaWIQJpWtTrcrT4QsAb4BIS2QR_uu7MA_mCPB0IYOI=.646e8ec4-9c4d-4f53-9fd5-2e5bb8a9bc8c@github.com> Message-ID: On Mon, 14 Oct 2024 10:12:47 GMT, Sorna Sarathi N wrote: > Hi all, > This pull request contains a backport of commit [febc34d](https://github.com/openjdk/jdk/commit/febc34dd285c3382716e068748d4a3b0c73d87ad) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > Tier1 testing is successful. > Thanks! > > JBS Issue: [JDK-8314610](https://bugs.openjdk.org/browse/JDK-8314610) Regarding the GHA failures, I have only seen the "xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer'" issue which has been resolved by https://github.com/openjdk/jdk17u-dev/commit/82a609dd7841eab66866e785ddd035b55d441970. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2959#issuecomment-2563977737 From goetz at openjdk.org Sun Dec 29 13:57:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 29 Dec 2024 13:57:55 GMT Subject: [jdk17u-dev] RFR: 8316218: Open some swing tests 5 In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 11:37:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3172#issuecomment-2564733054 From goetz at openjdk.org Sun Dec 29 13:58:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 29 Dec 2024 13:58:00 GMT Subject: [jdk17u-dev] RFR: 8315882: Open some swing tests 2 In-Reply-To: <9CCJ9aPgvLZh1XmEx_W_mpZcumdCAXse4rWIfXY-s8E=.63da4f57-0703-4d7b-aa6b-b640bb586417@github.com> References: <9CCJ9aPgvLZh1XmEx_W_mpZcumdCAXse4rWIfXY-s8E=.63da4f57-0703-4d7b-aa6b-b640bb586417@github.com> Message-ID: On Fri, 27 Dec 2024 11:33:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3171#issuecomment-2564733125 From goetz at openjdk.org Sun Dec 29 13:58:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 29 Dec 2024 13:58:50 GMT Subject: [jdk21u-dev] RFR: 8337660: C2: basic blocks with only BoxLock nodes are wrongly treated as empty In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 10:43:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle > > I had to adapt the flags in the run command of the test, > as the locking mode is experimental in 21: > > Error: VM option 'LockingMode' is experimental and must be enabled via -XX:+UnlockExperimentalVMOptions. > Error: The unlock option must precede 'LockingMode'. > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. GHA failure: well known wget issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1293#issuecomment-2564733187 From goetz at openjdk.org Sun Dec 29 14:02:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 29 Dec 2024 14:02:33 GMT Subject: [jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner [v2] In-Reply-To: References: Message-ID: > I would like to fix this issue in 17. I think it's important to get this feature rigtht. > > I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Improve documentation in test helper class. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3163/files - new: https://git.openjdk.org/jdk17u-dev/pull/3163/files/483781c0..48f4809c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3163&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3163&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3163.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3163/head:pull/3163 PR: https://git.openjdk.org/jdk17u-dev/pull/3163 From goetz at openjdk.org Sun Dec 29 14:10:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 29 Dec 2024 14:10:31 GMT Subject: [jdk21u-dev] RFR: 8337660: C2: basic blocks with only BoxLock nodes are wrongly treated as empty [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.7-oracle > > I had to adapt the flags in the run command of the test, > as the locking mode is experimental in 21: > > Error: VM option 'LockingMode' is experimental and must be enabled via -XX:+UnlockExperimentalVMOptions. > Error: The unlock option must precede 'LockingMode'. > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 0105203575182e24a56a38a12da7c1af58ea0a78 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1293/files - new: https://git.openjdk.org/jdk21u-dev/pull/1293/files/795036dc..f3a1011e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1293&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1293&range=00-01 Stats: 87 lines in 1 file changed: 87 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1293.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1293/head:pull/1293 PR: https://git.openjdk.org/jdk21u-dev/pull/1293 From amitkumar at openjdk.org Mon Dec 30 04:48:48 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 30 Dec 2024 04:48:48 GMT Subject: [jdk21u-dev] RFR: 8346847: [s390x] minimal build failure Message-ID: Hi all, This pull request contains a backport of commit [807f6f7f](https://github.com/openjdk/jdk/commit/807f6f7fb868240cba5ba117c7059216f69a53f9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 27 Dec 2024 and was reviewed by Thomas Stuefe. Thanks! ------------- Commit messages: - Backport 807f6f7fb868240cba5ba117c7059216f69a53f9 Changes: https://git.openjdk.org/jdk21u-dev/pull/1296/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1296&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346847 Stats: 12 lines in 1 file changed: 6 ins; 6 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1296.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1296/head:pull/1296 PR: https://git.openjdk.org/jdk21u-dev/pull/1296 From amitkumar at openjdk.org Mon Dec 30 04:51:12 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 30 Dec 2024 04:51:12 GMT Subject: [jdk24u] RFR: 8346847: [s390x] minimal build failure Message-ID: Hi all, This pull request contains a backport of commit [807f6f7f](https://github.com/openjdk/jdk/commit/807f6f7fb868240cba5ba117c7059216f69a53f9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 27 Dec 2024 and was reviewed by Thomas Stuefe. Thanks! ------------- Commit messages: - Backport 807f6f7fb868240cba5ba117c7059216f69a53f9 Changes: https://git.openjdk.org/jdk24u/pull/9/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=9&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346847 Stats: 12 lines in 1 file changed: 6 ins; 6 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/9.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/9/head:pull/9 PR: https://git.openjdk.org/jdk24u/pull/9 From mbaesken at openjdk.org Mon Dec 30 09:14:43 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 30 Dec 2024 09:14:43 GMT Subject: [jdk24u] RFR: 8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test Message-ID: 8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test ------------- Commit messages: - Backport 60e0730a3ba26180d0eb2cd278e389c3e70fec5f Changes: https://git.openjdk.org/jdk24u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346712 Stats: 145 lines in 1 file changed: 0 ins; 145 del; 0 mod Patch: https://git.openjdk.org/jdk24u/pull/10.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/10/head:pull/10 PR: https://git.openjdk.org/jdk24u/pull/10 From mbaesken at openjdk.org Mon Dec 30 09:29:43 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 30 Dec 2024 09:29:43 GMT Subject: [jdk21u-dev] RFR: 8337660: C2: basic blocks with only BoxLock nodes are wrongly treated as empty [v2] In-Reply-To: References: Message-ID: On Sun, 29 Dec 2024 14:10:31 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.7-oracle >> >> I had to adapt the flags in the run command of the test, >> as the locking mode is experimental in 21: >> >> Error: VM option 'LockingMode' is experimental and must be enabled via -XX:+UnlockExperimentalVMOptions. >> Error: The unlock option must precede 'LockingMode'. >> Error: Could not create the Java Virtual Machine. >> Error: A fatal exception has occurred. Program will exit. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 0105203575182e24a56a38a12da7c1af58ea0a78 Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1293#pullrequestreview-2525366808 From mdoerr at openjdk.org Mon Dec 30 09:33:48 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 30 Dec 2024 09:33:48 GMT Subject: [jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner [v2] In-Reply-To: References: Message-ID: On Sun, 29 Dec 2024 14:02:33 GMT, Goetz Lindenmaier wrote: >> I would like to fix this issue in 17. I think it's important to get this feature rigtht. >> >> I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Improve documentation in test helper class. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3163#pullrequestreview-2525370385 From mdoerr at openjdk.org Mon Dec 30 09:54:44 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 30 Dec 2024 09:54:44 GMT Subject: [jdk17u-dev] RFR: 8343101: Rework BasicTest.testTemp test cases In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 12:20:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. > > This is based on the commit to 21. I needed to resolve again, though: > https://bugs.openjdk.org/browse/JDK-8291978: jpackage: allow to override primary l10n files on Windows is not in 17. > > I include some of the edits of 8291978 in this change, as they nicely clean up the test code. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3176#pullrequestreview-2525390629 From goetz at openjdk.org Mon Dec 30 10:14:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 10:14:22 GMT Subject: [jdk17u-dev] RFR: 8283387: [macos] a11y : Screen magnifier does not show selected Tab Message-ID: <98l-INXQ4mIEwE_insPJYVdCCrUmIl6Afb42AUCqvyA=.497fc953-1a39-4234-99c0-7d26ab6f4da2@github.com> I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport d5cd4a3a28a85bbcaa3c0c7f2e74e0684b5efcab Changes: https://git.openjdk.org/jdk17u-dev/pull/3178/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3178&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283387 Stats: 113 lines in 2 files changed: 110 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3178.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3178/head:pull/3178 PR: https://git.openjdk.org/jdk17u-dev/pull/3178 From amitkumar at openjdk.org Mon Dec 30 10:14:35 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 30 Dec 2024 10:14:35 GMT Subject: [jdk24u] Withdrawn: 8346847: [s390x] minimal build failure In-Reply-To: References: Message-ID: On Mon, 30 Dec 2024 04:46:11 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [807f6f7f](https://github.com/openjdk/jdk/commit/807f6f7fb868240cba5ba117c7059216f69a53f9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 27 Dec 2024 and was reviewed by Thomas Stuefe. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/9 From syan at openjdk.org Mon Dec 30 12:04:15 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 30 Dec 2024 12:04:15 GMT Subject: [jdk21u-dev] RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr Message-ID: <6sfsbX0oVzKjmf6Izgn8XiE_bCwIZYDQzhn1fBZLgrE=.01bcdf8b-dab3-46ae-a484-89f3ce9c848a@github.com> Hi all, This pull request contains a backport of commit [f5ab7dff](https://github.com/openjdk/jdk/commit/f5ab7dff402a3152f5d5736cc6521b4be617eccf) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring deprecated warnings. Test-fix only, the change has been verified locally, no risk. The commit being backported was authored by Axel Boldt-Christmas on 21 May 2024 and was reviewed by Jaikiran Pai, Stefan Karlsson and David Holmes. Thanks! ------------- Commit messages: - Backport f5ab7dff402a3152f5d5736cc6521b4be617eccf Changes: https://git.openjdk.org/jdk21u-dev/pull/1297/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1297&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332494 Stats: 21 lines in 2 files changed: 18 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1297.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1297/head:pull/1297 PR: https://git.openjdk.org/jdk21u-dev/pull/1297 From mbaesken at openjdk.org Mon Dec 30 13:15:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 30 Dec 2024 13:15:31 GMT Subject: [jdk17u-dev] RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang Message-ID: Backport of 8341722 from 21u-dev; symtab.c coding needed manual adjustment; os_linux part of commit not in 17 ------------- Commit messages: - Backport 3aa59b3139d6ca88afb4339510b0a47ec15c8959 Changes: https://git.openjdk.org/jdk17u-dev/pull/3179/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3179&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341722 Stats: 8 lines in 3 files changed: 1 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3179.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3179/head:pull/3179 PR: https://git.openjdk.org/jdk17u-dev/pull/3179 From mdoerr at openjdk.org Mon Dec 30 13:52:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 30 Dec 2024 13:52:36 GMT Subject: [jdk17u-dev] RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang In-Reply-To: References: Message-ID: On Mon, 30 Dec 2024 13:10:12 GMT, Matthias Baesken wrote: > Backport of 8341722 from 21u-dev; symtab.c coding needed manual adjustment; os_linux part of commit not in 17 LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3179#pullrequestreview-2525608680 From goetz at openjdk.org Mon Dec 30 22:26:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:26:42 GMT Subject: [jdk21u-dev] Integrated: 8313905: Checked_cast assert in CDS compare_by_loader In-Reply-To: References: Message-ID: On Wed, 25 Dec 2024 16:32:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > Resolved because "8313564: Fix -Wconversion warnings in classfile code" is not in 21. > Probably clean anyways. This pull request has now been integrated. Changeset: 3b8d404d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/3b8d404da205a4396ede6dc76a3a51b9e5c75eb5 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod 8313905: Checked_cast assert in CDS compare_by_loader Reviewed-by: mdoerr Backport-of: bd1b9427410c458215e9e89eeff6e4d30592a4a4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1290 From goetz at openjdk.org Mon Dec 30 22:28:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:28:46 GMT Subject: [jdk17u-dev] Integrated: 8315825: Open some swing tests In-Reply-To: <3Hxa-L7X325DaehG5LPf-jlFxz0hEDOuYrgon2vqR9U=.66a1a8b4-82fa-49e4-900b-90ea0fa4da1f@github.com> References: <3Hxa-L7X325DaehG5LPf-jlFxz0hEDOuYrgon2vqR9U=.66a1a8b4-82fa-49e4-900b-90ea0fa4da1f@github.com> Message-ID: On Wed, 25 Dec 2024 16:46:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 487b9a59 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/487b9a594038d81cff2916d6e7fdc9b51c7986b2 Stats: 449 lines in 4 files changed: 449 ins; 0 del; 0 mod 8315825: Open some swing tests Backport-of: e015e6ce28e263e546cd1b6583a4a3ecc431d576 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3168 From goetz at openjdk.org Mon Dec 30 22:30:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:30:42 GMT Subject: [jdk21u-dev] Integrated: 8315825: Open some swing tests In-Reply-To: References: Message-ID: On Wed, 25 Dec 2024 16:46:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle This pull request has now been integrated. Changeset: cf360526 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/cf36052692be8eb78c60ab0af44cdadd98ebe488 Stats: 449 lines in 4 files changed: 449 ins; 0 del; 0 mod 8315825: Open some swing tests Backport-of: e015e6ce28e263e546cd1b6583a4a3ecc431d576 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1291 From goetz at openjdk.org Mon Dec 30 22:30:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:30:43 GMT Subject: [jdk17u-dev] Integrated: 8315882: Open some swing tests 2 In-Reply-To: <9CCJ9aPgvLZh1XmEx_W_mpZcumdCAXse4rWIfXY-s8E=.63da4f57-0703-4d7b-aa6b-b640bb586417@github.com> References: <9CCJ9aPgvLZh1XmEx_W_mpZcumdCAXse4rWIfXY-s8E=.63da4f57-0703-4d7b-aa6b-b640bb586417@github.com> Message-ID: On Fri, 27 Dec 2024 11:33:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 1d525cc9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1d525cc9f3060fe8a331098063171ec8e95a2eb6 Stats: 228 lines in 3 files changed: 228 ins; 0 del; 0 mod 8315882: Open some swing tests 2 Backport-of: d2d7d9a8b7c68865553dcbb4d660bbb06fde3974 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3171 From goetz at openjdk.org Mon Dec 30 22:32:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:32:36 GMT Subject: [jdk21u-dev] Integrated: 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 11:56:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: 60bf0398 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/60bf03982646c0486ed809186d3510d5700563c7 Stats: 15 lines in 2 files changed: 10 ins; 0 del; 5 mod 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java Backport-of: b1b4cd429a4135840966975dd0c068fe428e2ee6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1294 From goetz at openjdk.org Mon Dec 30 22:32:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:32:47 GMT Subject: [jdk17u-dev] Integrated: 8316218: Open some swing tests 5 In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 11:37:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 7625c826 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7625c82641700a2e33af8e4f53996e7580ee2def Stats: 262 lines in 4 files changed: 262 ins; 0 del; 0 mod 8316218: Open some swing tests 5 Backport-of: 788e6e154824317cf92884510c2ee116bc64f510 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3172 From goetz at openjdk.org Mon Dec 30 22:33:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:33:46 GMT Subject: [jdk17u-dev] Integrated: 8316371: Open some swing tests 6 In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 11:39:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 6f0f175b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6f0f175b395be2cf2ea8fddae1dfcbc7bb1d0bf4 Stats: 569 lines in 5 files changed: 569 ins; 0 del; 0 mod 8316371: Open some swing tests 6 Backport-of: d3a79b5861be27227b8c28cb3acdce089b74c50b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3173 From goetz at openjdk.org Mon Dec 30 22:34:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:34:46 GMT Subject: [jdk17u-dev] Integrated: 8316146: Open some swing tests 4 In-Reply-To: <_gBJEoV_UT1mRCtuRrP1oJjHQz0USm51NbRgsv0-fjw=.2570ec74-a39d-4bee-9f05-2c39e6c928db@github.com> References: <_gBJEoV_UT1mRCtuRrP1oJjHQz0USm51NbRgsv0-fjw=.2570ec74-a39d-4bee-9f05-2c39e6c928db@github.com> Message-ID: On Fri, 27 Dec 2024 11:45:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 2171eda5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2171eda5983417f9b38a5e9d0e99859bee94791c Stats: 311 lines in 4 files changed: 311 ins; 0 del; 0 mod 8316146: Open some swing tests 4 Backport-of: 3105538de5569845547b40f243a994a95a84b48f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3174 From goetz at openjdk.org Mon Dec 30 22:35:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:35:39 GMT Subject: [jdk21u-dev] Integrated: 8340313: Crash due to invalid oop in nmethod after C1 patching In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 09:45:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. > > I had to do trivial resolves: > > src/hotspot/cpu/riscv/nativeInst_riscv.cpp > The first lock to be changed already uses CodeCache_lock. > > src/hotspot/share/runtime/mutexLocker.cpp/hpp > Resolved due to context This pull request has now been integrated. Changeset: d9123307 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d912330772c537fc77854c6cd52d60185b1570fc Stats: 166 lines in 10 files changed: 145 ins; 7 del; 14 mod 8340313: Crash due to invalid oop in nmethod after C1 patching Reviewed-by: mdoerr Backport-of: 58d39c317e332fda994f66529fcd1a0ea0e53151 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1284 From goetz at openjdk.org Mon Dec 30 22:36:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:36:42 GMT Subject: [jdk17u-dev] Integrated: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main In-Reply-To: References: Message-ID: On Wed, 25 Dec 2024 16:54:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle This pull request has now been integrated. Changeset: 5adbdac1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5adbdac14d9980542002c52172c40fdf55d5696c Stats: 351 lines in 4 files changed: 108 ins; 243 del; 0 mod 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main Backport-of: ef2bd5721316f208a458fecfffa02ec2c0ea7fe0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3169 From goetz at openjdk.org Mon Dec 30 22:31:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:31:45 GMT Subject: [jdk21u-dev] Integrated: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main In-Reply-To: References: Message-ID: On Wed, 25 Dec 2024 16:54:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.7-oracle. This pull request has now been integrated. Changeset: ff7e1847 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ff7e18478a00f30da157420ad38ff23ddd16a2b3 Stats: 351 lines in 4 files changed: 108 ins; 243 del; 0 mod 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main Backport-of: ef2bd5721316f208a458fecfffa02ec2c0ea7fe0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1292 From goetz at openjdk.org Mon Dec 30 22:37:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 30 Dec 2024 22:37:36 GMT Subject: [jdk17u-dev] Integrated: 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java In-Reply-To: References: Message-ID: On Fri, 27 Dec 2024 11:56:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. This pull request has now been integrated. Changeset: 65fde365 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/65fde365263e0ec532c2ac2df406f59f711e4902 Stats: 15 lines in 2 files changed: 10 ins; 0 del; 5 mod 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java Backport-of: b1b4cd429a4135840966975dd0c068fe428e2ee6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3175 From srl at openjdk.org Tue Dec 31 05:18:47 2024 From: srl at openjdk.org (Steven Loomis) Date: Tue, 31 Dec 2024 05:18:47 GMT Subject: [jdk11u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v3] In-Reply-To: <-vkps507KhQ9HKpJ3Sw26fY_qopj7e8TbZruHr4R7u0=.ac422fce-bd04-4a76-a4d1-5d94f5f21361@github.com> References: <3j_Tqw92GYtmWFYtRJkbplIF1_KiA4VXBe9lt1dMvTc=.5f342d4c-074a-4b56-bb3d-8c93fc5a47d7@github.com> <-vkps507KhQ9HKpJ3Sw26fY_qopj7e8TbZruHr4R7u0=.ac422fce-bd04-4a76-a4d1-5d94f5f21361@github.com> Message-ID: On Mon, 4 Nov 2024 16:29:27 GMT, Steven Loomis wrote: >> @srl295 Could not automatically backport b8f2ec90 to openjdk/jdk11u-dev due to conflicts in the following files: >> >> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m >> Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know. >> >> # Fetch the up-to-date version of the target branch >> $ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master >> >> # Check out the target branch and create your own branch to backport >> $ git checkout master >> $ git checkout -b backport-srl295-b8f2ec90-master >> >> # Fetch the commit you want to backport >> $ git fetch --no-tags https://git.openjdk.org/jdk.git b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd >> >> # Backport the commit >> $ git cherry-pick --no-commit b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd >> # Resolve conflicts now >> >> # Commit the files you have modified >> $ git add files/with/resolved/conflicts >> $ git commit -m 'Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd' >> Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd. >> >> Below you can find a suggestion for the pull request body: >> >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> >> PR: https://github.com/openjdk/jdk/pull/17921 >> >> Thanks! > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - 8195675: merge from master > - 8195675: empty commit to trigger build > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd Ping.. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2954#issuecomment-2566139819 From goetz at openjdk.org Tue Dec 31 11:02:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 31 Dec 2024 11:02:20 GMT Subject: [jdk17u-dev] RFR: 8283404: [macos] a11y : Screen magnifier does not show JMenu name Message-ID: I backport this for parity with 17.0.15-oracle. ------------- Commit messages: - Backport ecec611af6c6314d7a834392f38468ad3f390e2d Changes: https://git.openjdk.org/jdk17u-dev/pull/3180/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3180&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283404 Stats: 112 lines in 2 files changed: 109 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3180.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3180/head:pull/3180 PR: https://git.openjdk.org/jdk17u-dev/pull/3180 From goetz at openjdk.org Tue Dec 31 11:10:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 31 Dec 2024 11:10:49 GMT Subject: [jdk17u-dev] RFR: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above Message-ID: I backport this for parity with 17.0.15-oracle. Resolved copyright, probably clean. ------------- Commit messages: - Backport 999e556be4302de4b6911e6d62ee5ca556a76469 Changes: https://git.openjdk.org/jdk17u-dev/pull/3181/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3181&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312518 Stats: 91 lines in 2 files changed: 90 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3181.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3181/head:pull/3181 PR: https://git.openjdk.org/jdk17u-dev/pull/3181 From goetz at openjdk.org Tue Dec 31 11:12:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 31 Dec 2024 11:12:57 GMT Subject: [jdk17u-dev] RFR: 8283387: [macos] a11y : Screen magnifier does not show selected Tab In-Reply-To: <98l-INXQ4mIEwE_insPJYVdCCrUmIl6Afb42AUCqvyA=.497fc953-1a39-4234-99c0-7d26ab6f4da2@github.com> References: <98l-INXQ4mIEwE_insPJYVdCCrUmIl6Afb42AUCqvyA=.497fc953-1a39-4234-99c0-7d26ab6f4da2@github.com> Message-ID: On Mon, 30 Dec 2024 10:08:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.15-oracle. GHA failure: wget issue, unrelated. As this change adresses mac, and it's just these test that failed, I'll restart the tests. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3178#issuecomment-2566354711 From goetz at openjdk.org Tue Dec 31 11:12:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 31 Dec 2024 11:12:57 GMT Subject: [jdk17u-dev] RFR: 8283387: [macos] a11y : Screen magnifier does not show selected Tab [v2] In-Reply-To: <98l-INXQ4mIEwE_insPJYVdCCrUmIl6Afb42AUCqvyA=.497fc953-1a39-4234-99c0-7d26ab6f4da2@github.com> References: <98l-INXQ4mIEwE_insPJYVdCCrUmIl6Afb42AUCqvyA=.497fc953-1a39-4234-99c0-7d26ab6f4da2@github.com> Message-ID: > I backport this for parity with 17.0.15-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-d5cd4a3a-master - Backport d5cd4a3a28a85bbcaa3c0c7f2e74e0684b5efcab ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3178/files - new: https://git.openjdk.org/jdk17u-dev/pull/3178/files/cec2aa17..1e08ebdb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3178&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3178&range=00-01 Stats: 2185 lines in 26 files changed: 1937 ins; 243 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3178.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3178/head:pull/3178 PR: https://git.openjdk.org/jdk17u-dev/pull/3178 From goetz at openjdk.org Tue Dec 31 11:56:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 31 Dec 2024 11:56:56 GMT Subject: [jdk21u-dev] RFR: 8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package Message-ID: I backport this to keep tests close to head. It will simplify future backports. Clean backport, but added some test funcionality of "8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package" to make BasicTest.java compile. Tests pass. 8344326 is not a good candidate to backport along with this, it's a real bug and rather fresh. ------------- Commit messages: - Backport 2c509a158fad63e69a8072fa4a7588eaacf37dc0 Changes: https://git.openjdk.org/jdk21u-dev/pull/1298/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1298&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344326 Stats: 211 lines in 23 files changed: 131 ins; 44 del; 36 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1298.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1298/head:pull/1298 PR: https://git.openjdk.org/jdk21u-dev/pull/1298 From duke at openjdk.org Tue Dec 31 13:29:41 2024 From: duke at openjdk.org (duke) Date: Tue, 31 Dec 2024 13:29:41 GMT Subject: [jdk23u] Withdrawn: 8341722: Fix some warnings as errors when building on Linux with toolchain clang In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 15:28:00 GMT, Matthias Baesken wrote: > Backport of 8341722, changes of Lib.gmk are not in 23u so I omit those; otherwise applied clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk23u/pull/213 From duke at openjdk.org Tue Dec 31 23:25:43 2024 From: duke at openjdk.org (duke) Date: Tue, 31 Dec 2024 23:25:43 GMT Subject: [jdk11u-dev] Withdrawn: 8301118: Ignore allow and disallow options for java.security.manager System Property In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 11:13:21 GMT, Dmitry Cherepanov wrote: > Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). > > The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11. > > New test fails without the change and passes with the change. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2932