[jdk21u-dev] RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v3]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Dec 2 09:45:48 UTC 2024
On Mon, 2 Dec 2024 09:32:12 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> Resolved SystemModulesPlugin.java due to context (ClassFile.of() <--> Classfile)
>>
>> The patch is based on the commit to 23, the version for 22/22.0.1 is identical.
>>
>> I can reproduce the error with the test, and the patch fixes the issue.
>>
>> I had to adapt the tests because "8317620: Build JDK tools with ModuleMainClass attribute" is missing in 21.
>> jdk.jfr has no main, so I exclude it from the tests.
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove commented module name
Marked as reviewed by sgehwolf (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk21u-dev/pull/1189#pullrequestreview-2472207172
More information about the jdk-updates-dev
mailing list