[jdk21u-dev] RFR: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux [v3]
Francisco Ferrari Bihurriet
fferrari at openjdk.org
Tue Dec 3 17:30:46 UTC 2024
On Tue, 3 Dec 2024 16:51:23 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> > Please note that the old PR diff exactly matches the new one:
>
> Yes, understood. But for dependent PRs it's advised to merge master once the dependent PR integrates before actually integrating since the base revision changes and the actual commit might not be right. Not a problem in this case, but still good to merge master. Thanks!
Yes, once the Skara bot changes the base, the PR gets a conflict and the rebase or merge becomes strictly necessary.
Sorry for the confusion, I should have mentioned I was showing the same-diff evidence only to make the re-review process faster after the merge (in case @martinuy was going to re-review, and wanted to rely on his previous review by acknowledging that nothing changed).
-------------
PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1192#issuecomment-2515172037
More information about the jdk-updates-dev
mailing list