[jdk21u-dev] RFR: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file [v2]
Goetz Lindenmaier
goetz at openjdk.org
Fri Dec 13 16:00:57 UTC 2024
> I would like to backport this to make follow-up backports clean.
>
> I checked all files that would not patch clean for predecessors that are candidates for
> backport. The remaining resolves are the following:
>
> test/jdk/tools/jpackage/TEST.properties
> Resolved. Will backport 8314909, which probably makes this clean.
>
> test/jdk/tools/jpackage/share/AppContentTest.java
> One of the removed @modules statements is not in 21. It was added in 24 with 8341443.
>
> test/jdk/tools/jpackage/share/RuntimeImageTest.java
> Trivial resolve
>
> test/jdk/tools/jpackage/share/jdk/jpackage/tests/JLinkOptionsTest.java
> Resolved Copyright. "8308398: Move SunEC crypto provider into java.base" not in 21.
>
> test/jdk/tools/jpackage/windows/WinChildProcessTest.java
> Resolved. "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" not in 21.
>
> Some tests touched by this change are not in 21. Some came with new features,
> but other with bug fixes that are theoretically applicable to 21. Non of these fixes
> qualify for an obvious and simple backport that could be done as prereq of a
> pure test rework. Here the list:
>
>
> test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/DirectoryContentVerifierTest.java
> test/jdk/tools/jpackage/share/InOutPathTest.java
> Both added by "8325089: jpackage utility creates an "infinite", undeleteable directory tree", a bug
> that sounds interesting for 21, 17. But it is big and rather new, so don't backport now.
>
> test/jdk/tools/jpackage/linux/ServiceAndDesktopTest.java
> test/jdk/tools/jpackage/linux/UpgradeTest.java
> Both added by "8301856: Generated .spec file for RPM installers uninstalls desktop launcher
> on update", a bug that sounds interesting for 21, 17. It was published in 22, so it should be
> considered as stable. But it is big and Oracle did not address this yet, so let's not backport.
>
> test/jdk/tools/jpackage/macosx/SigningOptionsTest.java
> Added by "8311877: [macos] Add CLI options to provide signing identity directly to
> codesign and productbuild" in 22. A new feature, no candidate for backport.
>
> test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java
> Added by "8310933: Copying from runtime image to application image should not
> follow symlinks" in 22. Enhancement.
>
> test/jdk/tools/jpackage/windows/WinNoRestartTest.java
> Added by "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" in 24.
Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
- Merge branch 'master' into goetz_backport_8343314
- Backport c33a8f52b613e5eff02f572eda876cbbfc7c22cf
-------------
Changes: https://git.openjdk.org/jdk21u-dev/pull/1221/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1221&range=01
Stats: 278 lines in 80 files changed: 4 ins; 113 del; 161 mod
Patch: https://git.openjdk.org/jdk21u-dev/pull/1221.diff
Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1221/head:pull/1221
PR: https://git.openjdk.org/jdk21u-dev/pull/1221
More information about the jdk-updates-dev
mailing list