[jdk17u-dev] RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop [v2]

[Martin Doerr]

On Mon, 16 Dec 2024 11:23:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 17.0.15-oracle.
>> 
>> Two trivial resolved due to context changes.
>
> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport e203df46faf610e35e2c2510271ad68199f4fa3f

LGTM.

src/hotspot/share/opto/loopnode.hpp line 932:

> 930: #ifdef ASSERT
> 931:   bool only_has_infinite_loops();
> 932: #endif

The original change deletes the empty line, too. That's probably why this backport is not clean.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3123#pullrequestreview-2508490881
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3123#discussion_r1888287355