[jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

[Goetz Lindenmaier]

On Wed, 18 Dec 2024 09:32:17 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [f56a1541](https://github.com/openjdk/jdk/commit/f56a154132f7e66b1b65adfa2aa937119999b14a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by SendaoYan on 14 Oct 2024 and was reviewed by Chen Liang, Severin Gehwolf, Magnus Ihse Bursie and Brian Burkhalter.
>> 
>> The original PR use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly.
>> 
>> Additional testing:
>> 
>> - [x] linux-x64 build at alinux3, and run the test passed.
>> - [x] linux-x64 build at centos7 docker container, and run the test passed.
>> - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command
>> 
>> `libCreationTimeHelper.c` compile test command:
>> 
>> gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c
>> 
>> 
>> Thanks!
>
> Thanks all for the reviews.

Hi @sendaoYan, 
This change breaks our Alpine builds:
asicFileAttributeView/libCreationTimeHelper.c:30:10: fatal error: bits/types.h: No such file or directory
   30 | #include <bits/types.h>
Is it possible that you need a follow-up?  Maybe 8338884?
I remove the fix request label in the meantime.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556521294