[jdk21u-dev] RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v2]
SendaoYan
syan at openjdk.org
Fri Dec 20 10:27:38 UTC 2024
On Fri, 20 Dec 2024 09:57:18 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>>
>> This PR backport [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) together, and this PR fix test bug which cause test fails on some Linux distribution. Change has been verified locally, risk is low.
>>
>> The original PR of [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly.
>>
>> [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) backport is cleanly.
>>
>> Additional testing:
>>
>> - [x] linux-x64 build at alinux3, and run the test passed.
>> - [x] linux-x64 build at centos7 docker container, and run the test passed.
>> - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command
>> - [x] linux-64 compile libCreationTimeHelper.c at `adoptopenjdk/alpine3_build_image docker container` use below command
>>
>> `libCreationTimeHelper.c` compile test command:
>>
>> gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c
>>
>>
>> Thanks!
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> add patch of JDK-8342145.patch
GHA report several failures:
1. `linux-x86-hs / build(release)` fails at `Get JTReg` stage as `wget exited with exit code 4`, seems like infrastructure or environmental issue, it's unrelated to this PR.
2. `linux-x64 / build(release)` same to 1
3. `macos-x64 / build(release)` same to 1
4. `macos-aarch64 / build` fails at `Install toolchain and dependencies` stage as `invalid developer directory`, seems like infrastructure or environmental issue, it's unrelated to this PR.
-------------
PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1068#issuecomment-2556710346
More information about the jdk-updates-dev
mailing list