[jdk21u-dev] Integrated: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
SendaoYan
syan at openjdk.org
Sat Dec 21 08:58:44 UTC 2024
On Sat, 19 Oct 2024 08:00:47 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
>
> This PR backport [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) and [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) together, and this PR fix test bug which cause test fails on some Linux distribution. Change has been verified locally, risk is low.
>
> The original PR of [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) use FFM API to call native library, but we can't use FFM API in jdk21u directly, and the original PR dependency the file `test/lib/native/export.h`, this file not exists in jdk21 repository. So we use JNI instead of FFM API. Before this PR, the file `test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c` and `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java` already exists cause this PR can't backport cleanly.
>
> [JDK-8341881](https://bugs.openjdk.org/browse/JDK-8341881) backport is cleanly.
>
> Additional testing:
>
> - [x] linux-x64 build at alinux3, and run the test passed.
> - [x] linux-x64 build at centos7 docker container, and run the test passed.
> - [x] linux-64 compile libCreationTimeHelper.c at `centos6 docker container(glibc2.12)` by gcc 11.2.0 use below command
> - [x] linux-64 compile libCreationTimeHelper.c at `adoptopenjdk/alpine3_build_image docker container` use below command
>
> `libCreationTimeHelper.c` compile test command:
>
> gcc test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c -Ibuild/linux-x86_64-server-release/jdk/include -I build/linux-x86_64-server-release/jdk/include/linux -c
>
>
> Thanks!
This pull request has now been integrated.
Changeset: c7c7280f
Author: SendaoYan <syan at openjdk.org>
URL: https://git.openjdk.org/jdk21u-dev/commit/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3
Stats: 135 lines in 3 files changed: 116 ins; 8 del; 11 mod
8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
8342145: File libCreationTimeHelper.c compile fails on Alpine
Reviewed-by: sgehwolf, goetz, phh
Backport-of: daa67f45f0c17d4087eb51a708193d6db124b426
-------------
PR: https://git.openjdk.org/jdk21u-dev/pull/1068
More information about the jdk-updates-dev
mailing list