[jdk17u-dev] RFR: 8281234: The -protected option is not always checked in keytool and jarsigner

[Martin Doerr]

On Sun, 22 Dec 2024 10:46:58 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I would like to fix this issue in 17. I think it's important to get this feature rigtht.
> 
> I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean.

test/jdk/sun/security/tools/jarsigner/AutoKeyStore.java line 64:

> 62:                 -J--add-exports -Jjava.base/sun.security.x509=ALL-UNNAMED
> 63:                 -providerClass AutoKeyStore$AutoProvider
> 64:                 -providerPath $test.classes

You changed the code below due to missing "8281175: Add a -providerPath option to jarsigner", but here, there is still "-providerPath".

test/lib/jdk/test/lib/SecurityTools.java line 71:

> 69:                 } else {
> 70:                     launcher.addVMArg(jarg);
> 71:                 }

For which property is this needed? I can't see such code upstream.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3163#discussion_r1895650979
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3163#discussion_r1895663482