[jdk17u-dev] RFR: 8324234: Use reserved IP for java.net testing

Ludovic Henry luhenry at openjdk.org
Sat Feb 3 16:12:07 UTC 2024


On Mon, 22 Jan 2024 08:38:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Some tests like test/jdk/java/net/Socket/B8312065.java use specific IPs (like 192.168.255.255) taking the assumption that the address is not going to be assigned. This doesn't always hold true, as 192.168.255.255 for example is a valid address.
>> 
>> [RFC 5737](https://www.rfc-editor.org/rfc/rfc5737) defines specific ranges of IP addresses that may are reserved for these exact purpose and that will never be assigned. Let's make sure to use an IP in this range, like 192.0.2.1 for example.
>> 
>> The specific test test/jdk/java/net/Socket/B8312065.java was introduced with https://git.openjdk.org/jdk17u-dev/pull/1639.
>
> 2luhenry Reviewi missing. Tests fail. Fix-request comment missing. Removing the tag.
> Why don't you fix this in head?

@GoeLin could you please let me know if it would be good to get this one integrated? I can also disable the test in Adoptium otherwise, but I would much rather fix it here. Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2149#issuecomment-1925369473


More information about the jdk-updates-dev mailing list