[jdk11u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id [v2]

唐佳未 duke at openjdk.org
Tue Feb 6 03:37:57 UTC 2024


On Tue, 30 Jan 2024 09:42:03 GMT, 唐佳未 <duke at openjdk.org> wrote:

>> It isn't a clean backport for two reasons.
>> 1. jdk11 cannot use nullptr, so it should use NULL instead.
>> 2. `parent_thread_group_handle != NULL` will cause a compile error without a type cast. 
>> 
>> This backport prevents a JFR operation from accessing an illegal address which has not be filled before the initialization of a JavaThread, which is created from a JNI interface.
>> 
>> The risk is very low since it only adds a null pointer check. Besides, This backport has be accepted in [jdk17-dev](https://github.com/openjdk/jdk17u-dev/pull/2179).  
>> 
>> Additional testing:
>> - [x] Linux aarch64 server fastdebug, test/jdk/jdk/jfr passed
>
> 唐佳未 has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport a885aab696777c99c8c4c5d9a46afc5fe0a4fe47

Is there any reviewer available to help with the review? Thanks a lot!

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2501#issuecomment-1928724800


More information about the jdk-updates-dev mailing list