[jdk17u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address [v2]
Jaikiran Pai
jpai at openjdk.org
Tue Feb 6 14:39:24 UTC 2024
> Can I please get a review for this change which backports the fix that was done in https://bugs.openjdk.org/browse/JDK-8305906?
>
> The fix in the source is a clean backport. However, the newly introduced test in mainline uses a test specific libraries which aren't the same in 17u. As a result, the tests `test/jdk/java/net/httpclient/http2/ConnectionReuseTest.java` had conflicts. I have manually updated relevant parts of that test to make it use the test libraries that are available and applicable in 17u.
>
> I have also verified that the test fails (as expected) if I undo the source change and passes when I re-introduce the source change. Additionally, I have run this test in our CI to verify that it passes.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
update the test to use ReferenceTracker
-------------
Changes:
- all: https://git.openjdk.org/jdk17u-dev/pull/2121/files
- new: https://git.openjdk.org/jdk17u-dev/pull/2121/files/32bb9368..0fbf00c8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2121&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2121&range=00-01
Stats: 51 lines in 1 file changed: 25 ins; 5 del; 21 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/2121.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2121/head:pull/2121
PR: https://git.openjdk.org/jdk17u-dev/pull/2121
More information about the jdk-updates-dev
mailing list