[jdk17u-dev] RFR: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

psoujany duke at openjdk.org
Thu Feb 8 06:10:57 UTC 2024


On Wed, 7 Feb 2024 16:54:42 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> psoujany has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Backport 783ae56634a3bca23516c22b071d224fec18591f
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 418:
> 
>> 416:                     .setId(HtmlIds.forTabPanel(id))
>> 417:                     .put(HtmlAttr.ROLE, "tabpanel")
>> 418:                     .put(HtmlAttr.ARIA_LABELLEDBY, HtmlIds.forTab(id, tabIndex).name());
> 
> This is not the correct default value for the `aria-labelledby` attribute. In line 405 where it was previously assigned, `tabIndex` has value `0`. However in the `for-in` loop that follows, `tabIndex` is increased and so the generated id refers to the last tab instead of the first. The correct value for the attribute is `HtmlIds.forTab(id, 0).name()`.

Updated tabindex with default Tab. Thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2196#discussion_r1482452195


More information about the jdk-updates-dev mailing list