[jdk21u-dev] RFR: 8320890: [AIX] Find a better way to mimic dl handle equality

[Martin Doerr]

On Fri, 9 Feb 2024 16:42:01 GMT, Joachim Kern <jkern at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [b8ae4a8c](https://github.com/openjdk/jdk/commit/b8ae4a8c0985d1763ac48ba78943d8b992d7be77) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Joachim Kern on 11 Jan 2024 and was reviewed by Thomas Stuefe and Martin Doerr.
> 
> Thanks!

Looks correct, but please minimize diffs to upstream version!

src/hotspot/os/aix/os_aix.cpp line 1132:

> 1130: 
> 1131:   const char* error_report = nullptr;
> 1132:   void * result = Aix_dlopen(filename, dflags, &error_report);

Diff to upstream version should get minimized: `void* result;` is in a separate line here: https://github.com/openjdk/jdk/commit/b8ae4a8c0985d1763ac48ba78943d8b992d7be77

src/hotspot/os/aix/porting_aix.cpp line 1170:

> 1168: 
> 1169:   return res;
> 1170: } // end: os::pd_dll_unload()

Newline diff.

src/hotspot/os/posix/os_posix.cpp line 740:

> 738:   char ebuf[1024];
> 739:   bool res = os::pd_dll_unload(lib, ebuf, sizeof(ebuf));
> 740: 

Empty lines are different than in upstream version.

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/252#pullrequestreview-1873491689
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/252#discussion_r1484998854
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/252#discussion_r1484999021
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/252#discussion_r1484999527