[jdk11u-dev] RFR: 8304725: AsyncGetCallTrace can cause SIGBUS on M1 [v4]
Jaroslav Bachorik
jbachorik at openjdk.org
Sat Feb 10 10:54:08 UTC 2024
On Wed, 7 Feb 2024 18:59:51 GMT, Paul Hohensee <phh at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into backport-parttimenerd-d8af7a60
>> - Replace nullptr with NULL
>> - Fix compilation issue
>> - Merge branch 'openjdk:master' into backport-parttimenerd-d8af7a60
>> - Backport d8af7a6014055295355a1242db6c2872299c6398
>
> The 17u backport didn't remove the call to set_in_asgct() in forte.cpp that's removed here. Perhaps 17u should be fixed?
>
> In none of tip, 21u, or 17u is _in_asgct set false in thread.cpp. Is it really needed in 11u?
@phohensee
In tip, the `_in_asgct` is initialized in-place and non-static data member initializers are not allowed in JDK 11 codebase.
Considering the style of initialization of data members in thread.hpp I would argue that this is necessary and correct.
-------------
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2452#issuecomment-1936971103
More information about the jdk-updates-dev
mailing list