[jdk11u-dev] RFR: 8310923: Refactor Currency tests to use JUnit

Andrew John Hughes andrew at openjdk.org
Mon Feb 12 23:42:04 UTC 2024


On Thu, 8 Feb 2024 12:37:49 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> The github actions tests fail, because the junit code used in this change depends on a recent junit. GHA of 11 use old jtreg 6.1.. With 7.3.1, which contains a more recent junit, the tests would work.

Do we plan to transition 11u to jtreg 7? Doing so has quite a long tail of dependencies: https://bugs.openjdk.org/browse/JDK-8289798

I think this is being backported for [8321480: ISO 4217 Amendment 176 Update](https://github.com/openjdk/jdk17u-dev/commit/223018a3aabc319992d9790fa1d6c88b02fcca9f) because it contains some follow-on unrelated test changes from this patch.  You could do 8321480 without this patch - I think we'll have to in 8u as jtreg 7 needs JDK 11 - but I don't want to do that if we are going to bring this change in, as it will make this change unclean and risk missing the post-8310923 changes in 8321480.

Incidentally, this one is in 11.0.24-oracle, not 11.0.23-oracle.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2503#issuecomment-1939790941


More information about the jdk-updates-dev mailing list