[jdk11u-dev] RFR: 8247818: GCC 10 warning stringop-overflow with symbol code [v2]

[Thomas Stuefe]

On Wed, 14 Feb 2024 16:51:21 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> 11u-dev is tricky to build with GCC 11 and newer. GCC 11 is the default version in current Debian stable (and likely derivatives e.g. Ubuntu, but I have not checked) as well as RHEL 9 (and derivatives, likewise unchecked), so I think it's worthwhile to improve that.
>> 
>> This particular patch addresses one of the obstacles (a warning from GCC 10 onwards). It doesn't apply clean, but cherry-pick conflicts were trivial to resolve. It was backported from 16 to 15 and 13 and seems worthwhile for 11u.
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'jdk11u-dev/master' into 8247818-jdk11u-dev
>  - 8247818: GCC 10 warning stringop-overflow with symbol code
>    
>    Backport-of: ed31b661d35a72948af6cf117cccea2e7537b920

Looks fine.

What I find weird is that the memcpy version does not produce warnings. Since we are doing exactly the same (Symbol is var-sized in the typical C way, by defining a trailing one-byte-array, and gcc does not get it).

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2451#pullrequestreview-1880834959