[jdk17u-dev] RFR: 8314830: runtime/ErrorHandling/ tests ignore external VM flags [v2]

[Matthias Baesken]

On Wed, 7 Feb 2024 09:08:06 GMT, Andrew Lu <andrewlu at openjdk.org> wrote:

>> I backport this for parity with 17.0.11-oracle.
>> 
>> test/hotspot/jtreg/runtime/ErrorHandling/ClassPathEnvVar.java
>> test/hotspot/jtreg/runtime/ErrorHandling/ReattemptErrorTest.java
>> test/hotspot/jtreg/runtime/ErrorHandling/ResourceMarkTest.java
>> test/hotspot/jtreg/runtime/ErrorHandling/TestAbortVmOnException.java
>> test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java
>> these tests are not in 17, skipped, others are clean except Copyright.
>
> Andrew Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update SecondaryErrorTest.java
>   
>   remove the duplicate

Marked as reviewed by mbaesken (Reviewer).

test/hotspot/jtreg/runtime/ErrorHandling/SecondaryErrorTest.java line 31:

> 29:  * @library /test/lib
> 30:  * @requires vm.flagless
> 31:  * @requires vm.flagless

No need to put this twice here, please adjust it.

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2192#pullrequestreview-1867221348
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2192#discussion_r1481099953