[jdk17u-dev] RFR: 8306408: Fix the format of several tables in building.md
Zdenek Zambersky
zzambers at openjdk.org
Mon Feb 19 14:19:56 UTC 2024
On Fri, 16 Feb 2024 16:40:37 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
>> Backport fixing several tables in `doc/building.md`, so they would display correctly in GitHub. Change set applied almost cleanly to `doc/building.md` (only last table has one more target in original changeset). File `doc/building.html` was regenerated.
>
> `building.md` changes look fine.
> How was the HTML re-generated? I'm seeing some unrelated changes which I guess may be down to the tool version used?
> ~~~~
> +@@ -11,14 +11,14 @@
> + span.underline{text-decoration: underline;}
> + div.column{display: inline-block; vertical-align: top; width: 50%;}
> + </style>
> +- <link rel="stylesheet" href="../make/data/docs-resources/resources/jdk-default.css" />
> ++ <link rel="stylesheet" href="../make/data/docs-resources/resources/jdk-default.css">
> +
> + <style type="text/css">pre, code, tt { color: #1d6ae5; }</style>
> + </head>
> + <body>
> +-<header id="title-block-header">
> ++<header>
> + <h1 class="title">Building the JDK</h1>
> + </header>
> + <nav id="TOC">
> ~~~~
@gnu-andrew I have tried on few more systems, but pandoc from rhel-8 is closest to orignal generator I could get.
- [output of newer pandoc on f38](https://github.com/zzambers/jdk17u-dev/commit/tables-fix-f38) (2.19.2-21.fc38) or even ubuntu-20.04 (2.5-3build2) were much more different
- output of older pandoc on rhel-7 (1.12.3.1-2.el7) was also much more different
Unfortunately generated html does not include information about pandoc used. Rhel-8's pandoc (2.0.6-6.el8_6) seems pretty close.
-------------
PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2205#issuecomment-1952543872
More information about the jdk-updates-dev
mailing list