[jdk11u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update

Goetz Lindenmaier goetz at openjdk.org
Thu Feb 22 08:14:56 UTC 2024


On Tue, 20 Feb 2024 00:16:56 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Hi all,
> 
>  This pull request contains a backport of commit [223018a3](https://github.com/openjdk/jdk17u-dev/commit/223018a3aabc319992d9790fa1d6c88b02fcca9f) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository.
> 
>  The commit being backported was authored by Andrew Lu on 6 Feb 2024 and was reviewed by Matthias Baesken.
> 
> The changes are mostly clean. The differences are a different copyright header in `make/jdk/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java` and the absent refactoring of `test/jdk/java/util/Currency/ValidateISO4217.java b/test/jdk/java/util/Currency/ValidateISO4217.java`
> 
> As discussed on #2503, bringing in the refactoring also requires bumping JTreg, which in turn requires fixes to a number of other tests. To get this update in for 11.0.23 before rampdown, I think we can make the same code addition in `ValidateISO4217.java` (with different alignment) and defer the change to `twoLetterCodesTest` to JDK-8310923 on #2503.
> 
> The `java.util.Currency` tests all pass with this change.

LGTM. Also passed SAP's testing.

-------------

Marked as reviewed by goetz (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2532#pullrequestreview-1895182785


More information about the jdk-updates-dev mailing list